blob: f16a6d41347914986e6e9156c464efa64a069380 [file] [log] [blame]
Paul Bakker33b43f12013-08-20 11:48:36 +02001/* BEGIN_HEADER */
Manuel Pégourié-Gonnard7f809972015-03-09 17:05:11 +00002#include "mbedtls/ecdsa.h"
Paul Bakker33b43f12013-08-20 11:48:36 +02003/* END_HEADER */
Manuel Pégourié-Gonnardd1c71502013-01-26 19:09:07 +01004
Paul Bakker33b43f12013-08-20 11:48:36 +02005/* BEGIN_DEPENDENCIES
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02006 * depends_on:MBEDTLS_ECDSA_C
Paul Bakker33b43f12013-08-20 11:48:36 +02007 * END_DEPENDENCIES
8 */
Manuel Pégourié-Gonnardd1c71502013-01-26 19:09:07 +01009
Paul Bakker33b43f12013-08-20 11:48:36 +020010/* BEGIN_CASE */
Gilles Peskine449bd832023-01-11 14:50:10 +010011void ecdsa_prim_zero(int id)
Manuel Pégourié-Gonnardd1c71502013-01-26 19:09:07 +010012{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +020013 mbedtls_ecp_group grp;
14 mbedtls_ecp_point Q;
15 mbedtls_mpi d, r, s;
Ronald Cron351f0ee2020-06-10 12:12:18 +020016 mbedtls_test_rnd_pseudo_info rnd_info;
Manuel Pégourié-Gonnard88579842023-03-28 11:20:23 +020017 unsigned char buf[MBEDTLS_MD_MAX_SIZE];
Manuel Pégourié-Gonnardd1c71502013-01-26 19:09:07 +010018
Gilles Peskine449bd832023-01-11 14:50:10 +010019 mbedtls_ecp_group_init(&grp);
20 mbedtls_ecp_point_init(&Q);
21 mbedtls_mpi_init(&d); mbedtls_mpi_init(&r); mbedtls_mpi_init(&s);
22 memset(&rnd_info, 0x00, sizeof(mbedtls_test_rnd_pseudo_info));
23 memset(buf, 0, sizeof(buf));
Manuel Pégourié-Gonnardd1c71502013-01-26 19:09:07 +010024
Gilles Peskine449bd832023-01-11 14:50:10 +010025 TEST_ASSERT(mbedtls_ecp_group_load(&grp, id) == 0);
26 TEST_ASSERT(mbedtls_ecp_gen_keypair(&grp, &d, &Q,
27 &mbedtls_test_rnd_pseudo_rand,
28 &rnd_info) == 0);
Manuel Pégourié-Gonnardd1c71502013-01-26 19:09:07 +010029
Gilles Peskine449bd832023-01-11 14:50:10 +010030 TEST_ASSERT(mbedtls_ecdsa_sign(&grp, &r, &s, &d, buf, sizeof(buf),
31 &mbedtls_test_rnd_pseudo_rand,
32 &rnd_info) == 0);
33 TEST_ASSERT(mbedtls_ecdsa_verify(&grp, buf, sizeof(buf), &Q, &r, &s) == 0);
TRodziewicz5feb6702021-04-06 19:55:17 +020034
TRodziewicz40de3c92021-04-07 19:16:18 +020035exit:
Gilles Peskine449bd832023-01-11 14:50:10 +010036 mbedtls_ecp_group_free(&grp);
37 mbedtls_ecp_point_free(&Q);
38 mbedtls_mpi_free(&d); mbedtls_mpi_free(&r); mbedtls_mpi_free(&s);
TRodziewicz40de3c92021-04-07 19:16:18 +020039}
40/* END_CASE */
41
42/* BEGIN_CASE */
Gilles Peskine449bd832023-01-11 14:50:10 +010043void ecdsa_prim_random(int id)
TRodziewicz40de3c92021-04-07 19:16:18 +020044{
45 mbedtls_ecp_group grp;
46 mbedtls_ecp_point Q;
47 mbedtls_mpi d, r, s;
48 mbedtls_test_rnd_pseudo_info rnd_info;
Manuel Pégourié-Gonnard88579842023-03-28 11:20:23 +020049 unsigned char buf[MBEDTLS_MD_MAX_SIZE];
TRodziewicz40de3c92021-04-07 19:16:18 +020050
Gilles Peskine449bd832023-01-11 14:50:10 +010051 mbedtls_ecp_group_init(&grp);
52 mbedtls_ecp_point_init(&Q);
53 mbedtls_mpi_init(&d); mbedtls_mpi_init(&r); mbedtls_mpi_init(&s);
54 memset(&rnd_info, 0x00, sizeof(mbedtls_test_rnd_pseudo_info));
55 memset(buf, 0, sizeof(buf));
TRodziewicz40de3c92021-04-07 19:16:18 +020056
57 /* prepare material for signature */
Gilles Peskine449bd832023-01-11 14:50:10 +010058 TEST_ASSERT(mbedtls_test_rnd_pseudo_rand(&rnd_info,
59 buf, sizeof(buf)) == 0);
60 TEST_ASSERT(mbedtls_ecp_group_load(&grp, id) == 0);
61 TEST_ASSERT(mbedtls_ecp_gen_keypair(&grp, &d, &Q,
62 &mbedtls_test_rnd_pseudo_rand,
63 &rnd_info) == 0);
TRodziewicz40de3c92021-04-07 19:16:18 +020064
Gilles Peskine449bd832023-01-11 14:50:10 +010065 TEST_ASSERT(mbedtls_ecdsa_sign(&grp, &r, &s, &d, buf, sizeof(buf),
66 &mbedtls_test_rnd_pseudo_rand,
67 &rnd_info) == 0);
68 TEST_ASSERT(mbedtls_ecdsa_verify(&grp, buf, sizeof(buf), &Q, &r, &s) == 0);
Manuel Pégourié-Gonnardd1c71502013-01-26 19:09:07 +010069
Paul Bakkerbd51b262014-07-10 15:26:12 +020070exit:
Gilles Peskine449bd832023-01-11 14:50:10 +010071 mbedtls_ecp_group_free(&grp);
72 mbedtls_ecp_point_free(&Q);
73 mbedtls_mpi_free(&d); mbedtls_mpi_free(&r); mbedtls_mpi_free(&s);
Manuel Pégourié-Gonnardd1c71502013-01-26 19:09:07 +010074}
Paul Bakker33b43f12013-08-20 11:48:36 +020075/* END_CASE */
Manuel Pégourié-Gonnard602a8972013-01-27 08:10:28 +010076
Paul Bakker33b43f12013-08-20 11:48:36 +020077/* BEGIN_CASE */
Gilles Peskine449bd832023-01-11 14:50:10 +010078void ecdsa_prim_test_vectors(int id, char *d_str, char *xQ_str,
79 char *yQ_str, data_t *rnd_buf,
80 data_t *hash, char *r_str, char *s_str,
81 int result)
Manuel Pégourié-Gonnard602a8972013-01-27 08:10:28 +010082{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +020083 mbedtls_ecp_group grp;
84 mbedtls_ecp_point Q;
Manuel Pégourié-Gonnardec528932022-04-21 09:25:23 +020085 mbedtls_mpi d, r, s, r_check, s_check, zero;
Ronald Cron351f0ee2020-06-10 12:12:18 +020086 mbedtls_test_rnd_buf_info rnd_info;
Manuel Pégourié-Gonnard602a8972013-01-27 08:10:28 +010087
Gilles Peskine449bd832023-01-11 14:50:10 +010088 mbedtls_ecp_group_init(&grp);
89 mbedtls_ecp_point_init(&Q);
90 mbedtls_mpi_init(&d); mbedtls_mpi_init(&r); mbedtls_mpi_init(&s);
91 mbedtls_mpi_init(&r_check); mbedtls_mpi_init(&s_check);
92 mbedtls_mpi_init(&zero);
Manuel Pégourié-Gonnard602a8972013-01-27 08:10:28 +010093
Gilles Peskine449bd832023-01-11 14:50:10 +010094 TEST_ASSERT(mbedtls_ecp_group_load(&grp, id) == 0);
95 TEST_ASSERT(mbedtls_ecp_point_read_string(&Q, 16, xQ_str, yQ_str) == 0);
96 TEST_ASSERT(mbedtls_test_read_mpi(&d, d_str) == 0);
97 TEST_ASSERT(mbedtls_test_read_mpi(&r_check, r_str) == 0);
98 TEST_ASSERT(mbedtls_test_read_mpi(&s_check, s_str) == 0);
Gilles Peskineecacc3c2021-03-24 00:48:57 +010099 rnd_info.fallback_f_rng = mbedtls_test_rnd_std_rand;
100 rnd_info.fallback_p_rng = NULL;
Azim Khand30ca132017-06-09 04:32:58 +0100101 rnd_info.buf = rnd_buf->x;
102 rnd_info.length = rnd_buf->len;
Manuel Pégourié-Gonnard602a8972013-01-27 08:10:28 +0100103
Azim Khand30ca132017-06-09 04:32:58 +0100104 /* Fix rnd_buf->x by shifting it left if necessary */
Gilles Peskine449bd832023-01-11 14:50:10 +0100105 if (grp.nbits % 8 != 0) {
106 unsigned char shift = 8 - (grp.nbits % 8);
Manuel Pégourié-Gonnardfae079e2014-01-06 11:00:07 +0100107 size_t i;
108
Gilles Peskine449bd832023-01-11 14:50:10 +0100109 for (i = 0; i < rnd_info.length - 1; i++) {
110 rnd_buf->x[i] = rnd_buf->x[i] << shift | rnd_buf->x[i+1] >> (8 - shift);
111 }
Manuel Pégourié-Gonnardfae079e2014-01-06 11:00:07 +0100112
Azim Khand30ca132017-06-09 04:32:58 +0100113 rnd_buf->x[rnd_info.length-1] <<= shift;
Manuel Pégourié-Gonnardfae079e2014-01-06 11:00:07 +0100114 }
115
Gilles Peskine449bd832023-01-11 14:50:10 +0100116 TEST_ASSERT(mbedtls_ecdsa_sign(&grp, &r, &s, &d, hash->x, hash->len,
117 mbedtls_test_rnd_buffer_rand, &rnd_info) == result);
Manuel Pégourié-Gonnard602a8972013-01-27 08:10:28 +0100118
Gilles Peskine449bd832023-01-11 14:50:10 +0100119 if (result == 0) {
Manuel Pégourié-Gonnardec528932022-04-21 09:25:23 +0200120 /* Check we generated the expected values */
Gilles Peskine449bd832023-01-11 14:50:10 +0100121 TEST_EQUAL(mbedtls_mpi_cmp_mpi(&r, &r_check), 0);
122 TEST_EQUAL(mbedtls_mpi_cmp_mpi(&s, &s_check), 0);
Manuel Pégourié-Gonnard602a8972013-01-27 08:10:28 +0100123
Manuel Pégourié-Gonnardd8d19de2022-04-20 10:34:22 +0200124 /* Valid signature */
Gilles Peskine449bd832023-01-11 14:50:10 +0100125 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len,
126 &Q, &r_check, &s_check), 0);
Manuel Pégourié-Gonnardd0a66cc2018-06-13 09:53:21 +0200127
Manuel Pégourié-Gonnardd8d19de2022-04-20 10:34:22 +0200128 /* Invalid signature: wrong public key (G instead of Q) */
Gilles Peskine449bd832023-01-11 14:50:10 +0100129 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len,
130 &grp.G, &r_check, &s_check), MBEDTLS_ERR_ECP_VERIFY_FAILED);
Manuel Pégourié-Gonnardd0a66cc2018-06-13 09:53:21 +0200131
Manuel Pégourié-Gonnardd8d19de2022-04-20 10:34:22 +0200132 /* Invalid signatures: r or s or both one off */
Gilles Peskine449bd832023-01-11 14:50:10 +0100133 TEST_EQUAL(mbedtls_mpi_sub_int(&r, &r_check, 1), 0);
134 TEST_EQUAL(mbedtls_mpi_add_int(&s, &s_check, 1), 0);
Manuel Pégourié-Gonnardd8d19de2022-04-20 10:34:22 +0200135
Gilles Peskine449bd832023-01-11 14:50:10 +0100136 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
137 &r, &s_check), MBEDTLS_ERR_ECP_VERIFY_FAILED);
138 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
139 &r_check, &s), MBEDTLS_ERR_ECP_VERIFY_FAILED);
140 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
141 &r, &s), MBEDTLS_ERR_ECP_VERIFY_FAILED);
Manuel Pégourié-Gonnardd8d19de2022-04-20 10:34:22 +0200142
143 /* Invalid signatures: r, s or both (CVE-2022-21449) are zero */
Gilles Peskine449bd832023-01-11 14:50:10 +0100144 TEST_EQUAL(mbedtls_mpi_lset(&zero, 0), 0);
Manuel Pégourié-Gonnardd8d19de2022-04-20 10:34:22 +0200145
Gilles Peskine449bd832023-01-11 14:50:10 +0100146 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
147 &zero, &s_check), MBEDTLS_ERR_ECP_VERIFY_FAILED);
148 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
149 &r_check, &zero), MBEDTLS_ERR_ECP_VERIFY_FAILED);
150 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
151 &zero, &zero), MBEDTLS_ERR_ECP_VERIFY_FAILED);
Manuel Pégourié-Gonnardd8d19de2022-04-20 10:34:22 +0200152
153 /* Invalid signatures: r, s or both are == N */
Gilles Peskine449bd832023-01-11 14:50:10 +0100154 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
155 &grp.N, &s_check), MBEDTLS_ERR_ECP_VERIFY_FAILED);
156 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
157 &r_check, &grp.N), MBEDTLS_ERR_ECP_VERIFY_FAILED);
158 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
159 &grp.N, &grp.N), MBEDTLS_ERR_ECP_VERIFY_FAILED);
Manuel Pégourié-Gonnardec528932022-04-21 09:25:23 +0200160
161 /* Invalid signatures: r, s or both are negative */
Gilles Peskine449bd832023-01-11 14:50:10 +0100162 TEST_EQUAL(mbedtls_mpi_sub_mpi(&r, &r_check, &grp.N), 0);
163 TEST_EQUAL(mbedtls_mpi_sub_mpi(&s, &s_check, &grp.N), 0);
Manuel Pégourié-Gonnardd8d19de2022-04-20 10:34:22 +0200164
Gilles Peskine449bd832023-01-11 14:50:10 +0100165 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
166 &r, &s_check), MBEDTLS_ERR_ECP_VERIFY_FAILED);
167 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
168 &r_check, &s), MBEDTLS_ERR_ECP_VERIFY_FAILED);
169 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
170 &r, &s), MBEDTLS_ERR_ECP_VERIFY_FAILED);
Manuel Pégourié-Gonnardd8d19de2022-04-20 10:34:22 +0200171
172 /* Invalid signatures: r or s or both are > N */
Gilles Peskine449bd832023-01-11 14:50:10 +0100173 TEST_EQUAL(mbedtls_mpi_add_mpi(&r, &r_check, &grp.N), 0);
174 TEST_EQUAL(mbedtls_mpi_add_mpi(&s, &s_check, &grp.N), 0);
Manuel Pégourié-Gonnardd8d19de2022-04-20 10:34:22 +0200175
Gilles Peskine449bd832023-01-11 14:50:10 +0100176 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
177 &r, &s_check), MBEDTLS_ERR_ECP_VERIFY_FAILED);
178 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
179 &r_check, &s), MBEDTLS_ERR_ECP_VERIFY_FAILED);
180 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
181 &r, &s), MBEDTLS_ERR_ECP_VERIFY_FAILED);
Darryl Greenf5bcbed2017-11-17 17:09:31 +0000182 }
Manuel Pégourié-Gonnard602a8972013-01-27 08:10:28 +0100183
Paul Bakkerbd51b262014-07-10 15:26:12 +0200184exit:
Gilles Peskine449bd832023-01-11 14:50:10 +0100185 mbedtls_ecp_group_free(&grp);
186 mbedtls_ecp_point_free(&Q);
187 mbedtls_mpi_free(&d); mbedtls_mpi_free(&r); mbedtls_mpi_free(&s);
188 mbedtls_mpi_free(&r_check); mbedtls_mpi_free(&s_check);
189 mbedtls_mpi_free(&zero);
Manuel Pégourié-Gonnard602a8972013-01-27 08:10:28 +0100190}
Paul Bakker33b43f12013-08-20 11:48:36 +0200191/* END_CASE */
Manuel Pégourié-Gonnardb694b482013-08-08 13:30:57 +0200192
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200193/* BEGIN_CASE depends_on:MBEDTLS_ECDSA_DETERMINISTIC */
Gilles Peskine449bd832023-01-11 14:50:10 +0100194void ecdsa_det_test_vectors(int id, char *d_str, int md_alg, data_t *hash,
195 char *r_str, char *s_str)
Manuel Pégourié-Gonnard4daaef72014-01-06 14:25:56 +0100196{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200197 mbedtls_ecp_group grp;
198 mbedtls_mpi d, r, s, r_check, s_check;
Manuel Pégourié-Gonnard4daaef72014-01-06 14:25:56 +0100199
Manuel Pégourié-Gonnardebef58d2023-03-16 12:48:24 +0100200 MD_PSA_INIT();
201
Gilles Peskine449bd832023-01-11 14:50:10 +0100202 mbedtls_ecp_group_init(&grp);
203 mbedtls_mpi_init(&d); mbedtls_mpi_init(&r); mbedtls_mpi_init(&s);
204 mbedtls_mpi_init(&r_check); mbedtls_mpi_init(&s_check);
Manuel Pégourié-Gonnard4daaef72014-01-06 14:25:56 +0100205
Gilles Peskine449bd832023-01-11 14:50:10 +0100206 TEST_ASSERT(mbedtls_ecp_group_load(&grp, id) == 0);
207 TEST_ASSERT(mbedtls_test_read_mpi(&d, d_str) == 0);
208 TEST_ASSERT(mbedtls_test_read_mpi(&r_check, r_str) == 0);
209 TEST_ASSERT(mbedtls_test_read_mpi(&s_check, s_str) == 0);
Manuel Pégourié-Gonnard4daaef72014-01-06 14:25:56 +0100210
Janos Follath651eac82019-01-04 15:51:24 +0000211 TEST_ASSERT(
Gilles Peskine449bd832023-01-11 14:50:10 +0100212 mbedtls_ecdsa_sign_det_ext(&grp, &r, &s, &d,
213 hash->x, hash->len, md_alg,
214 mbedtls_test_rnd_std_rand,
215 NULL)
216 == 0);
Manuel Pégourié-Gonnard4daaef72014-01-06 14:25:56 +0100217
Gilles Peskine449bd832023-01-11 14:50:10 +0100218 TEST_ASSERT(mbedtls_mpi_cmp_mpi(&r, &r_check) == 0);
219 TEST_ASSERT(mbedtls_mpi_cmp_mpi(&s, &s_check) == 0);
Manuel Pégourié-Gonnard4daaef72014-01-06 14:25:56 +0100220
Paul Bakkerbd51b262014-07-10 15:26:12 +0200221exit:
Gilles Peskine449bd832023-01-11 14:50:10 +0100222 mbedtls_ecp_group_free(&grp);
223 mbedtls_mpi_free(&d); mbedtls_mpi_free(&r); mbedtls_mpi_free(&s);
224 mbedtls_mpi_free(&r_check); mbedtls_mpi_free(&s_check);
Manuel Pégourié-Gonnardebef58d2023-03-16 12:48:24 +0100225 MD_PSA_DONE();
Manuel Pégourié-Gonnard4daaef72014-01-06 14:25:56 +0100226}
227/* END_CASE */
228
Manuel Pégourié-Gonnardebef58d2023-03-16 12:48:24 +0100229/* BEGIN_CASE depends_on:MBEDTLS_MD_CAN_SHA256 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100230void ecdsa_write_read_zero(int id)
TRodziewicz40de3c92021-04-07 19:16:18 +0200231{
232 mbedtls_ecdsa_context ctx;
233 mbedtls_test_rnd_pseudo_info rnd_info;
234 unsigned char hash[32];
235 unsigned char sig[200];
236 size_t sig_len, i;
237
Manuel Pégourié-Gonnard91cc8bb2023-03-20 11:02:12 +0100238 MD_PSA_INIT();
239
Gilles Peskine449bd832023-01-11 14:50:10 +0100240 mbedtls_ecdsa_init(&ctx);
241 memset(&rnd_info, 0x00, sizeof(mbedtls_test_rnd_pseudo_info));
242 memset(hash, 0, sizeof(hash));
243 memset(sig, 0x2a, sizeof(sig));
TRodziewicz40de3c92021-04-07 19:16:18 +0200244
245 /* generate signing key */
Gilles Peskine449bd832023-01-11 14:50:10 +0100246 TEST_ASSERT(mbedtls_ecdsa_genkey(&ctx, id,
247 &mbedtls_test_rnd_pseudo_rand,
248 &rnd_info) == 0);
TRodziewicz40de3c92021-04-07 19:16:18 +0200249
250 /* generate and write signature, then read and verify it */
Gilles Peskine449bd832023-01-11 14:50:10 +0100251 TEST_ASSERT(mbedtls_ecdsa_write_signature(&ctx, MBEDTLS_MD_SHA256,
252 hash, sizeof(hash),
253 sig, sizeof(sig), &sig_len,
254 &mbedtls_test_rnd_pseudo_rand,
255 &rnd_info) == 0);
256 TEST_ASSERT(mbedtls_ecdsa_read_signature(&ctx, hash, sizeof(hash),
257 sig, sig_len) == 0);
TRodziewicz40de3c92021-04-07 19:16:18 +0200258
259 /* check we didn't write past the announced length */
Gilles Peskine449bd832023-01-11 14:50:10 +0100260 for (i = sig_len; i < sizeof(sig); i++) {
261 TEST_ASSERT(sig[i] == 0x2a);
262 }
TRodziewicz40de3c92021-04-07 19:16:18 +0200263
264 /* try verification with invalid length */
Gilles Peskine449bd832023-01-11 14:50:10 +0100265 TEST_ASSERT(mbedtls_ecdsa_read_signature(&ctx, hash, sizeof(hash),
266 sig, sig_len - 1) != 0);
267 TEST_ASSERT(mbedtls_ecdsa_read_signature(&ctx, hash, sizeof(hash),
268 sig, sig_len + 1) != 0);
TRodziewicz40de3c92021-04-07 19:16:18 +0200269
270 /* try invalid sequence tag */
271 sig[0]++;
Gilles Peskine449bd832023-01-11 14:50:10 +0100272 TEST_ASSERT(mbedtls_ecdsa_read_signature(&ctx, hash, sizeof(hash),
273 sig, sig_len) != 0);
TRodziewicz40de3c92021-04-07 19:16:18 +0200274 sig[0]--;
275
276 /* try modifying r */
277 sig[10]++;
Gilles Peskine449bd832023-01-11 14:50:10 +0100278 TEST_ASSERT(mbedtls_ecdsa_read_signature(&ctx, hash, sizeof(hash),
279 sig, sig_len) == MBEDTLS_ERR_ECP_VERIFY_FAILED);
TRodziewicz40de3c92021-04-07 19:16:18 +0200280 sig[10]--;
281
282 /* try modifying s */
283 sig[sig_len - 1]++;
Gilles Peskine449bd832023-01-11 14:50:10 +0100284 TEST_ASSERT(mbedtls_ecdsa_read_signature(&ctx, hash, sizeof(hash),
285 sig, sig_len) == MBEDTLS_ERR_ECP_VERIFY_FAILED);
TRodziewicz40de3c92021-04-07 19:16:18 +0200286 sig[sig_len - 1]--;
287
288exit:
Gilles Peskine449bd832023-01-11 14:50:10 +0100289 mbedtls_ecdsa_free(&ctx);
Manuel Pégourié-Gonnard91cc8bb2023-03-20 11:02:12 +0100290 MD_PSA_DONE();
TRodziewicz40de3c92021-04-07 19:16:18 +0200291}
292/* END_CASE */
293
Manuel Pégourié-Gonnardebef58d2023-03-16 12:48:24 +0100294/* BEGIN_CASE depends_on:MBEDTLS_MD_CAN_SHA256 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100295void ecdsa_write_read_random(int id)
Manuel Pégourié-Gonnardb694b482013-08-08 13:30:57 +0200296{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200297 mbedtls_ecdsa_context ctx;
Ronald Cron351f0ee2020-06-10 12:12:18 +0200298 mbedtls_test_rnd_pseudo_info rnd_info;
Manuel Pégourié-Gonnarddfdcac92015-03-31 11:41:42 +0200299 unsigned char hash[32];
Manuel Pégourié-Gonnardb694b482013-08-08 13:30:57 +0200300 unsigned char sig[200];
301 size_t sig_len, i;
302
Manuel Pégourié-Gonnard91cc8bb2023-03-20 11:02:12 +0100303 MD_PSA_INIT();
304
Gilles Peskine449bd832023-01-11 14:50:10 +0100305 mbedtls_ecdsa_init(&ctx);
306 memset(&rnd_info, 0x00, sizeof(mbedtls_test_rnd_pseudo_info));
307 memset(hash, 0, sizeof(hash));
308 memset(sig, 0x2a, sizeof(sig));
Manuel Pégourié-Gonnardb694b482013-08-08 13:30:57 +0200309
TRodziewicz40de3c92021-04-07 19:16:18 +0200310 /* prepare material for signature */
Gilles Peskine449bd832023-01-11 14:50:10 +0100311 TEST_ASSERT(mbedtls_test_rnd_pseudo_rand(&rnd_info,
312 hash, sizeof(hash)) == 0);
Manuel Pégourié-Gonnardb694b482013-08-08 13:30:57 +0200313
TRodziewicz40de3c92021-04-07 19:16:18 +0200314 /* generate signing key */
Gilles Peskine449bd832023-01-11 14:50:10 +0100315 TEST_ASSERT(mbedtls_ecdsa_genkey(&ctx, id,
316 &mbedtls_test_rnd_pseudo_rand,
317 &rnd_info) == 0);
Manuel Pégourié-Gonnardb694b482013-08-08 13:30:57 +0200318
TRodziewicz40de3c92021-04-07 19:16:18 +0200319 /* generate and write signature, then read and verify it */
Gilles Peskine449bd832023-01-11 14:50:10 +0100320 TEST_ASSERT(mbedtls_ecdsa_write_signature(&ctx, MBEDTLS_MD_SHA256,
321 hash, sizeof(hash),
322 sig, sizeof(sig), &sig_len,
323 &mbedtls_test_rnd_pseudo_rand,
324 &rnd_info) == 0);
325 TEST_ASSERT(mbedtls_ecdsa_read_signature(&ctx, hash, sizeof(hash),
326 sig, sig_len) == 0);
Manuel Pégourié-Gonnardb694b482013-08-08 13:30:57 +0200327
TRodziewicz40de3c92021-04-07 19:16:18 +0200328 /* check we didn't write past the announced length */
Gilles Peskine449bd832023-01-11 14:50:10 +0100329 for (i = sig_len; i < sizeof(sig); i++) {
330 TEST_ASSERT(sig[i] == 0x2a);
331 }
Manuel Pégourié-Gonnardb694b482013-08-08 13:30:57 +0200332
TRodziewicz40de3c92021-04-07 19:16:18 +0200333 /* try verification with invalid length */
Gilles Peskine449bd832023-01-11 14:50:10 +0100334 TEST_ASSERT(mbedtls_ecdsa_read_signature(&ctx, hash, sizeof(hash),
335 sig, sig_len - 1) != 0);
336 TEST_ASSERT(mbedtls_ecdsa_read_signature(&ctx, hash, sizeof(hash),
337 sig, sig_len + 1) != 0);
Manuel Pégourié-Gonnardb694b482013-08-08 13:30:57 +0200338
TRodziewicz40de3c92021-04-07 19:16:18 +0200339 /* try invalid sequence tag */
340 sig[0]++;
Gilles Peskine449bd832023-01-11 14:50:10 +0100341 TEST_ASSERT(mbedtls_ecdsa_read_signature(&ctx, hash, sizeof(hash),
342 sig, sig_len) != 0);
TRodziewicz40de3c92021-04-07 19:16:18 +0200343 sig[0]--;
Manuel Pégourié-Gonnardb694b482013-08-08 13:30:57 +0200344
TRodziewicz40de3c92021-04-07 19:16:18 +0200345 /* try modifying r */
346 sig[10]++;
Gilles Peskine449bd832023-01-11 14:50:10 +0100347 TEST_ASSERT(mbedtls_ecdsa_read_signature(&ctx, hash, sizeof(hash),
348 sig, sig_len) == MBEDTLS_ERR_ECP_VERIFY_FAILED);
TRodziewicz40de3c92021-04-07 19:16:18 +0200349 sig[10]--;
Manuel Pégourié-Gonnardb694b482013-08-08 13:30:57 +0200350
TRodziewicz40de3c92021-04-07 19:16:18 +0200351 /* try modifying s */
352 sig[sig_len - 1]++;
Gilles Peskine449bd832023-01-11 14:50:10 +0100353 TEST_ASSERT(mbedtls_ecdsa_read_signature(&ctx, hash, sizeof(hash),
354 sig, sig_len) == MBEDTLS_ERR_ECP_VERIFY_FAILED);
TRodziewicz40de3c92021-04-07 19:16:18 +0200355 sig[sig_len - 1]--;
Manuel Pégourié-Gonnardb694b482013-08-08 13:30:57 +0200356
Paul Bakkerbd51b262014-07-10 15:26:12 +0200357exit:
Gilles Peskine449bd832023-01-11 14:50:10 +0100358 mbedtls_ecdsa_free(&ctx);
Manuel Pégourié-Gonnard91cc8bb2023-03-20 11:02:12 +0100359 MD_PSA_DONE();
Manuel Pégourié-Gonnardb694b482013-08-08 13:30:57 +0200360}
361/* END_CASE */
Manuel Pégourié-Gonnard937340b2014-01-06 10:27:16 +0100362
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200363/* BEGIN_CASE depends_on:MBEDTLS_ECP_RESTARTABLE */
Gilles Peskine449bd832023-01-11 14:50:10 +0100364void ecdsa_read_restart(int id, data_t *pk, data_t *hash, data_t *sig,
365 int max_ops, int min_restart, int max_restart)
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200366{
367 mbedtls_ecdsa_context ctx;
368 mbedtls_ecdsa_restart_ctx rs_ctx;
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200369 int ret, cnt_restart;
370
Gilles Peskine449bd832023-01-11 14:50:10 +0100371 mbedtls_ecdsa_init(&ctx);
372 mbedtls_ecdsa_restart_init(&rs_ctx);
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200373
Gilles Peskine449bd832023-01-11 14:50:10 +0100374 TEST_ASSERT(mbedtls_ecp_group_load(&ctx.grp, id) == 0);
375 TEST_ASSERT(mbedtls_ecp_point_read_binary(&ctx.grp, &ctx.Q,
376 pk->x, pk->len) == 0);
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200377
Gilles Peskine449bd832023-01-11 14:50:10 +0100378 mbedtls_ecp_set_max_ops(max_ops);
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200379
380 cnt_restart = 0;
381 do {
Gilles Peskine449bd832023-01-11 14:50:10 +0100382 ret = mbedtls_ecdsa_read_signature_restartable(&ctx,
383 hash->x, hash->len, sig->x, sig->len,
384 &rs_ctx);
385 } while (ret == MBEDTLS_ERR_ECP_IN_PROGRESS && ++cnt_restart);
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200386
Gilles Peskine449bd832023-01-11 14:50:10 +0100387 TEST_ASSERT(ret == 0);
388 TEST_ASSERT(cnt_restart >= min_restart);
389 TEST_ASSERT(cnt_restart <= max_restart);
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200390
391 /* try modifying r */
Ronald Cron9ed40732020-06-25 09:03:34 +0200392
Gilles Peskine449bd832023-01-11 14:50:10 +0100393 TEST_ASSERT(sig->len > 10);
Ronald Cron9ed40732020-06-25 09:03:34 +0200394 sig->x[10]++;
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200395 do {
Gilles Peskine449bd832023-01-11 14:50:10 +0100396 ret = mbedtls_ecdsa_read_signature_restartable(&ctx,
397 hash->x, hash->len, sig->x, sig->len,
398 &rs_ctx);
399 } while (ret == MBEDTLS_ERR_ECP_IN_PROGRESS);
400 TEST_ASSERT(ret == MBEDTLS_ERR_ECP_VERIFY_FAILED);
Ronald Cron9ed40732020-06-25 09:03:34 +0200401 sig->x[10]--;
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200402
403 /* try modifying s */
Ronald Cron9ed40732020-06-25 09:03:34 +0200404 sig->x[sig->len - 1]++;
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200405 do {
Gilles Peskine449bd832023-01-11 14:50:10 +0100406 ret = mbedtls_ecdsa_read_signature_restartable(&ctx,
407 hash->x, hash->len, sig->x, sig->len,
408 &rs_ctx);
409 } while (ret == MBEDTLS_ERR_ECP_IN_PROGRESS);
410 TEST_ASSERT(ret == MBEDTLS_ERR_ECP_VERIFY_FAILED);
Ronald Cron9ed40732020-06-25 09:03:34 +0200411 sig->x[sig->len - 1]--;
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200412
Manuel Pégourié-Gonnard46ba7f32017-08-28 12:20:39 +0200413 /* Do we leak memory when aborting an operation?
414 * This test only makes sense when we actually restart */
Gilles Peskine449bd832023-01-11 14:50:10 +0100415 if (min_restart > 0) {
416 ret = mbedtls_ecdsa_read_signature_restartable(&ctx,
417 hash->x, hash->len, sig->x, sig->len,
418 &rs_ctx);
419 TEST_ASSERT(ret == MBEDTLS_ERR_ECP_IN_PROGRESS);
Manuel Pégourié-Gonnard46ba7f32017-08-28 12:20:39 +0200420 }
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200421
422exit:
Gilles Peskine449bd832023-01-11 14:50:10 +0100423 mbedtls_ecdsa_free(&ctx);
424 mbedtls_ecdsa_restart_free(&rs_ctx);
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200425}
426/* END_CASE */
Manuel Pégourié-Gonnardeb402f32017-04-25 10:57:30 +0200427
428/* BEGIN_CASE depends_on:MBEDTLS_ECP_RESTARTABLE:MBEDTLS_ECDSA_DETERMINISTIC */
Gilles Peskine449bd832023-01-11 14:50:10 +0100429void ecdsa_write_restart(int id, char *d_str, int md_alg,
430 data_t *hash, data_t *sig_check,
431 int max_ops, int min_restart, int max_restart)
Manuel Pégourié-Gonnardeb402f32017-04-25 10:57:30 +0200432{
433 int ret, cnt_restart;
434 mbedtls_ecdsa_restart_ctx rs_ctx;
435 mbedtls_ecdsa_context ctx;
Manuel Pégourié-Gonnardeb402f32017-04-25 10:57:30 +0200436 unsigned char sig[MBEDTLS_ECDSA_MAX_LEN];
Neil Armstrong5ea65172022-07-19 16:54:28 +0200437 size_t slen;
Manuel Pégourié-Gonnardeb402f32017-04-25 10:57:30 +0200438
Manuel Pégourié-Gonnard91cc8bb2023-03-20 11:02:12 +0100439 MD_PSA_INIT();
440
Gilles Peskine449bd832023-01-11 14:50:10 +0100441 mbedtls_ecdsa_restart_init(&rs_ctx);
442 mbedtls_ecdsa_init(&ctx);
443 memset(sig, 0, sizeof(sig));
Manuel Pégourié-Gonnardeb402f32017-04-25 10:57:30 +0200444
Gilles Peskine449bd832023-01-11 14:50:10 +0100445 TEST_ASSERT(mbedtls_ecp_group_load(&ctx.grp, id) == 0);
446 TEST_ASSERT(mbedtls_test_read_mpi(&ctx.d, d_str) == 0);
Manuel Pégourié-Gonnardeb402f32017-04-25 10:57:30 +0200447
Gilles Peskine449bd832023-01-11 14:50:10 +0100448 mbedtls_ecp_set_max_ops(max_ops);
Manuel Pégourié-Gonnardeb402f32017-04-25 10:57:30 +0200449
Gilles Peskine449bd832023-01-11 14:50:10 +0100450 slen = sizeof(sig);
Manuel Pégourié-Gonnardeb402f32017-04-25 10:57:30 +0200451 cnt_restart = 0;
452 do {
Gilles Peskine449bd832023-01-11 14:50:10 +0100453 ret = mbedtls_ecdsa_write_signature_restartable(&ctx,
454 md_alg,
455 hash->x,
456 hash->len,
457 sig,
458 sizeof(sig),
459 &slen,
460 mbedtls_test_rnd_std_rand,
461 NULL,
462 &rs_ctx);
463 } while (ret == MBEDTLS_ERR_ECP_IN_PROGRESS && ++cnt_restart);
Manuel Pégourié-Gonnardeb402f32017-04-25 10:57:30 +0200464
Gilles Peskine449bd832023-01-11 14:50:10 +0100465 TEST_ASSERT(ret == 0);
466 TEST_ASSERT(slen == sig_check->len);
467 TEST_ASSERT(memcmp(sig, sig_check->x, slen) == 0);
Manuel Pégourié-Gonnardeb402f32017-04-25 10:57:30 +0200468
Gilles Peskine449bd832023-01-11 14:50:10 +0100469 TEST_ASSERT(cnt_restart >= min_restart);
470 TEST_ASSERT(cnt_restart <= max_restart);
Manuel Pégourié-Gonnardeb402f32017-04-25 10:57:30 +0200471
Manuel Pégourié-Gonnard46ba7f32017-08-28 12:20:39 +0200472 /* Do we leak memory when aborting an operation?
473 * This test only makes sense when we actually restart */
Gilles Peskine449bd832023-01-11 14:50:10 +0100474 if (min_restart > 0) {
475 ret = mbedtls_ecdsa_write_signature_restartable(&ctx,
476 md_alg,
477 hash->x,
478 hash->len,
479 sig,
480 sizeof(sig),
481 &slen,
482 mbedtls_test_rnd_std_rand,
483 NULL,
484 &rs_ctx);
485 TEST_ASSERT(ret == MBEDTLS_ERR_ECP_IN_PROGRESS);
Manuel Pégourié-Gonnard46ba7f32017-08-28 12:20:39 +0200486 }
Manuel Pégourié-Gonnardeb402f32017-04-25 10:57:30 +0200487
488exit:
Gilles Peskine449bd832023-01-11 14:50:10 +0100489 mbedtls_ecdsa_restart_free(&rs_ctx);
490 mbedtls_ecdsa_free(&ctx);
Manuel Pégourié-Gonnard91cc8bb2023-03-20 11:02:12 +0100491 MD_PSA_DONE();
Manuel Pégourié-Gonnardeb402f32017-04-25 10:57:30 +0200492}
493/* END_CASE */
Dave Rodgman1fdb8e82022-08-10 11:32:07 +0100494
495/* BEGIN_CASE */
Gilles Peskine449bd832023-01-11 14:50:10 +0100496void ecdsa_verify(int grp_id, char *x, char *y, char *r, char *s, data_t *content, int expected)
Dave Rodgman1fdb8e82022-08-10 11:32:07 +0100497{
Dave Rodgman1fdb8e82022-08-10 11:32:07 +0100498 mbedtls_ecdsa_context ctx;
499 mbedtls_mpi sig_r, sig_s;
Dave Rodgman1fdb8e82022-08-10 11:32:07 +0100500
Gilles Peskine449bd832023-01-11 14:50:10 +0100501 mbedtls_ecdsa_init(&ctx);
502 mbedtls_mpi_init(&sig_r);
503 mbedtls_mpi_init(&sig_s);
Dave Rodgman1fdb8e82022-08-10 11:32:07 +0100504
505 /* Prepare ECP group context */
Gilles Peskine449bd832023-01-11 14:50:10 +0100506 TEST_EQUAL(mbedtls_ecp_group_load(&ctx.grp, grp_id), 0);
Dave Rodgman1fdb8e82022-08-10 11:32:07 +0100507
508 /* Prepare public key */
Gilles Peskine449bd832023-01-11 14:50:10 +0100509 TEST_EQUAL(mbedtls_test_read_mpi(&ctx.Q.X, x), 0);
510 TEST_EQUAL(mbedtls_test_read_mpi(&ctx.Q.Y, y), 0);
511 TEST_EQUAL(mbedtls_mpi_lset(&ctx.Q.Z, 1), 0);
Dave Rodgman1fdb8e82022-08-10 11:32:07 +0100512
513 /* Prepare signature R & S */
Gilles Peskine449bd832023-01-11 14:50:10 +0100514 TEST_EQUAL(mbedtls_test_read_mpi(&sig_r, r), 0);
515 TEST_EQUAL(mbedtls_test_read_mpi(&sig_s, s), 0);
Dave Rodgman1fdb8e82022-08-10 11:32:07 +0100516
517 /* Test whether public key has expected validity */
Gilles Peskine449bd832023-01-11 14:50:10 +0100518 TEST_EQUAL(mbedtls_ecp_check_pubkey(&ctx.grp, &ctx.Q),
519 expected == MBEDTLS_ERR_ECP_INVALID_KEY ? MBEDTLS_ERR_ECP_INVALID_KEY : 0);
Dave Rodgman1fdb8e82022-08-10 11:32:07 +0100520
521 /* Verification */
Gilles Peskine449bd832023-01-11 14:50:10 +0100522 int result = mbedtls_ecdsa_verify(&ctx.grp, content->x, content->len, &ctx.Q, &sig_r, &sig_s);
Dave Rodgman1fdb8e82022-08-10 11:32:07 +0100523
Gilles Peskine449bd832023-01-11 14:50:10 +0100524 TEST_EQUAL(result, expected);
Dave Rodgman1fdb8e82022-08-10 11:32:07 +0100525exit:
Gilles Peskine449bd832023-01-11 14:50:10 +0100526 mbedtls_ecdsa_free(&ctx);
527 mbedtls_mpi_free(&sig_r);
528 mbedtls_mpi_free(&sig_s);
Dave Rodgman1fdb8e82022-08-10 11:32:07 +0100529}
Dave Rodgman56cfb312022-08-10 12:21:23 +0100530/* END_CASE */