blob: 7496b4cc3f55df305eac5e56826f4678ec3e1dd6 [file] [log] [blame]
Paul Bakker33b43f12013-08-20 11:48:36 +02001/* BEGIN_HEADER */
Manuel Pégourié-Gonnard7f809972015-03-09 17:05:11 +00002#include "mbedtls/ecdsa.h"
Przemek Stekiel40afdd22022-09-06 13:08:28 +02003#include "hash_info.h"
Paul Bakker33b43f12013-08-20 11:48:36 +02004/* END_HEADER */
Manuel Pégourié-Gonnardd1c71502013-01-26 19:09:07 +01005
Paul Bakker33b43f12013-08-20 11:48:36 +02006/* BEGIN_DEPENDENCIES
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02007 * depends_on:MBEDTLS_ECDSA_C
Paul Bakker33b43f12013-08-20 11:48:36 +02008 * END_DEPENDENCIES
9 */
Manuel Pégourié-Gonnardd1c71502013-01-26 19:09:07 +010010
Paul Bakker33b43f12013-08-20 11:48:36 +020011/* BEGIN_CASE */
Gilles Peskine449bd832023-01-11 14:50:10 +010012void ecdsa_prim_zero(int id)
Manuel Pégourié-Gonnardd1c71502013-01-26 19:09:07 +010013{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +020014 mbedtls_ecp_group grp;
15 mbedtls_ecp_point Q;
16 mbedtls_mpi d, r, s;
Ronald Cron351f0ee2020-06-10 12:12:18 +020017 mbedtls_test_rnd_pseudo_info rnd_info;
Przemek Stekiel40afdd22022-09-06 13:08:28 +020018 unsigned char buf[MBEDTLS_HASH_MAX_SIZE];
Manuel Pégourié-Gonnardd1c71502013-01-26 19:09:07 +010019
Gilles Peskine449bd832023-01-11 14:50:10 +010020 mbedtls_ecp_group_init(&grp);
21 mbedtls_ecp_point_init(&Q);
22 mbedtls_mpi_init(&d); mbedtls_mpi_init(&r); mbedtls_mpi_init(&s);
23 memset(&rnd_info, 0x00, sizeof(mbedtls_test_rnd_pseudo_info));
24 memset(buf, 0, sizeof(buf));
Manuel Pégourié-Gonnardd1c71502013-01-26 19:09:07 +010025
Gilles Peskine449bd832023-01-11 14:50:10 +010026 TEST_ASSERT(mbedtls_ecp_group_load(&grp, id) == 0);
27 TEST_ASSERT(mbedtls_ecp_gen_keypair(&grp, &d, &Q,
28 &mbedtls_test_rnd_pseudo_rand,
29 &rnd_info) == 0);
Manuel Pégourié-Gonnardd1c71502013-01-26 19:09:07 +010030
Gilles Peskine449bd832023-01-11 14:50:10 +010031 TEST_ASSERT(mbedtls_ecdsa_sign(&grp, &r, &s, &d, buf, sizeof(buf),
32 &mbedtls_test_rnd_pseudo_rand,
33 &rnd_info) == 0);
34 TEST_ASSERT(mbedtls_ecdsa_verify(&grp, buf, sizeof(buf), &Q, &r, &s) == 0);
TRodziewicz5feb6702021-04-06 19:55:17 +020035
TRodziewicz40de3c92021-04-07 19:16:18 +020036exit:
Gilles Peskine449bd832023-01-11 14:50:10 +010037 mbedtls_ecp_group_free(&grp);
38 mbedtls_ecp_point_free(&Q);
39 mbedtls_mpi_free(&d); mbedtls_mpi_free(&r); mbedtls_mpi_free(&s);
TRodziewicz40de3c92021-04-07 19:16:18 +020040}
41/* END_CASE */
42
43/* BEGIN_CASE */
Gilles Peskine449bd832023-01-11 14:50:10 +010044void ecdsa_prim_random(int id)
TRodziewicz40de3c92021-04-07 19:16:18 +020045{
46 mbedtls_ecp_group grp;
47 mbedtls_ecp_point Q;
48 mbedtls_mpi d, r, s;
49 mbedtls_test_rnd_pseudo_info rnd_info;
Przemek Stekiel40afdd22022-09-06 13:08:28 +020050 unsigned char buf[MBEDTLS_HASH_MAX_SIZE];
TRodziewicz40de3c92021-04-07 19:16:18 +020051
Gilles Peskine449bd832023-01-11 14:50:10 +010052 mbedtls_ecp_group_init(&grp);
53 mbedtls_ecp_point_init(&Q);
54 mbedtls_mpi_init(&d); mbedtls_mpi_init(&r); mbedtls_mpi_init(&s);
55 memset(&rnd_info, 0x00, sizeof(mbedtls_test_rnd_pseudo_info));
56 memset(buf, 0, sizeof(buf));
TRodziewicz40de3c92021-04-07 19:16:18 +020057
58 /* prepare material for signature */
Gilles Peskine449bd832023-01-11 14:50:10 +010059 TEST_ASSERT(mbedtls_test_rnd_pseudo_rand(&rnd_info,
60 buf, sizeof(buf)) == 0);
61 TEST_ASSERT(mbedtls_ecp_group_load(&grp, id) == 0);
62 TEST_ASSERT(mbedtls_ecp_gen_keypair(&grp, &d, &Q,
63 &mbedtls_test_rnd_pseudo_rand,
64 &rnd_info) == 0);
TRodziewicz40de3c92021-04-07 19:16:18 +020065
Gilles Peskine449bd832023-01-11 14:50:10 +010066 TEST_ASSERT(mbedtls_ecdsa_sign(&grp, &r, &s, &d, buf, sizeof(buf),
67 &mbedtls_test_rnd_pseudo_rand,
68 &rnd_info) == 0);
69 TEST_ASSERT(mbedtls_ecdsa_verify(&grp, buf, sizeof(buf), &Q, &r, &s) == 0);
Manuel Pégourié-Gonnardd1c71502013-01-26 19:09:07 +010070
Paul Bakkerbd51b262014-07-10 15:26:12 +020071exit:
Gilles Peskine449bd832023-01-11 14:50:10 +010072 mbedtls_ecp_group_free(&grp);
73 mbedtls_ecp_point_free(&Q);
74 mbedtls_mpi_free(&d); mbedtls_mpi_free(&r); mbedtls_mpi_free(&s);
Manuel Pégourié-Gonnardd1c71502013-01-26 19:09:07 +010075}
Paul Bakker33b43f12013-08-20 11:48:36 +020076/* END_CASE */
Manuel Pégourié-Gonnard602a8972013-01-27 08:10:28 +010077
Paul Bakker33b43f12013-08-20 11:48:36 +020078/* BEGIN_CASE */
Gilles Peskine449bd832023-01-11 14:50:10 +010079void ecdsa_prim_test_vectors(int id, char *d_str, char *xQ_str,
80 char *yQ_str, data_t *rnd_buf,
81 data_t *hash, char *r_str, char *s_str,
82 int result)
Manuel Pégourié-Gonnard602a8972013-01-27 08:10:28 +010083{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +020084 mbedtls_ecp_group grp;
85 mbedtls_ecp_point Q;
Manuel Pégourié-Gonnardec528932022-04-21 09:25:23 +020086 mbedtls_mpi d, r, s, r_check, s_check, zero;
Ronald Cron351f0ee2020-06-10 12:12:18 +020087 mbedtls_test_rnd_buf_info rnd_info;
Manuel Pégourié-Gonnard602a8972013-01-27 08:10:28 +010088
Gilles Peskine449bd832023-01-11 14:50:10 +010089 mbedtls_ecp_group_init(&grp);
90 mbedtls_ecp_point_init(&Q);
91 mbedtls_mpi_init(&d); mbedtls_mpi_init(&r); mbedtls_mpi_init(&s);
92 mbedtls_mpi_init(&r_check); mbedtls_mpi_init(&s_check);
93 mbedtls_mpi_init(&zero);
Manuel Pégourié-Gonnard602a8972013-01-27 08:10:28 +010094
Gilles Peskine449bd832023-01-11 14:50:10 +010095 TEST_ASSERT(mbedtls_ecp_group_load(&grp, id) == 0);
96 TEST_ASSERT(mbedtls_ecp_point_read_string(&Q, 16, xQ_str, yQ_str) == 0);
97 TEST_ASSERT(mbedtls_test_read_mpi(&d, d_str) == 0);
98 TEST_ASSERT(mbedtls_test_read_mpi(&r_check, r_str) == 0);
99 TEST_ASSERT(mbedtls_test_read_mpi(&s_check, s_str) == 0);
Gilles Peskineecacc3c2021-03-24 00:48:57 +0100100 rnd_info.fallback_f_rng = mbedtls_test_rnd_std_rand;
101 rnd_info.fallback_p_rng = NULL;
Azim Khand30ca132017-06-09 04:32:58 +0100102 rnd_info.buf = rnd_buf->x;
103 rnd_info.length = rnd_buf->len;
Manuel Pégourié-Gonnard602a8972013-01-27 08:10:28 +0100104
Azim Khand30ca132017-06-09 04:32:58 +0100105 /* Fix rnd_buf->x by shifting it left if necessary */
Gilles Peskine449bd832023-01-11 14:50:10 +0100106 if (grp.nbits % 8 != 0) {
107 unsigned char shift = 8 - (grp.nbits % 8);
Manuel Pégourié-Gonnardfae079e2014-01-06 11:00:07 +0100108 size_t i;
109
Gilles Peskine449bd832023-01-11 14:50:10 +0100110 for (i = 0; i < rnd_info.length - 1; i++) {
111 rnd_buf->x[i] = rnd_buf->x[i] << shift | rnd_buf->x[i+1] >> (8 - shift);
112 }
Manuel Pégourié-Gonnardfae079e2014-01-06 11:00:07 +0100113
Azim Khand30ca132017-06-09 04:32:58 +0100114 rnd_buf->x[rnd_info.length-1] <<= shift;
Manuel Pégourié-Gonnardfae079e2014-01-06 11:00:07 +0100115 }
116
Gilles Peskine449bd832023-01-11 14:50:10 +0100117 TEST_ASSERT(mbedtls_ecdsa_sign(&grp, &r, &s, &d, hash->x, hash->len,
118 mbedtls_test_rnd_buffer_rand, &rnd_info) == result);
Manuel Pégourié-Gonnard602a8972013-01-27 08:10:28 +0100119
Gilles Peskine449bd832023-01-11 14:50:10 +0100120 if (result == 0) {
Manuel Pégourié-Gonnardec528932022-04-21 09:25:23 +0200121 /* Check we generated the expected values */
Gilles Peskine449bd832023-01-11 14:50:10 +0100122 TEST_EQUAL(mbedtls_mpi_cmp_mpi(&r, &r_check), 0);
123 TEST_EQUAL(mbedtls_mpi_cmp_mpi(&s, &s_check), 0);
Manuel Pégourié-Gonnard602a8972013-01-27 08:10:28 +0100124
Manuel Pégourié-Gonnardd8d19de2022-04-20 10:34:22 +0200125 /* Valid signature */
Gilles Peskine449bd832023-01-11 14:50:10 +0100126 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len,
127 &Q, &r_check, &s_check), 0);
Manuel Pégourié-Gonnardd0a66cc2018-06-13 09:53:21 +0200128
Manuel Pégourié-Gonnardd8d19de2022-04-20 10:34:22 +0200129 /* Invalid signature: wrong public key (G instead of Q) */
Gilles Peskine449bd832023-01-11 14:50:10 +0100130 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len,
131 &grp.G, &r_check, &s_check), MBEDTLS_ERR_ECP_VERIFY_FAILED);
Manuel Pégourié-Gonnardd0a66cc2018-06-13 09:53:21 +0200132
Manuel Pégourié-Gonnardd8d19de2022-04-20 10:34:22 +0200133 /* Invalid signatures: r or s or both one off */
Gilles Peskine449bd832023-01-11 14:50:10 +0100134 TEST_EQUAL(mbedtls_mpi_sub_int(&r, &r_check, 1), 0);
135 TEST_EQUAL(mbedtls_mpi_add_int(&s, &s_check, 1), 0);
Manuel Pégourié-Gonnardd8d19de2022-04-20 10:34:22 +0200136
Gilles Peskine449bd832023-01-11 14:50:10 +0100137 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
138 &r, &s_check), MBEDTLS_ERR_ECP_VERIFY_FAILED);
139 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
140 &r_check, &s), MBEDTLS_ERR_ECP_VERIFY_FAILED);
141 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
142 &r, &s), MBEDTLS_ERR_ECP_VERIFY_FAILED);
Manuel Pégourié-Gonnardd8d19de2022-04-20 10:34:22 +0200143
144 /* Invalid signatures: r, s or both (CVE-2022-21449) are zero */
Gilles Peskine449bd832023-01-11 14:50:10 +0100145 TEST_EQUAL(mbedtls_mpi_lset(&zero, 0), 0);
Manuel Pégourié-Gonnardd8d19de2022-04-20 10:34:22 +0200146
Gilles Peskine449bd832023-01-11 14:50:10 +0100147 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
148 &zero, &s_check), MBEDTLS_ERR_ECP_VERIFY_FAILED);
149 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
150 &r_check, &zero), MBEDTLS_ERR_ECP_VERIFY_FAILED);
151 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
152 &zero, &zero), MBEDTLS_ERR_ECP_VERIFY_FAILED);
Manuel Pégourié-Gonnardd8d19de2022-04-20 10:34:22 +0200153
154 /* Invalid signatures: r, s or both are == N */
Gilles Peskine449bd832023-01-11 14:50:10 +0100155 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
156 &grp.N, &s_check), MBEDTLS_ERR_ECP_VERIFY_FAILED);
157 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
158 &r_check, &grp.N), MBEDTLS_ERR_ECP_VERIFY_FAILED);
159 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
160 &grp.N, &grp.N), MBEDTLS_ERR_ECP_VERIFY_FAILED);
Manuel Pégourié-Gonnardec528932022-04-21 09:25:23 +0200161
162 /* Invalid signatures: r, s or both are negative */
Gilles Peskine449bd832023-01-11 14:50:10 +0100163 TEST_EQUAL(mbedtls_mpi_sub_mpi(&r, &r_check, &grp.N), 0);
164 TEST_EQUAL(mbedtls_mpi_sub_mpi(&s, &s_check, &grp.N), 0);
Manuel Pégourié-Gonnardd8d19de2022-04-20 10:34:22 +0200165
Gilles Peskine449bd832023-01-11 14:50:10 +0100166 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
167 &r, &s_check), MBEDTLS_ERR_ECP_VERIFY_FAILED);
168 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
169 &r_check, &s), MBEDTLS_ERR_ECP_VERIFY_FAILED);
170 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
171 &r, &s), MBEDTLS_ERR_ECP_VERIFY_FAILED);
Manuel Pégourié-Gonnardd8d19de2022-04-20 10:34:22 +0200172
173 /* Invalid signatures: r or s or both are > N */
Gilles Peskine449bd832023-01-11 14:50:10 +0100174 TEST_EQUAL(mbedtls_mpi_add_mpi(&r, &r_check, &grp.N), 0);
175 TEST_EQUAL(mbedtls_mpi_add_mpi(&s, &s_check, &grp.N), 0);
Manuel Pégourié-Gonnardd8d19de2022-04-20 10:34:22 +0200176
Gilles Peskine449bd832023-01-11 14:50:10 +0100177 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
178 &r, &s_check), MBEDTLS_ERR_ECP_VERIFY_FAILED);
179 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
180 &r_check, &s), MBEDTLS_ERR_ECP_VERIFY_FAILED);
181 TEST_EQUAL(mbedtls_ecdsa_verify(&grp, hash->x, hash->len, &Q,
182 &r, &s), MBEDTLS_ERR_ECP_VERIFY_FAILED);
Darryl Greenf5bcbed2017-11-17 17:09:31 +0000183 }
Manuel Pégourié-Gonnard602a8972013-01-27 08:10:28 +0100184
Paul Bakkerbd51b262014-07-10 15:26:12 +0200185exit:
Gilles Peskine449bd832023-01-11 14:50:10 +0100186 mbedtls_ecp_group_free(&grp);
187 mbedtls_ecp_point_free(&Q);
188 mbedtls_mpi_free(&d); mbedtls_mpi_free(&r); mbedtls_mpi_free(&s);
189 mbedtls_mpi_free(&r_check); mbedtls_mpi_free(&s_check);
190 mbedtls_mpi_free(&zero);
Manuel Pégourié-Gonnard602a8972013-01-27 08:10:28 +0100191}
Paul Bakker33b43f12013-08-20 11:48:36 +0200192/* END_CASE */
Manuel Pégourié-Gonnardb694b482013-08-08 13:30:57 +0200193
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200194/* BEGIN_CASE depends_on:MBEDTLS_ECDSA_DETERMINISTIC */
Gilles Peskine449bd832023-01-11 14:50:10 +0100195void ecdsa_det_test_vectors(int id, char *d_str, int md_alg, data_t *hash,
196 char *r_str, char *s_str)
Manuel Pégourié-Gonnard4daaef72014-01-06 14:25:56 +0100197{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200198 mbedtls_ecp_group grp;
199 mbedtls_mpi d, r, s, r_check, s_check;
Manuel Pégourié-Gonnard4daaef72014-01-06 14:25:56 +0100200
Manuel Pégourié-Gonnardebef58d2023-03-16 12:48:24 +0100201 MD_PSA_INIT();
202
Gilles Peskine449bd832023-01-11 14:50:10 +0100203 mbedtls_ecp_group_init(&grp);
204 mbedtls_mpi_init(&d); mbedtls_mpi_init(&r); mbedtls_mpi_init(&s);
205 mbedtls_mpi_init(&r_check); mbedtls_mpi_init(&s_check);
Manuel Pégourié-Gonnard4daaef72014-01-06 14:25:56 +0100206
Gilles Peskine449bd832023-01-11 14:50:10 +0100207 TEST_ASSERT(mbedtls_ecp_group_load(&grp, id) == 0);
208 TEST_ASSERT(mbedtls_test_read_mpi(&d, d_str) == 0);
209 TEST_ASSERT(mbedtls_test_read_mpi(&r_check, r_str) == 0);
210 TEST_ASSERT(mbedtls_test_read_mpi(&s_check, s_str) == 0);
Manuel Pégourié-Gonnard4daaef72014-01-06 14:25:56 +0100211
Janos Follath651eac82019-01-04 15:51:24 +0000212 TEST_ASSERT(
Gilles Peskine449bd832023-01-11 14:50:10 +0100213 mbedtls_ecdsa_sign_det_ext(&grp, &r, &s, &d,
214 hash->x, hash->len, md_alg,
215 mbedtls_test_rnd_std_rand,
216 NULL)
217 == 0);
Manuel Pégourié-Gonnard4daaef72014-01-06 14:25:56 +0100218
Gilles Peskine449bd832023-01-11 14:50:10 +0100219 TEST_ASSERT(mbedtls_mpi_cmp_mpi(&r, &r_check) == 0);
220 TEST_ASSERT(mbedtls_mpi_cmp_mpi(&s, &s_check) == 0);
Manuel Pégourié-Gonnard4daaef72014-01-06 14:25:56 +0100221
Paul Bakkerbd51b262014-07-10 15:26:12 +0200222exit:
Gilles Peskine449bd832023-01-11 14:50:10 +0100223 mbedtls_ecp_group_free(&grp);
224 mbedtls_mpi_free(&d); mbedtls_mpi_free(&r); mbedtls_mpi_free(&s);
225 mbedtls_mpi_free(&r_check); mbedtls_mpi_free(&s_check);
Manuel Pégourié-Gonnardebef58d2023-03-16 12:48:24 +0100226 MD_PSA_DONE();
Manuel Pégourié-Gonnard4daaef72014-01-06 14:25:56 +0100227}
228/* END_CASE */
229
Manuel Pégourié-Gonnardebef58d2023-03-16 12:48:24 +0100230/* BEGIN_CASE depends_on:MBEDTLS_MD_CAN_SHA256 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100231void ecdsa_write_read_zero(int id)
TRodziewicz40de3c92021-04-07 19:16:18 +0200232{
233 mbedtls_ecdsa_context ctx;
234 mbedtls_test_rnd_pseudo_info rnd_info;
235 unsigned char hash[32];
236 unsigned char sig[200];
237 size_t sig_len, i;
238
Gilles Peskine449bd832023-01-11 14:50:10 +0100239 mbedtls_ecdsa_init(&ctx);
240 memset(&rnd_info, 0x00, sizeof(mbedtls_test_rnd_pseudo_info));
241 memset(hash, 0, sizeof(hash));
242 memset(sig, 0x2a, sizeof(sig));
TRodziewicz40de3c92021-04-07 19:16:18 +0200243
244 /* generate signing key */
Gilles Peskine449bd832023-01-11 14:50:10 +0100245 TEST_ASSERT(mbedtls_ecdsa_genkey(&ctx, id,
246 &mbedtls_test_rnd_pseudo_rand,
247 &rnd_info) == 0);
TRodziewicz40de3c92021-04-07 19:16:18 +0200248
249 /* generate and write signature, then read and verify it */
Gilles Peskine449bd832023-01-11 14:50:10 +0100250 TEST_ASSERT(mbedtls_ecdsa_write_signature(&ctx, MBEDTLS_MD_SHA256,
251 hash, sizeof(hash),
252 sig, sizeof(sig), &sig_len,
253 &mbedtls_test_rnd_pseudo_rand,
254 &rnd_info) == 0);
255 TEST_ASSERT(mbedtls_ecdsa_read_signature(&ctx, hash, sizeof(hash),
256 sig, sig_len) == 0);
TRodziewicz40de3c92021-04-07 19:16:18 +0200257
258 /* check we didn't write past the announced length */
Gilles Peskine449bd832023-01-11 14:50:10 +0100259 for (i = sig_len; i < sizeof(sig); i++) {
260 TEST_ASSERT(sig[i] == 0x2a);
261 }
TRodziewicz40de3c92021-04-07 19:16:18 +0200262
263 /* try verification with invalid length */
Gilles Peskine449bd832023-01-11 14:50:10 +0100264 TEST_ASSERT(mbedtls_ecdsa_read_signature(&ctx, hash, sizeof(hash),
265 sig, sig_len - 1) != 0);
266 TEST_ASSERT(mbedtls_ecdsa_read_signature(&ctx, hash, sizeof(hash),
267 sig, sig_len + 1) != 0);
TRodziewicz40de3c92021-04-07 19:16:18 +0200268
269 /* try invalid sequence tag */
270 sig[0]++;
Gilles Peskine449bd832023-01-11 14:50:10 +0100271 TEST_ASSERT(mbedtls_ecdsa_read_signature(&ctx, hash, sizeof(hash),
272 sig, sig_len) != 0);
TRodziewicz40de3c92021-04-07 19:16:18 +0200273 sig[0]--;
274
275 /* try modifying r */
276 sig[10]++;
Gilles Peskine449bd832023-01-11 14:50:10 +0100277 TEST_ASSERT(mbedtls_ecdsa_read_signature(&ctx, hash, sizeof(hash),
278 sig, sig_len) == MBEDTLS_ERR_ECP_VERIFY_FAILED);
TRodziewicz40de3c92021-04-07 19:16:18 +0200279 sig[10]--;
280
281 /* try modifying s */
282 sig[sig_len - 1]++;
Gilles Peskine449bd832023-01-11 14:50:10 +0100283 TEST_ASSERT(mbedtls_ecdsa_read_signature(&ctx, hash, sizeof(hash),
284 sig, sig_len) == MBEDTLS_ERR_ECP_VERIFY_FAILED);
TRodziewicz40de3c92021-04-07 19:16:18 +0200285 sig[sig_len - 1]--;
286
287exit:
Gilles Peskine449bd832023-01-11 14:50:10 +0100288 mbedtls_ecdsa_free(&ctx);
TRodziewicz40de3c92021-04-07 19:16:18 +0200289}
290/* END_CASE */
291
Manuel Pégourié-Gonnardebef58d2023-03-16 12:48:24 +0100292/* BEGIN_CASE depends_on:MBEDTLS_MD_CAN_SHA256 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100293void ecdsa_write_read_random(int id)
Manuel Pégourié-Gonnardb694b482013-08-08 13:30:57 +0200294{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200295 mbedtls_ecdsa_context ctx;
Ronald Cron351f0ee2020-06-10 12:12:18 +0200296 mbedtls_test_rnd_pseudo_info rnd_info;
Manuel Pégourié-Gonnarddfdcac92015-03-31 11:41:42 +0200297 unsigned char hash[32];
Manuel Pégourié-Gonnardb694b482013-08-08 13:30:57 +0200298 unsigned char sig[200];
299 size_t sig_len, i;
300
Gilles Peskine449bd832023-01-11 14:50:10 +0100301 mbedtls_ecdsa_init(&ctx);
302 memset(&rnd_info, 0x00, sizeof(mbedtls_test_rnd_pseudo_info));
303 memset(hash, 0, sizeof(hash));
304 memset(sig, 0x2a, sizeof(sig));
Manuel Pégourié-Gonnardb694b482013-08-08 13:30:57 +0200305
TRodziewicz40de3c92021-04-07 19:16:18 +0200306 /* prepare material for signature */
Gilles Peskine449bd832023-01-11 14:50:10 +0100307 TEST_ASSERT(mbedtls_test_rnd_pseudo_rand(&rnd_info,
308 hash, sizeof(hash)) == 0);
Manuel Pégourié-Gonnardb694b482013-08-08 13:30:57 +0200309
TRodziewicz40de3c92021-04-07 19:16:18 +0200310 /* generate signing key */
Gilles Peskine449bd832023-01-11 14:50:10 +0100311 TEST_ASSERT(mbedtls_ecdsa_genkey(&ctx, id,
312 &mbedtls_test_rnd_pseudo_rand,
313 &rnd_info) == 0);
Manuel Pégourié-Gonnardb694b482013-08-08 13:30:57 +0200314
TRodziewicz40de3c92021-04-07 19:16:18 +0200315 /* generate and write signature, then read and verify it */
Gilles Peskine449bd832023-01-11 14:50:10 +0100316 TEST_ASSERT(mbedtls_ecdsa_write_signature(&ctx, MBEDTLS_MD_SHA256,
317 hash, sizeof(hash),
318 sig, sizeof(sig), &sig_len,
319 &mbedtls_test_rnd_pseudo_rand,
320 &rnd_info) == 0);
321 TEST_ASSERT(mbedtls_ecdsa_read_signature(&ctx, hash, sizeof(hash),
322 sig, sig_len) == 0);
Manuel Pégourié-Gonnardb694b482013-08-08 13:30:57 +0200323
TRodziewicz40de3c92021-04-07 19:16:18 +0200324 /* check we didn't write past the announced length */
Gilles Peskine449bd832023-01-11 14:50:10 +0100325 for (i = sig_len; i < sizeof(sig); i++) {
326 TEST_ASSERT(sig[i] == 0x2a);
327 }
Manuel Pégourié-Gonnardb694b482013-08-08 13:30:57 +0200328
TRodziewicz40de3c92021-04-07 19:16:18 +0200329 /* try verification with invalid length */
Gilles Peskine449bd832023-01-11 14:50:10 +0100330 TEST_ASSERT(mbedtls_ecdsa_read_signature(&ctx, hash, sizeof(hash),
331 sig, sig_len - 1) != 0);
332 TEST_ASSERT(mbedtls_ecdsa_read_signature(&ctx, hash, sizeof(hash),
333 sig, sig_len + 1) != 0);
Manuel Pégourié-Gonnardb694b482013-08-08 13:30:57 +0200334
TRodziewicz40de3c92021-04-07 19:16:18 +0200335 /* try invalid sequence tag */
336 sig[0]++;
Gilles Peskine449bd832023-01-11 14:50:10 +0100337 TEST_ASSERT(mbedtls_ecdsa_read_signature(&ctx, hash, sizeof(hash),
338 sig, sig_len) != 0);
TRodziewicz40de3c92021-04-07 19:16:18 +0200339 sig[0]--;
Manuel Pégourié-Gonnardb694b482013-08-08 13:30:57 +0200340
TRodziewicz40de3c92021-04-07 19:16:18 +0200341 /* try modifying r */
342 sig[10]++;
Gilles Peskine449bd832023-01-11 14:50:10 +0100343 TEST_ASSERT(mbedtls_ecdsa_read_signature(&ctx, hash, sizeof(hash),
344 sig, sig_len) == MBEDTLS_ERR_ECP_VERIFY_FAILED);
TRodziewicz40de3c92021-04-07 19:16:18 +0200345 sig[10]--;
Manuel Pégourié-Gonnardb694b482013-08-08 13:30:57 +0200346
TRodziewicz40de3c92021-04-07 19:16:18 +0200347 /* try modifying s */
348 sig[sig_len - 1]++;
Gilles Peskine449bd832023-01-11 14:50:10 +0100349 TEST_ASSERT(mbedtls_ecdsa_read_signature(&ctx, hash, sizeof(hash),
350 sig, sig_len) == MBEDTLS_ERR_ECP_VERIFY_FAILED);
TRodziewicz40de3c92021-04-07 19:16:18 +0200351 sig[sig_len - 1]--;
Manuel Pégourié-Gonnardb694b482013-08-08 13:30:57 +0200352
Paul Bakkerbd51b262014-07-10 15:26:12 +0200353exit:
Gilles Peskine449bd832023-01-11 14:50:10 +0100354 mbedtls_ecdsa_free(&ctx);
Manuel Pégourié-Gonnardb694b482013-08-08 13:30:57 +0200355}
356/* END_CASE */
Manuel Pégourié-Gonnard937340b2014-01-06 10:27:16 +0100357
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200358/* BEGIN_CASE depends_on:MBEDTLS_ECP_RESTARTABLE */
Gilles Peskine449bd832023-01-11 14:50:10 +0100359void ecdsa_read_restart(int id, data_t *pk, data_t *hash, data_t *sig,
360 int max_ops, int min_restart, int max_restart)
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200361{
362 mbedtls_ecdsa_context ctx;
363 mbedtls_ecdsa_restart_ctx rs_ctx;
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200364 int ret, cnt_restart;
365
Gilles Peskine449bd832023-01-11 14:50:10 +0100366 mbedtls_ecdsa_init(&ctx);
367 mbedtls_ecdsa_restart_init(&rs_ctx);
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200368
Gilles Peskine449bd832023-01-11 14:50:10 +0100369 TEST_ASSERT(mbedtls_ecp_group_load(&ctx.grp, id) == 0);
370 TEST_ASSERT(mbedtls_ecp_point_read_binary(&ctx.grp, &ctx.Q,
371 pk->x, pk->len) == 0);
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200372
Gilles Peskine449bd832023-01-11 14:50:10 +0100373 mbedtls_ecp_set_max_ops(max_ops);
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200374
375 cnt_restart = 0;
376 do {
Gilles Peskine449bd832023-01-11 14:50:10 +0100377 ret = mbedtls_ecdsa_read_signature_restartable(&ctx,
378 hash->x, hash->len, sig->x, sig->len,
379 &rs_ctx);
380 } while (ret == MBEDTLS_ERR_ECP_IN_PROGRESS && ++cnt_restart);
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200381
Gilles Peskine449bd832023-01-11 14:50:10 +0100382 TEST_ASSERT(ret == 0);
383 TEST_ASSERT(cnt_restart >= min_restart);
384 TEST_ASSERT(cnt_restart <= max_restart);
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200385
386 /* try modifying r */
Ronald Cron9ed40732020-06-25 09:03:34 +0200387
Gilles Peskine449bd832023-01-11 14:50:10 +0100388 TEST_ASSERT(sig->len > 10);
Ronald Cron9ed40732020-06-25 09:03:34 +0200389 sig->x[10]++;
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200390 do {
Gilles Peskine449bd832023-01-11 14:50:10 +0100391 ret = mbedtls_ecdsa_read_signature_restartable(&ctx,
392 hash->x, hash->len, sig->x, sig->len,
393 &rs_ctx);
394 } while (ret == MBEDTLS_ERR_ECP_IN_PROGRESS);
395 TEST_ASSERT(ret == MBEDTLS_ERR_ECP_VERIFY_FAILED);
Ronald Cron9ed40732020-06-25 09:03:34 +0200396 sig->x[10]--;
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200397
398 /* try modifying s */
Ronald Cron9ed40732020-06-25 09:03:34 +0200399 sig->x[sig->len - 1]++;
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200400 do {
Gilles Peskine449bd832023-01-11 14:50:10 +0100401 ret = mbedtls_ecdsa_read_signature_restartable(&ctx,
402 hash->x, hash->len, sig->x, sig->len,
403 &rs_ctx);
404 } while (ret == MBEDTLS_ERR_ECP_IN_PROGRESS);
405 TEST_ASSERT(ret == MBEDTLS_ERR_ECP_VERIFY_FAILED);
Ronald Cron9ed40732020-06-25 09:03:34 +0200406 sig->x[sig->len - 1]--;
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200407
Manuel Pégourié-Gonnard46ba7f32017-08-28 12:20:39 +0200408 /* Do we leak memory when aborting an operation?
409 * This test only makes sense when we actually restart */
Gilles Peskine449bd832023-01-11 14:50:10 +0100410 if (min_restart > 0) {
411 ret = mbedtls_ecdsa_read_signature_restartable(&ctx,
412 hash->x, hash->len, sig->x, sig->len,
413 &rs_ctx);
414 TEST_ASSERT(ret == MBEDTLS_ERR_ECP_IN_PROGRESS);
Manuel Pégourié-Gonnard46ba7f32017-08-28 12:20:39 +0200415 }
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200416
417exit:
Gilles Peskine449bd832023-01-11 14:50:10 +0100418 mbedtls_ecdsa_free(&ctx);
419 mbedtls_ecdsa_restart_free(&rs_ctx);
Manuel Pégourié-Gonnard722e5152017-04-21 11:04:47 +0200420}
421/* END_CASE */
Manuel Pégourié-Gonnardeb402f32017-04-25 10:57:30 +0200422
423/* BEGIN_CASE depends_on:MBEDTLS_ECP_RESTARTABLE:MBEDTLS_ECDSA_DETERMINISTIC */
Gilles Peskine449bd832023-01-11 14:50:10 +0100424void ecdsa_write_restart(int id, char *d_str, int md_alg,
425 data_t *hash, data_t *sig_check,
426 int max_ops, int min_restart, int max_restart)
Manuel Pégourié-Gonnardeb402f32017-04-25 10:57:30 +0200427{
428 int ret, cnt_restart;
429 mbedtls_ecdsa_restart_ctx rs_ctx;
430 mbedtls_ecdsa_context ctx;
Manuel Pégourié-Gonnardeb402f32017-04-25 10:57:30 +0200431 unsigned char sig[MBEDTLS_ECDSA_MAX_LEN];
Neil Armstrong5ea65172022-07-19 16:54:28 +0200432 size_t slen;
Manuel Pégourié-Gonnardeb402f32017-04-25 10:57:30 +0200433
Gilles Peskine449bd832023-01-11 14:50:10 +0100434 mbedtls_ecdsa_restart_init(&rs_ctx);
435 mbedtls_ecdsa_init(&ctx);
436 memset(sig, 0, sizeof(sig));
Manuel Pégourié-Gonnardeb402f32017-04-25 10:57:30 +0200437
Gilles Peskine449bd832023-01-11 14:50:10 +0100438 TEST_ASSERT(mbedtls_ecp_group_load(&ctx.grp, id) == 0);
439 TEST_ASSERT(mbedtls_test_read_mpi(&ctx.d, d_str) == 0);
Manuel Pégourié-Gonnardeb402f32017-04-25 10:57:30 +0200440
Gilles Peskine449bd832023-01-11 14:50:10 +0100441 mbedtls_ecp_set_max_ops(max_ops);
Manuel Pégourié-Gonnardeb402f32017-04-25 10:57:30 +0200442
Gilles Peskine449bd832023-01-11 14:50:10 +0100443 slen = sizeof(sig);
Manuel Pégourié-Gonnardeb402f32017-04-25 10:57:30 +0200444 cnt_restart = 0;
445 do {
Gilles Peskine449bd832023-01-11 14:50:10 +0100446 ret = mbedtls_ecdsa_write_signature_restartable(&ctx,
447 md_alg,
448 hash->x,
449 hash->len,
450 sig,
451 sizeof(sig),
452 &slen,
453 mbedtls_test_rnd_std_rand,
454 NULL,
455 &rs_ctx);
456 } while (ret == MBEDTLS_ERR_ECP_IN_PROGRESS && ++cnt_restart);
Manuel Pégourié-Gonnardeb402f32017-04-25 10:57:30 +0200457
Gilles Peskine449bd832023-01-11 14:50:10 +0100458 TEST_ASSERT(ret == 0);
459 TEST_ASSERT(slen == sig_check->len);
460 TEST_ASSERT(memcmp(sig, sig_check->x, slen) == 0);
Manuel Pégourié-Gonnardeb402f32017-04-25 10:57:30 +0200461
Gilles Peskine449bd832023-01-11 14:50:10 +0100462 TEST_ASSERT(cnt_restart >= min_restart);
463 TEST_ASSERT(cnt_restart <= max_restart);
Manuel Pégourié-Gonnardeb402f32017-04-25 10:57:30 +0200464
Manuel Pégourié-Gonnard46ba7f32017-08-28 12:20:39 +0200465 /* Do we leak memory when aborting an operation?
466 * This test only makes sense when we actually restart */
Gilles Peskine449bd832023-01-11 14:50:10 +0100467 if (min_restart > 0) {
468 ret = mbedtls_ecdsa_write_signature_restartable(&ctx,
469 md_alg,
470 hash->x,
471 hash->len,
472 sig,
473 sizeof(sig),
474 &slen,
475 mbedtls_test_rnd_std_rand,
476 NULL,
477 &rs_ctx);
478 TEST_ASSERT(ret == MBEDTLS_ERR_ECP_IN_PROGRESS);
Manuel Pégourié-Gonnard46ba7f32017-08-28 12:20:39 +0200479 }
Manuel Pégourié-Gonnardeb402f32017-04-25 10:57:30 +0200480
481exit:
Gilles Peskine449bd832023-01-11 14:50:10 +0100482 mbedtls_ecdsa_restart_free(&rs_ctx);
483 mbedtls_ecdsa_free(&ctx);
Manuel Pégourié-Gonnardeb402f32017-04-25 10:57:30 +0200484}
485/* END_CASE */
Dave Rodgman1fdb8e82022-08-10 11:32:07 +0100486
487/* BEGIN_CASE */
Gilles Peskine449bd832023-01-11 14:50:10 +0100488void ecdsa_verify(int grp_id, char *x, char *y, char *r, char *s, data_t *content, int expected)
Dave Rodgman1fdb8e82022-08-10 11:32:07 +0100489{
Dave Rodgman1fdb8e82022-08-10 11:32:07 +0100490 mbedtls_ecdsa_context ctx;
491 mbedtls_mpi sig_r, sig_s;
Dave Rodgman1fdb8e82022-08-10 11:32:07 +0100492
Gilles Peskine449bd832023-01-11 14:50:10 +0100493 mbedtls_ecdsa_init(&ctx);
494 mbedtls_mpi_init(&sig_r);
495 mbedtls_mpi_init(&sig_s);
Dave Rodgman1fdb8e82022-08-10 11:32:07 +0100496
497 /* Prepare ECP group context */
Gilles Peskine449bd832023-01-11 14:50:10 +0100498 TEST_EQUAL(mbedtls_ecp_group_load(&ctx.grp, grp_id), 0);
Dave Rodgman1fdb8e82022-08-10 11:32:07 +0100499
500 /* Prepare public key */
Gilles Peskine449bd832023-01-11 14:50:10 +0100501 TEST_EQUAL(mbedtls_test_read_mpi(&ctx.Q.X, x), 0);
502 TEST_EQUAL(mbedtls_test_read_mpi(&ctx.Q.Y, y), 0);
503 TEST_EQUAL(mbedtls_mpi_lset(&ctx.Q.Z, 1), 0);
Dave Rodgman1fdb8e82022-08-10 11:32:07 +0100504
505 /* Prepare signature R & S */
Gilles Peskine449bd832023-01-11 14:50:10 +0100506 TEST_EQUAL(mbedtls_test_read_mpi(&sig_r, r), 0);
507 TEST_EQUAL(mbedtls_test_read_mpi(&sig_s, s), 0);
Dave Rodgman1fdb8e82022-08-10 11:32:07 +0100508
509 /* Test whether public key has expected validity */
Gilles Peskine449bd832023-01-11 14:50:10 +0100510 TEST_EQUAL(mbedtls_ecp_check_pubkey(&ctx.grp, &ctx.Q),
511 expected == MBEDTLS_ERR_ECP_INVALID_KEY ? MBEDTLS_ERR_ECP_INVALID_KEY : 0);
Dave Rodgman1fdb8e82022-08-10 11:32:07 +0100512
513 /* Verification */
Gilles Peskine449bd832023-01-11 14:50:10 +0100514 int result = mbedtls_ecdsa_verify(&ctx.grp, content->x, content->len, &ctx.Q, &sig_r, &sig_s);
Dave Rodgman1fdb8e82022-08-10 11:32:07 +0100515
Gilles Peskine449bd832023-01-11 14:50:10 +0100516 TEST_EQUAL(result, expected);
Dave Rodgman1fdb8e82022-08-10 11:32:07 +0100517exit:
Gilles Peskine449bd832023-01-11 14:50:10 +0100518 mbedtls_ecdsa_free(&ctx);
519 mbedtls_mpi_free(&sig_r);
520 mbedtls_mpi_free(&sig_s);
Dave Rodgman1fdb8e82022-08-10 11:32:07 +0100521}
Dave Rodgman56cfb312022-08-10 12:21:23 +0100522/* END_CASE */