blob: 4e078e321689fa436120d84c6dd240a5cf144d9c [file] [log] [blame]
Gilles Peskine8266b5b2021-09-27 19:53:31 +02001#!/usr/bin/env python3
2#
3# Copyright The Mbed TLS Contributors
4# SPDX-License-Identifier: Apache-2.0
5#
6# Licensed under the Apache License, Version 2.0 (the "License"); you may
7# not use this file except in compliance with the License.
8# You may obtain a copy of the License at
9#
10# http://www.apache.org/licenses/LICENSE-2.0
11#
12# Unless required by applicable law or agreed to in writing, software
13# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
14# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15# See the License for the specific language governing permissions and
16# limitations under the License.
17
18"""
19This script confirms that the naming of all symbols and identifiers in Mbed TLS
20are consistent with the house style and are also self-consistent. It only runs
21on Linux and macOS since it depends on nm.
22
23It contains two major Python classes, CodeParser and NameChecker. They both have
24a comprehensive "run-all" function (comprehensive_parse() and perform_checks())
25but the individual functions can also be used for specific needs.
26
27CodeParser makes heavy use of regular expressions to parse the code, and is
28dependent on the current code formatting. Many Python C parser libraries require
29preprocessed C code, which means no macro parsing. Compiler tools are also not
30very helpful when we want the exact location in the original source (which
31becomes impossible when e.g. comments are stripped).
32
33NameChecker performs the following checks:
34
35- All exported and available symbols in the library object files, are explicitly
36 declared in the header files. This uses the nm command.
37- All macros, constants, and identifiers (function names, struct names, etc)
38 follow the required regex pattern.
39- Typo checking: All words that begin with MBED exist as macros or constants.
40
41The script returns 0 on success, 1 on test failure, and 2 if there is a script
42error. It must be run from Mbed TLS root.
43"""
44
45import abc
46import argparse
Gilles Peskine7bf52052021-09-27 19:20:17 +020047import fnmatch
Gilles Peskine8266b5b2021-09-27 19:53:31 +020048import glob
49import textwrap
50import os
51import sys
52import traceback
53import re
54import enum
55import shutil
56import subprocess
57import logging
58
59# Naming patterns to check against. These are defined outside the NameCheck
60# class for ease of modification.
61MACRO_PATTERN = r"^(MBEDTLS|PSA)_[0-9A-Z_]*[0-9A-Z]$"
62CONSTANTS_PATTERN = MACRO_PATTERN
63IDENTIFIER_PATTERN = r"^(mbedtls|psa)_[0-9a-z_]*[0-9a-z]$"
64
65class Match(): # pylint: disable=too-few-public-methods
66 """
67 A class representing a match, together with its found position.
68
69 Fields:
70 * filename: the file that the match was in.
71 * line: the full line containing the match.
72 * line_no: the line number.
73 * pos: a tuple of (start, end) positions on the line where the match is.
74 * name: the match itself.
75 """
76 def __init__(self, filename, line, line_no, pos, name):
77 # pylint: disable=too-many-arguments
78 self.filename = filename
79 self.line = line
80 self.line_no = line_no
81 self.pos = pos
82 self.name = name
83
84 def __str__(self):
85 """
86 Return a formatted code listing representation of the erroneous line.
87 """
88 gutter = format(self.line_no, "4d")
89 underline = self.pos[0] * " " + (self.pos[1] - self.pos[0]) * "^"
90
91 return (
92 " {0} |\n".format(" " * len(gutter)) +
93 " {0} | {1}".format(gutter, self.line) +
94 " {0} | {1}\n".format(" " * len(gutter), underline)
95 )
96
97class Problem(abc.ABC): # pylint: disable=too-few-public-methods
98 """
99 An abstract parent class representing a form of static analysis error.
100 It extends an Abstract Base Class, which means it is not instantiable, and
101 it also mandates certain abstract methods to be implemented in subclasses.
102 """
103 # Class variable to control the quietness of all problems
104 quiet = False
105 def __init__(self):
106 self.textwrapper = textwrap.TextWrapper()
107 self.textwrapper.width = 80
108 self.textwrapper.initial_indent = " > "
109 self.textwrapper.subsequent_indent = " "
110
111 def __str__(self):
112 """
113 Unified string representation method for all Problems.
114 """
115 if self.__class__.quiet:
116 return self.quiet_output()
117 return self.verbose_output()
118
119 @abc.abstractmethod
120 def quiet_output(self):
121 """
122 The output when --quiet is enabled.
123 """
124 pass
125
126 @abc.abstractmethod
127 def verbose_output(self):
128 """
129 The default output with explanation and code snippet if appropriate.
130 """
131 pass
132
133class SymbolNotInHeader(Problem): # pylint: disable=too-few-public-methods
134 """
135 A problem that occurs when an exported/available symbol in the object file
136 is not explicitly declared in header files. Created with
137 NameCheck.check_symbols_declared_in_header()
138
139 Fields:
140 * symbol_name: the name of the symbol.
141 """
142 def __init__(self, symbol_name):
143 self.symbol_name = symbol_name
144 Problem.__init__(self)
145
146 def quiet_output(self):
147 return "{0}".format(self.symbol_name)
148
149 def verbose_output(self):
150 return self.textwrapper.fill(
151 "'{0}' was found as an available symbol in the output of nm, "
152 "however it was not declared in any header files."
153 .format(self.symbol_name))
154
155class PatternMismatch(Problem): # pylint: disable=too-few-public-methods
156 """
157 A problem that occurs when something doesn't match the expected pattern.
158 Created with NameCheck.check_match_pattern()
159
160 Fields:
161 * pattern: the expected regex pattern
162 * match: the Match object in question
163 """
164 def __init__(self, pattern, match):
165 self.pattern = pattern
166 self.match = match
167 Problem.__init__(self)
168
169
170 def quiet_output(self):
171 return (
172 "{0}:{1}:{2}"
173 .format(self.match.filename, self.match.line_no, self.match.name)
174 )
175
176 def verbose_output(self):
177 return self.textwrapper.fill(
178 "{0}:{1}: '{2}' does not match the required pattern '{3}'."
179 .format(
180 self.match.filename,
181 self.match.line_no,
182 self.match.name,
183 self.pattern
184 )
185 ) + "\n" + str(self.match)
186
187class Typo(Problem): # pylint: disable=too-few-public-methods
188 """
189 A problem that occurs when a word using MBED doesn't appear to be defined as
190 constants nor enum values. Created with NameCheck.check_for_typos()
191
192 Fields:
193 * match: the Match object of the MBED name in question.
194 """
195 def __init__(self, match):
196 self.match = match
197 Problem.__init__(self)
198
199 def quiet_output(self):
200 return (
201 "{0}:{1}:{2}"
202 .format(self.match.filename, self.match.line_no, self.match.name)
203 )
204
205 def verbose_output(self):
206 return self.textwrapper.fill(
207 "{0}:{1}: '{2}' looks like a typo. It was not found in any "
208 "macros or any enums. If this is not a typo, put "
209 "//no-check-names after it."
210 .format(self.match.filename, self.match.line_no, self.match.name)
211 ) + "\n" + str(self.match)
212
213class CodeParser():
214 """
215 Class for retrieving files and parsing the code. This can be used
216 independently of the checks that NameChecker performs, for example for
217 list_internal_identifiers.py.
218 """
219 def __init__(self, log):
220 self.log = log
221 self.check_repo_path()
222
223 # Memo for storing "glob expression": set(filepaths)
224 self.files = {}
225
Gilles Peskine7bf52052021-09-27 19:20:17 +0200226 # Globally excluded filenames.
227 # Note that "*" can match directory separators in exclude lists.
Gilles Peskined47f6362021-09-27 20:12:00 +0200228 self.excluded_files = ["*/bn_mul", "*/compat-1.3.h"]
Gilles Peskine8266b5b2021-09-27 19:53:31 +0200229
230 @staticmethod
231 def check_repo_path():
232 """
233 Check that the current working directory is the project root, and throw
234 an exception if not.
235 """
236 if not all(os.path.isdir(d) for d in ["include", "library", "tests"]):
237 raise Exception("This script must be run from Mbed TLS root")
238
239 def comprehensive_parse(self):
240 """
241 Comprehensive ("default") function to call each parsing function and
242 retrieve various elements of the code, together with the source location.
243
244 Returns a dict of parsed item key to the corresponding List of Matches.
245 """
246 self.log.info("Parsing source code...")
247 self.log.debug(
248 "The following files are excluded from the search: {}"
249 .format(str(self.excluded_files))
250 )
251
252 all_macros = self.parse_macros([
253 "include/mbedtls/*.h",
254 "include/psa/*.h",
255 "library/*.h",
256 "tests/include/test/drivers/*.h",
257 "3rdparty/everest/include/everest/everest.h",
258 "3rdparty/everest/include/everest/x25519.h"
259 ])
260 enum_consts = self.parse_enum_consts([
261 "include/mbedtls/*.h",
262 "library/*.h",
263 "3rdparty/everest/include/everest/everest.h",
264 "3rdparty/everest/include/everest/x25519.h"
265 ])
266 identifiers = self.parse_identifiers([
267 "include/mbedtls/*.h",
268 "include/psa/*.h",
269 "library/*.h",
270 "3rdparty/everest/include/everest/everest.h",
271 "3rdparty/everest/include/everest/x25519.h"
272 ])
273 mbed_words = self.parse_mbed_words([
274 "include/mbedtls/*.h",
275 "include/psa/*.h",
276 "library/*.h",
277 "3rdparty/everest/include/everest/everest.h",
278 "3rdparty/everest/include/everest/x25519.h",
279 "library/*.c",
280 "3rdparty/everest/library/everest.c",
281 "3rdparty/everest/library/x25519.c"
282 ])
283 symbols = self.parse_symbols()
284
285 # Remove identifier macros like mbedtls_printf or mbedtls_calloc
286 identifiers_justname = [x.name for x in identifiers]
287 actual_macros = []
288 for macro in all_macros:
289 if macro.name not in identifiers_justname:
290 actual_macros.append(macro)
291
292 self.log.debug("Found:")
293 # Aligns the counts on the assumption that none exceeds 4 digits
294 self.log.debug(" {:4} Total Macros".format(len(all_macros)))
295 self.log.debug(" {:4} Non-identifier Macros".format(len(actual_macros)))
296 self.log.debug(" {:4} Enum Constants".format(len(enum_consts)))
297 self.log.debug(" {:4} Identifiers".format(len(identifiers)))
298 self.log.debug(" {:4} Exported Symbols".format(len(symbols)))
299 return {
300 "macros": actual_macros,
301 "enum_consts": enum_consts,
302 "identifiers": identifiers,
303 "symbols": symbols,
304 "mbed_words": mbed_words
305 }
306
Gilles Peskine7bf52052021-09-27 19:20:17 +0200307 def is_file_excluded(self, path, exclude_wildcards):
Gilles Peskine1c399752021-09-28 10:12:49 +0200308 """Whether the given file path is excluded."""
Gilles Peskine7bf52052021-09-27 19:20:17 +0200309 # exclude_wildcards may be None. Also, consider the global exclusions.
310 exclude_wildcards = (exclude_wildcards or []) + self.excluded_files
311 for pattern in exclude_wildcards:
312 if fnmatch.fnmatch(path, pattern):
313 return True
314 return False
315
Gilles Peskine8266b5b2021-09-27 19:53:31 +0200316 def get_files(self, include_wildcards, exclude_wildcards):
317 """
318 Get all files that match any of the UNIX-style wildcards. While the
319 check_names script is designed only for use on UNIX/macOS (due to nm),
320 this function alone would work fine on Windows even with forward slashes
321 in the wildcard.
322
323 Args:
324 * include_wildcards: a List of shell-style wildcards to match filepaths.
325 * exclude_wildcards: a List of shell-style wildcards to exclude.
326
327 Returns a List of relative filepaths.
328 """
329 accumulator = set()
330
Gilles Peskine8266b5b2021-09-27 19:53:31 +0200331 for include_wildcard in include_wildcards:
Gilles Peskine7bf52052021-09-27 19:20:17 +0200332 accumulator = accumulator.union(glob.iglob(include_wildcard))
Gilles Peskine8266b5b2021-09-27 19:53:31 +0200333
Gilles Peskine7bf52052021-09-27 19:20:17 +0200334 return list(path for path in accumulator
335 if not self.is_file_excluded(path, exclude_wildcards))
Gilles Peskine8266b5b2021-09-27 19:53:31 +0200336
337 def parse_macros(self, include, exclude=None):
338 """
339 Parse all macros defined by #define preprocessor directives.
340
341 Args:
342 * include: A List of glob expressions to look for files through.
343 * exclude: A List of glob expressions for excluding files.
344
345 Returns a List of Match objects for the found macros.
346 """
347 macro_regex = re.compile(r"# *define +(?P<macro>\w+)")
348 exclusions = (
349 "asm", "inline", "EMIT", "_CRT_SECURE_NO_DEPRECATE", "MULADDC_"
350 )
351
352 files = self.get_files(include, exclude)
353 self.log.debug("Looking for macros in {} files".format(len(files)))
354
355 macros = []
356 for header_file in files:
357 with open(header_file, "r", encoding="utf-8") as header:
358 for line_no, line in enumerate(header):
359 for macro in macro_regex.finditer(line):
360 if macro.group("macro").startswith(exclusions):
361 continue
362
363 macros.append(Match(
364 header_file,
365 line,
366 line_no,
367 macro.span("macro"),
368 macro.group("macro")))
369
370 return macros
371
372 def parse_mbed_words(self, include, exclude=None):
373 """
374 Parse all words in the file that begin with MBED, in and out of macros,
375 comments, anything.
376
377 Args:
378 * include: A List of glob expressions to look for files through.
379 * exclude: A List of glob expressions for excluding files.
380
381 Returns a List of Match objects for words beginning with MBED.
382 """
383 # Typos of TLS are common, hence the broader check below than MBEDTLS.
384 mbed_regex = re.compile(r"\bMBED.+?_[A-Z0-9_]*")
385 exclusions = re.compile(r"// *no-check-names|#error")
386
387 files = self.get_files(include, exclude)
388 self.log.debug("Looking for MBED words in {} files".format(len(files)))
389
390 mbed_words = []
391 for filename in files:
392 with open(filename, "r", encoding="utf-8") as fp:
393 for line_no, line in enumerate(fp):
394 if exclusions.search(line):
395 continue
396
397 for name in mbed_regex.finditer(line):
398 mbed_words.append(Match(
399 filename,
400 line,
401 line_no,
402 name.span(0),
403 name.group(0)))
404
405 return mbed_words
406
407 def parse_enum_consts(self, include, exclude=None):
408 """
409 Parse all enum value constants that are declared.
410
411 Args:
412 * include: A List of glob expressions to look for files through.
413 * exclude: A List of glob expressions for excluding files.
414
415 Returns a List of Match objects for the findings.
416 """
417 files = self.get_files(include, exclude)
418 self.log.debug("Looking for enum consts in {} files".format(len(files)))
419
420 # Emulate a finite state machine to parse enum declarations.
421 # OUTSIDE_KEYWORD = outside the enum keyword
422 # IN_BRACES = inside enum opening braces
423 # IN_BETWEEN = between enum keyword and opening braces
424 states = enum.Enum("FSM", ["OUTSIDE_KEYWORD", "IN_BRACES", "IN_BETWEEN"])
425 enum_consts = []
426 for header_file in files:
427 state = states.OUTSIDE_KEYWORD
428 with open(header_file, "r", encoding="utf-8") as header:
429 for line_no, line in enumerate(header):
430 # Match typedefs and brackets only when they are at the
431 # beginning of the line -- if they are indented, they might
432 # be sub-structures within structs, etc.
433 if (state == states.OUTSIDE_KEYWORD and
434 re.search(r"^(typedef +)?enum +{", line)):
435 state = states.IN_BRACES
436 elif (state == states.OUTSIDE_KEYWORD and
437 re.search(r"^(typedef +)?enum", line)):
438 state = states.IN_BETWEEN
439 elif (state == states.IN_BETWEEN and
440 re.search(r"^{", line)):
441 state = states.IN_BRACES
442 elif (state == states.IN_BRACES and
443 re.search(r"^}", line)):
444 state = states.OUTSIDE_KEYWORD
445 elif (state == states.IN_BRACES and
446 not re.search(r"^ *#", line)):
447 enum_const = re.search(r"^ *(?P<enum_const>\w+)", line)
448 if not enum_const:
449 continue
450
451 enum_consts.append(Match(
452 header_file,
453 line,
454 line_no,
455 enum_const.span("enum_const"),
456 enum_const.group("enum_const")))
457
458 return enum_consts
459
460 def parse_identifiers(self, include, exclude=None):
461 """
462 Parse all lines of a header where a function/enum/struct/union/typedef
463 identifier is declared, based on some regex and heuristics. Highly
464 dependent on formatting style.
465
466 Args:
467 * include: A List of glob expressions to look for files through.
468 * exclude: A List of glob expressions for excluding files.
469
470 Returns a List of Match objects with identifiers.
471 """
472 identifier_regex = re.compile(
473 # Match " something(a" or " *something(a". Functions.
474 # Assumptions:
475 # - function definition from return type to one of its arguments is
476 # all on one line
477 # - function definition line only contains alphanumeric, asterisk,
478 # underscore, and open bracket
479 r".* \**(\w+) *\( *\w|"
480 # Match "(*something)(".
481 r".*\( *\* *(\w+) *\) *\(|"
482 # Match names of named data structures.
483 r"(?:typedef +)?(?:struct|union|enum) +(\w+)(?: *{)?$|"
484 # Match names of typedef instances, after closing bracket.
485 r"}? *(\w+)[;[].*"
486 )
487 # The regex below is indented for clarity.
488 exclusion_lines = re.compile(
489 r"^("
490 r"extern +\"C\"|" # pylint: disable=bad-continuation
491 r"(typedef +)?(struct|union|enum)( *{)?$|"
492 r"} *;?$|"
493 r"$|"
494 r"//|"
495 r"#"
496 r")"
497 )
498
499 files = self.get_files(include, exclude)
500 self.log.debug("Looking for identifiers in {} files".format(len(files)))
501
502 identifiers = []
503 for header_file in files:
504 with open(header_file, "r", encoding="utf-8") as header:
505 in_block_comment = False
506 # The previous line variable is used for concatenating lines
507 # when identifiers are formatted and spread across multiple
508 # lines.
509 previous_line = ""
510
511 for line_no, line in enumerate(header):
512 # Skip parsing this line if a block comment ends on it,
513 # but don't skip if it has just started -- there is a chance
514 # it ends on the same line.
515 if re.search(r"/\*", line):
516 in_block_comment = not in_block_comment
517 if re.search(r"\*/", line):
518 in_block_comment = not in_block_comment
519 continue
520
521 if in_block_comment:
522 previous_line = ""
523 continue
524
525 if exclusion_lines.search(line):
526 previous_line = ""
527 continue
528
529 # If the line contains only space-separated alphanumeric
530 # characters (or underscore, asterisk, or, open bracket),
531 # and nothing else, high chance it's a declaration that
532 # continues on the next line
533 if re.search(r"^([\w\*\(]+\s+)+$", line):
534 previous_line += line
535 continue
536
537 # If previous line seemed to start an unfinished declaration
538 # (as above), concat and treat them as one.
539 if previous_line:
540 line = previous_line.strip() + " " + line.strip() + "\n"
541 previous_line = ""
542
543 # Skip parsing if line has a space in front = heuristic to
544 # skip function argument lines (highly subject to formatting
545 # changes)
546 if line[0] == " ":
547 continue
548
549 identifier = identifier_regex.search(line)
550
551 if not identifier:
552 continue
553
554 # Find the group that matched, and append it
555 for group in identifier.groups():
556 if not group:
557 continue
558
559 identifiers.append(Match(
560 header_file,
561 line,
562 line_no,
563 identifier.span(),
564 group))
565
566 return identifiers
567
568 def parse_symbols(self):
569 """
570 Compile the Mbed TLS libraries, and parse the TLS, Crypto, and x509
571 object files using nm to retrieve the list of referenced symbols.
572 Exceptions thrown here are rethrown because they would be critical
573 errors that void several tests, and thus needs to halt the program. This
574 is explicitly done for clarity.
575
576 Returns a List of unique symbols defined and used in the libraries.
577 """
578 self.log.info("Compiling...")
579 symbols = []
580
581 # Back up the config and atomically compile with the full configratuion.
582 shutil.copy(
Gilles Peskined47f6362021-09-27 20:12:00 +0200583 "include/mbedtls/config.h",
584 "include/mbedtls/config.h.bak"
Gilles Peskine8266b5b2021-09-27 19:53:31 +0200585 )
586 try:
587 # Use check=True in all subprocess calls so that failures are raised
588 # as exceptions and logged.
589 subprocess.run(
590 ["python3", "scripts/config.py", "full"],
591 universal_newlines=True,
592 check=True
593 )
594 my_environment = os.environ.copy()
595 my_environment["CFLAGS"] = "-fno-asynchronous-unwind-tables"
596 # Run make clean separately to lib to prevent unwanted behavior when
597 # make is invoked with parallelism.
598 subprocess.run(
599 ["make", "clean"],
600 universal_newlines=True,
601 check=True
602 )
603 subprocess.run(
604 ["make", "lib"],
605 env=my_environment,
606 universal_newlines=True,
607 stdout=subprocess.PIPE,
608 stderr=subprocess.STDOUT,
609 check=True
610 )
611
612 # Perform object file analysis using nm
613 symbols = self.parse_symbols_from_nm([
614 "library/libmbedcrypto.a",
615 "library/libmbedtls.a",
616 "library/libmbedx509.a"
617 ])
618
619 subprocess.run(
620 ["make", "clean"],
621 universal_newlines=True,
622 check=True
623 )
624 except subprocess.CalledProcessError as error:
625 self.log.debug(error.output)
626 raise error
627 finally:
628 # Put back the original config regardless of there being errors.
629 # Works also for keyboard interrupts.
630 shutil.move(
Gilles Peskined47f6362021-09-27 20:12:00 +0200631 "include/mbedtls/config.h.bak",
632 "include/mbedtls/config.h"
Gilles Peskine8266b5b2021-09-27 19:53:31 +0200633 )
634
635 return symbols
636
637 def parse_symbols_from_nm(self, object_files):
638 """
639 Run nm to retrieve the list of referenced symbols in each object file.
640 Does not return the position data since it is of no use.
641
642 Args:
643 * object_files: a List of compiled object filepaths to search through.
644
645 Returns a List of unique symbols defined and used in any of the object
646 files.
647 """
648 nm_undefined_regex = re.compile(r"^\S+: +U |^$|^\S+:$")
649 nm_valid_regex = re.compile(r"^\S+( [0-9A-Fa-f]+)* . _*(?P<symbol>\w+)")
650 exclusions = ("FStar", "Hacl")
651
652 symbols = []
653
654 # Gather all outputs of nm
655 nm_output = ""
656 for lib in object_files:
657 nm_output += subprocess.run(
658 ["nm", "-og", lib],
659 universal_newlines=True,
660 stdout=subprocess.PIPE,
661 stderr=subprocess.STDOUT,
662 check=True
663 ).stdout
664
665 for line in nm_output.splitlines():
666 if not nm_undefined_regex.search(line):
667 symbol = nm_valid_regex.search(line)
668 if (symbol and not symbol.group("symbol").startswith(exclusions)):
669 symbols.append(symbol.group("symbol"))
670 else:
671 self.log.error(line)
672
673 return symbols
674
675class NameChecker():
676 """
677 Representation of the core name checking operation performed by this script.
678 """
679 def __init__(self, parse_result, log):
680 self.parse_result = parse_result
681 self.log = log
682
683 def perform_checks(self, quiet=False):
684 """
685 A comprehensive checker that performs each check in order, and outputs
686 a final verdict.
687
688 Args:
689 * quiet: whether to hide detailed problem explanation.
690 """
691 self.log.info("=============")
692 Problem.quiet = quiet
693 problems = 0
694 problems += self.check_symbols_declared_in_header()
695
696 pattern_checks = [
697 ("macros", MACRO_PATTERN),
698 ("enum_consts", CONSTANTS_PATTERN),
699 ("identifiers", IDENTIFIER_PATTERN)
700 ]
701 for group, check_pattern in pattern_checks:
702 problems += self.check_match_pattern(group, check_pattern)
703
704 problems += self.check_for_typos()
705
706 self.log.info("=============")
707 if problems > 0:
708 self.log.info("FAIL: {0} problem(s) to fix".format(str(problems)))
709 if quiet:
710 self.log.info("Remove --quiet to see explanations.")
711 else:
712 self.log.info("Use --quiet for minimal output.")
713 return 1
714 else:
715 self.log.info("PASS")
716 return 0
717
718 def check_symbols_declared_in_header(self):
719 """
720 Perform a check that all detected symbols in the library object files
721 are properly declared in headers.
722 Assumes parse_names_in_source() was called before this.
723
724 Returns the number of problems that need fixing.
725 """
726 problems = []
727
728 for symbol in self.parse_result["symbols"]:
729 found_symbol_declared = False
730 for identifier_match in self.parse_result["identifiers"]:
731 if symbol == identifier_match.name:
732 found_symbol_declared = True
733 break
734
735 if not found_symbol_declared:
736 problems.append(SymbolNotInHeader(symbol))
737
738 self.output_check_result("All symbols in header", problems)
739 return len(problems)
740
741 def check_match_pattern(self, group_to_check, check_pattern):
742 """
743 Perform a check that all items of a group conform to a regex pattern.
744 Assumes parse_names_in_source() was called before this.
745
746 Args:
747 * group_to_check: string key to index into self.parse_result.
748 * check_pattern: the regex to check against.
749
750 Returns the number of problems that need fixing.
751 """
752 problems = []
753
754 for item_match in self.parse_result[group_to_check]:
755 if not re.search(check_pattern, item_match.name):
756 problems.append(PatternMismatch(check_pattern, item_match))
757 # Double underscore should not be used for names
758 if re.search(r".*__.*", item_match.name):
759 problems.append(
760 PatternMismatch("no double underscore allowed", item_match))
761
762 self.output_check_result(
763 "Naming patterns of {}".format(group_to_check),
764 problems)
765 return len(problems)
766
767 def check_for_typos(self):
768 """
769 Perform a check that all words in the soure code beginning with MBED are
770 either defined as macros, or as enum constants.
771 Assumes parse_names_in_source() was called before this.
772
773 Returns the number of problems that need fixing.
774 """
775 problems = []
776
777 # Set comprehension, equivalent to a list comprehension wrapped by set()
778 all_caps_names = {
779 match.name
780 for match
781 in self.parse_result["macros"] + self.parse_result["enum_consts"]}
Ronald Cronb814bda2021-09-13 14:50:42 +0200782 typo_exclusion = re.compile(r"XXX|__|_$|^MBEDTLS_.*CONFIG_FILE$|"
783 r"MBEDTLS_TEST_LIBTESTDRIVER*")
Gilles Peskine8266b5b2021-09-27 19:53:31 +0200784
785 for name_match in self.parse_result["mbed_words"]:
786 found = name_match.name in all_caps_names
787
788 # Since MBEDTLS_PSA_ACCEL_XXX defines are defined by the
789 # PSA driver, they will not exist as macros. However, they
790 # should still be checked for typos using the equivalent
791 # BUILTINs that exist.
792 if "MBEDTLS_PSA_ACCEL_" in name_match.name:
793 found = name_match.name.replace(
794 "MBEDTLS_PSA_ACCEL_",
795 "MBEDTLS_PSA_BUILTIN_") in all_caps_names
796
797 if not found and not typo_exclusion.search(name_match.name):
798 problems.append(Typo(name_match))
799
800 self.output_check_result("Likely typos", problems)
801 return len(problems)
802
803 def output_check_result(self, name, problems):
804 """
805 Write out the PASS/FAIL status of a performed check depending on whether
806 there were problems.
807
808 Args:
809 * name: the name of the test
810 * problems: a List of encountered Problems
811 """
812 if problems:
813 self.log.info("{}: FAIL\n".format(name))
814 for problem in problems:
815 self.log.warning(str(problem))
816 else:
817 self.log.info("{}: PASS".format(name))
818
819def main():
820 """
821 Perform argument parsing, and create an instance of CodeParser and
822 NameChecker to begin the core operation.
823 """
824 parser = argparse.ArgumentParser(
825 formatter_class=argparse.RawDescriptionHelpFormatter,
826 description=(
827 "This script confirms that the naming of all symbols and identifiers "
828 "in Mbed TLS are consistent with the house style and are also "
829 "self-consistent.\n\n"
830 "Expected to be run from the MbedTLS root directory.")
831 )
832 parser.add_argument(
833 "-v", "--verbose",
834 action="store_true",
835 help="show parse results"
836 )
837 parser.add_argument(
838 "-q", "--quiet",
839 action="store_true",
840 help="hide unnecessary text, explanations, and highlighs"
841 )
842
843 args = parser.parse_args()
844
845 # Configure the global logger, which is then passed to the classes below
846 log = logging.getLogger()
847 log.setLevel(logging.DEBUG if args.verbose else logging.INFO)
848 log.addHandler(logging.StreamHandler())
849
850 try:
851 code_parser = CodeParser(log)
852 parse_result = code_parser.comprehensive_parse()
853 except Exception: # pylint: disable=broad-except
854 traceback.print_exc()
855 sys.exit(2)
856
857 name_checker = NameChecker(parse_result, log)
858 return_code = name_checker.perform_checks(quiet=args.quiet)
859
860 sys.exit(return_code)
861
862if __name__ == "__main__":
863 main()