David Brazdil | 7a462ec | 2019-08-15 12:27:47 +0100 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2019 The Hafnium Authors. |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * https://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #include "hf/manifest.h" |
| 18 | |
| 19 | #include "hf/addr.h" |
| 20 | #include "hf/check.h" |
Andrew Scull | ae9962e | 2019-10-03 16:51:16 +0100 | [diff] [blame] | 21 | #include "hf/dlog.h" |
David Brazdil | 7a462ec | 2019-08-15 12:27:47 +0100 | [diff] [blame] | 22 | #include "hf/fdt.h" |
| 23 | #include "hf/static_assert.h" |
| 24 | #include "hf/std.h" |
| 25 | |
| 26 | #define TRY(expr) \ |
| 27 | do { \ |
| 28 | enum manifest_return_code ret_code = (expr); \ |
| 29 | if (ret_code != MANIFEST_SUCCESS) { \ |
| 30 | return ret_code; \ |
| 31 | } \ |
| 32 | } while (0) |
| 33 | |
| 34 | #define VM_NAME_BUF_SIZE (2 + 5 + 1) /* "vm" + number + null terminator */ |
| 35 | static_assert(MAX_VMS <= 99999, "Insufficient VM_NAME_BUF_SIZE"); |
Andrew Walbran | 9daa57e | 2019-09-27 13:33:20 +0100 | [diff] [blame] | 36 | static_assert(HF_TEE_VM_ID > MAX_VMS, |
| 37 | "TrustZone VM ID clashes with normal VM range."); |
David Brazdil | 7a462ec | 2019-08-15 12:27:47 +0100 | [diff] [blame] | 38 | |
| 39 | /** |
| 40 | * Generates a string with the two letters "vm" followed by an integer. |
| 41 | * Assumes `buf` is of size VM_NAME_BUF_SIZE. |
| 42 | */ |
| 43 | static const char *generate_vm_node_name(char *buf, spci_vm_id_t vm_id) |
| 44 | { |
| 45 | static const char *digits = "0123456789"; |
| 46 | char *ptr = buf + VM_NAME_BUF_SIZE; |
| 47 | |
| 48 | *(--ptr) = '\0'; |
| 49 | do { |
| 50 | *(--ptr) = digits[vm_id % 10]; |
| 51 | vm_id /= 10; |
| 52 | } while (vm_id); |
| 53 | *(--ptr) = 'm'; |
| 54 | *(--ptr) = 'v'; |
| 55 | |
| 56 | return ptr; |
| 57 | } |
| 58 | |
Andrew Scull | ae9962e | 2019-10-03 16:51:16 +0100 | [diff] [blame] | 59 | /** |
Andrew Scull | b2c3a24 | 2019-11-04 13:52:36 +0000 | [diff] [blame] | 60 | * Read a boolean property: true if present; false if not. If present, the value |
| 61 | * of the property must be empty else it is considered malformed. |
Andrew Scull | ae9962e | 2019-10-03 16:51:16 +0100 | [diff] [blame] | 62 | */ |
Andrew Scull | b2c3a24 | 2019-11-04 13:52:36 +0000 | [diff] [blame] | 63 | static enum manifest_return_code read_bool(const struct fdt_node *node, |
| 64 | const char *property, bool *out) |
Andrew Scull | ae9962e | 2019-10-03 16:51:16 +0100 | [diff] [blame] | 65 | { |
| 66 | const char *data; |
| 67 | uint32_t size; |
Andrew Scull | b2c3a24 | 2019-11-04 13:52:36 +0000 | [diff] [blame] | 68 | bool present = fdt_read_property(node, property, &data, &size); |
Andrew Scull | ae9962e | 2019-10-03 16:51:16 +0100 | [diff] [blame] | 69 | |
Andrew Scull | b2c3a24 | 2019-11-04 13:52:36 +0000 | [diff] [blame] | 70 | if (present && size != 0) { |
| 71 | return MANIFEST_ERROR_MALFORMED_BOOLEAN; |
| 72 | } |
| 73 | |
| 74 | *out = present; |
| 75 | return MANIFEST_SUCCESS; |
Andrew Scull | ae9962e | 2019-10-03 16:51:16 +0100 | [diff] [blame] | 76 | } |
| 77 | |
Andrew Scull | 72b43c0 | 2019-09-18 13:53:45 +0100 | [diff] [blame] | 78 | static enum manifest_return_code read_string(const struct fdt_node *node, |
David Brazdil | 136f294 | 2019-09-23 14:11:03 +0100 | [diff] [blame] | 79 | const char *property, |
| 80 | struct string *out) |
Andrew Scull | 72b43c0 | 2019-09-18 13:53:45 +0100 | [diff] [blame] | 81 | { |
| 82 | const char *data; |
| 83 | uint32_t size; |
| 84 | |
| 85 | if (!fdt_read_property(node, property, &data, &size)) { |
| 86 | return MANIFEST_ERROR_PROPERTY_NOT_FOUND; |
| 87 | } |
| 88 | |
David Brazdil | 136f294 | 2019-09-23 14:11:03 +0100 | [diff] [blame] | 89 | switch (string_init(out, data, size)) { |
| 90 | case STRING_SUCCESS: |
| 91 | return MANIFEST_SUCCESS; |
| 92 | case STRING_ERROR_INVALID_INPUT: |
| 93 | return MANIFEST_ERROR_MALFORMED_STRING; |
| 94 | case STRING_ERROR_TOO_LONG: |
| 95 | return MANIFEST_ERROR_STRING_TOO_LONG; |
| 96 | } |
Andrew Scull | 72b43c0 | 2019-09-18 13:53:45 +0100 | [diff] [blame] | 97 | } |
| 98 | |
| 99 | static enum manifest_return_code read_optional_string( |
David Brazdil | 136f294 | 2019-09-23 14:11:03 +0100 | [diff] [blame] | 100 | const struct fdt_node *node, const char *property, struct string *out) |
Andrew Scull | 72b43c0 | 2019-09-18 13:53:45 +0100 | [diff] [blame] | 101 | { |
David Brazdil | 136f294 | 2019-09-23 14:11:03 +0100 | [diff] [blame] | 102 | enum manifest_return_code ret; |
Andrew Scull | 72b43c0 | 2019-09-18 13:53:45 +0100 | [diff] [blame] | 103 | |
David Brazdil | 136f294 | 2019-09-23 14:11:03 +0100 | [diff] [blame] | 104 | ret = read_string(node, property, out); |
| 105 | if (ret == MANIFEST_ERROR_PROPERTY_NOT_FOUND) { |
| 106 | string_init_empty(out); |
| 107 | ret = MANIFEST_SUCCESS; |
Andrew Scull | 72b43c0 | 2019-09-18 13:53:45 +0100 | [diff] [blame] | 108 | } |
David Brazdil | 136f294 | 2019-09-23 14:11:03 +0100 | [diff] [blame] | 109 | return ret; |
Andrew Scull | 72b43c0 | 2019-09-18 13:53:45 +0100 | [diff] [blame] | 110 | } |
| 111 | |
David Brazdil | 7a462ec | 2019-08-15 12:27:47 +0100 | [diff] [blame] | 112 | static enum manifest_return_code read_uint64(const struct fdt_node *node, |
| 113 | const char *property, |
| 114 | uint64_t *out) |
| 115 | { |
| 116 | const char *data; |
| 117 | uint32_t size; |
| 118 | |
| 119 | if (!fdt_read_property(node, property, &data, &size)) { |
| 120 | return MANIFEST_ERROR_PROPERTY_NOT_FOUND; |
| 121 | } |
| 122 | |
| 123 | if (!fdt_parse_number(data, size, out)) { |
| 124 | return MANIFEST_ERROR_MALFORMED_INTEGER; |
| 125 | } |
| 126 | |
| 127 | return MANIFEST_SUCCESS; |
| 128 | } |
| 129 | |
| 130 | static enum manifest_return_code read_uint16(const struct fdt_node *node, |
| 131 | const char *property, |
| 132 | uint16_t *out) |
| 133 | { |
| 134 | uint64_t value; |
| 135 | |
| 136 | TRY(read_uint64(node, property, &value)); |
| 137 | |
| 138 | if (value > UINT16_MAX) { |
| 139 | return MANIFEST_ERROR_INTEGER_OVERFLOW; |
| 140 | } |
| 141 | |
| 142 | *out = (uint16_t)value; |
| 143 | return MANIFEST_SUCCESS; |
| 144 | } |
| 145 | |
Andrew Scull | ae9962e | 2019-10-03 16:51:16 +0100 | [diff] [blame] | 146 | struct uint32list_iter { |
| 147 | struct memiter mem_it; |
| 148 | }; |
| 149 | |
| 150 | static enum manifest_return_code read_optional_uint32list( |
| 151 | const struct fdt_node *node, const char *property, |
| 152 | struct uint32list_iter *out) |
| 153 | { |
| 154 | const char *data; |
| 155 | uint32_t size; |
| 156 | |
| 157 | if (!fdt_read_property(node, property, &data, &size)) { |
| 158 | memiter_init(&out->mem_it, NULL, 0); |
| 159 | return MANIFEST_SUCCESS; |
| 160 | } |
| 161 | |
| 162 | if ((size % sizeof(uint32_t)) != 0) { |
| 163 | return MANIFEST_ERROR_MALFORMED_INTEGER_LIST; |
| 164 | } |
| 165 | |
| 166 | memiter_init(&out->mem_it, data, size); |
| 167 | return MANIFEST_SUCCESS; |
| 168 | } |
| 169 | |
David Brazdil | 74e9c3b | 2019-08-28 11:09:08 +0100 | [diff] [blame] | 170 | /** |
| 171 | * Represents the value of property whose type is a list of strings. These are |
| 172 | * encoded as one contiguous byte buffer with NULL-separated entries. |
| 173 | */ |
| 174 | struct stringlist_iter { |
| 175 | struct memiter mem_it; |
| 176 | }; |
| 177 | |
| 178 | static enum manifest_return_code read_stringlist(const struct fdt_node *node, |
| 179 | const char *property, |
| 180 | struct stringlist_iter *out) |
| 181 | { |
| 182 | const char *data; |
| 183 | uint32_t size; |
| 184 | |
| 185 | if (!fdt_read_property(node, property, &data, &size)) { |
| 186 | return MANIFEST_ERROR_PROPERTY_NOT_FOUND; |
| 187 | } |
| 188 | |
| 189 | /* |
| 190 | * Require that the value ends with a NULL terminator. Other NULL |
| 191 | * characters separate the string list entries. |
| 192 | */ |
| 193 | if (data[size - 1] != '\0') { |
| 194 | return MANIFEST_ERROR_MALFORMED_STRING_LIST; |
| 195 | } |
| 196 | |
| 197 | memiter_init(&out->mem_it, data, size - 1); |
| 198 | return MANIFEST_SUCCESS; |
| 199 | } |
| 200 | |
Andrew Scull | ae9962e | 2019-10-03 16:51:16 +0100 | [diff] [blame] | 201 | static bool uint32list_has_next(const struct uint32list_iter *list) |
| 202 | { |
| 203 | return memiter_size(&list->mem_it) > 0; |
| 204 | } |
| 205 | |
| 206 | static uint32_t uint32list_get_next(struct uint32list_iter *list) |
| 207 | { |
| 208 | const char *mem_base = memiter_base(&list->mem_it); |
| 209 | uint64_t num; |
| 210 | |
| 211 | CHECK(uint32list_has_next(list)); |
| 212 | |
| 213 | if (!fdt_parse_number(mem_base, sizeof(uint32_t), &num)) { |
| 214 | return MANIFEST_ERROR_MALFORMED_INTEGER; |
| 215 | } |
| 216 | |
| 217 | memiter_advance(&list->mem_it, sizeof(uint32_t)); |
| 218 | return num; |
| 219 | } |
| 220 | |
David Brazdil | 74e9c3b | 2019-08-28 11:09:08 +0100 | [diff] [blame] | 221 | static bool stringlist_has_next(const struct stringlist_iter *list) |
| 222 | { |
| 223 | return memiter_size(&list->mem_it) > 0; |
| 224 | } |
| 225 | |
| 226 | static void stringlist_get_next(struct stringlist_iter *list, |
| 227 | struct memiter *out) |
| 228 | { |
| 229 | const char *mem_base = memiter_base(&list->mem_it); |
| 230 | size_t mem_size = memiter_size(&list->mem_it); |
| 231 | const char *null_term; |
| 232 | |
| 233 | CHECK(stringlist_has_next(list)); |
| 234 | |
| 235 | null_term = memchr(mem_base, '\0', mem_size); |
| 236 | if (null_term == NULL) { |
| 237 | /* |
| 238 | * NULL terminator not found, this is the last entry. |
| 239 | * Set entry memiter to the entire byte range and advance list |
| 240 | * memiter to the end of the byte range. |
| 241 | */ |
| 242 | memiter_init(out, mem_base, mem_size); |
| 243 | memiter_advance(&list->mem_it, mem_size); |
| 244 | } else { |
| 245 | /* |
| 246 | * Found NULL terminator. Set entry memiter to byte range |
| 247 | * [base, null) and move list memiter past the terminator. |
| 248 | */ |
| 249 | size_t entry_size = null_term - mem_base; |
| 250 | |
| 251 | memiter_init(out, mem_base, entry_size); |
| 252 | memiter_advance(&list->mem_it, entry_size + 1); |
| 253 | } |
| 254 | } |
| 255 | |
| 256 | static bool stringlist_contains(const struct stringlist_iter *list, |
| 257 | const char *str) |
| 258 | { |
| 259 | struct stringlist_iter it = *list; |
| 260 | struct memiter entry; |
| 261 | |
| 262 | while (stringlist_has_next(&it)) { |
| 263 | stringlist_get_next(&it, &entry); |
| 264 | if (memiter_iseq(&entry, str)) { |
| 265 | return true; |
| 266 | } |
| 267 | } |
| 268 | return false; |
| 269 | } |
| 270 | |
David Brazdil | 7a462ec | 2019-08-15 12:27:47 +0100 | [diff] [blame] | 271 | static enum manifest_return_code parse_vm(struct fdt_node *node, |
| 272 | struct manifest_vm *vm, |
| 273 | spci_vm_id_t vm_id) |
| 274 | { |
Andrew Scull | ae9962e | 2019-10-03 16:51:16 +0100 | [diff] [blame] | 275 | struct uint32list_iter smcs; |
| 276 | |
David Brazdil | 136f294 | 2019-09-23 14:11:03 +0100 | [diff] [blame] | 277 | TRY(read_string(node, "debug_name", &vm->debug_name)); |
| 278 | TRY(read_optional_string(node, "kernel_filename", |
| 279 | &vm->kernel_filename)); |
Andrew Scull | ae9962e | 2019-10-03 16:51:16 +0100 | [diff] [blame] | 280 | |
| 281 | TRY(read_optional_uint32list(node, "smc_whitelist", &smcs)); |
| 282 | while (uint32list_has_next(&smcs) && |
| 283 | vm->smc_whitelist.smc_count < MAX_SMCS) { |
| 284 | vm->smc_whitelist.smcs[vm->smc_whitelist.smc_count++] = |
| 285 | uint32list_get_next(&smcs); |
| 286 | } |
| 287 | |
| 288 | if (uint32list_has_next(&smcs)) { |
Andrew Walbran | 17eebf9 | 2020-02-05 16:35:49 +0000 | [diff] [blame] | 289 | dlog_warning("%s SMC whitelist too long.\n", vm->debug_name); |
Andrew Scull | ae9962e | 2019-10-03 16:51:16 +0100 | [diff] [blame] | 290 | } |
| 291 | |
Andrew Scull | b2c3a24 | 2019-11-04 13:52:36 +0000 | [diff] [blame] | 292 | TRY(read_bool(node, "smc_whitelist_permissive", |
| 293 | &vm->smc_whitelist.permissive)); |
Andrew Scull | ae9962e | 2019-10-03 16:51:16 +0100 | [diff] [blame] | 294 | |
David Brazdil | e6f8322 | 2019-09-23 14:47:37 +0100 | [diff] [blame] | 295 | if (vm_id == HF_PRIMARY_VM_ID) { |
| 296 | TRY(read_optional_string(node, "ramdisk_filename", |
| 297 | &vm->primary.ramdisk_filename)); |
| 298 | } else { |
David Brazdil | 7a462ec | 2019-08-15 12:27:47 +0100 | [diff] [blame] | 299 | TRY(read_uint64(node, "mem_size", &vm->secondary.mem_size)); |
| 300 | TRY(read_uint16(node, "vcpu_count", &vm->secondary.vcpu_count)); |
| 301 | } |
| 302 | return MANIFEST_SUCCESS; |
| 303 | } |
| 304 | |
| 305 | /** |
| 306 | * Parse manifest from FDT. |
| 307 | */ |
| 308 | enum manifest_return_code manifest_init(struct manifest *manifest, |
David Brazdil | a2358d4 | 2020-01-27 18:51:38 +0000 | [diff] [blame] | 309 | struct memiter *manifest_fdt) |
David Brazdil | 7a462ec | 2019-08-15 12:27:47 +0100 | [diff] [blame] | 310 | { |
| 311 | char vm_name_buf[VM_NAME_BUF_SIZE]; |
David Brazdil | a2358d4 | 2020-01-27 18:51:38 +0000 | [diff] [blame] | 312 | const struct fdt_header *fdt; |
David Brazdil | 7a462ec | 2019-08-15 12:27:47 +0100 | [diff] [blame] | 313 | struct fdt_node hyp_node; |
David Brazdil | 74e9c3b | 2019-08-28 11:09:08 +0100 | [diff] [blame] | 314 | struct stringlist_iter compatible_list; |
David Brazdil | 7a462ec | 2019-08-15 12:27:47 +0100 | [diff] [blame] | 315 | size_t i = 0; |
| 316 | bool found_primary_vm = false; |
| 317 | |
| 318 | memset_s(manifest, sizeof(*manifest), 0, sizeof(*manifest)); |
| 319 | |
David Brazdil | a2358d4 | 2020-01-27 18:51:38 +0000 | [diff] [blame] | 320 | fdt = (const struct fdt_header *)memiter_base(manifest_fdt); |
| 321 | if (memiter_size(manifest_fdt) != fdt_total_size(fdt)) { |
| 322 | return MANIFEST_ERROR_FILE_SIZE; |
| 323 | } |
| 324 | |
David Brazdil | 7a462ec | 2019-08-15 12:27:47 +0100 | [diff] [blame] | 325 | /* Find hypervisor node. */ |
David Brazdil | a2358d4 | 2020-01-27 18:51:38 +0000 | [diff] [blame] | 326 | if (!fdt_root_node(&hyp_node, fdt)) { |
| 327 | return MANIFEST_ERROR_NO_ROOT_NODE; |
| 328 | } |
| 329 | if (!fdt_find_child(&hyp_node, "")) { |
| 330 | return MANIFEST_ERROR_NO_ROOT_NODE; |
| 331 | } |
David Brazdil | 7a462ec | 2019-08-15 12:27:47 +0100 | [diff] [blame] | 332 | if (!fdt_find_child(&hyp_node, "hypervisor")) { |
| 333 | return MANIFEST_ERROR_NO_HYPERVISOR_FDT_NODE; |
| 334 | } |
| 335 | |
David Brazdil | 74e9c3b | 2019-08-28 11:09:08 +0100 | [diff] [blame] | 336 | /* Check "compatible" property. */ |
| 337 | TRY(read_stringlist(&hyp_node, "compatible", &compatible_list)); |
| 338 | if (!stringlist_contains(&compatible_list, "hafnium,hafnium")) { |
| 339 | return MANIFEST_ERROR_NOT_COMPATIBLE; |
| 340 | } |
| 341 | |
David Brazdil | 7a462ec | 2019-08-15 12:27:47 +0100 | [diff] [blame] | 342 | /* Iterate over reserved VM IDs and check no such nodes exist. */ |
| 343 | for (i = 0; i < HF_VM_ID_OFFSET; i++) { |
| 344 | spci_vm_id_t vm_id = (spci_vm_id_t)i; |
| 345 | struct fdt_node vm_node = hyp_node; |
| 346 | const char *vm_name = generate_vm_node_name(vm_name_buf, vm_id); |
| 347 | |
| 348 | if (fdt_find_child(&vm_node, vm_name)) { |
| 349 | return MANIFEST_ERROR_RESERVED_VM_ID; |
| 350 | } |
| 351 | } |
| 352 | |
| 353 | /* Iterate over VM nodes until we find one that does not exist. */ |
| 354 | for (i = 0; i <= MAX_VMS; ++i) { |
| 355 | spci_vm_id_t vm_id = HF_VM_ID_OFFSET + i; |
| 356 | struct fdt_node vm_node = hyp_node; |
| 357 | const char *vm_name = generate_vm_node_name(vm_name_buf, vm_id); |
| 358 | |
| 359 | if (!fdt_find_child(&vm_node, vm_name)) { |
| 360 | break; |
| 361 | } |
| 362 | |
| 363 | if (i == MAX_VMS) { |
| 364 | return MANIFEST_ERROR_TOO_MANY_VMS; |
| 365 | } |
| 366 | |
| 367 | if (vm_id == HF_PRIMARY_VM_ID) { |
| 368 | CHECK(found_primary_vm == false); /* sanity check */ |
| 369 | found_primary_vm = true; |
| 370 | } |
| 371 | |
David Brazdil | 0251b94 | 2019-09-10 15:59:50 +0100 | [diff] [blame] | 372 | manifest->vm_count = i + 1; |
David Brazdil | 7a462ec | 2019-08-15 12:27:47 +0100 | [diff] [blame] | 373 | TRY(parse_vm(&vm_node, &manifest->vm[i], vm_id)); |
| 374 | } |
| 375 | |
| 376 | if (!found_primary_vm) { |
| 377 | return MANIFEST_ERROR_NO_PRIMARY_VM; |
| 378 | } |
| 379 | |
| 380 | return MANIFEST_SUCCESS; |
| 381 | } |
| 382 | |
| 383 | const char *manifest_strerror(enum manifest_return_code ret_code) |
| 384 | { |
| 385 | switch (ret_code) { |
| 386 | case MANIFEST_SUCCESS: |
| 387 | return "Success"; |
David Brazdil | a2358d4 | 2020-01-27 18:51:38 +0000 | [diff] [blame] | 388 | case MANIFEST_ERROR_FILE_SIZE: |
| 389 | return "Total size in header does not match file size"; |
| 390 | case MANIFEST_ERROR_NO_ROOT_NODE: |
| 391 | return "Could not find root node in manifest"; |
David Brazdil | 7a462ec | 2019-08-15 12:27:47 +0100 | [diff] [blame] | 392 | case MANIFEST_ERROR_NO_HYPERVISOR_FDT_NODE: |
| 393 | return "Could not find \"hypervisor\" node in manifest"; |
David Brazdil | 74e9c3b | 2019-08-28 11:09:08 +0100 | [diff] [blame] | 394 | case MANIFEST_ERROR_NOT_COMPATIBLE: |
| 395 | return "Hypervisor manifest entry not compatible with Hafnium"; |
David Brazdil | 7a462ec | 2019-08-15 12:27:47 +0100 | [diff] [blame] | 396 | case MANIFEST_ERROR_RESERVED_VM_ID: |
| 397 | return "Manifest defines a VM with a reserved ID"; |
| 398 | case MANIFEST_ERROR_NO_PRIMARY_VM: |
| 399 | return "Manifest does not contain a primary VM entry"; |
| 400 | case MANIFEST_ERROR_TOO_MANY_VMS: |
| 401 | return "Manifest specifies more VMs than Hafnium has " |
| 402 | "statically allocated space for"; |
| 403 | case MANIFEST_ERROR_PROPERTY_NOT_FOUND: |
| 404 | return "Property not found"; |
| 405 | case MANIFEST_ERROR_MALFORMED_STRING: |
| 406 | return "Malformed string property"; |
David Brazdil | 0dbb41f | 2019-09-09 18:03:35 +0100 | [diff] [blame] | 407 | case MANIFEST_ERROR_STRING_TOO_LONG: |
| 408 | return "String too long"; |
David Brazdil | 74e9c3b | 2019-08-28 11:09:08 +0100 | [diff] [blame] | 409 | case MANIFEST_ERROR_MALFORMED_STRING_LIST: |
| 410 | return "Malformed string list property"; |
David Brazdil | 7a462ec | 2019-08-15 12:27:47 +0100 | [diff] [blame] | 411 | case MANIFEST_ERROR_MALFORMED_INTEGER: |
| 412 | return "Malformed integer property"; |
| 413 | case MANIFEST_ERROR_INTEGER_OVERFLOW: |
| 414 | return "Integer overflow"; |
Andrew Scull | ae9962e | 2019-10-03 16:51:16 +0100 | [diff] [blame] | 415 | case MANIFEST_ERROR_MALFORMED_INTEGER_LIST: |
| 416 | return "Malformed integer list property"; |
Andrew Scull | b2c3a24 | 2019-11-04 13:52:36 +0000 | [diff] [blame] | 417 | case MANIFEST_ERROR_MALFORMED_BOOLEAN: |
| 418 | return "Malformed boolean property"; |
David Brazdil | 7a462ec | 2019-08-15 12:27:47 +0100 | [diff] [blame] | 419 | } |
| 420 | |
| 421 | panic("Unexpected manifest return code."); |
| 422 | } |