Andrew Scull | 1883487 | 2018-10-12 11:48:09 +0100 | [diff] [blame] | 1 | /* |
Andrew Walbran | 692b325 | 2019-03-07 15:51:31 +0000 | [diff] [blame] | 2 | * Copyright 2018 The Hafnium Authors. |
Andrew Scull | 1883487 | 2018-10-12 11:48:09 +0100 | [diff] [blame] | 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * https://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Andrew Scull | 18c78fc | 2018-08-20 12:57:41 +0100 | [diff] [blame] | 17 | #include "hf/api.h" |
Wedson Almeida Filho | 3fcbcff | 2018-07-10 23:53:39 +0100 | [diff] [blame] | 18 | |
Andrew Walbran | 318f573 | 2018-11-20 16:23:42 +0000 | [diff] [blame] | 19 | #include "hf/arch/cpu.h" |
Andrew Walbran | 508e63c | 2018-12-20 17:02:37 +0000 | [diff] [blame] | 20 | #include "hf/arch/timer.h" |
Andrew Walbran | 318f573 | 2018-11-20 16:23:42 +0000 | [diff] [blame] | 21 | |
Andrew Scull | 877ae4b | 2019-07-02 12:52:33 +0100 | [diff] [blame] | 22 | #include "hf/check.h" |
Andrew Walbran | 318f573 | 2018-11-20 16:23:42 +0000 | [diff] [blame] | 23 | #include "hf/dlog.h" |
Andrew Scull | 6386f25 | 2018-12-06 13:29:10 +0000 | [diff] [blame] | 24 | #include "hf/mm.h" |
Andrew Walbran | c1ad4ce | 2019-05-09 11:41:39 +0100 | [diff] [blame] | 25 | #include "hf/plat/console.h" |
Jose Marinho | 40d55f3 | 2019-07-01 15:41:54 +0100 | [diff] [blame] | 26 | #include "hf/spci_internal.h" |
Andrew Scull | 6386f25 | 2018-12-06 13:29:10 +0000 | [diff] [blame] | 27 | #include "hf/spinlock.h" |
Andrew Scull | 877ae4b | 2019-07-02 12:52:33 +0100 | [diff] [blame] | 28 | #include "hf/static_assert.h" |
Andrew Scull | 8d9e121 | 2019-04-05 13:52:55 +0100 | [diff] [blame] | 29 | #include "hf/std.h" |
Andrew Scull | 18c78fc | 2018-08-20 12:57:41 +0100 | [diff] [blame] | 30 | #include "hf/vm.h" |
| 31 | |
Andrew Scull | f35a5c9 | 2018-08-07 18:09:46 +0100 | [diff] [blame] | 32 | #include "vmapi/hf/call.h" |
Jose Marinho | a1dfeda | 2019-02-27 16:46:03 +0000 | [diff] [blame] | 33 | #include "vmapi/hf/spci.h" |
Wedson Almeida Filho | 3fcbcff | 2018-07-10 23:53:39 +0100 | [diff] [blame] | 34 | |
Wedson Almeida Filho | ba641ef | 2018-12-03 04:19:44 +0000 | [diff] [blame] | 35 | /* |
| 36 | * To eliminate the risk of deadlocks, we define a partial order for the |
| 37 | * acquisition of locks held concurrently by the same physical CPU. Our current |
| 38 | * ordering requirements are as follows: |
| 39 | * |
Andrew Walbran | c1ad4ce | 2019-05-09 11:41:39 +0100 | [diff] [blame] | 40 | * vm::lock -> vcpu::lock -> mm_stage1_lock -> dlog sl |
Andrew Scull | 6386f25 | 2018-12-06 13:29:10 +0000 | [diff] [blame] | 41 | * |
Andrew Scull | 4caadaf | 2019-07-03 13:13:47 +0100 | [diff] [blame] | 42 | * Locks of the same kind require the lock of lowest address to be locked first, |
| 43 | * see `sl_lock_both()`. |
Wedson Almeida Filho | ba641ef | 2018-12-03 04:19:44 +0000 | [diff] [blame] | 44 | */ |
| 45 | |
Andrew Scull | aa039b3 | 2018-10-04 15:02:26 +0100 | [diff] [blame] | 46 | static_assert(HF_MAILBOX_SIZE == PAGE_SIZE, |
Andrew Scull | 13652af | 2018-09-17 14:49:08 +0100 | [diff] [blame] | 47 | "Currently, a page is mapped for the send and receive buffers so " |
| 48 | "the maximum request is the size of a page."); |
| 49 | |
Wedson Almeida Filho | 9ed8da5 | 2018-12-17 16:09:11 +0000 | [diff] [blame] | 50 | static struct mpool api_page_pool; |
Wedson Almeida Filho | 22d5eaa | 2018-12-16 00:38:49 +0000 | [diff] [blame] | 51 | |
| 52 | /** |
Wedson Almeida Filho | 81568c4 | 2019-01-04 13:33:02 +0000 | [diff] [blame] | 53 | * Initialises the API page pool by taking ownership of the contents of the |
| 54 | * given page pool. |
Wedson Almeida Filho | 22d5eaa | 2018-12-16 00:38:49 +0000 | [diff] [blame] | 55 | */ |
| 56 | void api_init(struct mpool *ppool) |
| 57 | { |
Wedson Almeida Filho | 9ed8da5 | 2018-12-17 16:09:11 +0000 | [diff] [blame] | 58 | mpool_init_from(&api_page_pool, ppool); |
Wedson Almeida Filho | 22d5eaa | 2018-12-16 00:38:49 +0000 | [diff] [blame] | 59 | } |
| 60 | |
Wedson Almeida Filho | 3fcbcff | 2018-07-10 23:53:39 +0100 | [diff] [blame] | 61 | /** |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 62 | * Switches the physical CPU back to the corresponding vcpu of the primary VM. |
Andrew Scull | aa039b3 | 2018-10-04 15:02:26 +0100 | [diff] [blame] | 63 | * |
| 64 | * This triggers the scheduling logic to run. Run in the context of secondary VM |
| 65 | * to cause HF_VCPU_RUN to return and the primary VM to regain control of the |
| 66 | * cpu. |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 67 | */ |
Wedson Almeida Filho | 00df6c7 | 2018-10-18 11:19:24 +0100 | [diff] [blame] | 68 | static struct vcpu *api_switch_to_primary(struct vcpu *current, |
Wedson Almeida Filho | ba641ef | 2018-12-03 04:19:44 +0000 | [diff] [blame] | 69 | struct hf_vcpu_run_return primary_ret, |
| 70 | enum vcpu_state secondary_state) |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 71 | { |
Andrew Walbran | 42347a9 | 2019-05-09 13:59:03 +0100 | [diff] [blame] | 72 | struct vm *primary = vm_find(HF_PRIMARY_VM_ID); |
Andrew Walbran | e1310df | 2019-04-29 17:28:28 +0100 | [diff] [blame] | 73 | struct vcpu *next = vm_get_vcpu(primary, cpu_index(current->cpu)); |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 74 | |
Andrew Walbran | 508e63c | 2018-12-20 17:02:37 +0000 | [diff] [blame] | 75 | /* |
| 76 | * If the secondary is blocked but has a timer running, sleep until the |
| 77 | * timer fires rather than indefinitely. |
| 78 | */ |
Andrew Scull | b06d175 | 2019-02-04 10:15:48 +0000 | [diff] [blame] | 79 | switch (primary_ret.code) { |
| 80 | case HF_VCPU_RUN_WAIT_FOR_INTERRUPT: |
| 81 | case HF_VCPU_RUN_WAIT_FOR_MESSAGE: |
| 82 | primary_ret.sleep.ns = |
| 83 | arch_timer_enabled_current() |
| 84 | ? arch_timer_remaining_ns_current() |
| 85 | : HF_SLEEP_INDEFINITE; |
| 86 | break; |
| 87 | |
| 88 | default: |
| 89 | /* Do nothing. */ |
| 90 | break; |
Andrew Walbran | 508e63c | 2018-12-20 17:02:37 +0000 | [diff] [blame] | 91 | } |
| 92 | |
Wedson Almeida Filho | 00df6c7 | 2018-10-18 11:19:24 +0100 | [diff] [blame] | 93 | /* Set the return value for the primary VM's call to HF_VCPU_RUN. */ |
Andrew Scull | 6d2db33 | 2018-10-10 15:28:17 +0100 | [diff] [blame] | 94 | arch_regs_set_retval(&next->regs, |
| 95 | hf_vcpu_run_return_encode(primary_ret)); |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 96 | |
Wedson Almeida Filho | ba641ef | 2018-12-03 04:19:44 +0000 | [diff] [blame] | 97 | /* Mark the current vcpu as waiting. */ |
| 98 | sl_lock(¤t->lock); |
| 99 | current->state = secondary_state; |
| 100 | sl_unlock(¤t->lock); |
| 101 | |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 102 | return next; |
| 103 | } |
| 104 | |
| 105 | /** |
Andrew Scull | 33fecd3 | 2019-01-08 14:48:27 +0000 | [diff] [blame] | 106 | * Returns to the primary vm and signals that the vcpu still has work to do so. |
| 107 | */ |
| 108 | struct vcpu *api_preempt(struct vcpu *current) |
| 109 | { |
| 110 | struct hf_vcpu_run_return ret = { |
| 111 | .code = HF_VCPU_RUN_PREEMPTED, |
| 112 | }; |
| 113 | |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 114 | return api_switch_to_primary(current, ret, VCPU_STATE_READY); |
Andrew Scull | 33fecd3 | 2019-01-08 14:48:27 +0000 | [diff] [blame] | 115 | } |
| 116 | |
| 117 | /** |
Andrew Scull | aa039b3 | 2018-10-04 15:02:26 +0100 | [diff] [blame] | 118 | * Puts the current vcpu in wait for interrupt mode, and returns to the primary |
| 119 | * vm. |
| 120 | */ |
Wedson Almeida Filho | 00df6c7 | 2018-10-18 11:19:24 +0100 | [diff] [blame] | 121 | struct vcpu *api_wait_for_interrupt(struct vcpu *current) |
Andrew Scull | aa039b3 | 2018-10-04 15:02:26 +0100 | [diff] [blame] | 122 | { |
Andrew Scull | 6d2db33 | 2018-10-10 15:28:17 +0100 | [diff] [blame] | 123 | struct hf_vcpu_run_return ret = { |
| 124 | .code = HF_VCPU_RUN_WAIT_FOR_INTERRUPT, |
| 125 | }; |
Wedson Almeida Filho | 81568c4 | 2019-01-04 13:33:02 +0000 | [diff] [blame] | 126 | |
Wedson Almeida Filho | ba641ef | 2018-12-03 04:19:44 +0000 | [diff] [blame] | 127 | return api_switch_to_primary(current, ret, |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 128 | VCPU_STATE_BLOCKED_INTERRUPT); |
Andrew Scull | aa039b3 | 2018-10-04 15:02:26 +0100 | [diff] [blame] | 129 | } |
| 130 | |
| 131 | /** |
Andrew Walbran | 3364565 | 2019-04-15 12:29:31 +0100 | [diff] [blame] | 132 | * Puts the current vCPU in off mode, and returns to the primary VM. |
| 133 | */ |
| 134 | struct vcpu *api_vcpu_off(struct vcpu *current) |
| 135 | { |
| 136 | struct hf_vcpu_run_return ret = { |
| 137 | .code = HF_VCPU_RUN_WAIT_FOR_INTERRUPT, |
| 138 | }; |
| 139 | |
| 140 | /* |
| 141 | * Disable the timer, so the scheduler doesn't get told to call back |
| 142 | * based on it. |
| 143 | */ |
| 144 | arch_timer_disable_current(); |
| 145 | |
| 146 | return api_switch_to_primary(current, ret, VCPU_STATE_OFF); |
| 147 | } |
| 148 | |
| 149 | /** |
Andrew Scull | 66d62bf | 2019-02-01 13:54:10 +0000 | [diff] [blame] | 150 | * Returns to the primary vm to allow this cpu to be used for other tasks as the |
| 151 | * vcpu does not have work to do at this moment. The current vcpu is marked as |
Jose Marinho | 135dff3 | 2019-02-28 10:25:57 +0000 | [diff] [blame] | 152 | * ready to be scheduled again. This SPCI function always returns SPCI_SUCCESS. |
Andrew Scull | 66d62bf | 2019-02-01 13:54:10 +0000 | [diff] [blame] | 153 | */ |
Jose Marinho | 135dff3 | 2019-02-28 10:25:57 +0000 | [diff] [blame] | 154 | int32_t api_spci_yield(struct vcpu *current, struct vcpu **next) |
Andrew Scull | 66d62bf | 2019-02-01 13:54:10 +0000 | [diff] [blame] | 155 | { |
| 156 | struct hf_vcpu_run_return ret = { |
| 157 | .code = HF_VCPU_RUN_YIELD, |
| 158 | }; |
| 159 | |
| 160 | if (current->vm->id == HF_PRIMARY_VM_ID) { |
Andrew Scull | b06d175 | 2019-02-04 10:15:48 +0000 | [diff] [blame] | 161 | /* Noop on the primary as it makes the scheduling decisions. */ |
Jose Marinho | 135dff3 | 2019-02-28 10:25:57 +0000 | [diff] [blame] | 162 | return SPCI_SUCCESS; |
Andrew Scull | 66d62bf | 2019-02-01 13:54:10 +0000 | [diff] [blame] | 163 | } |
| 164 | |
Jose Marinho | 135dff3 | 2019-02-28 10:25:57 +0000 | [diff] [blame] | 165 | *next = api_switch_to_primary(current, ret, VCPU_STATE_READY); |
| 166 | |
| 167 | /* SPCI_YIELD always returns SPCI_SUCCESS. */ |
| 168 | return SPCI_SUCCESS; |
Andrew Scull | 66d62bf | 2019-02-01 13:54:10 +0000 | [diff] [blame] | 169 | } |
| 170 | |
| 171 | /** |
Andrew Walbran | 3364565 | 2019-04-15 12:29:31 +0100 | [diff] [blame] | 172 | * Switches to the primary so that it can switch to the target, or kick it if it |
| 173 | * is already running on a different physical CPU. |
| 174 | */ |
| 175 | struct vcpu *api_wake_up(struct vcpu *current, struct vcpu *target_vcpu) |
| 176 | { |
| 177 | struct hf_vcpu_run_return ret = { |
| 178 | .code = HF_VCPU_RUN_WAKE_UP, |
| 179 | .wake_up.vm_id = target_vcpu->vm->id, |
| 180 | .wake_up.vcpu = vcpu_index(target_vcpu), |
| 181 | }; |
| 182 | return api_switch_to_primary(current, ret, VCPU_STATE_READY); |
| 183 | } |
| 184 | |
| 185 | /** |
Andrew Scull | 38772ab | 2019-01-24 15:16:50 +0000 | [diff] [blame] | 186 | * Aborts the vCPU and triggers its VM to abort fully. |
Andrew Scull | 9726c25 | 2019-01-23 13:44:19 +0000 | [diff] [blame] | 187 | */ |
| 188 | struct vcpu *api_abort(struct vcpu *current) |
| 189 | { |
| 190 | struct hf_vcpu_run_return ret = { |
| 191 | .code = HF_VCPU_RUN_ABORTED, |
| 192 | }; |
| 193 | |
| 194 | dlog("Aborting VM %u vCPU %u\n", current->vm->id, vcpu_index(current)); |
| 195 | |
| 196 | if (current->vm->id == HF_PRIMARY_VM_ID) { |
| 197 | /* TODO: what to do when the primary aborts? */ |
| 198 | for (;;) { |
| 199 | /* Do nothing. */ |
| 200 | } |
| 201 | } |
| 202 | |
| 203 | atomic_store_explicit(¤t->vm->aborting, true, |
| 204 | memory_order_relaxed); |
| 205 | |
| 206 | /* TODO: free resources once all vCPUs abort. */ |
| 207 | |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 208 | return api_switch_to_primary(current, ret, VCPU_STATE_ABORTED); |
Andrew Scull | 9726c25 | 2019-01-23 13:44:19 +0000 | [diff] [blame] | 209 | } |
| 210 | |
| 211 | /** |
Andrew Scull | 55c4d8b | 2018-12-18 18:50:18 +0000 | [diff] [blame] | 212 | * Returns the ID of the VM. |
| 213 | */ |
Andrew Walbran | fc6cd9d | 2019-06-25 15:23:27 +0100 | [diff] [blame] | 214 | spci_vm_id_t api_vm_get_id(const struct vcpu *current) |
Andrew Scull | 55c4d8b | 2018-12-18 18:50:18 +0000 | [diff] [blame] | 215 | { |
| 216 | return current->vm->id; |
| 217 | } |
| 218 | |
| 219 | /** |
Wedson Almeida Filho | 3fcbcff | 2018-07-10 23:53:39 +0100 | [diff] [blame] | 220 | * Returns the number of VMs configured to run. |
| 221 | */ |
Andrew Walbran | 52d9967 | 2019-06-25 15:51:11 +0100 | [diff] [blame] | 222 | spci_vm_count_t api_vm_get_count(void) |
Wedson Almeida Filho | 3fcbcff | 2018-07-10 23:53:39 +0100 | [diff] [blame] | 223 | { |
Andrew Scull | 1950326 | 2018-09-20 14:48:39 +0100 | [diff] [blame] | 224 | return vm_get_count(); |
Wedson Almeida Filho | 3fcbcff | 2018-07-10 23:53:39 +0100 | [diff] [blame] | 225 | } |
| 226 | |
| 227 | /** |
Andrew Walbran | c6d23c4 | 2019-06-26 13:30:42 +0100 | [diff] [blame] | 228 | * Returns the number of vCPUs configured in the given VM, or 0 if there is no |
| 229 | * such VM or the caller is not the primary VM. |
Wedson Almeida Filho | 3fcbcff | 2018-07-10 23:53:39 +0100 | [diff] [blame] | 230 | */ |
Andrew Walbran | c6d23c4 | 2019-06-26 13:30:42 +0100 | [diff] [blame] | 231 | spci_vcpu_count_t api_vcpu_get_count(spci_vm_id_t vm_id, |
| 232 | const struct vcpu *current) |
Wedson Almeida Filho | 3fcbcff | 2018-07-10 23:53:39 +0100 | [diff] [blame] | 233 | { |
Andrew Scull | 1950326 | 2018-09-20 14:48:39 +0100 | [diff] [blame] | 234 | struct vm *vm; |
| 235 | |
| 236 | /* Only the primary VM needs to know about vcpus for scheduling. */ |
Wedson Almeida Filho | 00df6c7 | 2018-10-18 11:19:24 +0100 | [diff] [blame] | 237 | if (current->vm->id != HF_PRIMARY_VM_ID) { |
Andrew Walbran | c6d23c4 | 2019-06-26 13:30:42 +0100 | [diff] [blame] | 238 | return 0; |
Andrew Scull | 7364a8e | 2018-07-19 15:39:29 +0100 | [diff] [blame] | 239 | } |
Wedson Almeida Filho | 3fcbcff | 2018-07-10 23:53:39 +0100 | [diff] [blame] | 240 | |
Andrew Walbran | 42347a9 | 2019-05-09 13:59:03 +0100 | [diff] [blame] | 241 | vm = vm_find(vm_id); |
Andrew Scull | 1950326 | 2018-09-20 14:48:39 +0100 | [diff] [blame] | 242 | if (vm == NULL) { |
Andrew Walbran | c6d23c4 | 2019-06-26 13:30:42 +0100 | [diff] [blame] | 243 | return 0; |
Andrew Scull | 1950326 | 2018-09-20 14:48:39 +0100 | [diff] [blame] | 244 | } |
| 245 | |
| 246 | return vm->vcpu_count; |
Wedson Almeida Filho | 3fcbcff | 2018-07-10 23:53:39 +0100 | [diff] [blame] | 247 | } |
| 248 | |
| 249 | /** |
Wedson Almeida Filho | 0330611 | 2018-11-26 00:08:03 +0000 | [diff] [blame] | 250 | * This function is called by the architecture-specific context switching |
| 251 | * function to indicate that register state for the given vcpu has been saved |
| 252 | * and can therefore be used by other pcpus. |
| 253 | */ |
| 254 | void api_regs_state_saved(struct vcpu *vcpu) |
| 255 | { |
| 256 | sl_lock(&vcpu->lock); |
| 257 | vcpu->regs_available = true; |
| 258 | sl_unlock(&vcpu->lock); |
| 259 | } |
| 260 | |
| 261 | /** |
Wedson Almeida Filho | ea62e2e | 2019-01-09 19:14:59 +0000 | [diff] [blame] | 262 | * Retrieves the next waiter and removes it from the wait list if the VM's |
| 263 | * mailbox is in a writable state. |
| 264 | */ |
| 265 | static struct wait_entry *api_fetch_waiter(struct vm_locked locked_vm) |
| 266 | { |
| 267 | struct wait_entry *entry; |
| 268 | struct vm *vm = locked_vm.vm; |
| 269 | |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 270 | if (vm->mailbox.state != MAILBOX_STATE_EMPTY || |
Wedson Almeida Filho | ea62e2e | 2019-01-09 19:14:59 +0000 | [diff] [blame] | 271 | vm->mailbox.recv == NULL || list_empty(&vm->mailbox.waiter_list)) { |
| 272 | /* The mailbox is not writable or there are no waiters. */ |
| 273 | return NULL; |
| 274 | } |
| 275 | |
| 276 | /* Remove waiter from the wait list. */ |
| 277 | entry = CONTAINER_OF(vm->mailbox.waiter_list.next, struct wait_entry, |
| 278 | wait_links); |
| 279 | list_remove(&entry->wait_links); |
| 280 | return entry; |
| 281 | } |
| 282 | |
| 283 | /** |
Andrew Walbran | 508e63c | 2018-12-20 17:02:37 +0000 | [diff] [blame] | 284 | * Assuming that the arguments have already been checked by the caller, injects |
| 285 | * a virtual interrupt of the given ID into the given target vCPU. This doesn't |
| 286 | * cause the vCPU to actually be run immediately; it will be taken when the vCPU |
| 287 | * is next run, which is up to the scheduler. |
| 288 | * |
| 289 | * Returns: |
| 290 | * - 0 on success if no further action is needed. |
| 291 | * - 1 if it was called by the primary VM and the primary VM now needs to wake |
| 292 | * up or kick the target vCPU. |
| 293 | */ |
Andrew Walbran | fc9d438 | 2019-05-10 18:07:21 +0100 | [diff] [blame] | 294 | static int64_t internal_interrupt_inject(struct vcpu *target_vcpu, |
Andrew Walbran | 508e63c | 2018-12-20 17:02:37 +0000 | [diff] [blame] | 295 | uint32_t intid, struct vcpu *current, |
| 296 | struct vcpu **next) |
| 297 | { |
| 298 | uint32_t intid_index = intid / INTERRUPT_REGISTER_BITS; |
| 299 | uint32_t intid_mask = 1u << (intid % INTERRUPT_REGISTER_BITS); |
Andrew Walbran | 508e63c | 2018-12-20 17:02:37 +0000 | [diff] [blame] | 300 | int64_t ret = 0; |
| 301 | |
| 302 | sl_lock(&target_vcpu->lock); |
Andrew Walbran | 508e63c | 2018-12-20 17:02:37 +0000 | [diff] [blame] | 303 | |
| 304 | /* |
| 305 | * We only need to change state and (maybe) trigger a virtual IRQ if it |
| 306 | * is enabled and was not previously pending. Otherwise we can skip |
| 307 | * everything except setting the pending bit. |
| 308 | * |
| 309 | * If you change this logic make sure to update the need_vm_lock logic |
| 310 | * above to match. |
| 311 | */ |
| 312 | if (!(target_vcpu->interrupts.interrupt_enabled[intid_index] & |
| 313 | ~target_vcpu->interrupts.interrupt_pending[intid_index] & |
| 314 | intid_mask)) { |
| 315 | goto out; |
| 316 | } |
| 317 | |
| 318 | /* Increment the count. */ |
| 319 | target_vcpu->interrupts.enabled_and_pending_count++; |
| 320 | |
| 321 | /* |
| 322 | * Only need to update state if there was not already an |
| 323 | * interrupt enabled and pending. |
| 324 | */ |
| 325 | if (target_vcpu->interrupts.enabled_and_pending_count != 1) { |
| 326 | goto out; |
| 327 | } |
| 328 | |
Andrew Walbran | 508e63c | 2018-12-20 17:02:37 +0000 | [diff] [blame] | 329 | if (current->vm->id == HF_PRIMARY_VM_ID) { |
| 330 | /* |
| 331 | * If the call came from the primary VM, let it know that it |
| 332 | * should run or kick the target vCPU. |
| 333 | */ |
| 334 | ret = 1; |
| 335 | } else if (current != target_vcpu && next != NULL) { |
Andrew Walbran | 3364565 | 2019-04-15 12:29:31 +0100 | [diff] [blame] | 336 | *next = api_wake_up(current, target_vcpu); |
Andrew Walbran | 508e63c | 2018-12-20 17:02:37 +0000 | [diff] [blame] | 337 | } |
| 338 | |
| 339 | out: |
| 340 | /* Either way, make it pending. */ |
| 341 | target_vcpu->interrupts.interrupt_pending[intid_index] |= intid_mask; |
| 342 | |
| 343 | sl_unlock(&target_vcpu->lock); |
Andrew Walbran | 508e63c | 2018-12-20 17:02:37 +0000 | [diff] [blame] | 344 | |
| 345 | return ret; |
| 346 | } |
| 347 | |
| 348 | /** |
Wedson Almeida Filho | 0330611 | 2018-11-26 00:08:03 +0000 | [diff] [blame] | 349 | * Prepares the vcpu to run by updating its state and fetching whether a return |
| 350 | * value needs to be forced onto the vCPU. |
| 351 | */ |
Andrew Scull | 38772ab | 2019-01-24 15:16:50 +0000 | [diff] [blame] | 352 | static bool api_vcpu_prepare_run(const struct vcpu *current, struct vcpu *vcpu, |
Andrew Walbran | 508e63c | 2018-12-20 17:02:37 +0000 | [diff] [blame] | 353 | struct hf_vcpu_run_return *run_ret) |
Wedson Almeida Filho | 0330611 | 2018-11-26 00:08:03 +0000 | [diff] [blame] | 354 | { |
Andrew Scull | b06d175 | 2019-02-04 10:15:48 +0000 | [diff] [blame] | 355 | bool need_vm_lock; |
Wedson Almeida Filho | 0330611 | 2018-11-26 00:08:03 +0000 | [diff] [blame] | 356 | bool ret; |
| 357 | |
Andrew Scull | b06d175 | 2019-02-04 10:15:48 +0000 | [diff] [blame] | 358 | /* |
Andrew Scull | 4caadaf | 2019-07-03 13:13:47 +0100 | [diff] [blame] | 359 | * Wait until the registers become available. All locks must be released |
| 360 | * between iterations of this loop to avoid potential deadlocks if, on |
| 361 | * any path, a lock needs to be taken after taking the decision to |
| 362 | * switch context but before the registers have been saved. |
Andrew Scull | b06d175 | 2019-02-04 10:15:48 +0000 | [diff] [blame] | 363 | * |
Andrew Scull | 4caadaf | 2019-07-03 13:13:47 +0100 | [diff] [blame] | 364 | * The VM lock is not needed in the common case so it must only be taken |
| 365 | * when it is going to be needed. This ensures there are no inter-vCPU |
| 366 | * dependencies in the common run case meaning the sensitive context |
| 367 | * switch performance is consistent. |
Andrew Scull | b06d175 | 2019-02-04 10:15:48 +0000 | [diff] [blame] | 368 | */ |
| 369 | for (;;) { |
| 370 | sl_lock(&vcpu->lock); |
| 371 | |
| 372 | /* The VM needs to be locked to deliver mailbox messages. */ |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 373 | need_vm_lock = vcpu->state == VCPU_STATE_BLOCKED_MAILBOX; |
Andrew Scull | b06d175 | 2019-02-04 10:15:48 +0000 | [diff] [blame] | 374 | if (need_vm_lock) { |
| 375 | sl_unlock(&vcpu->lock); |
| 376 | sl_lock(&vcpu->vm->lock); |
| 377 | sl_lock(&vcpu->lock); |
| 378 | } |
| 379 | |
| 380 | if (vcpu->regs_available) { |
| 381 | break; |
| 382 | } |
| 383 | |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 384 | if (vcpu->state == VCPU_STATE_RUNNING) { |
Andrew Scull | b06d175 | 2019-02-04 10:15:48 +0000 | [diff] [blame] | 385 | /* |
| 386 | * vCPU is running on another pCPU. |
| 387 | * |
Andrew Walbran | abf88fb | 2019-06-21 12:17:47 +0100 | [diff] [blame] | 388 | * It's ok not to return the sleep duration here because |
Andrew Scull | b06d175 | 2019-02-04 10:15:48 +0000 | [diff] [blame] | 389 | * the other physical CPU that is currently running this |
Andrew Walbran | abf88fb | 2019-06-21 12:17:47 +0100 | [diff] [blame] | 390 | * vCPU will return the sleep duration if needed. The |
| 391 | * default return value is |
| 392 | * HF_VCPU_RUN_WAIT_FOR_INTERRUPT, so no need to set it |
| 393 | * explicitly. |
Andrew Scull | b06d175 | 2019-02-04 10:15:48 +0000 | [diff] [blame] | 394 | */ |
| 395 | ret = false; |
| 396 | goto out; |
| 397 | } |
| 398 | |
| 399 | sl_unlock(&vcpu->lock); |
| 400 | if (need_vm_lock) { |
| 401 | sl_unlock(&vcpu->vm->lock); |
| 402 | } |
| 403 | } |
Andrew Scull | 9726c25 | 2019-01-23 13:44:19 +0000 | [diff] [blame] | 404 | |
| 405 | if (atomic_load_explicit(&vcpu->vm->aborting, memory_order_relaxed)) { |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 406 | if (vcpu->state != VCPU_STATE_ABORTED) { |
Andrew Scull | 8233128 | 2019-01-25 10:29:34 +0000 | [diff] [blame] | 407 | dlog("Aborting VM %u vCPU %u\n", vcpu->vm->id, |
| 408 | vcpu_index(vcpu)); |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 409 | vcpu->state = VCPU_STATE_ABORTED; |
Andrew Scull | 9726c25 | 2019-01-23 13:44:19 +0000 | [diff] [blame] | 410 | } |
| 411 | ret = false; |
| 412 | goto out; |
| 413 | } |
| 414 | |
Andrew Walbran | 508e63c | 2018-12-20 17:02:37 +0000 | [diff] [blame] | 415 | switch (vcpu->state) { |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 416 | case VCPU_STATE_RUNNING: |
| 417 | case VCPU_STATE_OFF: |
| 418 | case VCPU_STATE_ABORTED: |
Wedson Almeida Filho | 0330611 | 2018-11-26 00:08:03 +0000 | [diff] [blame] | 419 | ret = false; |
| 420 | goto out; |
Andrew Scull | b06d175 | 2019-02-04 10:15:48 +0000 | [diff] [blame] | 421 | |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 422 | case VCPU_STATE_BLOCKED_MAILBOX: |
Andrew Scull | b06d175 | 2019-02-04 10:15:48 +0000 | [diff] [blame] | 423 | /* |
| 424 | * A pending message allows the vCPU to run so the message can |
| 425 | * be delivered directly. |
| 426 | */ |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 427 | if (vcpu->vm->mailbox.state == MAILBOX_STATE_RECEIVED) { |
Jose Marinho | 3e2442f | 2019-03-12 13:30:37 +0000 | [diff] [blame] | 428 | arch_regs_set_retval(&vcpu->regs, SPCI_SUCCESS); |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 429 | vcpu->vm->mailbox.state = MAILBOX_STATE_READ; |
Andrew Scull | b06d175 | 2019-02-04 10:15:48 +0000 | [diff] [blame] | 430 | break; |
| 431 | } |
| 432 | /* Fall through. */ |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 433 | case VCPU_STATE_BLOCKED_INTERRUPT: |
Andrew Scull | b06d175 | 2019-02-04 10:15:48 +0000 | [diff] [blame] | 434 | /* Allow virtual interrupts to be delivered. */ |
| 435 | if (vcpu->interrupts.enabled_and_pending_count > 0) { |
| 436 | break; |
| 437 | } |
| 438 | |
| 439 | /* The timer expired so allow the interrupt to be delivered. */ |
Andrew Walbran | 508e63c | 2018-12-20 17:02:37 +0000 | [diff] [blame] | 440 | if (arch_timer_pending(&vcpu->regs)) { |
| 441 | break; |
| 442 | } |
| 443 | |
| 444 | /* |
| 445 | * The vCPU is not ready to run, return the appropriate code to |
| 446 | * the primary which called vcpu_run. |
| 447 | */ |
| 448 | if (arch_timer_enabled(&vcpu->regs)) { |
Andrew Scull | b06d175 | 2019-02-04 10:15:48 +0000 | [diff] [blame] | 449 | run_ret->code = |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 450 | vcpu->state == VCPU_STATE_BLOCKED_MAILBOX |
Andrew Scull | b06d175 | 2019-02-04 10:15:48 +0000 | [diff] [blame] | 451 | ? HF_VCPU_RUN_WAIT_FOR_MESSAGE |
| 452 | : HF_VCPU_RUN_WAIT_FOR_INTERRUPT; |
Andrew Walbran | 508e63c | 2018-12-20 17:02:37 +0000 | [diff] [blame] | 453 | run_ret->sleep.ns = |
| 454 | arch_timer_remaining_ns(&vcpu->regs); |
| 455 | } |
| 456 | |
| 457 | ret = false; |
| 458 | goto out; |
Andrew Scull | b06d175 | 2019-02-04 10:15:48 +0000 | [diff] [blame] | 459 | |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 460 | case VCPU_STATE_READY: |
Andrew Walbran | 508e63c | 2018-12-20 17:02:37 +0000 | [diff] [blame] | 461 | break; |
Wedson Almeida Filho | 0330611 | 2018-11-26 00:08:03 +0000 | [diff] [blame] | 462 | } |
| 463 | |
Andrew Scull | b06d175 | 2019-02-04 10:15:48 +0000 | [diff] [blame] | 464 | /* It has been decided that the vCPU should be run. */ |
Wedson Almeida Filho | 0330611 | 2018-11-26 00:08:03 +0000 | [diff] [blame] | 465 | vcpu->cpu = current->cpu; |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 466 | vcpu->state = VCPU_STATE_RUNNING; |
Wedson Almeida Filho | 0330611 | 2018-11-26 00:08:03 +0000 | [diff] [blame] | 467 | |
Wedson Almeida Filho | 0330611 | 2018-11-26 00:08:03 +0000 | [diff] [blame] | 468 | /* |
Wedson Almeida Filho | 0330611 | 2018-11-26 00:08:03 +0000 | [diff] [blame] | 469 | * Mark the registers as unavailable now that we're about to reflect |
| 470 | * them onto the real registers. This will also prevent another physical |
| 471 | * CPU from trying to read these registers. |
| 472 | */ |
| 473 | vcpu->regs_available = false; |
| 474 | |
| 475 | ret = true; |
| 476 | |
| 477 | out: |
| 478 | sl_unlock(&vcpu->lock); |
Andrew Scull | b06d175 | 2019-02-04 10:15:48 +0000 | [diff] [blame] | 479 | if (need_vm_lock) { |
| 480 | sl_unlock(&vcpu->vm->lock); |
| 481 | } |
| 482 | |
Wedson Almeida Filho | 0330611 | 2018-11-26 00:08:03 +0000 | [diff] [blame] | 483 | return ret; |
| 484 | } |
| 485 | |
| 486 | /** |
Wedson Almeida Filho | 3fcbcff | 2018-07-10 23:53:39 +0100 | [diff] [blame] | 487 | * Runs the given vcpu of the given vm. |
| 488 | */ |
Andrew Walbran | b037d5b | 2019-06-25 17:19:41 +0100 | [diff] [blame] | 489 | struct hf_vcpu_run_return api_vcpu_run(spci_vm_id_t vm_id, |
| 490 | spci_vcpu_index_t vcpu_idx, |
Andrew Scull | 38772ab | 2019-01-24 15:16:50 +0000 | [diff] [blame] | 491 | const struct vcpu *current, |
| 492 | struct vcpu **next) |
Wedson Almeida Filho | 3fcbcff | 2018-07-10 23:53:39 +0100 | [diff] [blame] | 493 | { |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 494 | struct vm *vm; |
Wedson Almeida Filho | 3fcbcff | 2018-07-10 23:53:39 +0100 | [diff] [blame] | 495 | struct vcpu *vcpu; |
Andrew Scull | 6d2db33 | 2018-10-10 15:28:17 +0100 | [diff] [blame] | 496 | struct hf_vcpu_run_return ret = { |
| 497 | .code = HF_VCPU_RUN_WAIT_FOR_INTERRUPT, |
Andrew Scull | b06d175 | 2019-02-04 10:15:48 +0000 | [diff] [blame] | 498 | .sleep.ns = HF_SLEEP_INDEFINITE, |
Andrew Scull | 6d2db33 | 2018-10-10 15:28:17 +0100 | [diff] [blame] | 499 | }; |
Wedson Almeida Filho | 3fcbcff | 2018-07-10 23:53:39 +0100 | [diff] [blame] | 500 | |
| 501 | /* Only the primary VM can switch vcpus. */ |
Wedson Almeida Filho | 00df6c7 | 2018-10-18 11:19:24 +0100 | [diff] [blame] | 502 | if (current->vm->id != HF_PRIMARY_VM_ID) { |
Andrew Scull | 6d2db33 | 2018-10-10 15:28:17 +0100 | [diff] [blame] | 503 | goto out; |
Andrew Scull | 7364a8e | 2018-07-19 15:39:29 +0100 | [diff] [blame] | 504 | } |
Wedson Almeida Filho | 3fcbcff | 2018-07-10 23:53:39 +0100 | [diff] [blame] | 505 | |
Andrew Scull | 1950326 | 2018-09-20 14:48:39 +0100 | [diff] [blame] | 506 | /* Only secondary VM vcpus can be run. */ |
| 507 | if (vm_id == HF_PRIMARY_VM_ID) { |
Andrew Scull | 6d2db33 | 2018-10-10 15:28:17 +0100 | [diff] [blame] | 508 | goto out; |
Andrew Scull | 7364a8e | 2018-07-19 15:39:29 +0100 | [diff] [blame] | 509 | } |
Wedson Almeida Filho | 3fcbcff | 2018-07-10 23:53:39 +0100 | [diff] [blame] | 510 | |
Andrew Scull | 1950326 | 2018-09-20 14:48:39 +0100 | [diff] [blame] | 511 | /* The requested VM must exist. */ |
Andrew Walbran | 42347a9 | 2019-05-09 13:59:03 +0100 | [diff] [blame] | 512 | vm = vm_find(vm_id); |
Andrew Scull | 1950326 | 2018-09-20 14:48:39 +0100 | [diff] [blame] | 513 | if (vm == NULL) { |
Andrew Scull | 6d2db33 | 2018-10-10 15:28:17 +0100 | [diff] [blame] | 514 | goto out; |
Andrew Scull | 1950326 | 2018-09-20 14:48:39 +0100 | [diff] [blame] | 515 | } |
| 516 | |
| 517 | /* The requested vcpu must exist. */ |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 518 | if (vcpu_idx >= vm->vcpu_count) { |
Andrew Scull | 6d2db33 | 2018-10-10 15:28:17 +0100 | [diff] [blame] | 519 | goto out; |
Andrew Scull | 7364a8e | 2018-07-19 15:39:29 +0100 | [diff] [blame] | 520 | } |
Wedson Almeida Filho | 3fcbcff | 2018-07-10 23:53:39 +0100 | [diff] [blame] | 521 | |
Wedson Almeida Filho | 0330611 | 2018-11-26 00:08:03 +0000 | [diff] [blame] | 522 | /* Update state if allowed. */ |
Andrew Walbran | e1310df | 2019-04-29 17:28:28 +0100 | [diff] [blame] | 523 | vcpu = vm_get_vcpu(vm, vcpu_idx); |
Andrew Scull | b06d175 | 2019-02-04 10:15:48 +0000 | [diff] [blame] | 524 | if (!api_vcpu_prepare_run(current, vcpu, &ret)) { |
Wedson Almeida Filho | 0330611 | 2018-11-26 00:08:03 +0000 | [diff] [blame] | 525 | goto out; |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 526 | } |
Wedson Almeida Filho | 0330611 | 2018-11-26 00:08:03 +0000 | [diff] [blame] | 527 | |
Andrew Walbran | 508e63c | 2018-12-20 17:02:37 +0000 | [diff] [blame] | 528 | /* |
| 529 | * Inject timer interrupt if timer has expired. It's safe to access |
| 530 | * vcpu->regs here because api_vcpu_prepare_run already made sure that |
| 531 | * regs_available was true (and then set it to false) before returning |
| 532 | * true. |
| 533 | */ |
| 534 | if (arch_timer_pending(&vcpu->regs)) { |
| 535 | /* Make virtual timer interrupt pending. */ |
Andrew Walbran | fc9d438 | 2019-05-10 18:07:21 +0100 | [diff] [blame] | 536 | internal_interrupt_inject(vcpu, HF_VIRTUAL_TIMER_INTID, vcpu, |
| 537 | NULL); |
Andrew Walbran | 508e63c | 2018-12-20 17:02:37 +0000 | [diff] [blame] | 538 | |
| 539 | /* |
| 540 | * Set the mask bit so the hardware interrupt doesn't fire |
| 541 | * again. Ideally we wouldn't do this because it affects what |
| 542 | * the secondary vCPU sees, but if we don't then we end up with |
| 543 | * a loop of the interrupt firing each time we try to return to |
| 544 | * the secondary vCPU. |
| 545 | */ |
| 546 | arch_timer_mask(&vcpu->regs); |
| 547 | } |
| 548 | |
Andrew Scull | 33fecd3 | 2019-01-08 14:48:27 +0000 | [diff] [blame] | 549 | /* Switch to the vcpu. */ |
Wedson Almeida Filho | 0330611 | 2018-11-26 00:08:03 +0000 | [diff] [blame] | 550 | *next = vcpu; |
Wedson Almeida Filho | 0330611 | 2018-11-26 00:08:03 +0000 | [diff] [blame] | 551 | |
Andrew Scull | 33fecd3 | 2019-01-08 14:48:27 +0000 | [diff] [blame] | 552 | /* |
| 553 | * Set a placeholder return code to the scheduler. This will be |
| 554 | * overwritten when the switch back to the primary occurs. |
| 555 | */ |
| 556 | ret.code = HF_VCPU_RUN_PREEMPTED; |
| 557 | |
Andrew Scull | 6d2db33 | 2018-10-10 15:28:17 +0100 | [diff] [blame] | 558 | out: |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 559 | return ret; |
Wedson Almeida Filho | 3fcbcff | 2018-07-10 23:53:39 +0100 | [diff] [blame] | 560 | } |
| 561 | |
| 562 | /** |
Andrew Scull | 81e8509 | 2018-12-12 12:56:20 +0000 | [diff] [blame] | 563 | * Check that the mode indicates memory that is valid, owned and exclusive. |
| 564 | */ |
Andrew Scull | cbefbdb | 2019-01-11 16:36:26 +0000 | [diff] [blame] | 565 | static bool api_mode_valid_owned_and_exclusive(int mode) |
Andrew Scull | 81e8509 | 2018-12-12 12:56:20 +0000 | [diff] [blame] | 566 | { |
| 567 | return (mode & (MM_MODE_INVALID | MM_MODE_UNOWNED | MM_MODE_SHARED)) == |
| 568 | 0; |
| 569 | } |
| 570 | |
| 571 | /** |
Wedson Almeida Filho | ea62e2e | 2019-01-09 19:14:59 +0000 | [diff] [blame] | 572 | * Determines the value to be returned by api_vm_configure and api_mailbox_clear |
| 573 | * after they've succeeded. If a secondary VM is running and there are waiters, |
| 574 | * it also switches back to the primary VM for it to wake waiters up. |
| 575 | */ |
| 576 | static int64_t api_waiter_result(struct vm_locked locked_vm, |
| 577 | struct vcpu *current, struct vcpu **next) |
| 578 | { |
| 579 | struct vm *vm = locked_vm.vm; |
| 580 | struct hf_vcpu_run_return ret = { |
| 581 | .code = HF_VCPU_RUN_NOTIFY_WAITERS, |
| 582 | }; |
| 583 | |
| 584 | if (list_empty(&vm->mailbox.waiter_list)) { |
| 585 | /* No waiters, nothing else to do. */ |
| 586 | return 0; |
| 587 | } |
| 588 | |
| 589 | if (vm->id == HF_PRIMARY_VM_ID) { |
| 590 | /* The caller is the primary VM. Tell it to wake up waiters. */ |
| 591 | return 1; |
| 592 | } |
| 593 | |
| 594 | /* |
| 595 | * Switch back to the primary VM, informing it that there are waiters |
| 596 | * that need to be notified. |
| 597 | */ |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 598 | *next = api_switch_to_primary(current, ret, VCPU_STATE_READY); |
Wedson Almeida Filho | ea62e2e | 2019-01-09 19:14:59 +0000 | [diff] [blame] | 599 | |
| 600 | return 0; |
| 601 | } |
| 602 | |
| 603 | /** |
Andrew Scull | e132279 | 2019-07-01 17:46:10 +0100 | [diff] [blame] | 604 | * Configures the hypervisor's stage-1 view of the send and receive pages. The |
| 605 | * stage-1 page tables must be locked so memory cannot be taken by another core |
| 606 | * which could result in this transaction being unable to roll back in the case |
| 607 | * of an error. |
| 608 | */ |
| 609 | static bool api_vm_configure_stage1(struct vm_locked vm_locked, |
| 610 | paddr_t pa_send_begin, paddr_t pa_send_end, |
| 611 | paddr_t pa_recv_begin, paddr_t pa_recv_end, |
| 612 | struct mpool *local_page_pool) |
| 613 | { |
| 614 | bool ret; |
| 615 | struct mm_stage1_locked mm_stage1_locked = mm_lock_stage1(); |
| 616 | |
| 617 | /* Map the send page as read-only in the hypervisor address space. */ |
| 618 | vm_locked.vm->mailbox.send = |
| 619 | mm_identity_map(mm_stage1_locked, pa_send_begin, pa_send_end, |
| 620 | MM_MODE_R, local_page_pool); |
| 621 | if (!vm_locked.vm->mailbox.send) { |
| 622 | /* TODO: partial defrag of failed range. */ |
| 623 | /* Recover any memory consumed in failed mapping. */ |
| 624 | mm_defrag(mm_stage1_locked, local_page_pool); |
| 625 | goto fail; |
| 626 | } |
| 627 | |
| 628 | /* |
| 629 | * Map the receive page as writable in the hypervisor address space. On |
| 630 | * failure, unmap the send page before returning. |
| 631 | */ |
| 632 | vm_locked.vm->mailbox.recv = |
| 633 | mm_identity_map(mm_stage1_locked, pa_recv_begin, pa_recv_end, |
| 634 | MM_MODE_W, local_page_pool); |
| 635 | if (!vm_locked.vm->mailbox.recv) { |
| 636 | /* TODO: partial defrag of failed range. */ |
| 637 | /* Recover any memory consumed in failed mapping. */ |
| 638 | mm_defrag(mm_stage1_locked, local_page_pool); |
| 639 | goto fail_undo_send; |
| 640 | } |
| 641 | |
| 642 | ret = true; |
| 643 | goto out; |
| 644 | |
| 645 | /* |
| 646 | * The following mappings will not require more memory than is available |
| 647 | * in the local pool. |
| 648 | */ |
| 649 | fail_undo_send: |
| 650 | vm_locked.vm->mailbox.send = NULL; |
Andrew Scull | 7e8de32 | 2019-07-02 13:00:56 +0100 | [diff] [blame] | 651 | CHECK(mm_unmap(mm_stage1_locked, pa_send_begin, pa_send_end, |
| 652 | local_page_pool)); |
Andrew Scull | e132279 | 2019-07-01 17:46:10 +0100 | [diff] [blame] | 653 | |
| 654 | fail: |
| 655 | ret = false; |
| 656 | |
| 657 | out: |
| 658 | mm_unlock_stage1(&mm_stage1_locked); |
| 659 | |
| 660 | return ret; |
| 661 | } |
| 662 | |
| 663 | /** |
| 664 | * Configures the send and receive pages in the VM stage-2 and hypervisor |
| 665 | * stage-1 page tables. Locking of the page tables combined with a local memory |
| 666 | * pool ensures there will always be enough memory to recover from any errors |
| 667 | * that arise. |
| 668 | */ |
| 669 | static bool api_vm_configure_pages(struct vm_locked vm_locked, |
| 670 | paddr_t pa_send_begin, paddr_t pa_send_end, |
| 671 | int orig_send_mode, paddr_t pa_recv_begin, |
| 672 | paddr_t pa_recv_end, int orig_recv_mode) |
| 673 | { |
| 674 | bool ret; |
| 675 | struct mpool local_page_pool; |
| 676 | |
| 677 | /* |
| 678 | * Create a local pool so any freed memory can't be used by another |
| 679 | * thread. This is to ensure the original mapping can be restored if any |
| 680 | * stage of the process fails. |
| 681 | */ |
| 682 | mpool_init_with_fallback(&local_page_pool, &api_page_pool); |
| 683 | |
| 684 | /* Take memory ownership away from the VM and mark as shared. */ |
| 685 | if (!mm_vm_identity_map( |
| 686 | &vm_locked.vm->ptable, pa_send_begin, pa_send_end, |
| 687 | MM_MODE_UNOWNED | MM_MODE_SHARED | MM_MODE_R | MM_MODE_W, |
| 688 | NULL, &local_page_pool)) { |
| 689 | goto fail; |
| 690 | } |
| 691 | |
| 692 | if (!mm_vm_identity_map(&vm_locked.vm->ptable, pa_recv_begin, |
| 693 | pa_recv_end, |
| 694 | MM_MODE_UNOWNED | MM_MODE_SHARED | MM_MODE_R, |
| 695 | NULL, &local_page_pool)) { |
| 696 | /* TODO: partial defrag of failed range. */ |
| 697 | /* Recover any memory consumed in failed mapping. */ |
| 698 | mm_vm_defrag(&vm_locked.vm->ptable, &local_page_pool); |
| 699 | goto fail_undo_send; |
| 700 | } |
| 701 | |
| 702 | if (!api_vm_configure_stage1(vm_locked, pa_send_begin, pa_send_end, |
| 703 | pa_recv_begin, pa_recv_end, |
| 704 | &local_page_pool)) { |
| 705 | goto fail_undo_send_and_recv; |
| 706 | } |
| 707 | |
| 708 | ret = true; |
| 709 | goto out; |
| 710 | |
| 711 | /* |
| 712 | * The following mappings will not require more memory than is available |
| 713 | * in the local pool. |
| 714 | */ |
| 715 | fail_undo_send_and_recv: |
Andrew Scull | 7e8de32 | 2019-07-02 13:00:56 +0100 | [diff] [blame] | 716 | CHECK(mm_vm_identity_map(&vm_locked.vm->ptable, pa_recv_begin, |
| 717 | pa_recv_end, orig_recv_mode, NULL, |
| 718 | &local_page_pool)); |
Andrew Scull | e132279 | 2019-07-01 17:46:10 +0100 | [diff] [blame] | 719 | |
| 720 | fail_undo_send: |
Andrew Scull | 7e8de32 | 2019-07-02 13:00:56 +0100 | [diff] [blame] | 721 | CHECK(mm_vm_identity_map(&vm_locked.vm->ptable, pa_send_begin, |
| 722 | pa_send_end, orig_send_mode, NULL, |
| 723 | &local_page_pool)); |
Andrew Scull | e132279 | 2019-07-01 17:46:10 +0100 | [diff] [blame] | 724 | |
| 725 | fail: |
| 726 | ret = false; |
| 727 | |
| 728 | out: |
| 729 | mpool_fini(&local_page_pool); |
| 730 | |
| 731 | return ret; |
| 732 | } |
| 733 | |
| 734 | /** |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 735 | * Configures the VM to send/receive data through the specified pages. The pages |
| 736 | * must not be shared. |
Wedson Almeida Filho | ea62e2e | 2019-01-09 19:14:59 +0000 | [diff] [blame] | 737 | * |
| 738 | * Returns: |
| 739 | * - -1 on failure. |
| 740 | * - 0 on success if no further action is needed. |
| 741 | * - 1 if it was called by the primary VM and the primary VM now needs to wake |
| 742 | * up or kick waiters. Waiters should be retrieved by calling |
| 743 | * hf_mailbox_waiter_get. |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 744 | */ |
Wedson Almeida Filho | ea62e2e | 2019-01-09 19:14:59 +0000 | [diff] [blame] | 745 | int64_t api_vm_configure(ipaddr_t send, ipaddr_t recv, struct vcpu *current, |
| 746 | struct vcpu **next) |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 747 | { |
Wedson Almeida Filho | 00df6c7 | 2018-10-18 11:19:24 +0100 | [diff] [blame] | 748 | struct vm *vm = current->vm; |
Andrew Scull | e132279 | 2019-07-01 17:46:10 +0100 | [diff] [blame] | 749 | struct vm_locked vm_locked; |
Andrew Scull | 8087132 | 2018-08-06 12:04:09 +0100 | [diff] [blame] | 750 | paddr_t pa_send_begin; |
| 751 | paddr_t pa_send_end; |
| 752 | paddr_t pa_recv_begin; |
| 753 | paddr_t pa_recv_end; |
Andrew Scull | 220e621 | 2018-12-21 18:09:00 +0000 | [diff] [blame] | 754 | int orig_send_mode; |
| 755 | int orig_recv_mode; |
Andrew Scull | c0e569a | 2018-10-02 18:05:21 +0100 | [diff] [blame] | 756 | int64_t ret; |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 757 | |
| 758 | /* Fail if addresses are not page-aligned. */ |
Alfredo Mazzinghi | eb1997c | 2019-02-07 18:00:01 +0000 | [diff] [blame] | 759 | if (!is_aligned(ipa_addr(send), PAGE_SIZE) || |
| 760 | !is_aligned(ipa_addr(recv), PAGE_SIZE)) { |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 761 | return -1; |
| 762 | } |
| 763 | |
Andrew Scull | c2eb6a3 | 2018-12-13 16:54:24 +0000 | [diff] [blame] | 764 | /* Convert to physical addresses. */ |
| 765 | pa_send_begin = pa_from_ipa(send); |
| 766 | pa_send_end = pa_add(pa_send_begin, PAGE_SIZE); |
| 767 | |
| 768 | pa_recv_begin = pa_from_ipa(recv); |
| 769 | pa_recv_end = pa_add(pa_recv_begin, PAGE_SIZE); |
| 770 | |
Andrew Scull | c9ccb3f | 2018-08-13 15:27:12 +0100 | [diff] [blame] | 771 | /* Fail if the same page is used for the send and receive pages. */ |
| 772 | if (pa_addr(pa_send_begin) == pa_addr(pa_recv_begin)) { |
Andrew Scull | 220e621 | 2018-12-21 18:09:00 +0000 | [diff] [blame] | 773 | return -1; |
| 774 | } |
| 775 | |
Andrew Scull | 3c0a90a | 2019-07-01 11:55:53 +0100 | [diff] [blame] | 776 | /* |
| 777 | * The hypervisor's memory map must be locked for the duration of this |
| 778 | * operation to ensure there will be sufficient memory to recover from |
| 779 | * any failures. |
| 780 | * |
| 781 | * TODO: the scope of the can be reduced but will require restructuring |
| 782 | * to keep a single unlock point. |
| 783 | */ |
Andrew Scull | e132279 | 2019-07-01 17:46:10 +0100 | [diff] [blame] | 784 | vm_locked = vm_lock(vm); |
Andrew Scull | 220e621 | 2018-12-21 18:09:00 +0000 | [diff] [blame] | 785 | |
| 786 | /* We only allow these to be setup once. */ |
| 787 | if (vm->mailbox.send || vm->mailbox.recv) { |
| 788 | goto fail; |
| 789 | } |
| 790 | |
| 791 | /* |
| 792 | * Ensure the pages are valid, owned and exclusive to the VM and that |
| 793 | * the VM has the required access to the memory. |
| 794 | */ |
| 795 | if (!mm_vm_get_mode(&vm->ptable, send, ipa_add(send, PAGE_SIZE), |
| 796 | &orig_send_mode) || |
| 797 | !api_mode_valid_owned_and_exclusive(orig_send_mode) || |
| 798 | (orig_send_mode & MM_MODE_R) == 0 || |
| 799 | (orig_send_mode & MM_MODE_W) == 0) { |
| 800 | goto fail; |
| 801 | } |
| 802 | |
| 803 | if (!mm_vm_get_mode(&vm->ptable, recv, ipa_add(recv, PAGE_SIZE), |
| 804 | &orig_recv_mode) || |
| 805 | !api_mode_valid_owned_and_exclusive(orig_recv_mode) || |
| 806 | (orig_recv_mode & MM_MODE_R) == 0) { |
| 807 | goto fail; |
| 808 | } |
| 809 | |
Andrew Scull | e132279 | 2019-07-01 17:46:10 +0100 | [diff] [blame] | 810 | if (!api_vm_configure_pages(vm_locked, pa_send_begin, pa_send_end, |
| 811 | orig_send_mode, pa_recv_begin, pa_recv_end, |
| 812 | orig_recv_mode)) { |
| 813 | goto fail; |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 814 | } |
| 815 | |
Wedson Almeida Filho | ea62e2e | 2019-01-09 19:14:59 +0000 | [diff] [blame] | 816 | /* Tell caller about waiters, if any. */ |
Andrew Scull | e132279 | 2019-07-01 17:46:10 +0100 | [diff] [blame] | 817 | ret = api_waiter_result(vm_locked, current, next); |
Andrew Scull | 220e621 | 2018-12-21 18:09:00 +0000 | [diff] [blame] | 818 | goto exit; |
| 819 | |
Andrew Scull | 220e621 | 2018-12-21 18:09:00 +0000 | [diff] [blame] | 820 | fail: |
| 821 | ret = -1; |
| 822 | |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 823 | exit: |
Andrew Scull | e132279 | 2019-07-01 17:46:10 +0100 | [diff] [blame] | 824 | vm_unlock(&vm_locked); |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 825 | |
| 826 | return ret; |
| 827 | } |
| 828 | |
| 829 | /** |
Andrew Scull | aa039b3 | 2018-10-04 15:02:26 +0100 | [diff] [blame] | 830 | * Copies data from the sender's send buffer to the recipient's receive buffer |
| 831 | * and notifies the recipient. |
Wedson Almeida Filho | 17c997f | 2019-01-09 18:50:09 +0000 | [diff] [blame] | 832 | * |
| 833 | * If the recipient's receive buffer is busy, it can optionally register the |
| 834 | * caller to be notified when the recipient's receive buffer becomes available. |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 835 | */ |
Jose Marinho | 75509b4 | 2019-04-09 09:34:59 +0100 | [diff] [blame] | 836 | spci_return_t api_spci_msg_send(uint32_t attributes, struct vcpu *current, |
| 837 | struct vcpu **next) |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 838 | { |
Wedson Almeida Filho | 00df6c7 | 2018-10-18 11:19:24 +0100 | [diff] [blame] | 839 | struct vm *from = current->vm; |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 840 | struct vm *to; |
Jose Marinho | 75509b4 | 2019-04-09 09:34:59 +0100 | [diff] [blame] | 841 | |
| 842 | struct two_vm_locked vm_from_to_lock; |
| 843 | |
Andrew Scull | b06d175 | 2019-02-04 10:15:48 +0000 | [diff] [blame] | 844 | struct hf_vcpu_run_return primary_ret = { |
| 845 | .code = HF_VCPU_RUN_MESSAGE, |
| 846 | }; |
Jose Marinho | a1dfeda | 2019-02-27 16:46:03 +0000 | [diff] [blame] | 847 | struct spci_message from_msg_replica; |
| 848 | struct spci_message *to_msg; |
| 849 | const struct spci_message *from_msg; |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 850 | |
Jose Marinho | a1dfeda | 2019-02-27 16:46:03 +0000 | [diff] [blame] | 851 | uint32_t size; |
Andrew Scull | 1950326 | 2018-09-20 14:48:39 +0100 | [diff] [blame] | 852 | |
Jose Marinho | a1dfeda | 2019-02-27 16:46:03 +0000 | [diff] [blame] | 853 | int64_t ret; |
| 854 | bool notify = (attributes & SPCI_MSG_SEND_NOTIFY_MASK) == |
| 855 | SPCI_MSG_SEND_NOTIFY; |
Andrew Scull | 1950326 | 2018-09-20 14:48:39 +0100 | [diff] [blame] | 856 | |
Jose Marinho | a1dfeda | 2019-02-27 16:46:03 +0000 | [diff] [blame] | 857 | /* |
| 858 | * Check that the sender has configured its send buffer. Copy the |
| 859 | * message header. If the tx mailbox at from_msg is configured (i.e. |
| 860 | * from_msg != NULL) then it can be safely accessed after releasing the |
| 861 | * lock since the tx mailbox address can only be configured once. |
| 862 | */ |
| 863 | sl_lock(&from->lock); |
| 864 | from_msg = from->mailbox.send; |
| 865 | sl_unlock(&from->lock); |
| 866 | |
| 867 | if (from_msg == NULL) { |
| 868 | return SPCI_INVALID_PARAMETERS; |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 869 | } |
| 870 | |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 871 | /* |
Jose Marinho | a1dfeda | 2019-02-27 16:46:03 +0000 | [diff] [blame] | 872 | * Note that the payload is not copied when the message header is. |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 873 | */ |
Jose Marinho | a1dfeda | 2019-02-27 16:46:03 +0000 | [diff] [blame] | 874 | from_msg_replica = *from_msg; |
| 875 | |
| 876 | /* Ensure source VM id corresponds to the current VM. */ |
| 877 | if (from_msg_replica.source_vm_id != from->id) { |
| 878 | return SPCI_INVALID_PARAMETERS; |
| 879 | } |
| 880 | |
| 881 | size = from_msg_replica.length; |
| 882 | /* Limit the size of transfer. */ |
Andrew Scull | 1262ac2 | 2019-04-05 12:44:26 +0100 | [diff] [blame] | 883 | if (size > SPCI_MSG_PAYLOAD_MAX) { |
Jose Marinho | a1dfeda | 2019-02-27 16:46:03 +0000 | [diff] [blame] | 884 | return SPCI_INVALID_PARAMETERS; |
| 885 | } |
| 886 | |
| 887 | /* Disallow reflexive requests as this suggests an error in the VM. */ |
| 888 | if (from_msg_replica.target_vm_id == from->id) { |
| 889 | return SPCI_INVALID_PARAMETERS; |
| 890 | } |
| 891 | |
| 892 | /* Ensure the target VM exists. */ |
Andrew Walbran | 42347a9 | 2019-05-09 13:59:03 +0100 | [diff] [blame] | 893 | to = vm_find(from_msg_replica.target_vm_id); |
Jose Marinho | a1dfeda | 2019-02-27 16:46:03 +0000 | [diff] [blame] | 894 | if (to == NULL) { |
| 895 | return SPCI_INVALID_PARAMETERS; |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 896 | } |
| 897 | |
Jose Marinho | 75509b4 | 2019-04-09 09:34:59 +0100 | [diff] [blame] | 898 | /* |
| 899 | * Hf needs to hold the lock on <to> before the mailbox state is |
| 900 | * checked. The lock on <to> must be held until the information is |
| 901 | * copied to <to> Rx buffer. Since in |
| 902 | * spci_msg_handle_architected_message we may call api_spci_share_memory |
| 903 | * which must hold the <from> lock, we must hold the <from> lock at this |
| 904 | * point to prevent a deadlock scenario. |
| 905 | */ |
| 906 | vm_from_to_lock = vm_lock_both(to, from); |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 907 | |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 908 | if (to->mailbox.state != MAILBOX_STATE_EMPTY || |
Andrew Scull | aa039b3 | 2018-10-04 15:02:26 +0100 | [diff] [blame] | 909 | to->mailbox.recv == NULL) { |
Wedson Almeida Filho | ea62e2e | 2019-01-09 19:14:59 +0000 | [diff] [blame] | 910 | /* |
| 911 | * Fail if the target isn't currently ready to receive data, |
| 912 | * setting up for notification if requested. |
| 913 | */ |
| 914 | if (notify) { |
Wedson Almeida Filho | b790f65 | 2019-01-22 23:41:56 +0000 | [diff] [blame] | 915 | struct wait_entry *entry = |
Jose Marinho | a1dfeda | 2019-02-27 16:46:03 +0000 | [diff] [blame] | 916 | ¤t->vm->wait_entries |
| 917 | [from_msg_replica.target_vm_id]; |
Wedson Almeida Filho | ea62e2e | 2019-01-09 19:14:59 +0000 | [diff] [blame] | 918 | |
| 919 | /* Append waiter only if it's not there yet. */ |
| 920 | if (list_empty(&entry->wait_links)) { |
| 921 | list_append(&to->mailbox.waiter_list, |
| 922 | &entry->wait_links); |
| 923 | } |
| 924 | } |
| 925 | |
Jose Marinho | a1dfeda | 2019-02-27 16:46:03 +0000 | [diff] [blame] | 926 | ret = SPCI_BUSY; |
Andrew Scull | aa039b3 | 2018-10-04 15:02:26 +0100 | [diff] [blame] | 927 | goto out; |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 928 | } |
| 929 | |
Jose Marinho | a1dfeda | 2019-02-27 16:46:03 +0000 | [diff] [blame] | 930 | to_msg = to->mailbox.recv; |
Jose Marinho | 75509b4 | 2019-04-09 09:34:59 +0100 | [diff] [blame] | 931 | |
| 932 | /* Handle architected messages. */ |
| 933 | if ((from_msg_replica.flags & SPCI_MESSAGE_IMPDEF_MASK) != |
| 934 | SPCI_MESSAGE_IMPDEF) { |
| 935 | /* |
| 936 | * Buffer holding the internal copy of the shared memory |
| 937 | * regions. |
| 938 | */ |
Jose Marinho | 20713fa | 2019-08-07 15:42:07 +0100 | [diff] [blame] | 939 | uint8_t *message_buffer = cpu_get_buffer(current->cpu->id); |
| 940 | uint32_t message_buffer_size = |
| 941 | cpu_get_buffer_size(current->cpu->id); |
Jose Marinho | 75509b4 | 2019-04-09 09:34:59 +0100 | [diff] [blame] | 942 | |
| 943 | struct spci_architected_message_header *architected_header = |
| 944 | spci_get_architected_message_header(from->mailbox.send); |
| 945 | |
| 946 | const struct spci_architected_message_header |
| 947 | *architected_message_replica; |
| 948 | |
Jose Marinho | 20713fa | 2019-08-07 15:42:07 +0100 | [diff] [blame] | 949 | if (from_msg_replica.length > message_buffer_size) { |
Jose Marinho | 75509b4 | 2019-04-09 09:34:59 +0100 | [diff] [blame] | 950 | ret = SPCI_INVALID_PARAMETERS; |
| 951 | goto out; |
| 952 | } |
| 953 | |
| 954 | if (from_msg_replica.length < |
| 955 | sizeof(struct spci_architected_message_header)) { |
| 956 | ret = SPCI_INVALID_PARAMETERS; |
| 957 | goto out; |
| 958 | } |
| 959 | |
| 960 | /* Copy the architected message into an internal buffer. */ |
Jose Marinho | 20713fa | 2019-08-07 15:42:07 +0100 | [diff] [blame] | 961 | memcpy_s(message_buffer, message_buffer_size, |
Jose Marinho | 75509b4 | 2019-04-09 09:34:59 +0100 | [diff] [blame] | 962 | architected_header, from_msg_replica.length); |
| 963 | |
| 964 | architected_message_replica = |
| 965 | (struct spci_architected_message_header *) |
| 966 | message_buffer; |
| 967 | |
| 968 | /* |
| 969 | * Note that message_buffer is passed as the third parameter to |
| 970 | * spci_msg_handle_architected_message. The execution flow |
| 971 | * commencing at spci_msg_handle_architected_message will make |
| 972 | * several accesses to fields in message_buffer. The memory area |
| 973 | * message_buffer must be exclusively owned by Hf so that TOCTOU |
| 974 | * issues do not arise. |
| 975 | */ |
| 976 | ret = spci_msg_handle_architected_message( |
| 977 | vm_from_to_lock.vm1, vm_from_to_lock.vm2, |
| 978 | architected_message_replica, &from_msg_replica, to_msg); |
| 979 | |
| 980 | if (ret != SPCI_SUCCESS) { |
| 981 | goto out; |
| 982 | } |
| 983 | } else { |
| 984 | /* Copy data. */ |
| 985 | memcpy_s(to_msg->payload, SPCI_MSG_PAYLOAD_MAX, |
| 986 | from->mailbox.send->payload, size); |
| 987 | *to_msg = from_msg_replica; |
| 988 | } |
| 989 | |
Andrew Scull | b06d175 | 2019-02-04 10:15:48 +0000 | [diff] [blame] | 990 | primary_ret.message.vm_id = to->id; |
Jose Marinho | a1dfeda | 2019-02-27 16:46:03 +0000 | [diff] [blame] | 991 | ret = SPCI_SUCCESS; |
Andrew Scull | aa039b3 | 2018-10-04 15:02:26 +0100 | [diff] [blame] | 992 | |
| 993 | /* Messages for the primary VM are delivered directly. */ |
| 994 | if (to->id == HF_PRIMARY_VM_ID) { |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 995 | to->mailbox.state = MAILBOX_STATE_READ; |
Wedson Almeida Filho | ba641ef | 2018-12-03 04:19:44 +0000 | [diff] [blame] | 996 | *next = api_switch_to_primary(current, primary_ret, |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 997 | VCPU_STATE_READY); |
Andrew Scull | aa039b3 | 2018-10-04 15:02:26 +0100 | [diff] [blame] | 998 | goto out; |
| 999 | } |
| 1000 | |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 1001 | to->mailbox.state = MAILBOX_STATE_RECEIVED; |
Andrew Scull | aa039b3 | 2018-10-04 15:02:26 +0100 | [diff] [blame] | 1002 | |
| 1003 | /* Return to the primary VM directly or with a switch. */ |
Andrew Scull | b06d175 | 2019-02-04 10:15:48 +0000 | [diff] [blame] | 1004 | if (from->id != HF_PRIMARY_VM_ID) { |
Wedson Almeida Filho | ba641ef | 2018-12-03 04:19:44 +0000 | [diff] [blame] | 1005 | *next = api_switch_to_primary(current, primary_ret, |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 1006 | VCPU_STATE_READY); |
Wedson Almeida Filho | 80eb4a3 | 2018-11-30 17:11:15 +0000 | [diff] [blame] | 1007 | } |
Andrew Scull | aa039b3 | 2018-10-04 15:02:26 +0100 | [diff] [blame] | 1008 | |
| 1009 | out: |
Jose Marinho | 75509b4 | 2019-04-09 09:34:59 +0100 | [diff] [blame] | 1010 | vm_unlock(&vm_from_to_lock.vm1); |
| 1011 | vm_unlock(&vm_from_to_lock.vm2); |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 1012 | |
Wedson Almeida Filho | 80eb4a3 | 2018-11-30 17:11:15 +0000 | [diff] [blame] | 1013 | return ret; |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 1014 | } |
| 1015 | |
| 1016 | /** |
Andrew Scull | ec52ddf | 2019-08-20 10:41:01 +0100 | [diff] [blame] | 1017 | * Checks whether the vCPU's attempt to block for a message has already been |
| 1018 | * interrupted or whether it is allowed to block. |
| 1019 | */ |
| 1020 | bool api_spci_msg_recv_block_interrupted(struct vcpu *current) |
| 1021 | { |
| 1022 | bool interrupted; |
| 1023 | |
| 1024 | sl_lock(¤t->lock); |
| 1025 | |
| 1026 | /* |
| 1027 | * Don't block if there are enabled and pending interrupts, to match |
| 1028 | * behaviour of wait_for_interrupt. |
| 1029 | */ |
| 1030 | interrupted = (current->interrupts.enabled_and_pending_count > 0); |
| 1031 | |
| 1032 | sl_unlock(¤t->lock); |
| 1033 | |
| 1034 | return interrupted; |
| 1035 | } |
| 1036 | |
| 1037 | /** |
Andrew Scull | aa039b3 | 2018-10-04 15:02:26 +0100 | [diff] [blame] | 1038 | * Receives a message from the mailbox. If one isn't available, this function |
| 1039 | * can optionally block the caller until one becomes available. |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 1040 | * |
Andrew Scull | aa039b3 | 2018-10-04 15:02:26 +0100 | [diff] [blame] | 1041 | * No new messages can be received until the mailbox has been cleared. |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 1042 | */ |
Andrew Walbran | 0de4f16 | 2019-09-03 16:44:20 +0100 | [diff] [blame^] | 1043 | int32_t api_spci_msg_recv(bool block, struct vcpu *current, struct vcpu **next) |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 1044 | { |
Wedson Almeida Filho | 00df6c7 | 2018-10-18 11:19:24 +0100 | [diff] [blame] | 1045 | struct vm *vm = current->vm; |
Jose Marinho | 3e2442f | 2019-03-12 13:30:37 +0000 | [diff] [blame] | 1046 | int32_t return_code; |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 1047 | |
Andrew Scull | aa039b3 | 2018-10-04 15:02:26 +0100 | [diff] [blame] | 1048 | /* |
| 1049 | * The primary VM will receive messages as a status code from running |
| 1050 | * vcpus and must not call this function. |
| 1051 | */ |
Andrew Scull | 1950326 | 2018-09-20 14:48:39 +0100 | [diff] [blame] | 1052 | if (vm->id == HF_PRIMARY_VM_ID) { |
Jose Marinho | 3e2442f | 2019-03-12 13:30:37 +0000 | [diff] [blame] | 1053 | return SPCI_INTERRUPTED; |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 1054 | } |
| 1055 | |
| 1056 | sl_lock(&vm->lock); |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 1057 | |
Andrew Scull | aa039b3 | 2018-10-04 15:02:26 +0100 | [diff] [blame] | 1058 | /* Return pending messages without blocking. */ |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 1059 | if (vm->mailbox.state == MAILBOX_STATE_RECEIVED) { |
| 1060 | vm->mailbox.state = MAILBOX_STATE_READ; |
Jose Marinho | 3e2442f | 2019-03-12 13:30:37 +0000 | [diff] [blame] | 1061 | return_code = SPCI_SUCCESS; |
| 1062 | goto out; |
| 1063 | } |
| 1064 | |
| 1065 | /* No pending message so fail if not allowed to block. */ |
| 1066 | if (!block) { |
| 1067 | return_code = SPCI_RETRY; |
Andrew Scull | aa039b3 | 2018-10-04 15:02:26 +0100 | [diff] [blame] | 1068 | goto out; |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 1069 | } |
Andrew Scull | aa039b3 | 2018-10-04 15:02:26 +0100 | [diff] [blame] | 1070 | |
Andrew Walbran | 9311c9a | 2019-03-12 16:59:04 +0000 | [diff] [blame] | 1071 | /* |
Jose Marinho | 3e2442f | 2019-03-12 13:30:37 +0000 | [diff] [blame] | 1072 | * From this point onward this call can only be interrupted or a message |
| 1073 | * received. If a message is received the return value will be set at |
| 1074 | * that time to SPCI_SUCCESS. |
Andrew Walbran | 9311c9a | 2019-03-12 16:59:04 +0000 | [diff] [blame] | 1075 | */ |
Jose Marinho | 3e2442f | 2019-03-12 13:30:37 +0000 | [diff] [blame] | 1076 | return_code = SPCI_INTERRUPTED; |
Andrew Scull | ec52ddf | 2019-08-20 10:41:01 +0100 | [diff] [blame] | 1077 | if (api_spci_msg_recv_block_interrupted(current)) { |
Andrew Scull | aa039b3 | 2018-10-04 15:02:26 +0100 | [diff] [blame] | 1078 | goto out; |
| 1079 | } |
| 1080 | |
Andrew Scull | aa039b3 | 2018-10-04 15:02:26 +0100 | [diff] [blame] | 1081 | /* Switch back to primary vm to block. */ |
Andrew Walbran | b481655 | 2018-12-05 17:35:42 +0000 | [diff] [blame] | 1082 | { |
| 1083 | struct hf_vcpu_run_return run_return = { |
Andrew Scull | b06d175 | 2019-02-04 10:15:48 +0000 | [diff] [blame] | 1084 | .code = HF_VCPU_RUN_WAIT_FOR_MESSAGE, |
Andrew Walbran | b481655 | 2018-12-05 17:35:42 +0000 | [diff] [blame] | 1085 | }; |
Wedson Almeida Filho | 81568c4 | 2019-01-04 13:33:02 +0000 | [diff] [blame] | 1086 | |
Andrew Walbran | b481655 | 2018-12-05 17:35:42 +0000 | [diff] [blame] | 1087 | *next = api_switch_to_primary(current, run_return, |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 1088 | VCPU_STATE_BLOCKED_MAILBOX); |
Andrew Walbran | b481655 | 2018-12-05 17:35:42 +0000 | [diff] [blame] | 1089 | } |
Andrew Scull | aa039b3 | 2018-10-04 15:02:26 +0100 | [diff] [blame] | 1090 | out: |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 1091 | sl_unlock(&vm->lock); |
| 1092 | |
Jose Marinho | 3e2442f | 2019-03-12 13:30:37 +0000 | [diff] [blame] | 1093 | return return_code; |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 1094 | } |
| 1095 | |
| 1096 | /** |
Wedson Almeida Filho | ea62e2e | 2019-01-09 19:14:59 +0000 | [diff] [blame] | 1097 | * Retrieves the next VM whose mailbox became writable. For a VM to be notified |
| 1098 | * by this function, the caller must have called api_mailbox_send before with |
| 1099 | * the notify argument set to true, and this call must have failed because the |
| 1100 | * mailbox was not available. |
| 1101 | * |
| 1102 | * It should be called repeatedly to retrieve a list of VMs. |
| 1103 | * |
| 1104 | * Returns -1 if no VM became writable, or the id of the VM whose mailbox |
| 1105 | * became writable. |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 1106 | */ |
Wedson Almeida Filho | ea62e2e | 2019-01-09 19:14:59 +0000 | [diff] [blame] | 1107 | int64_t api_mailbox_writable_get(const struct vcpu *current) |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 1108 | { |
Wedson Almeida Filho | 00df6c7 | 2018-10-18 11:19:24 +0100 | [diff] [blame] | 1109 | struct vm *vm = current->vm; |
Wedson Almeida Filho | ea62e2e | 2019-01-09 19:14:59 +0000 | [diff] [blame] | 1110 | struct wait_entry *entry; |
Andrew Scull | c0e569a | 2018-10-02 18:05:21 +0100 | [diff] [blame] | 1111 | int64_t ret; |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 1112 | |
| 1113 | sl_lock(&vm->lock); |
Wedson Almeida Filho | ea62e2e | 2019-01-09 19:14:59 +0000 | [diff] [blame] | 1114 | if (list_empty(&vm->mailbox.ready_list)) { |
| 1115 | ret = -1; |
| 1116 | goto exit; |
| 1117 | } |
| 1118 | |
| 1119 | entry = CONTAINER_OF(vm->mailbox.ready_list.next, struct wait_entry, |
| 1120 | ready_links); |
| 1121 | list_remove(&entry->ready_links); |
Wedson Almeida Filho | b790f65 | 2019-01-22 23:41:56 +0000 | [diff] [blame] | 1122 | ret = entry - vm->wait_entries; |
Wedson Almeida Filho | ea62e2e | 2019-01-09 19:14:59 +0000 | [diff] [blame] | 1123 | |
| 1124 | exit: |
| 1125 | sl_unlock(&vm->lock); |
| 1126 | return ret; |
| 1127 | } |
| 1128 | |
| 1129 | /** |
| 1130 | * Retrieves the next VM waiting to be notified that the mailbox of the |
| 1131 | * specified VM became writable. Only primary VMs are allowed to call this. |
| 1132 | * |
Wedson Almeida Filho | b790f65 | 2019-01-22 23:41:56 +0000 | [diff] [blame] | 1133 | * Returns -1 on failure or if there are no waiters; the VM id of the next |
| 1134 | * waiter otherwise. |
Wedson Almeida Filho | ea62e2e | 2019-01-09 19:14:59 +0000 | [diff] [blame] | 1135 | */ |
Andrew Walbran | 42347a9 | 2019-05-09 13:59:03 +0100 | [diff] [blame] | 1136 | int64_t api_mailbox_waiter_get(spci_vm_id_t vm_id, const struct vcpu *current) |
Wedson Almeida Filho | ea62e2e | 2019-01-09 19:14:59 +0000 | [diff] [blame] | 1137 | { |
| 1138 | struct vm *vm; |
| 1139 | struct vm_locked locked; |
| 1140 | struct wait_entry *entry; |
| 1141 | struct vm *waiting_vm; |
| 1142 | |
| 1143 | /* Only primary VMs are allowed to call this function. */ |
| 1144 | if (current->vm->id != HF_PRIMARY_VM_ID) { |
| 1145 | return -1; |
| 1146 | } |
| 1147 | |
Andrew Walbran | 42347a9 | 2019-05-09 13:59:03 +0100 | [diff] [blame] | 1148 | vm = vm_find(vm_id); |
Wedson Almeida Filho | ea62e2e | 2019-01-09 19:14:59 +0000 | [diff] [blame] | 1149 | if (vm == NULL) { |
| 1150 | return -1; |
| 1151 | } |
| 1152 | |
| 1153 | /* Check if there are outstanding notifications from given vm. */ |
Andrew Walbran | 7e932bd | 2019-04-29 16:47:06 +0100 | [diff] [blame] | 1154 | locked = vm_lock(vm); |
Wedson Almeida Filho | ea62e2e | 2019-01-09 19:14:59 +0000 | [diff] [blame] | 1155 | entry = api_fetch_waiter(locked); |
| 1156 | vm_unlock(&locked); |
| 1157 | |
| 1158 | if (entry == NULL) { |
| 1159 | return -1; |
| 1160 | } |
| 1161 | |
| 1162 | /* Enqueue notification to waiting VM. */ |
| 1163 | waiting_vm = entry->waiting_vm; |
| 1164 | |
| 1165 | sl_lock(&waiting_vm->lock); |
| 1166 | if (list_empty(&entry->ready_links)) { |
| 1167 | list_append(&waiting_vm->mailbox.ready_list, |
| 1168 | &entry->ready_links); |
| 1169 | } |
| 1170 | sl_unlock(&waiting_vm->lock); |
| 1171 | |
| 1172 | return waiting_vm->id; |
| 1173 | } |
| 1174 | |
| 1175 | /** |
| 1176 | * Clears the caller's mailbox so that a new message can be received. The caller |
| 1177 | * must have copied out all data they wish to preserve as new messages will |
| 1178 | * overwrite the old and will arrive asynchronously. |
| 1179 | * |
| 1180 | * Returns: |
Andrew Scull | aa7db8e | 2019-02-01 14:12:19 +0000 | [diff] [blame] | 1181 | * - -1 on failure, if the mailbox hasn't been read. |
Wedson Almeida Filho | ea62e2e | 2019-01-09 19:14:59 +0000 | [diff] [blame] | 1182 | * - 0 on success if no further action is needed. |
| 1183 | * - 1 if it was called by the primary VM and the primary VM now needs to wake |
| 1184 | * up or kick waiters. Waiters should be retrieved by calling |
| 1185 | * hf_mailbox_waiter_get. |
| 1186 | */ |
| 1187 | int64_t api_mailbox_clear(struct vcpu *current, struct vcpu **next) |
| 1188 | { |
| 1189 | struct vm *vm = current->vm; |
| 1190 | struct vm_locked locked; |
| 1191 | int64_t ret; |
| 1192 | |
Andrew Walbran | 7e932bd | 2019-04-29 16:47:06 +0100 | [diff] [blame] | 1193 | locked = vm_lock(vm); |
Andrew Scull | aa7db8e | 2019-02-01 14:12:19 +0000 | [diff] [blame] | 1194 | switch (vm->mailbox.state) { |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 1195 | case MAILBOX_STATE_EMPTY: |
Andrew Scull | aa7db8e | 2019-02-01 14:12:19 +0000 | [diff] [blame] | 1196 | ret = 0; |
| 1197 | break; |
| 1198 | |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 1199 | case MAILBOX_STATE_RECEIVED: |
Andrew Scull | aa7db8e | 2019-02-01 14:12:19 +0000 | [diff] [blame] | 1200 | ret = -1; |
| 1201 | break; |
| 1202 | |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 1203 | case MAILBOX_STATE_READ: |
Wedson Almeida Filho | ea62e2e | 2019-01-09 19:14:59 +0000 | [diff] [blame] | 1204 | ret = api_waiter_result(locked, current, next); |
Andrew Scull | d6ee110 | 2019-04-05 22:12:42 +0100 | [diff] [blame] | 1205 | vm->mailbox.state = MAILBOX_STATE_EMPTY; |
Andrew Scull | aa7db8e | 2019-02-01 14:12:19 +0000 | [diff] [blame] | 1206 | break; |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 1207 | } |
Wedson Almeida Filho | ea62e2e | 2019-01-09 19:14:59 +0000 | [diff] [blame] | 1208 | vm_unlock(&locked); |
Wedson Almeida Filho | 2f94ec1 | 2018-07-26 16:00:48 +0100 | [diff] [blame] | 1209 | |
| 1210 | return ret; |
Wedson Almeida Filho | 3fcbcff | 2018-07-10 23:53:39 +0100 | [diff] [blame] | 1211 | } |
Andrew Walbran | 318f573 | 2018-11-20 16:23:42 +0000 | [diff] [blame] | 1212 | |
| 1213 | /** |
| 1214 | * Enables or disables a given interrupt ID for the calling vCPU. |
| 1215 | * |
| 1216 | * Returns 0 on success, or -1 if the intid is invalid. |
| 1217 | */ |
Wedson Almeida Filho | c559d13 | 2019-01-09 19:33:40 +0000 | [diff] [blame] | 1218 | int64_t api_interrupt_enable(uint32_t intid, bool enable, struct vcpu *current) |
Andrew Walbran | 318f573 | 2018-11-20 16:23:42 +0000 | [diff] [blame] | 1219 | { |
| 1220 | uint32_t intid_index = intid / INTERRUPT_REGISTER_BITS; |
| 1221 | uint32_t intid_mask = 1u << (intid % INTERRUPT_REGISTER_BITS); |
Wedson Almeida Filho | 81568c4 | 2019-01-04 13:33:02 +0000 | [diff] [blame] | 1222 | |
Andrew Walbran | 318f573 | 2018-11-20 16:23:42 +0000 | [diff] [blame] | 1223 | if (intid >= HF_NUM_INTIDS) { |
| 1224 | return -1; |
| 1225 | } |
| 1226 | |
| 1227 | sl_lock(¤t->lock); |
| 1228 | if (enable) { |
Andrew Walbran | 3d84a26 | 2018-12-13 14:41:19 +0000 | [diff] [blame] | 1229 | /* |
| 1230 | * If it is pending and was not enabled before, increment the |
| 1231 | * count. |
| 1232 | */ |
| 1233 | if (current->interrupts.interrupt_pending[intid_index] & |
| 1234 | ~current->interrupts.interrupt_enabled[intid_index] & |
| 1235 | intid_mask) { |
| 1236 | current->interrupts.enabled_and_pending_count++; |
| 1237 | } |
Andrew Walbran | 318f573 | 2018-11-20 16:23:42 +0000 | [diff] [blame] | 1238 | current->interrupts.interrupt_enabled[intid_index] |= |
| 1239 | intid_mask; |
Andrew Walbran | 318f573 | 2018-11-20 16:23:42 +0000 | [diff] [blame] | 1240 | } else { |
Andrew Walbran | 3d84a26 | 2018-12-13 14:41:19 +0000 | [diff] [blame] | 1241 | /* |
| 1242 | * If it is pending and was enabled before, decrement the count. |
| 1243 | */ |
| 1244 | if (current->interrupts.interrupt_pending[intid_index] & |
| 1245 | current->interrupts.interrupt_enabled[intid_index] & |
| 1246 | intid_mask) { |
| 1247 | current->interrupts.enabled_and_pending_count--; |
| 1248 | } |
Andrew Walbran | 318f573 | 2018-11-20 16:23:42 +0000 | [diff] [blame] | 1249 | current->interrupts.interrupt_enabled[intid_index] &= |
| 1250 | ~intid_mask; |
| 1251 | } |
| 1252 | |
| 1253 | sl_unlock(¤t->lock); |
| 1254 | return 0; |
| 1255 | } |
| 1256 | |
| 1257 | /** |
| 1258 | * Returns the ID of the next pending interrupt for the calling vCPU, and |
| 1259 | * acknowledges it (i.e. marks it as no longer pending). Returns |
| 1260 | * HF_INVALID_INTID if there are no pending interrupts. |
| 1261 | */ |
Wedson Almeida Filho | c559d13 | 2019-01-09 19:33:40 +0000 | [diff] [blame] | 1262 | uint32_t api_interrupt_get(struct vcpu *current) |
Andrew Walbran | 318f573 | 2018-11-20 16:23:42 +0000 | [diff] [blame] | 1263 | { |
| 1264 | uint8_t i; |
| 1265 | uint32_t first_interrupt = HF_INVALID_INTID; |
Andrew Walbran | 318f573 | 2018-11-20 16:23:42 +0000 | [diff] [blame] | 1266 | |
| 1267 | /* |
| 1268 | * Find the first enabled and pending interrupt ID, return it, and |
| 1269 | * deactivate it. |
| 1270 | */ |
| 1271 | sl_lock(¤t->lock); |
| 1272 | for (i = 0; i < HF_NUM_INTIDS / INTERRUPT_REGISTER_BITS; ++i) { |
| 1273 | uint32_t enabled_and_pending = |
| 1274 | current->interrupts.interrupt_enabled[i] & |
| 1275 | current->interrupts.interrupt_pending[i]; |
Wedson Almeida Filho | 81568c4 | 2019-01-04 13:33:02 +0000 | [diff] [blame] | 1276 | |
Andrew Walbran | 318f573 | 2018-11-20 16:23:42 +0000 | [diff] [blame] | 1277 | if (enabled_and_pending != 0) { |
Andrew Walbran | 3d84a26 | 2018-12-13 14:41:19 +0000 | [diff] [blame] | 1278 | uint8_t bit_index = ctz(enabled_and_pending); |
| 1279 | /* |
| 1280 | * Mark it as no longer pending and decrement the count. |
| 1281 | */ |
| 1282 | current->interrupts.interrupt_pending[i] &= |
| 1283 | ~(1u << bit_index); |
| 1284 | current->interrupts.enabled_and_pending_count--; |
| 1285 | first_interrupt = |
| 1286 | i * INTERRUPT_REGISTER_BITS + bit_index; |
Andrew Walbran | 318f573 | 2018-11-20 16:23:42 +0000 | [diff] [blame] | 1287 | break; |
| 1288 | } |
| 1289 | } |
Andrew Walbran | 318f573 | 2018-11-20 16:23:42 +0000 | [diff] [blame] | 1290 | |
| 1291 | sl_unlock(¤t->lock); |
| 1292 | return first_interrupt; |
| 1293 | } |
| 1294 | |
| 1295 | /** |
Andrew Walbran | 4cf217a | 2018-12-14 15:24:50 +0000 | [diff] [blame] | 1296 | * Returns whether the current vCPU is allowed to inject an interrupt into the |
Andrew Walbran | 318f573 | 2018-11-20 16:23:42 +0000 | [diff] [blame] | 1297 | * given VM and vCPU. |
| 1298 | */ |
| 1299 | static inline bool is_injection_allowed(uint32_t target_vm_id, |
| 1300 | struct vcpu *current) |
| 1301 | { |
| 1302 | uint32_t current_vm_id = current->vm->id; |
Wedson Almeida Filho | 81568c4 | 2019-01-04 13:33:02 +0000 | [diff] [blame] | 1303 | |
Andrew Walbran | 318f573 | 2018-11-20 16:23:42 +0000 | [diff] [blame] | 1304 | /* |
| 1305 | * The primary VM is allowed to inject interrupts into any VM. Secondary |
| 1306 | * VMs are only allowed to inject interrupts into their own vCPUs. |
| 1307 | */ |
| 1308 | return current_vm_id == HF_PRIMARY_VM_ID || |
| 1309 | current_vm_id == target_vm_id; |
| 1310 | } |
| 1311 | |
| 1312 | /** |
| 1313 | * Injects a virtual interrupt of the given ID into the given target vCPU. |
| 1314 | * This doesn't cause the vCPU to actually be run immediately; it will be taken |
| 1315 | * when the vCPU is next run, which is up to the scheduler. |
| 1316 | * |
Andrew Walbran | 3d84a26 | 2018-12-13 14:41:19 +0000 | [diff] [blame] | 1317 | * Returns: |
| 1318 | * - -1 on failure because the target VM or vCPU doesn't exist, the interrupt |
| 1319 | * ID is invalid, or the current VM is not allowed to inject interrupts to |
| 1320 | * the target VM. |
| 1321 | * - 0 on success if no further action is needed. |
| 1322 | * - 1 if it was called by the primary VM and the primary VM now needs to wake |
| 1323 | * up or kick the target vCPU. |
Andrew Walbran | 318f573 | 2018-11-20 16:23:42 +0000 | [diff] [blame] | 1324 | */ |
Andrew Walbran | 42347a9 | 2019-05-09 13:59:03 +0100 | [diff] [blame] | 1325 | int64_t api_interrupt_inject(spci_vm_id_t target_vm_id, |
Andrew Walbran | b037d5b | 2019-06-25 17:19:41 +0100 | [diff] [blame] | 1326 | spci_vcpu_index_t target_vcpu_idx, uint32_t intid, |
Andrew Walbran | 42347a9 | 2019-05-09 13:59:03 +0100 | [diff] [blame] | 1327 | struct vcpu *current, struct vcpu **next) |
Andrew Walbran | 318f573 | 2018-11-20 16:23:42 +0000 | [diff] [blame] | 1328 | { |
Andrew Walbran | 318f573 | 2018-11-20 16:23:42 +0000 | [diff] [blame] | 1329 | struct vcpu *target_vcpu; |
Andrew Walbran | 42347a9 | 2019-05-09 13:59:03 +0100 | [diff] [blame] | 1330 | struct vm *target_vm = vm_find(target_vm_id); |
Andrew Walbran | 318f573 | 2018-11-20 16:23:42 +0000 | [diff] [blame] | 1331 | |
| 1332 | if (intid >= HF_NUM_INTIDS) { |
| 1333 | return -1; |
| 1334 | } |
Wedson Almeida Filho | 81568c4 | 2019-01-04 13:33:02 +0000 | [diff] [blame] | 1335 | |
Andrew Walbran | 318f573 | 2018-11-20 16:23:42 +0000 | [diff] [blame] | 1336 | if (target_vm == NULL) { |
| 1337 | return -1; |
| 1338 | } |
Wedson Almeida Filho | 81568c4 | 2019-01-04 13:33:02 +0000 | [diff] [blame] | 1339 | |
Andrew Walbran | 318f573 | 2018-11-20 16:23:42 +0000 | [diff] [blame] | 1340 | if (target_vcpu_idx >= target_vm->vcpu_count) { |
| 1341 | /* The requested vcpu must exist. */ |
| 1342 | return -1; |
| 1343 | } |
Wedson Almeida Filho | 81568c4 | 2019-01-04 13:33:02 +0000 | [diff] [blame] | 1344 | |
Andrew Walbran | 318f573 | 2018-11-20 16:23:42 +0000 | [diff] [blame] | 1345 | if (!is_injection_allowed(target_vm_id, current)) { |
| 1346 | return -1; |
| 1347 | } |
Wedson Almeida Filho | 81568c4 | 2019-01-04 13:33:02 +0000 | [diff] [blame] | 1348 | |
Andrew Walbran | e1310df | 2019-04-29 17:28:28 +0100 | [diff] [blame] | 1349 | target_vcpu = vm_get_vcpu(target_vm, target_vcpu_idx); |
Andrew Walbran | 318f573 | 2018-11-20 16:23:42 +0000 | [diff] [blame] | 1350 | |
| 1351 | dlog("Injecting IRQ %d for VM %d VCPU %d from VM %d VCPU %d\n", intid, |
| 1352 | target_vm_id, target_vcpu_idx, current->vm->id, current->cpu->id); |
Andrew Walbran | fc9d438 | 2019-05-10 18:07:21 +0100 | [diff] [blame] | 1353 | return internal_interrupt_inject(target_vcpu, intid, current, next); |
Andrew Walbran | 318f573 | 2018-11-20 16:23:42 +0000 | [diff] [blame] | 1354 | } |
Andrew Scull | 6386f25 | 2018-12-06 13:29:10 +0000 | [diff] [blame] | 1355 | |
| 1356 | /** |
| 1357 | * Clears a region of physical memory by overwriting it with zeros. The data is |
| 1358 | * flushed from the cache so the memory has been cleared across the system. |
| 1359 | */ |
| 1360 | static bool api_clear_memory(paddr_t begin, paddr_t end, struct mpool *ppool) |
| 1361 | { |
| 1362 | /* |
| 1363 | * TODO: change this to a cpu local single page window rather than a |
| 1364 | * global mapping of the whole range. Such an approach will limit |
| 1365 | * the changes to stage-1 tables and will allow only local |
| 1366 | * invalidation. |
| 1367 | */ |
Andrew Scull | 3c0a90a | 2019-07-01 11:55:53 +0100 | [diff] [blame] | 1368 | bool ret; |
| 1369 | struct mm_stage1_locked stage1_locked = mm_lock_stage1(); |
| 1370 | void *ptr = |
| 1371 | mm_identity_map(stage1_locked, begin, end, MM_MODE_W, ppool); |
Andrew Walbran | 2cb4339 | 2019-04-17 12:52:45 +0100 | [diff] [blame] | 1372 | size_t size = pa_difference(begin, end); |
Andrew Scull | 6386f25 | 2018-12-06 13:29:10 +0000 | [diff] [blame] | 1373 | |
| 1374 | if (!ptr) { |
| 1375 | /* TODO: partial defrag of failed range. */ |
| 1376 | /* Recover any memory consumed in failed mapping. */ |
Andrew Scull | 3c0a90a | 2019-07-01 11:55:53 +0100 | [diff] [blame] | 1377 | mm_defrag(stage1_locked, ppool); |
| 1378 | goto fail; |
Andrew Scull | 6386f25 | 2018-12-06 13:29:10 +0000 | [diff] [blame] | 1379 | } |
| 1380 | |
Andrew Scull | 2b5fbad | 2019-04-05 13:55:56 +0100 | [diff] [blame] | 1381 | memset_s(ptr, size, 0, size); |
Andrew Scull | c059fbe | 2019-09-12 12:58:40 +0100 | [diff] [blame] | 1382 | arch_mm_flush_dcache(ptr, size); |
Andrew Scull | 3c0a90a | 2019-07-01 11:55:53 +0100 | [diff] [blame] | 1383 | mm_unmap(stage1_locked, begin, end, ppool); |
Andrew Scull | 6386f25 | 2018-12-06 13:29:10 +0000 | [diff] [blame] | 1384 | |
Andrew Scull | 3c0a90a | 2019-07-01 11:55:53 +0100 | [diff] [blame] | 1385 | ret = true; |
| 1386 | goto out; |
| 1387 | |
| 1388 | fail: |
| 1389 | ret = false; |
| 1390 | |
| 1391 | out: |
| 1392 | mm_unlock_stage1(&stage1_locked); |
| 1393 | |
| 1394 | return ret; |
Andrew Scull | 6386f25 | 2018-12-06 13:29:10 +0000 | [diff] [blame] | 1395 | } |
| 1396 | |
Jose Marinho | 75509b4 | 2019-04-09 09:34:59 +0100 | [diff] [blame] | 1397 | /** TODO: Move function to spci_architectted_message.c. */ |
| 1398 | /** |
| 1399 | * Shares memory from the calling VM with another. The memory can be shared in |
| 1400 | * different modes. |
| 1401 | * |
| 1402 | * This function requires the calling context to hold the <to> and <from> locks. |
| 1403 | * |
| 1404 | * Returns: |
| 1405 | * In case of error one of the following values is returned: |
| 1406 | * 1) SPCI_INVALID_PARAMETERS - The endpoint provided parameters were |
| 1407 | * erroneous; |
| 1408 | * 2) SPCI_NO_MEMORY - Hf did not have sufficient memory to complete |
| 1409 | * the request. |
| 1410 | * Success is indicated by SPCI_SUCCESS. |
| 1411 | */ |
| 1412 | spci_return_t api_spci_share_memory(struct vm_locked to_locked, |
| 1413 | struct vm_locked from_locked, |
| 1414 | struct spci_memory_region *memory_region, |
| 1415 | uint32_t memory_to_attributes, |
| 1416 | enum spci_memory_share share) |
| 1417 | { |
| 1418 | struct vm *to = to_locked.vm; |
| 1419 | struct vm *from = from_locked.vm; |
| 1420 | int orig_from_mode; |
| 1421 | int from_mode; |
| 1422 | int to_mode; |
| 1423 | struct mpool local_page_pool; |
| 1424 | int64_t ret; |
| 1425 | paddr_t pa_begin; |
| 1426 | paddr_t pa_end; |
| 1427 | ipaddr_t begin; |
| 1428 | ipaddr_t end; |
| 1429 | |
| 1430 | size_t size; |
| 1431 | |
| 1432 | /* Disallow reflexive shares as this suggests an error in the VM. */ |
| 1433 | if (to == from) { |
| 1434 | return SPCI_INVALID_PARAMETERS; |
| 1435 | } |
| 1436 | |
| 1437 | /* |
| 1438 | * Create a local pool so any freed memory can't be used by another |
| 1439 | * thread. This is to ensure the original mapping can be restored if any |
| 1440 | * stage of the process fails. |
| 1441 | */ |
| 1442 | mpool_init_with_fallback(&local_page_pool, &api_page_pool); |
| 1443 | |
| 1444 | /* Obtain the single contiguous set of pages from the memory_region. */ |
| 1445 | /* TODO: Add support for multiple constituent regions. */ |
| 1446 | size = memory_region->constituents[0].page_count * PAGE_SIZE; |
| 1447 | begin = ipa_init(memory_region->constituents[0].address); |
| 1448 | end = ipa_add(begin, size); |
| 1449 | |
| 1450 | /* |
| 1451 | * Check if the state transition is lawful for both VMs involved |
| 1452 | * in the memory exchange, ensure that all constituents of a memory |
| 1453 | * region being shared are at the same state. |
| 1454 | */ |
| 1455 | if (!spci_msg_check_transition(to, from, share, &orig_from_mode, begin, |
| 1456 | end, memory_to_attributes, &from_mode, |
| 1457 | &to_mode)) { |
| 1458 | return SPCI_INVALID_PARAMETERS; |
| 1459 | } |
| 1460 | |
| 1461 | pa_begin = pa_from_ipa(begin); |
| 1462 | pa_end = pa_from_ipa(end); |
| 1463 | |
| 1464 | /* |
| 1465 | * First update the mapping for the sender so there is not overlap with |
| 1466 | * the recipient. |
| 1467 | */ |
| 1468 | if (!mm_vm_identity_map(&from->ptable, pa_begin, pa_end, from_mode, |
| 1469 | NULL, &local_page_pool)) { |
| 1470 | ret = SPCI_NO_MEMORY; |
| 1471 | goto out; |
| 1472 | } |
| 1473 | |
| 1474 | /* Complete the transfer by mapping the memory into the recipient. */ |
| 1475 | if (!mm_vm_identity_map(&to->ptable, pa_begin, pa_end, to_mode, NULL, |
| 1476 | &local_page_pool)) { |
| 1477 | /* TODO: partial defrag of failed range. */ |
| 1478 | /* Recover any memory consumed in failed mapping. */ |
| 1479 | mm_vm_defrag(&from->ptable, &local_page_pool); |
| 1480 | |
| 1481 | ret = SPCI_NO_MEMORY; |
| 1482 | |
| 1483 | CHECK(mm_vm_identity_map(&from->ptable, pa_begin, pa_end, |
| 1484 | orig_from_mode, NULL, |
| 1485 | &local_page_pool)); |
| 1486 | |
| 1487 | goto out; |
| 1488 | } |
| 1489 | |
| 1490 | ret = SPCI_SUCCESS; |
| 1491 | |
| 1492 | out: |
| 1493 | |
| 1494 | mpool_fini(&local_page_pool); |
| 1495 | |
| 1496 | return ret; |
| 1497 | } |
| 1498 | |
Andrew Scull | 6386f25 | 2018-12-06 13:29:10 +0000 | [diff] [blame] | 1499 | /** |
| 1500 | * Shares memory from the calling VM with another. The memory can be shared in |
| 1501 | * different modes. |
| 1502 | * |
| 1503 | * TODO: the interface for sharing memory will need to be enhanced to allow |
| 1504 | * sharing with different modes e.g. read-only, informing the recipient |
| 1505 | * of the memory they have been given, opting to not wipe the memory and |
| 1506 | * possibly allowing multiple blocks to be transferred. What this will |
| 1507 | * look like is TBD. |
| 1508 | */ |
Andrew Walbran | 42347a9 | 2019-05-09 13:59:03 +0100 | [diff] [blame] | 1509 | int64_t api_share_memory(spci_vm_id_t vm_id, ipaddr_t addr, size_t size, |
Andrew Scull | 6386f25 | 2018-12-06 13:29:10 +0000 | [diff] [blame] | 1510 | enum hf_share share, struct vcpu *current) |
| 1511 | { |
| 1512 | struct vm *from = current->vm; |
| 1513 | struct vm *to; |
| 1514 | int orig_from_mode; |
| 1515 | int from_mode; |
| 1516 | int to_mode; |
| 1517 | ipaddr_t begin; |
| 1518 | ipaddr_t end; |
| 1519 | paddr_t pa_begin; |
| 1520 | paddr_t pa_end; |
| 1521 | struct mpool local_page_pool; |
| 1522 | int64_t ret; |
| 1523 | |
| 1524 | /* Disallow reflexive shares as this suggests an error in the VM. */ |
| 1525 | if (vm_id == from->id) { |
| 1526 | return -1; |
| 1527 | } |
| 1528 | |
| 1529 | /* Ensure the target VM exists. */ |
Andrew Walbran | 42347a9 | 2019-05-09 13:59:03 +0100 | [diff] [blame] | 1530 | to = vm_find(vm_id); |
Andrew Scull | 6386f25 | 2018-12-06 13:29:10 +0000 | [diff] [blame] | 1531 | if (to == NULL) { |
| 1532 | return -1; |
| 1533 | } |
| 1534 | |
| 1535 | begin = addr; |
| 1536 | end = ipa_add(addr, size); |
| 1537 | |
| 1538 | /* Fail if addresses are not page-aligned. */ |
Alfredo Mazzinghi | eb1997c | 2019-02-07 18:00:01 +0000 | [diff] [blame] | 1539 | if (!is_aligned(ipa_addr(begin), PAGE_SIZE) || |
| 1540 | !is_aligned(ipa_addr(end), PAGE_SIZE)) { |
Andrew Scull | 6386f25 | 2018-12-06 13:29:10 +0000 | [diff] [blame] | 1541 | return -1; |
| 1542 | } |
| 1543 | |
| 1544 | /* Convert the sharing request to memory management modes. */ |
| 1545 | switch (share) { |
| 1546 | case HF_MEMORY_GIVE: |
| 1547 | from_mode = MM_MODE_INVALID | MM_MODE_UNOWNED; |
| 1548 | to_mode = MM_MODE_R | MM_MODE_W | MM_MODE_X; |
| 1549 | break; |
| 1550 | |
| 1551 | case HF_MEMORY_LEND: |
| 1552 | from_mode = MM_MODE_INVALID; |
| 1553 | to_mode = MM_MODE_R | MM_MODE_W | MM_MODE_X | MM_MODE_UNOWNED; |
| 1554 | break; |
| 1555 | |
| 1556 | case HF_MEMORY_SHARE: |
| 1557 | from_mode = MM_MODE_R | MM_MODE_W | MM_MODE_X | MM_MODE_SHARED; |
| 1558 | to_mode = MM_MODE_R | MM_MODE_W | MM_MODE_X | MM_MODE_UNOWNED | |
| 1559 | MM_MODE_SHARED; |
| 1560 | break; |
| 1561 | |
| 1562 | default: |
| 1563 | /* The input is untrusted so might not be a valid value. */ |
| 1564 | return -1; |
| 1565 | } |
| 1566 | |
| 1567 | /* |
| 1568 | * Create a local pool so any freed memory can't be used by another |
| 1569 | * thread. This is to ensure the original mapping can be restored if any |
| 1570 | * stage of the process fails. |
| 1571 | */ |
| 1572 | mpool_init_with_fallback(&local_page_pool, &api_page_pool); |
| 1573 | |
| 1574 | sl_lock_both(&from->lock, &to->lock); |
| 1575 | |
| 1576 | /* |
| 1577 | * Ensure that the memory range is mapped with the same mode so that |
| 1578 | * changes can be reverted if the process fails. |
| 1579 | */ |
| 1580 | if (!mm_vm_get_mode(&from->ptable, begin, end, &orig_from_mode)) { |
| 1581 | goto fail; |
| 1582 | } |
| 1583 | |
| 1584 | /* |
| 1585 | * Ensure the memory range is valid for the sender. If it isn't, the |
| 1586 | * sender has either shared it with another VM already or has no claim |
| 1587 | * to the memory. |
| 1588 | */ |
| 1589 | if (orig_from_mode & MM_MODE_INVALID) { |
| 1590 | goto fail; |
| 1591 | } |
| 1592 | |
| 1593 | /* |
| 1594 | * The sender must own the memory and have exclusive access to it in |
| 1595 | * order to share it. Alternatively, it is giving memory back to the |
| 1596 | * owning VM. |
| 1597 | */ |
| 1598 | if (orig_from_mode & MM_MODE_UNOWNED) { |
| 1599 | int orig_to_mode; |
| 1600 | |
| 1601 | if (share != HF_MEMORY_GIVE || |
| 1602 | !mm_vm_get_mode(&to->ptable, begin, end, &orig_to_mode) || |
| 1603 | orig_to_mode & MM_MODE_UNOWNED) { |
| 1604 | goto fail; |
| 1605 | } |
| 1606 | } else if (orig_from_mode & MM_MODE_SHARED) { |
| 1607 | goto fail; |
| 1608 | } |
| 1609 | |
| 1610 | pa_begin = pa_from_ipa(begin); |
| 1611 | pa_end = pa_from_ipa(end); |
| 1612 | |
| 1613 | /* |
| 1614 | * First update the mapping for the sender so there is not overlap with |
| 1615 | * the recipient. |
| 1616 | */ |
| 1617 | if (!mm_vm_identity_map(&from->ptable, pa_begin, pa_end, from_mode, |
| 1618 | NULL, &local_page_pool)) { |
| 1619 | goto fail; |
| 1620 | } |
| 1621 | |
| 1622 | /* Clear the memory so no VM or device can see the previous contents. */ |
| 1623 | if (!api_clear_memory(pa_begin, pa_end, &local_page_pool)) { |
| 1624 | goto fail_return_to_sender; |
| 1625 | } |
| 1626 | |
| 1627 | /* Complete the transfer by mapping the memory into the recipient. */ |
| 1628 | if (!mm_vm_identity_map(&to->ptable, pa_begin, pa_end, to_mode, NULL, |
| 1629 | &local_page_pool)) { |
| 1630 | /* TODO: partial defrag of failed range. */ |
| 1631 | /* Recover any memory consumed in failed mapping. */ |
| 1632 | mm_vm_defrag(&from->ptable, &local_page_pool); |
| 1633 | goto fail_return_to_sender; |
| 1634 | } |
| 1635 | |
| 1636 | ret = 0; |
| 1637 | goto out; |
| 1638 | |
| 1639 | fail_return_to_sender: |
Andrew Scull | 7e8de32 | 2019-07-02 13:00:56 +0100 | [diff] [blame] | 1640 | CHECK(mm_vm_identity_map(&from->ptable, pa_begin, pa_end, |
| 1641 | orig_from_mode, NULL, &local_page_pool)); |
Andrew Scull | 6386f25 | 2018-12-06 13:29:10 +0000 | [diff] [blame] | 1642 | |
| 1643 | fail: |
| 1644 | ret = -1; |
| 1645 | |
| 1646 | out: |
| 1647 | sl_unlock(&from->lock); |
| 1648 | sl_unlock(&to->lock); |
| 1649 | |
| 1650 | mpool_fini(&local_page_pool); |
| 1651 | |
| 1652 | return ret; |
| 1653 | } |
Jose Marinho | fc0b2b6 | 2019-06-06 11:18:45 +0100 | [diff] [blame] | 1654 | |
| 1655 | /** Returns the version of the implemented SPCI specification. */ |
| 1656 | int32_t api_spci_version(void) |
| 1657 | { |
| 1658 | /* |
| 1659 | * Ensure that both major and minor revision representation occupies at |
| 1660 | * most 15 bits. |
| 1661 | */ |
| 1662 | static_assert(0x8000 > SPCI_VERSION_MAJOR, |
| 1663 | "Major revision representation take more than 15 bits."); |
| 1664 | static_assert(0x10000 > SPCI_VERSION_MINOR, |
| 1665 | "Minor revision representation take more than 16 bits."); |
| 1666 | |
| 1667 | return (SPCI_VERSION_MAJOR << SPCI_VERSION_MAJOR_OFFSET) | |
| 1668 | SPCI_VERSION_MINOR; |
| 1669 | } |
Andrew Walbran | c1ad4ce | 2019-05-09 11:41:39 +0100 | [diff] [blame] | 1670 | |
| 1671 | int64_t api_debug_log(char c, struct vcpu *current) |
| 1672 | { |
Andrew Scull | d54e1be | 2019-08-20 11:09:42 +0100 | [diff] [blame] | 1673 | bool flush; |
Andrew Walbran | c1ad4ce | 2019-05-09 11:41:39 +0100 | [diff] [blame] | 1674 | struct vm *vm = current->vm; |
| 1675 | struct vm_locked vm_locked = vm_lock(vm); |
| 1676 | |
Andrew Scull | d54e1be | 2019-08-20 11:09:42 +0100 | [diff] [blame] | 1677 | if (c == '\n' || c == '\0') { |
| 1678 | flush = true; |
| 1679 | } else { |
| 1680 | vm->log_buffer[vm->log_buffer_length++] = c; |
| 1681 | flush = (vm->log_buffer_length == sizeof(vm->log_buffer)); |
| 1682 | } |
| 1683 | |
| 1684 | if (flush) { |
Andrew Walbran | 7f904bf | 2019-07-12 16:38:38 +0100 | [diff] [blame] | 1685 | dlog_flush_vm_buffer(vm->id, vm->log_buffer, |
| 1686 | vm->log_buffer_length); |
| 1687 | vm->log_buffer_length = 0; |
Andrew Walbran | c1ad4ce | 2019-05-09 11:41:39 +0100 | [diff] [blame] | 1688 | } |
| 1689 | |
| 1690 | vm_unlock(&vm_locked); |
| 1691 | |
| 1692 | return 0; |
| 1693 | } |