commit ba1fa9ad23419edc6738f42fd6796bc3aeb5145e
author Hugues de Valon <hugues.devalon@arm.com> Tue Jun 18 16:12:54 2019 +0100
committer Tamas Ban <tamas.ban@arm.com> Fri Jul 12 07:54:55 2019 +0000
tree f896033af6add39ea47ddc441bb48c1d782c9046
parent f2f5c01d00bca8bb7e13b1e7043c69035f4c2b77

Attest: Improve code quality

This patch fixes the following things:
* avoid implicit casting by using matching types or casting
* be explicit about return values of functions not checked
* fix indentation of code
* remove whitespaces

Change-Id: I8264b177d483d9f9f5f9e43e83f2268d0182d396
Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>

interface/src/tfm_initial_attestation_api.c

diff --git a/interface/src/tfm_initial_attestation_api.c b/interface/src/tfm_initial_attestation_api.c
index 826c667..f9ab4ce 100644
--- a/interface/src/tfm_initial_attestation_api.c
+++ b/interface/src/tfm_initial_attestation_api.c
@@ -25,7 +25,7 @@
     psa_handle_t handle = PSA_NULL_HANDLE;
     psa_status_t status;
 #else
-    uint32_t res;
+    int32_t res;
 #endif
     psa_invec in_vec[] = {
         {challenge_obj, challenge_size}
@@ -60,7 +60,7 @@
                                (uint32_t)in_vec,  IOVEC_LEN(in_vec),
                                (uint32_t)out_vec, IOVEC_LEN(out_vec));
 
-    if (res == PSA_ATTEST_ERR_SUCCESS) {
+    if (res == (int32_t)PSA_ATTEST_ERR_SUCCESS) {
         *token_size = out_vec[0].len;
     }