| gabor-mezei-arm | d112534 | 2021-07-12 16:31:22 +0200 | [diff] [blame] | 1 | /** | 
|  | 2 | *  Constant-time functions | 
|  | 3 | * | 
|  | 4 | *  Copyright The Mbed TLS Contributors | 
|  | 5 | *  SPDX-License-Identifier: Apache-2.0 | 
|  | 6 | * | 
|  | 7 | *  Licensed under the Apache License, Version 2.0 (the "License"); you may | 
|  | 8 | *  not use this file except in compliance with the License. | 
|  | 9 | *  You may obtain a copy of the License at | 
|  | 10 | * | 
|  | 11 | *  http://www.apache.org/licenses/LICENSE-2.0 | 
|  | 12 | * | 
|  | 13 | *  Unless required by applicable law or agreed to in writing, software | 
|  | 14 | *  distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | 
|  | 15 | *  WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | 
|  | 16 | *  See the License for the specific language governing permissions and | 
|  | 17 | *  limitations under the License. | 
|  | 18 | */ | 
|  | 19 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 20 | /* | 
| Gabor Mezei | 642eeb2 | 2021-11-03 16:13:32 +0100 | [diff] [blame] | 21 | * The following functions are implemented without using comparison operators, as those | 
| Gabor Mezei | eab90bc | 2021-10-18 16:09:41 +0200 | [diff] [blame] | 22 | * might be translated to branches by some compilers on some platforms. | 
|  | 23 | */ | 
|  | 24 |  | 
| gabor-mezei-arm | d112534 | 2021-07-12 16:31:22 +0200 | [diff] [blame] | 25 | #include "common.h" | 
| Gabor Mezei | 22c9a6f | 2021-10-20 12:09:35 +0200 | [diff] [blame] | 26 | #include "constant_time_internal.h" | 
| Gabor Mezei | 765862c | 2021-10-19 12:22:25 +0200 | [diff] [blame] | 27 | #include "mbedtls/constant_time.h" | 
| gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 28 | #include "mbedtls/error.h" | 
| gabor-mezei-arm | 5b3a32d | 2021-09-29 10:50:31 +0200 | [diff] [blame] | 29 | #include "mbedtls/platform_util.h" | 
| gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 30 |  | 
| gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 31 | #if defined(MBEDTLS_BIGNUM_C) | 
|  | 32 | #include "mbedtls/bignum.h" | 
| Gabor Mezei | 87638a9 | 2022-09-15 20:02:36 +0200 | [diff] [blame] | 33 | #include "bignum_core.h" | 
| gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 34 | #endif | 
|  | 35 |  | 
| gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 36 | #if defined(MBEDTLS_SSL_TLS_C) | 
|  | 37 | #include "ssl_misc.h" | 
|  | 38 | #endif | 
|  | 39 |  | 
| gabor-mezei-arm | 5b3a32d | 2021-09-29 10:50:31 +0200 | [diff] [blame] | 40 | #if defined(MBEDTLS_RSA_C) | 
|  | 41 | #include "mbedtls/rsa.h" | 
|  | 42 | #endif | 
|  | 43 |  | 
| Gabor Mezei | 28d6115 | 2021-11-15 16:13:01 +0100 | [diff] [blame] | 44 | #if defined(MBEDTLS_BASE64_C) | 
|  | 45 | #include "constant_time_invasive.h" | 
|  | 46 | #endif | 
|  | 47 |  | 
| gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 48 | #include <string.h> | 
| Andrzej Kurek | 8a045ce | 2022-12-23 11:00:06 -0500 | [diff] [blame] | 49 | #if defined(MBEDTLS_USE_PSA_CRYPTO) | 
|  | 50 | #define PSA_TO_MBEDTLS_ERR(status) PSA_TO_MBEDTLS_ERR_LIST(status,    \ | 
|  | 51 | psa_to_ssl_errors,              \ | 
|  | 52 | psa_generic_status_to_mbedtls) | 
|  | 53 | #endif | 
| gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 54 |  | 
| Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 55 | /* | 
| Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 56 | * Define MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS where assembly is present to | 
|  | 57 | * perform fast unaligned access to volatile data. | 
| Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 58 | * | 
|  | 59 | * This is needed because mbedtls_get_unaligned_uintXX etc don't support volatile | 
|  | 60 | * memory accesses. | 
|  | 61 | * | 
| Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 62 | * Some of these definitions could be moved into alignment.h but for now they are | 
|  | 63 | * only used here. | 
| Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 64 | */ | 
| Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 65 | #if defined(MBEDTLS_EFFICIENT_UNALIGNED_ACCESS) && defined(MBEDTLS_HAVE_ASM) | 
|  | 66 | #if defined(__arm__) || defined(__thumb__) || defined(__thumb2__) || defined(__aarch64__) | 
|  | 67 | #define MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS | 
|  | 68 | #endif | 
| Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 69 | #endif | 
|  | 70 |  | 
| Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 71 | #if defined(MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS) | 
| Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 72 | static inline uint32_t mbedtls_get_unaligned_volatile_uint32(volatile const unsigned char *p) | 
|  | 73 | { | 
|  | 74 | /* This is UB, even where it's safe: | 
|  | 75 | *    return *((volatile uint32_t*)p); | 
|  | 76 | * so instead the same thing is expressed in assembly below. | 
|  | 77 | */ | 
|  | 78 | uint32_t r; | 
|  | 79 | #if defined(__arm__) || defined(__thumb__) || defined(__thumb2__) | 
| Dave Rodgman | 4610d4b | 2023-01-30 09:26:48 +0000 | [diff] [blame] | 80 | asm volatile ("ldr %0, [%1]" : "=r" (r) : "r" (p) :); | 
| Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 81 | #elif defined(__aarch64__) | 
| Dave Rodgman | 4610d4b | 2023-01-30 09:26:48 +0000 | [diff] [blame] | 82 | asm volatile ("ldr %w0, [%1]" : "=r" (r) : "r" (p) :); | 
| Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 83 | #endif | 
| Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 84 | return r; | 
| Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 85 | } | 
| Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 86 | #endif /* MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS */ | 
| Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 87 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 88 | int mbedtls_ct_memcmp(const void *a, | 
|  | 89 | const void *b, | 
|  | 90 | size_t n) | 
| gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 91 | { | 
| Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 92 | size_t i = 0; | 
| Dave Rodgman | 7658b63 | 2023-01-11 17:39:33 +0000 | [diff] [blame] | 93 | /* | 
|  | 94 | * `A` and `B` are cast to volatile to ensure that the compiler | 
|  | 95 | * generates code that always fully reads both buffers. | 
|  | 96 | * Otherwise it could generate a test to exit early if `diff` has all | 
|  | 97 | * bits set early in the loop. | 
|  | 98 | */ | 
| gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 99 | volatile const unsigned char *A = (volatile const unsigned char *) a; | 
|  | 100 | volatile const unsigned char *B = (volatile const unsigned char *) b; | 
| Dave Rodgman | 7658b63 | 2023-01-11 17:39:33 +0000 | [diff] [blame] | 101 | uint32_t diff = 0; | 
| gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 102 |  | 
| Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 103 | #if defined(MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS) | 
| Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 104 | for (; (i + 4) <= n; i += 4) { | 
|  | 105 | uint32_t x = mbedtls_get_unaligned_volatile_uint32(A + i); | 
|  | 106 | uint32_t y = mbedtls_get_unaligned_volatile_uint32(B + i); | 
|  | 107 | diff |= x ^ y; | 
|  | 108 | } | 
|  | 109 | #endif | 
|  | 110 |  | 
|  | 111 | for (; i < n; i++) { | 
| gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 112 | /* Read volatile data in order before computing diff. | 
|  | 113 | * This avoids IAR compiler warning: | 
|  | 114 | * 'the order of volatile accesses is undefined ..' */ | 
|  | 115 | unsigned char x = A[i], y = B[i]; | 
|  | 116 | diff |= x ^ y; | 
|  | 117 | } | 
|  | 118 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 119 | return (int) diff; | 
| gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 120 | } | 
|  | 121 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 122 | unsigned mbedtls_ct_uint_mask(unsigned value) | 
| gabor-mezei-arm | 340948e | 2021-09-27 11:40:03 +0200 | [diff] [blame] | 123 | { | 
|  | 124 | /* MSVC has a warning about unary minus on unsigned, but this is | 
|  | 125 | * well-defined and precisely what we want to do here */ | 
|  | 126 | #if defined(_MSC_VER) | 
|  | 127 | #pragma warning( push ) | 
|  | 128 | #pragma warning( disable : 4146 ) | 
|  | 129 | #endif | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 130 | return -((value | -value) >> (sizeof(value) * 8 - 1)); | 
| gabor-mezei-arm | 340948e | 2021-09-27 11:40:03 +0200 | [diff] [blame] | 131 | #if defined(_MSC_VER) | 
|  | 132 | #pragma warning( pop ) | 
|  | 133 | #endif | 
|  | 134 | } | 
| gabor-mezei-arm | 3733bf8 | 2021-09-27 11:49:42 +0200 | [diff] [blame] | 135 |  | 
| Przemek Stekiel | 89ad623 | 2022-09-27 13:36:12 +0200 | [diff] [blame] | 136 | #if defined(MBEDTLS_SSL_SOME_SUITES_USE_MAC) | 
| Gabor Mezei | 6a426c9 | 2021-10-20 11:17:43 +0200 | [diff] [blame] | 137 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 138 | size_t mbedtls_ct_size_mask(size_t value) | 
| gabor-mezei-arm | 3733bf8 | 2021-09-27 11:49:42 +0200 | [diff] [blame] | 139 | { | 
|  | 140 | /* MSVC has a warning about unary minus on unsigned integer types, | 
|  | 141 | * but this is well-defined and precisely what we want to do here. */ | 
|  | 142 | #if defined(_MSC_VER) | 
|  | 143 | #pragma warning( push ) | 
|  | 144 | #pragma warning( disable : 4146 ) | 
|  | 145 | #endif | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 146 | return -((value | -value) >> (sizeof(value) * 8 - 1)); | 
| gabor-mezei-arm | 3733bf8 | 2021-09-27 11:49:42 +0200 | [diff] [blame] | 147 | #if defined(_MSC_VER) | 
|  | 148 | #pragma warning( pop ) | 
|  | 149 | #endif | 
|  | 150 | } | 
| gabor-mezei-arm | c76227d | 2021-09-27 11:53:54 +0200 | [diff] [blame] | 151 |  | 
| Przemek Stekiel | 89ad623 | 2022-09-27 13:36:12 +0200 | [diff] [blame] | 152 | #endif /* MBEDTLS_SSL_SOME_SUITES_USE_MAC */ | 
| Gabor Mezei | 6a426c9 | 2021-10-20 11:17:43 +0200 | [diff] [blame] | 153 |  | 
| gabor-mezei-arm | 9cb5569 | 2021-08-11 15:07:02 +0200 | [diff] [blame] | 154 | #if defined(MBEDTLS_BIGNUM_C) | 
|  | 155 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 156 | mbedtls_mpi_uint mbedtls_ct_mpi_uint_mask(mbedtls_mpi_uint value) | 
| gabor-mezei-arm | 9cb5569 | 2021-08-11 15:07:02 +0200 | [diff] [blame] | 157 | { | 
|  | 158 | /* MSVC has a warning about unary minus on unsigned, but this is | 
|  | 159 | * well-defined and precisely what we want to do here */ | 
|  | 160 | #if defined(_MSC_VER) | 
|  | 161 | #pragma warning( push ) | 
|  | 162 | #pragma warning( disable : 4146 ) | 
|  | 163 | #endif | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 164 | return -((value | -value) >> (sizeof(value) * 8 - 1)); | 
| gabor-mezei-arm | 9cb5569 | 2021-08-11 15:07:02 +0200 | [diff] [blame] | 165 | #if defined(_MSC_VER) | 
|  | 166 | #pragma warning( pop ) | 
|  | 167 | #endif | 
|  | 168 | } | 
|  | 169 |  | 
|  | 170 | #endif /* MBEDTLS_BIGNUM_C */ | 
|  | 171 |  | 
| Gabor Mezei | e212379 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 172 | #if defined(MBEDTLS_SSL_SOME_SUITES_USE_TLS_CBC) | 
|  | 173 |  | 
| Gabor Mezei | 1e64261 | 2021-10-18 16:05:50 +0200 | [diff] [blame] | 174 | /** Constant-flow mask generation for "less than" comparison: | 
|  | 175 | * - if \p x < \p y, return all-bits 1, that is (size_t) -1 | 
|  | 176 | * - otherwise, return all bits 0, that is 0 | 
|  | 177 | * | 
|  | 178 | * This function can be used to write constant-time code by replacing branches | 
|  | 179 | * with bit operations using masks. | 
|  | 180 | * | 
|  | 181 | * \param x     The first value to analyze. | 
|  | 182 | * \param y     The second value to analyze. | 
|  | 183 | * | 
|  | 184 | * \return      All-bits-one if \p x is less than \p y, otherwise zero. | 
|  | 185 | */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 186 | static size_t mbedtls_ct_size_mask_lt(size_t x, | 
|  | 187 | size_t y) | 
| gabor-mezei-arm | c76227d | 2021-09-27 11:53:54 +0200 | [diff] [blame] | 188 | { | 
|  | 189 | /* This has the most significant bit set if and only if x < y */ | 
|  | 190 | const size_t sub = x - y; | 
|  | 191 |  | 
|  | 192 | /* sub1 = (x < y) ? 1 : 0 */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 193 | const size_t sub1 = sub >> (sizeof(sub) * 8 - 1); | 
| gabor-mezei-arm | c76227d | 2021-09-27 11:53:54 +0200 | [diff] [blame] | 194 |  | 
|  | 195 | /* mask = (x < y) ? 0xff... : 0x00... */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 196 | const size_t mask = mbedtls_ct_size_mask(sub1); | 
| gabor-mezei-arm | c76227d | 2021-09-27 11:53:54 +0200 | [diff] [blame] | 197 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 198 | return mask; | 
| gabor-mezei-arm | c76227d | 2021-09-27 11:53:54 +0200 | [diff] [blame] | 199 | } | 
| gabor-mezei-arm | 16fc57b | 2021-09-27 11:58:31 +0200 | [diff] [blame] | 200 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 201 | size_t mbedtls_ct_size_mask_ge(size_t x, | 
|  | 202 | size_t y) | 
| gabor-mezei-arm | 16fc57b | 2021-09-27 11:58:31 +0200 | [diff] [blame] | 203 | { | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 204 | return ~mbedtls_ct_size_mask_lt(x, y); | 
| gabor-mezei-arm | 16fc57b | 2021-09-27 11:58:31 +0200 | [diff] [blame] | 205 | } | 
| gabor-mezei-arm | 8d1d5fd | 2021-09-27 12:15:19 +0200 | [diff] [blame] | 206 |  | 
| Gabor Mezei | e212379 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 207 | #endif /* MBEDTLS_SSL_SOME_SUITES_USE_TLS_CBC */ | 
|  | 208 |  | 
| Gabor Mezei | 28d6115 | 2021-11-15 16:13:01 +0100 | [diff] [blame] | 209 | #if defined(MBEDTLS_BASE64_C) | 
|  | 210 |  | 
|  | 211 | /* Return 0xff if low <= c <= high, 0 otherwise. | 
|  | 212 | * | 
|  | 213 | * Constant flow with respect to c. | 
|  | 214 | */ | 
| Gabor Mezei | c0d8dda | 2021-11-26 17:20:36 +0100 | [diff] [blame] | 215 | MBEDTLS_STATIC_TESTABLE | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 216 | unsigned char mbedtls_ct_uchar_mask_of_range(unsigned char low, | 
|  | 217 | unsigned char high, | 
|  | 218 | unsigned char c) | 
| Gabor Mezei | 28d6115 | 2021-11-15 16:13:01 +0100 | [diff] [blame] | 219 | { | 
|  | 220 | /* low_mask is: 0 if low <= c, 0x...ff if low > c */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 221 | unsigned low_mask = ((unsigned) c - low) >> 8; | 
| Gabor Mezei | 28d6115 | 2021-11-15 16:13:01 +0100 | [diff] [blame] | 222 | /* high_mask is: 0 if c <= high, 0x...ff if c > high */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 223 | unsigned high_mask = ((unsigned) high - c) >> 8; | 
|  | 224 | return ~(low_mask | high_mask) & 0xff; | 
| Gabor Mezei | 28d6115 | 2021-11-15 16:13:01 +0100 | [diff] [blame] | 225 | } | 
|  | 226 |  | 
|  | 227 | #endif /* MBEDTLS_BASE64_C */ | 
|  | 228 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 229 | unsigned mbedtls_ct_size_bool_eq(size_t x, | 
|  | 230 | size_t y) | 
| gabor-mezei-arm | 8d1d5fd | 2021-09-27 12:15:19 +0200 | [diff] [blame] | 231 | { | 
|  | 232 | /* diff = 0 if x == y, non-zero otherwise */ | 
|  | 233 | const size_t diff = x ^ y; | 
|  | 234 |  | 
|  | 235 | /* MSVC has a warning about unary minus on unsigned integer types, | 
|  | 236 | * but this is well-defined and precisely what we want to do here. */ | 
|  | 237 | #if defined(_MSC_VER) | 
|  | 238 | #pragma warning( push ) | 
|  | 239 | #pragma warning( disable : 4146 ) | 
|  | 240 | #endif | 
|  | 241 |  | 
|  | 242 | /* diff_msb's most significant bit is equal to x != y */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 243 | const size_t diff_msb = (diff | (size_t) -diff); | 
| gabor-mezei-arm | 8d1d5fd | 2021-09-27 12:15:19 +0200 | [diff] [blame] | 244 |  | 
|  | 245 | #if defined(_MSC_VER) | 
|  | 246 | #pragma warning( pop ) | 
|  | 247 | #endif | 
|  | 248 |  | 
|  | 249 | /* diff1 = (x != y) ? 1 : 0 */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 250 | const unsigned diff1 = diff_msb >> (sizeof(diff_msb) * 8 - 1); | 
| gabor-mezei-arm | 8d1d5fd | 2021-09-27 12:15:19 +0200 | [diff] [blame] | 251 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 252 | return 1 ^ diff1; | 
| gabor-mezei-arm | 8d1d5fd | 2021-09-27 12:15:19 +0200 | [diff] [blame] | 253 | } | 
| gabor-mezei-arm | 5a85442 | 2021-09-27 12:25:07 +0200 | [diff] [blame] | 254 |  | 
| Gabor Mezei | e212379 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 255 | #if defined(MBEDTLS_PKCS1_V15) && defined(MBEDTLS_RSA_C) && !defined(MBEDTLS_RSA_ALT) | 
|  | 256 |  | 
| Gabor Mezei | a2d0f90 | 2021-10-18 16:35:23 +0200 | [diff] [blame] | 257 | /** Constant-flow "greater than" comparison: | 
|  | 258 | * return x > y | 
|  | 259 | * | 
|  | 260 | * This is equivalent to \p x > \p y, but is likely to be compiled | 
|  | 261 | * to code using bitwise operation rather than a branch. | 
|  | 262 | * | 
|  | 263 | * \param x     The first value to analyze. | 
|  | 264 | * \param y     The second value to analyze. | 
|  | 265 | * | 
|  | 266 | * \return      1 if \p x greater than \p y, otherwise 0. | 
|  | 267 | */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 268 | static unsigned mbedtls_ct_size_gt(size_t x, | 
|  | 269 | size_t y) | 
| gabor-mezei-arm | 5a85442 | 2021-09-27 12:25:07 +0200 | [diff] [blame] | 270 | { | 
| gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 271 | /* Return the sign bit (1 for negative) of (y - x). */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 272 | return (y - x) >> (sizeof(size_t) * 8 - 1); | 
| gabor-mezei-arm | 5a85442 | 2021-09-27 12:25:07 +0200 | [diff] [blame] | 273 | } | 
| gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 274 |  | 
| Gabor Mezei | e212379 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 275 | #endif /* MBEDTLS_PKCS1_V15 && MBEDTLS_RSA_C && ! MBEDTLS_RSA_ALT */ | 
|  | 276 |  | 
| gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 277 | #if defined(MBEDTLS_BIGNUM_C) | 
|  | 278 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 279 | unsigned mbedtls_ct_mpi_uint_lt(const mbedtls_mpi_uint x, | 
|  | 280 | const mbedtls_mpi_uint y) | 
| gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 281 | { | 
|  | 282 | mbedtls_mpi_uint ret; | 
|  | 283 | mbedtls_mpi_uint cond; | 
|  | 284 |  | 
|  | 285 | /* | 
|  | 286 | * Check if the most significant bits (MSB) of the operands are different. | 
|  | 287 | */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 288 | cond = (x ^ y); | 
| gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 289 | /* | 
|  | 290 | * If the MSB are the same then the difference x-y will be negative (and | 
|  | 291 | * have its MSB set to 1 during conversion to unsigned) if and only if x<y. | 
|  | 292 | */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 293 | ret = (x - y) & ~cond; | 
| gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 294 | /* | 
|  | 295 | * If the MSB are different, then the operand with the MSB of 1 is the | 
|  | 296 | * bigger. (That is if y has MSB of 1, then x<y is true and it is false if | 
|  | 297 | * the MSB of y is 0.) | 
|  | 298 | */ | 
|  | 299 | ret |= y & cond; | 
|  | 300 |  | 
|  | 301 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 302 | ret = ret >> (sizeof(mbedtls_mpi_uint) * 8 - 1); | 
| gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 303 |  | 
|  | 304 | return (unsigned) ret; | 
|  | 305 | } | 
|  | 306 |  | 
|  | 307 | #endif /* MBEDTLS_BIGNUM_C */ | 
| gabor-mezei-arm | b2dbf2c | 2021-09-27 12:59:30 +0200 | [diff] [blame] | 308 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 309 | unsigned mbedtls_ct_uint_if(unsigned condition, | 
|  | 310 | unsigned if1, | 
|  | 311 | unsigned if0) | 
| gabor-mezei-arm | b2dbf2c | 2021-09-27 12:59:30 +0200 | [diff] [blame] | 312 | { | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 313 | unsigned mask = mbedtls_ct_uint_mask(condition); | 
|  | 314 | return (mask & if1) | (~mask & if0); | 
| gabor-mezei-arm | b2dbf2c | 2021-09-27 12:59:30 +0200 | [diff] [blame] | 315 | } | 
| gabor-mezei-arm | d3230d5 | 2021-09-27 13:03:57 +0200 | [diff] [blame] | 316 |  | 
| Gabor Mezei | e212379 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 317 | #if defined(MBEDTLS_BIGNUM_C) | 
| gabor-mezei-arm | 65cefdb | 2021-09-27 15:47:00 +0200 | [diff] [blame] | 318 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 319 | void mbedtls_ct_mpi_uint_cond_assign(size_t n, | 
|  | 320 | mbedtls_mpi_uint *dest, | 
|  | 321 | const mbedtls_mpi_uint *src, | 
|  | 322 | unsigned char condition) | 
| gabor-mezei-arm | be8d98b | 2021-09-27 13:17:15 +0200 | [diff] [blame] | 323 | { | 
|  | 324 | size_t i; | 
|  | 325 |  | 
|  | 326 | /* MSVC has a warning about unary minus on unsigned integer types, | 
|  | 327 | * but this is well-defined and precisely what we want to do here. */ | 
|  | 328 | #if defined(_MSC_VER) | 
|  | 329 | #pragma warning( push ) | 
|  | 330 | #pragma warning( disable : 4146 ) | 
|  | 331 | #endif | 
|  | 332 |  | 
| gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 333 | /* all-bits 1 if condition is 1, all-bits 0 if condition is 0 */ | 
|  | 334 | const mbedtls_mpi_uint mask = -condition; | 
| gabor-mezei-arm | be8d98b | 2021-09-27 13:17:15 +0200 | [diff] [blame] | 335 |  | 
|  | 336 | #if defined(_MSC_VER) | 
|  | 337 | #pragma warning( pop ) | 
|  | 338 | #endif | 
|  | 339 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 340 | for (i = 0; i < n; i++) { | 
|  | 341 | dest[i] = (src[i] & mask) | (dest[i] & ~mask); | 
|  | 342 | } | 
| gabor-mezei-arm | be8d98b | 2021-09-27 13:17:15 +0200 | [diff] [blame] | 343 | } | 
|  | 344 |  | 
|  | 345 | #endif /* MBEDTLS_BIGNUM_C */ | 
| gabor-mezei-arm | 394aeaa | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 346 |  | 
| Gabor Mezei | 9a4074a | 2021-11-15 16:18:54 +0100 | [diff] [blame] | 347 | #if defined(MBEDTLS_BASE64_C) | 
|  | 348 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 349 | unsigned char mbedtls_ct_base64_enc_char(unsigned char value) | 
| Gabor Mezei | 9a4074a | 2021-11-15 16:18:54 +0100 | [diff] [blame] | 350 | { | 
|  | 351 | unsigned char digit = 0; | 
| Gabor Mezei | 14d5fac | 2021-11-24 15:51:39 +0100 | [diff] [blame] | 352 | /* For each range of values, if value is in that range, mask digit with | 
|  | 353 | * the corresponding value. Since value can only be in a single range, | 
| Gabor Mezei | 9a4074a | 2021-11-15 16:18:54 +0100 | [diff] [blame] | 354 | * only at most one masking will change digit. */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 355 | digit |= mbedtls_ct_uchar_mask_of_range(0, 25, value) & ('A' + value); | 
|  | 356 | digit |= mbedtls_ct_uchar_mask_of_range(26, 51, value) & ('a' + value - 26); | 
|  | 357 | digit |= mbedtls_ct_uchar_mask_of_range(52, 61, value) & ('0' + value - 52); | 
|  | 358 | digit |= mbedtls_ct_uchar_mask_of_range(62, 62, value) & '+'; | 
|  | 359 | digit |= mbedtls_ct_uchar_mask_of_range(63, 63, value) & '/'; | 
|  | 360 | return digit; | 
| Gabor Mezei | 9a4074a | 2021-11-15 16:18:54 +0100 | [diff] [blame] | 361 | } | 
|  | 362 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 363 | signed char mbedtls_ct_base64_dec_value(unsigned char c) | 
| Gabor Mezei | 358829a | 2021-11-15 16:22:37 +0100 | [diff] [blame] | 364 | { | 
|  | 365 | unsigned char val = 0; | 
|  | 366 | /* For each range of digits, if c is in that range, mask val with | 
|  | 367 | * the corresponding value. Since c can only be in a single range, | 
|  | 368 | * only at most one masking will change val. Set val to one plus | 
|  | 369 | * the desired value so that it stays 0 if c is in none of the ranges. */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 370 | val |= mbedtls_ct_uchar_mask_of_range('A', 'Z', c) & (c - 'A' +  0 + 1); | 
|  | 371 | val |= mbedtls_ct_uchar_mask_of_range('a', 'z', c) & (c - 'a' + 26 + 1); | 
|  | 372 | val |= mbedtls_ct_uchar_mask_of_range('0', '9', c) & (c - '0' + 52 + 1); | 
|  | 373 | val |= mbedtls_ct_uchar_mask_of_range('+', '+', c) & (c - '+' + 62 + 1); | 
|  | 374 | val |= mbedtls_ct_uchar_mask_of_range('/', '/', c) & (c - '/' + 63 + 1); | 
| Gabor Mezei | 358829a | 2021-11-15 16:22:37 +0100 | [diff] [blame] | 375 | /* At this point, val is 0 if c is an invalid digit and v+1 if c is | 
|  | 376 | * a digit with the value v. */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 377 | return val - 1; | 
| Gabor Mezei | 358829a | 2021-11-15 16:22:37 +0100 | [diff] [blame] | 378 | } | 
|  | 379 |  | 
| Gabor Mezei | 9a4074a | 2021-11-15 16:18:54 +0100 | [diff] [blame] | 380 | #endif /* MBEDTLS_BASE64_C */ | 
|  | 381 |  | 
| Gabor Mezei | e212379 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 382 | #if defined(MBEDTLS_PKCS1_V15) && defined(MBEDTLS_RSA_C) && !defined(MBEDTLS_RSA_ALT) | 
|  | 383 |  | 
| Gabor Mezei | a2d0f90 | 2021-10-18 16:35:23 +0200 | [diff] [blame] | 384 | /** Shift some data towards the left inside a buffer. | 
|  | 385 | * | 
| Gabor Mezei | 90437e3 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 386 | * `mbedtls_ct_mem_move_to_left(start, total, offset)` is functionally | 
| Gabor Mezei | a2d0f90 | 2021-10-18 16:35:23 +0200 | [diff] [blame] | 387 | * equivalent to | 
|  | 388 | * ``` | 
|  | 389 | * memmove(start, start + offset, total - offset); | 
|  | 390 | * memset(start + offset, 0, total - offset); | 
|  | 391 | * ``` | 
|  | 392 | * but it strives to use a memory access pattern (and thus total timing) | 
|  | 393 | * that does not depend on \p offset. This timing independence comes at | 
|  | 394 | * the expense of performance. | 
|  | 395 | * | 
|  | 396 | * \param start     Pointer to the start of the buffer. | 
|  | 397 | * \param total     Total size of the buffer. | 
|  | 398 | * \param offset    Offset from which to copy \p total - \p offset bytes. | 
|  | 399 | */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 400 | static void mbedtls_ct_mem_move_to_left(void *start, | 
|  | 401 | size_t total, | 
|  | 402 | size_t offset) | 
| gabor-mezei-arm | 394aeaa | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 403 | { | 
|  | 404 | volatile unsigned char *buf = start; | 
|  | 405 | size_t i, n; | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 406 | if (total == 0) { | 
| gabor-mezei-arm | 394aeaa | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 407 | return; | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 408 | } | 
|  | 409 | for (i = 0; i < total; i++) { | 
|  | 410 | unsigned no_op = mbedtls_ct_size_gt(total - offset, i); | 
| gabor-mezei-arm | 394aeaa | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 411 | /* The first `total - offset` passes are a no-op. The last | 
|  | 412 | * `offset` passes shift the data one byte to the left and | 
|  | 413 | * zero out the last byte. */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 414 | for (n = 0; n < total - 1; n++) { | 
| gabor-mezei-arm | 394aeaa | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 415 | unsigned char current = buf[n]; | 
|  | 416 | unsigned char next = buf[n+1]; | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 417 | buf[n] = mbedtls_ct_uint_if(no_op, current, next); | 
| gabor-mezei-arm | 394aeaa | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 418 | } | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 419 | buf[total-1] = mbedtls_ct_uint_if(no_op, buf[total-1], 0); | 
| gabor-mezei-arm | 394aeaa | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 420 | } | 
|  | 421 | } | 
| gabor-mezei-arm | dee0fd3 | 2021-09-27 13:34:25 +0200 | [diff] [blame] | 422 |  | 
| Gabor Mezei | e212379 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 423 | #endif /* MBEDTLS_PKCS1_V15 && MBEDTLS_RSA_C && ! MBEDTLS_RSA_ALT */ | 
|  | 424 |  | 
| Przemek Stekiel | 89ad623 | 2022-09-27 13:36:12 +0200 | [diff] [blame] | 425 | #if defined(MBEDTLS_SSL_SOME_SUITES_USE_MAC) | 
| Gabor Mezei | e212379 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 426 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 427 | void mbedtls_ct_memcpy_if_eq(unsigned char *dest, | 
|  | 428 | const unsigned char *src, | 
|  | 429 | size_t len, | 
|  | 430 | size_t c1, | 
|  | 431 | size_t c2) | 
| gabor-mezei-arm | dee0fd3 | 2021-09-27 13:34:25 +0200 | [diff] [blame] | 432 | { | 
|  | 433 | /* mask = c1 == c2 ? 0xff : 0x00 */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 434 | const size_t equal = mbedtls_ct_size_bool_eq(c1, c2); | 
| gabor-mezei-arm | dee0fd3 | 2021-09-27 13:34:25 +0200 | [diff] [blame] | 435 |  | 
| gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 436 | /* dest[i] = c1 == c2 ? src[i] : dest[i] */ | 
| Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 437 | size_t i = 0; | 
|  | 438 | #if defined(MBEDTLS_EFFICIENT_UNALIGNED_ACCESS) | 
|  | 439 | const uint32_t mask32 = (uint32_t) mbedtls_ct_size_mask(equal); | 
|  | 440 | const unsigned char mask = (unsigned char) mask32 & 0xff; | 
|  | 441 |  | 
|  | 442 | for (; (i + 4) <= len; i += 4) { | 
|  | 443 | uint32_t a = mbedtls_get_unaligned_uint32(src  + i) &  mask32; | 
|  | 444 | uint32_t b = mbedtls_get_unaligned_uint32(dest + i) & ~mask32; | 
|  | 445 | mbedtls_put_unaligned_uint32(dest + i, a | b); | 
|  | 446 | } | 
|  | 447 | #else | 
|  | 448 | const unsigned char mask = (unsigned char) mbedtls_ct_size_mask(equal); | 
|  | 449 | #endif /* MBEDTLS_EFFICIENT_UNALIGNED_ACCESS */ | 
|  | 450 | for (; i < len; i++) { | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 451 | dest[i] = (src[i] & mask) | (dest[i] & ~mask); | 
|  | 452 | } | 
| gabor-mezei-arm | dee0fd3 | 2021-09-27 13:34:25 +0200 | [diff] [blame] | 453 | } | 
| gabor-mezei-arm | 0e7f71e | 2021-09-27 13:57:45 +0200 | [diff] [blame] | 454 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 455 | void mbedtls_ct_memcpy_offset(unsigned char *dest, | 
|  | 456 | const unsigned char *src, | 
|  | 457 | size_t offset, | 
|  | 458 | size_t offset_min, | 
|  | 459 | size_t offset_max, | 
|  | 460 | size_t len) | 
| gabor-mezei-arm | 0e7f71e | 2021-09-27 13:57:45 +0200 | [diff] [blame] | 461 | { | 
| Gabor Mezei | 63bbba5 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 462 | size_t offsetval; | 
| gabor-mezei-arm | 0e7f71e | 2021-09-27 13:57:45 +0200 | [diff] [blame] | 463 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 464 | for (offsetval = offset_min; offsetval <= offset_max; offsetval++) { | 
|  | 465 | mbedtls_ct_memcpy_if_eq(dest, src + offsetval, len, | 
|  | 466 | offsetval, offset); | 
| gabor-mezei-arm | 0e7f71e | 2021-09-27 13:57:45 +0200 | [diff] [blame] | 467 | } | 
|  | 468 | } | 
| gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 469 |  | 
| Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 470 | #if defined(MBEDTLS_USE_PSA_CRYPTO) | 
| Neil Armstrong | 36cc13b | 2022-03-17 16:36:52 +0100 | [diff] [blame] | 471 |  | 
|  | 472 | #if defined(PSA_WANT_ALG_SHA_384) | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 473 | #define MAX_HASH_BLOCK_LENGTH PSA_HASH_BLOCK_LENGTH(PSA_ALG_SHA_384) | 
| Neil Armstrong | 36cc13b | 2022-03-17 16:36:52 +0100 | [diff] [blame] | 474 | #elif defined(PSA_WANT_ALG_SHA_256) | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 475 | #define MAX_HASH_BLOCK_LENGTH PSA_HASH_BLOCK_LENGTH(PSA_ALG_SHA_256) | 
| Neil Armstrong | 36cc13b | 2022-03-17 16:36:52 +0100 | [diff] [blame] | 476 | #else /* See check_config.h */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 477 | #define MAX_HASH_BLOCK_LENGTH PSA_HASH_BLOCK_LENGTH(PSA_ALG_SHA_1) | 
| Neil Armstrong | 36cc13b | 2022-03-17 16:36:52 +0100 | [diff] [blame] | 478 | #endif | 
|  | 479 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 480 | int mbedtls_ct_hmac(mbedtls_svc_key_id_t key, | 
|  | 481 | psa_algorithm_t mac_alg, | 
|  | 482 | const unsigned char *add_data, | 
|  | 483 | size_t add_data_len, | 
|  | 484 | const unsigned char *data, | 
|  | 485 | size_t data_len_secret, | 
|  | 486 | size_t min_data_len, | 
|  | 487 | size_t max_data_len, | 
|  | 488 | unsigned char *output) | 
| Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 489 | { | 
|  | 490 | /* | 
| Neil Armstrong | 28d9c63 | 2022-03-17 16:33:27 +0100 | [diff] [blame] | 491 | * This function breaks the HMAC abstraction and uses psa_hash_clone() | 
|  | 492 | * extension in order to get constant-flow behaviour. | 
| Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 493 | * | 
|  | 494 | * HMAC(msg) is defined as HASH(okey + HASH(ikey + msg)) where + means | 
|  | 495 | * concatenation, and okey/ikey are the XOR of the key with some fixed bit | 
|  | 496 | * patterns (see RFC 2104, sec. 2). | 
|  | 497 | * | 
|  | 498 | * We'll first compute ikey/okey, then inner_hash = HASH(ikey + msg) by | 
|  | 499 | * hashing up to minlen, then cloning the context, and for each byte up | 
|  | 500 | * to maxlen finishing up the hash computation, keeping only the | 
|  | 501 | * correct result. | 
|  | 502 | * | 
|  | 503 | * Then we only need to compute HASH(okey + inner_hash) and we're done. | 
|  | 504 | */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 505 | psa_algorithm_t hash_alg = PSA_ALG_HMAC_GET_HASH(mac_alg); | 
|  | 506 | const size_t block_size = PSA_HASH_BLOCK_LENGTH(hash_alg); | 
| Neil Armstrong | 9ebb9ff | 2022-03-17 17:04:37 +0100 | [diff] [blame] | 507 | unsigned char key_buf[MAX_HASH_BLOCK_LENGTH]; | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 508 | const size_t hash_size = PSA_HASH_LENGTH(hash_alg); | 
| Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 509 | psa_hash_operation_t operation = PSA_HASH_OPERATION_INIT; | 
|  | 510 | size_t hash_length; | 
|  | 511 |  | 
| Neil Armstrong | 36cc13b | 2022-03-17 16:36:52 +0100 | [diff] [blame] | 512 | unsigned char aux_out[PSA_HASH_MAX_SIZE]; | 
| Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 513 | psa_hash_operation_t aux_operation = PSA_HASH_OPERATION_INIT; | 
|  | 514 | size_t offset; | 
|  | 515 | psa_status_t status = PSA_ERROR_CORRUPTION_DETECTED; | 
|  | 516 |  | 
| Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 517 | size_t mac_key_length; | 
|  | 518 | size_t i; | 
|  | 519 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 520 | #define PSA_CHK(func_call)        \ | 
| Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 521 | do {                            \ | 
|  | 522 | status = (func_call);       \ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 523 | if (status != PSA_SUCCESS) \ | 
|  | 524 | goto cleanup;           \ | 
|  | 525 | } while (0) | 
| Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 526 |  | 
| Neil Armstrong | 72c2f76 | 2022-03-17 16:39:10 +0100 | [diff] [blame] | 527 | /* Export MAC key | 
|  | 528 | * We assume key length is always exactly the output size | 
|  | 529 | * which is never more than the block size, thus we use block_size | 
|  | 530 | * as the key buffer size. | 
|  | 531 | */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 532 | PSA_CHK(psa_export_key(key, key_buf, block_size, &mac_key_length)); | 
| Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 533 |  | 
| Neil Armstrong | 9ebb9ff | 2022-03-17 17:04:37 +0100 | [diff] [blame] | 534 | /* Calculate ikey */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 535 | for (i = 0; i < mac_key_length; i++) { | 
|  | 536 | key_buf[i] = (unsigned char) (key_buf[i] ^ 0x36); | 
|  | 537 | } | 
|  | 538 | for (; i < block_size; ++i) { | 
| Neil Armstrong | 9ebb9ff | 2022-03-17 17:04:37 +0100 | [diff] [blame] | 539 | key_buf[i] = 0x36; | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 540 | } | 
| Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 541 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 542 | PSA_CHK(psa_hash_setup(&operation, hash_alg)); | 
| Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 543 |  | 
|  | 544 | /* Now compute inner_hash = HASH(ikey + msg) */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 545 | PSA_CHK(psa_hash_update(&operation, key_buf, block_size)); | 
|  | 546 | PSA_CHK(psa_hash_update(&operation, add_data, add_data_len)); | 
|  | 547 | PSA_CHK(psa_hash_update(&operation, data, min_data_len)); | 
| Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 548 |  | 
| Paul Elliott | 5260ce2 | 2022-05-09 18:15:54 +0100 | [diff] [blame] | 549 | /* Fill the hash buffer in advance with something that is | 
|  | 550 | * not a valid hash (barring an attack on the hash and | 
|  | 551 | * deliberately-crafted input), in case the caller doesn't | 
|  | 552 | * check the return status properly. */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 553 | memset(output, '!', hash_size); | 
| Paul Elliott | 5260ce2 | 2022-05-09 18:15:54 +0100 | [diff] [blame] | 554 |  | 
| Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 555 | /* For each possible length, compute the hash up to that point */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 556 | for (offset = min_data_len; offset <= max_data_len; offset++) { | 
|  | 557 | PSA_CHK(psa_hash_clone(&operation, &aux_operation)); | 
|  | 558 | PSA_CHK(psa_hash_finish(&aux_operation, aux_out, | 
|  | 559 | PSA_HASH_MAX_SIZE, &hash_length)); | 
| Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 560 | /* Keep only the correct inner_hash in the output buffer */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 561 | mbedtls_ct_memcpy_if_eq(output, aux_out, hash_size, | 
|  | 562 | offset, data_len_secret); | 
| Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 563 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 564 | if (offset < max_data_len) { | 
|  | 565 | PSA_CHK(psa_hash_update(&operation, data + offset, 1)); | 
|  | 566 | } | 
| Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 567 | } | 
|  | 568 |  | 
| Neil Armstrong | 28d9c63 | 2022-03-17 16:33:27 +0100 | [diff] [blame] | 569 | /* Abort current operation to prepare for final operation */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 570 | PSA_CHK(psa_hash_abort(&operation)); | 
| Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 571 |  | 
| Neil Armstrong | 9ebb9ff | 2022-03-17 17:04:37 +0100 | [diff] [blame] | 572 | /* Calculate okey */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 573 | for (i = 0; i < mac_key_length; i++) { | 
|  | 574 | key_buf[i] = (unsigned char) ((key_buf[i] ^ 0x36) ^ 0x5C); | 
|  | 575 | } | 
|  | 576 | for (; i < block_size; ++i) { | 
| Neil Armstrong | 9ebb9ff | 2022-03-17 17:04:37 +0100 | [diff] [blame] | 577 | key_buf[i] = 0x5C; | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 578 | } | 
| Neil Armstrong | 9ebb9ff | 2022-03-17 17:04:37 +0100 | [diff] [blame] | 579 |  | 
| Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 580 | /* Now compute HASH(okey + inner_hash) */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 581 | PSA_CHK(psa_hash_setup(&operation, hash_alg)); | 
|  | 582 | PSA_CHK(psa_hash_update(&operation, key_buf, block_size)); | 
|  | 583 | PSA_CHK(psa_hash_update(&operation, output, hash_size)); | 
|  | 584 | PSA_CHK(psa_hash_finish(&operation, output, hash_size, &hash_length)); | 
| Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 585 |  | 
|  | 586 | #undef PSA_CHK | 
|  | 587 |  | 
|  | 588 | cleanup: | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 589 | mbedtls_platform_zeroize(key_buf, MAX_HASH_BLOCK_LENGTH); | 
|  | 590 | mbedtls_platform_zeroize(aux_out, PSA_HASH_MAX_SIZE); | 
| Neil Armstrong | 36cc13b | 2022-03-17 16:36:52 +0100 | [diff] [blame] | 591 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 592 | psa_hash_abort(&operation); | 
|  | 593 | psa_hash_abort(&aux_operation); | 
| Andrzej Kurek | 8a045ce | 2022-12-23 11:00:06 -0500 | [diff] [blame] | 594 | return PSA_TO_MBEDTLS_ERR(status); | 
| Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 595 | } | 
| Neil Armstrong | 36cc13b | 2022-03-17 16:36:52 +0100 | [diff] [blame] | 596 |  | 
|  | 597 | #undef MAX_HASH_BLOCK_LENGTH | 
|  | 598 |  | 
| Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 599 | #else | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 600 | int mbedtls_ct_hmac(mbedtls_md_context_t *ctx, | 
|  | 601 | const unsigned char *add_data, | 
|  | 602 | size_t add_data_len, | 
|  | 603 | const unsigned char *data, | 
|  | 604 | size_t data_len_secret, | 
|  | 605 | size_t min_data_len, | 
|  | 606 | size_t max_data_len, | 
|  | 607 | unsigned char *output) | 
| gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 608 | { | 
|  | 609 | /* | 
|  | 610 | * This function breaks the HMAC abstraction and uses the md_clone() | 
|  | 611 | * extension to the MD API in order to get constant-flow behaviour. | 
|  | 612 | * | 
|  | 613 | * HMAC(msg) is defined as HASH(okey + HASH(ikey + msg)) where + means | 
|  | 614 | * concatenation, and okey/ikey are the XOR of the key with some fixed bit | 
|  | 615 | * patterns (see RFC 2104, sec. 2), which are stored in ctx->hmac_ctx. | 
|  | 616 | * | 
|  | 617 | * We'll first compute inner_hash = HASH(ikey + msg) by hashing up to | 
|  | 618 | * minlen, then cloning the context, and for each byte up to maxlen | 
|  | 619 | * finishing up the hash computation, keeping only the correct result. | 
|  | 620 | * | 
|  | 621 | * Then we only need to compute HASH(okey + inner_hash) and we're done. | 
|  | 622 | */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 623 | const mbedtls_md_type_t md_alg = mbedtls_md_get_type(ctx->md_info); | 
| gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 624 | /* TLS 1.2 only supports SHA-384, SHA-256, SHA-1, MD-5, | 
|  | 625 | * all of which have the same block size except SHA-384. */ | 
|  | 626 | const size_t block_size = md_alg == MBEDTLS_MD_SHA384 ? 128 : 64; | 
|  | 627 | const unsigned char * const ikey = ctx->hmac_ctx; | 
|  | 628 | const unsigned char * const okey = ikey + block_size; | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 629 | const size_t hash_size = mbedtls_md_get_size(ctx->md_info); | 
| gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 630 |  | 
|  | 631 | unsigned char aux_out[MBEDTLS_MD_MAX_SIZE]; | 
|  | 632 | mbedtls_md_context_t aux; | 
|  | 633 | size_t offset; | 
|  | 634 | int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED; | 
|  | 635 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 636 | mbedtls_md_init(&aux); | 
| gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 637 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 638 | #define MD_CHK(func_call) \ | 
| gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 639 | do {                    \ | 
|  | 640 | ret = (func_call);  \ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 641 | if (ret != 0)      \ | 
|  | 642 | goto cleanup;   \ | 
|  | 643 | } while (0) | 
| gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 644 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 645 | MD_CHK(mbedtls_md_setup(&aux, ctx->md_info, 0)); | 
| gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 646 |  | 
|  | 647 | /* After hmac_start() of hmac_reset(), ikey has already been hashed, | 
|  | 648 | * so we can start directly with the message */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 649 | MD_CHK(mbedtls_md_update(ctx, add_data, add_data_len)); | 
|  | 650 | MD_CHK(mbedtls_md_update(ctx, data, min_data_len)); | 
| gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 651 |  | 
| Paul Elliott | 5260ce2 | 2022-05-09 18:15:54 +0100 | [diff] [blame] | 652 | /* Fill the hash buffer in advance with something that is | 
|  | 653 | * not a valid hash (barring an attack on the hash and | 
|  | 654 | * deliberately-crafted input), in case the caller doesn't | 
|  | 655 | * check the return status properly. */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 656 | memset(output, '!', hash_size); | 
| Paul Elliott | 5260ce2 | 2022-05-09 18:15:54 +0100 | [diff] [blame] | 657 |  | 
| gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 658 | /* For each possible length, compute the hash up to that point */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 659 | for (offset = min_data_len; offset <= max_data_len; offset++) { | 
|  | 660 | MD_CHK(mbedtls_md_clone(&aux, ctx)); | 
|  | 661 | MD_CHK(mbedtls_md_finish(&aux, aux_out)); | 
| gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 662 | /* Keep only the correct inner_hash in the output buffer */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 663 | mbedtls_ct_memcpy_if_eq(output, aux_out, hash_size, | 
|  | 664 | offset, data_len_secret); | 
| gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 665 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 666 | if (offset < max_data_len) { | 
|  | 667 | MD_CHK(mbedtls_md_update(ctx, data + offset, 1)); | 
|  | 668 | } | 
| gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 669 | } | 
|  | 670 |  | 
|  | 671 | /* The context needs to finish() before it starts() again */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 672 | MD_CHK(mbedtls_md_finish(ctx, aux_out)); | 
| gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 673 |  | 
|  | 674 | /* Now compute HASH(okey + inner_hash) */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 675 | MD_CHK(mbedtls_md_starts(ctx)); | 
|  | 676 | MD_CHK(mbedtls_md_update(ctx, okey, block_size)); | 
|  | 677 | MD_CHK(mbedtls_md_update(ctx, output, hash_size)); | 
|  | 678 | MD_CHK(mbedtls_md_finish(ctx, output)); | 
| gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 679 |  | 
|  | 680 | /* Done, get ready for next time */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 681 | MD_CHK(mbedtls_md_hmac_reset(ctx)); | 
| gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 682 |  | 
|  | 683 | #undef MD_CHK | 
|  | 684 |  | 
|  | 685 | cleanup: | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 686 | mbedtls_md_free(&aux); | 
|  | 687 | return ret; | 
| gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 688 | } | 
| Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 689 | #endif /* MBEDTLS_USE_PSA_CRYPTO */ | 
| gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 690 |  | 
| Przemek Stekiel | 89ad623 | 2022-09-27 13:36:12 +0200 | [diff] [blame] | 691 | #endif /* MBEDTLS_SSL_SOME_SUITES_USE_MAC */ | 
| gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 692 |  | 
|  | 693 | #if defined(MBEDTLS_BIGNUM_C) | 
|  | 694 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 695 | #define MPI_VALIDATE_RET(cond)                                       \ | 
|  | 696 | MBEDTLS_INTERNAL_VALIDATE_RET(cond, MBEDTLS_ERR_MPI_BAD_INPUT_DATA) | 
| gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 697 |  | 
|  | 698 | /* | 
|  | 699 | * Conditionally assign X = Y, without leaking information | 
|  | 700 | * about whether the assignment was made or not. | 
|  | 701 | * (Leaking information about the respective sizes of X and Y is ok however.) | 
|  | 702 | */ | 
| Tautvydas Žilys | 40fc7da | 2022-01-31 13:34:01 -0800 | [diff] [blame] | 703 | #if defined(_MSC_VER) && defined(_M_ARM64) && (_MSC_FULL_VER < 193131103) | 
| Tautvydas Žilys | 60165d7 | 2022-01-26 15:33:27 -0800 | [diff] [blame] | 704 | /* | 
| Tautvydas Žilys | 40fc7da | 2022-01-31 13:34:01 -0800 | [diff] [blame] | 705 | * MSVC miscompiles this function if it's inlined prior to Visual Studio 2022 version 17.1. See: | 
| Tautvydas Žilys | 60165d7 | 2022-01-26 15:33:27 -0800 | [diff] [blame] | 706 | * https://developercommunity.visualstudio.com/t/c-compiler-miscompiles-part-of-mbedtls-library-on/1646989 | 
|  | 707 | */ | 
|  | 708 | __declspec(noinline) | 
|  | 709 | #endif | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 710 | int mbedtls_mpi_safe_cond_assign(mbedtls_mpi *X, | 
|  | 711 | const mbedtls_mpi *Y, | 
|  | 712 | unsigned char assign) | 
| gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 713 | { | 
|  | 714 | int ret = 0; | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 715 | MPI_VALIDATE_RET(X != NULL); | 
|  | 716 | MPI_VALIDATE_RET(Y != NULL); | 
| gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 717 |  | 
| gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 718 | /* all-bits 1 if assign is 1, all-bits 0 if assign is 0 */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 719 | mbedtls_mpi_uint limb_mask = mbedtls_ct_mpi_uint_mask(assign); | 
| gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 720 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 721 | MBEDTLS_MPI_CHK(mbedtls_mpi_grow(X, Y->n)); | 
| gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 722 |  | 
| Tom Cosgrove | e22413c | 2023-05-03 09:44:01 +0100 | [diff] [blame] | 723 | X->s = (int) mbedtls_ct_uint_if(assign, Y->s, X->s); | 
| gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 724 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 725 | mbedtls_mpi_core_cond_assign(X->p, Y->p, Y->n, assign); | 
| gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 726 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 727 | for (size_t i = Y->n; i < X->n; i++) { | 
| gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 728 | X->p[i] &= ~limb_mask; | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 729 | } | 
| gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 730 |  | 
|  | 731 | cleanup: | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 732 | return ret; | 
| gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 733 | } | 
|  | 734 |  | 
| gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 735 | /* | 
|  | 736 | * Conditionally swap X and Y, without leaking information | 
|  | 737 | * about whether the swap was made or not. | 
| Shaun Case | 8b0ecbc | 2021-12-20 21:14:10 -0800 | [diff] [blame] | 738 | * Here it is not ok to simply swap the pointers, which would lead to | 
| gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 739 | * different memory access patterns when X and Y are used afterwards. | 
|  | 740 | */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 741 | int mbedtls_mpi_safe_cond_swap(mbedtls_mpi *X, | 
|  | 742 | mbedtls_mpi *Y, | 
|  | 743 | unsigned char swap) | 
| gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 744 | { | 
| Gabor Mezei | d7edb1d | 2022-10-10 14:32:09 +0200 | [diff] [blame] | 745 | int ret = 0; | 
|  | 746 | int s; | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 747 | MPI_VALIDATE_RET(X != NULL); | 
|  | 748 | MPI_VALIDATE_RET(Y != NULL); | 
| gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 749 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 750 | if (X == Y) { | 
|  | 751 | return 0; | 
|  | 752 | } | 
| gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 753 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 754 | MBEDTLS_MPI_CHK(mbedtls_mpi_grow(X, Y->n)); | 
|  | 755 | MBEDTLS_MPI_CHK(mbedtls_mpi_grow(Y, X->n)); | 
| gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 756 |  | 
|  | 757 | s = X->s; | 
| Tom Cosgrove | e22413c | 2023-05-03 09:44:01 +0100 | [diff] [blame] | 758 | X->s = (int) mbedtls_ct_uint_if(swap, Y->s, X->s); | 
|  | 759 | Y->s = (int) mbedtls_ct_uint_if(swap, s, Y->s); | 
| gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 760 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 761 | mbedtls_mpi_core_cond_swap(X->p, Y->p, X->n, swap); | 
| gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 762 |  | 
|  | 763 | cleanup: | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 764 | return ret; | 
| gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 765 | } | 
|  | 766 |  | 
| gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 767 | /* | 
| Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 768 | * Compare unsigned values in constant time | 
|  | 769 | */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 770 | unsigned mbedtls_mpi_core_lt_ct(const mbedtls_mpi_uint *A, | 
|  | 771 | const mbedtls_mpi_uint *B, | 
|  | 772 | size_t limbs) | 
| Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 773 | { | 
| Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 774 | unsigned ret, cond, done; | 
|  | 775 |  | 
| Janos Follath | 6318468 | 2022-08-11 17:42:59 +0100 | [diff] [blame] | 776 | /* The value of any of these variables is either 0 or 1 for the rest of | 
|  | 777 | * their scope. */ | 
| Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 778 | ret = cond = done = 0; | 
|  | 779 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 780 | for (size_t i = limbs; i > 0; i--) { | 
| Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 781 | /* | 
| Janos Follath | b7a88ec | 2022-08-19 12:24:40 +0100 | [diff] [blame] | 782 | * If B[i - 1] < A[i - 1] then A < B is false and the result must | 
| Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 783 | * remain 0. | 
|  | 784 | * | 
|  | 785 | * Again even if we can make a decision, we just mark the result and | 
|  | 786 | * the fact that we are done and continue looping. | 
|  | 787 | */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 788 | cond = mbedtls_ct_mpi_uint_lt(B[i - 1], A[i - 1]); | 
| Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 789 | done |= cond; | 
|  | 790 |  | 
|  | 791 | /* | 
| Janos Follath | b7a88ec | 2022-08-19 12:24:40 +0100 | [diff] [blame] | 792 | * If A[i - 1] < B[i - 1] then A < B is true. | 
| Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 793 | * | 
|  | 794 | * Again even if we can make a decision, we just mark the result and | 
|  | 795 | * the fact that we are done and continue looping. | 
|  | 796 | */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 797 | cond = mbedtls_ct_mpi_uint_lt(A[i - 1], B[i - 1]); | 
|  | 798 | ret |= cond & (1 - done); | 
| Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 799 | done |= cond; | 
|  | 800 | } | 
|  | 801 |  | 
|  | 802 | /* | 
| Janos Follath | b7a88ec | 2022-08-19 12:24:40 +0100 | [diff] [blame] | 803 | * If all the limbs were equal, then the numbers are equal, A < B is false | 
| Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 804 | * and leaving the result 0 is correct. | 
|  | 805 | */ | 
|  | 806 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 807 | return ret; | 
| Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 808 | } | 
|  | 809 |  | 
|  | 810 | /* | 
| gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 811 | * Compare signed values in constant time | 
|  | 812 | */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 813 | int mbedtls_mpi_lt_mpi_ct(const mbedtls_mpi *X, | 
|  | 814 | const mbedtls_mpi *Y, | 
|  | 815 | unsigned *ret) | 
| gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 816 | { | 
|  | 817 | size_t i; | 
|  | 818 | /* The value of any of these variables is either 0 or 1 at all times. */ | 
|  | 819 | unsigned cond, done, X_is_negative, Y_is_negative; | 
|  | 820 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 821 | MPI_VALIDATE_RET(X != NULL); | 
|  | 822 | MPI_VALIDATE_RET(Y != NULL); | 
|  | 823 | MPI_VALIDATE_RET(ret != NULL); | 
| gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 824 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 825 | if (X->n != Y->n) { | 
| gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 826 | return MBEDTLS_ERR_MPI_BAD_INPUT_DATA; | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 827 | } | 
| gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 828 |  | 
|  | 829 | /* | 
|  | 830 | * Set sign_N to 1 if N >= 0, 0 if N < 0. | 
|  | 831 | * We know that N->s == 1 if N >= 0 and N->s == -1 if N < 0. | 
|  | 832 | */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 833 | X_is_negative = (X->s & 2) >> 1; | 
|  | 834 | Y_is_negative = (Y->s & 2) >> 1; | 
| gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 835 |  | 
|  | 836 | /* | 
|  | 837 | * If the signs are different, then the positive operand is the bigger. | 
|  | 838 | * That is if X is negative (X_is_negative == 1), then X < Y is true and it | 
|  | 839 | * is false if X is positive (X_is_negative == 0). | 
|  | 840 | */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 841 | cond = (X_is_negative ^ Y_is_negative); | 
| gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 842 | *ret = cond & X_is_negative; | 
|  | 843 |  | 
|  | 844 | /* | 
|  | 845 | * This is a constant-time function. We might have the result, but we still | 
|  | 846 | * need to go through the loop. Record if we have the result already. | 
|  | 847 | */ | 
|  | 848 | done = cond; | 
|  | 849 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 850 | for (i = X->n; i > 0; i--) { | 
| gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 851 | /* | 
|  | 852 | * If Y->p[i - 1] < X->p[i - 1] then X < Y is true if and only if both | 
|  | 853 | * X and Y are negative. | 
|  | 854 | * | 
|  | 855 | * Again even if we can make a decision, we just mark the result and | 
|  | 856 | * the fact that we are done and continue looping. | 
|  | 857 | */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 858 | cond = mbedtls_ct_mpi_uint_lt(Y->p[i - 1], X->p[i - 1]); | 
|  | 859 | *ret |= cond & (1 - done) & X_is_negative; | 
| gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 860 | done |= cond; | 
|  | 861 |  | 
|  | 862 | /* | 
|  | 863 | * If X->p[i - 1] < Y->p[i - 1] then X < Y is true if and only if both | 
|  | 864 | * X and Y are positive. | 
|  | 865 | * | 
|  | 866 | * Again even if we can make a decision, we just mark the result and | 
|  | 867 | * the fact that we are done and continue looping. | 
|  | 868 | */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 869 | cond = mbedtls_ct_mpi_uint_lt(X->p[i - 1], Y->p[i - 1]); | 
|  | 870 | *ret |= cond & (1 - done) & (1 - X_is_negative); | 
| gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 871 | done |= cond; | 
|  | 872 | } | 
|  | 873 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 874 | return 0; | 
| gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 875 | } | 
|  | 876 |  | 
| gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 877 | #endif /* MBEDTLS_BIGNUM_C */ | 
| gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 878 |  | 
|  | 879 | #if defined(MBEDTLS_PKCS1_V15) && defined(MBEDTLS_RSA_C) && !defined(MBEDTLS_RSA_ALT) | 
|  | 880 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 881 | int mbedtls_ct_rsaes_pkcs1_v15_unpadding(unsigned char *input, | 
|  | 882 | size_t ilen, | 
|  | 883 | unsigned char *output, | 
|  | 884 | size_t output_max_len, | 
|  | 885 | size_t *olen) | 
| gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 886 | { | 
|  | 887 | int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED; | 
|  | 888 | size_t i, plaintext_max_size; | 
|  | 889 |  | 
|  | 890 | /* The following variables take sensitive values: their value must | 
|  | 891 | * not leak into the observable behavior of the function other than | 
|  | 892 | * the designated outputs (output, olen, return value). Otherwise | 
|  | 893 | * this would open the execution of the function to | 
|  | 894 | * side-channel-based variants of the Bleichenbacher padding oracle | 
|  | 895 | * attack. Potential side channels include overall timing, memory | 
|  | 896 | * access patterns (especially visible to an adversary who has access | 
|  | 897 | * to a shared memory cache), and branches (especially visible to | 
|  | 898 | * an adversary who has access to a shared code cache or to a shared | 
|  | 899 | * branch predictor). */ | 
|  | 900 | size_t pad_count = 0; | 
|  | 901 | unsigned bad = 0; | 
|  | 902 | unsigned char pad_done = 0; | 
|  | 903 | size_t plaintext_size = 0; | 
|  | 904 | unsigned output_too_large; | 
|  | 905 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 906 | plaintext_max_size = (output_max_len > ilen - 11) ? ilen - 11 | 
| Gabor Mezei | 7013f62 | 2021-10-18 16:12:45 +0200 | [diff] [blame] | 907 | : output_max_len; | 
| gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 908 |  | 
|  | 909 | /* Check and get padding length in constant time and constant | 
|  | 910 | * memory trace. The first byte must be 0. */ | 
| Gabor Mezei | 63bbba5 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 911 | bad |= input[0]; | 
| gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 912 |  | 
|  | 913 |  | 
|  | 914 | /* Decode EME-PKCS1-v1_5 padding: 0x00 || 0x02 || PS || 0x00 | 
| Gabor Mezei | 63bbba5 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 915 | * where PS must be at least 8 nonzero bytes. */ | 
|  | 916 | bad |= input[1] ^ MBEDTLS_RSA_CRYPT; | 
| gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 917 |  | 
|  | 918 | /* Read the whole buffer. Set pad_done to nonzero if we find | 
| Gabor Mezei | 63bbba5 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 919 | * the 0x00 byte and remember the padding length in pad_count. */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 920 | for (i = 2; i < ilen; i++) { | 
|  | 921 | pad_done  |= ((input[i] | (unsigned char) -input[i]) >> 7) ^ 1; | 
|  | 922 | pad_count += ((pad_done | (unsigned char) -pad_done) >> 7) ^ 1; | 
| gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 923 | } | 
|  | 924 |  | 
|  | 925 |  | 
|  | 926 | /* If pad_done is still zero, there's no data, only unfinished padding. */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 927 | bad |= mbedtls_ct_uint_if(pad_done, 0, 1); | 
| gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 928 |  | 
|  | 929 | /* There must be at least 8 bytes of padding. */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 930 | bad |= mbedtls_ct_size_gt(8, pad_count); | 
| gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 931 |  | 
|  | 932 | /* If the padding is valid, set plaintext_size to the number of | 
|  | 933 | * remaining bytes after stripping the padding. If the padding | 
|  | 934 | * is invalid, avoid leaking this fact through the size of the | 
|  | 935 | * output: use the maximum message size that fits in the output | 
|  | 936 | * buffer. Do it without branches to avoid leaking the padding | 
|  | 937 | * validity through timing. RSA keys are small enough that all the | 
|  | 938 | * size_t values involved fit in unsigned int. */ | 
| Gabor Mezei | 90437e3 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 939 | plaintext_size = mbedtls_ct_uint_if( | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 940 | bad, (unsigned) plaintext_max_size, | 
|  | 941 | (unsigned) (ilen - pad_count - 3)); | 
| gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 942 |  | 
|  | 943 | /* Set output_too_large to 0 if the plaintext fits in the output | 
|  | 944 | * buffer and to 1 otherwise. */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 945 | output_too_large = mbedtls_ct_size_gt(plaintext_size, | 
|  | 946 | plaintext_max_size); | 
| gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 947 |  | 
|  | 948 | /* Set ret without branches to avoid timing attacks. Return: | 
|  | 949 | * - INVALID_PADDING if the padding is bad (bad != 0). | 
|  | 950 | * - OUTPUT_TOO_LARGE if the padding is good but the decrypted | 
|  | 951 | *   plaintext does not fit in the output buffer. | 
|  | 952 | * - 0 if the padding is correct. */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 953 | ret = -(int) mbedtls_ct_uint_if( | 
|  | 954 | bad, -MBEDTLS_ERR_RSA_INVALID_PADDING, | 
|  | 955 | mbedtls_ct_uint_if(output_too_large, | 
|  | 956 | -MBEDTLS_ERR_RSA_OUTPUT_TOO_LARGE, | 
|  | 957 | 0)); | 
| gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 958 |  | 
|  | 959 | /* If the padding is bad or the plaintext is too large, zero the | 
|  | 960 | * data that we're about to copy to the output buffer. | 
|  | 961 | * We need to copy the same amount of data | 
|  | 962 | * from the same buffer whether the padding is good or not to | 
|  | 963 | * avoid leaking the padding validity through overall timing or | 
|  | 964 | * through memory or cache access patterns. */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 965 | bad = mbedtls_ct_uint_mask(bad | output_too_large); | 
|  | 966 | for (i = 11; i < ilen; i++) { | 
| Gabor Mezei | 63bbba5 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 967 | input[i] &= ~bad; | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 968 | } | 
| gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 969 |  | 
|  | 970 | /* If the plaintext is too large, truncate it to the buffer size. | 
|  | 971 | * Copy anyway to avoid revealing the length through timing, because | 
|  | 972 | * revealing the length is as bad as revealing the padding validity | 
|  | 973 | * for a Bleichenbacher attack. */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 974 | plaintext_size = mbedtls_ct_uint_if(output_too_large, | 
|  | 975 | (unsigned) plaintext_max_size, | 
|  | 976 | (unsigned) plaintext_size); | 
| gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 977 |  | 
|  | 978 | /* Move the plaintext to the leftmost position where it can start in | 
|  | 979 | * the working buffer, i.e. make it start plaintext_max_size from | 
|  | 980 | * the end of the buffer. Do this with a memory access trace that | 
|  | 981 | * does not depend on the plaintext size. After this move, the | 
|  | 982 | * starting location of the plaintext is no longer sensitive | 
|  | 983 | * information. */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 984 | mbedtls_ct_mem_move_to_left(input + ilen - plaintext_max_size, | 
|  | 985 | plaintext_max_size, | 
|  | 986 | plaintext_max_size - plaintext_size); | 
| gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 987 |  | 
|  | 988 | /* Finally copy the decrypted plaintext plus trailing zeros into the output | 
|  | 989 | * buffer. If output_max_len is 0, then output may be an invalid pointer | 
|  | 990 | * and the result of memcpy() would be undefined; prevent undefined | 
|  | 991 | * behavior making sure to depend only on output_max_len (the size of the | 
|  | 992 | * user-provided output buffer), which is independent from plaintext | 
|  | 993 | * length, validity of padding, success of the decryption, and other | 
|  | 994 | * secrets. */ | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 995 | if (output_max_len != 0) { | 
|  | 996 | memcpy(output, input + ilen - plaintext_max_size, plaintext_max_size); | 
|  | 997 | } | 
| gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 998 |  | 
|  | 999 | /* Report the amount of data we copied to the output buffer. In case | 
|  | 1000 | * of errors (bad padding or output too large), the value of *olen | 
|  | 1001 | * when this function returns is not specified. Making it equivalent | 
|  | 1002 | * to the good case limits the risks of leaking the padding validity. */ | 
|  | 1003 | *olen = plaintext_size; | 
|  | 1004 |  | 
| Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 1005 | return ret; | 
| gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 1006 | } | 
|  | 1007 |  | 
|  | 1008 | #endif /* MBEDTLS_PKCS1_V15 && MBEDTLS_RSA_C && ! MBEDTLS_RSA_ALT */ |