Manuel Pégourié-Gonnard | e137ea6 | 2015-04-09 10:47:44 +0200 | [diff] [blame] | 1 | #!/bin/sh |
Simon Butcher | 71ebc58 | 2016-06-23 20:02:07 +0100 | [diff] [blame] | 2 | # |
Bence Szépkúti | 1e14827 | 2020-08-07 13:07:28 +0200 | [diff] [blame] | 3 | # Copyright The Mbed TLS Contributors |
Bence Szépkúti | c7da1fe | 2020-05-26 01:54:15 +0200 | [diff] [blame] | 4 | # SPDX-License-Identifier: Apache-2.0 |
| 5 | # |
| 6 | # Licensed under the Apache License, Version 2.0 (the "License"); you may |
| 7 | # not use this file except in compliance with the License. |
| 8 | # You may obtain a copy of the License at |
| 9 | # |
| 10 | # http://www.apache.org/licenses/LICENSE-2.0 |
| 11 | # |
| 12 | # Unless required by applicable law or agreed to in writing, software |
| 13 | # distributed under the License is distributed on an "AS IS" BASIS, WITHOUT |
| 14 | # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 15 | # See the License for the specific language governing permissions and |
| 16 | # limitations under the License. |
Gilles Peskine | 0c12e30 | 2019-05-22 18:22:45 +0200 | [diff] [blame] | 17 | |
Mateusz Starzyk | d30917c | 2021-08-04 11:14:25 +0200 | [diff] [blame^] | 18 | exit 0 |
| 19 | |
Manuel Pégourié-Gonnard | e137ea6 | 2015-04-09 10:47:44 +0200 | [diff] [blame] | 20 | set -eu |
| 21 | |
Gilles Peskine | 0c12e30 | 2019-05-22 18:22:45 +0200 | [diff] [blame] | 22 | if [ $# -ne 0 ] && [ "$1" = "--help" ]; then |
| 23 | cat <<EOF |
| 24 | $0 [-v] |
| 25 | This script confirms that the naming of all symbols and identifiers in mbed |
| 26 | TLS are consistent with the house style and are also self-consistent. |
| 27 | |
| 28 | -v If the script fails unexpectedly, print a command trace. |
| 29 | EOF |
| 30 | exit |
| 31 | fi |
| 32 | |
Gilles Peskine | 36428d3 | 2019-05-15 17:29:15 +0200 | [diff] [blame] | 33 | trace= |
| 34 | if [ $# -ne 0 ] && [ "$1" = "-v" ]; then |
| 35 | shift |
| 36 | trace='-x' |
| 37 | exec 2>check-names.err |
| 38 | trap 'echo "FAILED UNEXPECTEDLY, status=$?"; |
| 39 | cat check-names.err' EXIT |
| 40 | set -x |
| 41 | fi |
| 42 | |
Simon Butcher | 71ebc58 | 2016-06-23 20:02:07 +0100 | [diff] [blame] | 43 | printf "Analysing source code...\n" |
| 44 | |
Gilles Peskine | 36428d3 | 2019-05-15 17:29:15 +0200 | [diff] [blame] | 45 | sh $trace tests/scripts/list-macros.sh |
Manuel Pégourié-Gonnard | e137ea6 | 2015-04-09 10:47:44 +0200 | [diff] [blame] | 46 | tests/scripts/list-enum-consts.pl |
Gilles Peskine | 36428d3 | 2019-05-15 17:29:15 +0200 | [diff] [blame] | 47 | sh $trace tests/scripts/list-identifiers.sh |
| 48 | sh $trace tests/scripts/list-symbols.sh |
Manuel Pégourié-Gonnard | e137ea6 | 2015-04-09 10:47:44 +0200 | [diff] [blame] | 49 | |
| 50 | FAIL=0 |
| 51 | |
Simon Butcher | 71ebc58 | 2016-06-23 20:02:07 +0100 | [diff] [blame] | 52 | printf "\nExported symbols declared in header: " |
Manuel Pégourié-Gonnard | e137ea6 | 2015-04-09 10:47:44 +0200 | [diff] [blame] | 53 | UNDECLARED=$( diff exported-symbols identifiers | sed -n -e 's/^< //p' ) |
Manuel Pégourié-Gonnard | 9afdc83 | 2015-08-04 17:15:13 +0200 | [diff] [blame] | 54 | if [ "x$UNDECLARED" = "x" ]; then |
Manuel Pégourié-Gonnard | e137ea6 | 2015-04-09 10:47:44 +0200 | [diff] [blame] | 55 | echo "PASS" |
| 56 | else |
| 57 | echo "FAIL" |
| 58 | echo "$UNDECLARED" |
| 59 | FAIL=1 |
| 60 | fi |
| 61 | |
| 62 | diff macros identifiers | sed -n -e 's/< //p' > actual-macros |
| 63 | |
| 64 | for THING in actual-macros enum-consts; do |
Gilles Peskine | 231befa | 2020-08-26 20:05:11 +0200 | [diff] [blame] | 65 | printf 'Names of %s: ' "$THING" |
Manuel Pégourié-Gonnard | e137ea6 | 2015-04-09 10:47:44 +0200 | [diff] [blame] | 66 | test -r $THING |
Nir Sonnenschein | 03091d1 | 2019-01-08 18:15:50 +0200 | [diff] [blame] | 67 | BAD=$( grep -E -v '^(MBEDTLS|PSA)_[0-9A-Z_]*[0-9A-Z]$' $THING || true ) |
Unknown | 712f7a8 | 2019-08-21 03:34:00 -0400 | [diff] [blame] | 68 | UNDERSCORES=$( grep -E '.*__.*' $THING || true ) |
| 69 | |
| 70 | if [ "x$BAD" = "x" ] && [ "x$UNDERSCORES" = "x" ]; then |
Manuel Pégourié-Gonnard | e137ea6 | 2015-04-09 10:47:44 +0200 | [diff] [blame] | 71 | echo "PASS" |
| 72 | else |
| 73 | echo "FAIL" |
| 74 | echo "$BAD" |
Unknown | 712f7a8 | 2019-08-21 03:34:00 -0400 | [diff] [blame] | 75 | echo "$UNDERSCORES" |
Manuel Pégourié-Gonnard | e137ea6 | 2015-04-09 10:47:44 +0200 | [diff] [blame] | 76 | FAIL=1 |
| 77 | fi |
| 78 | done |
| 79 | |
| 80 | for THING in identifiers; do |
Gilles Peskine | 231befa | 2020-08-26 20:05:11 +0200 | [diff] [blame] | 81 | printf 'Names of %s: ' "$THING" |
Manuel Pégourié-Gonnard | e137ea6 | 2015-04-09 10:47:44 +0200 | [diff] [blame] | 82 | test -r $THING |
Gilles Peskine | 2d9d6db | 2018-06-18 23:25:28 +0200 | [diff] [blame] | 83 | BAD=$( grep -E -v '^(mbedtls|psa)_[0-9a-z_]*[0-9a-z]$' $THING || true ) |
Manuel Pégourié-Gonnard | e137ea6 | 2015-04-09 10:47:44 +0200 | [diff] [blame] | 84 | if [ "x$BAD" = "x" ]; then |
| 85 | echo "PASS" |
| 86 | else |
| 87 | echo "FAIL" |
| 88 | echo "$BAD" |
| 89 | FAIL=1 |
| 90 | fi |
| 91 | done |
| 92 | |
Manuel Pégourié-Gonnard | f9aae83 | 2015-04-09 12:20:53 +0200 | [diff] [blame] | 93 | printf "Likely typos: " |
| 94 | sort -u actual-macros enum-consts > _caps |
TRodziewicz | 26371e4 | 2021-06-08 16:45:41 +0200 | [diff] [blame] | 95 | HEADERS=$( ls include/mbedtls/*.h include/psa/*.h | egrep -v 'compat-2\.x\.h' ) |
Manuel Pégourié-Gonnard | 65a6fa3 | 2020-07-09 09:52:17 +0200 | [diff] [blame] | 96 | HEADERS="$HEADERS library/*.h" |
Christoph M. Wintersteiger | 8a0f5bb | 2018-12-14 15:46:34 +0000 | [diff] [blame] | 97 | HEADERS="$HEADERS 3rdparty/everest/include/everest/everest.h 3rdparty/everest/include/everest/x25519.h" |
Gilles Peskine | 9ab9621 | 2020-02-12 21:06:45 +0100 | [diff] [blame] | 98 | LIBRARY="$( ls library/*.c )" |
| 99 | LIBRARY="$LIBRARY 3rdparty/everest/library/everest.c 3rdparty/everest/library/x25519.c" |
Manuel Pégourié-Gonnard | f9aae83 | 2015-04-09 12:20:53 +0200 | [diff] [blame] | 100 | NL=' |
| 101 | ' |
Gilles Peskine | b683776 | 2021-04-21 18:45:08 +0200 | [diff] [blame] | 102 | cat $HEADERS $LIBRARY \ |
| 103 | | grep -v -e '//no-check-names' -e '#error' \ |
| 104 | | sed -n 's/MBED..._[A-Z0-9_]*/\'"$NL"'&\'"$NL"/gp \ |
Manuel Pégourié-Gonnard | f9aae83 | 2015-04-09 12:20:53 +0200 | [diff] [blame] | 105 | | grep MBEDTLS | sort -u > _MBEDTLS_XXX |
| 106 | TYPOS=$( diff _caps _MBEDTLS_XXX | sed -n 's/^> //p' \ |
Manuel Pégourié-Gonnard | 32da9f6 | 2015-07-31 15:52:30 +0200 | [diff] [blame] | 107 | | egrep -v 'XXX|__|_$|^MBEDTLS_.*CONFIG_FILE$' || true ) |
Manuel Pégourié-Gonnard | f9aae83 | 2015-04-09 12:20:53 +0200 | [diff] [blame] | 108 | rm _MBEDTLS_XXX _caps |
Manuel Pégourié-Gonnard | 9afdc83 | 2015-08-04 17:15:13 +0200 | [diff] [blame] | 109 | if [ "x$TYPOS" = "x" ]; then |
Manuel Pégourié-Gonnard | f9aae83 | 2015-04-09 12:20:53 +0200 | [diff] [blame] | 110 | echo "PASS" |
| 111 | else |
| 112 | echo "FAIL" |
| 113 | echo "$TYPOS" |
| 114 | FAIL=1 |
| 115 | fi |
| 116 | |
Gilles Peskine | 36428d3 | 2019-05-15 17:29:15 +0200 | [diff] [blame] | 117 | if [ -n "$trace" ]; then |
| 118 | set +x |
| 119 | trap - EXIT |
| 120 | rm check-names.err |
| 121 | fi |
| 122 | |
Simon Butcher | 71ebc58 | 2016-06-23 20:02:07 +0100 | [diff] [blame] | 123 | printf "\nOverall: " |
Manuel Pégourié-Gonnard | e137ea6 | 2015-04-09 10:47:44 +0200 | [diff] [blame] | 124 | if [ "$FAIL" -eq 0 ]; then |
| 125 | rm macros actual-macros enum-consts identifiers exported-symbols |
| 126 | echo "PASSED" |
| 127 | exit 0 |
| 128 | else |
| 129 | echo "FAILED" |
| 130 | exit 1 |
| 131 | fi |