| gabor-mezei-arm | 9055972 | 2021-07-12 16:31:22 +0200 | [diff] [blame] | 1 | /** | 
|  | 2 | *  Constant-time functions | 
|  | 3 | * | 
|  | 4 | *  Copyright The Mbed TLS Contributors | 
|  | 5 | *  SPDX-License-Identifier: Apache-2.0 | 
|  | 6 | * | 
|  | 7 | *  Licensed under the Apache License, Version 2.0 (the "License"); you may | 
|  | 8 | *  not use this file except in compliance with the License. | 
|  | 9 | *  You may obtain a copy of the License at | 
|  | 10 | * | 
|  | 11 | *  http://www.apache.org/licenses/LICENSE-2.0 | 
|  | 12 | * | 
|  | 13 | *  Unless required by applicable law or agreed to in writing, software | 
|  | 14 | *  distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | 
|  | 15 | *  WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | 
|  | 16 | *  See the License for the specific language governing permissions and | 
|  | 17 | *  limitations under the License. | 
|  | 18 | */ | 
|  | 19 |  | 
| Gabor Mezei | 3c38b6e | 2021-10-18 16:09:41 +0200 | [diff] [blame] | 20 | /* | 
| Gabor Mezei | dbe0f89 | 2021-11-03 16:13:32 +0100 | [diff] [blame] | 21 | * The following functions are implemented without using comparison operators, as those | 
| Gabor Mezei | 3c38b6e | 2021-10-18 16:09:41 +0200 | [diff] [blame] | 22 | * might be translated to branches by some compilers on some platforms. | 
|  | 23 | */ | 
|  | 24 |  | 
| gabor-mezei-arm | 9055972 | 2021-07-12 16:31:22 +0200 | [diff] [blame] | 25 | #include "common.h" | 
| Gabor Mezei | c0ae1cf | 2021-10-20 12:09:35 +0200 | [diff] [blame] | 26 | #include "constant_time_internal.h" | 
| Gabor Mezei | e24dea8 | 2021-10-19 12:22:25 +0200 | [diff] [blame] | 27 | #include "mbedtls/constant_time.h" | 
| gabor-mezei-arm | cb4317b | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 28 | #include "mbedtls/error.h" | 
| gabor-mezei-arm | d5a392a | 2021-09-29 10:50:31 +0200 | [diff] [blame] | 29 | #include "mbedtls/platform_util.h" | 
| gabor-mezei-arm | 944c107 | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 30 |  | 
| gabor-mezei-arm | 097d4f5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 31 | #if defined(MBEDTLS_BIGNUM_C) | 
|  | 32 | #include "mbedtls/bignum.h" | 
|  | 33 | #endif | 
|  | 34 |  | 
| gabor-mezei-arm | cb4317b | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 35 | #if defined(MBEDTLS_SSL_TLS_C) | 
|  | 36 | #include "mbedtls/ssl_internal.h" | 
|  | 37 | #endif | 
|  | 38 |  | 
| gabor-mezei-arm | d5a392a | 2021-09-29 10:50:31 +0200 | [diff] [blame] | 39 | #if defined(MBEDTLS_RSA_C) | 
|  | 40 | #include "mbedtls/rsa.h" | 
|  | 41 | #endif | 
|  | 42 |  | 
| Gabor Mezei | 46f79c3 | 2021-11-15 16:13:01 +0100 | [diff] [blame] | 43 | #if defined(MBEDTLS_BASE64_C) | 
|  | 44 | #include "constant_time_invasive.h" | 
|  | 45 | #endif | 
|  | 46 |  | 
| gabor-mezei-arm | f52941e | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 47 | #include <string.h> | 
| gabor-mezei-arm | 097d4f5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 48 |  | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 49 | int mbedtls_ct_memcmp( const void *a, | 
| gabor-mezei-arm | 378e7eb | 2021-07-19 15:19:19 +0200 | [diff] [blame] | 50 | const void *b, | 
|  | 51 | size_t n ) | 
| gabor-mezei-arm | 944c107 | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 52 | { | 
|  | 53 | size_t i; | 
|  | 54 | volatile const unsigned char *A = (volatile const unsigned char *) a; | 
|  | 55 | volatile const unsigned char *B = (volatile const unsigned char *) b; | 
|  | 56 | volatile unsigned char diff = 0; | 
|  | 57 |  | 
|  | 58 | for( i = 0; i < n; i++ ) | 
|  | 59 | { | 
|  | 60 | /* Read volatile data in order before computing diff. | 
|  | 61 | * This avoids IAR compiler warning: | 
|  | 62 | * 'the order of volatile accesses is undefined ..' */ | 
|  | 63 | unsigned char x = A[i], y = B[i]; | 
|  | 64 | diff |= x ^ y; | 
|  | 65 | } | 
|  | 66 |  | 
| gabor-mezei-arm | 944c107 | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 67 | return( (int)diff ); | 
|  | 68 | } | 
|  | 69 |  | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 70 | unsigned mbedtls_ct_uint_mask( unsigned value ) | 
| gabor-mezei-arm | c11cac9 | 2021-09-27 11:40:03 +0200 | [diff] [blame] | 71 | { | 
|  | 72 | /* MSVC has a warning about unary minus on unsigned, but this is | 
|  | 73 | * well-defined and precisely what we want to do here */ | 
|  | 74 | #if defined(_MSC_VER) | 
|  | 75 | #pragma warning( push ) | 
|  | 76 | #pragma warning( disable : 4146 ) | 
|  | 77 | #endif | 
|  | 78 | return( - ( ( value | - value ) >> ( sizeof( value ) * 8 - 1 ) ) ); | 
|  | 79 | #if defined(_MSC_VER) | 
|  | 80 | #pragma warning( pop ) | 
|  | 81 | #endif | 
|  | 82 | } | 
| gabor-mezei-arm | d361ccd | 2021-09-27 11:49:42 +0200 | [diff] [blame] | 83 |  | 
| Przemek Stekiel | 169554c | 2022-10-06 10:53:20 +0200 | [diff] [blame] | 84 | #if defined(MBEDTLS_SSL_SOME_MODES_USE_MAC) | 
| Gabor Mezei | 61bf64f | 2021-10-20 11:17:43 +0200 | [diff] [blame] | 85 |  | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 86 | size_t mbedtls_ct_size_mask( size_t value ) | 
| gabor-mezei-arm | d361ccd | 2021-09-27 11:49:42 +0200 | [diff] [blame] | 87 | { | 
|  | 88 | /* MSVC has a warning about unary minus on unsigned integer types, | 
|  | 89 | * but this is well-defined and precisely what we want to do here. */ | 
|  | 90 | #if defined(_MSC_VER) | 
|  | 91 | #pragma warning( push ) | 
|  | 92 | #pragma warning( disable : 4146 ) | 
|  | 93 | #endif | 
| gabor-mezei-arm | 2f2c0be | 2021-08-10 20:56:21 +0200 | [diff] [blame] | 94 | return( - ( ( value | - value ) >> ( sizeof( value ) * 8 - 1 ) ) ); | 
| gabor-mezei-arm | d361ccd | 2021-09-27 11:49:42 +0200 | [diff] [blame] | 95 | #if defined(_MSC_VER) | 
|  | 96 | #pragma warning( pop ) | 
|  | 97 | #endif | 
|  | 98 | } | 
| gabor-mezei-arm | 4d6b146 | 2021-09-27 11:53:54 +0200 | [diff] [blame] | 99 |  | 
| Przemek Stekiel | 169554c | 2022-10-06 10:53:20 +0200 | [diff] [blame] | 100 | #endif /* MBEDTLS_SSL_SOME_MODES_USE_MAC */ | 
| Gabor Mezei | 61bf64f | 2021-10-20 11:17:43 +0200 | [diff] [blame] | 101 |  | 
| gabor-mezei-arm | 60febd5 | 2021-08-11 15:07:02 +0200 | [diff] [blame] | 102 | #if defined(MBEDTLS_BIGNUM_C) | 
|  | 103 |  | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 104 | mbedtls_mpi_uint mbedtls_ct_mpi_uint_mask( mbedtls_mpi_uint value ) | 
| gabor-mezei-arm | 60febd5 | 2021-08-11 15:07:02 +0200 | [diff] [blame] | 105 | { | 
|  | 106 | /* MSVC has a warning about unary minus on unsigned, but this is | 
|  | 107 | * well-defined and precisely what we want to do here */ | 
|  | 108 | #if defined(_MSC_VER) | 
|  | 109 | #pragma warning( push ) | 
|  | 110 | #pragma warning( disable : 4146 ) | 
|  | 111 | #endif | 
|  | 112 | return( - ( ( value | - value ) >> ( sizeof( value ) * 8 - 1 ) ) ); | 
|  | 113 | #if defined(_MSC_VER) | 
|  | 114 | #pragma warning( pop ) | 
|  | 115 | #endif | 
|  | 116 | } | 
|  | 117 |  | 
|  | 118 | #endif /* MBEDTLS_BIGNUM_C */ | 
|  | 119 |  | 
| Gabor Mezei | 2b35880 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 120 | #if defined(MBEDTLS_SSL_SOME_SUITES_USE_TLS_CBC) | 
|  | 121 |  | 
| Gabor Mezei | 2c5ed22 | 2021-10-18 16:05:50 +0200 | [diff] [blame] | 122 | /** Constant-flow mask generation for "less than" comparison: | 
|  | 123 | * - if \p x < \p y, return all-bits 1, that is (size_t) -1 | 
|  | 124 | * - otherwise, return all bits 0, that is 0 | 
|  | 125 | * | 
|  | 126 | * This function can be used to write constant-time code by replacing branches | 
|  | 127 | * with bit operations using masks. | 
|  | 128 | * | 
|  | 129 | * \param x     The first value to analyze. | 
|  | 130 | * \param y     The second value to analyze. | 
|  | 131 | * | 
|  | 132 | * \return      All-bits-one if \p x is less than \p y, otherwise zero. | 
|  | 133 | */ | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 134 | static size_t mbedtls_ct_size_mask_lt( size_t x, | 
| Gabor Mezei | 2c5ed22 | 2021-10-18 16:05:50 +0200 | [diff] [blame] | 135 | size_t y ) | 
| gabor-mezei-arm | 4d6b146 | 2021-09-27 11:53:54 +0200 | [diff] [blame] | 136 | { | 
|  | 137 | /* This has the most significant bit set if and only if x < y */ | 
|  | 138 | const size_t sub = x - y; | 
|  | 139 |  | 
|  | 140 | /* sub1 = (x < y) ? 1 : 0 */ | 
|  | 141 | const size_t sub1 = sub >> ( sizeof( sub ) * 8 - 1 ); | 
|  | 142 |  | 
|  | 143 | /* mask = (x < y) ? 0xff... : 0x00... */ | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 144 | const size_t mask = mbedtls_ct_size_mask( sub1 ); | 
| gabor-mezei-arm | 4d6b146 | 2021-09-27 11:53:54 +0200 | [diff] [blame] | 145 |  | 
|  | 146 | return( mask ); | 
|  | 147 | } | 
| gabor-mezei-arm | a2bcabc | 2021-09-27 11:58:31 +0200 | [diff] [blame] | 148 |  | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 149 | size_t mbedtls_ct_size_mask_ge( size_t x, | 
| gabor-mezei-arm | 04087df | 2021-09-27 16:29:52 +0200 | [diff] [blame] | 150 | size_t y ) | 
| gabor-mezei-arm | a2bcabc | 2021-09-27 11:58:31 +0200 | [diff] [blame] | 151 | { | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 152 | return( ~mbedtls_ct_size_mask_lt( x, y ) ); | 
| gabor-mezei-arm | a2bcabc | 2021-09-27 11:58:31 +0200 | [diff] [blame] | 153 | } | 
| gabor-mezei-arm | 96584dd | 2021-09-27 12:15:19 +0200 | [diff] [blame] | 154 |  | 
| Gabor Mezei | 2b35880 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 155 | #endif /* MBEDTLS_SSL_SOME_SUITES_USE_TLS_CBC */ | 
|  | 156 |  | 
| Gabor Mezei | 46f79c3 | 2021-11-15 16:13:01 +0100 | [diff] [blame] | 157 | #if defined(MBEDTLS_BASE64_C) | 
|  | 158 |  | 
|  | 159 | /* Return 0xff if low <= c <= high, 0 otherwise. | 
|  | 160 | * | 
|  | 161 | * Constant flow with respect to c. | 
|  | 162 | */ | 
| Gabor Mezei | df29332 | 2021-11-26 17:20:36 +0100 | [diff] [blame] | 163 | MBEDTLS_STATIC_TESTABLE | 
| Gabor Mezei | 46f79c3 | 2021-11-15 16:13:01 +0100 | [diff] [blame] | 164 | unsigned char mbedtls_ct_uchar_mask_of_range( unsigned char low, | 
|  | 165 | unsigned char high, | 
|  | 166 | unsigned char c ) | 
|  | 167 | { | 
|  | 168 | /* low_mask is: 0 if low <= c, 0x...ff if low > c */ | 
|  | 169 | unsigned low_mask = ( (unsigned) c - low ) >> 8; | 
|  | 170 | /* high_mask is: 0 if c <= high, 0x...ff if c > high */ | 
|  | 171 | unsigned high_mask = ( (unsigned) high - c ) >> 8; | 
|  | 172 | return( ~( low_mask | high_mask ) & 0xff ); | 
|  | 173 | } | 
|  | 174 |  | 
|  | 175 | #endif /* MBEDTLS_BASE64_C */ | 
|  | 176 |  | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 177 | unsigned mbedtls_ct_size_bool_eq( size_t x, | 
| gabor-mezei-arm | 1ffd0cc | 2021-08-11 17:28:49 +0200 | [diff] [blame] | 178 | size_t y ) | 
| gabor-mezei-arm | 96584dd | 2021-09-27 12:15:19 +0200 | [diff] [blame] | 179 | { | 
|  | 180 | /* diff = 0 if x == y, non-zero otherwise */ | 
|  | 181 | const size_t diff = x ^ y; | 
|  | 182 |  | 
|  | 183 | /* MSVC has a warning about unary minus on unsigned integer types, | 
|  | 184 | * but this is well-defined and precisely what we want to do here. */ | 
|  | 185 | #if defined(_MSC_VER) | 
|  | 186 | #pragma warning( push ) | 
|  | 187 | #pragma warning( disable : 4146 ) | 
|  | 188 | #endif | 
|  | 189 |  | 
|  | 190 | /* diff_msb's most significant bit is equal to x != y */ | 
|  | 191 | const size_t diff_msb = ( diff | (size_t) -diff ); | 
|  | 192 |  | 
|  | 193 | #if defined(_MSC_VER) | 
|  | 194 | #pragma warning( pop ) | 
|  | 195 | #endif | 
|  | 196 |  | 
|  | 197 | /* diff1 = (x != y) ? 1 : 0 */ | 
| gabor-mezei-arm | 1ffd0cc | 2021-08-11 17:28:49 +0200 | [diff] [blame] | 198 | const unsigned diff1 = diff_msb >> ( sizeof( diff_msb ) * 8 - 1 ); | 
| gabor-mezei-arm | 96584dd | 2021-09-27 12:15:19 +0200 | [diff] [blame] | 199 |  | 
|  | 200 | return( 1 ^ diff1 ); | 
|  | 201 | } | 
| gabor-mezei-arm | 9d7bf09 | 2021-09-27 12:25:07 +0200 | [diff] [blame] | 202 |  | 
| Gabor Mezei | 2b35880 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 203 | #if defined(MBEDTLS_PKCS1_V15) && defined(MBEDTLS_RSA_C) && !defined(MBEDTLS_RSA_ALT) | 
|  | 204 |  | 
| Gabor Mezei | fd8a42d | 2021-10-18 16:35:23 +0200 | [diff] [blame] | 205 | /** Constant-flow "greater than" comparison: | 
|  | 206 | * return x > y | 
|  | 207 | * | 
|  | 208 | * This is equivalent to \p x > \p y, but is likely to be compiled | 
|  | 209 | * to code using bitwise operation rather than a branch. | 
|  | 210 | * | 
|  | 211 | * \param x     The first value to analyze. | 
|  | 212 | * \param y     The second value to analyze. | 
|  | 213 | * | 
|  | 214 | * \return      1 if \p x greater than \p y, otherwise 0. | 
|  | 215 | */ | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 216 | static unsigned mbedtls_ct_size_gt( size_t x, | 
| Gabor Mezei | fd8a42d | 2021-10-18 16:35:23 +0200 | [diff] [blame] | 217 | size_t y ) | 
| gabor-mezei-arm | 9d7bf09 | 2021-09-27 12:25:07 +0200 | [diff] [blame] | 218 | { | 
| gabor-mezei-arm | 5e48824 | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 219 | /* Return the sign bit (1 for negative) of (y - x). */ | 
|  | 220 | return( ( y - x ) >> ( sizeof( size_t ) * 8 - 1 ) ); | 
| gabor-mezei-arm | 9d7bf09 | 2021-09-27 12:25:07 +0200 | [diff] [blame] | 221 | } | 
| gabor-mezei-arm | 097d4f5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 222 |  | 
| Gabor Mezei | 2b35880 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 223 | #endif /* MBEDTLS_PKCS1_V15 && MBEDTLS_RSA_C && ! MBEDTLS_RSA_ALT */ | 
|  | 224 |  | 
| gabor-mezei-arm | 097d4f5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 225 | #if defined(MBEDTLS_BIGNUM_C) | 
|  | 226 |  | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 227 | unsigned mbedtls_ct_mpi_uint_lt( const mbedtls_mpi_uint x, | 
| gabor-mezei-arm | 04087df | 2021-09-27 16:29:52 +0200 | [diff] [blame] | 228 | const mbedtls_mpi_uint y ) | 
| gabor-mezei-arm | 097d4f5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 229 | { | 
|  | 230 | mbedtls_mpi_uint ret; | 
|  | 231 | mbedtls_mpi_uint cond; | 
|  | 232 |  | 
|  | 233 | /* | 
|  | 234 | * Check if the most significant bits (MSB) of the operands are different. | 
|  | 235 | */ | 
|  | 236 | cond = ( x ^ y ); | 
|  | 237 | /* | 
|  | 238 | * If the MSB are the same then the difference x-y will be negative (and | 
|  | 239 | * have its MSB set to 1 during conversion to unsigned) if and only if x<y. | 
|  | 240 | */ | 
|  | 241 | ret = ( x - y ) & ~cond; | 
|  | 242 | /* | 
|  | 243 | * If the MSB are different, then the operand with the MSB of 1 is the | 
|  | 244 | * bigger. (That is if y has MSB of 1, then x<y is true and it is false if | 
|  | 245 | * the MSB of y is 0.) | 
|  | 246 | */ | 
|  | 247 | ret |= y & cond; | 
|  | 248 |  | 
|  | 249 |  | 
|  | 250 | ret = ret >> ( sizeof( mbedtls_mpi_uint ) * 8 - 1 ); | 
|  | 251 |  | 
|  | 252 | return (unsigned) ret; | 
|  | 253 | } | 
|  | 254 |  | 
|  | 255 | #endif /* MBEDTLS_BIGNUM_C */ | 
| gabor-mezei-arm | 7533253 | 2021-09-27 12:59:30 +0200 | [diff] [blame] | 256 |  | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 257 | unsigned mbedtls_ct_uint_if( unsigned condition, | 
| gabor-mezei-arm | 04087df | 2021-09-27 16:29:52 +0200 | [diff] [blame] | 258 | unsigned if1, | 
|  | 259 | unsigned if0 ) | 
| gabor-mezei-arm | 7533253 | 2021-09-27 12:59:30 +0200 | [diff] [blame] | 260 | { | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 261 | unsigned mask = mbedtls_ct_uint_mask( condition ); | 
| gabor-mezei-arm | 7533253 | 2021-09-27 12:59:30 +0200 | [diff] [blame] | 262 | return( ( mask & if1 ) | (~mask & if0 ) ); | 
|  | 263 | } | 
| gabor-mezei-arm | 5cec8b4 | 2021-09-27 13:03:57 +0200 | [diff] [blame] | 264 |  | 
| Gabor Mezei | 2b35880 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 265 | #if defined(MBEDTLS_BIGNUM_C) | 
| gabor-mezei-arm | bc3a288 | 2021-09-27 15:47:00 +0200 | [diff] [blame] | 266 |  | 
| Gabor Mezei | dbe0f89 | 2021-11-03 16:13:32 +0100 | [diff] [blame] | 267 | /** Select between two sign values without branches. | 
| Gabor Mezei | fd8a42d | 2021-10-18 16:35:23 +0200 | [diff] [blame] | 268 | * | 
|  | 269 | * This is functionally equivalent to `condition ? if1 : if0` but uses only bit | 
|  | 270 | * operations in order to avoid branches. | 
|  | 271 | * | 
|  | 272 | * \note if1 and if0 must be either 1 or -1, otherwise the result | 
|  | 273 | *       is undefined. | 
|  | 274 | * | 
| Tom Cosgrove | f211d82 | 2022-08-18 14:09:18 +0100 | [diff] [blame] | 275 | * \param condition     Condition to test; must be either 0 or 1. | 
| Gabor Mezei | fd8a42d | 2021-10-18 16:35:23 +0200 | [diff] [blame] | 276 | * \param if1           The first sign; must be either +1 or -1. | 
|  | 277 | * \param if0           The second sign; must be either +1 or -1. | 
|  | 278 | * | 
|  | 279 | * \return  \c if1 if \p condition is nonzero, otherwise \c if0. | 
|  | 280 | * */ | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 281 | static int mbedtls_ct_cond_select_sign( unsigned char condition, | 
| Gabor Mezei | fd8a42d | 2021-10-18 16:35:23 +0200 | [diff] [blame] | 282 | int if1, | 
|  | 283 | int if0 ) | 
| gabor-mezei-arm | 5cec8b4 | 2021-09-27 13:03:57 +0200 | [diff] [blame] | 284 | { | 
| Gabor Mezei | dbe0f89 | 2021-11-03 16:13:32 +0100 | [diff] [blame] | 285 | /* In order to avoid questions about what we can reasonably assume about | 
| gabor-mezei-arm | 5cec8b4 | 2021-09-27 13:03:57 +0200 | [diff] [blame] | 286 | * the representations of signed integers, move everything to unsigned | 
| Gabor Mezei | 4b4e4d8 | 2021-10-18 16:28:27 +0200 | [diff] [blame] | 287 | * by taking advantage of the fact that if1 and if0 are either +1 or -1. */ | 
| gabor-mezei-arm | 5e48824 | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 288 | unsigned uif1 = if1 + 1; | 
|  | 289 | unsigned uif0 = if0 + 1; | 
| gabor-mezei-arm | 5cec8b4 | 2021-09-27 13:03:57 +0200 | [diff] [blame] | 290 |  | 
| Gabor Mezei | 4b4e4d8 | 2021-10-18 16:28:27 +0200 | [diff] [blame] | 291 | /* condition was 0 or 1, mask is 0 or 2 as are uif1 and uif0 */ | 
| gabor-mezei-arm | 5e48824 | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 292 | const unsigned mask = condition << 1; | 
| gabor-mezei-arm | 5cec8b4 | 2021-09-27 13:03:57 +0200 | [diff] [blame] | 293 |  | 
| Gabor Mezei | 4b4e4d8 | 2021-10-18 16:28:27 +0200 | [diff] [blame] | 294 | /* select uif1 or uif0 */ | 
| gabor-mezei-arm | 5e48824 | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 295 | unsigned ur = ( uif0 & ~mask ) | ( uif1 & mask ); | 
| gabor-mezei-arm | 5cec8b4 | 2021-09-27 13:03:57 +0200 | [diff] [blame] | 296 |  | 
|  | 297 | /* ur is now 0 or 2, convert back to -1 or +1 */ | 
|  | 298 | return( (int) ur - 1 ); | 
|  | 299 | } | 
| gabor-mezei-arm | 043192d | 2021-09-27 13:17:15 +0200 | [diff] [blame] | 300 |  | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 301 | void mbedtls_ct_mpi_uint_cond_assign( size_t n, | 
| gabor-mezei-arm | 043192d | 2021-09-27 13:17:15 +0200 | [diff] [blame] | 302 | mbedtls_mpi_uint *dest, | 
|  | 303 | const mbedtls_mpi_uint *src, | 
| gabor-mezei-arm | 5e48824 | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 304 | unsigned char condition ) | 
| gabor-mezei-arm | 043192d | 2021-09-27 13:17:15 +0200 | [diff] [blame] | 305 | { | 
|  | 306 | size_t i; | 
|  | 307 |  | 
|  | 308 | /* MSVC has a warning about unary minus on unsigned integer types, | 
|  | 309 | * but this is well-defined and precisely what we want to do here. */ | 
|  | 310 | #if defined(_MSC_VER) | 
|  | 311 | #pragma warning( push ) | 
|  | 312 | #pragma warning( disable : 4146 ) | 
|  | 313 | #endif | 
|  | 314 |  | 
| gabor-mezei-arm | 5e48824 | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 315 | /* all-bits 1 if condition is 1, all-bits 0 if condition is 0 */ | 
|  | 316 | const mbedtls_mpi_uint mask = -condition; | 
| gabor-mezei-arm | 043192d | 2021-09-27 13:17:15 +0200 | [diff] [blame] | 317 |  | 
|  | 318 | #if defined(_MSC_VER) | 
|  | 319 | #pragma warning( pop ) | 
|  | 320 | #endif | 
|  | 321 |  | 
|  | 322 | for( i = 0; i < n; i++ ) | 
|  | 323 | dest[i] = ( src[i] & mask ) | ( dest[i] & ~mask ); | 
|  | 324 | } | 
|  | 325 |  | 
|  | 326 | #endif /* MBEDTLS_BIGNUM_C */ | 
| gabor-mezei-arm | 7b23c0b | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 327 |  | 
| Gabor Mezei | 200708d | 2021-11-15 16:18:54 +0100 | [diff] [blame] | 328 | #if defined(MBEDTLS_BASE64_C) | 
|  | 329 |  | 
| Gabor Mezei | 46ca2f7 | 2021-11-24 15:51:39 +0100 | [diff] [blame] | 330 | unsigned char mbedtls_ct_base64_enc_char( unsigned char value ) | 
| Gabor Mezei | 200708d | 2021-11-15 16:18:54 +0100 | [diff] [blame] | 331 | { | 
|  | 332 | unsigned char digit = 0; | 
| Gabor Mezei | 46ca2f7 | 2021-11-24 15:51:39 +0100 | [diff] [blame] | 333 | /* For each range of values, if value is in that range, mask digit with | 
|  | 334 | * the corresponding value. Since value can only be in a single range, | 
| Gabor Mezei | 200708d | 2021-11-15 16:18:54 +0100 | [diff] [blame] | 335 | * only at most one masking will change digit. */ | 
| Gabor Mezei | 46ca2f7 | 2021-11-24 15:51:39 +0100 | [diff] [blame] | 336 | digit |= mbedtls_ct_uchar_mask_of_range(  0, 25, value ) & ( 'A' + value ); | 
|  | 337 | digit |= mbedtls_ct_uchar_mask_of_range( 26, 51, value ) & ( 'a' + value - 26 ); | 
|  | 338 | digit |= mbedtls_ct_uchar_mask_of_range( 52, 61, value ) & ( '0' + value - 52 ); | 
|  | 339 | digit |= mbedtls_ct_uchar_mask_of_range( 62, 62, value ) & '+'; | 
|  | 340 | digit |= mbedtls_ct_uchar_mask_of_range( 63, 63, value ) & '/'; | 
| Gabor Mezei | 200708d | 2021-11-15 16:18:54 +0100 | [diff] [blame] | 341 | return( digit ); | 
|  | 342 | } | 
|  | 343 |  | 
| Gabor Mezei | 3d4dba8 | 2021-11-15 16:22:37 +0100 | [diff] [blame] | 344 | signed char mbedtls_ct_base64_dec_value( unsigned char c ) | 
|  | 345 | { | 
|  | 346 | unsigned char val = 0; | 
|  | 347 | /* For each range of digits, if c is in that range, mask val with | 
|  | 348 | * the corresponding value. Since c can only be in a single range, | 
|  | 349 | * only at most one masking will change val. Set val to one plus | 
|  | 350 | * the desired value so that it stays 0 if c is in none of the ranges. */ | 
|  | 351 | val |= mbedtls_ct_uchar_mask_of_range( 'A', 'Z', c ) & ( c - 'A' +  0 + 1 ); | 
|  | 352 | val |= mbedtls_ct_uchar_mask_of_range( 'a', 'z', c ) & ( c - 'a' + 26 + 1 ); | 
|  | 353 | val |= mbedtls_ct_uchar_mask_of_range( '0', '9', c ) & ( c - '0' + 52 + 1 ); | 
|  | 354 | val |= mbedtls_ct_uchar_mask_of_range( '+', '+', c ) & ( c - '+' + 62 + 1 ); | 
|  | 355 | val |= mbedtls_ct_uchar_mask_of_range( '/', '/', c ) & ( c - '/' + 63 + 1 ); | 
|  | 356 | /* At this point, val is 0 if c is an invalid digit and v+1 if c is | 
|  | 357 | * a digit with the value v. */ | 
|  | 358 | return( val - 1 ); | 
|  | 359 | } | 
|  | 360 |  | 
| Gabor Mezei | 200708d | 2021-11-15 16:18:54 +0100 | [diff] [blame] | 361 | #endif /* MBEDTLS_BASE64_C */ | 
|  | 362 |  | 
| Gabor Mezei | 2b35880 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 363 | #if defined(MBEDTLS_PKCS1_V15) && defined(MBEDTLS_RSA_C) && !defined(MBEDTLS_RSA_ALT) | 
|  | 364 |  | 
| Gabor Mezei | fd8a42d | 2021-10-18 16:35:23 +0200 | [diff] [blame] | 365 | /** Shift some data towards the left inside a buffer. | 
|  | 366 | * | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 367 | * `mbedtls_ct_mem_move_to_left(start, total, offset)` is functionally | 
| Gabor Mezei | fd8a42d | 2021-10-18 16:35:23 +0200 | [diff] [blame] | 368 | * equivalent to | 
|  | 369 | * ``` | 
|  | 370 | * memmove(start, start + offset, total - offset); | 
|  | 371 | * memset(start + offset, 0, total - offset); | 
|  | 372 | * ``` | 
|  | 373 | * but it strives to use a memory access pattern (and thus total timing) | 
|  | 374 | * that does not depend on \p offset. This timing independence comes at | 
|  | 375 | * the expense of performance. | 
|  | 376 | * | 
|  | 377 | * \param start     Pointer to the start of the buffer. | 
|  | 378 | * \param total     Total size of the buffer. | 
|  | 379 | * \param offset    Offset from which to copy \p total - \p offset bytes. | 
|  | 380 | */ | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 381 | static void mbedtls_ct_mem_move_to_left( void *start, | 
| Gabor Mezei | fd8a42d | 2021-10-18 16:35:23 +0200 | [diff] [blame] | 382 | size_t total, | 
|  | 383 | size_t offset ) | 
| gabor-mezei-arm | 7b23c0b | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 384 | { | 
|  | 385 | volatile unsigned char *buf = start; | 
|  | 386 | size_t i, n; | 
|  | 387 | if( total == 0 ) | 
|  | 388 | return; | 
|  | 389 | for( i = 0; i < total; i++ ) | 
|  | 390 | { | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 391 | unsigned no_op = mbedtls_ct_size_gt( total - offset, i ); | 
| gabor-mezei-arm | 7b23c0b | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 392 | /* The first `total - offset` passes are a no-op. The last | 
|  | 393 | * `offset` passes shift the data one byte to the left and | 
|  | 394 | * zero out the last byte. */ | 
|  | 395 | for( n = 0; n < total - 1; n++ ) | 
|  | 396 | { | 
|  | 397 | unsigned char current = buf[n]; | 
|  | 398 | unsigned char next = buf[n+1]; | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 399 | buf[n] = mbedtls_ct_uint_if( no_op, current, next ); | 
| gabor-mezei-arm | 7b23c0b | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 400 | } | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 401 | buf[total-1] = mbedtls_ct_uint_if( no_op, buf[total-1], 0 ); | 
| gabor-mezei-arm | 7b23c0b | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 402 | } | 
|  | 403 | } | 
| gabor-mezei-arm | ee06feb | 2021-09-27 13:34:25 +0200 | [diff] [blame] | 404 |  | 
| Gabor Mezei | 2b35880 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 405 | #endif /* MBEDTLS_PKCS1_V15 && MBEDTLS_RSA_C && ! MBEDTLS_RSA_ALT */ | 
|  | 406 |  | 
| Przemek Stekiel | 169554c | 2022-10-06 10:53:20 +0200 | [diff] [blame] | 407 | #if defined(MBEDTLS_SSL_SOME_MODES_USE_MAC) | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 408 | void mbedtls_ct_memcpy_if_eq( unsigned char *dest, | 
| gabor-mezei-arm | 04087df | 2021-09-27 16:29:52 +0200 | [diff] [blame] | 409 | const unsigned char *src, | 
|  | 410 | size_t len, | 
|  | 411 | size_t c1, | 
|  | 412 | size_t c2 ) | 
| gabor-mezei-arm | ee06feb | 2021-09-27 13:34:25 +0200 | [diff] [blame] | 413 | { | 
|  | 414 | /* mask = c1 == c2 ? 0xff : 0x00 */ | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 415 | const size_t equal = mbedtls_ct_size_bool_eq( c1, c2 ); | 
|  | 416 | const unsigned char mask = (unsigned char) mbedtls_ct_size_mask( equal ); | 
| gabor-mezei-arm | ee06feb | 2021-09-27 13:34:25 +0200 | [diff] [blame] | 417 |  | 
| gabor-mezei-arm | 5e48824 | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 418 | /* dest[i] = c1 == c2 ? src[i] : dest[i] */ | 
| gabor-mezei-arm | ee06feb | 2021-09-27 13:34:25 +0200 | [diff] [blame] | 419 | for( size_t i = 0; i < len; i++ ) | 
| gabor-mezei-arm | 5e48824 | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 420 | dest[i] = ( src[i] & mask ) | ( dest[i] & ~mask ); | 
| gabor-mezei-arm | ee06feb | 2021-09-27 13:34:25 +0200 | [diff] [blame] | 421 | } | 
| gabor-mezei-arm | 0f7b9e4 | 2021-09-27 13:57:45 +0200 | [diff] [blame] | 422 |  | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 423 | void mbedtls_ct_memcpy_offset( unsigned char *dest, | 
| Gabor Mezei | 91deea7 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 424 | const unsigned char *src, | 
|  | 425 | size_t offset, | 
| gabor-mezei-arm | 04087df | 2021-09-27 16:29:52 +0200 | [diff] [blame] | 426 | size_t offset_min, | 
|  | 427 | size_t offset_max, | 
|  | 428 | size_t len ) | 
| gabor-mezei-arm | 0f7b9e4 | 2021-09-27 13:57:45 +0200 | [diff] [blame] | 429 | { | 
| Gabor Mezei | 91deea7 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 430 | size_t offsetval; | 
| gabor-mezei-arm | 0f7b9e4 | 2021-09-27 13:57:45 +0200 | [diff] [blame] | 431 |  | 
| Gabor Mezei | 91deea7 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 432 | for( offsetval = offset_min; offsetval <= offset_max; offsetval++ ) | 
| gabor-mezei-arm | 0f7b9e4 | 2021-09-27 13:57:45 +0200 | [diff] [blame] | 433 | { | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 434 | mbedtls_ct_memcpy_if_eq( dest, src + offsetval, len, | 
| Gabor Mezei | 91deea7 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 435 | offsetval, offset ); | 
| gabor-mezei-arm | 0f7b9e4 | 2021-09-27 13:57:45 +0200 | [diff] [blame] | 436 | } | 
|  | 437 | } | 
| gabor-mezei-arm | cb4317b | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 438 |  | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 439 | int mbedtls_ct_hmac( mbedtls_md_context_t *ctx, | 
| gabor-mezei-arm | 04087df | 2021-09-27 16:29:52 +0200 | [diff] [blame] | 440 | const unsigned char *add_data, | 
|  | 441 | size_t add_data_len, | 
|  | 442 | const unsigned char *data, | 
|  | 443 | size_t data_len_secret, | 
|  | 444 | size_t min_data_len, | 
|  | 445 | size_t max_data_len, | 
|  | 446 | unsigned char *output ) | 
| gabor-mezei-arm | cb4317b | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 447 | { | 
|  | 448 | /* | 
|  | 449 | * This function breaks the HMAC abstraction and uses the md_clone() | 
|  | 450 | * extension to the MD API in order to get constant-flow behaviour. | 
|  | 451 | * | 
|  | 452 | * HMAC(msg) is defined as HASH(okey + HASH(ikey + msg)) where + means | 
|  | 453 | * concatenation, and okey/ikey are the XOR of the key with some fixed bit | 
|  | 454 | * patterns (see RFC 2104, sec. 2), which are stored in ctx->hmac_ctx. | 
|  | 455 | * | 
|  | 456 | * We'll first compute inner_hash = HASH(ikey + msg) by hashing up to | 
|  | 457 | * minlen, then cloning the context, and for each byte up to maxlen | 
|  | 458 | * finishing up the hash computation, keeping only the correct result. | 
|  | 459 | * | 
|  | 460 | * Then we only need to compute HASH(okey + inner_hash) and we're done. | 
|  | 461 | */ | 
|  | 462 | const mbedtls_md_type_t md_alg = mbedtls_md_get_type( ctx->md_info ); | 
|  | 463 | /* TLS 1.0-1.2 only support SHA-384, SHA-256, SHA-1, MD-5, | 
|  | 464 | * all of which have the same block size except SHA-384. */ | 
|  | 465 | const size_t block_size = md_alg == MBEDTLS_MD_SHA384 ? 128 : 64; | 
|  | 466 | const unsigned char * const ikey = ctx->hmac_ctx; | 
|  | 467 | const unsigned char * const okey = ikey + block_size; | 
|  | 468 | const size_t hash_size = mbedtls_md_get_size( ctx->md_info ); | 
|  | 469 |  | 
|  | 470 | unsigned char aux_out[MBEDTLS_MD_MAX_SIZE]; | 
|  | 471 | mbedtls_md_context_t aux; | 
|  | 472 | size_t offset; | 
|  | 473 | int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED; | 
|  | 474 |  | 
|  | 475 | mbedtls_md_init( &aux ); | 
|  | 476 |  | 
|  | 477 | #define MD_CHK( func_call ) \ | 
|  | 478 | do {                    \ | 
|  | 479 | ret = (func_call);  \ | 
|  | 480 | if( ret != 0 )      \ | 
|  | 481 | goto cleanup;   \ | 
|  | 482 | } while( 0 ) | 
|  | 483 |  | 
|  | 484 | MD_CHK( mbedtls_md_setup( &aux, ctx->md_info, 0 ) ); | 
|  | 485 |  | 
|  | 486 | /* After hmac_start() of hmac_reset(), ikey has already been hashed, | 
|  | 487 | * so we can start directly with the message */ | 
|  | 488 | MD_CHK( mbedtls_md_update( ctx, add_data, add_data_len ) ); | 
|  | 489 | MD_CHK( mbedtls_md_update( ctx, data, min_data_len ) ); | 
|  | 490 |  | 
| Paul Elliott | b830028 | 2022-05-19 18:31:35 +0100 | [diff] [blame] | 491 | /* Fill the hash buffer in advance with something that is | 
|  | 492 | * not a valid hash (barring an attack on the hash and | 
|  | 493 | * deliberately-crafted input), in case the caller doesn't | 
|  | 494 | * check the return status properly. */ | 
|  | 495 | memset( output, '!', hash_size ); | 
|  | 496 |  | 
| gabor-mezei-arm | cb4317b | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 497 | /* For each possible length, compute the hash up to that point */ | 
|  | 498 | for( offset = min_data_len; offset <= max_data_len; offset++ ) | 
|  | 499 | { | 
|  | 500 | MD_CHK( mbedtls_md_clone( &aux, ctx ) ); | 
|  | 501 | MD_CHK( mbedtls_md_finish( &aux, aux_out ) ); | 
|  | 502 | /* Keep only the correct inner_hash in the output buffer */ | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 503 | mbedtls_ct_memcpy_if_eq( output, aux_out, hash_size, | 
| gabor-mezei-arm | cb4317b | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 504 | offset, data_len_secret ); | 
|  | 505 |  | 
|  | 506 | if( offset < max_data_len ) | 
|  | 507 | MD_CHK( mbedtls_md_update( ctx, data + offset, 1 ) ); | 
|  | 508 | } | 
|  | 509 |  | 
|  | 510 | /* The context needs to finish() before it starts() again */ | 
|  | 511 | MD_CHK( mbedtls_md_finish( ctx, aux_out ) ); | 
|  | 512 |  | 
|  | 513 | /* Now compute HASH(okey + inner_hash) */ | 
|  | 514 | MD_CHK( mbedtls_md_starts( ctx ) ); | 
|  | 515 | MD_CHK( mbedtls_md_update( ctx, okey, block_size ) ); | 
|  | 516 | MD_CHK( mbedtls_md_update( ctx, output, hash_size ) ); | 
|  | 517 | MD_CHK( mbedtls_md_finish( ctx, output ) ); | 
|  | 518 |  | 
|  | 519 | /* Done, get ready for next time */ | 
|  | 520 | MD_CHK( mbedtls_md_hmac_reset( ctx ) ); | 
|  | 521 |  | 
|  | 522 | #undef MD_CHK | 
|  | 523 |  | 
|  | 524 | cleanup: | 
|  | 525 | mbedtls_md_free( &aux ); | 
|  | 526 | return( ret ); | 
|  | 527 | } | 
|  | 528 |  | 
| Przemek Stekiel | 169554c | 2022-10-06 10:53:20 +0200 | [diff] [blame] | 529 | #endif /* MBEDTLS_SSL_SOME_MODES_USE_MAC */ | 
| gabor-mezei-arm | b8caeee | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 530 |  | 
|  | 531 | #if defined(MBEDTLS_BIGNUM_C) | 
|  | 532 |  | 
|  | 533 | #define MPI_VALIDATE_RET( cond )                                       \ | 
|  | 534 | MBEDTLS_INTERNAL_VALIDATE_RET( cond, MBEDTLS_ERR_MPI_BAD_INPUT_DATA ) | 
|  | 535 |  | 
|  | 536 | /* | 
|  | 537 | * Conditionally assign X = Y, without leaking information | 
|  | 538 | * about whether the assignment was made or not. | 
|  | 539 | * (Leaking information about the respective sizes of X and Y is ok however.) | 
|  | 540 | */ | 
| Tautvydas Žilys | 61156f8 | 2022-01-31 13:34:01 -0800 | [diff] [blame] | 541 | #if defined(_MSC_VER) && defined(_M_ARM64) && (_MSC_FULL_VER < 193131103) | 
| Tautvydas Žilys | ea4af4d | 2022-01-26 15:33:27 -0800 | [diff] [blame] | 542 | /* | 
| Tautvydas Žilys | 61156f8 | 2022-01-31 13:34:01 -0800 | [diff] [blame] | 543 | * MSVC miscompiles this function if it's inlined prior to Visual Studio 2022 version 17.1. See: | 
| Tautvydas Žilys | ea4af4d | 2022-01-26 15:33:27 -0800 | [diff] [blame] | 544 | * https://developercommunity.visualstudio.com/t/c-compiler-miscompiles-part-of-mbedtls-library-on/1646989 | 
|  | 545 | */ | 
|  | 546 | __declspec(noinline) | 
|  | 547 | #endif | 
| gabor-mezei-arm | 04087df | 2021-09-27 16:29:52 +0200 | [diff] [blame] | 548 | int mbedtls_mpi_safe_cond_assign( mbedtls_mpi *X, | 
|  | 549 | const mbedtls_mpi *Y, | 
|  | 550 | unsigned char assign ) | 
| gabor-mezei-arm | b8caeee | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 551 | { | 
|  | 552 | int ret = 0; | 
|  | 553 | size_t i; | 
|  | 554 | mbedtls_mpi_uint limb_mask; | 
|  | 555 | MPI_VALIDATE_RET( X != NULL ); | 
|  | 556 | MPI_VALIDATE_RET( Y != NULL ); | 
|  | 557 |  | 
| gabor-mezei-arm | b8caeee | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 558 | /* all-bits 1 if assign is 1, all-bits 0 if assign is 0 */ | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 559 | limb_mask = mbedtls_ct_mpi_uint_mask( assign );; | 
| gabor-mezei-arm | b8caeee | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 560 |  | 
|  | 561 | MBEDTLS_MPI_CHK( mbedtls_mpi_grow( X, Y->n ) ); | 
|  | 562 |  | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 563 | X->s = mbedtls_ct_cond_select_sign( assign, Y->s, X->s ); | 
| gabor-mezei-arm | b8caeee | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 564 |  | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 565 | mbedtls_ct_mpi_uint_cond_assign( Y->n, X->p, Y->p, assign ); | 
| gabor-mezei-arm | b8caeee | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 566 |  | 
|  | 567 | for( i = Y->n; i < X->n; i++ ) | 
|  | 568 | X->p[i] &= ~limb_mask; | 
|  | 569 |  | 
|  | 570 | cleanup: | 
|  | 571 | return( ret ); | 
|  | 572 | } | 
|  | 573 |  | 
| gabor-mezei-arm | 58fc8a6 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 574 | /* | 
|  | 575 | * Conditionally swap X and Y, without leaking information | 
|  | 576 | * about whether the swap was made or not. | 
| Shaun Case | 0e7791f | 2021-12-20 21:14:10 -0800 | [diff] [blame] | 577 | * Here it is not ok to simply swap the pointers, which would lead to | 
| gabor-mezei-arm | 58fc8a6 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 578 | * different memory access patterns when X and Y are used afterwards. | 
|  | 579 | */ | 
| gabor-mezei-arm | 04087df | 2021-09-27 16:29:52 +0200 | [diff] [blame] | 580 | int mbedtls_mpi_safe_cond_swap( mbedtls_mpi *X, | 
|  | 581 | mbedtls_mpi *Y, | 
|  | 582 | unsigned char swap ) | 
| gabor-mezei-arm | 58fc8a6 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 583 | { | 
|  | 584 | int ret, s; | 
|  | 585 | size_t i; | 
|  | 586 | mbedtls_mpi_uint limb_mask; | 
|  | 587 | mbedtls_mpi_uint tmp; | 
|  | 588 | MPI_VALIDATE_RET( X != NULL ); | 
|  | 589 | MPI_VALIDATE_RET( Y != NULL ); | 
|  | 590 |  | 
|  | 591 | if( X == Y ) | 
|  | 592 | return( 0 ); | 
|  | 593 |  | 
| gabor-mezei-arm | 58fc8a6 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 594 | /* all-bits 1 if swap is 1, all-bits 0 if swap is 0 */ | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 595 | limb_mask = mbedtls_ct_mpi_uint_mask( swap ); | 
| gabor-mezei-arm | 58fc8a6 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 596 |  | 
|  | 597 | MBEDTLS_MPI_CHK( mbedtls_mpi_grow( X, Y->n ) ); | 
|  | 598 | MBEDTLS_MPI_CHK( mbedtls_mpi_grow( Y, X->n ) ); | 
|  | 599 |  | 
|  | 600 | s = X->s; | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 601 | X->s = mbedtls_ct_cond_select_sign( swap, Y->s, X->s ); | 
|  | 602 | Y->s = mbedtls_ct_cond_select_sign( swap, s, Y->s ); | 
| gabor-mezei-arm | 58fc8a6 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 603 |  | 
|  | 604 |  | 
|  | 605 | for( i = 0; i < X->n; i++ ) | 
|  | 606 | { | 
|  | 607 | tmp = X->p[i]; | 
|  | 608 | X->p[i] = ( X->p[i] & ~limb_mask ) | ( Y->p[i] & limb_mask ); | 
|  | 609 | Y->p[i] = ( Y->p[i] & ~limb_mask ) | (     tmp & limb_mask ); | 
|  | 610 | } | 
|  | 611 |  | 
|  | 612 | cleanup: | 
|  | 613 | return( ret ); | 
|  | 614 | } | 
|  | 615 |  | 
| gabor-mezei-arm | b10301d | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 616 | /* | 
|  | 617 | * Compare signed values in constant time | 
|  | 618 | */ | 
| gabor-mezei-arm | 04087df | 2021-09-27 16:29:52 +0200 | [diff] [blame] | 619 | int mbedtls_mpi_lt_mpi_ct( const mbedtls_mpi *X, | 
|  | 620 | const mbedtls_mpi *Y, | 
|  | 621 | unsigned *ret ) | 
| gabor-mezei-arm | b10301d | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 622 | { | 
|  | 623 | size_t i; | 
|  | 624 | /* The value of any of these variables is either 0 or 1 at all times. */ | 
|  | 625 | unsigned cond, done, X_is_negative, Y_is_negative; | 
|  | 626 |  | 
|  | 627 | MPI_VALIDATE_RET( X != NULL ); | 
|  | 628 | MPI_VALIDATE_RET( Y != NULL ); | 
|  | 629 | MPI_VALIDATE_RET( ret != NULL ); | 
|  | 630 |  | 
|  | 631 | if( X->n != Y->n ) | 
|  | 632 | return MBEDTLS_ERR_MPI_BAD_INPUT_DATA; | 
|  | 633 |  | 
|  | 634 | /* | 
|  | 635 | * Set sign_N to 1 if N >= 0, 0 if N < 0. | 
|  | 636 | * We know that N->s == 1 if N >= 0 and N->s == -1 if N < 0. | 
|  | 637 | */ | 
|  | 638 | X_is_negative = ( X->s & 2 ) >> 1; | 
|  | 639 | Y_is_negative = ( Y->s & 2 ) >> 1; | 
|  | 640 |  | 
|  | 641 | /* | 
|  | 642 | * If the signs are different, then the positive operand is the bigger. | 
|  | 643 | * That is if X is negative (X_is_negative == 1), then X < Y is true and it | 
|  | 644 | * is false if X is positive (X_is_negative == 0). | 
|  | 645 | */ | 
|  | 646 | cond = ( X_is_negative ^ Y_is_negative ); | 
|  | 647 | *ret = cond & X_is_negative; | 
|  | 648 |  | 
|  | 649 | /* | 
|  | 650 | * This is a constant-time function. We might have the result, but we still | 
|  | 651 | * need to go through the loop. Record if we have the result already. | 
|  | 652 | */ | 
|  | 653 | done = cond; | 
|  | 654 |  | 
|  | 655 | for( i = X->n; i > 0; i-- ) | 
|  | 656 | { | 
|  | 657 | /* | 
|  | 658 | * If Y->p[i - 1] < X->p[i - 1] then X < Y is true if and only if both | 
|  | 659 | * X and Y are negative. | 
|  | 660 | * | 
|  | 661 | * Again even if we can make a decision, we just mark the result and | 
|  | 662 | * the fact that we are done and continue looping. | 
|  | 663 | */ | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 664 | cond = mbedtls_ct_mpi_uint_lt( Y->p[i - 1], X->p[i - 1] ); | 
| gabor-mezei-arm | b10301d | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 665 | *ret |= cond & ( 1 - done ) & X_is_negative; | 
|  | 666 | done |= cond; | 
|  | 667 |  | 
|  | 668 | /* | 
|  | 669 | * If X->p[i - 1] < Y->p[i - 1] then X < Y is true if and only if both | 
|  | 670 | * X and Y are positive. | 
|  | 671 | * | 
|  | 672 | * Again even if we can make a decision, we just mark the result and | 
|  | 673 | * the fact that we are done and continue looping. | 
|  | 674 | */ | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 675 | cond = mbedtls_ct_mpi_uint_lt( X->p[i - 1], Y->p[i - 1] ); | 
| gabor-mezei-arm | b10301d | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 676 | *ret |= cond & ( 1 - done ) & ( 1 - X_is_negative ); | 
|  | 677 | done |= cond; | 
|  | 678 | } | 
|  | 679 |  | 
|  | 680 | return( 0 ); | 
|  | 681 | } | 
|  | 682 |  | 
| gabor-mezei-arm | b8caeee | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 683 | #endif /* MBEDTLS_BIGNUM_C */ | 
| gabor-mezei-arm | f52941e | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 684 |  | 
|  | 685 | #if defined(MBEDTLS_PKCS1_V15) && defined(MBEDTLS_RSA_C) && !defined(MBEDTLS_RSA_ALT) | 
|  | 686 |  | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 687 | int mbedtls_ct_rsaes_pkcs1_v15_unpadding( int mode, | 
| Gabor Mezei | 91deea7 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 688 | unsigned char *input, | 
| gabor-mezei-arm | f52941e | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 689 | size_t ilen, | 
| gabor-mezei-arm | f52941e | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 690 | unsigned char *output, | 
|  | 691 | size_t output_max_len, | 
| Gabor Mezei | 91deea7 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 692 | size_t *olen ) | 
| gabor-mezei-arm | f52941e | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 693 | { | 
|  | 694 | int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED; | 
|  | 695 | size_t i, plaintext_max_size; | 
|  | 696 |  | 
|  | 697 | /* The following variables take sensitive values: their value must | 
|  | 698 | * not leak into the observable behavior of the function other than | 
|  | 699 | * the designated outputs (output, olen, return value). Otherwise | 
|  | 700 | * this would open the execution of the function to | 
|  | 701 | * side-channel-based variants of the Bleichenbacher padding oracle | 
|  | 702 | * attack. Potential side channels include overall timing, memory | 
|  | 703 | * access patterns (especially visible to an adversary who has access | 
|  | 704 | * to a shared memory cache), and branches (especially visible to | 
|  | 705 | * an adversary who has access to a shared code cache or to a shared | 
|  | 706 | * branch predictor). */ | 
|  | 707 | size_t pad_count = 0; | 
|  | 708 | unsigned bad = 0; | 
|  | 709 | unsigned char pad_done = 0; | 
|  | 710 | size_t plaintext_size = 0; | 
|  | 711 | unsigned output_too_large; | 
|  | 712 |  | 
| Gabor Mezei | 150bdee | 2021-10-18 16:12:45 +0200 | [diff] [blame] | 713 | plaintext_max_size = ( output_max_len > ilen - 11 ) ? ilen - 11 | 
|  | 714 | : output_max_len; | 
| gabor-mezei-arm | f52941e | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 715 |  | 
|  | 716 | /* Check and get padding length in constant time and constant | 
|  | 717 | * memory trace. The first byte must be 0. */ | 
| Gabor Mezei | 91deea7 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 718 | bad |= input[0]; | 
| gabor-mezei-arm | f52941e | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 719 |  | 
|  | 720 | if( mode == MBEDTLS_RSA_PRIVATE ) | 
|  | 721 | { | 
|  | 722 | /* Decode EME-PKCS1-v1_5 padding: 0x00 || 0x02 || PS || 0x00 | 
|  | 723 | * where PS must be at least 8 nonzero bytes. */ | 
| Gabor Mezei | 91deea7 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 724 | bad |= input[1] ^ MBEDTLS_RSA_CRYPT; | 
| gabor-mezei-arm | f52941e | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 725 |  | 
|  | 726 | /* Read the whole buffer. Set pad_done to nonzero if we find | 
|  | 727 | * the 0x00 byte and remember the padding length in pad_count. */ | 
|  | 728 | for( i = 2; i < ilen; i++ ) | 
|  | 729 | { | 
| Gabor Mezei | 91deea7 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 730 | pad_done  |= ((input[i] | (unsigned char)-input[i]) >> 7) ^ 1; | 
| gabor-mezei-arm | f52941e | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 731 | pad_count += ((pad_done | (unsigned char)-pad_done) >> 7) ^ 1; | 
|  | 732 | } | 
|  | 733 | } | 
|  | 734 | else | 
|  | 735 | { | 
|  | 736 | /* Decode EMSA-PKCS1-v1_5 padding: 0x00 || 0x01 || PS || 0x00 | 
|  | 737 | * where PS must be at least 8 bytes with the value 0xFF. */ | 
| Gabor Mezei | 91deea7 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 738 | bad |= input[1] ^ MBEDTLS_RSA_SIGN; | 
| gabor-mezei-arm | f52941e | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 739 |  | 
|  | 740 | /* Read the whole buffer. Set pad_done to nonzero if we find | 
|  | 741 | * the 0x00 byte and remember the padding length in pad_count. | 
|  | 742 | * If there's a non-0xff byte in the padding, the padding is bad. */ | 
|  | 743 | for( i = 2; i < ilen; i++ ) | 
|  | 744 | { | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 745 | pad_done |= mbedtls_ct_uint_if( input[i], 0, 1 ); | 
|  | 746 | pad_count += mbedtls_ct_uint_if( pad_done, 0, 1 ); | 
|  | 747 | bad |= mbedtls_ct_uint_if( pad_done, 0, input[i] ^ 0xFF ); | 
| gabor-mezei-arm | f52941e | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 748 | } | 
|  | 749 | } | 
|  | 750 |  | 
|  | 751 | /* If pad_done is still zero, there's no data, only unfinished padding. */ | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 752 | bad |= mbedtls_ct_uint_if( pad_done, 0, 1 ); | 
| gabor-mezei-arm | f52941e | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 753 |  | 
|  | 754 | /* There must be at least 8 bytes of padding. */ | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 755 | bad |= mbedtls_ct_size_gt( 8, pad_count ); | 
| gabor-mezei-arm | f52941e | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 756 |  | 
|  | 757 | /* If the padding is valid, set plaintext_size to the number of | 
|  | 758 | * remaining bytes after stripping the padding. If the padding | 
|  | 759 | * is invalid, avoid leaking this fact through the size of the | 
|  | 760 | * output: use the maximum message size that fits in the output | 
|  | 761 | * buffer. Do it without branches to avoid leaking the padding | 
|  | 762 | * validity through timing. RSA keys are small enough that all the | 
|  | 763 | * size_t values involved fit in unsigned int. */ | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 764 | plaintext_size = mbedtls_ct_uint_if( | 
| gabor-mezei-arm | f52941e | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 765 | bad, (unsigned) plaintext_max_size, | 
|  | 766 | (unsigned) ( ilen - pad_count - 3 ) ); | 
|  | 767 |  | 
|  | 768 | /* Set output_too_large to 0 if the plaintext fits in the output | 
|  | 769 | * buffer and to 1 otherwise. */ | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 770 | output_too_large = mbedtls_ct_size_gt( plaintext_size, | 
| gabor-mezei-arm | f52941e | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 771 | plaintext_max_size ); | 
|  | 772 |  | 
|  | 773 | /* Set ret without branches to avoid timing attacks. Return: | 
|  | 774 | * - INVALID_PADDING if the padding is bad (bad != 0). | 
|  | 775 | * - OUTPUT_TOO_LARGE if the padding is good but the decrypted | 
|  | 776 | *   plaintext does not fit in the output buffer. | 
|  | 777 | * - 0 if the padding is correct. */ | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 778 | ret = - (int) mbedtls_ct_uint_if( | 
| gabor-mezei-arm | f52941e | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 779 | bad, - MBEDTLS_ERR_RSA_INVALID_PADDING, | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 780 | mbedtls_ct_uint_if( output_too_large, | 
| gabor-mezei-arm | f52941e | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 781 | - MBEDTLS_ERR_RSA_OUTPUT_TOO_LARGE, | 
|  | 782 | 0 ) ); | 
|  | 783 |  | 
|  | 784 | /* If the padding is bad or the plaintext is too large, zero the | 
|  | 785 | * data that we're about to copy to the output buffer. | 
|  | 786 | * We need to copy the same amount of data | 
|  | 787 | * from the same buffer whether the padding is good or not to | 
|  | 788 | * avoid leaking the padding validity through overall timing or | 
|  | 789 | * through memory or cache access patterns. */ | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 790 | bad = mbedtls_ct_uint_mask( bad | output_too_large ); | 
| gabor-mezei-arm | f52941e | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 791 | for( i = 11; i < ilen; i++ ) | 
| Gabor Mezei | 91deea7 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 792 | input[i] &= ~bad; | 
| gabor-mezei-arm | f52941e | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 793 |  | 
|  | 794 | /* If the plaintext is too large, truncate it to the buffer size. | 
|  | 795 | * Copy anyway to avoid revealing the length through timing, because | 
|  | 796 | * revealing the length is as bad as revealing the padding validity | 
|  | 797 | * for a Bleichenbacher attack. */ | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 798 | plaintext_size = mbedtls_ct_uint_if( output_too_large, | 
| gabor-mezei-arm | f52941e | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 799 | (unsigned) plaintext_max_size, | 
|  | 800 | (unsigned) plaintext_size ); | 
|  | 801 |  | 
|  | 802 | /* Move the plaintext to the leftmost position where it can start in | 
|  | 803 | * the working buffer, i.e. make it start plaintext_max_size from | 
|  | 804 | * the end of the buffer. Do this with a memory access trace that | 
|  | 805 | * does not depend on the plaintext size. After this move, the | 
|  | 806 | * starting location of the plaintext is no longer sensitive | 
|  | 807 | * information. */ | 
| Gabor Mezei | 18a4494 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 808 | mbedtls_ct_mem_move_to_left( input + ilen - plaintext_max_size, | 
| gabor-mezei-arm | f52941e | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 809 | plaintext_max_size, | 
|  | 810 | plaintext_max_size - plaintext_size ); | 
|  | 811 |  | 
|  | 812 | /* Finally copy the decrypted plaintext plus trailing zeros into the output | 
|  | 813 | * buffer. If output_max_len is 0, then output may be an invalid pointer | 
|  | 814 | * and the result of memcpy() would be undefined; prevent undefined | 
|  | 815 | * behavior making sure to depend only on output_max_len (the size of the | 
|  | 816 | * user-provided output buffer), which is independent from plaintext | 
|  | 817 | * length, validity of padding, success of the decryption, and other | 
|  | 818 | * secrets. */ | 
|  | 819 | if( output_max_len != 0 ) | 
| Gabor Mezei | 91deea7 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 820 | memcpy( output, input + ilen - plaintext_max_size, plaintext_max_size ); | 
| gabor-mezei-arm | f52941e | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 821 |  | 
|  | 822 | /* Report the amount of data we copied to the output buffer. In case | 
|  | 823 | * of errors (bad padding or output too large), the value of *olen | 
|  | 824 | * when this function returns is not specified. Making it equivalent | 
|  | 825 | * to the good case limits the risks of leaking the padding validity. */ | 
|  | 826 | *olen = plaintext_size; | 
|  | 827 |  | 
|  | 828 | return( ret ); | 
|  | 829 | } | 
|  | 830 |  | 
|  | 831 | #endif /* MBEDTLS_PKCS1_V15 && MBEDTLS_RSA_C && ! MBEDTLS_RSA_ALT */ |