blob: 6f9b8db5b9a8b50286f552a0809033e101e1c9c7 [file] [log] [blame]
Paul Bakker33b43f12013-08-20 11:48:36 +02001/* BEGIN_HEADER */
Mohammad Azim Khancf32c452017-06-13 14:55:58 +01002#include "mbedtls/bignum.h"
Manuel Pégourié-Gonnard7f809972015-03-09 17:05:11 +00003#include "mbedtls/x509_crt.h"
4#include "mbedtls/x509_csr.h"
5#include "mbedtls/pem.h"
6#include "mbedtls/oid.h"
Hanno Becker418a6222017-09-14 07:51:28 +01007#include "mbedtls/rsa.h"
Valerio Setti48e8fc72022-10-19 15:14:29 +02008#include "mbedtls/asn1write.h"
Valerio Setti178b5bd2023-02-13 10:04:28 +01009#include "mbedtls/pk.h"
Manuel Pégourié-Gonnardfeb03962020-08-20 09:59:33 +020010
Manuel Pégourié-Gonnardabac0372022-07-18 13:41:11 +020011#include "hash_info.h"
12
Hanno Becker418a6222017-09-14 07:51:28 +010013#if defined(MBEDTLS_RSA_C)
Gilles Peskine449bd832023-01-11 14:50:10 +010014int mbedtls_rsa_decrypt_func(void *ctx, size_t *olen,
15 const unsigned char *input, unsigned char *output,
16 size_t output_max_len)
Hanno Becker418a6222017-09-14 07:51:28 +010017{
Gilles Peskine449bd832023-01-11 14:50:10 +010018 return mbedtls_rsa_pkcs1_decrypt((mbedtls_rsa_context *) ctx, NULL, NULL,
19 olen, input, output, output_max_len);
Hanno Becker418a6222017-09-14 07:51:28 +010020}
Gilles Peskine449bd832023-01-11 14:50:10 +010021int mbedtls_rsa_sign_func(void *ctx,
22 int (*f_rng)(void *, unsigned char *, size_t), void *p_rng,
23 mbedtls_md_type_t md_alg, unsigned int hashlen,
24 const unsigned char *hash, unsigned char *sig)
Hanno Becker418a6222017-09-14 07:51:28 +010025{
Gilles Peskine449bd832023-01-11 14:50:10 +010026 return mbedtls_rsa_pkcs1_sign((mbedtls_rsa_context *) ctx, f_rng, p_rng,
27 md_alg, hashlen, hash, sig);
Hanno Becker418a6222017-09-14 07:51:28 +010028}
Gilles Peskine449bd832023-01-11 14:50:10 +010029size_t mbedtls_rsa_key_len_func(void *ctx)
Hanno Becker418a6222017-09-14 07:51:28 +010030{
Gilles Peskine449bd832023-01-11 14:50:10 +010031 return ((const mbedtls_rsa_context *) ctx)->len;
Hanno Becker418a6222017-09-14 07:51:28 +010032}
33#endif /* MBEDTLS_RSA_C */
34
Gilles Peskinef4e672e2020-01-31 14:22:10 +010035#if defined(MBEDTLS_USE_PSA_CRYPTO) && \
36 defined(MBEDTLS_PEM_WRITE_C) && defined(MBEDTLS_X509_CSR_WRITE_C)
Gilles Peskine449bd832023-01-11 14:50:10 +010037static int x509_crt_verifycsr(const unsigned char *buf, size_t buflen)
Andrzej Kurek5f7bad32018-11-19 10:12:37 -050038{
Przemek Stekiel54a54462022-08-01 13:59:12 +020039 unsigned char hash[PSA_HASH_MAX_SIZE];
Andrzej Kurek5f7bad32018-11-19 10:12:37 -050040 mbedtls_x509_csr csr;
Hanno Beckerbf2dacb2019-06-03 16:28:24 +010041 int ret = 0;
42
Gilles Peskine449bd832023-01-11 14:50:10 +010043 mbedtls_x509_csr_init(&csr);
Andrzej Kurek5f7bad32018-11-19 10:12:37 -050044
Gilles Peskine449bd832023-01-11 14:50:10 +010045 if (mbedtls_x509_csr_parse(&csr, buf, buflen) != 0) {
Hanno Beckerbf2dacb2019-06-03 16:28:24 +010046 ret = MBEDTLS_ERR_X509_BAD_INPUT_DATA;
47 goto cleanup;
48 }
Andrzej Kurek5f7bad32018-11-19 10:12:37 -050049
Gilles Peskine449bd832023-01-11 14:50:10 +010050 psa_algorithm_t psa_alg = mbedtls_hash_info_psa_from_md(csr.sig_md);
Przemek Stekiel54a54462022-08-01 13:59:12 +020051 size_t hash_size = 0;
Gilles Peskine449bd832023-01-11 14:50:10 +010052 psa_status_t status = psa_hash_compute(psa_alg, csr.cri.p, csr.cri.len,
53 hash, PSA_HASH_MAX_SIZE, &hash_size);
Przemek Stekiel54a54462022-08-01 13:59:12 +020054
Gilles Peskine449bd832023-01-11 14:50:10 +010055 if (status != PSA_SUCCESS) {
Andrzej Kurek4b114072018-11-19 18:04:01 -050056 /* Note: this can't happen except after an internal error */
Hanno Beckerbf2dacb2019-06-03 16:28:24 +010057 ret = MBEDTLS_ERR_X509_BAD_INPUT_DATA;
58 goto cleanup;
Andrzej Kurek4b114072018-11-19 18:04:01 -050059 }
Andrzej Kurek5f7bad32018-11-19 10:12:37 -050060
Gilles Peskine449bd832023-01-11 14:50:10 +010061 if (mbedtls_pk_verify_ext(csr.sig_pk, csr.sig_opts, &csr.pk,
62 csr.sig_md, hash, mbedtls_hash_info_get_size(csr.sig_md),
63 csr.sig.p, csr.sig.len) != 0) {
Hanno Beckerbf2dacb2019-06-03 16:28:24 +010064 ret = MBEDTLS_ERR_X509_CERT_VERIFY_FAILED;
65 goto cleanup;
Andrzej Kurek4b114072018-11-19 18:04:01 -050066 }
Andrzej Kurek5f7bad32018-11-19 10:12:37 -050067
Hanno Beckerbf2dacb2019-06-03 16:28:24 +010068cleanup:
69
Gilles Peskine449bd832023-01-11 14:50:10 +010070 mbedtls_x509_csr_free(&csr);
71 return ret;
Andrzej Kurek5f7bad32018-11-19 10:12:37 -050072}
Gilles Peskinef4e672e2020-01-31 14:22:10 +010073#endif /* MBEDTLS_USE_PSA_CRYPTO && MBEDTLS_PEM_WRITE_C && MBEDTLS_X509_CSR_WRITE_C */
Andrzej Kurek5f7bad32018-11-19 10:12:37 -050074
Valerio Setti48e8fc72022-10-19 15:14:29 +020075#if defined(MBEDTLS_X509_CSR_WRITE_C)
76
77/*
78 * The size of this temporary buffer is given by the sequence of functions
79 * called hereinafter:
80 * - mbedtls_asn1_write_oid()
81 * - 8 bytes for MBEDTLS_OID_EXTENDED_KEY_USAGE raw value
82 * - 1 byte for MBEDTLS_OID_EXTENDED_KEY_USAGE length
83 * - 1 byte for MBEDTLS_ASN1_OID tag
84 * - mbedtls_asn1_write_len()
85 * - 1 byte since we're dealing with sizes which are less than 0x80
86 * - mbedtls_asn1_write_tag()
87 * - 1 byte
88 *
89 * This length is fine as long as this function is called using the
90 * MBEDTLS_OID_SERVER_AUTH OID. If this is changed in the future, then this
91 * buffer's length should be adjusted accordingly.
92 * Unfortunately there's no predefined max size for OIDs which can be used
93 * to set an overall upper boundary which is always guaranteed.
94 */
95#define EXT_KEY_USAGE_TMP_BUF_MAX_LENGTH 12
96
Gilles Peskine449bd832023-01-11 14:50:10 +010097static int csr_set_extended_key_usage(mbedtls_x509write_csr *ctx,
98 const char *oid, size_t oid_len)
Valerio Setti48e8fc72022-10-19 15:14:29 +020099{
100 unsigned char buf[EXT_KEY_USAGE_TMP_BUF_MAX_LENGTH] = { 0 };
Gilles Peskine449bd832023-01-11 14:50:10 +0100101 unsigned char *p = buf + sizeof(buf);
Valerio Setti48e8fc72022-10-19 15:14:29 +0200102 int ret;
103 size_t len = 0;
104
105 /*
106 * Following functions fail anyway if the temporary buffer is not large,
107 * but we set an extra check here to emphasize a possible source of errors
108 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100109 if (oid_len > EXT_KEY_USAGE_TMP_BUF_MAX_LENGTH) {
Valerio Setti48e8fc72022-10-19 15:14:29 +0200110 return MBEDTLS_ERR_X509_BAD_INPUT_DATA;
111 }
112
Gilles Peskine449bd832023-01-11 14:50:10 +0100113 MBEDTLS_ASN1_CHK_ADD(len, mbedtls_asn1_write_oid(&p, buf, oid, oid_len));
114 MBEDTLS_ASN1_CHK_ADD(len, mbedtls_asn1_write_len(&p, buf, ret));
115 MBEDTLS_ASN1_CHK_ADD(len, mbedtls_asn1_write_tag(&p, buf,
116 MBEDTLS_ASN1_CONSTRUCTED |
117 MBEDTLS_ASN1_SEQUENCE));
Valerio Setti48e8fc72022-10-19 15:14:29 +0200118
Gilles Peskine449bd832023-01-11 14:50:10 +0100119 ret = mbedtls_x509write_csr_set_extension(ctx,
120 MBEDTLS_OID_EXTENDED_KEY_USAGE,
121 MBEDTLS_OID_SIZE(MBEDTLS_OID_EXTENDED_KEY_USAGE),
122 0,
123 p,
124 len);
Valerio Setti48e8fc72022-10-19 15:14:29 +0200125
126 return ret;
127}
128#endif /* MBEDTLS_X509_CSR_WRITE_C */
Paul Bakker33b43f12013-08-20 11:48:36 +0200129/* END_HEADER */
Paul Bakker6d620502012-02-16 14:09:13 +0000130
Paul Bakker33b43f12013-08-20 11:48:36 +0200131/* BEGIN_DEPENDENCIES
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200132 * depends_on:MBEDTLS_BIGNUM_C:MBEDTLS_FS_IO:MBEDTLS_PK_PARSE_C
Paul Bakker33b43f12013-08-20 11:48:36 +0200133 * END_DEPENDENCIES
134 */
Paul Bakker6d620502012-02-16 14:09:13 +0000135
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200136/* BEGIN_CASE depends_on:MBEDTLS_PEM_WRITE_C:MBEDTLS_X509_CSR_WRITE_C */
Gilles Peskine449bd832023-01-11 14:50:10 +0100137void x509_csr_check(char *key_file, char *cert_req_check_file, int md_type,
138 int key_usage, int set_key_usage, int cert_type,
139 int set_cert_type, int set_extension)
Paul Bakker6d620502012-02-16 14:09:13 +0000140{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200141 mbedtls_pk_context key;
142 mbedtls_x509write_csr req;
Andres AGe0af9952016-09-07 11:09:44 +0100143 unsigned char buf[4096];
Paul Bakker6d620502012-02-16 14:09:13 +0000144 int ret;
Neil Armstrongc23d2e32022-03-18 15:31:59 +0100145#if !defined(MBEDTLS_USE_PSA_CRYPTO)
146 unsigned char check_buf[4000];
Paul Bakker6d620502012-02-16 14:09:13 +0000147 FILE *f;
Neil Armstrongc23d2e32022-03-18 15:31:59 +0100148 size_t olen = 0;
149#endif /* !MBEDTLS_USE_PSA_CRYPTO */
150 size_t pem_len = 0, buf_index;
151 int der_len = -1;
Paul Bakker3a8cb6f2013-12-30 20:41:54 +0100152 const char *subject_name = "C=NL,O=PolarSSL,CN=PolarSSL Server 1";
Ronald Cron351f0ee2020-06-10 12:12:18 +0200153 mbedtls_test_rnd_pseudo_info rnd_info;
Przemek Stekiel8e83d3a2023-02-14 12:01:16 +0100154 mbedtls_x509_san_list san_ip;
155 mbedtls_x509_san_list san_dns;
156 mbedtls_x509_san_list san_uri;
157 mbedtls_x509_san_list *san_list = NULL;
158 const char san_ip_name[] = { 0x7f, 0x01, 0x01, 0x00 }; // 127.1.1.0
159 const char *san_dns_name = "example.com";
160 const char *san_uri_name = "http://pki.example.com/";
161
162 san_uri.node.type = MBEDTLS_X509_SAN_UNIFORM_RESOURCE_IDENTIFIER;
Przemek Stekiel5a49d3c2023-02-24 13:12:55 +0100163 san_uri.node.san.unstructured_name.p = (unsigned char *) san_uri_name;
164 san_uri.node.san.unstructured_name.len = strlen(san_uri_name);
Przemek Stekiel8e83d3a2023-02-14 12:01:16 +0100165 san_uri.next = NULL;
166 san_ip.node.type = MBEDTLS_X509_SAN_IP_ADDRESS;
Przemek Stekiel5a49d3c2023-02-24 13:12:55 +0100167 san_ip.node.san.unstructured_name.p = (unsigned char *) san_ip_name;
168 san_ip.node.san.unstructured_name.len = sizeof(san_ip_name);
Przemek Stekiel8e83d3a2023-02-14 12:01:16 +0100169 san_ip.next = &san_uri;
170 san_dns.node.type = MBEDTLS_X509_SAN_DNS_NAME;
Przemek Stekiel5a49d3c2023-02-24 13:12:55 +0100171 san_dns.node.san.unstructured_name.p = (unsigned char *) san_dns_name;
172 san_dns.node.san.unstructured_name.len = strlen(san_dns_name);
Przemek Stekiel8e83d3a2023-02-14 12:01:16 +0100173 san_dns.next = &san_ip;
174 san_list = &san_dns;
Paul Bakker6d620502012-02-16 14:09:13 +0000175
Gilles Peskine449bd832023-01-11 14:50:10 +0100176 memset(&rnd_info, 0x2a, sizeof(mbedtls_test_rnd_pseudo_info));
Manuel Pégourié-Gonnardee731792013-09-11 22:48:40 +0200177
Gilles Peskine449bd832023-01-11 14:50:10 +0100178 mbedtls_x509write_csr_init(&req);
Gilles Peskine449bd832023-01-11 14:50:10 +0100179 mbedtls_pk_init(&key);
valerio32f2ac92023-04-20 11:59:52 +0200180 MD_OR_USE_PSA_INIT();
181
Gilles Peskine449bd832023-01-11 14:50:10 +0100182 TEST_ASSERT(mbedtls_pk_parse_keyfile(&key, key_file, NULL,
183 mbedtls_test_rnd_std_rand, NULL) == 0);
Paul Bakker6d620502012-02-16 14:09:13 +0000184
Gilles Peskine449bd832023-01-11 14:50:10 +0100185 mbedtls_x509write_csr_set_md_alg(&req, md_type);
186 mbedtls_x509write_csr_set_key(&req, &key);
187 TEST_ASSERT(mbedtls_x509write_csr_set_subject_name(&req, subject_name) == 0);
188 if (set_key_usage != 0) {
189 TEST_ASSERT(mbedtls_x509write_csr_set_key_usage(&req, key_usage) == 0);
190 }
191 if (set_cert_type != 0) {
192 TEST_ASSERT(mbedtls_x509write_csr_set_ns_cert_type(&req, cert_type) == 0);
193 }
194 if (set_extension != 0) {
195 TEST_ASSERT(csr_set_extended_key_usage(&req, MBEDTLS_OID_SERVER_AUTH,
196 MBEDTLS_OID_SIZE(MBEDTLS_OID_SERVER_AUTH)) == 0);
Przemek Stekiel8e83d3a2023-02-14 12:01:16 +0100197
198 TEST_ASSERT(mbedtls_x509write_csr_set_subject_alternative_name(&req, san_list) == 0);
Gilles Peskine449bd832023-01-11 14:50:10 +0100199 }
Paul Bakker8eabfc12013-08-25 10:18:25 +0200200
Gilles Peskine449bd832023-01-11 14:50:10 +0100201 ret = mbedtls_x509write_csr_pem(&req, buf, sizeof(buf),
202 mbedtls_test_rnd_pseudo_rand, &rnd_info);
203 TEST_ASSERT(ret == 0);
Paul Bakker6d620502012-02-16 14:09:13 +0000204
Gilles Peskine449bd832023-01-11 14:50:10 +0100205 pem_len = strlen((char *) buf);
Paul Bakker6d620502012-02-16 14:09:13 +0000206
Gilles Peskine449bd832023-01-11 14:50:10 +0100207 for (buf_index = pem_len; buf_index < sizeof(buf); ++buf_index) {
208 TEST_ASSERT(buf[buf_index] == 0);
Paul Elliott557b8d62020-11-19 09:46:56 +0000209 }
210
Neil Armstrong5b320382022-02-21 17:22:10 +0100211#if defined(MBEDTLS_USE_PSA_CRYPTO)
212 // When using PSA crypto, RNG isn't controllable, so cert_req_check_file can't be used
Gilles Peskine449bd832023-01-11 14:50:10 +0100213 (void) cert_req_check_file;
Neil Armstrong5b320382022-02-21 17:22:10 +0100214 buf[pem_len] = '\0';
Gilles Peskine449bd832023-01-11 14:50:10 +0100215 TEST_ASSERT(x509_crt_verifycsr(buf, pem_len + 1) == 0);
Neil Armstrong5b320382022-02-21 17:22:10 +0100216#else
Gilles Peskine449bd832023-01-11 14:50:10 +0100217 f = fopen(cert_req_check_file, "r");
218 TEST_ASSERT(f != NULL);
219 olen = fread(check_buf, 1, sizeof(check_buf), f);
220 fclose(f);
Paul Bakker6d620502012-02-16 14:09:13 +0000221
Gilles Peskine449bd832023-01-11 14:50:10 +0100222 TEST_ASSERT(olen >= pem_len - 1);
223 TEST_ASSERT(memcmp(buf, check_buf, pem_len - 1) == 0);
Neil Armstrongc23d2e32022-03-18 15:31:59 +0100224#endif /* MBEDTLS_USE_PSA_CRYPTO */
Paul Bakker58ef6ec2013-01-03 11:33:48 +0100225
Gilles Peskine449bd832023-01-11 14:50:10 +0100226 der_len = mbedtls_x509write_csr_der(&req, buf, sizeof(buf),
227 mbedtls_test_rnd_pseudo_rand,
228 &rnd_info);
229 TEST_ASSERT(der_len >= 0);
Andres AGe0af9952016-09-07 11:09:44 +0100230
Gilles Peskine449bd832023-01-11 14:50:10 +0100231 if (der_len == 0) {
Andres AGe0af9952016-09-07 11:09:44 +0100232 goto exit;
Gilles Peskine449bd832023-01-11 14:50:10 +0100233 }
Andres AGe0af9952016-09-07 11:09:44 +0100234
Neil Armstrong5b320382022-02-21 17:22:10 +0100235#if defined(MBEDTLS_USE_PSA_CRYPTO)
236 // When using PSA crypto, RNG isn't controllable, result length isn't
237 // deterministic over multiple runs, removing a single byte isn't enough to
238 // go into the MBEDTLS_ERR_ASN1_BUF_TOO_SMALL error case
239 der_len /= 2;
240#else
241 der_len -= 1;
242#endif
Gilles Peskine449bd832023-01-11 14:50:10 +0100243 ret = mbedtls_x509write_csr_der(&req, buf, (size_t) (der_len),
244 mbedtls_test_rnd_pseudo_rand, &rnd_info);
245 TEST_ASSERT(ret == MBEDTLS_ERR_ASN1_BUF_TOO_SMALL);
Andres AGe0af9952016-09-07 11:09:44 +0100246
Paul Bakkerbd51b262014-07-10 15:26:12 +0200247exit:
Gilles Peskine449bd832023-01-11 14:50:10 +0100248 mbedtls_x509write_csr_free(&req);
249 mbedtls_pk_free(&key);
Manuel Pégourié-Gonnard33a13022023-03-17 14:02:49 +0100250 MD_OR_USE_PSA_DONE();
Paul Bakker6d620502012-02-16 14:09:13 +0000251}
Paul Bakker33b43f12013-08-20 11:48:36 +0200252/* END_CASE */
Paul Bakker2397cf32013-09-08 15:58:15 +0200253
Andrzej Kurek5f7bad32018-11-19 10:12:37 -0500254/* BEGIN_CASE depends_on:MBEDTLS_PEM_WRITE_C:MBEDTLS_X509_CSR_WRITE_C:MBEDTLS_USE_PSA_CRYPTO */
Gilles Peskine449bd832023-01-11 14:50:10 +0100255void x509_csr_check_opaque(char *key_file, int md_type, int key_usage,
256 int cert_type)
Andrzej Kurek5f7bad32018-11-19 10:12:37 -0500257{
258 mbedtls_pk_context key;
Ronald Cron5425a212020-08-04 14:58:35 +0200259 mbedtls_svc_key_id_t key_id = MBEDTLS_SVC_KEY_ID_INIT;
Neil Armstrong95974972022-04-22 13:57:44 +0200260 psa_algorithm_t md_alg_psa, alg_psa;
Andrzej Kurek5f7bad32018-11-19 10:12:37 -0500261 mbedtls_x509write_csr req;
262 unsigned char buf[4096];
263 int ret;
264 size_t pem_len = 0;
265 const char *subject_name = "C=NL,O=PolarSSL,CN=PolarSSL Server 1";
Ronald Cron351f0ee2020-06-10 12:12:18 +0200266 mbedtls_test_rnd_pseudo_info rnd_info;
Andrzej Kurek5f7bad32018-11-19 10:12:37 -0500267
valerio32f2ac92023-04-20 11:59:52 +0200268 mbedtls_x509write_csr_init(&req);
Valerio Setti569c1712023-04-19 14:53:36 +0200269 MD_OR_USE_PSA_INIT();
270
Gilles Peskine449bd832023-01-11 14:50:10 +0100271 memset(&rnd_info, 0x2a, sizeof(mbedtls_test_rnd_pseudo_info));
Andrzej Kurek5f7bad32018-11-19 10:12:37 -0500272
Gilles Peskine449bd832023-01-11 14:50:10 +0100273 md_alg_psa = mbedtls_hash_info_psa_from_md((mbedtls_md_type_t) md_type);
274 TEST_ASSERT(md_alg_psa != MBEDTLS_MD_NONE);
Andrzej Kurek967cfd12018-11-20 02:53:17 -0500275
Gilles Peskine449bd832023-01-11 14:50:10 +0100276 mbedtls_pk_init(&key);
277 TEST_ASSERT(mbedtls_pk_parse_keyfile(&key, key_file, NULL,
278 mbedtls_test_rnd_std_rand, NULL) == 0);
Neil Armstrong95974972022-04-22 13:57:44 +0200279
Gilles Peskine449bd832023-01-11 14:50:10 +0100280 if (mbedtls_pk_get_type(&key) == MBEDTLS_PK_ECKEY) {
281 alg_psa = PSA_ALG_ECDSA(md_alg_psa);
282 } else if (mbedtls_pk_get_type(&key) == MBEDTLS_PK_RSA) {
283 alg_psa = PSA_ALG_RSA_PKCS1V15_SIGN(md_alg_psa);
284 } else {
285 TEST_ASSUME(!"PK key type not supported in this configuration");
286 }
Neil Armstrong95974972022-04-22 13:57:44 +0200287
Gilles Peskine449bd832023-01-11 14:50:10 +0100288 TEST_ASSERT(mbedtls_pk_wrap_as_opaque(&key, &key_id, alg_psa,
289 PSA_KEY_USAGE_SIGN_HASH,
290 PSA_ALG_NONE) == 0);
Andrzej Kurek5f7bad32018-11-19 10:12:37 -0500291
Gilles Peskine449bd832023-01-11 14:50:10 +0100292 mbedtls_x509write_csr_set_md_alg(&req, md_type);
293 mbedtls_x509write_csr_set_key(&req, &key);
294 TEST_ASSERT(mbedtls_x509write_csr_set_subject_name(&req, subject_name) == 0);
295 if (key_usage != 0) {
296 TEST_ASSERT(mbedtls_x509write_csr_set_key_usage(&req, key_usage) == 0);
297 }
298 if (cert_type != 0) {
299 TEST_ASSERT(mbedtls_x509write_csr_set_ns_cert_type(&req, cert_type) == 0);
300 }
Andrzej Kurek5f7bad32018-11-19 10:12:37 -0500301
Gilles Peskine449bd832023-01-11 14:50:10 +0100302 ret = mbedtls_x509write_csr_pem(&req, buf, sizeof(buf) - 1,
303 mbedtls_test_rnd_pseudo_rand, &rnd_info);
Ronald Cron6c5bd7f2020-06-10 14:08:26 +0200304
Gilles Peskine449bd832023-01-11 14:50:10 +0100305 TEST_ASSERT(ret == 0);
Andrzej Kurek5f7bad32018-11-19 10:12:37 -0500306
Gilles Peskine449bd832023-01-11 14:50:10 +0100307 pem_len = strlen((char *) buf);
Andrzej Kurek5f7bad32018-11-19 10:12:37 -0500308 buf[pem_len] = '\0';
Gilles Peskine449bd832023-01-11 14:50:10 +0100309 TEST_ASSERT(x509_crt_verifycsr(buf, pem_len + 1) == 0);
Andrzej Kurek5f7bad32018-11-19 10:12:37 -0500310
Manuel Pégourié-Gonnardfeb03962020-08-20 09:59:33 +0200311
Andrzej Kurek5f7bad32018-11-19 10:12:37 -0500312exit:
Gilles Peskine449bd832023-01-11 14:50:10 +0100313 mbedtls_x509write_csr_free(&req);
314 mbedtls_pk_free(&key);
315 psa_destroy_key(key_id);
Valerio Setti569c1712023-04-19 14:53:36 +0200316 MD_OR_USE_PSA_DONE();
Andrzej Kurek5f7bad32018-11-19 10:12:37 -0500317}
318/* END_CASE */
319
Manuel Pégourié-Gonnarda9464892023-03-17 12:08:50 +0100320/* BEGIN_CASE depends_on:MBEDTLS_PEM_WRITE_C:MBEDTLS_X509_CRT_WRITE_C:MBEDTLS_X509_CRT_PARSE_C:MBEDTLS_MD_CAN_SHA1 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100321void x509_crt_check(char *subject_key_file, char *subject_pwd,
322 char *subject_name, char *issuer_key_file,
323 char *issuer_pwd, char *issuer_name,
Valerio Settiaad8dbd2023-01-09 17:20:25 +0100324 data_t *serial_arg, char *not_before, char *not_after,
Gilles Peskine449bd832023-01-11 14:50:10 +0100325 int md_type, int key_usage, int set_key_usage,
326 char *ext_key_usage,
327 int cert_type, int set_cert_type, int auth_ident,
328 int ver, char *cert_check_file, int pk_wrap, int is_ca,
Andrzej Kurek76c96622023-04-04 06:57:08 -0400329 char *cert_verify_file, int set_subjectAltNames)
Paul Bakker2397cf32013-09-08 15:58:15 +0200330{
Hanno Becker418a6222017-09-14 07:51:28 +0100331 mbedtls_pk_context subject_key, issuer_key, issuer_key_alt;
332 mbedtls_pk_context *key = &issuer_key;
333
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200334 mbedtls_x509write_cert crt;
Andres AGe0af9952016-09-07 11:09:44 +0100335 unsigned char buf[4096];
Paul Bakker2397cf32013-09-08 15:58:15 +0200336 unsigned char check_buf[5000];
Werner Lewisacd01e52022-05-10 12:23:13 +0100337 unsigned char *p, *end;
338 unsigned char tag, sz;
Valerio Settiaad8dbd2023-01-09 17:20:25 +0100339#if defined(MBEDTLS_TEST_DEPRECATED) && defined(MBEDTLS_BIGNUM_C)
340 mbedtls_mpi serial_mpi;
341#endif
Werner Lewisacd01e52022-05-10 12:23:13 +0100342 int ret, before_tag, after_tag;
Paul Elliott557b8d62020-11-19 09:46:56 +0000343 size_t olen = 0, pem_len = 0, buf_index = 0;
Andres AGe0af9952016-09-07 11:09:44 +0100344 int der_len = -1;
Paul Bakker2397cf32013-09-08 15:58:15 +0200345 FILE *f;
Ronald Cron351f0ee2020-06-10 12:12:18 +0200346 mbedtls_test_rnd_pseudo_info rnd_info;
Neil Armstrong98f899c2022-03-16 17:42:42 +0100347#if defined(MBEDTLS_USE_PSA_CRYPTO)
348 mbedtls_svc_key_id_t key_id = MBEDTLS_SVC_KEY_ID_INIT;
349#endif
Neil Armstrong6ce6dd92022-03-17 09:38:50 +0100350 mbedtls_pk_type_t issuer_key_type;
Andrzej Kurek76c96622023-04-04 06:57:08 -0400351 mbedtls_x509_san_list san_ip;
352 mbedtls_x509_san_list san_dns;
353 mbedtls_x509_san_list san_uri;
354 mbedtls_x509_san_list san_mail;
355 mbedtls_x509_san_list san_dn;
356 mbedtls_asn1_named_data *ext_san_dirname = NULL;
357 const char san_ip_name[] = { 0x01, 0x02, 0x03, 0x04 };
358 const char *san_dns_name = "example.com";
359 const char *san_dn_name = "C=UK,O=Mbed TLS,CN=SubjectAltName test";
360 const char *san_mail_name = "mail@example.com";
361 const char *san_uri_name = "http://pki.example.com";
362 mbedtls_x509_san_list *san_list = NULL;
363
364 if (set_subjectAltNames) {
365 san_mail.node.type = MBEDTLS_X509_SAN_RFC822_NAME;
366 san_mail.node.san.unstructured_name.p = (unsigned char *) san_mail_name;
367 san_mail.node.san.unstructured_name.len = sizeof(san_mail_name);
368 san_mail.next = NULL;
369
370 san_dns.node.type = MBEDTLS_X509_SAN_DNS_NAME;
371 san_dns.node.san.unstructured_name.p = (unsigned char *) san_dns_name;
372 san_dns.node.san.unstructured_name.len = strlen(san_dns_name);
373 san_dns.next = &san_mail;
374
375 san_dn.node.type = MBEDTLS_X509_SAN_DIRECTORY_NAME;
376 TEST_ASSERT(mbedtls_x509_string_to_names(&ext_san_dirname,
377 san_dn_name) == 0);
378 san_dn.node.san.directory_name = *ext_san_dirname;
379 san_dn.next = &san_dns;
380
381 san_ip.node.type = MBEDTLS_X509_SAN_IP_ADDRESS;
382 san_ip.node.san.unstructured_name.p = (unsigned char *) san_ip_name;
383 san_ip.node.san.unstructured_name.len = sizeof(san_ip_name);
384 san_ip.next = &san_dn;
385
386 san_uri.node.type = MBEDTLS_X509_SAN_UNIFORM_RESOURCE_IDENTIFIER;
387 san_uri.node.san.unstructured_name.p = (unsigned char *) san_uri_name;
388 san_uri.node.san.unstructured_name.len = strlen(san_uri_name);
389 san_uri.next = &san_ip;
390
391 san_list = &san_uri;
392 }
Paul Bakker2397cf32013-09-08 15:58:15 +0200393
Gilles Peskine449bd832023-01-11 14:50:10 +0100394 memset(&rnd_info, 0x2a, sizeof(mbedtls_test_rnd_pseudo_info));
Valerio Settiaad8dbd2023-01-09 17:20:25 +0100395#if defined(MBEDTLS_TEST_DEPRECATED) && defined(MBEDTLS_BIGNUM_C)
396 mbedtls_mpi_init(&serial_mpi);
397#endif
Hanno Becker418a6222017-09-14 07:51:28 +0100398
Gilles Peskine449bd832023-01-11 14:50:10 +0100399 mbedtls_pk_init(&subject_key);
400 mbedtls_pk_init(&issuer_key);
401 mbedtls_pk_init(&issuer_key_alt);
Gilles Peskine449bd832023-01-11 14:50:10 +0100402 mbedtls_x509write_crt_init(&crt);
valerio32f2ac92023-04-20 11:59:52 +0200403 MD_OR_USE_PSA_INIT();
Paul Bakker2397cf32013-09-08 15:58:15 +0200404
Gilles Peskine449bd832023-01-11 14:50:10 +0100405 TEST_ASSERT(mbedtls_pk_parse_keyfile(&subject_key, subject_key_file,
406 subject_pwd, mbedtls_test_rnd_std_rand, NULL) == 0);
Hanno Becker418a6222017-09-14 07:51:28 +0100407
Gilles Peskine449bd832023-01-11 14:50:10 +0100408 TEST_ASSERT(mbedtls_pk_parse_keyfile(&issuer_key, issuer_key_file,
409 issuer_pwd, mbedtls_test_rnd_std_rand, NULL) == 0);
Hanno Becker418a6222017-09-14 07:51:28 +0100410
Gilles Peskine449bd832023-01-11 14:50:10 +0100411 issuer_key_type = mbedtls_pk_get_type(&issuer_key);
Neil Armstrong6ce6dd92022-03-17 09:38:50 +0100412
Dave Rodgmandc3b1542023-01-20 11:39:00 +0000413#if defined(MBEDTLS_RSA_C) && defined(MBEDTLS_PK_RSA_ALT_SUPPORT)
Hanno Becker418a6222017-09-14 07:51:28 +0100414 /* For RSA PK contexts, create a copy as an alternative RSA context. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100415 if (pk_wrap == 1 && issuer_key_type == MBEDTLS_PK_RSA) {
416 TEST_ASSERT(mbedtls_pk_setup_rsa_alt(&issuer_key_alt,
417 mbedtls_pk_rsa(issuer_key),
418 mbedtls_rsa_decrypt_func,
419 mbedtls_rsa_sign_func,
420 mbedtls_rsa_key_len_func) == 0);
Hanno Becker418a6222017-09-14 07:51:28 +0100421
422 key = &issuer_key_alt;
423 }
Manuel Pégourié-Gonnard147b28e2018-03-12 15:26:59 +0100424#endif
Hanno Becker418a6222017-09-14 07:51:28 +0100425
Neil Armstrong98f899c2022-03-16 17:42:42 +0100426#if defined(MBEDTLS_USE_PSA_CRYPTO)
427 /* For Opaque PK contexts, wrap key as an Opaque RSA context. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100428 if (pk_wrap == 2) {
Neil Armstrong95974972022-04-22 13:57:44 +0200429 psa_algorithm_t alg_psa, md_alg_psa;
Neil Armstrong98f899c2022-03-16 17:42:42 +0100430
Gilles Peskine449bd832023-01-11 14:50:10 +0100431 md_alg_psa = mbedtls_hash_info_psa_from_md((mbedtls_md_type_t) md_type);
432 TEST_ASSERT(md_alg_psa != MBEDTLS_MD_NONE);
Neil Armstrong95974972022-04-22 13:57:44 +0200433
Gilles Peskine449bd832023-01-11 14:50:10 +0100434 if (mbedtls_pk_get_type(&issuer_key) == MBEDTLS_PK_ECKEY) {
435 alg_psa = PSA_ALG_ECDSA(md_alg_psa);
436 } else if (mbedtls_pk_get_type(&issuer_key) == MBEDTLS_PK_RSA) {
437 alg_psa = PSA_ALG_RSA_PKCS1V15_SIGN(md_alg_psa);
438 } else {
439 TEST_ASSUME(!"PK key type not supported in this configuration");
440 }
Neil Armstrong95974972022-04-22 13:57:44 +0200441
Gilles Peskine449bd832023-01-11 14:50:10 +0100442 TEST_ASSERT(mbedtls_pk_wrap_as_opaque(&issuer_key, &key_id, alg_psa,
443 PSA_KEY_USAGE_SIGN_HASH,
444 PSA_ALG_NONE) == 0);
Neil Armstrong98f899c2022-03-16 17:42:42 +0100445 }
446#endif /* MBEDTLS_USE_PSA_CRYPTO */
447
Gilles Peskine449bd832023-01-11 14:50:10 +0100448 if (pk_wrap == 2) {
449 TEST_ASSERT(mbedtls_pk_get_type(&issuer_key) == MBEDTLS_PK_OPAQUE);
450 }
Neil Armstrong98f899c2022-03-16 17:42:42 +0100451
Gilles Peskine449bd832023-01-11 14:50:10 +0100452 if (ver != -1) {
453 mbedtls_x509write_crt_set_version(&crt, ver);
454 }
Hanno Becker418a6222017-09-14 07:51:28 +0100455
Valerio Settiaad8dbd2023-01-09 17:20:25 +0100456#if defined(MBEDTLS_TEST_DEPRECATED) && defined(MBEDTLS_BIGNUM_C)
Valerio Settiaad8dbd2023-01-09 17:20:25 +0100457 TEST_ASSERT(mbedtls_mpi_read_binary(&serial_mpi, serial_arg->x,
458 serial_arg->len) == 0);
459 TEST_ASSERT(mbedtls_x509write_crt_set_serial(&crt, &serial_mpi) == 0);
Valerio Settida0afcc2023-01-05 16:46:59 +0100460#else
Valerio Settiaf4815c2023-01-26 17:43:09 +0100461 TEST_ASSERT(mbedtls_x509write_crt_set_serial_raw(&crt, serial_arg->x,
Valerio Settiaad8dbd2023-01-09 17:20:25 +0100462 serial_arg->len) == 0);
Valerio Settida0afcc2023-01-05 16:46:59 +0100463#endif
Gilles Peskine449bd832023-01-11 14:50:10 +0100464 TEST_ASSERT(mbedtls_x509write_crt_set_validity(&crt, not_before,
465 not_after) == 0);
466 mbedtls_x509write_crt_set_md_alg(&crt, md_type);
467 TEST_ASSERT(mbedtls_x509write_crt_set_issuer_name(&crt, issuer_name) == 0);
468 TEST_ASSERT(mbedtls_x509write_crt_set_subject_name(&crt, subject_name) == 0);
469 mbedtls_x509write_crt_set_subject_key(&crt, &subject_key);
Hanno Becker418a6222017-09-14 07:51:28 +0100470
Gilles Peskine449bd832023-01-11 14:50:10 +0100471 mbedtls_x509write_crt_set_issuer_key(&crt, key);
Paul Bakker2397cf32013-09-08 15:58:15 +0200472
Gilles Peskine449bd832023-01-11 14:50:10 +0100473 if (crt.version >= MBEDTLS_X509_CRT_VERSION_3) {
Darren Krahn9c134ce2021-01-13 22:04:45 -0800474 /* For the CA case, a path length of -1 means unlimited. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100475 TEST_ASSERT(mbedtls_x509write_crt_set_basic_constraints(&crt, is_ca,
476 (is_ca ? -1 : 0)) == 0);
477 TEST_ASSERT(mbedtls_x509write_crt_set_subject_key_identifier(&crt) == 0);
478 if (auth_ident) {
479 TEST_ASSERT(mbedtls_x509write_crt_set_authority_key_identifier(&crt) == 0);
480 }
481 if (set_key_usage != 0) {
482 TEST_ASSERT(mbedtls_x509write_crt_set_key_usage(&crt, key_usage) == 0);
483 }
484 if (set_cert_type != 0) {
485 TEST_ASSERT(mbedtls_x509write_crt_set_ns_cert_type(&crt, cert_type) == 0);
486 }
487 if (strcmp(ext_key_usage, "NULL") != 0) {
Dave Rodgmanec9f6b42022-07-27 14:34:58 +0100488 mbedtls_asn1_sequence exts[2];
Gilles Peskine449bd832023-01-11 14:50:10 +0100489 memset(exts, 0, sizeof(exts));
Dave Rodgman5f3f0d02022-08-11 14:38:26 +0100490
491#define SET_OID(x, oid) \
492 do { \
493 x.len = MBEDTLS_OID_SIZE(oid); \
Gilles Peskine449bd832023-01-11 14:50:10 +0100494 x.p = (unsigned char *) oid; \
Dave Rodgman5f3f0d02022-08-11 14:38:26 +0100495 x.tag = MBEDTLS_ASN1_OID; \
Dave Rodgmane2b772d2022-08-11 16:04:13 +0100496 } \
Gilles Peskine449bd832023-01-11 14:50:10 +0100497 while (0)
Dave Rodgman5f3f0d02022-08-11 14:38:26 +0100498
Gilles Peskine449bd832023-01-11 14:50:10 +0100499 if (strcmp(ext_key_usage, "serverAuth") == 0) {
500 SET_OID(exts[0].buf, MBEDTLS_OID_SERVER_AUTH);
501 } else if (strcmp(ext_key_usage, "codeSigning,timeStamping") == 0) {
502 SET_OID(exts[0].buf, MBEDTLS_OID_CODE_SIGNING);
Dave Rodgman5f3f0d02022-08-11 14:38:26 +0100503 exts[0].next = &exts[1];
Gilles Peskine449bd832023-01-11 14:50:10 +0100504 SET_OID(exts[1].buf, MBEDTLS_OID_TIME_STAMPING);
Nicholas Wilsonca841d32015-11-13 14:22:36 +0000505 }
Gilles Peskine449bd832023-01-11 14:50:10 +0100506 TEST_ASSERT(mbedtls_x509write_crt_set_ext_key_usage(&crt, exts) == 0);
Nicholas Wilsonca841d32015-11-13 14:22:36 +0000507 }
Manuel Pégourié-Gonnard6c1a73e2014-03-28 14:03:22 +0100508 }
Paul Bakker2397cf32013-09-08 15:58:15 +0200509
Andrzej Kurek76c96622023-04-04 06:57:08 -0400510 if (set_subjectAltNames) {
511 TEST_ASSERT(mbedtls_x509write_crt_set_subject_alternative_name(&crt, san_list) == 0);
512 }
Gilles Peskine449bd832023-01-11 14:50:10 +0100513 ret = mbedtls_x509write_crt_pem(&crt, buf, sizeof(buf),
514 mbedtls_test_rnd_pseudo_rand, &rnd_info);
515 TEST_ASSERT(ret == 0);
Paul Bakker2397cf32013-09-08 15:58:15 +0200516
Gilles Peskine449bd832023-01-11 14:50:10 +0100517 pem_len = strlen((char *) buf);
Paul Bakker2397cf32013-09-08 15:58:15 +0200518
Paul Elliott557b8d62020-11-19 09:46:56 +0000519 // check that the rest of the buffer remains clear
Gilles Peskine449bd832023-01-11 14:50:10 +0100520 for (buf_index = pem_len; buf_index < sizeof(buf); ++buf_index) {
521 TEST_ASSERT(buf[buf_index] == 0);
Paul Elliott557b8d62020-11-19 09:46:56 +0000522 }
523
Gilles Peskine449bd832023-01-11 14:50:10 +0100524 if (issuer_key_type != MBEDTLS_PK_RSA) {
Neil Armstrong6ce6dd92022-03-17 09:38:50 +0100525 mbedtls_x509_crt crt_parse, trusted;
526 uint32_t flags;
Paul Bakker2397cf32013-09-08 15:58:15 +0200527
Gilles Peskine449bd832023-01-11 14:50:10 +0100528 mbedtls_x509_crt_init(&crt_parse);
529 mbedtls_x509_crt_init(&trusted);
Neil Armstrong6ce6dd92022-03-17 09:38:50 +0100530
Gilles Peskine449bd832023-01-11 14:50:10 +0100531 TEST_ASSERT(mbedtls_x509_crt_parse_file(&trusted,
532 cert_verify_file) == 0);
533 TEST_ASSERT(mbedtls_x509_crt_parse(&crt_parse,
534 buf, sizeof(buf)) == 0);
Neil Armstrong6ce6dd92022-03-17 09:38:50 +0100535
Gilles Peskine449bd832023-01-11 14:50:10 +0100536 ret = mbedtls_x509_crt_verify(&crt_parse, &trusted, NULL, NULL, &flags,
537 NULL, NULL);
Neil Armstrong6ce6dd92022-03-17 09:38:50 +0100538
Gilles Peskine449bd832023-01-11 14:50:10 +0100539 mbedtls_x509_crt_free(&crt_parse);
540 mbedtls_x509_crt_free(&trusted);
Neil Armstrong6ce6dd92022-03-17 09:38:50 +0100541
Gilles Peskine449bd832023-01-11 14:50:10 +0100542 TEST_EQUAL(flags, 0);
543 TEST_EQUAL(ret, 0);
544 } else if (*cert_check_file != '\0') {
545 f = fopen(cert_check_file, "r");
546 TEST_ASSERT(f != NULL);
547 olen = fread(check_buf, 1, sizeof(check_buf), f);
548 fclose(f);
549 TEST_ASSERT(olen < sizeof(check_buf));
Neil Armstrong6ce6dd92022-03-17 09:38:50 +0100550
Gilles Peskine449bd832023-01-11 14:50:10 +0100551 TEST_EQUAL(olen, pem_len);
552 TEST_ASSERT(olen >= pem_len - 1);
553 TEST_ASSERT(memcmp(buf, check_buf, pem_len - 1) == 0);
Neil Armstrong6ce6dd92022-03-17 09:38:50 +0100554 }
Paul Bakker2397cf32013-09-08 15:58:15 +0200555
Gilles Peskine449bd832023-01-11 14:50:10 +0100556 der_len = mbedtls_x509write_crt_der(&crt, buf, sizeof(buf),
557 mbedtls_test_rnd_pseudo_rand,
558 &rnd_info);
559 TEST_ASSERT(der_len >= 0);
Andres AGe0af9952016-09-07 11:09:44 +0100560
Gilles Peskine449bd832023-01-11 14:50:10 +0100561 if (der_len == 0) {
Andres AGe0af9952016-09-07 11:09:44 +0100562 goto exit;
Gilles Peskine449bd832023-01-11 14:50:10 +0100563 }
Andres AGe0af9952016-09-07 11:09:44 +0100564
Werner Lewisacd01e52022-05-10 12:23:13 +0100565 // Not testing against file, check date format
Gilles Peskine449bd832023-01-11 14:50:10 +0100566 if (*cert_check_file == '\0') {
Werner Lewisacd01e52022-05-10 12:23:13 +0100567 // UTC tag if before 2050, 2 digits less for year
Gilles Peskine449bd832023-01-11 14:50:10 +0100568 if (not_before[0] == '2' && (not_before[1] > '0' || not_before[2] > '4')) {
Werner Lewisacd01e52022-05-10 12:23:13 +0100569 before_tag = MBEDTLS_ASN1_GENERALIZED_TIME;
Gilles Peskine449bd832023-01-11 14:50:10 +0100570 } else {
Werner Lewisacd01e52022-05-10 12:23:13 +0100571 before_tag = MBEDTLS_ASN1_UTC_TIME;
572 not_before += 2;
573 }
Gilles Peskine449bd832023-01-11 14:50:10 +0100574 if (not_after[0] == '2' && (not_after[1] > '0' || not_after[2] > '4')) {
Werner Lewisacd01e52022-05-10 12:23:13 +0100575 after_tag = MBEDTLS_ASN1_GENERALIZED_TIME;
Gilles Peskine449bd832023-01-11 14:50:10 +0100576 } else {
Werner Lewisacd01e52022-05-10 12:23:13 +0100577 after_tag = MBEDTLS_ASN1_UTC_TIME;
578 not_after += 2;
579 }
Gilles Peskine449bd832023-01-11 14:50:10 +0100580 end = buf + sizeof(buf);
581 for (p = end - der_len; p < end;) {
Werner Lewisacd01e52022-05-10 12:23:13 +0100582 tag = *p++;
583 sz = *p++;
Gilles Peskine449bd832023-01-11 14:50:10 +0100584 if (tag == MBEDTLS_ASN1_UTC_TIME || tag == MBEDTLS_ASN1_GENERALIZED_TIME) {
Werner Lewisacd01e52022-05-10 12:23:13 +0100585 // Check correct tag and time written
Gilles Peskine449bd832023-01-11 14:50:10 +0100586 TEST_ASSERT(before_tag == tag);
587 TEST_ASSERT(memcmp(p, not_before, sz - 1) == 0);
Werner Lewisacd01e52022-05-10 12:23:13 +0100588 p += sz;
589 tag = *p++;
590 sz = *p++;
Gilles Peskine449bd832023-01-11 14:50:10 +0100591 TEST_ASSERT(after_tag == tag);
592 TEST_ASSERT(memcmp(p, not_after, sz - 1) == 0);
Werner Lewisacd01e52022-05-10 12:23:13 +0100593 break;
594 }
595 // Increment if long form ASN1 length
Gilles Peskine449bd832023-01-11 14:50:10 +0100596 if (sz & 0x80) {
Werner Lewisacd01e52022-05-10 12:23:13 +0100597 p += sz & 0x0F;
Gilles Peskine449bd832023-01-11 14:50:10 +0100598 }
599 if (tag != (MBEDTLS_ASN1_CONSTRUCTED | MBEDTLS_ASN1_SEQUENCE)) {
Werner Lewisacd01e52022-05-10 12:23:13 +0100600 p += sz;
Gilles Peskine449bd832023-01-11 14:50:10 +0100601 }
Werner Lewisacd01e52022-05-10 12:23:13 +0100602 }
Gilles Peskine449bd832023-01-11 14:50:10 +0100603 TEST_ASSERT(p < end);
Werner Lewisacd01e52022-05-10 12:23:13 +0100604 }
605
Neil Armstrong6ce6dd92022-03-17 09:38:50 +0100606#if defined(MBEDTLS_USE_PSA_CRYPTO)
Neil Armstronge6ed23c2022-04-22 09:44:04 +0200607 // When using PSA crypto, RNG isn't controllable, result length isn't
Neil Armstrong6ce6dd92022-03-17 09:38:50 +0100608 // deterministic over multiple runs, removing a single byte isn't enough to
609 // go into the MBEDTLS_ERR_ASN1_BUF_TOO_SMALL error case
Gilles Peskine449bd832023-01-11 14:50:10 +0100610 if (issuer_key_type != MBEDTLS_PK_RSA) {
Neil Armstrong6ce6dd92022-03-17 09:38:50 +0100611 der_len /= 2;
Gilles Peskine449bd832023-01-11 14:50:10 +0100612 } else
Neil Armstrong6ce6dd92022-03-17 09:38:50 +0100613#endif
Gilles Peskine449bd832023-01-11 14:50:10 +0100614 der_len -= 1;
Neil Armstrong6ce6dd92022-03-17 09:38:50 +0100615
Gilles Peskine449bd832023-01-11 14:50:10 +0100616 ret = mbedtls_x509write_crt_der(&crt, buf, (size_t) (der_len),
617 mbedtls_test_rnd_pseudo_rand, &rnd_info);
618 TEST_ASSERT(ret == MBEDTLS_ERR_ASN1_BUF_TOO_SMALL);
Andres AGe0af9952016-09-07 11:09:44 +0100619
Paul Bakkerbd51b262014-07-10 15:26:12 +0200620exit:
Gilles Peskine449bd832023-01-11 14:50:10 +0100621 mbedtls_x509write_crt_free(&crt);
622 mbedtls_pk_free(&issuer_key_alt);
623 mbedtls_pk_free(&subject_key);
624 mbedtls_pk_free(&issuer_key);
Valerio Settiaad8dbd2023-01-09 17:20:25 +0100625#if defined(MBEDTLS_TEST_DEPRECATED) && defined(MBEDTLS_BIGNUM_C)
626 mbedtls_mpi_free(&serial_mpi);
627#endif
Neil Armstrong98f899c2022-03-16 17:42:42 +0100628#if defined(MBEDTLS_USE_PSA_CRYPTO)
Gilles Peskine449bd832023-01-11 14:50:10 +0100629 psa_destroy_key(key_id);
Neil Armstrong98f899c2022-03-16 17:42:42 +0100630#endif
Manuel Pégourié-Gonnard33a13022023-03-17 14:02:49 +0100631 MD_OR_USE_PSA_DONE();
Paul Bakker2397cf32013-09-08 15:58:15 +0200632}
633/* END_CASE */
Paul Bakker8dcb2d72014-08-08 12:22:30 +0200634
Valerio Settiaad8dbd2023-01-09 17:20:25 +0100635/* BEGIN_CASE depends_on:MBEDTLS_X509_CRT_WRITE_C */
636void x509_set_serial_check()
637{
638 mbedtls_x509write_cert ctx;
639 uint8_t invalid_serial[MBEDTLS_X509_RFC5280_MAX_SERIAL_LEN + 1];
640
Valerio Setti569c1712023-04-19 14:53:36 +0200641 USE_PSA_INIT();
Valerio Settiaad8dbd2023-01-09 17:20:25 +0100642 memset(invalid_serial, 0x01, sizeof(invalid_serial));
643
Valerio Settiea19d2d2023-01-09 17:21:17 +0100644#if defined(MBEDTLS_TEST_DEPRECATED) && defined(MBEDTLS_BIGNUM_C)
Valerio Settiaad8dbd2023-01-09 17:20:25 +0100645 mbedtls_mpi serial_mpi;
646
647 mbedtls_mpi_init(&serial_mpi);
648 TEST_EQUAL(mbedtls_mpi_read_binary(&serial_mpi, invalid_serial,
649 sizeof(invalid_serial)), 0);
650 TEST_EQUAL(mbedtls_x509write_crt_set_serial(&ctx, &serial_mpi),
651 MBEDTLS_ERR_X509_BAD_INPUT_DATA);
Valerio Settiaad8dbd2023-01-09 17:20:25 +0100652#endif
653
Valerio Settiaf4815c2023-01-26 17:43:09 +0100654 TEST_EQUAL(mbedtls_x509write_crt_set_serial_raw(&ctx, invalid_serial,
Valerio Settiaad8dbd2023-01-09 17:20:25 +0100655 sizeof(invalid_serial)),
656 MBEDTLS_ERR_X509_BAD_INPUT_DATA);
657
Valerio Settia87f8392023-01-26 18:00:50 +0100658exit:
659#if defined(MBEDTLS_TEST_DEPRECATED) && defined(MBEDTLS_BIGNUM_C)
660 mbedtls_mpi_free(&serial_mpi);
661#else
662 ;
663#endif
Valerio Setti569c1712023-04-19 14:53:36 +0200664 USE_PSA_DONE();
Valerio Settiaad8dbd2023-01-09 17:20:25 +0100665}
666/* END_CASE */
667
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200668/* BEGIN_CASE depends_on:MBEDTLS_X509_CREATE_C:MBEDTLS_X509_USE_C */
Gilles Peskine449bd832023-01-11 14:50:10 +0100669void mbedtls_x509_string_to_names(char *name, char *parsed_name, int result
670 )
Paul Bakker8dcb2d72014-08-08 12:22:30 +0200671{
672 int ret;
673 size_t len = 0;
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200674 mbedtls_asn1_named_data *names = NULL;
675 mbedtls_x509_name parsed, *parsed_cur, *parsed_prv;
Manuel Pégourié-Gonnard4fd0b252015-06-26 14:15:48 +0200676 unsigned char buf[1024], out[1024], *c;
Paul Bakker8dcb2d72014-08-08 12:22:30 +0200677
Valerio Setti569c1712023-04-19 14:53:36 +0200678 USE_PSA_INIT();
679
Gilles Peskine449bd832023-01-11 14:50:10 +0100680 memset(&parsed, 0, sizeof(parsed));
681 memset(out, 0, sizeof(out));
682 memset(buf, 0, sizeof(buf));
683 c = buf + sizeof(buf);
Paul Bakker8dcb2d72014-08-08 12:22:30 +0200684
Gilles Peskine449bd832023-01-11 14:50:10 +0100685 ret = mbedtls_x509_string_to_names(&names, name);
686 TEST_ASSERT(ret == result);
Paul Bakker8dcb2d72014-08-08 12:22:30 +0200687
Gilles Peskine449bd832023-01-11 14:50:10 +0100688 if (ret != 0) {
Paul Bakker8dcb2d72014-08-08 12:22:30 +0200689 goto exit;
Gilles Peskine449bd832023-01-11 14:50:10 +0100690 }
Paul Bakker8dcb2d72014-08-08 12:22:30 +0200691
Gilles Peskine449bd832023-01-11 14:50:10 +0100692 ret = mbedtls_x509_write_names(&c, buf, names);
693 TEST_ASSERT(ret > 0);
Paul Bakker8dcb2d72014-08-08 12:22:30 +0200694
Gilles Peskine449bd832023-01-11 14:50:10 +0100695 TEST_ASSERT(mbedtls_asn1_get_tag(&c, buf + sizeof(buf), &len,
696 MBEDTLS_ASN1_CONSTRUCTED | MBEDTLS_ASN1_SEQUENCE) == 0);
697 TEST_ASSERT(mbedtls_x509_get_name(&c, buf + sizeof(buf), &parsed) == 0);
Paul Bakker8dcb2d72014-08-08 12:22:30 +0200698
Gilles Peskine449bd832023-01-11 14:50:10 +0100699 ret = mbedtls_x509_dn_gets((char *) out, sizeof(out), &parsed);
700 TEST_ASSERT(ret > 0);
Paul Bakker8dcb2d72014-08-08 12:22:30 +0200701
Gilles Peskine449bd832023-01-11 14:50:10 +0100702 TEST_ASSERT(strcmp((char *) out, parsed_name) == 0);
Paul Bakker8dcb2d72014-08-08 12:22:30 +0200703
704exit:
Gilles Peskine449bd832023-01-11 14:50:10 +0100705 mbedtls_asn1_free_named_data_list(&names);
Paul Bakker8dcb2d72014-08-08 12:22:30 +0200706
707 parsed_cur = parsed.next;
Gilles Peskine449bd832023-01-11 14:50:10 +0100708 while (parsed_cur != 0) {
Paul Bakker8dcb2d72014-08-08 12:22:30 +0200709 parsed_prv = parsed_cur;
710 parsed_cur = parsed_cur->next;
Gilles Peskine449bd832023-01-11 14:50:10 +0100711 mbedtls_free(parsed_prv);
Paul Bakker8dcb2d72014-08-08 12:22:30 +0200712 }
Valerio Setti569c1712023-04-19 14:53:36 +0200713 USE_PSA_DONE();
Paul Bakker8dcb2d72014-08-08 12:22:30 +0200714}
715/* END_CASE */