blob: 870773c136c3d294748d82364e8e07a3b8201748 [file] [log] [blame]
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +01001/*
Manuel Pégourié-Gonnard32b04c12013-12-02 15:49:09 +01002 * Elliptic curves over GF(p): generic functions
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +01003 *
Bence Szépkúti1e148272020-08-07 13:07:28 +02004 * Copyright The Mbed TLS Contributors
Manuel Pégourié-Gonnard37ff1402015-09-04 14:21:07 +02005 * SPDX-License-Identifier: Apache-2.0
6 *
7 * Licensed under the Apache License, Version 2.0 (the "License"); you may
8 * not use this file except in compliance with the License.
9 * You may obtain a copy of the License at
10 *
11 * http://www.apache.org/licenses/LICENSE-2.0
12 *
13 * Unless required by applicable law or agreed to in writing, software
14 * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
15 * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16 * See the License for the specific language governing permissions and
17 * limitations under the License.
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +010018 */
19
20/*
21 * References:
22 *
Xiaokang Qian669c7c32023-04-10 07:36:04 +000023 * SEC1 https://www.secg.org/sec1-v2.pdf
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +010024 * GECC = Guide to Elliptic Curve Cryptography - Hankerson, Menezes, Vanstone
Manuel Pégourié-Gonnard62aad142012-11-10 00:27:12 +010025 * FIPS 186-3 http://csrc.nist.gov/publications/fips/fips186-3/fips_186-3.pdf
Manuel Pégourié-Gonnard1a967282013-02-09 17:03:58 +010026 * RFC 4492 for the related TLS structures and constants
Xiaokang Qian50fe3632023-04-12 06:08:45 +000027 * - https://www.rfc-editor.org/rfc/rfc4492
Nicholas Wilson08f3ef12015-11-10 13:10:01 +000028 * RFC 7748 for the Curve448 and Curve25519 curve definitions
Xiaokang Qian50fe3632023-04-12 06:08:45 +000029 * - https://www.rfc-editor.org/rfc/rfc7748
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +020030 *
Xiaokang Qian50fe3632023-04-12 06:08:45 +000031 * [Curve25519] https://cr.yp.to/ecdh/curve25519-20060209.pdf
Manuel Pégourié-Gonnardfe0af402013-12-04 18:14:55 +010032 *
Manuel Pégourié-Gonnard998930a2015-04-03 13:48:06 +020033 * [2] CORON, Jean-S'ebastien. Resistance against differential power analysis
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +020034 * for elliptic curve cryptosystems. In : Cryptographic Hardware and
35 * Embedded Systems. Springer Berlin Heidelberg, 1999. p. 292-302.
36 * <http://link.springer.com/chapter/10.1007/3-540-48059-5_25>
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +010037 *
Manuel Pégourié-Gonnard998930a2015-04-03 13:48:06 +020038 * [3] HEDABOU, Mustapha, PINEL, Pierre, et B'EN'ETEAU, Lucien. A comb method to
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +010039 * render ECC resistant against Side Channel Attacks. IACR Cryptology
40 * ePrint Archive, 2004, vol. 2004, p. 342.
41 * <http://eprint.iacr.org/2004/342.pdf>
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +010042 */
43
Gilles Peskinedb09ef62020-06-03 01:43:33 +020044#include "common.h"
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +010045
Andrzej Kurekc470b6b2019-01-31 08:20:20 -050046/**
47 * \brief Function level alternative implementation.
48 *
49 * The MBEDTLS_ECP_INTERNAL_ALT macro enables alternative implementations to
50 * replace certain functions in this module. The alternative implementations are
51 * typically hardware accelerators and need to activate the hardware before the
52 * computation starts and deactivate it after it finishes. The
53 * mbedtls_internal_ecp_init() and mbedtls_internal_ecp_free() functions serve
54 * this purpose.
55 *
56 * To preserve the correct functionality the following conditions must hold:
57 *
58 * - The alternative implementation must be activated by
59 * mbedtls_internal_ecp_init() before any of the replaceable functions is
60 * called.
61 * - mbedtls_internal_ecp_free() must \b only be called when the alternative
62 * implementation is activated.
63 * - mbedtls_internal_ecp_init() must \b not be called when the alternative
64 * implementation is activated.
65 * - Public functions must not return while the alternative implementation is
66 * activated.
67 * - Replaceable functions are guarded by \c MBEDTLS_ECP_XXX_ALT macros and
68 * before calling them an \code if( mbedtls_internal_ecp_grp_capable( grp ) )
69 * \endcode ensures that the alternative implementation supports the current
70 * group.
71 */
72#if defined(MBEDTLS_ECP_INTERNAL_ALT)
73#endif
74
Valerio Settifd122f42023-04-05 18:15:32 +020075#if defined(MBEDTLS_ECP_LIGHT)
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +010076
Manuel Pégourié-Gonnard7f809972015-03-09 17:05:11 +000077#include "mbedtls/ecp.h"
Janos Follath430d3372016-11-03 14:25:37 +000078#include "mbedtls/threading.h"
Andres Amaya Garcia1f6301b2018-04-17 09:51:09 -050079#include "mbedtls/platform_util.h"
Janos Follath24eed8d2019-11-22 13:21:35 +000080#include "mbedtls/error.h"
Paul Bakker6e339b52013-07-03 13:37:05 +020081
Janos Follath8c70e812021-06-24 14:48:38 +010082#include "bn_mul.h"
Gabor Mezei2a7bcaf2023-07-06 10:37:51 +020083#include "ecp_invasive.h"
Gilles Peskine80ba8502021-04-03 20:36:37 +020084
Rich Evans00ab4702015-02-06 13:43:58 +000085#include <string.h>
86
Janos Follathb0697532016-08-18 12:38:46 +010087#if !defined(MBEDTLS_ECP_ALT)
88
Manuel Pégourié-Gonnard7f809972015-03-09 17:05:11 +000089#include "mbedtls/platform.h"
Paul Bakker6e339b52013-07-03 13:37:05 +020090
Gilles Peskine6a2fb612021-05-24 22:25:04 +020091#include "ecp_internal_alt.h"
Janos Follathb0697532016-08-18 12:38:46 +010092
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +020093#if defined(MBEDTLS_SELF_TEST)
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +010094/*
Manuel Pégourié-Gonnard91814812013-11-21 20:23:55 +010095 * Counts of point addition and doubling, and field multiplications.
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +020096 * Used to test resistance of point multiplication to simple timing attacks.
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +010097 */
Valerio Settifd122f42023-04-05 18:15:32 +020098#if defined(MBEDTLS_ECP_C)
99static unsigned long add_count, dbl_count;
100#endif /* MBEDTLS_ECP_C */
101static unsigned long mul_count;
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +0100102#endif
103
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +0200104#if defined(MBEDTLS_ECP_RESTARTABLE)
Manuel Pégourié-Gonnard054433c2017-03-22 11:18:33 +0100105/*
106 * Maximum number of "basic operations" to be done in a row.
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +0200107 *
108 * Default value 0 means that ECC operations will not yield.
109 * Note that regardless of the value of ecp_max_ops, always at
110 * least one step is performed before yielding.
111 *
112 * Setting ecp_max_ops=1 can be suitable for testing purposes
113 * as it will interrupt computation at all possible points.
Manuel Pégourié-Gonnard054433c2017-03-22 11:18:33 +0100114 */
115static unsigned ecp_max_ops = 0;
116
117/*
118 * Set ecp_max_ops
119 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100120void mbedtls_ecp_set_max_ops(unsigned max_ops)
Manuel Pégourié-Gonnard054433c2017-03-22 11:18:33 +0100121{
122 ecp_max_ops = max_ops;
123}
Manuel Pégourié-Gonnard510d5ca2017-03-08 11:41:47 +0100124
125/*
Manuel Pégourié-Gonnarda0c5bcc2017-04-21 11:33:57 +0200126 * Check if restart is enabled
127 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100128int mbedtls_ecp_restart_is_enabled(void)
Manuel Pégourié-Gonnarda0c5bcc2017-04-21 11:33:57 +0200129{
Gilles Peskine449bd832023-01-11 14:50:10 +0100130 return ecp_max_ops != 0;
Manuel Pégourié-Gonnarda0c5bcc2017-04-21 11:33:57 +0200131}
132
133/*
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200134 * Restart sub-context for ecp_mul_comb()
Manuel Pégourié-Gonnard510d5ca2017-03-08 11:41:47 +0100135 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100136struct mbedtls_ecp_restart_mul {
Manuel Pégourié-Gonnard8962ddb2017-03-14 12:11:21 +0100137 mbedtls_ecp_point R; /* current intermediate result */
Manuel Pégourié-Gonnardc5d844b2017-03-15 13:06:28 +0100138 size_t i; /* current index in various loops, 0 outside */
Manuel Pégourié-Gonnardc9c0aa62017-03-16 14:53:26 +0100139 mbedtls_ecp_point *T; /* table for precomputed points */
140 unsigned char T_size; /* number of points in table T */
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +0200141 enum { /* what were we doing last time we returned? */
142 ecp_rsm_init = 0, /* nothing so far, dummy initial state */
143 ecp_rsm_pre_dbl, /* precompute 2^n multiples */
Manuel Pégourié-Gonnard45fd0162017-03-22 08:24:42 +0100144 ecp_rsm_pre_norm_dbl, /* normalize precomputed 2^n multiples */
145 ecp_rsm_pre_add, /* precompute remaining points by adding */
146 ecp_rsm_pre_norm_add, /* normalize all precomputed points */
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +0200147 ecp_rsm_comb_core, /* ecp_mul_comb_core() */
Manuel Pégourié-Gonnard45fd0162017-03-22 08:24:42 +0100148 ecp_rsm_final_norm, /* do the final normalization */
Manuel Pégourié-Gonnard2fad7ae2017-03-14 13:13:13 +0100149 } state;
Manuel Pégourié-Gonnard77af79a2017-03-14 10:58:00 +0100150};
Manuel Pégourié-Gonnard510d5ca2017-03-08 11:41:47 +0100151
152/*
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200153 * Init restart_mul sub-context
Manuel Pégourié-Gonnard510d5ca2017-03-08 11:41:47 +0100154 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100155static void ecp_restart_rsm_init(mbedtls_ecp_restart_mul_ctx *ctx)
Manuel Pégourié-Gonnard77af79a2017-03-14 10:58:00 +0100156{
Gilles Peskine449bd832023-01-11 14:50:10 +0100157 mbedtls_ecp_point_init(&ctx->R);
Manuel Pégourié-Gonnard5bd38b12017-08-23 16:55:59 +0200158 ctx->i = 0;
159 ctx->T = NULL;
160 ctx->T_size = 0;
161 ctx->state = ecp_rsm_init;
Manuel Pégourié-Gonnard77af79a2017-03-14 10:58:00 +0100162}
163
164/*
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200165 * Free the components of a restart_mul sub-context
Manuel Pégourié-Gonnard77af79a2017-03-14 10:58:00 +0100166 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100167static void ecp_restart_rsm_free(mbedtls_ecp_restart_mul_ctx *ctx)
Manuel Pégourié-Gonnard77af79a2017-03-14 10:58:00 +0100168{
Manuel Pégourié-Gonnardc9c0aa62017-03-16 14:53:26 +0100169 unsigned char i;
170
Gilles Peskine449bd832023-01-11 14:50:10 +0100171 if (ctx == NULL) {
Manuel Pégourié-Gonnard77af79a2017-03-14 10:58:00 +0100172 return;
Manuel Pégourié-Gonnardc9c0aa62017-03-16 14:53:26 +0100173 }
174
Gilles Peskine449bd832023-01-11 14:50:10 +0100175 mbedtls_ecp_point_free(&ctx->R);
176
177 if (ctx->T != NULL) {
178 for (i = 0; i < ctx->T_size; i++) {
179 mbedtls_ecp_point_free(ctx->T + i);
180 }
181 mbedtls_free(ctx->T);
182 }
183
184 ecp_restart_rsm_init(ctx);
Manuel Pégourié-Gonnard77af79a2017-03-14 10:58:00 +0100185}
Manuel Pégourié-Gonnard2fad7ae2017-03-14 13:13:13 +0100186
187/*
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200188 * Restart context for ecp_muladd()
189 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100190struct mbedtls_ecp_restart_muladd {
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +0200191 mbedtls_ecp_point mP; /* mP value */
192 mbedtls_ecp_point R; /* R intermediate result */
193 enum { /* what should we do next? */
194 ecp_rsma_mul1 = 0, /* first multiplication */
195 ecp_rsma_mul2, /* second multiplication */
196 ecp_rsma_add, /* addition */
197 ecp_rsma_norm, /* normalization */
198 } state;
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200199};
200
201/*
202 * Init restart_muladd sub-context
203 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100204static void ecp_restart_ma_init(mbedtls_ecp_restart_muladd_ctx *ctx)
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200205{
Gilles Peskine449bd832023-01-11 14:50:10 +0100206 mbedtls_ecp_point_init(&ctx->mP);
207 mbedtls_ecp_point_init(&ctx->R);
Manuel Pégourié-Gonnard5bd38b12017-08-23 16:55:59 +0200208 ctx->state = ecp_rsma_mul1;
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200209}
210
211/*
212 * Free the components of a restart_muladd sub-context
213 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100214static void ecp_restart_ma_free(mbedtls_ecp_restart_muladd_ctx *ctx)
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200215{
Gilles Peskine449bd832023-01-11 14:50:10 +0100216 if (ctx == NULL) {
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200217 return;
Gilles Peskine449bd832023-01-11 14:50:10 +0100218 }
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200219
Gilles Peskine449bd832023-01-11 14:50:10 +0100220 mbedtls_ecp_point_free(&ctx->mP);
221 mbedtls_ecp_point_free(&ctx->R);
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +0200222
Gilles Peskine449bd832023-01-11 14:50:10 +0100223 ecp_restart_ma_init(ctx);
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200224}
225
226/*
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +0200227 * Initialize a restart context
228 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100229void mbedtls_ecp_restart_init(mbedtls_ecp_restart_ctx *ctx)
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +0200230{
Manuel Pégourié-Gonnard5bd38b12017-08-23 16:55:59 +0200231 ctx->ops_done = 0;
232 ctx->depth = 0;
233 ctx->rsm = NULL;
234 ctx->ma = NULL;
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +0200235}
236
237/*
238 * Free the components of a restart context
239 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100240void mbedtls_ecp_restart_free(mbedtls_ecp_restart_ctx *ctx)
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +0200241{
Gilles Peskine449bd832023-01-11 14:50:10 +0100242 if (ctx == NULL) {
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +0200243 return;
Gilles Peskine449bd832023-01-11 14:50:10 +0100244 }
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +0200245
Gilles Peskine449bd832023-01-11 14:50:10 +0100246 ecp_restart_rsm_free(ctx->rsm);
247 mbedtls_free(ctx->rsm);
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +0200248
Gilles Peskine449bd832023-01-11 14:50:10 +0100249 ecp_restart_ma_free(ctx->ma);
250 mbedtls_free(ctx->ma);
Manuel Pégourié-Gonnard5bd38b12017-08-23 16:55:59 +0200251
Gilles Peskine449bd832023-01-11 14:50:10 +0100252 mbedtls_ecp_restart_init(ctx);
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +0200253}
254
255/*
Manuel Pégourié-Gonnard2fad7ae2017-03-14 13:13:13 +0100256 * Check if we can do the next step
257 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100258int mbedtls_ecp_check_budget(const mbedtls_ecp_group *grp,
259 mbedtls_ecp_restart_ctx *rs_ctx,
260 unsigned ops)
Manuel Pégourié-Gonnard2fad7ae2017-03-14 13:13:13 +0100261{
Gilles Peskine449bd832023-01-11 14:50:10 +0100262 if (rs_ctx != NULL && ecp_max_ops != 0) {
Manuel Pégourié-Gonnarde6854492017-03-20 14:35:19 +0100263 /* scale depending on curve size: the chosen reference is 256-bit,
264 * and multiplication is quadratic. Round to the closest integer. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100265 if (grp->pbits >= 512) {
Manuel Pégourié-Gonnarde6854492017-03-20 14:35:19 +0100266 ops *= 4;
Gilles Peskine449bd832023-01-11 14:50:10 +0100267 } else if (grp->pbits >= 384) {
Manuel Pégourié-Gonnarde6854492017-03-20 14:35:19 +0100268 ops *= 2;
Gilles Peskine449bd832023-01-11 14:50:10 +0100269 }
Manuel Pégourié-Gonnarde6854492017-03-20 14:35:19 +0100270
Hanno Beckerb10c6602018-10-26 13:50:13 +0100271 /* Avoid infinite loops: always allow first step.
272 * Because of that, however, it's not generally true
273 * that ops_done <= ecp_max_ops, so the check
274 * ops_done > ecp_max_ops below is mandatory. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100275 if ((rs_ctx->ops_done != 0) &&
276 (rs_ctx->ops_done > ecp_max_ops ||
277 ops > ecp_max_ops - rs_ctx->ops_done)) {
278 return MBEDTLS_ERR_ECP_IN_PROGRESS;
Hanno Beckerb10c6602018-10-26 13:50:13 +0100279 }
Manuel Pégourié-Gonnard2fad7ae2017-03-14 13:13:13 +0100280
Manuel Pégourié-Gonnarde6854492017-03-20 14:35:19 +0100281 /* update running count */
Manuel Pégourié-Gonnard646393b2017-04-20 10:03:45 +0200282 rs_ctx->ops_done += ops;
Manuel Pégourié-Gonnard2fad7ae2017-03-14 13:13:13 +0100283 }
284
Gilles Peskine449bd832023-01-11 14:50:10 +0100285 return 0;
Manuel Pégourié-Gonnard2fad7ae2017-03-14 13:13:13 +0100286}
287
Manuel Pégourié-Gonnarddb4a8eb2017-08-23 18:18:22 +0200288/* Call this when entering a function that needs its own sub-context */
Gilles Peskine449bd832023-01-11 14:50:10 +0100289#define ECP_RS_ENTER(SUB) do { \
290 /* reset ops count for this call if top-level */ \
291 if (rs_ctx != NULL && rs_ctx->depth++ == 0) \
Manuel Pégourié-Gonnarda58e0112018-10-16 10:42:47 +0200292 rs_ctx->ops_done = 0; \
293 \
Gilles Peskine449bd832023-01-11 14:50:10 +0100294 /* set up our own sub-context if needed */ \
295 if (mbedtls_ecp_restart_is_enabled() && \
296 rs_ctx != NULL && rs_ctx->SUB == NULL) \
297 { \
298 rs_ctx->SUB = mbedtls_calloc(1, sizeof(*rs_ctx->SUB)); \
299 if (rs_ctx->SUB == NULL) \
300 return MBEDTLS_ERR_ECP_ALLOC_FAILED; \
301 \
302 ecp_restart_## SUB ##_init(rs_ctx->SUB); \
303 } \
304} while (0)
Manuel Pégourié-Gonnarddb4a8eb2017-08-23 18:18:22 +0200305
306/* Call this when leaving a function that needs its own sub-context */
Gilles Peskine449bd832023-01-11 14:50:10 +0100307#define ECP_RS_LEAVE(SUB) do { \
308 /* clear our sub-context when not in progress (done or error) */ \
309 if (rs_ctx != NULL && rs_ctx->SUB != NULL && \
310 ret != MBEDTLS_ERR_ECP_IN_PROGRESS) \
311 { \
312 ecp_restart_## SUB ##_free(rs_ctx->SUB); \
313 mbedtls_free(rs_ctx->SUB); \
314 rs_ctx->SUB = NULL; \
315 } \
Manuel Pégourié-Gonnarda58e0112018-10-16 10:42:47 +0200316 \
Gilles Peskine449bd832023-01-11 14:50:10 +0100317 if (rs_ctx != NULL) \
Manuel Pégourié-Gonnarda58e0112018-10-16 10:42:47 +0200318 rs_ctx->depth--; \
Gilles Peskine449bd832023-01-11 14:50:10 +0100319} while (0)
Manuel Pégourié-Gonnarddb4a8eb2017-08-23 18:18:22 +0200320
321#else /* MBEDTLS_ECP_RESTARTABLE */
322
Gilles Peskine449bd832023-01-11 14:50:10 +0100323#define ECP_RS_ENTER(sub) (void) rs_ctx;
324#define ECP_RS_LEAVE(sub) (void) rs_ctx;
Manuel Pégourié-Gonnarddb4a8eb2017-08-23 18:18:22 +0200325
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +0200326#endif /* MBEDTLS_ECP_RESTARTABLE */
Manuel Pégourié-Gonnard054433c2017-03-22 11:18:33 +0100327
Valerio Settifd122f42023-04-05 18:15:32 +0200328#if defined(MBEDTLS_ECP_C)
Gilles Peskine449bd832023-01-11 14:50:10 +0100329static void mpi_init_many(mbedtls_mpi *arr, size_t size)
Hanno Becker466df6e2022-01-10 11:16:51 +0000330{
Gilles Peskine449bd832023-01-11 14:50:10 +0100331 while (size--) {
332 mbedtls_mpi_init(arr++);
333 }
Hanno Becker466df6e2022-01-10 11:16:51 +0000334}
335
Gilles Peskine449bd832023-01-11 14:50:10 +0100336static void mpi_free_many(mbedtls_mpi *arr, size_t size)
Hanno Becker466df6e2022-01-10 11:16:51 +0000337{
Gilles Peskine449bd832023-01-11 14:50:10 +0100338 while (size--) {
339 mbedtls_mpi_free(arr++);
340 }
Hanno Becker466df6e2022-01-10 11:16:51 +0000341}
Valerio Settifd122f42023-04-05 18:15:32 +0200342#endif /* MBEDTLS_ECP_C */
Hanno Becker466df6e2022-01-10 11:16:51 +0000343
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +0100344/*
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200345 * List of supported curves:
346 * - internal ID
Christoph M. Wintersteigercb310732019-02-15 15:50:38 +0000347 * - TLS NamedCurve ID (RFC 4492 sec. 5.1.1, RFC 7071 sec. 2, RFC 8446 sec. 4.2.7)
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200348 * - size in bits
Manuel Pégourié-Gonnard8195c1a2013-10-07 19:40:41 +0200349 * - readable name
Gergely Budaie40c4692014-01-22 11:22:20 +0100350 *
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100351 * Curves are listed in order: largest curves first, and for a given size,
Gilles Peskineae270bf2021-06-02 00:05:29 +0200352 * fastest curves first.
Manuel Pégourié-Gonnard88db5da2015-06-15 14:34:59 +0200353 *
Gilles Peskineae270bf2021-06-02 00:05:29 +0200354 * Reminder: update profiles in x509_crt.c and ssl_tls.c when adding a new curve!
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200355 */
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200356static const mbedtls_ecp_curve_info ecp_supported_curves[] =
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200357{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200358#if defined(MBEDTLS_ECP_DP_SECP521R1_ENABLED)
359 { MBEDTLS_ECP_DP_SECP521R1, 25, 521, "secp521r1" },
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200360#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200361#if defined(MBEDTLS_ECP_DP_BP512R1_ENABLED)
362 { MBEDTLS_ECP_DP_BP512R1, 28, 512, "brainpoolP512r1" },
Gergely Budaie40c4692014-01-22 11:22:20 +0100363#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200364#if defined(MBEDTLS_ECP_DP_SECP384R1_ENABLED)
365 { MBEDTLS_ECP_DP_SECP384R1, 24, 384, "secp384r1" },
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200366#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200367#if defined(MBEDTLS_ECP_DP_BP384R1_ENABLED)
368 { MBEDTLS_ECP_DP_BP384R1, 27, 384, "brainpoolP384r1" },
Gergely Budaie40c4692014-01-22 11:22:20 +0100369#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200370#if defined(MBEDTLS_ECP_DP_SECP256R1_ENABLED)
371 { MBEDTLS_ECP_DP_SECP256R1, 23, 256, "secp256r1" },
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200372#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200373#if defined(MBEDTLS_ECP_DP_SECP256K1_ENABLED)
374 { MBEDTLS_ECP_DP_SECP256K1, 22, 256, "secp256k1" },
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100375#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200376#if defined(MBEDTLS_ECP_DP_BP256R1_ENABLED)
377 { MBEDTLS_ECP_DP_BP256R1, 26, 256, "brainpoolP256r1" },
Gergely Budaie40c4692014-01-22 11:22:20 +0100378#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200379#if defined(MBEDTLS_ECP_DP_SECP224R1_ENABLED)
380 { MBEDTLS_ECP_DP_SECP224R1, 21, 224, "secp224r1" },
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200381#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200382#if defined(MBEDTLS_ECP_DP_SECP224K1_ENABLED)
383 { MBEDTLS_ECP_DP_SECP224K1, 20, 224, "secp224k1" },
Manuel Pégourié-Gonnard9bcff392014-01-10 18:26:48 +0100384#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200385#if defined(MBEDTLS_ECP_DP_SECP192R1_ENABLED)
386 { MBEDTLS_ECP_DP_SECP192R1, 19, 192, "secp192r1" },
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100387#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200388#if defined(MBEDTLS_ECP_DP_SECP192K1_ENABLED)
389 { MBEDTLS_ECP_DP_SECP192K1, 18, 192, "secp192k1" },
Manuel Pégourié-Gonnard9bcff392014-01-10 18:26:48 +0100390#endif
Gilles Peskine360e2c42020-07-24 02:03:20 +0200391#if defined(MBEDTLS_ECP_DP_CURVE25519_ENABLED)
Christoph M. Wintersteiger86e36c42018-12-06 17:27:31 +0000392 { MBEDTLS_ECP_DP_CURVE25519, 29, 256, "x25519" },
Christoph M. Wintersteigerc9f737b2018-10-25 13:03:05 +0100393#endif
Gilles Peskine360e2c42020-07-24 02:03:20 +0200394#if defined(MBEDTLS_ECP_DP_CURVE448_ENABLED)
395 { MBEDTLS_ECP_DP_CURVE448, 30, 448, "x448" },
396#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200397 { MBEDTLS_ECP_DP_NONE, 0, 0, NULL },
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200398};
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100399
Gilles Peskine449bd832023-01-11 14:50:10 +0100400#define ECP_NB_CURVES sizeof(ecp_supported_curves) / \
401 sizeof(ecp_supported_curves[0])
Manuel Pégourié-Gonnardba782bb2014-07-08 13:31:34 +0200402
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200403static mbedtls_ecp_group_id ecp_supported_grp_id[ECP_NB_CURVES];
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200404
405/*
Manuel Pégourié-Gonnardda179e42013-09-18 15:31:24 +0200406 * List of supported curves and associated info
407 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100408const mbedtls_ecp_curve_info *mbedtls_ecp_curve_list(void)
Manuel Pégourié-Gonnardda179e42013-09-18 15:31:24 +0200409{
Gilles Peskine449bd832023-01-11 14:50:10 +0100410 return ecp_supported_curves;
Manuel Pégourié-Gonnardda179e42013-09-18 15:31:24 +0200411}
412
413/*
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100414 * List of supported curves, group ID only
415 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100416const mbedtls_ecp_group_id *mbedtls_ecp_grp_id_list(void)
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100417{
418 static int init_done = 0;
419
Gilles Peskine449bd832023-01-11 14:50:10 +0100420 if (!init_done) {
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100421 size_t i = 0;
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200422 const mbedtls_ecp_curve_info *curve_info;
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100423
Gilles Peskine449bd832023-01-11 14:50:10 +0100424 for (curve_info = mbedtls_ecp_curve_list();
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200425 curve_info->grp_id != MBEDTLS_ECP_DP_NONE;
Gilles Peskine449bd832023-01-11 14:50:10 +0100426 curve_info++) {
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100427 ecp_supported_grp_id[i++] = curve_info->grp_id;
428 }
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200429 ecp_supported_grp_id[i] = MBEDTLS_ECP_DP_NONE;
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100430
431 init_done = 1;
432 }
433
Gilles Peskine449bd832023-01-11 14:50:10 +0100434 return ecp_supported_grp_id;
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100435}
436
437/*
438 * Get the curve info for the internal identifier
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200439 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100440const mbedtls_ecp_curve_info *mbedtls_ecp_curve_info_from_grp_id(mbedtls_ecp_group_id grp_id)
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200441{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200442 const mbedtls_ecp_curve_info *curve_info;
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200443
Gilles Peskine449bd832023-01-11 14:50:10 +0100444 for (curve_info = mbedtls_ecp_curve_list();
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200445 curve_info->grp_id != MBEDTLS_ECP_DP_NONE;
Gilles Peskine449bd832023-01-11 14:50:10 +0100446 curve_info++) {
447 if (curve_info->grp_id == grp_id) {
448 return curve_info;
449 }
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200450 }
451
Gilles Peskine449bd832023-01-11 14:50:10 +0100452 return NULL;
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200453}
454
455/*
456 * Get the curve info from the TLS identifier
457 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100458const mbedtls_ecp_curve_info *mbedtls_ecp_curve_info_from_tls_id(uint16_t tls_id)
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200459{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200460 const mbedtls_ecp_curve_info *curve_info;
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200461
Gilles Peskine449bd832023-01-11 14:50:10 +0100462 for (curve_info = mbedtls_ecp_curve_list();
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200463 curve_info->grp_id != MBEDTLS_ECP_DP_NONE;
Gilles Peskine449bd832023-01-11 14:50:10 +0100464 curve_info++) {
465 if (curve_info->tls_id == tls_id) {
466 return curve_info;
467 }
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200468 }
469
Gilles Peskine449bd832023-01-11 14:50:10 +0100470 return NULL;
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200471}
472
473/*
Manuel Pégourié-Gonnard0267e3d2013-11-30 15:10:14 +0100474 * Get the curve info from the name
475 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100476const mbedtls_ecp_curve_info *mbedtls_ecp_curve_info_from_name(const char *name)
Manuel Pégourié-Gonnard0267e3d2013-11-30 15:10:14 +0100477{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200478 const mbedtls_ecp_curve_info *curve_info;
Manuel Pégourié-Gonnard0267e3d2013-11-30 15:10:14 +0100479
Gilles Peskine449bd832023-01-11 14:50:10 +0100480 if (name == NULL) {
481 return NULL;
Manuel Pégourié-Gonnard0267e3d2013-11-30 15:10:14 +0100482 }
483
Gilles Peskine449bd832023-01-11 14:50:10 +0100484 for (curve_info = mbedtls_ecp_curve_list();
485 curve_info->grp_id != MBEDTLS_ECP_DP_NONE;
486 curve_info++) {
487 if (strcmp(curve_info->name, name) == 0) {
488 return curve_info;
489 }
490 }
491
492 return NULL;
Manuel Pégourié-Gonnard0267e3d2013-11-30 15:10:14 +0100493}
494
495/*
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +0100496 * Get the type of a curve
Manuel Pégourié-Gonnard312d2e82013-12-04 11:08:01 +0100497 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100498mbedtls_ecp_curve_type mbedtls_ecp_get_type(const mbedtls_ecp_group *grp)
Manuel Pégourié-Gonnard312d2e82013-12-04 11:08:01 +0100499{
Gilles Peskine449bd832023-01-11 14:50:10 +0100500 if (grp->G.X.p == NULL) {
501 return MBEDTLS_ECP_TYPE_NONE;
502 }
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +0100503
Gilles Peskine449bd832023-01-11 14:50:10 +0100504 if (grp->G.Y.p == NULL) {
505 return MBEDTLS_ECP_TYPE_MONTGOMERY;
506 } else {
507 return MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS;
508 }
Manuel Pégourié-Gonnard312d2e82013-12-04 11:08:01 +0100509}
510
511/*
Manuel Pégourié-Gonnardb505c272012-11-05 17:27:54 +0100512 * Initialize (the components of) a point
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +0100513 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100514void mbedtls_ecp_point_init(mbedtls_ecp_point *pt)
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +0100515{
Gilles Peskine449bd832023-01-11 14:50:10 +0100516 mbedtls_mpi_init(&pt->X);
517 mbedtls_mpi_init(&pt->Y);
518 mbedtls_mpi_init(&pt->Z);
Manuel Pégourié-Gonnardb505c272012-11-05 17:27:54 +0100519}
520
521/*
522 * Initialize (the components of) a group
523 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100524void mbedtls_ecp_group_init(mbedtls_ecp_group *grp)
Manuel Pégourié-Gonnardb505c272012-11-05 17:27:54 +0100525{
Manuel Pégourié-Gonnard95e2eca2018-06-20 10:29:47 +0200526 grp->id = MBEDTLS_ECP_DP_NONE;
Gilles Peskine449bd832023-01-11 14:50:10 +0100527 mbedtls_mpi_init(&grp->P);
528 mbedtls_mpi_init(&grp->A);
529 mbedtls_mpi_init(&grp->B);
530 mbedtls_ecp_point_init(&grp->G);
531 mbedtls_mpi_init(&grp->N);
Manuel Pégourié-Gonnard5bd38b12017-08-23 16:55:59 +0200532 grp->pbits = 0;
533 grp->nbits = 0;
534 grp->h = 0;
535 grp->modp = NULL;
536 grp->t_pre = NULL;
537 grp->t_post = NULL;
538 grp->t_data = NULL;
539 grp->T = NULL;
540 grp->T_size = 0;
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +0100541}
542
543/*
Manuel Pégourié-Gonnardb8c6e0e2013-07-01 13:40:52 +0200544 * Initialize (the components of) a key pair
545 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100546void mbedtls_ecp_keypair_init(mbedtls_ecp_keypair *key)
Manuel Pégourié-Gonnardb8c6e0e2013-07-01 13:40:52 +0200547{
Gilles Peskine449bd832023-01-11 14:50:10 +0100548 mbedtls_ecp_group_init(&key->grp);
549 mbedtls_mpi_init(&key->d);
550 mbedtls_ecp_point_init(&key->Q);
Manuel Pégourié-Gonnardb8c6e0e2013-07-01 13:40:52 +0200551}
552
553/*
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100554 * Unallocate (the components of) a point
555 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100556void mbedtls_ecp_point_free(mbedtls_ecp_point *pt)
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100557{
Gilles Peskine449bd832023-01-11 14:50:10 +0100558 if (pt == NULL) {
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100559 return;
Gilles Peskine449bd832023-01-11 14:50:10 +0100560 }
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100561
Gilles Peskine449bd832023-01-11 14:50:10 +0100562 mbedtls_mpi_free(&(pt->X));
563 mbedtls_mpi_free(&(pt->Y));
564 mbedtls_mpi_free(&(pt->Z));
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100565}
566
567/*
kXuanba9cb762021-04-08 14:32:06 +0800568 * Check that the comb table (grp->T) is static initialized.
569 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100570static int ecp_group_is_static_comb_table(const mbedtls_ecp_group *grp)
571{
kXuanba9cb762021-04-08 14:32:06 +0800572#if MBEDTLS_ECP_FIXED_POINT_OPTIM == 1
573 return grp->T != NULL && grp->T_size == 0;
574#else
575 (void) grp;
576 return 0;
577#endif
578}
579
580/*
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100581 * Unallocate (the components of) a group
582 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100583void mbedtls_ecp_group_free(mbedtls_ecp_group *grp)
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100584{
Manuel Pégourié-Gonnard161ef962013-09-17 19:13:10 +0200585 size_t i;
586
Gilles Peskine449bd832023-01-11 14:50:10 +0100587 if (grp == NULL) {
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100588 return;
Manuel Pégourié-Gonnard1f82b042013-12-06 12:51:50 +0100589 }
Manuel Pégourié-Gonnardc9727702013-09-16 18:56:28 +0200590
Gilles Peskine449bd832023-01-11 14:50:10 +0100591 if (grp->h != 1) {
Gilles Peskine449bd832023-01-11 14:50:10 +0100592 mbedtls_mpi_free(&grp->A);
593 mbedtls_mpi_free(&grp->B);
594 mbedtls_ecp_point_free(&grp->G);
Janos Follathd8cb3d72023-07-31 12:54:59 +0100595
596#if !defined(MBEDTLS_ECP_WITH_MPI_UINT)
Xiaokang Qianb903f4e2023-07-20 05:51:53 +0000597 mbedtls_mpi_free(&grp->N);
Janos Follathd8cb3d72023-07-31 12:54:59 +0100598 mbedtls_mpi_free(&grp->P);
599#endif
Manuel Pégourié-Gonnard161ef962013-09-17 19:13:10 +0200600 }
601
Gilles Peskine449bd832023-01-11 14:50:10 +0100602 if (!ecp_group_is_static_comb_table(grp) && grp->T != NULL) {
603 for (i = 0; i < grp->T_size; i++) {
604 mbedtls_ecp_point_free(&grp->T[i]);
605 }
606 mbedtls_free(grp->T);
607 }
608
609 mbedtls_platform_zeroize(grp, sizeof(mbedtls_ecp_group));
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100610}
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +0100611
Manuel Pégourié-Gonnard883f3132012-11-02 09:40:25 +0100612/*
Manuel Pégourié-Gonnardb8c6e0e2013-07-01 13:40:52 +0200613 * Unallocate (the components of) a key pair
614 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100615void mbedtls_ecp_keypair_free(mbedtls_ecp_keypair *key)
Manuel Pégourié-Gonnardb8c6e0e2013-07-01 13:40:52 +0200616{
Gilles Peskine449bd832023-01-11 14:50:10 +0100617 if (key == NULL) {
Manuel Pégourié-Gonnardb8c6e0e2013-07-01 13:40:52 +0200618 return;
Gilles Peskine449bd832023-01-11 14:50:10 +0100619 }
Manuel Pégourié-Gonnardb8c6e0e2013-07-01 13:40:52 +0200620
Gilles Peskine449bd832023-01-11 14:50:10 +0100621 mbedtls_ecp_group_free(&key->grp);
622 mbedtls_mpi_free(&key->d);
623 mbedtls_ecp_point_free(&key->Q);
Manuel Pégourié-Gonnardb8c6e0e2013-07-01 13:40:52 +0200624}
625
626/*
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200627 * Copy the contents of a point
628 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100629int mbedtls_ecp_copy(mbedtls_ecp_point *P, const mbedtls_ecp_point *Q)
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200630{
Janos Follath24eed8d2019-11-22 13:21:35 +0000631 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +0100632 MBEDTLS_MPI_CHK(mbedtls_mpi_copy(&P->X, &Q->X));
633 MBEDTLS_MPI_CHK(mbedtls_mpi_copy(&P->Y, &Q->Y));
634 MBEDTLS_MPI_CHK(mbedtls_mpi_copy(&P->Z, &Q->Z));
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200635
636cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100637 return ret;
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200638}
639
640/*
641 * Copy the contents of a group object
642 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100643int mbedtls_ecp_group_copy(mbedtls_ecp_group *dst, const mbedtls_ecp_group *src)
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200644{
Gilles Peskine449bd832023-01-11 14:50:10 +0100645 return mbedtls_ecp_group_load(dst, src->id);
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200646}
647
648/*
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +0100649 * Set point to zero
650 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100651int mbedtls_ecp_set_zero(mbedtls_ecp_point *pt)
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +0100652{
Janos Follath24eed8d2019-11-22 13:21:35 +0000653 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +0100654 MBEDTLS_MPI_CHK(mbedtls_mpi_lset(&pt->X, 1));
655 MBEDTLS_MPI_CHK(mbedtls_mpi_lset(&pt->Y, 1));
656 MBEDTLS_MPI_CHK(mbedtls_mpi_lset(&pt->Z, 0));
Manuel Pégourié-Gonnard1c2782c2012-11-19 20:16:28 +0100657
658cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100659 return ret;
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +0100660}
661
662/*
Manuel Pégourié-Gonnard6545ca72013-01-26 16:05:22 +0100663 * Tell if a point is zero
664 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100665int mbedtls_ecp_is_zero(mbedtls_ecp_point *pt)
Manuel Pégourié-Gonnard6545ca72013-01-26 16:05:22 +0100666{
Gilles Peskine449bd832023-01-11 14:50:10 +0100667 return mbedtls_mpi_cmp_int(&pt->Z, 0) == 0;
Manuel Pégourié-Gonnard6545ca72013-01-26 16:05:22 +0100668}
669
670/*
Andrzej Kurekc470b6b2019-01-31 08:20:20 -0500671 * Compare two points lazily
Manuel Pégourié-Gonnard6029a852015-08-11 15:44:41 +0200672 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100673int mbedtls_ecp_point_cmp(const mbedtls_ecp_point *P,
674 const mbedtls_ecp_point *Q)
Manuel Pégourié-Gonnard6029a852015-08-11 15:44:41 +0200675{
Gilles Peskine449bd832023-01-11 14:50:10 +0100676 if (mbedtls_mpi_cmp_mpi(&P->X, &Q->X) == 0 &&
677 mbedtls_mpi_cmp_mpi(&P->Y, &Q->Y) == 0 &&
678 mbedtls_mpi_cmp_mpi(&P->Z, &Q->Z) == 0) {
679 return 0;
Manuel Pégourié-Gonnard6029a852015-08-11 15:44:41 +0200680 }
681
Gilles Peskine449bd832023-01-11 14:50:10 +0100682 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Manuel Pégourié-Gonnard6029a852015-08-11 15:44:41 +0200683}
684
685/*
Manuel Pégourié-Gonnard847395a2012-11-05 13:13:44 +0100686 * Import a non-zero point from ASCII strings
687 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100688int mbedtls_ecp_point_read_string(mbedtls_ecp_point *P, int radix,
689 const char *x, const char *y)
Manuel Pégourié-Gonnard847395a2012-11-05 13:13:44 +0100690{
Janos Follath24eed8d2019-11-22 13:21:35 +0000691 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +0100692 MBEDTLS_MPI_CHK(mbedtls_mpi_read_string(&P->X, radix, x));
693 MBEDTLS_MPI_CHK(mbedtls_mpi_read_string(&P->Y, radix, y));
694 MBEDTLS_MPI_CHK(mbedtls_mpi_lset(&P->Z, 1));
Manuel Pégourié-Gonnard847395a2012-11-05 13:13:44 +0100695
696cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100697 return ret;
Manuel Pégourié-Gonnard847395a2012-11-05 13:13:44 +0100698}
699
700/*
Janos Follath7caf8e42019-02-20 12:00:22 +0000701 * Export a point into unsigned binary data (SEC1 2.3.3 and RFC7748)
Manuel Pégourié-Gonnarde19feb52012-11-24 14:10:14 +0100702 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100703int mbedtls_ecp_point_write_binary(const mbedtls_ecp_group *grp,
704 const mbedtls_ecp_point *P,
705 int format, size_t *olen,
706 unsigned char *buf, size_t buflen)
Manuel Pégourié-Gonnarde19feb52012-11-24 14:10:14 +0100707{
Janos Follath28eb06d2019-02-26 10:53:34 +0000708 int ret = MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Manuel Pégourié-Gonnarde19feb52012-11-24 14:10:14 +0100709 size_t plen;
Gilles Peskine449bd832023-01-11 14:50:10 +0100710 if (format != MBEDTLS_ECP_PF_UNCOMPRESSED &&
711 format != MBEDTLS_ECP_PF_COMPRESSED) {
712 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
713 }
Manuel Pégourié-Gonnard37d218a2012-11-24 15:19:55 +0100714
Gilles Peskine449bd832023-01-11 14:50:10 +0100715 plen = mbedtls_mpi_size(&grp->P);
Manuel Pégourié-Gonnarde19feb52012-11-24 14:10:14 +0100716
Gilles Peskinee8c04fe2018-09-14 17:44:21 +0200717#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine59970052019-02-28 13:12:06 +0100718 (void) format; /* Montgomery curves always use the same point format */
Gilles Peskine449bd832023-01-11 14:50:10 +0100719 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_MONTGOMERY) {
Janos Follath7caf8e42019-02-20 12:00:22 +0000720 *olen = plen;
Gilles Peskine449bd832023-01-11 14:50:10 +0100721 if (buflen < *olen) {
722 return MBEDTLS_ERR_ECP_BUFFER_TOO_SMALL;
723 }
Manuel Pégourié-Gonnard37d218a2012-11-24 15:19:55 +0100724
Gilles Peskine449bd832023-01-11 14:50:10 +0100725 MBEDTLS_MPI_CHK(mbedtls_mpi_write_binary_le(&P->X, buf, plen));
Manuel Pégourié-Gonnard37d218a2012-11-24 15:19:55 +0100726 }
Janos Follath7caf8e42019-02-20 12:00:22 +0000727#endif
Gilles Peskinee8c04fe2018-09-14 17:44:21 +0200728#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +0100729 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
Janos Follath7caf8e42019-02-20 12:00:22 +0000730 /*
731 * Common case: P == 0
732 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100733 if (mbedtls_mpi_cmp_int(&P->Z, 0) == 0) {
734 if (buflen < 1) {
735 return MBEDTLS_ERR_ECP_BUFFER_TOO_SMALL;
736 }
Manuel Pégourié-Gonnard37d218a2012-11-24 15:19:55 +0100737
Janos Follath7caf8e42019-02-20 12:00:22 +0000738 buf[0] = 0x00;
739 *olen = 1;
Manuel Pégourié-Gonnard37d218a2012-11-24 15:19:55 +0100740
Gilles Peskine449bd832023-01-11 14:50:10 +0100741 return 0;
Janos Follath7caf8e42019-02-20 12:00:22 +0000742 }
743
Gilles Peskine449bd832023-01-11 14:50:10 +0100744 if (format == MBEDTLS_ECP_PF_UNCOMPRESSED) {
Janos Follath7caf8e42019-02-20 12:00:22 +0000745 *olen = 2 * plen + 1;
746
Gilles Peskine449bd832023-01-11 14:50:10 +0100747 if (buflen < *olen) {
748 return MBEDTLS_ERR_ECP_BUFFER_TOO_SMALL;
749 }
Janos Follath7caf8e42019-02-20 12:00:22 +0000750
751 buf[0] = 0x04;
Gilles Peskine449bd832023-01-11 14:50:10 +0100752 MBEDTLS_MPI_CHK(mbedtls_mpi_write_binary(&P->X, buf + 1, plen));
753 MBEDTLS_MPI_CHK(mbedtls_mpi_write_binary(&P->Y, buf + 1 + plen, plen));
754 } else if (format == MBEDTLS_ECP_PF_COMPRESSED) {
Janos Follath7caf8e42019-02-20 12:00:22 +0000755 *olen = plen + 1;
756
Gilles Peskine449bd832023-01-11 14:50:10 +0100757 if (buflen < *olen) {
758 return MBEDTLS_ERR_ECP_BUFFER_TOO_SMALL;
759 }
Janos Follath7caf8e42019-02-20 12:00:22 +0000760
Gilles Peskine449bd832023-01-11 14:50:10 +0100761 buf[0] = 0x02 + mbedtls_mpi_get_bit(&P->Y, 0);
762 MBEDTLS_MPI_CHK(mbedtls_mpi_write_binary(&P->X, buf + 1, plen));
Janos Follath7caf8e42019-02-20 12:00:22 +0000763 }
Manuel Pégourié-Gonnard37d218a2012-11-24 15:19:55 +0100764 }
Janos Follath7caf8e42019-02-20 12:00:22 +0000765#endif
Manuel Pégourié-Gonnarde19feb52012-11-24 14:10:14 +0100766
767cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100768 return ret;
Manuel Pégourié-Gonnarde19feb52012-11-24 14:10:14 +0100769}
770
Glenn Strauss2ff77112022-09-14 23:27:50 -0400771#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +0100772static int mbedtls_ecp_sw_derive_y(const mbedtls_ecp_group *grp,
773 const mbedtls_mpi *X,
774 mbedtls_mpi *Y,
775 int parity_bit);
Glenn Strauss2ff77112022-09-14 23:27:50 -0400776#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
777
Manuel Pégourié-Gonnarde19feb52012-11-24 14:10:14 +0100778/*
Janos Follath59b813c2019-02-13 10:44:06 +0000779 * Import a point from unsigned binary data (SEC1 2.3.4 and RFC7748)
Manuel Pégourié-Gonnard5e402d82012-11-24 16:19:42 +0100780 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100781int mbedtls_ecp_point_read_binary(const mbedtls_ecp_group *grp,
782 mbedtls_ecp_point *pt,
783 const unsigned char *buf, size_t ilen)
Manuel Pégourié-Gonnard5246ee52014-03-19 16:18:38 +0100784{
Janos Follath28eb06d2019-02-26 10:53:34 +0000785 int ret = MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Manuel Pégourié-Gonnard5e402d82012-11-24 16:19:42 +0100786 size_t plen;
Gilles Peskine449bd832023-01-11 14:50:10 +0100787 if (ilen < 1) {
788 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
789 }
Manuel Pégourié-Gonnard67dbe1e2014-07-08 13:09:24 +0200790
Gilles Peskine449bd832023-01-11 14:50:10 +0100791 plen = mbedtls_mpi_size(&grp->P);
Manuel Pégourié-Gonnard5e402d82012-11-24 16:19:42 +0100792
Gilles Peskinee8c04fe2018-09-14 17:44:21 +0200793#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +0100794 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_MONTGOMERY) {
795 if (plen != ilen) {
796 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
797 }
Manuel Pégourié-Gonnard5246ee52014-03-19 16:18:38 +0100798
Gilles Peskine449bd832023-01-11 14:50:10 +0100799 MBEDTLS_MPI_CHK(mbedtls_mpi_read_binary_le(&pt->X, buf, plen));
800 mbedtls_mpi_free(&pt->Y);
Manuel Pégourié-Gonnard5e402d82012-11-24 16:19:42 +0100801
Gilles Peskine449bd832023-01-11 14:50:10 +0100802 if (grp->id == MBEDTLS_ECP_DP_CURVE25519) {
Janos Follathffbd7e82019-02-25 11:35:20 +0000803 /* Set most significant bit to 0 as prescribed in RFC7748 §5 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100804 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(&pt->X, plen * 8 - 1, 0));
805 }
Janos Follath28eb06d2019-02-26 10:53:34 +0000806
Gilles Peskine449bd832023-01-11 14:50:10 +0100807 MBEDTLS_MPI_CHK(mbedtls_mpi_lset(&pt->Z, 1));
Janos Follath59b813c2019-02-13 10:44:06 +0000808 }
809#endif
Gilles Peskinee8c04fe2018-09-14 17:44:21 +0200810#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +0100811 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
812 if (buf[0] == 0x00) {
813 if (ilen == 1) {
814 return mbedtls_ecp_set_zero(pt);
815 } else {
816 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
817 }
Janos Follath59b813c2019-02-13 10:44:06 +0000818 }
819
Gilles Peskine449bd832023-01-11 14:50:10 +0100820 if (ilen < 1 + plen) {
821 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
822 }
Janos Follath59b813c2019-02-13 10:44:06 +0000823
Gilles Peskine449bd832023-01-11 14:50:10 +0100824 MBEDTLS_MPI_CHK(mbedtls_mpi_read_binary(&pt->X, buf + 1, plen));
825 MBEDTLS_MPI_CHK(mbedtls_mpi_lset(&pt->Z, 1));
Glenn Strauss2ff77112022-09-14 23:27:50 -0400826
Gilles Peskine449bd832023-01-11 14:50:10 +0100827 if (buf[0] == 0x04) {
Glenn Strauss2ff77112022-09-14 23:27:50 -0400828 /* format == MBEDTLS_ECP_PF_UNCOMPRESSED */
Gilles Peskine449bd832023-01-11 14:50:10 +0100829 if (ilen != 1 + plen * 2) {
830 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
831 }
832 return mbedtls_mpi_read_binary(&pt->Y, buf + 1 + plen, plen);
833 } else if (buf[0] == 0x02 || buf[0] == 0x03) {
Glenn Strauss2ff77112022-09-14 23:27:50 -0400834 /* format == MBEDTLS_ECP_PF_COMPRESSED */
Gilles Peskine449bd832023-01-11 14:50:10 +0100835 if (ilen != 1 + plen) {
836 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
837 }
838 return mbedtls_ecp_sw_derive_y(grp, &pt->X, &pt->Y,
839 (buf[0] & 1));
840 } else {
841 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Glenn Strauss2ff77112022-09-14 23:27:50 -0400842 }
Janos Follath59b813c2019-02-13 10:44:06 +0000843 }
844#endif
Manuel Pégourié-Gonnard5e402d82012-11-24 16:19:42 +0100845
846cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100847 return ret;
Manuel Pégourié-Gonnard5e402d82012-11-24 16:19:42 +0100848}
849
850/*
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100851 * Import a point from a TLS ECPoint record (RFC 4492)
852 * struct {
853 * opaque point <1..2^8-1>;
854 * } ECPoint;
855 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100856int mbedtls_ecp_tls_read_point(const mbedtls_ecp_group *grp,
857 mbedtls_ecp_point *pt,
858 const unsigned char **buf, size_t buf_len)
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100859{
860 unsigned char data_len;
Manuel Pégourié-Gonnard98f51812013-02-10 13:38:29 +0100861 const unsigned char *buf_start;
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100862 /*
Manuel Pégourié-Gonnard67dbe1e2014-07-08 13:09:24 +0200863 * We must have at least two bytes (1 for length, at least one for data)
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100864 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100865 if (buf_len < 2) {
866 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
867 }
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100868
Manuel Pégourié-Gonnard98f51812013-02-10 13:38:29 +0100869 data_len = *(*buf)++;
Gilles Peskine449bd832023-01-11 14:50:10 +0100870 if (data_len < 1 || data_len > buf_len - 1) {
871 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
872 }
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100873
Manuel Pégourié-Gonnard98f51812013-02-10 13:38:29 +0100874 /*
875 * Save buffer start for read_binary and update buf
876 */
877 buf_start = *buf;
878 *buf += data_len;
879
Gilles Peskine449bd832023-01-11 14:50:10 +0100880 return mbedtls_ecp_point_read_binary(grp, pt, buf_start, data_len);
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100881}
882
883/*
884 * Export a point as a TLS ECPoint record (RFC 4492)
885 * struct {
886 * opaque point <1..2^8-1>;
887 * } ECPoint;
888 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100889int mbedtls_ecp_tls_write_point(const mbedtls_ecp_group *grp, const mbedtls_ecp_point *pt,
890 int format, size_t *olen,
891 unsigned char *buf, size_t blen)
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100892{
Janos Follath24eed8d2019-11-22 13:21:35 +0000893 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +0100894 if (format != MBEDTLS_ECP_PF_UNCOMPRESSED &&
895 format != MBEDTLS_ECP_PF_COMPRESSED) {
896 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
897 }
Manuel Pégourié-Gonnard420f1eb2013-02-10 12:22:46 +0100898
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100899 /*
Manuel Pégourié-Gonnard420f1eb2013-02-10 12:22:46 +0100900 * buffer length must be at least one, for our length byte
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100901 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100902 if (blen < 1) {
903 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
904 }
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100905
Gilles Peskine449bd832023-01-11 14:50:10 +0100906 if ((ret = mbedtls_ecp_point_write_binary(grp, pt, format,
907 olen, buf + 1, blen - 1)) != 0) {
908 return ret;
909 }
Manuel Pégourié-Gonnard420f1eb2013-02-10 12:22:46 +0100910
911 /*
912 * write length to the first byte and update total length
913 */
Paul Bakkerb9cfaa02013-10-11 18:58:55 +0200914 buf[0] = (unsigned char) *olen;
Manuel Pégourié-Gonnard420f1eb2013-02-10 12:22:46 +0100915 ++*olen;
916
Gilles Peskine449bd832023-01-11 14:50:10 +0100917 return 0;
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100918}
919
920/*
Manuel Pégourié-Gonnard1a967282013-02-09 17:03:58 +0100921 * Set a group from an ECParameters record (RFC 4492)
922 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100923int mbedtls_ecp_tls_read_group(mbedtls_ecp_group *grp,
924 const unsigned char **buf, size_t len)
Andrzej Kurekc470b6b2019-01-31 08:20:20 -0500925{
Janos Follath24eed8d2019-11-22 13:21:35 +0000926 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Andrzej Kurekc470b6b2019-01-31 08:20:20 -0500927 mbedtls_ecp_group_id grp_id;
Gilles Peskine449bd832023-01-11 14:50:10 +0100928 if ((ret = mbedtls_ecp_tls_read_group_id(&grp_id, buf, len)) != 0) {
929 return ret;
930 }
Andrzej Kurekc470b6b2019-01-31 08:20:20 -0500931
Gilles Peskine449bd832023-01-11 14:50:10 +0100932 return mbedtls_ecp_group_load(grp, grp_id);
Andrzej Kurekc470b6b2019-01-31 08:20:20 -0500933}
934
935/*
936 * Read a group id from an ECParameters record (RFC 4492) and convert it to
937 * mbedtls_ecp_group_id.
938 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100939int mbedtls_ecp_tls_read_group_id(mbedtls_ecp_group_id *grp,
940 const unsigned char **buf, size_t len)
Manuel Pégourié-Gonnard1a967282013-02-09 17:03:58 +0100941{
Manuel Pégourié-Gonnardf24b4a72013-09-23 18:14:50 +0200942 uint16_t tls_id;
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200943 const mbedtls_ecp_curve_info *curve_info;
Manuel Pégourié-Gonnard1a967282013-02-09 17:03:58 +0100944 /*
945 * We expect at least three bytes (see below)
946 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100947 if (len < 3) {
948 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
949 }
Manuel Pégourié-Gonnard1a967282013-02-09 17:03:58 +0100950
951 /*
952 * First byte is curve_type; only named_curve is handled
953 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100954 if (*(*buf)++ != MBEDTLS_ECP_TLS_NAMED_CURVE) {
955 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
956 }
Manuel Pégourié-Gonnard1a967282013-02-09 17:03:58 +0100957
958 /*
Manuel Pégourié-Gonnardb3258872013-02-10 12:06:19 +0100959 * Next two bytes are the namedcurve value
Manuel Pégourié-Gonnard1a967282013-02-09 17:03:58 +0100960 */
Manuel Pégourié-Gonnardf24b4a72013-09-23 18:14:50 +0200961 tls_id = *(*buf)++;
962 tls_id <<= 8;
963 tls_id |= *(*buf)++;
964
Gilles Peskine449bd832023-01-11 14:50:10 +0100965 if ((curve_info = mbedtls_ecp_curve_info_from_tls_id(tls_id)) == NULL) {
966 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
967 }
Manuel Pégourié-Gonnardf24b4a72013-09-23 18:14:50 +0200968
Andrzej Kurekc470b6b2019-01-31 08:20:20 -0500969 *grp = curve_info->grp_id;
970
Gilles Peskine449bd832023-01-11 14:50:10 +0100971 return 0;
Manuel Pégourié-Gonnardb3258872013-02-10 12:06:19 +0100972}
973
974/*
975 * Write the ECParameters record corresponding to a group (RFC 4492)
976 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100977int mbedtls_ecp_tls_write_group(const mbedtls_ecp_group *grp, size_t *olen,
978 unsigned char *buf, size_t blen)
Manuel Pégourié-Gonnardb3258872013-02-10 12:06:19 +0100979{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200980 const mbedtls_ecp_curve_info *curve_info;
Gilles Peskine449bd832023-01-11 14:50:10 +0100981 if ((curve_info = mbedtls_ecp_curve_info_from_grp_id(grp->id)) == NULL) {
982 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
983 }
Manuel Pégourié-Gonnard70380392013-09-16 16:19:53 +0200984
Manuel Pégourié-Gonnardb3258872013-02-10 12:06:19 +0100985 /*
986 * We are going to write 3 bytes (see below)
987 */
988 *olen = 3;
Gilles Peskine449bd832023-01-11 14:50:10 +0100989 if (blen < *olen) {
990 return MBEDTLS_ERR_ECP_BUFFER_TOO_SMALL;
991 }
Manuel Pégourié-Gonnardb3258872013-02-10 12:06:19 +0100992
993 /*
994 * First byte is curve_type, always named_curve
995 */
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200996 *buf++ = MBEDTLS_ECP_TLS_NAMED_CURVE;
Manuel Pégourié-Gonnardb3258872013-02-10 12:06:19 +0100997
998 /*
999 * Next two bytes are the namedcurve value
1000 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001001 MBEDTLS_PUT_UINT16_BE(curve_info->tls_id, buf, 0);
Manuel Pégourié-Gonnardb3258872013-02-10 12:06:19 +01001002
Gilles Peskine449bd832023-01-11 14:50:10 +01001003 return 0;
Manuel Pégourié-Gonnarda5402fe2012-11-07 20:24:05 +01001004}
Manuel Pégourié-Gonnardab38b702012-11-05 17:34:55 +01001005
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +02001006/*
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001007 * Wrapper around fast quasi-modp functions, with fall-back to mbedtls_mpi_mod_mpi.
1008 * See the documentation of struct mbedtls_ecp_group.
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +02001009 *
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001010 * This function is in the critial loop for mbedtls_ecp_mul, so pay attention to perf.
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +02001011 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001012static int ecp_modp(mbedtls_mpi *N, const mbedtls_ecp_group *grp)
Manuel Pégourié-Gonnard70380392013-09-16 16:19:53 +02001013{
Janos Follath24eed8d2019-11-22 13:21:35 +00001014 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +02001015
Gilles Peskine449bd832023-01-11 14:50:10 +01001016 if (grp->modp == NULL) {
1017 return mbedtls_mpi_mod_mpi(N, N, &grp->P);
Manuel Pégourié-Gonnard70380392013-09-16 16:19:53 +02001018 }
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +02001019
Gilles Peskine449bd832023-01-11 14:50:10 +01001020 /* N->s < 0 is a much faster test, which fails only if N is 0 */
1021 if ((N->s < 0 && mbedtls_mpi_cmp_int(N, 0) != 0) ||
1022 mbedtls_mpi_bitlen(N) > 2 * grp->pbits) {
1023 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
1024 }
1025
1026 MBEDTLS_MPI_CHK(grp->modp(N));
Manuel Pégourié-Gonnard70380392013-09-16 16:19:53 +02001027
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +02001028 /* N->s < 0 is a much faster test, which fails only if N is 0 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001029 while (N->s < 0 && mbedtls_mpi_cmp_int(N, 0) != 0) {
1030 MBEDTLS_MPI_CHK(mbedtls_mpi_add_mpi(N, N, &grp->P));
1031 }
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +02001032
Gilles Peskine449bd832023-01-11 14:50:10 +01001033 while (mbedtls_mpi_cmp_mpi(N, &grp->P) >= 0) {
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +02001034 /* we known P, N and the result are positive */
Gilles Peskine449bd832023-01-11 14:50:10 +01001035 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_abs(N, N, &grp->P));
1036 }
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +02001037
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +02001038cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001039 return ret;
Manuel Pégourié-Gonnard70380392013-09-16 16:19:53 +02001040}
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +02001041
Manuel Pégourié-Gonnard847395a2012-11-05 13:13:44 +01001042/*
Manuel Pégourié-Gonnard47123252012-11-10 14:44:24 +01001043 * Fast mod-p functions expect their argument to be in the 0..p^2 range.
Manuel Pégourié-Gonnarddada4da2012-11-10 14:23:17 +01001044 *
Manuel Pégourié-Gonnard47123252012-11-10 14:44:24 +01001045 * In order to guarantee that, we need to ensure that operands of
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001046 * mbedtls_mpi_mul_mpi are in the 0..p range. So, after each operation we will
Manuel Pégourié-Gonnarddada4da2012-11-10 14:23:17 +01001047 * bring the result back to this range.
1048 *
Manuel Pégourié-Gonnard47123252012-11-10 14:44:24 +01001049 * The following macros are shortcuts for doing that.
Manuel Pégourié-Gonnarddada4da2012-11-10 14:23:17 +01001050 */
1051
1052/*
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001053 * Reduce a mbedtls_mpi mod p in-place, general case, to use after mbedtls_mpi_mul_mpi
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001054 */
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001055#if defined(MBEDTLS_SELF_TEST)
Manuel Pégourié-Gonnard91814812013-11-21 20:23:55 +01001056#define INC_MUL_COUNT mul_count++;
1057#else
1058#define INC_MUL_COUNT
1059#endif
1060
Gilles Peskine449bd832023-01-11 14:50:10 +01001061#define MOD_MUL(N) \
Hanno Becker1eeca412018-10-15 12:01:35 +01001062 do \
1063 { \
Gilles Peskine449bd832023-01-11 14:50:10 +01001064 MBEDTLS_MPI_CHK(ecp_modp(&(N), grp)); \
Hanno Becker1eeca412018-10-15 12:01:35 +01001065 INC_MUL_COUNT \
Gilles Peskine449bd832023-01-11 14:50:10 +01001066 } while (0)
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001067
Gilles Peskine449bd832023-01-11 14:50:10 +01001068static inline int mbedtls_mpi_mul_mod(const mbedtls_ecp_group *grp,
1069 mbedtls_mpi *X,
1070 const mbedtls_mpi *A,
1071 const mbedtls_mpi *B)
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001072{
Janos Follath24eed8d2019-11-22 13:21:35 +00001073 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +01001074 MBEDTLS_MPI_CHK(mbedtls_mpi_mul_mpi(X, A, B));
1075 MOD_MUL(*X);
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001076cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001077 return ret;
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001078}
1079
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001080/*
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001081 * Reduce a mbedtls_mpi mod p in-place, to use after mbedtls_mpi_sub_mpi
Manuel Pégourié-Gonnardc9e387c2013-10-17 17:15:35 +02001082 * N->s < 0 is a very fast test, which fails only if N is 0
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001083 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001084#define MOD_SUB(N) \
Hanno Beckerce29ae82022-01-04 04:55:11 +00001085 do { \
Gilles Peskine449bd832023-01-11 14:50:10 +01001086 while ((N)->s < 0 && mbedtls_mpi_cmp_int((N), 0) != 0) \
1087 MBEDTLS_MPI_CHK(mbedtls_mpi_add_mpi((N), (N), &grp->P)); \
1088 } while (0)
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001089
Gilles Peskine449bd832023-01-11 14:50:10 +01001090#if (defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED) && \
1091 !(defined(MBEDTLS_ECP_NO_FALLBACK) && \
1092 defined(MBEDTLS_ECP_DOUBLE_JAC_ALT) && \
1093 defined(MBEDTLS_ECP_ADD_MIXED_ALT))) || \
1094 (defined(MBEDTLS_ECP_MONTGOMERY_ENABLED) && \
1095 !(defined(MBEDTLS_ECP_NO_FALLBACK) && \
1096 defined(MBEDTLS_ECP_DOUBLE_ADD_MXZ_ALT)))
1097static inline int mbedtls_mpi_sub_mod(const mbedtls_ecp_group *grp,
1098 mbedtls_mpi *X,
1099 const mbedtls_mpi *A,
1100 const mbedtls_mpi *B)
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001101{
Janos Follath24eed8d2019-11-22 13:21:35 +00001102 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +01001103 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_mpi(X, A, B));
1104 MOD_SUB(X);
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001105cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001106 return ret;
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001107}
Steven Cooremane5388962021-03-01 14:04:53 +01001108#endif /* All functions referencing mbedtls_mpi_sub_mod() are alt-implemented without fallback */
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001109
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001110/*
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001111 * Reduce a mbedtls_mpi mod p in-place, to use after mbedtls_mpi_add_mpi and mbedtls_mpi_mul_int.
Manuel Pégourié-Gonnardc9e387c2013-10-17 17:15:35 +02001112 * We known P, N and the result are positive, so sub_abs is correct, and
1113 * a bit faster.
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001114 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001115#define MOD_ADD(N) \
1116 while (mbedtls_mpi_cmp_mpi((N), &grp->P) >= 0) \
1117 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_abs((N), (N), &grp->P))
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001118
Gilles Peskine449bd832023-01-11 14:50:10 +01001119static inline int mbedtls_mpi_add_mod(const mbedtls_ecp_group *grp,
1120 mbedtls_mpi *X,
1121 const mbedtls_mpi *A,
1122 const mbedtls_mpi *B)
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001123{
Janos Follath24eed8d2019-11-22 13:21:35 +00001124 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +01001125 MBEDTLS_MPI_CHK(mbedtls_mpi_add_mpi(X, A, B));
1126 MOD_ADD(X);
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001127cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001128 return ret;
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001129}
1130
Gilles Peskine449bd832023-01-11 14:50:10 +01001131static inline int mbedtls_mpi_mul_int_mod(const mbedtls_ecp_group *grp,
1132 mbedtls_mpi *X,
1133 const mbedtls_mpi *A,
1134 mbedtls_mpi_uint c)
Hanno Becker02b35bd2022-01-01 06:54:25 +00001135{
1136 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
1137
Gilles Peskine449bd832023-01-11 14:50:10 +01001138 MBEDTLS_MPI_CHK(mbedtls_mpi_mul_int(X, A, c));
1139 MOD_ADD(X);
Hanno Becker02b35bd2022-01-01 06:54:25 +00001140cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001141 return ret;
Hanno Becker02b35bd2022-01-01 06:54:25 +00001142}
1143
Gilles Peskine449bd832023-01-11 14:50:10 +01001144static inline int mbedtls_mpi_sub_int_mod(const mbedtls_ecp_group *grp,
1145 mbedtls_mpi *X,
1146 const mbedtls_mpi *A,
1147 mbedtls_mpi_uint c)
Hanno Beckerce29ae82022-01-04 04:55:11 +00001148{
1149 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
1150
Gilles Peskine449bd832023-01-11 14:50:10 +01001151 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_int(X, A, c));
1152 MOD_SUB(X);
Hanno Beckerce29ae82022-01-04 04:55:11 +00001153cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001154 return ret;
Hanno Beckerce29ae82022-01-04 04:55:11 +00001155}
1156
Gilles Peskine449bd832023-01-11 14:50:10 +01001157#define MPI_ECP_SUB_INT(X, A, c) \
1158 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_int_mod(grp, X, A, c))
Hanno Beckerce29ae82022-01-04 04:55:11 +00001159
Steven Cooremane5388962021-03-01 14:04:53 +01001160#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED) && \
Gilles Peskine449bd832023-01-11 14:50:10 +01001161 !(defined(MBEDTLS_ECP_NO_FALLBACK) && \
1162 defined(MBEDTLS_ECP_DOUBLE_JAC_ALT) && \
1163 defined(MBEDTLS_ECP_ADD_MIXED_ALT))
1164static inline int mbedtls_mpi_shift_l_mod(const mbedtls_ecp_group *grp,
1165 mbedtls_mpi *X,
1166 size_t count)
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001167{
Janos Follath24eed8d2019-11-22 13:21:35 +00001168 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +01001169 MBEDTLS_MPI_CHK(mbedtls_mpi_shift_l(X, count));
1170 MOD_ADD(X);
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001171cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001172 return ret;
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001173}
Gilles Peskine449bd832023-01-11 14:50:10 +01001174#endif \
1175 /* All functions referencing mbedtls_mpi_shift_l_mod() are alt-implemented without fallback */
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001176
Hanno Becker595616e2022-01-05 08:28:24 +00001177/*
1178 * Macro wrappers around ECP modular arithmetic
1179 *
1180 * Currently, these wrappers are defined via the bignum module.
1181 */
1182
Gilles Peskine449bd832023-01-11 14:50:10 +01001183#define MPI_ECP_ADD(X, A, B) \
1184 MBEDTLS_MPI_CHK(mbedtls_mpi_add_mod(grp, X, A, B))
Hanno Beckerce29ae82022-01-04 04:55:11 +00001185
Gilles Peskine449bd832023-01-11 14:50:10 +01001186#define MPI_ECP_SUB(X, A, B) \
1187 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_mod(grp, X, A, B))
Hanno Beckerce29ae82022-01-04 04:55:11 +00001188
Gilles Peskine449bd832023-01-11 14:50:10 +01001189#define MPI_ECP_MUL(X, A, B) \
1190 MBEDTLS_MPI_CHK(mbedtls_mpi_mul_mod(grp, X, A, B))
Hanno Beckerce29ae82022-01-04 04:55:11 +00001191
Gilles Peskine449bd832023-01-11 14:50:10 +01001192#define MPI_ECP_SQR(X, A) \
1193 MBEDTLS_MPI_CHK(mbedtls_mpi_mul_mod(grp, X, A, A))
Hanno Becker885ed402022-01-04 06:43:50 +00001194
Gilles Peskine449bd832023-01-11 14:50:10 +01001195#define MPI_ECP_MUL_INT(X, A, c) \
1196 MBEDTLS_MPI_CHK(mbedtls_mpi_mul_int_mod(grp, X, A, c))
Hanno Beckerce29ae82022-01-04 04:55:11 +00001197
Gilles Peskine449bd832023-01-11 14:50:10 +01001198#define MPI_ECP_INV(dst, src) \
1199 MBEDTLS_MPI_CHK(mbedtls_mpi_inv_mod((dst), (src), &grp->P))
Hanno Beckerce29ae82022-01-04 04:55:11 +00001200
Gilles Peskine449bd832023-01-11 14:50:10 +01001201#define MPI_ECP_MOV(X, A) \
1202 MBEDTLS_MPI_CHK(mbedtls_mpi_copy(X, A))
Hanno Beckerce29ae82022-01-04 04:55:11 +00001203
Gilles Peskine449bd832023-01-11 14:50:10 +01001204#define MPI_ECP_SHIFT_L(X, count) \
1205 MBEDTLS_MPI_CHK(mbedtls_mpi_shift_l_mod(grp, X, count))
Hanno Beckerce29ae82022-01-04 04:55:11 +00001206
Gilles Peskine449bd832023-01-11 14:50:10 +01001207#define MPI_ECP_LSET(X, c) \
1208 MBEDTLS_MPI_CHK(mbedtls_mpi_lset(X, c))
Hanno Becker595616e2022-01-05 08:28:24 +00001209
Gilles Peskine449bd832023-01-11 14:50:10 +01001210#define MPI_ECP_CMP_INT(X, c) \
1211 mbedtls_mpi_cmp_int(X, c)
Hanno Becker595616e2022-01-05 08:28:24 +00001212
Gilles Peskine449bd832023-01-11 14:50:10 +01001213#define MPI_ECP_CMP(X, Y) \
1214 mbedtls_mpi_cmp_mpi(X, Y)
Hanno Becker595616e2022-01-05 08:28:24 +00001215
1216/* Needs f_rng, p_rng to be defined. */
Gilles Peskine449bd832023-01-11 14:50:10 +01001217#define MPI_ECP_RAND(X) \
1218 MBEDTLS_MPI_CHK(mbedtls_mpi_random((X), 2, &grp->P, f_rng, p_rng))
Hanno Becker595616e2022-01-05 08:28:24 +00001219
1220/* Conditional negation
1221 * Needs grp and a temporary MPI tmp to be defined. */
Gilles Peskine449bd832023-01-11 14:50:10 +01001222#define MPI_ECP_COND_NEG(X, cond) \
Hanno Becker595616e2022-01-05 08:28:24 +00001223 do \
1224 { \
Gilles Peskine449bd832023-01-11 14:50:10 +01001225 unsigned char nonzero = mbedtls_mpi_cmp_int((X), 0) != 0; \
1226 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_mpi(&tmp, &grp->P, (X))); \
1227 MBEDTLS_MPI_CHK(mbedtls_mpi_safe_cond_assign((X), &tmp, \
1228 nonzero & cond)); \
1229 } while (0)
Hanno Becker595616e2022-01-05 08:28:24 +00001230
Gilles Peskine449bd832023-01-11 14:50:10 +01001231#define MPI_ECP_NEG(X) MPI_ECP_COND_NEG((X), 1)
Hanno Beckerc27a0e02022-01-06 05:56:34 +00001232
Gilles Peskine449bd832023-01-11 14:50:10 +01001233#define MPI_ECP_VALID(X) \
1234 ((X)->p != NULL)
Hanno Beckerc27a0e02022-01-06 05:56:34 +00001235
Gilles Peskine449bd832023-01-11 14:50:10 +01001236#define MPI_ECP_COND_ASSIGN(X, Y, cond) \
1237 MBEDTLS_MPI_CHK(mbedtls_mpi_safe_cond_assign((X), (Y), (cond)))
Hanno Beckerc27a0e02022-01-06 05:56:34 +00001238
Gilles Peskine449bd832023-01-11 14:50:10 +01001239#define MPI_ECP_COND_SWAP(X, Y, cond) \
1240 MBEDTLS_MPI_CHK(mbedtls_mpi_safe_cond_swap((X), (Y), (cond)))
Hanno Beckerc27a0e02022-01-06 05:56:34 +00001241
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02001242#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Glenn Straussefde9d52022-12-20 04:20:12 -05001243
Manuel Pégourié-Gonnard8b6d14b2022-12-20 10:02:52 +01001244/*
1245 * Computes the right-hand side of the Short Weierstrass equation
1246 * RHS = X^3 + A X + B
1247 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001248static int ecp_sw_rhs(const mbedtls_ecp_group *grp,
1249 mbedtls_mpi *rhs,
1250 const mbedtls_mpi *X)
Manuel Pégourié-Gonnard8b6d14b2022-12-20 10:02:52 +01001251{
1252 int ret;
1253
1254 /* Compute X^3 + A X + B as X (X^2 + A) + B */
Gilles Peskine449bd832023-01-11 14:50:10 +01001255 MPI_ECP_SQR(rhs, X);
Manuel Pégourié-Gonnard8b6d14b2022-12-20 10:02:52 +01001256
1257 /* Special case for A = -3 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001258 if (grp->A.p == NULL) {
1259 MPI_ECP_SUB_INT(rhs, rhs, 3);
1260 } else {
1261 MPI_ECP_ADD(rhs, rhs, &grp->A);
Manuel Pégourié-Gonnard8b6d14b2022-12-20 10:02:52 +01001262 }
1263
Gilles Peskine449bd832023-01-11 14:50:10 +01001264 MPI_ECP_MUL(rhs, rhs, X);
1265 MPI_ECP_ADD(rhs, rhs, &grp->B);
Manuel Pégourié-Gonnard8b6d14b2022-12-20 10:02:52 +01001266
1267cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001268 return ret;
Manuel Pégourié-Gonnard8b6d14b2022-12-20 10:02:52 +01001269}
1270
1271/*
1272 * Derive Y from X and a parity bit
1273 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001274static int mbedtls_ecp_sw_derive_y(const mbedtls_ecp_group *grp,
1275 const mbedtls_mpi *X,
1276 mbedtls_mpi *Y,
1277 int parity_bit)
Glenn Strauss45241612022-12-19 19:37:07 -05001278{
1279 /* w = y^2 = x^3 + ax + b
1280 * y = sqrt(w) = w^((p+1)/4) mod p (for prime p where p = 3 mod 4)
1281 *
1282 * Note: this method for extracting square root does not validate that w
1283 * was indeed a square so this function will return garbage in Y if X
1284 * does not correspond to a point on the curve.
1285 */
1286
1287 /* Check prerequisite p = 3 mod 4 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001288 if (mbedtls_mpi_get_bit(&grp->P, 0) != 1 ||
1289 mbedtls_mpi_get_bit(&grp->P, 1) != 1) {
1290 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
1291 }
Glenn Strauss45241612022-12-19 19:37:07 -05001292
1293 int ret;
1294 mbedtls_mpi exp;
Gilles Peskine449bd832023-01-11 14:50:10 +01001295 mbedtls_mpi_init(&exp);
Glenn Strauss45241612022-12-19 19:37:07 -05001296
Manuel Pégourié-Gonnard8b6d14b2022-12-20 10:02:52 +01001297 /* use Y to store intermediate result, actually w above */
Gilles Peskine449bd832023-01-11 14:50:10 +01001298 MBEDTLS_MPI_CHK(ecp_sw_rhs(grp, Y, X));
Glenn Strauss45241612022-12-19 19:37:07 -05001299
1300 /* w = y^2 */ /* Y contains y^2 intermediate result */
1301 /* exp = ((p+1)/4) */
Gilles Peskine449bd832023-01-11 14:50:10 +01001302 MBEDTLS_MPI_CHK(mbedtls_mpi_add_int(&exp, &grp->P, 1));
1303 MBEDTLS_MPI_CHK(mbedtls_mpi_shift_r(&exp, 2));
Glenn Strauss45241612022-12-19 19:37:07 -05001304 /* sqrt(w) = w^((p+1)/4) mod p (for prime p where p = 3 mod 4) */
Gilles Peskine449bd832023-01-11 14:50:10 +01001305 MBEDTLS_MPI_CHK(mbedtls_mpi_exp_mod(Y, Y /*y^2*/, &exp, &grp->P, NULL));
Glenn Strauss45241612022-12-19 19:37:07 -05001306
1307 /* check parity bit match or else invert Y */
1308 /* This quick inversion implementation is valid because Y != 0 for all
1309 * Short Weierstrass curves supported by mbedtls, as each supported curve
1310 * has an order that is a large prime, so each supported curve does not
1311 * have any point of order 2, and a point with Y == 0 would be of order 2 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001312 if (mbedtls_mpi_get_bit(Y, 0) != parity_bit) {
1313 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_mpi(Y, &grp->P, Y));
1314 }
Glenn Strauss45241612022-12-19 19:37:07 -05001315
1316cleanup:
1317
Gilles Peskine449bd832023-01-11 14:50:10 +01001318 mbedtls_mpi_free(&exp);
1319 return ret;
Glenn Strauss45241612022-12-19 19:37:07 -05001320}
Valerio Settifd122f42023-04-05 18:15:32 +02001321#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
Glenn Strauss45241612022-12-19 19:37:07 -05001322
Valerio Settifd122f42023-04-05 18:15:32 +02001323#if defined(MBEDTLS_ECP_C)
1324#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +01001325/*
1326 * For curves in short Weierstrass form, we do all the internal operations in
1327 * Jacobian coordinates.
1328 *
Shaun Case8b0ecbc2021-12-20 21:14:10 -08001329 * For multiplication, we'll use a comb method with countermeasures against
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +01001330 * SPA, hence timing attacks.
1331 */
1332
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001333/*
Manuel Pégourié-Gonnard1c2782c2012-11-19 20:16:28 +01001334 * Normalize jacobian coordinates so that Z == 0 || Z == 1 (GECC 3.2.1)
Manuel Pégourié-Gonnard04a02252013-11-20 22:57:38 +01001335 * Cost: 1N := 1I + 3M + 1S
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +01001336 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001337static int ecp_normalize_jac(const mbedtls_ecp_group *grp, mbedtls_ecp_point *pt)
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +01001338{
Gilles Peskine449bd832023-01-11 14:50:10 +01001339 if (MPI_ECP_CMP_INT(&pt->Z, 0) == 0) {
1340 return 0;
1341 }
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +01001342
Janos Follathb0697532016-08-18 12:38:46 +01001343#if defined(MBEDTLS_ECP_NORMALIZE_JAC_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001344 if (mbedtls_internal_ecp_grp_capable(grp)) {
1345 return mbedtls_internal_ecp_normalize_jac(grp, pt);
1346 }
Janos Follath372697b2016-10-28 16:53:11 +01001347#endif /* MBEDTLS_ECP_NORMALIZE_JAC_ALT */
Manuel Pégourié-Gonnardebac5d32017-08-23 16:23:36 +02001348
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001349#if defined(MBEDTLS_ECP_NO_FALLBACK) && defined(MBEDTLS_ECP_NORMALIZE_JAC_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001350 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001351#else
1352 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Hanno Becker76f897d2022-01-02 12:47:34 +00001353 mbedtls_mpi T;
Gilles Peskine449bd832023-01-11 14:50:10 +01001354 mbedtls_mpi_init(&T);
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +01001355
Gilles Peskine449bd832023-01-11 14:50:10 +01001356 MPI_ECP_INV(&T, &pt->Z); /* T <- 1 / Z */
1357 MPI_ECP_MUL(&pt->Y, &pt->Y, &T); /* Y' <- Y*T = Y / Z */
1358 MPI_ECP_SQR(&T, &T); /* T <- T^2 = 1 / Z^2 */
1359 MPI_ECP_MUL(&pt->X, &pt->X, &T); /* X <- X * T = X / Z^2 */
1360 MPI_ECP_MUL(&pt->Y, &pt->Y, &T); /* Y'' <- Y' * T = Y / Z^3 */
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +01001361
Gilles Peskine449bd832023-01-11 14:50:10 +01001362 MPI_ECP_LSET(&pt->Z, 1);
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +01001363
1364cleanup:
1365
Gilles Peskine449bd832023-01-11 14:50:10 +01001366 mbedtls_mpi_free(&T);
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +01001367
Gilles Peskine449bd832023-01-11 14:50:10 +01001368 return ret;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001369#endif /* !defined(MBEDTLS_ECP_NO_FALLBACK) || !defined(MBEDTLS_ECP_NORMALIZE_JAC_ALT) */
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +01001370}
1371
1372/*
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001373 * Normalize jacobian coordinates of an array of (pointers to) points,
Manuel Pégourié-Gonnard3680c822012-11-21 18:49:45 +01001374 * using Montgomery's trick to perform only one inversion mod P.
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001375 * (See for example Cohen's "A Course in Computational Algebraic Number
1376 * Theory", Algorithm 10.3.4.)
1377 *
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001378 * Warning: fails (returning an error) if one of the points is zero!
Manuel Pégourié-Gonnard7a949d32013-12-05 10:26:01 +01001379 * This should never happen, see choice of w in ecp_mul_comb().
Manuel Pégourié-Gonnard04a02252013-11-20 22:57:38 +01001380 *
1381 * Cost: 1N(t) := 1I + (6t - 3)M + 1S
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001382 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001383static int ecp_normalize_jac_many(const mbedtls_ecp_group *grp,
1384 mbedtls_ecp_point *T[], size_t T_size)
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001385{
Gilles Peskine449bd832023-01-11 14:50:10 +01001386 if (T_size < 2) {
1387 return ecp_normalize_jac(grp, *T);
1388 }
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001389
Janos Follathb0697532016-08-18 12:38:46 +01001390#if defined(MBEDTLS_ECP_NORMALIZE_JAC_MANY_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001391 if (mbedtls_internal_ecp_grp_capable(grp)) {
1392 return mbedtls_internal_ecp_normalize_jac_many(grp, T, T_size);
1393 }
Janos Follathb0697532016-08-18 12:38:46 +01001394#endif
1395
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001396#if defined(MBEDTLS_ECP_NO_FALLBACK) && defined(MBEDTLS_ECP_NORMALIZE_JAC_MANY_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001397 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001398#else
1399 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
1400 size_t i;
Hanno Beckerb8442cd2022-01-04 06:32:11 +00001401 mbedtls_mpi *c, t;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001402
Gilles Peskine449bd832023-01-11 14:50:10 +01001403 if ((c = mbedtls_calloc(T_size, sizeof(mbedtls_mpi))) == NULL) {
1404 return MBEDTLS_ERR_ECP_ALLOC_FAILED;
1405 }
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001406
Gilles Peskine449bd832023-01-11 14:50:10 +01001407 mbedtls_mpi_init(&t);
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001408
Gilles Peskine449bd832023-01-11 14:50:10 +01001409 mpi_init_many(c, T_size);
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001410 /*
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001411 * c[i] = Z_0 * ... * Z_i, i = 0,..,n := T_size-1
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001412 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001413 MPI_ECP_MOV(&c[0], &T[0]->Z);
1414 for (i = 1; i < T_size; i++) {
1415 MPI_ECP_MUL(&c[i], &c[i-1], &T[i]->Z);
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001416 }
1417
1418 /*
Hanno Beckerb8442cd2022-01-04 06:32:11 +00001419 * c[n] = 1 / (Z_0 * ... * Z_n) mod P
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001420 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001421 MPI_ECP_INV(&c[T_size-1], &c[T_size-1]);
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001422
Gilles Peskine449bd832023-01-11 14:50:10 +01001423 for (i = T_size - 1;; i--) {
Hanno Beckerb8442cd2022-01-04 06:32:11 +00001424 /* At the start of iteration i (note that i decrements), we have
1425 * - c[j] = Z_0 * .... * Z_j for j < i,
1426 * - c[j] = 1 / (Z_0 * .... * Z_j) for j == i,
1427 *
1428 * This is maintained via
1429 * - c[i-1] <- c[i] * Z_i
1430 *
1431 * We also derive 1/Z_i = c[i] * c[i-1] for i>0 and use that
1432 * to do the actual normalization. For i==0, we already have
1433 * c[0] = 1 / Z_0.
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001434 */
Hanno Beckerb8442cd2022-01-04 06:32:11 +00001435
Gilles Peskine449bd832023-01-11 14:50:10 +01001436 if (i > 0) {
Hanno Beckerb8442cd2022-01-04 06:32:11 +00001437 /* Compute 1/Z_i and establish invariant for the next iteration. */
Gilles Peskine449bd832023-01-11 14:50:10 +01001438 MPI_ECP_MUL(&t, &c[i], &c[i-1]);
1439 MPI_ECP_MUL(&c[i-1], &c[i], &T[i]->Z);
1440 } else {
1441 MPI_ECP_MOV(&t, &c[0]);
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001442 }
1443
Hanno Beckerb8442cd2022-01-04 06:32:11 +00001444 /* Now t holds 1 / Z_i; normalize as in ecp_normalize_jac() */
Gilles Peskine449bd832023-01-11 14:50:10 +01001445 MPI_ECP_MUL(&T[i]->Y, &T[i]->Y, &t);
1446 MPI_ECP_SQR(&t, &t);
1447 MPI_ECP_MUL(&T[i]->X, &T[i]->X, &t);
1448 MPI_ECP_MUL(&T[i]->Y, &T[i]->Y, &t);
Manuel Pégourié-Gonnard1f789b82013-12-30 17:31:56 +01001449
1450 /*
1451 * Post-precessing: reclaim some memory by shrinking coordinates
1452 * - not storing Z (always 1)
1453 * - shrinking other coordinates, but still keeping the same number of
1454 * limbs as P, as otherwise it will too likely be regrown too fast.
1455 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001456 MBEDTLS_MPI_CHK(mbedtls_mpi_shrink(&T[i]->X, grp->P.n));
1457 MBEDTLS_MPI_CHK(mbedtls_mpi_shrink(&T[i]->Y, grp->P.n));
Hanno Beckeree95f6c2022-01-09 05:46:18 +00001458
Gilles Peskine449bd832023-01-11 14:50:10 +01001459 MPI_ECP_LSET(&T[i]->Z, 1);
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001460
Gilles Peskine449bd832023-01-11 14:50:10 +01001461 if (i == 0) {
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001462 break;
Gilles Peskine449bd832023-01-11 14:50:10 +01001463 }
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001464 }
1465
1466cleanup:
1467
Gilles Peskine449bd832023-01-11 14:50:10 +01001468 mbedtls_mpi_free(&t);
1469 mpi_free_many(c, T_size);
1470 mbedtls_free(c);
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001471
Gilles Peskine449bd832023-01-11 14:50:10 +01001472 return ret;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001473#endif /* !defined(MBEDTLS_ECP_NO_FALLBACK) || !defined(MBEDTLS_ECP_NORMALIZE_JAC_MANY_ALT) */
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001474}
1475
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001476/*
Manuel Pégourié-Gonnard01fca5e2013-11-21 17:47:12 +01001477 * Conditional point inversion: Q -> -Q = (Q.X, -Q.Y, Q.Z) without leak.
1478 * "inv" must be 0 (don't invert) or 1 (invert) or the result will be invalid
1479 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001480static int ecp_safe_invert_jac(const mbedtls_ecp_group *grp,
1481 mbedtls_ecp_point *Q,
1482 unsigned char inv)
Manuel Pégourié-Gonnard01fca5e2013-11-21 17:47:12 +01001483{
Janos Follath24eed8d2019-11-22 13:21:35 +00001484 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Hanno Becker595616e2022-01-05 08:28:24 +00001485 mbedtls_mpi tmp;
Gilles Peskine449bd832023-01-11 14:50:10 +01001486 mbedtls_mpi_init(&tmp);
Manuel Pégourié-Gonnard01fca5e2013-11-21 17:47:12 +01001487
Gilles Peskine449bd832023-01-11 14:50:10 +01001488 MPI_ECP_COND_NEG(&Q->Y, inv);
Manuel Pégourié-Gonnard01fca5e2013-11-21 17:47:12 +01001489
1490cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001491 mbedtls_mpi_free(&tmp);
1492 return ret;
Manuel Pégourié-Gonnard01fca5e2013-11-21 17:47:12 +01001493}
1494
1495/*
Manuel Pégourié-Gonnard0cd6f982013-10-10 15:55:39 +02001496 * Point doubling R = 2 P, Jacobian coordinates
Manuel Pégourié-Gonnard0ace4b32013-10-10 12:44:27 +02001497 *
Peter Dettmance661b22015-02-07 14:43:51 +07001498 * Based on http://www.hyperelliptic.org/EFD/g1p/auto-shortw-jacobian.html#doubling-dbl-1998-cmo-2 .
Manuel Pégourié-Gonnard04a02252013-11-20 22:57:38 +01001499 *
Peter Dettmance661b22015-02-07 14:43:51 +07001500 * We follow the variable naming fairly closely. The formula variations that trade a MUL for a SQR
1501 * (plus a few ADDs) aren't useful as our bignum implementation doesn't distinguish squaring.
1502 *
1503 * Standard optimizations are applied when curve parameter A is one of { 0, -3 }.
1504 *
1505 * Cost: 1D := 3M + 4S (A == 0)
1506 * 4M + 4S (A == -3)
1507 * 3M + 6S + 1a otherwise
Manuel Pégourié-Gonnard1c4aa242013-10-09 16:09:46 +02001508 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001509static int ecp_double_jac(const mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
1510 const mbedtls_ecp_point *P,
1511 mbedtls_mpi tmp[4])
Manuel Pégourié-Gonnard1c4aa242013-10-09 16:09:46 +02001512{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001513#if defined(MBEDTLS_SELF_TEST)
Manuel Pégourié-Gonnard0cd6f982013-10-10 15:55:39 +02001514 dbl_count++;
1515#endif
1516
Janos Follathb0697532016-08-18 12:38:46 +01001517#if defined(MBEDTLS_ECP_DOUBLE_JAC_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001518 if (mbedtls_internal_ecp_grp_capable(grp)) {
1519 return mbedtls_internal_ecp_double_jac(grp, R, P);
1520 }
Janos Follath372697b2016-10-28 16:53:11 +01001521#endif /* MBEDTLS_ECP_DOUBLE_JAC_ALT */
Janos Follathb0697532016-08-18 12:38:46 +01001522
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001523#if defined(MBEDTLS_ECP_NO_FALLBACK) && defined(MBEDTLS_ECP_DOUBLE_JAC_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001524 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001525#else
1526 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard73cc01d2013-12-06 12:41:30 +01001527
1528 /* Special case for A = -3 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001529 if (grp->A.p == NULL) {
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001530 /* tmp[0] <- M = 3(X + Z^2)(X - Z^2) */
Gilles Peskine449bd832023-01-11 14:50:10 +01001531 MPI_ECP_SQR(&tmp[1], &P->Z);
1532 MPI_ECP_ADD(&tmp[2], &P->X, &tmp[1]);
1533 MPI_ECP_SUB(&tmp[3], &P->X, &tmp[1]);
1534 MPI_ECP_MUL(&tmp[1], &tmp[2], &tmp[3]);
1535 MPI_ECP_MUL_INT(&tmp[0], &tmp[1], 3);
1536 } else {
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001537 /* tmp[0] <- M = 3.X^2 + A.Z^4 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001538 MPI_ECP_SQR(&tmp[1], &P->X);
1539 MPI_ECP_MUL_INT(&tmp[0], &tmp[1], 3);
Peter Dettmance661b22015-02-07 14:43:51 +07001540
1541 /* Optimize away for "koblitz" curves with A = 0 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001542 if (MPI_ECP_CMP_INT(&grp->A, 0) != 0) {
Peter Dettmance661b22015-02-07 14:43:51 +07001543 /* M += A.Z^4 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001544 MPI_ECP_SQR(&tmp[1], &P->Z);
1545 MPI_ECP_SQR(&tmp[2], &tmp[1]);
1546 MPI_ECP_MUL(&tmp[1], &tmp[2], &grp->A);
1547 MPI_ECP_ADD(&tmp[0], &tmp[0], &tmp[1]);
Peter Dettmance661b22015-02-07 14:43:51 +07001548 }
Peter Vaskovica676acf2014-08-06 00:48:39 +02001549 }
Manuel Pégourié-Gonnard73cc01d2013-12-06 12:41:30 +01001550
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001551 /* tmp[1] <- S = 4.X.Y^2 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001552 MPI_ECP_SQR(&tmp[2], &P->Y);
1553 MPI_ECP_SHIFT_L(&tmp[2], 1);
1554 MPI_ECP_MUL(&tmp[1], &P->X, &tmp[2]);
1555 MPI_ECP_SHIFT_L(&tmp[1], 1);
Manuel Pégourié-Gonnard1c4aa242013-10-09 16:09:46 +02001556
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001557 /* tmp[3] <- U = 8.Y^4 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001558 MPI_ECP_SQR(&tmp[3], &tmp[2]);
1559 MPI_ECP_SHIFT_L(&tmp[3], 1);
Peter Dettmance661b22015-02-07 14:43:51 +07001560
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001561 /* tmp[2] <- T = M^2 - 2.S */
Gilles Peskine449bd832023-01-11 14:50:10 +01001562 MPI_ECP_SQR(&tmp[2], &tmp[0]);
1563 MPI_ECP_SUB(&tmp[2], &tmp[2], &tmp[1]);
1564 MPI_ECP_SUB(&tmp[2], &tmp[2], &tmp[1]);
Peter Dettmance661b22015-02-07 14:43:51 +07001565
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001566 /* tmp[1] <- S = M(S - T) - U */
Gilles Peskine449bd832023-01-11 14:50:10 +01001567 MPI_ECP_SUB(&tmp[1], &tmp[1], &tmp[2]);
1568 MPI_ECP_MUL(&tmp[1], &tmp[1], &tmp[0]);
1569 MPI_ECP_SUB(&tmp[1], &tmp[1], &tmp[3]);
Peter Dettmance661b22015-02-07 14:43:51 +07001570
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001571 /* tmp[3] <- U = 2.Y.Z */
Gilles Peskine449bd832023-01-11 14:50:10 +01001572 MPI_ECP_MUL(&tmp[3], &P->Y, &P->Z);
1573 MPI_ECP_SHIFT_L(&tmp[3], 1);
Peter Dettmance661b22015-02-07 14:43:51 +07001574
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001575 /* Store results */
Gilles Peskine449bd832023-01-11 14:50:10 +01001576 MPI_ECP_MOV(&R->X, &tmp[2]);
1577 MPI_ECP_MOV(&R->Y, &tmp[1]);
1578 MPI_ECP_MOV(&R->Z, &tmp[3]);
Manuel Pégourié-Gonnard1c4aa242013-10-09 16:09:46 +02001579
1580cleanup:
Manuel Pégourié-Gonnard1c4aa242013-10-09 16:09:46 +02001581
Gilles Peskine449bd832023-01-11 14:50:10 +01001582 return ret;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001583#endif /* !defined(MBEDTLS_ECP_NO_FALLBACK) || !defined(MBEDTLS_ECP_DOUBLE_JAC_ALT) */
Manuel Pégourié-Gonnard1c4aa242013-10-09 16:09:46 +02001584}
1585
1586/*
Manuel Pégourié-Gonnard469a2092013-11-21 18:20:43 +01001587 * Addition: R = P + Q, mixed affine-Jacobian coordinates (GECC 3.22)
Manuel Pégourié-Gonnard9674fd02012-11-19 21:23:27 +01001588 *
1589 * The coordinates of Q must be normalized (= affine),
1590 * but those of P don't need to. R is not normalized.
1591 *
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001592 * P,Q,R may alias, but only at the level of EC points: they must be either
1593 * equal as pointers, or disjoint (including the coordinate data buffers).
1594 * Fine-grained aliasing at the level of coordinates is not supported.
1595 *
Manuel Pégourié-Gonnardaade42f2013-11-21 19:19:54 +01001596 * Special cases: (1) P or Q is zero, (2) R is zero, (3) P == Q.
Manuel Pégourié-Gonnard7a949d32013-12-05 10:26:01 +01001597 * None of these cases can happen as intermediate step in ecp_mul_comb():
Manuel Pégourié-Gonnardaade42f2013-11-21 19:19:54 +01001598 * - at each step, P, Q and R are multiples of the base point, the factor
1599 * being less than its order, so none of them is zero;
1600 * - Q is an odd multiple of the base point, P an even multiple,
1601 * due to the choice of precomputed points in the modified comb method.
1602 * So branches for these cases do not leak secret information.
1603 *
Manuel Pégourié-Gonnard04a02252013-11-20 22:57:38 +01001604 * Cost: 1A := 8M + 3S
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +01001605 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001606static int ecp_add_mixed(const mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
1607 const mbedtls_ecp_point *P, const mbedtls_ecp_point *Q,
1608 mbedtls_mpi tmp[4])
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +01001609{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001610#if defined(MBEDTLS_SELF_TEST)
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01001611 add_count++;
1612#endif
1613
Janos Follathb0697532016-08-18 12:38:46 +01001614#if defined(MBEDTLS_ECP_ADD_MIXED_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001615 if (mbedtls_internal_ecp_grp_capable(grp)) {
1616 return mbedtls_internal_ecp_add_mixed(grp, R, P, Q);
1617 }
Janos Follath372697b2016-10-28 16:53:11 +01001618#endif /* MBEDTLS_ECP_ADD_MIXED_ALT */
Janos Follathb0697532016-08-18 12:38:46 +01001619
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001620#if defined(MBEDTLS_ECP_NO_FALLBACK) && defined(MBEDTLS_ECP_ADD_MIXED_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001621 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001622#else
1623 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Hanno Becker838b7152022-01-04 05:01:53 +00001624
1625 /* NOTE: Aliasing between input and output is allowed, so one has to make
1626 * sure that at the point X,Y,Z are written, {P,Q}->{X,Y,Z} are no
1627 * longer read from. */
Hanno Becker5c8ea302022-01-01 06:01:45 +00001628 mbedtls_mpi * const X = &R->X;
1629 mbedtls_mpi * const Y = &R->Y;
1630 mbedtls_mpi * const Z = &R->Z;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001631
Gilles Peskine449bd832023-01-11 14:50:10 +01001632 if (!MPI_ECP_VALID(&Q->Z)) {
1633 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
1634 }
Hanno Beckeree95f6c2022-01-09 05:46:18 +00001635
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +01001636 /*
Manuel Pégourié-Gonnardaade42f2013-11-21 19:19:54 +01001637 * Trivial cases: P == 0 or Q == 0 (case 1)
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +01001638 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001639 if (MPI_ECP_CMP_INT(&P->Z, 0) == 0) {
1640 return mbedtls_ecp_copy(R, Q);
1641 }
Manuel Pégourié-Gonnard469a2092013-11-21 18:20:43 +01001642
Gilles Peskine449bd832023-01-11 14:50:10 +01001643 if (MPI_ECP_CMP_INT(&Q->Z, 0) == 0) {
1644 return mbedtls_ecp_copy(R, P);
1645 }
Manuel Pégourié-Gonnard1c2782c2012-11-19 20:16:28 +01001646
1647 /*
1648 * Make sure Q coordinates are normalized
1649 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001650 if (MPI_ECP_CMP_INT(&Q->Z, 1) != 0) {
1651 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
1652 }
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +01001653
Gilles Peskine449bd832023-01-11 14:50:10 +01001654 MPI_ECP_SQR(&tmp[0], &P->Z);
1655 MPI_ECP_MUL(&tmp[1], &tmp[0], &P->Z);
1656 MPI_ECP_MUL(&tmp[0], &tmp[0], &Q->X);
1657 MPI_ECP_MUL(&tmp[1], &tmp[1], &Q->Y);
1658 MPI_ECP_SUB(&tmp[0], &tmp[0], &P->X);
1659 MPI_ECP_SUB(&tmp[1], &tmp[1], &P->Y);
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +01001660
Manuel Pégourié-Gonnardaade42f2013-11-21 19:19:54 +01001661 /* Special cases (2) and (3) */
Gilles Peskine449bd832023-01-11 14:50:10 +01001662 if (MPI_ECP_CMP_INT(&tmp[0], 0) == 0) {
1663 if (MPI_ECP_CMP_INT(&tmp[1], 0) == 0) {
1664 ret = ecp_double_jac(grp, R, P, tmp);
Manuel Pégourié-Gonnard7e0adfb2012-11-08 23:21:46 +01001665 goto cleanup;
Gilles Peskine449bd832023-01-11 14:50:10 +01001666 } else {
1667 ret = mbedtls_ecp_set_zero(R);
Manuel Pégourié-Gonnard7e0adfb2012-11-08 23:21:46 +01001668 goto cleanup;
1669 }
1670 }
1671
Hanno Becker838b7152022-01-04 05:01:53 +00001672 /* {P,Q}->Z no longer used, so OK to write to Z even if there's aliasing. */
Gilles Peskine449bd832023-01-11 14:50:10 +01001673 MPI_ECP_MUL(Z, &P->Z, &tmp[0]);
1674 MPI_ECP_SQR(&tmp[2], &tmp[0]);
1675 MPI_ECP_MUL(&tmp[3], &tmp[2], &tmp[0]);
1676 MPI_ECP_MUL(&tmp[2], &tmp[2], &P->X);
Hanno Beckerce29ae82022-01-04 04:55:11 +00001677
Gilles Peskine449bd832023-01-11 14:50:10 +01001678 MPI_ECP_MOV(&tmp[0], &tmp[2]);
1679 MPI_ECP_SHIFT_L(&tmp[0], 1);
Hanno Beckerce29ae82022-01-04 04:55:11 +00001680
Hanno Becker838b7152022-01-04 05:01:53 +00001681 /* {P,Q}->X no longer used, so OK to write to X even if there's aliasing. */
Gilles Peskine449bd832023-01-11 14:50:10 +01001682 MPI_ECP_SQR(X, &tmp[1]);
1683 MPI_ECP_SUB(X, X, &tmp[0]);
1684 MPI_ECP_SUB(X, X, &tmp[3]);
1685 MPI_ECP_SUB(&tmp[2], &tmp[2], X);
1686 MPI_ECP_MUL(&tmp[2], &tmp[2], &tmp[1]);
1687 MPI_ECP_MUL(&tmp[3], &tmp[3], &P->Y);
Hanno Becker838b7152022-01-04 05:01:53 +00001688 /* {P,Q}->Y no longer used, so OK to write to Y even if there's aliasing. */
Gilles Peskine449bd832023-01-11 14:50:10 +01001689 MPI_ECP_SUB(Y, &tmp[2], &tmp[3]);
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +01001690
1691cleanup:
1692
Gilles Peskine449bd832023-01-11 14:50:10 +01001693 return ret;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001694#endif /* !defined(MBEDTLS_ECP_NO_FALLBACK) || !defined(MBEDTLS_ECP_ADD_MIXED_ALT) */
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +01001695}
1696
1697/*
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001698 * Randomize jacobian coordinates:
1699 * (X, Y, Z) -> (l^2 X, l^3 Y, l Z) for random l
Manuel Pégourié-Gonnard3c0b4ea2013-12-02 19:44:41 +01001700 * This is sort of the reverse operation of ecp_normalize_jac().
Manuel Pégourié-Gonnard44aab792013-11-21 10:53:59 +01001701 *
1702 * This countermeasure was first suggested in [2].
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001703 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001704static int ecp_randomize_jac(const mbedtls_ecp_group *grp, mbedtls_ecp_point *pt,
1705 int (*f_rng)(void *, unsigned char *, size_t), void *p_rng)
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001706{
Janos Follathb0697532016-08-18 12:38:46 +01001707#if defined(MBEDTLS_ECP_RANDOMIZE_JAC_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001708 if (mbedtls_internal_ecp_grp_capable(grp)) {
1709 return mbedtls_internal_ecp_randomize_jac(grp, pt, f_rng, p_rng);
1710 }
Janos Follath372697b2016-10-28 16:53:11 +01001711#endif /* MBEDTLS_ECP_RANDOMIZE_JAC_ALT */
Janos Follathb0697532016-08-18 12:38:46 +01001712
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001713#if defined(MBEDTLS_ECP_NO_FALLBACK) && defined(MBEDTLS_ECP_RANDOMIZE_JAC_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001714 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001715#else
1716 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Hanno Becker0d629792022-01-04 06:45:49 +00001717 mbedtls_mpi l;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001718
Gilles Peskine449bd832023-01-11 14:50:10 +01001719 mbedtls_mpi_init(&l);
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001720
1721 /* Generate l such that 1 < l < p */
Gilles Peskine449bd832023-01-11 14:50:10 +01001722 MPI_ECP_RAND(&l);
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001723
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001724 /* Z' = l * Z */
Gilles Peskine449bd832023-01-11 14:50:10 +01001725 MPI_ECP_MUL(&pt->Z, &pt->Z, &l);
Hanno Becker0d629792022-01-04 06:45:49 +00001726
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001727 /* Y' = l * Y */
Gilles Peskine449bd832023-01-11 14:50:10 +01001728 MPI_ECP_MUL(&pt->Y, &pt->Y, &l);
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001729
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001730 /* X' = l^2 * X */
Gilles Peskine449bd832023-01-11 14:50:10 +01001731 MPI_ECP_SQR(&l, &l);
1732 MPI_ECP_MUL(&pt->X, &pt->X, &l);
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001733
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001734 /* Y'' = l^2 * Y' = l^3 * Y */
Gilles Peskine449bd832023-01-11 14:50:10 +01001735 MPI_ECP_MUL(&pt->Y, &pt->Y, &l);
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001736
1737cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001738 mbedtls_mpi_free(&l);
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001739
Gilles Peskine449bd832023-01-11 14:50:10 +01001740 if (ret == MBEDTLS_ERR_MPI_NOT_ACCEPTABLE) {
Gilles Peskine59215172021-03-29 22:28:50 +02001741 ret = MBEDTLS_ERR_ECP_RANDOM_FAILED;
Gilles Peskine449bd832023-01-11 14:50:10 +01001742 }
1743 return ret;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001744#endif /* !defined(MBEDTLS_ECP_NO_FALLBACK) || !defined(MBEDTLS_ECP_RANDOMIZE_JAC_ALT) */
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001745}
1746
1747/*
Manuel Pégourié-Gonnardc30200e2013-11-20 18:39:55 +01001748 * Check and define parameters used by the comb method (see below for details)
1749 */
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001750#if MBEDTLS_ECP_WINDOW_SIZE < 2 || MBEDTLS_ECP_WINDOW_SIZE > 7
1751#error "MBEDTLS_ECP_WINDOW_SIZE out of bounds"
Manuel Pégourié-Gonnardc30200e2013-11-20 18:39:55 +01001752#endif
1753
1754/* d = ceil( n / w ) */
Gilles Peskine449bd832023-01-11 14:50:10 +01001755#define COMB_MAX_D (MBEDTLS_ECP_MAX_BITS + 1) / 2
Manuel Pégourié-Gonnardc30200e2013-11-20 18:39:55 +01001756
1757/* number of precomputed points */
Gilles Peskine449bd832023-01-11 14:50:10 +01001758#define COMB_MAX_PRE (1 << (MBEDTLS_ECP_WINDOW_SIZE - 1))
Manuel Pégourié-Gonnardc30200e2013-11-20 18:39:55 +01001759
1760/*
1761 * Compute the representation of m that will be used with our comb method.
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001762 *
1763 * The basic comb method is described in GECC 3.44 for example. We use a
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001764 * modified version that provides resistance to SPA by avoiding zero
1765 * digits in the representation as in [3]. We modify the method further by
1766 * requiring that all K_i be odd, which has the small cost that our
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001767 * representation uses one more K_i, due to carries, but saves on the size of
1768 * the precomputed table.
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001769 *
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001770 * Summary of the comb method and its modifications:
1771 *
1772 * - The goal is to compute m*P for some w*d-bit integer m.
1773 *
1774 * - The basic comb method splits m into the w-bit integers
1775 * x[0] .. x[d-1] where x[i] consists of the bits in m whose
1776 * index has residue i modulo d, and computes m * P as
1777 * S[x[0]] + 2 * S[x[1]] + .. + 2^(d-1) S[x[d-1]], where
1778 * S[i_{w-1} .. i_0] := i_{w-1} 2^{(w-1)d} P + ... + i_1 2^d P + i_0 P.
1779 *
1780 * - If it happens that, say, x[i+1]=0 (=> S[x[i+1]]=0), one can replace the sum by
1781 * .. + 2^{i-1} S[x[i-1]] - 2^i S[x[i]] + 2^{i+1} S[x[i]] + 2^{i+2} S[x[i+2]] ..,
1782 * thereby successively converting it into a form where all summands
1783 * are nonzero, at the cost of negative summands. This is the basic idea of [3].
1784 *
1785 * - More generally, even if x[i+1] != 0, we can first transform the sum as
1786 * .. - 2^i S[x[i]] + 2^{i+1} ( S[x[i]] + S[x[i+1]] ) + 2^{i+2} S[x[i+2]] ..,
1787 * and then replace S[x[i]] + S[x[i+1]] = S[x[i] ^ x[i+1]] + 2 S[x[i] & x[i+1]].
1788 * Performing and iterating this procedure for those x[i] that are even
1789 * (keeping track of carry), we can transform the original sum into one of the form
1790 * S[x'[0]] +- 2 S[x'[1]] +- .. +- 2^{d-1} S[x'[d-1]] + 2^d S[x'[d]]
1791 * with all x'[i] odd. It is therefore only necessary to know S at odd indices,
1792 * which is why we are only computing half of it in the first place in
1793 * ecp_precompute_comb and accessing it with index abs(i) / 2 in ecp_select_comb.
1794 *
1795 * - For the sake of compactness, only the seven low-order bits of x[i]
1796 * are used to represent its absolute value (K_i in the paper), and the msb
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001797 * of x[i] encodes the sign (s_i in the paper): it is set if and only if
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001798 * if s_i == -1;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001799 *
1800 * Calling conventions:
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001801 * - x is an array of size d + 1
Manuel Pégourié-Gonnardc30200e2013-11-20 18:39:55 +01001802 * - w is the size, ie number of teeth, of the comb, and must be between
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001803 * 2 and 7 (in practice, between 2 and MBEDTLS_ECP_WINDOW_SIZE)
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001804 * - m is the MPI, expected to be odd and such that bitlength(m) <= w * d
1805 * (the result will be incorrect if these assumptions are not satisfied)
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001806 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001807static void ecp_comb_recode_core(unsigned char x[], size_t d,
1808 unsigned char w, const mbedtls_mpi *m)
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001809{
1810 size_t i, j;
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001811 unsigned char c, cc, adjust;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001812
Gilles Peskine449bd832023-01-11 14:50:10 +01001813 memset(x, 0, d+1);
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001814
Manuel Pégourié-Gonnardedc1a1f2013-11-21 09:50:00 +01001815 /* First get the classical comb values (except for x_d = 0) */
Gilles Peskine449bd832023-01-11 14:50:10 +01001816 for (i = 0; i < d; i++) {
1817 for (j = 0; j < w; j++) {
1818 x[i] |= mbedtls_mpi_get_bit(m, i + d * j) << j;
1819 }
1820 }
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001821
Manuel Pégourié-Gonnardedc1a1f2013-11-21 09:50:00 +01001822 /* Now make sure x_1 .. x_d are odd */
1823 c = 0;
Gilles Peskine449bd832023-01-11 14:50:10 +01001824 for (i = 1; i <= d; i++) {
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001825 /* Add carry and update it */
1826 cc = x[i] & c;
1827 x[i] = x[i] ^ c;
1828 c = cc;
1829
Manuel Pégourié-Gonnardedc1a1f2013-11-21 09:50:00 +01001830 /* Adjust if needed, avoiding branches */
Gilles Peskine449bd832023-01-11 14:50:10 +01001831 adjust = 1 - (x[i] & 0x01);
1832 c |= x[i] & (x[i-1] * adjust);
1833 x[i] = x[i] ^ (x[i-1] * adjust);
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001834 x[i-1] |= adjust << 7;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001835 }
1836}
1837
1838/*
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001839 * Precompute points for the adapted comb method
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001840 *
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001841 * Assumption: T must be able to hold 2^{w - 1} elements.
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001842 *
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001843 * Operation: If i = i_{w-1} ... i_1 is the binary representation of i,
1844 * sets T[i] = i_{w-1} 2^{(w-1)d} P + ... + i_1 2^d P + P.
Manuel Pégourié-Gonnard04a02252013-11-20 22:57:38 +01001845 *
1846 * Cost: d(w-1) D + (2^{w-1} - 1) A + 1 N(w-1) + 1 N(2^{w-1} - 1)
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001847 *
1848 * Note: Even comb values (those where P would be omitted from the
1849 * sum defining T[i] above) are not needed in our adaption
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001850 * the comb method. See ecp_comb_recode_core().
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001851 *
1852 * This function currently works in four steps:
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001853 * (1) [dbl] Computation of intermediate T[i] for 2-power values of i
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001854 * (2) [norm_dbl] Normalization of coordinates of these T[i]
1855 * (3) [add] Computation of all T[i]
1856 * (4) [norm_add] Normalization of all T[i]
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001857 *
1858 * Step 1 can be interrupted but not the others; together with the final
1859 * coordinate normalization they are the largest steps done at once, depending
1860 * on the window size. Here are operation counts for P-256:
1861 *
1862 * step (2) (3) (4)
1863 * w = 5 142 165 208
1864 * w = 4 136 77 160
1865 * w = 3 130 33 136
1866 * w = 2 124 11 124
1867 *
1868 * So if ECC operations are blocking for too long even with a low max_ops
1869 * value, it's useful to set MBEDTLS_ECP_WINDOW_SIZE to a lower value in order
1870 * to minimize maximum blocking time.
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001871 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001872static int ecp_precompute_comb(const mbedtls_ecp_group *grp,
1873 mbedtls_ecp_point T[], const mbedtls_ecp_point *P,
1874 unsigned char w, size_t d,
1875 mbedtls_ecp_restart_ctx *rs_ctx)
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001876{
Janos Follath24eed8d2019-11-22 13:21:35 +00001877 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnardfc3e0be2017-03-20 09:29:31 +01001878 unsigned char i;
Manuel Pégourié-Gonnard213541a2017-03-20 12:50:41 +01001879 size_t j = 0;
Gilles Peskine449bd832023-01-11 14:50:10 +01001880 const unsigned char T_size = 1U << (w - 1);
1881 mbedtls_ecp_point *cur, *TT[COMB_MAX_PRE - 1] = { NULL };
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001882
Hanno Beckera7f8edd2022-01-04 07:29:46 +00001883 mbedtls_mpi tmp[4];
1884
Gilles Peskine449bd832023-01-11 14:50:10 +01001885 mpi_init_many(tmp, sizeof(tmp) / sizeof(mbedtls_mpi));
Hanno Beckera7f8edd2022-01-04 07:29:46 +00001886
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02001887#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01001888 if (rs_ctx != NULL && rs_ctx->rsm != NULL) {
1889 if (rs_ctx->rsm->state == ecp_rsm_pre_dbl) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001890 goto dbl;
Gilles Peskine449bd832023-01-11 14:50:10 +01001891 }
1892 if (rs_ctx->rsm->state == ecp_rsm_pre_norm_dbl) {
Manuel Pégourié-Gonnarde2d7cb32017-03-20 10:24:17 +01001893 goto norm_dbl;
Gilles Peskine449bd832023-01-11 14:50:10 +01001894 }
1895 if (rs_ctx->rsm->state == ecp_rsm_pre_add) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001896 goto add;
Gilles Peskine449bd832023-01-11 14:50:10 +01001897 }
1898 if (rs_ctx->rsm->state == ecp_rsm_pre_norm_add) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001899 goto norm_add;
Gilles Peskine449bd832023-01-11 14:50:10 +01001900 }
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01001901 }
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001902#else
1903 (void) rs_ctx;
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01001904#endif
1905
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001906#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01001907 if (rs_ctx != NULL && rs_ctx->rsm != NULL) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001908 rs_ctx->rsm->state = ecp_rsm_pre_dbl;
1909
1910 /* initial state for the loop */
1911 rs_ctx->rsm->i = 0;
1912 }
1913
1914dbl:
1915#endif
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001916 /*
1917 * Set T[0] = P and
1918 * T[2^{l-1}] = 2^{dl} P for l = 1 .. w-1 (this is not the final value)
1919 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001920 MBEDTLS_MPI_CHK(mbedtls_ecp_copy(&T[0], P));
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001921
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02001922#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01001923 if (rs_ctx != NULL && rs_ctx->rsm != NULL && rs_ctx->rsm->i != 0) {
Manuel Pégourié-Gonnard3cade222017-04-20 09:31:00 +02001924 j = rs_ctx->rsm->i;
Gilles Peskine449bd832023-01-11 14:50:10 +01001925 } else
Manuel Pégourié-Gonnard213541a2017-03-20 12:50:41 +01001926#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01001927 j = 0;
Manuel Pégourié-Gonnard213541a2017-03-20 12:50:41 +01001928
Gilles Peskine449bd832023-01-11 14:50:10 +01001929 for (; j < d * (w - 1); j++) {
1930 MBEDTLS_ECP_BUDGET(MBEDTLS_ECP_OPS_DBL);
Manuel Pégourié-Gonnard213541a2017-03-20 12:50:41 +01001931
Gilles Peskine449bd832023-01-11 14:50:10 +01001932 i = 1U << (j / d);
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001933 cur = T + i;
Manuel Pégourié-Gonnardae557072017-03-20 12:21:24 +01001934
Gilles Peskine449bd832023-01-11 14:50:10 +01001935 if (j % d == 0) {
1936 MBEDTLS_MPI_CHK(mbedtls_ecp_copy(cur, T + (i >> 1)));
1937 }
Manuel Pégourié-Gonnardae557072017-03-20 12:21:24 +01001938
Gilles Peskine449bd832023-01-11 14:50:10 +01001939 MBEDTLS_MPI_CHK(ecp_double_jac(grp, cur, cur, tmp));
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001940 }
1941
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02001942#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01001943 if (rs_ctx != NULL && rs_ctx->rsm != NULL) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001944 rs_ctx->rsm->state = ecp_rsm_pre_norm_dbl;
Gilles Peskine449bd832023-01-11 14:50:10 +01001945 }
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001946
Manuel Pégourié-Gonnarde2d7cb32017-03-20 10:24:17 +01001947norm_dbl:
1948#endif
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001949 /*
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001950 * Normalize current elements in T to allow them to be used in
1951 * ecp_add_mixed() below, which requires one normalized input.
1952 *
1953 * As T has holes, use an auxiliary array of pointers to elements in T.
1954 *
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001955 */
Manuel Pégourié-Gonnardfc3e0be2017-03-20 09:29:31 +01001956 j = 0;
Gilles Peskine449bd832023-01-11 14:50:10 +01001957 for (i = 1; i < T_size; i <<= 1) {
Manuel Pégourié-Gonnardfc3e0be2017-03-20 09:29:31 +01001958 TT[j++] = T + i;
Gilles Peskine449bd832023-01-11 14:50:10 +01001959 }
Manuel Pégourié-Gonnardfc3e0be2017-03-20 09:29:31 +01001960
Gilles Peskine449bd832023-01-11 14:50:10 +01001961 MBEDTLS_ECP_BUDGET(MBEDTLS_ECP_OPS_INV + 6 * j - 2);
Manuel Pégourié-Gonnarde2d7cb32017-03-20 10:24:17 +01001962
Gilles Peskine449bd832023-01-11 14:50:10 +01001963 MBEDTLS_MPI_CHK(ecp_normalize_jac_many(grp, TT, j));
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001964
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02001965#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01001966 if (rs_ctx != NULL && rs_ctx->rsm != NULL) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001967 rs_ctx->rsm->state = ecp_rsm_pre_add;
Gilles Peskine449bd832023-01-11 14:50:10 +01001968 }
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001969
Manuel Pégourié-Gonnarde2d7cb32017-03-20 10:24:17 +01001970add:
1971#endif
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001972 /*
1973 * Compute the remaining ones using the minimal number of additions
1974 * Be careful to update T[2^l] only after using it!
1975 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001976 MBEDTLS_ECP_BUDGET((T_size - 1) * MBEDTLS_ECP_OPS_ADD);
Manuel Pégourié-Gonnarde2d7cb32017-03-20 10:24:17 +01001977
Gilles Peskine449bd832023-01-11 14:50:10 +01001978 for (i = 1; i < T_size; i <<= 1) {
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001979 j = i;
Gilles Peskine449bd832023-01-11 14:50:10 +01001980 while (j--) {
1981 MBEDTLS_MPI_CHK(ecp_add_mixed(grp, &T[i + j], &T[j], &T[i], tmp));
1982 }
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001983 }
1984
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02001985#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01001986 if (rs_ctx != NULL && rs_ctx->rsm != NULL) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001987 rs_ctx->rsm->state = ecp_rsm_pre_norm_add;
Gilles Peskine449bd832023-01-11 14:50:10 +01001988 }
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001989
Manuel Pégourié-Gonnarde2d7cb32017-03-20 10:24:17 +01001990norm_add:
1991#endif
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001992 /*
Manuel Pégourié-Gonnarda966fde2018-10-23 10:41:11 +02001993 * Normalize final elements in T. Even though there are no holes now, we
1994 * still need the auxiliary array for homogeneity with the previous
1995 * call. Also, skip T[0] which is already normalised, being a copy of P.
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001996 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001997 for (j = 0; j + 1 < T_size; j++) {
Manuel Pégourié-Gonnardfc3e0be2017-03-20 09:29:31 +01001998 TT[j] = T + j + 1;
Gilles Peskine449bd832023-01-11 14:50:10 +01001999 }
Manuel Pégourié-Gonnardfc3e0be2017-03-20 09:29:31 +01002000
Gilles Peskine449bd832023-01-11 14:50:10 +01002001 MBEDTLS_ECP_BUDGET(MBEDTLS_ECP_OPS_INV + 6 * j - 2);
Manuel Pégourié-Gonnarde2d7cb32017-03-20 10:24:17 +01002002
Gilles Peskine449bd832023-01-11 14:50:10 +01002003 MBEDTLS_MPI_CHK(ecp_normalize_jac_many(grp, TT, j));
Manuel Pégourié-Gonnarde2820122013-11-21 10:08:50 +01002004
Hanno Beckeree95f6c2022-01-09 05:46:18 +00002005 /* Free Z coordinate (=1 after normalization) to save RAM.
2006 * This makes T[i] invalid as mbedtls_ecp_points, but this is OK
2007 * since from this point onwards, they are only accessed indirectly
2008 * via the getter function ecp_select_comb() which does set the
2009 * target's Z coordinate to 1. */
Gilles Peskine449bd832023-01-11 14:50:10 +01002010 for (i = 0; i < T_size; i++) {
2011 mbedtls_mpi_free(&T[i].Z);
2012 }
Hanno Beckeree95f6c2022-01-09 05:46:18 +00002013
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002014cleanup:
Hanno Beckera7f8edd2022-01-04 07:29:46 +00002015
Gilles Peskine449bd832023-01-11 14:50:10 +01002016 mpi_free_many(tmp, sizeof(tmp) / sizeof(mbedtls_mpi));
Hanno Beckera7f8edd2022-01-04 07:29:46 +00002017
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002018#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002019 if (rs_ctx != NULL && rs_ctx->rsm != NULL &&
2020 ret == MBEDTLS_ERR_ECP_IN_PROGRESS) {
2021 if (rs_ctx->rsm->state == ecp_rsm_pre_dbl) {
Manuel Pégourié-Gonnard3cade222017-04-20 09:31:00 +02002022 rs_ctx->rsm->i = j;
Gilles Peskine449bd832023-01-11 14:50:10 +01002023 }
Manuel Pégourié-Gonnard213541a2017-03-20 12:50:41 +01002024 }
2025#endif
Janos Follathb0697532016-08-18 12:38:46 +01002026
Gilles Peskine449bd832023-01-11 14:50:10 +01002027 return ret;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002028}
2029
2030/*
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01002031 * Select precomputed point: R = sign(i) * T[ abs(i) / 2 ]
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02002032 *
2033 * See ecp_comb_recode_core() for background
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002034 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002035static int ecp_select_comb(const mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2036 const mbedtls_ecp_point T[], unsigned char T_size,
2037 unsigned char i)
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002038{
Janos Follath24eed8d2019-11-22 13:21:35 +00002039 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnardd7283502013-11-21 20:00:38 +01002040 unsigned char ii, j;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002041
Manuel Pégourié-Gonnardd7283502013-11-21 20:00:38 +01002042 /* Ignore the "sign" bit and scale down */
Gilles Peskine449bd832023-01-11 14:50:10 +01002043 ii = (i & 0x7Fu) >> 1;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002044
Manuel Pégourié-Gonnardd7283502013-11-21 20:00:38 +01002045 /* Read the whole table to thwart cache-based timing attacks */
Gilles Peskine449bd832023-01-11 14:50:10 +01002046 for (j = 0; j < T_size; j++) {
2047 MPI_ECP_COND_ASSIGN(&R->X, &T[j].X, j == ii);
2048 MPI_ECP_COND_ASSIGN(&R->Y, &T[j].Y, j == ii);
Manuel Pégourié-Gonnardd7283502013-11-21 20:00:38 +01002049 }
2050
Manuel Pégourié-Gonnard01fca5e2013-11-21 17:47:12 +01002051 /* Safely invert result if i is "negative" */
Gilles Peskine449bd832023-01-11 14:50:10 +01002052 MBEDTLS_MPI_CHK(ecp_safe_invert_jac(grp, R, i >> 7));
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002053
Gilles Peskine449bd832023-01-11 14:50:10 +01002054 MPI_ECP_LSET(&R->Z, 1);
Hanno Becker6a288702022-01-05 05:19:48 +00002055
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002056cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01002057 return ret;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002058}
2059
2060/*
2061 * Core multiplication algorithm for the (modified) comb method.
2062 * This part is actually common with the basic comb method (GECC 3.44)
Manuel Pégourié-Gonnard04a02252013-11-20 22:57:38 +01002063 *
2064 * Cost: d A + d D + 1 R
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002065 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002066static int ecp_mul_comb_core(const mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2067 const mbedtls_ecp_point T[], unsigned char T_size,
2068 const unsigned char x[], size_t d,
2069 int (*f_rng)(void *, unsigned char *, size_t),
2070 void *p_rng,
2071 mbedtls_ecp_restart_ctx *rs_ctx)
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002072{
Janos Follath24eed8d2019-11-22 13:21:35 +00002073 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02002074 mbedtls_ecp_point Txi;
Hanno Beckera7f8edd2022-01-04 07:29:46 +00002075 mbedtls_mpi tmp[4];
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002076 size_t i;
2077
Gilles Peskine449bd832023-01-11 14:50:10 +01002078 mbedtls_ecp_point_init(&Txi);
2079 mpi_init_many(tmp, sizeof(tmp) / sizeof(mbedtls_mpi));
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002080
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002081#if !defined(MBEDTLS_ECP_RESTARTABLE)
Manuel Pégourié-Gonnard3cade222017-04-20 09:31:00 +02002082 (void) rs_ctx;
2083#endif
2084
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002085#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002086 if (rs_ctx != NULL && rs_ctx->rsm != NULL &&
2087 rs_ctx->rsm->state != ecp_rsm_comb_core) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002088 rs_ctx->rsm->i = 0;
2089 rs_ctx->rsm->state = ecp_rsm_comb_core;
2090 }
2091
2092 /* new 'if' instead of nested for the sake of the 'else' branch */
Gilles Peskine449bd832023-01-11 14:50:10 +01002093 if (rs_ctx != NULL && rs_ctx->rsm != NULL && rs_ctx->rsm->i != 0) {
Manuel Pégourié-Gonnard3cade222017-04-20 09:31:00 +02002094 /* restore current index (R already pointing to rs_ctx->rsm->R) */
2095 i = rs_ctx->rsm->i;
Gilles Peskine449bd832023-01-11 14:50:10 +01002096 } else
Manuel Pégourié-Gonnardc5d844b2017-03-15 13:06:28 +01002097#endif
2098 {
2099 /* Start with a non-zero point and randomize its coordinates */
2100 i = d;
Gilles Peskine449bd832023-01-11 14:50:10 +01002101 MBEDTLS_MPI_CHK(ecp_select_comb(grp, R, T, T_size, x[i]));
2102 if (f_rng != 0) {
2103 MBEDTLS_MPI_CHK(ecp_randomize_jac(grp, R, f_rng, p_rng));
2104 }
Manuel Pégourié-Gonnardc5d844b2017-03-15 13:06:28 +01002105 }
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002106
Gilles Peskine449bd832023-01-11 14:50:10 +01002107 while (i != 0) {
2108 MBEDTLS_ECP_BUDGET(MBEDTLS_ECP_OPS_DBL + MBEDTLS_ECP_OPS_ADD);
Manuel Pégourié-Gonnard90f31b72018-10-16 10:45:24 +02002109 --i;
2110
Gilles Peskine449bd832023-01-11 14:50:10 +01002111 MBEDTLS_MPI_CHK(ecp_double_jac(grp, R, R, tmp));
2112 MBEDTLS_MPI_CHK(ecp_select_comb(grp, &Txi, T, T_size, x[i]));
2113 MBEDTLS_MPI_CHK(ecp_add_mixed(grp, R, R, &Txi, tmp));
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002114 }
2115
2116cleanup:
Janos Follathb0697532016-08-18 12:38:46 +01002117
Gilles Peskine449bd832023-01-11 14:50:10 +01002118 mbedtls_ecp_point_free(&Txi);
2119 mpi_free_many(tmp, sizeof(tmp) / sizeof(mbedtls_mpi));
Hanno Beckera7f8edd2022-01-04 07:29:46 +00002120
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002121#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002122 if (rs_ctx != NULL && rs_ctx->rsm != NULL &&
2123 ret == MBEDTLS_ERR_ECP_IN_PROGRESS) {
Manuel Pégourié-Gonnard90f31b72018-10-16 10:45:24 +02002124 rs_ctx->rsm->i = i;
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002125 /* no need to save R, already pointing to rs_ctx->rsm->R */
Manuel Pégourié-Gonnardc5d844b2017-03-15 13:06:28 +01002126 }
2127#endif
2128
Gilles Peskine449bd832023-01-11 14:50:10 +01002129 return ret;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002130}
2131
2132/*
Manuel Pégourié-Gonnard62738e92017-03-14 10:00:21 +01002133 * Recode the scalar to get constant-time comb multiplication
2134 *
2135 * As the actual scalar recoding needs an odd scalar as a starting point,
2136 * this wrapper ensures that by replacing m by N - m if necessary, and
2137 * informs the caller that the result of multiplication will be negated.
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02002138 *
Manuel Pégourié-Gonnardfd87e352017-08-24 14:21:05 +02002139 * This works because we only support large prime order for Short Weierstrass
2140 * curves, so N is always odd hence either m or N - m is.
2141 *
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02002142 * See ecp_comb_recode_core() for background.
Manuel Pégourié-Gonnardec5606a2017-03-09 12:46:45 +01002143 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002144static int ecp_comb_recode_scalar(const mbedtls_ecp_group *grp,
2145 const mbedtls_mpi *m,
2146 unsigned char k[COMB_MAX_D + 1],
2147 size_t d,
2148 unsigned char w,
2149 unsigned char *parity_trick)
Manuel Pégourié-Gonnardec5606a2017-03-09 12:46:45 +01002150{
Janos Follath24eed8d2019-11-22 13:21:35 +00002151 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard62738e92017-03-14 10:00:21 +01002152 mbedtls_mpi M, mm;
Manuel Pégourié-Gonnardec5606a2017-03-09 12:46:45 +01002153
Gilles Peskine449bd832023-01-11 14:50:10 +01002154 mbedtls_mpi_init(&M);
2155 mbedtls_mpi_init(&mm);
Manuel Pégourié-Gonnardec5606a2017-03-09 12:46:45 +01002156
Manuel Pégourié-Gonnardfd87e352017-08-24 14:21:05 +02002157 /* N is always odd (see above), just make extra sure */
Gilles Peskine449bd832023-01-11 14:50:10 +01002158 if (mbedtls_mpi_get_bit(&grp->N, 0) != 1) {
2159 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
2160 }
Manuel Pégourié-Gonnardec5606a2017-03-09 12:46:45 +01002161
Manuel Pégourié-Gonnard62738e92017-03-14 10:00:21 +01002162 /* do we need the parity trick? */
Gilles Peskine449bd832023-01-11 14:50:10 +01002163 *parity_trick = (mbedtls_mpi_get_bit(m, 0) == 0);
Manuel Pégourié-Gonnard62738e92017-03-14 10:00:21 +01002164
2165 /* execute parity fix in constant time */
Gilles Peskine449bd832023-01-11 14:50:10 +01002166 MBEDTLS_MPI_CHK(mbedtls_mpi_copy(&M, m));
2167 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_mpi(&mm, &grp->N, m));
2168 MBEDTLS_MPI_CHK(mbedtls_mpi_safe_cond_assign(&M, &mm, *parity_trick));
Manuel Pégourié-Gonnard62738e92017-03-14 10:00:21 +01002169
2170 /* actual scalar recoding */
Gilles Peskine449bd832023-01-11 14:50:10 +01002171 ecp_comb_recode_core(k, d, w, &M);
Manuel Pégourié-Gonnardec5606a2017-03-09 12:46:45 +01002172
2173cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01002174 mbedtls_mpi_free(&mm);
2175 mbedtls_mpi_free(&M);
Manuel Pégourié-Gonnardec5606a2017-03-09 12:46:45 +01002176
Gilles Peskine449bd832023-01-11 14:50:10 +01002177 return ret;
Manuel Pégourié-Gonnardec5606a2017-03-09 12:46:45 +01002178}
2179
2180/*
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002181 * Perform comb multiplication (for short Weierstrass curves)
2182 * once the auxiliary table has been pre-computed.
Manuel Pégourié-Gonnard62738e92017-03-14 10:00:21 +01002183 *
2184 * Scalar recoding may use a parity trick that makes us compute -m * P,
2185 * if that is the case we'll need to recover m * P at the end.
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002186 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002187static int ecp_mul_comb_after_precomp(const mbedtls_ecp_group *grp,
2188 mbedtls_ecp_point *R,
2189 const mbedtls_mpi *m,
2190 const mbedtls_ecp_point *T,
2191 unsigned char T_size,
2192 unsigned char w,
2193 size_t d,
2194 int (*f_rng)(void *, unsigned char *, size_t),
2195 void *p_rng,
2196 mbedtls_ecp_restart_ctx *rs_ctx)
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002197{
Janos Follath24eed8d2019-11-22 13:21:35 +00002198 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard62738e92017-03-14 10:00:21 +01002199 unsigned char parity_trick;
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002200 unsigned char k[COMB_MAX_D + 1];
Manuel Pégourié-Gonnard8962ddb2017-03-14 12:11:21 +01002201 mbedtls_ecp_point *RR = R;
2202
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002203#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002204 if (rs_ctx != NULL && rs_ctx->rsm != NULL) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002205 RR = &rs_ctx->rsm->R;
2206
Gilles Peskine449bd832023-01-11 14:50:10 +01002207 if (rs_ctx->rsm->state == ecp_rsm_final_norm) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002208 goto final_norm;
Gilles Peskine449bd832023-01-11 14:50:10 +01002209 }
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002210 }
Manuel Pégourié-Gonnard8962ddb2017-03-14 12:11:21 +01002211#endif
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002212
Gilles Peskine449bd832023-01-11 14:50:10 +01002213 MBEDTLS_MPI_CHK(ecp_comb_recode_scalar(grp, m, k, d, w,
2214 &parity_trick));
2215 MBEDTLS_MPI_CHK(ecp_mul_comb_core(grp, RR, T, T_size, k, d,
2216 f_rng, p_rng, rs_ctx));
2217 MBEDTLS_MPI_CHK(ecp_safe_invert_jac(grp, RR, parity_trick));
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002218
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002219#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002220 if (rs_ctx != NULL && rs_ctx->rsm != NULL) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002221 rs_ctx->rsm->state = ecp_rsm_final_norm;
Gilles Peskine449bd832023-01-11 14:50:10 +01002222 }
Manuel Pégourié-Gonnard3cade222017-04-20 09:31:00 +02002223
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002224final_norm:
Gilles Peskine449bd832023-01-11 14:50:10 +01002225 MBEDTLS_ECP_BUDGET(MBEDTLS_ECP_OPS_INV);
Manuel Pégourié-Gonnard2fad7ae2017-03-14 13:13:13 +01002226#endif
Manuel Pégourié-Gonnarda4aa89b2020-03-25 12:41:29 +01002227 /*
2228 * Knowledge of the jacobian coordinates may leak the last few bits of the
2229 * scalar [1], and since our MPI implementation isn't constant-flow,
2230 * inversion (used for coordinate normalization) may leak the full value
2231 * of its input via side-channels [2].
2232 *
2233 * [1] https://eprint.iacr.org/2003/191
2234 * [2] https://eprint.iacr.org/2020/055
2235 *
2236 * Avoid the leak by randomizing coordinates before we normalize them.
2237 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002238 if (f_rng != 0) {
2239 MBEDTLS_MPI_CHK(ecp_randomize_jac(grp, RR, f_rng, p_rng));
2240 }
Manuel Pégourié-Gonnarda4aa89b2020-03-25 12:41:29 +01002241
Gilles Peskine449bd832023-01-11 14:50:10 +01002242 MBEDTLS_MPI_CHK(ecp_normalize_jac(grp, RR));
Manuel Pégourié-Gonnard8962ddb2017-03-14 12:11:21 +01002243
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002244#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002245 if (rs_ctx != NULL && rs_ctx->rsm != NULL) {
2246 MBEDTLS_MPI_CHK(mbedtls_ecp_copy(R, RR));
2247 }
Manuel Pégourié-Gonnard8962ddb2017-03-14 12:11:21 +01002248#endif
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002249
2250cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01002251 return ret;
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002252}
2253
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002254/*
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002255 * Pick window size based on curve size and whether we optimize for base point
2256 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002257static unsigned char ecp_pick_window_size(const mbedtls_ecp_group *grp,
2258 unsigned char p_eq_g)
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002259{
2260 unsigned char w;
2261
2262 /*
2263 * Minimize the number of multiplications, that is minimize
2264 * 10 * d * w + 18 * 2^(w-1) + 11 * d + 7 * w, with d = ceil( nbits / w )
2265 * (see costs of the various parts, with 1S = 1M)
2266 */
2267 w = grp->nbits >= 384 ? 5 : 4;
2268
2269 /*
2270 * If P == G, pre-compute a bit more, since this may be re-used later.
2271 * Just adding one avoids upping the cost of the first mul too much,
2272 * and the memory cost too.
2273 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002274 if (p_eq_g) {
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002275 w++;
Gilles Peskine449bd832023-01-11 14:50:10 +01002276 }
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002277
2278 /*
kXuanba9cb762021-04-08 14:32:06 +08002279 * If static comb table may not be used (!p_eq_g) or static comb table does
2280 * not exists, make sure w is within bounds.
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002281 * (The last test is useful only for very small curves in the test suite.)
kXuanba9cb762021-04-08 14:32:06 +08002282 *
2283 * The user reduces MBEDTLS_ECP_WINDOW_SIZE does not changes the size of
2284 * static comb table, because the size of static comb table is fixed when
2285 * it is generated.
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002286 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002287#if (MBEDTLS_ECP_WINDOW_SIZE < 6)
2288 if ((!p_eq_g || !ecp_group_is_static_comb_table(grp)) && w > MBEDTLS_ECP_WINDOW_SIZE) {
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002289 w = MBEDTLS_ECP_WINDOW_SIZE;
Gilles Peskine449bd832023-01-11 14:50:10 +01002290 }
k-stachowiak653a4a22019-07-03 14:31:09 +02002291#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01002292 if (w >= grp->nbits) {
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002293 w = 2;
Gilles Peskine449bd832023-01-11 14:50:10 +01002294 }
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002295
Gilles Peskine449bd832023-01-11 14:50:10 +01002296 return w;
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002297}
2298
2299/*
Manuel Pégourié-Gonnard07bf6f52017-03-16 17:21:38 +01002300 * Multiplication using the comb method - for curves in short Weierstrass form
2301 *
2302 * This function is mainly responsible for administrative work:
2303 * - managing the restart context if enabled
Manuel Pégourié-Gonnard11556e22017-08-24 13:41:19 +02002304 * - managing the table of precomputed points (passed between the below two
Shaun Case8b0ecbc2021-12-20 21:14:10 -08002305 * functions): allocation, computation, ownership transfer, freeing.
Manuel Pégourié-Gonnard07bf6f52017-03-16 17:21:38 +01002306 *
2307 * It delegates the actual arithmetic work to:
2308 * ecp_precompute_comb() and ecp_mul_comb_with_precomp()
2309 *
2310 * See comments on ecp_comb_recode_core() regarding the computation strategy.
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002311 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002312static int ecp_mul_comb(mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2313 const mbedtls_mpi *m, const mbedtls_ecp_point *P,
2314 int (*f_rng)(void *, unsigned char *, size_t),
2315 void *p_rng,
2316 mbedtls_ecp_restart_ctx *rs_ctx)
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002317{
Janos Follath24eed8d2019-11-22 13:21:35 +00002318 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard11556e22017-08-24 13:41:19 +02002319 unsigned char w, p_eq_g, i;
Manuel Pégourié-Gonnardd7283502013-11-21 20:00:38 +01002320 size_t d;
Manuel Pégourié-Gonnardf2a9fcf2020-06-03 12:11:56 +02002321 unsigned char T_size = 0, T_ok = 0;
2322 mbedtls_ecp_point *T = NULL;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002323
Gilles Peskine449bd832023-01-11 14:50:10 +01002324 ECP_RS_ENTER(rsm);
Manuel Pégourié-Gonnard510d5ca2017-03-08 11:41:47 +01002325
Manuel Pégourié-Gonnard22be6352017-03-09 13:02:35 +01002326 /* Is P the base point ? */
2327#if MBEDTLS_ECP_FIXED_POINT_OPTIM == 1
Gilles Peskine449bd832023-01-11 14:50:10 +01002328 p_eq_g = (MPI_ECP_CMP(&P->Y, &grp->G.Y) == 0 &&
2329 MPI_ECP_CMP(&P->X, &grp->G.X) == 0);
Manuel Pégourié-Gonnard196d1332017-08-28 13:14:27 +02002330#else
2331 p_eq_g = 0;
Manuel Pégourié-Gonnard22be6352017-03-09 13:02:35 +01002332#endif
2333
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002334 /* Pick window size and deduce related sizes */
Gilles Peskine449bd832023-01-11 14:50:10 +01002335 w = ecp_pick_window_size(grp, p_eq_g);
2336 T_size = 1U << (w - 1);
2337 d = (grp->nbits + w - 1) / w;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002338
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01002339 /* Pre-computed table: do we have it already for the base point? */
Gilles Peskine449bd832023-01-11 14:50:10 +01002340 if (p_eq_g && grp->T != NULL) {
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02002341 /* second pointer to the same table, will be deleted on exit */
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01002342 T = grp->T;
2343 T_ok = 1;
Gilles Peskine449bd832023-01-11 14:50:10 +01002344 } else
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002345#if defined(MBEDTLS_ECP_RESTARTABLE)
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01002346 /* Pre-computed table: do we have one in progress? complete? */
Gilles Peskine449bd832023-01-11 14:50:10 +01002347 if (rs_ctx != NULL && rs_ctx->rsm != NULL && rs_ctx->rsm->T != NULL) {
Manuel Pégourié-Gonnard45fd0162017-03-22 08:24:42 +01002348 /* transfer ownership of T from rsm to local function */
Manuel Pégourié-Gonnard3cade222017-04-20 09:31:00 +02002349 T = rs_ctx->rsm->T;
2350 rs_ctx->rsm->T = NULL;
2351 rs_ctx->rsm->T_size = 0;
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01002352
Manuel Pégourié-Gonnardb25cb602018-10-16 11:48:09 +02002353 /* This effectively jumps to the call to mul_comb_after_precomp() */
Manuel Pégourié-Gonnard11556e22017-08-24 13:41:19 +02002354 T_ok = rs_ctx->rsm->state >= ecp_rsm_comb_core;
Gilles Peskine449bd832023-01-11 14:50:10 +01002355 } else
Manuel Pégourié-Gonnardc9c0aa62017-03-16 14:53:26 +01002356#endif
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01002357 /* Allocate table if we didn't have any */
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002358 {
Gilles Peskine449bd832023-01-11 14:50:10 +01002359 T = mbedtls_calloc(T_size, sizeof(mbedtls_ecp_point));
2360 if (T == NULL) {
Manuel Pégourié-Gonnard6a8ca332015-05-28 09:33:39 +02002361 ret = MBEDTLS_ERR_ECP_ALLOC_FAILED;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002362 goto cleanup;
2363 }
Manuel Pégourié-Gonnard5bd38b12017-08-23 16:55:59 +02002364
Gilles Peskine449bd832023-01-11 14:50:10 +01002365 for (i = 0; i < T_size; i++) {
2366 mbedtls_ecp_point_init(&T[i]);
2367 }
Manuel Pégourié-Gonnard11556e22017-08-24 13:41:19 +02002368
2369 T_ok = 0;
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01002370 }
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002371
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01002372 /* Compute table (or finish computing it) if not done already */
Gilles Peskine449bd832023-01-11 14:50:10 +01002373 if (!T_ok) {
2374 MBEDTLS_MPI_CHK(ecp_precompute_comb(grp, T, P, w, d, rs_ctx));
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002375
Gilles Peskine449bd832023-01-11 14:50:10 +01002376 if (p_eq_g) {
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02002377 /* almost transfer ownership of T to the group, but keep a copy of
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02002378 * the pointer to use for calling the next function more easily */
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002379 grp->T = T;
Manuel Pégourié-Gonnard92cceb22017-08-23 16:27:29 +02002380 grp->T_size = T_size;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002381 }
2382 }
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002383
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002384 /* Actual comb multiplication using precomputed points */
Gilles Peskine449bd832023-01-11 14:50:10 +01002385 MBEDTLS_MPI_CHK(ecp_mul_comb_after_precomp(grp, R, m,
2386 T, T_size, w, d,
2387 f_rng, p_rng, rs_ctx));
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002388
2389cleanup:
2390
Manuel Pégourié-Gonnard07bf6f52017-03-16 17:21:38 +01002391 /* does T belong to the group? */
Gilles Peskine449bd832023-01-11 14:50:10 +01002392 if (T == grp->T) {
Manuel Pégourié-Gonnard07bf6f52017-03-16 17:21:38 +01002393 T = NULL;
Gilles Peskine449bd832023-01-11 14:50:10 +01002394 }
Manuel Pégourié-Gonnard07bf6f52017-03-16 17:21:38 +01002395
2396 /* does T belong to the restart context? */
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002397#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002398 if (rs_ctx != NULL && rs_ctx->rsm != NULL && ret == MBEDTLS_ERR_ECP_IN_PROGRESS && T != NULL) {
Manuel Pégourié-Gonnard45fd0162017-03-22 08:24:42 +01002399 /* transfer ownership of T from local function to rsm */
Manuel Pégourié-Gonnard92cceb22017-08-23 16:27:29 +02002400 rs_ctx->rsm->T_size = T_size;
Manuel Pégourié-Gonnard3cade222017-04-20 09:31:00 +02002401 rs_ctx->rsm->T = T;
Manuel Pégourié-Gonnardc9c0aa62017-03-16 14:53:26 +01002402 T = NULL;
2403 }
2404#endif
2405
Manuel Pégourié-Gonnard07bf6f52017-03-16 17:21:38 +01002406 /* did T belong to us? then let's destroy it! */
Gilles Peskine449bd832023-01-11 14:50:10 +01002407 if (T != NULL) {
2408 for (i = 0; i < T_size; i++) {
2409 mbedtls_ecp_point_free(&T[i]);
2410 }
2411 mbedtls_free(T);
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002412 }
2413
Manuel Pégourié-Gonnard07bf6f52017-03-16 17:21:38 +01002414 /* prevent caller from using invalid value */
Gilles Peskine449bd832023-01-11 14:50:10 +01002415 int should_free_R = (ret != 0);
David Horstmannfc735df2022-10-06 19:11:04 +01002416#if defined(MBEDTLS_ECP_RESTARTABLE)
2417 /* don't free R while in progress in case R == P */
Gilles Peskine449bd832023-01-11 14:50:10 +01002418 if (ret == MBEDTLS_ERR_ECP_IN_PROGRESS) {
David Horstmann6e116872022-10-25 10:32:08 +01002419 should_free_R = 0;
Gilles Peskine449bd832023-01-11 14:50:10 +01002420 }
David Horstmannfc735df2022-10-06 19:11:04 +01002421#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01002422 if (should_free_R) {
2423 mbedtls_ecp_point_free(R);
2424 }
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002425
Gilles Peskine449bd832023-01-11 14:50:10 +01002426 ECP_RS_LEAVE(rsm);
Manuel Pégourié-Gonnard77af79a2017-03-14 10:58:00 +01002427
Gilles Peskine449bd832023-01-11 14:50:10 +01002428 return ret;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002429}
2430
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02002431#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +01002432
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02002433#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +01002434/*
2435 * For Montgomery curves, we do all the internal arithmetic in projective
2436 * coordinates. Import/export of points uses only the x coordinates, which is
Shaun Case8b0ecbc2021-12-20 21:14:10 -08002437 * internally represented as X / Z.
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +01002438 *
2439 * For scalar multiplication, we'll use a Montgomery ladder.
2440 */
2441
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002442/*
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002443 * Normalize Montgomery x/z coordinates: X = X/Z, Z = 1
2444 * Cost: 1M + 1I
2445 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002446static int ecp_normalize_mxz(const mbedtls_ecp_group *grp, mbedtls_ecp_point *P)
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002447{
Janos Follathb0697532016-08-18 12:38:46 +01002448#if defined(MBEDTLS_ECP_NORMALIZE_MXZ_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002449 if (mbedtls_internal_ecp_grp_capable(grp)) {
2450 return mbedtls_internal_ecp_normalize_mxz(grp, P);
2451 }
Janos Follath372697b2016-10-28 16:53:11 +01002452#endif /* MBEDTLS_ECP_NORMALIZE_MXZ_ALT */
Janos Follathb0697532016-08-18 12:38:46 +01002453
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002454#if defined(MBEDTLS_ECP_NO_FALLBACK) && defined(MBEDTLS_ECP_NORMALIZE_MXZ_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002455 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002456#else
2457 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +01002458 MPI_ECP_INV(&P->Z, &P->Z);
2459 MPI_ECP_MUL(&P->X, &P->X, &P->Z);
2460 MPI_ECP_LSET(&P->Z, 1);
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002461
2462cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01002463 return ret;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002464#endif /* !defined(MBEDTLS_ECP_NO_FALLBACK) || !defined(MBEDTLS_ECP_NORMALIZE_MXZ_ALT) */
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002465}
2466
2467/*
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002468 * Randomize projective x/z coordinates:
2469 * (X, Z) -> (l X, l Z) for random l
2470 * This is sort of the reverse operation of ecp_normalize_mxz().
2471 *
2472 * This countermeasure was first suggested in [2].
2473 * Cost: 2M
2474 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002475static int ecp_randomize_mxz(const mbedtls_ecp_group *grp, mbedtls_ecp_point *P,
2476 int (*f_rng)(void *, unsigned char *, size_t), void *p_rng)
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002477{
Janos Follathb0697532016-08-18 12:38:46 +01002478#if defined(MBEDTLS_ECP_RANDOMIZE_MXZ_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002479 if (mbedtls_internal_ecp_grp_capable(grp)) {
2480 return mbedtls_internal_ecp_randomize_mxz(grp, P, f_rng, p_rng);
2481 }
Janos Follath372697b2016-10-28 16:53:11 +01002482#endif /* MBEDTLS_ECP_RANDOMIZE_MXZ_ALT */
Janos Follathb0697532016-08-18 12:38:46 +01002483
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002484#if defined(MBEDTLS_ECP_NO_FALLBACK) && defined(MBEDTLS_ECP_RANDOMIZE_MXZ_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002485 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002486#else
2487 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
2488 mbedtls_mpi l;
Gilles Peskine449bd832023-01-11 14:50:10 +01002489 mbedtls_mpi_init(&l);
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002490
2491 /* Generate l such that 1 < l < p */
Gilles Peskine449bd832023-01-11 14:50:10 +01002492 MPI_ECP_RAND(&l);
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002493
Gilles Peskine449bd832023-01-11 14:50:10 +01002494 MPI_ECP_MUL(&P->X, &P->X, &l);
2495 MPI_ECP_MUL(&P->Z, &P->Z, &l);
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002496
2497cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01002498 mbedtls_mpi_free(&l);
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002499
Gilles Peskine449bd832023-01-11 14:50:10 +01002500 if (ret == MBEDTLS_ERR_MPI_NOT_ACCEPTABLE) {
Gilles Peskine59215172021-03-29 22:28:50 +02002501 ret = MBEDTLS_ERR_ECP_RANDOM_FAILED;
Gilles Peskine449bd832023-01-11 14:50:10 +01002502 }
2503 return ret;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002504#endif /* !defined(MBEDTLS_ECP_NO_FALLBACK) || !defined(MBEDTLS_ECP_RANDOMIZE_MXZ_ALT) */
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002505}
2506
2507/*
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002508 * Double-and-add: R = 2P, S = P + Q, with d = X(P - Q),
2509 * for Montgomery curves in x/z coordinates.
2510 *
2511 * http://www.hyperelliptic.org/EFD/g1p/auto-code/montgom/xz/ladder/mladd-1987-m.op3
2512 * with
2513 * d = X1
2514 * P = (X2, Z2)
2515 * Q = (X3, Z3)
2516 * R = (X4, Z4)
2517 * S = (X5, Z5)
2518 * and eliminating temporary variables tO, ..., t4.
2519 *
2520 * Cost: 5M + 4S
2521 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002522static int ecp_double_add_mxz(const mbedtls_ecp_group *grp,
2523 mbedtls_ecp_point *R, mbedtls_ecp_point *S,
2524 const mbedtls_ecp_point *P, const mbedtls_ecp_point *Q,
2525 const mbedtls_mpi *d,
2526 mbedtls_mpi T[4])
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002527{
Janos Follathb0697532016-08-18 12:38:46 +01002528#if defined(MBEDTLS_ECP_DOUBLE_ADD_MXZ_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002529 if (mbedtls_internal_ecp_grp_capable(grp)) {
2530 return mbedtls_internal_ecp_double_add_mxz(grp, R, S, P, Q, d);
2531 }
Janos Follath372697b2016-10-28 16:53:11 +01002532#endif /* MBEDTLS_ECP_DOUBLE_ADD_MXZ_ALT */
Janos Follathb0697532016-08-18 12:38:46 +01002533
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002534#if defined(MBEDTLS_ECP_NO_FALLBACK) && defined(MBEDTLS_ECP_DOUBLE_ADD_MXZ_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002535 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002536#else
2537 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002538
Gilles Peskine449bd832023-01-11 14:50:10 +01002539 MPI_ECP_ADD(&T[0], &P->X, &P->Z); /* Pp := PX + PZ */
2540 MPI_ECP_SUB(&T[1], &P->X, &P->Z); /* Pm := PX - PZ */
2541 MPI_ECP_ADD(&T[2], &Q->X, &Q->Z); /* Qp := QX + XZ */
2542 MPI_ECP_SUB(&T[3], &Q->X, &Q->Z); /* Qm := QX - QZ */
2543 MPI_ECP_MUL(&T[3], &T[3], &T[0]); /* Qm * Pp */
2544 MPI_ECP_MUL(&T[2], &T[2], &T[1]); /* Qp * Pm */
2545 MPI_ECP_SQR(&T[0], &T[0]); /* Pp^2 */
2546 MPI_ECP_SQR(&T[1], &T[1]); /* Pm^2 */
2547 MPI_ECP_MUL(&R->X, &T[0], &T[1]); /* Pp^2 * Pm^2 */
2548 MPI_ECP_SUB(&T[0], &T[0], &T[1]); /* Pp^2 - Pm^2 */
2549 MPI_ECP_MUL(&R->Z, &grp->A, &T[0]); /* A * (Pp^2 - Pm^2) */
2550 MPI_ECP_ADD(&R->Z, &T[1], &R->Z); /* [ A * (Pp^2-Pm^2) ] + Pm^2 */
2551 MPI_ECP_ADD(&S->X, &T[3], &T[2]); /* Qm*Pp + Qp*Pm */
2552 MPI_ECP_SQR(&S->X, &S->X); /* (Qm*Pp + Qp*Pm)^2 */
2553 MPI_ECP_SUB(&S->Z, &T[3], &T[2]); /* Qm*Pp - Qp*Pm */
2554 MPI_ECP_SQR(&S->Z, &S->Z); /* (Qm*Pp - Qp*Pm)^2 */
2555 MPI_ECP_MUL(&S->Z, d, &S->Z); /* d * ( Qm*Pp - Qp*Pm )^2 */
2556 MPI_ECP_MUL(&R->Z, &T[0], &R->Z); /* [A*(Pp^2-Pm^2)+Pm^2]*(Pp^2-Pm^2) */
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002557
2558cleanup:
Hanno Becker28ccb1c2022-01-04 07:15:04 +00002559
Gilles Peskine449bd832023-01-11 14:50:10 +01002560 return ret;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002561#endif /* !defined(MBEDTLS_ECP_NO_FALLBACK) || !defined(MBEDTLS_ECP_DOUBLE_ADD_MXZ_ALT) */
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002562}
2563
2564/*
Manuel Pégourié-Gonnarda0179b82013-12-04 11:49:20 +01002565 * Multiplication with Montgomery ladder in x/z coordinates,
2566 * for curves in Montgomery form
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002567 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002568static int ecp_mul_mxz(mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2569 const mbedtls_mpi *m, const mbedtls_ecp_point *P,
2570 int (*f_rng)(void *, unsigned char *, size_t),
2571 void *p_rng)
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002572{
Janos Follath24eed8d2019-11-22 13:21:35 +00002573 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002574 size_t i;
Manuel Pégourié-Gonnardb6f45a62013-12-04 21:54:36 +01002575 unsigned char b;
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02002576 mbedtls_ecp_point RP;
2577 mbedtls_mpi PX;
Hanno Becker30838862022-01-04 13:25:59 +00002578 mbedtls_mpi tmp[4];
Gilles Peskine449bd832023-01-11 14:50:10 +01002579 mbedtls_ecp_point_init(&RP); mbedtls_mpi_init(&PX);
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002580
Gilles Peskine449bd832023-01-11 14:50:10 +01002581 mpi_init_many(tmp, sizeof(tmp) / sizeof(mbedtls_mpi));
Hanno Becker30838862022-01-04 13:25:59 +00002582
Gilles Peskine449bd832023-01-11 14:50:10 +01002583 if (f_rng == NULL) {
2584 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
2585 }
Manuel Pégourié-Gonnard02b57052021-06-15 11:29:26 +02002586
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002587 /* Save PX and read from P before writing to R, in case P == R */
Gilles Peskine449bd832023-01-11 14:50:10 +01002588 MPI_ECP_MOV(&PX, &P->X);
2589 MBEDTLS_MPI_CHK(mbedtls_ecp_copy(&RP, P));
Manuel Pégourié-Gonnard357ff652013-12-04 18:39:17 +01002590
2591 /* Set R to zero in modified x/z coordinates */
Gilles Peskine449bd832023-01-11 14:50:10 +01002592 MPI_ECP_LSET(&R->X, 1);
2593 MPI_ECP_LSET(&R->Z, 0);
2594 mbedtls_mpi_free(&R->Y);
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002595
Shaun Case8b0ecbc2021-12-20 21:14:10 -08002596 /* RP.X might be slightly larger than P, so reduce it */
Gilles Peskine449bd832023-01-11 14:50:10 +01002597 MOD_ADD(&RP.X);
Manuel Pégourié-Gonnard93f41db2013-12-05 10:48:42 +01002598
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002599 /* Randomize coordinates of the starting point */
Gilles Peskine449bd832023-01-11 14:50:10 +01002600 MBEDTLS_MPI_CHK(ecp_randomize_mxz(grp, &RP, f_rng, p_rng));
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002601
Manuel Pégourié-Gonnardb6f45a62013-12-04 21:54:36 +01002602 /* Loop invariant: R = result so far, RP = R + P */
Aurelien Jarnoc79ce882022-05-15 13:24:05 +02002603 i = grp->nbits + 1; /* one past the (zero-based) required msb for private keys */
Gilles Peskine449bd832023-01-11 14:50:10 +01002604 while (i-- > 0) {
2605 b = mbedtls_mpi_get_bit(m, i);
Manuel Pégourié-Gonnardb6f45a62013-12-04 21:54:36 +01002606 /*
2607 * if (b) R = 2R + P else R = 2R,
2608 * which is:
2609 * if (b) double_add( RP, R, RP, R )
2610 * else double_add( R, RP, R, RP )
2611 * but using safe conditional swaps to avoid leaks
2612 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002613 MPI_ECP_COND_SWAP(&R->X, &RP.X, b);
2614 MPI_ECP_COND_SWAP(&R->Z, &RP.Z, b);
2615 MBEDTLS_MPI_CHK(ecp_double_add_mxz(grp, R, &RP, R, &RP, &PX, tmp));
2616 MPI_ECP_COND_SWAP(&R->X, &RP.X, b);
2617 MPI_ECP_COND_SWAP(&R->Z, &RP.Z, b);
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002618 }
2619
Manuel Pégourié-Gonnarda4aa89b2020-03-25 12:41:29 +01002620 /*
2621 * Knowledge of the projective coordinates may leak the last few bits of the
2622 * scalar [1], and since our MPI implementation isn't constant-flow,
2623 * inversion (used for coordinate normalization) may leak the full value
2624 * of its input via side-channels [2].
2625 *
2626 * [1] https://eprint.iacr.org/2003/191
2627 * [2] https://eprint.iacr.org/2020/055
2628 *
2629 * Avoid the leak by randomizing coordinates before we normalize them.
2630 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002631 MBEDTLS_MPI_CHK(ecp_randomize_mxz(grp, R, f_rng, p_rng));
2632 MBEDTLS_MPI_CHK(ecp_normalize_mxz(grp, R));
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002633
2634cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01002635 mbedtls_ecp_point_free(&RP); mbedtls_mpi_free(&PX);
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002636
Gilles Peskine449bd832023-01-11 14:50:10 +01002637 mpi_free_many(tmp, sizeof(tmp) / sizeof(mbedtls_mpi));
2638 return ret;
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002639}
2640
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02002641#endif /* MBEDTLS_ECP_MONTGOMERY_ENABLED */
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +01002642
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002643/*
Manuel Pégourié-Gonnard884569c2017-04-20 10:10:59 +02002644 * Restartable multiplication R = m * P
Manuel Pégourié-Gonnard75525ae2021-06-15 11:29:26 +02002645 *
2646 * This internal function can be called without an RNG in case where we know
2647 * the inputs are not sensitive.
Manuel Pégourié-Gonnarda0179b82013-12-04 11:49:20 +01002648 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002649static int ecp_mul_restartable_internal(mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2650 const mbedtls_mpi *m, const mbedtls_ecp_point *P,
2651 int (*f_rng)(void *, unsigned char *, size_t), void *p_rng,
2652 mbedtls_ecp_restart_ctx *rs_ctx)
Manuel Pégourié-Gonnarda0179b82013-12-04 11:49:20 +01002653{
Janos Follathb0697532016-08-18 12:38:46 +01002654 int ret = MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Janos Follathc44ab972016-11-18 16:38:23 +00002655#if defined(MBEDTLS_ECP_INTERNAL_ALT)
2656 char is_grp_capable = 0;
2657#endif
Manuel Pégourié-Gonnardaa3ed6f2021-06-15 11:29:26 +02002658
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002659#if defined(MBEDTLS_ECP_RESTARTABLE)
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002660 /* reset ops count for this call if top-level */
Gilles Peskine449bd832023-01-11 14:50:10 +01002661 if (rs_ctx != NULL && rs_ctx->depth++ == 0) {
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002662 rs_ctx->ops_done = 0;
Gilles Peskine449bd832023-01-11 14:50:10 +01002663 }
Gilles Peskine59970052019-02-28 13:12:06 +01002664#else
2665 (void) rs_ctx;
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002666#endif
Manuel Pégourié-Gonnarda0179b82013-12-04 11:49:20 +01002667
Janos Follathc44ab972016-11-18 16:38:23 +00002668#if defined(MBEDTLS_ECP_INTERNAL_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002669 if ((is_grp_capable = mbedtls_internal_ecp_grp_capable(grp))) {
2670 MBEDTLS_MPI_CHK(mbedtls_internal_ecp_init(grp));
2671 }
Janos Follathc44ab972016-11-18 16:38:23 +00002672#endif /* MBEDTLS_ECP_INTERNAL_ALT */
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002673
David Horstmannfc735df2022-10-06 19:11:04 +01002674 int restarting = 0;
Manuel Pégourié-Gonnard95aedfe2017-08-24 13:47:04 +02002675#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002676 restarting = (rs_ctx != NULL && rs_ctx->rsm != NULL);
Manuel Pégourié-Gonnarda08cd1a2017-04-20 11:29:43 +02002677#endif
David Horstmannfc735df2022-10-06 19:11:04 +01002678 /* skip argument check when restarting */
Gilles Peskine449bd832023-01-11 14:50:10 +01002679 if (!restarting) {
Manuel Pégourié-Gonnard5314f232017-04-21 12:36:59 +02002680 /* check_privkey is free */
Gilles Peskine449bd832023-01-11 14:50:10 +01002681 MBEDTLS_ECP_BUDGET(MBEDTLS_ECP_OPS_CHK);
Manuel Pégourié-Gonnard5314f232017-04-21 12:36:59 +02002682
Manuel Pégourié-Gonnarda08cd1a2017-04-20 11:29:43 +02002683 /* Common sanity checks */
Gilles Peskine449bd832023-01-11 14:50:10 +01002684 MBEDTLS_MPI_CHK(mbedtls_ecp_check_privkey(grp, m));
2685 MBEDTLS_MPI_CHK(mbedtls_ecp_check_pubkey(grp, P));
Manuel Pégourié-Gonnarda08cd1a2017-04-20 11:29:43 +02002686 }
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002687
2688 ret = MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02002689#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01002690 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_MONTGOMERY) {
2691 MBEDTLS_MPI_CHK(ecp_mul_mxz(grp, R, m, P, f_rng, p_rng));
2692 }
Janos Follath430d3372016-11-03 14:25:37 +00002693#endif
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02002694#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01002695 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
2696 MBEDTLS_MPI_CHK(ecp_mul_comb(grp, R, m, P, f_rng, p_rng, rs_ctx));
2697 }
Janos Follath430d3372016-11-03 14:25:37 +00002698#endif
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002699
Janos Follath6c8ccd52016-11-29 15:37:09 +00002700cleanup:
Janos Follathb0697532016-08-18 12:38:46 +01002701
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002702#if defined(MBEDTLS_ECP_INTERNAL_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002703 if (is_grp_capable) {
2704 mbedtls_internal_ecp_free(grp);
2705 }
Janos Follathc44ab972016-11-18 16:38:23 +00002706#endif /* MBEDTLS_ECP_INTERNAL_ALT */
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002707
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002708#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002709 if (rs_ctx != NULL) {
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002710 rs_ctx->depth--;
Gilles Peskine449bd832023-01-11 14:50:10 +01002711 }
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002712#endif
2713
Gilles Peskine449bd832023-01-11 14:50:10 +01002714 return ret;
Manuel Pégourié-Gonnarda0179b82013-12-04 11:49:20 +01002715}
2716
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +02002717/*
Manuel Pégourié-Gonnard75525ae2021-06-15 11:29:26 +02002718 * Restartable multiplication R = m * P
2719 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002720int mbedtls_ecp_mul_restartable(mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2721 const mbedtls_mpi *m, const mbedtls_ecp_point *P,
2722 int (*f_rng)(void *, unsigned char *, size_t), void *p_rng,
2723 mbedtls_ecp_restart_ctx *rs_ctx)
Manuel Pégourié-Gonnard75525ae2021-06-15 11:29:26 +02002724{
Gilles Peskine449bd832023-01-11 14:50:10 +01002725 if (f_rng == NULL) {
2726 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
2727 }
Manuel Pégourié-Gonnard75525ae2021-06-15 11:29:26 +02002728
Gilles Peskine449bd832023-01-11 14:50:10 +01002729 return ecp_mul_restartable_internal(grp, R, m, P, f_rng, p_rng, rs_ctx);
Manuel Pégourié-Gonnard75525ae2021-06-15 11:29:26 +02002730}
2731
2732/*
Manuel Pégourié-Gonnard884569c2017-04-20 10:10:59 +02002733 * Multiplication R = m * P
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +02002734 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002735int mbedtls_ecp_mul(mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2736 const mbedtls_mpi *m, const mbedtls_ecp_point *P,
2737 int (*f_rng)(void *, unsigned char *, size_t), void *p_rng)
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +02002738{
Gilles Peskine449bd832023-01-11 14:50:10 +01002739 return mbedtls_ecp_mul_restartable(grp, R, m, P, f_rng, p_rng, NULL);
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +02002740}
Valerio Settifd122f42023-04-05 18:15:32 +02002741#endif /* MBEDTLS_ECP_C */
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +02002742
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02002743#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Manuel Pégourié-Gonnarda0179b82013-12-04 11:49:20 +01002744/*
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01002745 * Check that an affine point is valid as a public key,
2746 * short weierstrass curves (SEC1 3.2.3.1)
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002747 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002748static int ecp_check_pubkey_sw(const mbedtls_ecp_group *grp, const mbedtls_ecp_point *pt)
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002749{
Janos Follath24eed8d2019-11-22 13:21:35 +00002750 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02002751 mbedtls_mpi YY, RHS;
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002752
Manuel Pégourié-Gonnard312d2e82013-12-04 11:08:01 +01002753 /* pt coordinates must be normalized for our checks */
Gilles Peskine449bd832023-01-11 14:50:10 +01002754 if (mbedtls_mpi_cmp_int(&pt->X, 0) < 0 ||
2755 mbedtls_mpi_cmp_int(&pt->Y, 0) < 0 ||
2756 mbedtls_mpi_cmp_mpi(&pt->X, &grp->P) >= 0 ||
2757 mbedtls_mpi_cmp_mpi(&pt->Y, &grp->P) >= 0) {
2758 return MBEDTLS_ERR_ECP_INVALID_KEY;
2759 }
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002760
Gilles Peskine449bd832023-01-11 14:50:10 +01002761 mbedtls_mpi_init(&YY); mbedtls_mpi_init(&RHS);
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002762
2763 /*
2764 * YY = Y^2
Manuel Pégourié-Gonnard8b6d14b2022-12-20 10:02:52 +01002765 * RHS = X^3 + A X + B
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002766 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002767 MPI_ECP_SQR(&YY, &pt->Y);
2768 MBEDTLS_MPI_CHK(ecp_sw_rhs(grp, &RHS, &pt->X));
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002769
Gilles Peskine449bd832023-01-11 14:50:10 +01002770 if (MPI_ECP_CMP(&YY, &RHS) != 0) {
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02002771 ret = MBEDTLS_ERR_ECP_INVALID_KEY;
Gilles Peskine449bd832023-01-11 14:50:10 +01002772 }
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002773
2774cleanup:
2775
Gilles Peskine449bd832023-01-11 14:50:10 +01002776 mbedtls_mpi_free(&YY); mbedtls_mpi_free(&RHS);
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002777
Gilles Peskine449bd832023-01-11 14:50:10 +01002778 return ret;
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002779}
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02002780#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01002781
Valerio Settifd122f42023-04-05 18:15:32 +02002782#if defined(MBEDTLS_ECP_C)
Gilles Peskine9b99a892018-09-14 18:32:19 +02002783#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002784/*
TRodziewicz9edff742021-03-04 17:59:39 +01002785 * R = m * P with shortcuts for m == 0, m == 1 and m == -1
Manuel Pégourié-Gonnardde9f9532015-10-23 15:50:37 +02002786 * NOT constant-time - ONLY for short Weierstrass!
2787 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002788static int mbedtls_ecp_mul_shortcuts(mbedtls_ecp_group *grp,
2789 mbedtls_ecp_point *R,
2790 const mbedtls_mpi *m,
2791 const mbedtls_ecp_point *P,
2792 mbedtls_ecp_restart_ctx *rs_ctx)
Manuel Pégourié-Gonnardde9f9532015-10-23 15:50:37 +02002793{
Janos Follath24eed8d2019-11-22 13:21:35 +00002794 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Hanno Beckerc27a0e02022-01-06 05:56:34 +00002795 mbedtls_mpi tmp;
Gilles Peskine449bd832023-01-11 14:50:10 +01002796 mbedtls_mpi_init(&tmp);
Manuel Pégourié-Gonnardde9f9532015-10-23 15:50:37 +02002797
Gilles Peskine449bd832023-01-11 14:50:10 +01002798 if (mbedtls_mpi_cmp_int(m, 0) == 0) {
2799 MBEDTLS_MPI_CHK(mbedtls_ecp_check_pubkey(grp, P));
2800 MBEDTLS_MPI_CHK(mbedtls_ecp_set_zero(R));
2801 } else if (mbedtls_mpi_cmp_int(m, 1) == 0) {
2802 MBEDTLS_MPI_CHK(mbedtls_ecp_check_pubkey(grp, P));
2803 MBEDTLS_MPI_CHK(mbedtls_ecp_copy(R, P));
2804 } else if (mbedtls_mpi_cmp_int(m, -1) == 0) {
2805 MBEDTLS_MPI_CHK(mbedtls_ecp_check_pubkey(grp, P));
2806 MBEDTLS_MPI_CHK(mbedtls_ecp_copy(R, P));
2807 MPI_ECP_NEG(&R->Y);
2808 } else {
2809 MBEDTLS_MPI_CHK(ecp_mul_restartable_internal(grp, R, m, P,
2810 NULL, NULL, rs_ctx));
Manuel Pégourié-Gonnardde9f9532015-10-23 15:50:37 +02002811 }
2812
2813cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01002814 mbedtls_mpi_free(&tmp);
Hanno Beckerc27a0e02022-01-06 05:56:34 +00002815
Gilles Peskine449bd832023-01-11 14:50:10 +01002816 return ret;
Manuel Pégourié-Gonnardde9f9532015-10-23 15:50:37 +02002817}
2818
2819/*
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +02002820 * Restartable linear combination
Manuel Pégourié-Gonnardde9f9532015-10-23 15:50:37 +02002821 * NOT constant-time
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002822 */
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +02002823int mbedtls_ecp_muladd_restartable(
Gilles Peskine449bd832023-01-11 14:50:10 +01002824 mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2825 const mbedtls_mpi *m, const mbedtls_ecp_point *P,
2826 const mbedtls_mpi *n, const mbedtls_ecp_point *Q,
2827 mbedtls_ecp_restart_ctx *rs_ctx)
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002828{
Janos Follath24eed8d2019-11-22 13:21:35 +00002829 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002830 mbedtls_ecp_point mP;
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002831 mbedtls_ecp_point *pmP = &mP;
2832 mbedtls_ecp_point *pR = R;
Hanno Becker3b29f212022-01-04 07:34:14 +00002833 mbedtls_mpi tmp[4];
Janos Follathc44ab972016-11-18 16:38:23 +00002834#if defined(MBEDTLS_ECP_INTERNAL_ALT)
2835 char is_grp_capable = 0;
2836#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01002837 if (mbedtls_ecp_get_type(grp) != MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
2838 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
2839 }
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002840
Gilles Peskine449bd832023-01-11 14:50:10 +01002841 mbedtls_ecp_point_init(&mP);
2842 mpi_init_many(tmp, sizeof(tmp) / sizeof(mbedtls_mpi));
Hanno Becker3b29f212022-01-04 07:34:14 +00002843
Gilles Peskine449bd832023-01-11 14:50:10 +01002844 ECP_RS_ENTER(ma);
Manuel Pégourié-Gonnarddb4a8eb2017-08-23 18:18:22 +02002845
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002846#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002847 if (rs_ctx != NULL && rs_ctx->ma != NULL) {
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002848 /* redirect intermediate results to restart context */
2849 pmP = &rs_ctx->ma->mP;
2850 pR = &rs_ctx->ma->R;
2851
2852 /* jump to next operation */
Gilles Peskine449bd832023-01-11 14:50:10 +01002853 if (rs_ctx->ma->state == ecp_rsma_mul2) {
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002854 goto mul2;
Gilles Peskine449bd832023-01-11 14:50:10 +01002855 }
2856 if (rs_ctx->ma->state == ecp_rsma_add) {
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002857 goto add;
Gilles Peskine449bd832023-01-11 14:50:10 +01002858 }
2859 if (rs_ctx->ma->state == ecp_rsma_norm) {
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002860 goto norm;
Gilles Peskine449bd832023-01-11 14:50:10 +01002861 }
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002862 }
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002863#endif /* MBEDTLS_ECP_RESTARTABLE */
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +02002864
Gilles Peskine449bd832023-01-11 14:50:10 +01002865 MBEDTLS_MPI_CHK(mbedtls_ecp_mul_shortcuts(grp, pmP, m, P, rs_ctx));
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002866#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002867 if (rs_ctx != NULL && rs_ctx->ma != NULL) {
Manuel Pégourié-Gonnardc9efa002017-08-24 10:25:06 +02002868 rs_ctx->ma->state = ecp_rsma_mul2;
Gilles Peskine449bd832023-01-11 14:50:10 +01002869 }
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002870
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002871mul2:
2872#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01002873 MBEDTLS_MPI_CHK(mbedtls_ecp_mul_shortcuts(grp, pR, n, Q, rs_ctx));
Andrzej Kurekc470b6b2019-01-31 08:20:20 -05002874
2875#if defined(MBEDTLS_ECP_INTERNAL_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002876 if ((is_grp_capable = mbedtls_internal_ecp_grp_capable(grp))) {
2877 MBEDTLS_MPI_CHK(mbedtls_internal_ecp_init(grp));
2878 }
Andrzej Kurekc470b6b2019-01-31 08:20:20 -05002879#endif /* MBEDTLS_ECP_INTERNAL_ALT */
2880
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002881#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002882 if (rs_ctx != NULL && rs_ctx->ma != NULL) {
Manuel Pégourié-Gonnardc9efa002017-08-24 10:25:06 +02002883 rs_ctx->ma->state = ecp_rsma_add;
Gilles Peskine449bd832023-01-11 14:50:10 +01002884 }
Manuel Pégourié-Gonnard1a7c5ef2015-08-13 10:19:09 +02002885
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002886add:
2887#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01002888 MBEDTLS_ECP_BUDGET(MBEDTLS_ECP_OPS_ADD);
2889 MBEDTLS_MPI_CHK(ecp_add_mixed(grp, pR, pmP, pR, tmp));
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002890#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002891 if (rs_ctx != NULL && rs_ctx->ma != NULL) {
Manuel Pégourié-Gonnardc9efa002017-08-24 10:25:06 +02002892 rs_ctx->ma->state = ecp_rsma_norm;
Gilles Peskine449bd832023-01-11 14:50:10 +01002893 }
Janos Follath430d3372016-11-03 14:25:37 +00002894
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002895norm:
2896#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01002897 MBEDTLS_ECP_BUDGET(MBEDTLS_ECP_OPS_INV);
2898 MBEDTLS_MPI_CHK(ecp_normalize_jac(grp, pR));
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002899
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002900#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002901 if (rs_ctx != NULL && rs_ctx->ma != NULL) {
2902 MBEDTLS_MPI_CHK(mbedtls_ecp_copy(R, pR));
2903 }
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002904#endif
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002905
2906cleanup:
Hanno Becker3b29f212022-01-04 07:34:14 +00002907
Gilles Peskine449bd832023-01-11 14:50:10 +01002908 mpi_free_many(tmp, sizeof(tmp) / sizeof(mbedtls_mpi));
Hanno Becker3b29f212022-01-04 07:34:14 +00002909
Janos Follathc44ab972016-11-18 16:38:23 +00002910#if defined(MBEDTLS_ECP_INTERNAL_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002911 if (is_grp_capable) {
2912 mbedtls_internal_ecp_free(grp);
2913 }
Janos Follathc44ab972016-11-18 16:38:23 +00002914#endif /* MBEDTLS_ECP_INTERNAL_ALT */
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002915
Gilles Peskine449bd832023-01-11 14:50:10 +01002916 mbedtls_ecp_point_free(&mP);
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002917
Gilles Peskine449bd832023-01-11 14:50:10 +01002918 ECP_RS_LEAVE(ma);
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +02002919
Gilles Peskine449bd832023-01-11 14:50:10 +01002920 return ret;
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002921}
2922
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +02002923/*
2924 * Linear combination
2925 * NOT constant-time
2926 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002927int mbedtls_ecp_muladd(mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2928 const mbedtls_mpi *m, const mbedtls_ecp_point *P,
2929 const mbedtls_mpi *n, const mbedtls_ecp_point *Q)
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +02002930{
Gilles Peskine449bd832023-01-11 14:50:10 +01002931 return mbedtls_ecp_muladd_restartable(grp, R, m, P, n, Q, NULL);
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +02002932}
Gilles Peskine9b99a892018-09-14 18:32:19 +02002933#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
Valerio Settifd122f42023-04-05 18:15:32 +02002934#endif /* MBEDTLS_ECP_C */
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01002935
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02002936#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02002937#if defined(MBEDTLS_ECP_DP_CURVE25519_ENABLED)
Dave Rodgmanb8f18852023-07-18 12:45:17 +01002938#define ECP_MPI_INIT(_p, _n) { .p = (mbedtls_mpi_uint *) (_p), .s = 1, .n = (_n) }
Manuel Pégourié-Gonnard06215ea2021-06-23 12:53:18 +02002939#define ECP_MPI_INIT_ARRAY(x) \
Dave Rodgmanb8f18852023-07-18 12:45:17 +01002940 ECP_MPI_INIT(x, sizeof(x) / sizeof(mbedtls_mpi_uint))
Manuel Pégourié-Gonnard06215ea2021-06-23 12:53:18 +02002941/*
2942 * Constants for the two points other than 0, 1, -1 (mod p) in
2943 * https://cr.yp.to/ecdh.html#validate
2944 * See ecp_check_pubkey_x25519().
2945 */
2946static const mbedtls_mpi_uint x25519_bad_point_1[] = {
Gilles Peskine449bd832023-01-11 14:50:10 +01002947 MBEDTLS_BYTES_TO_T_UINT_8(0xe0, 0xeb, 0x7a, 0x7c, 0x3b, 0x41, 0xb8, 0xae),
2948 MBEDTLS_BYTES_TO_T_UINT_8(0x16, 0x56, 0xe3, 0xfa, 0xf1, 0x9f, 0xc4, 0x6a),
2949 MBEDTLS_BYTES_TO_T_UINT_8(0xda, 0x09, 0x8d, 0xeb, 0x9c, 0x32, 0xb1, 0xfd),
2950 MBEDTLS_BYTES_TO_T_UINT_8(0x86, 0x62, 0x05, 0x16, 0x5f, 0x49, 0xb8, 0x00),
Manuel Pégourié-Gonnard06215ea2021-06-23 12:53:18 +02002951};
2952static const mbedtls_mpi_uint x25519_bad_point_2[] = {
Gilles Peskine449bd832023-01-11 14:50:10 +01002953 MBEDTLS_BYTES_TO_T_UINT_8(0x5f, 0x9c, 0x95, 0xbc, 0xa3, 0x50, 0x8c, 0x24),
2954 MBEDTLS_BYTES_TO_T_UINT_8(0xb1, 0xd0, 0xb1, 0x55, 0x9c, 0x83, 0xef, 0x5b),
2955 MBEDTLS_BYTES_TO_T_UINT_8(0x04, 0x44, 0x5c, 0xc4, 0x58, 0x1c, 0x8e, 0x86),
2956 MBEDTLS_BYTES_TO_T_UINT_8(0xd8, 0x22, 0x4e, 0xdd, 0xd0, 0x9f, 0x11, 0x57),
Manuel Pégourié-Gonnard06215ea2021-06-23 12:53:18 +02002957};
2958static const mbedtls_mpi ecp_x25519_bad_point_1 = ECP_MPI_INIT_ARRAY(
Gilles Peskine449bd832023-01-11 14:50:10 +01002959 x25519_bad_point_1);
Manuel Pégourié-Gonnard06215ea2021-06-23 12:53:18 +02002960static const mbedtls_mpi ecp_x25519_bad_point_2 = ECP_MPI_INIT_ARRAY(
Gilles Peskine449bd832023-01-11 14:50:10 +01002961 x25519_bad_point_2);
Janos Follath865a75e2021-06-24 15:34:59 +01002962#endif /* MBEDTLS_ECP_DP_CURVE25519_ENABLED */
Manuel Pégourié-Gonnard2389a602021-06-23 12:25:48 +02002963
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02002964/*
2965 * Check that the input point is not one of the low-order points.
2966 * This is recommended by the "May the Fourth" paper:
2967 * https://eprint.iacr.org/2017/806.pdf
2968 * Those points are never sent by an honest peer.
2969 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002970static int ecp_check_bad_points_mx(const mbedtls_mpi *X, const mbedtls_mpi *P,
2971 const mbedtls_ecp_group_id grp_id)
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02002972{
2973 int ret;
Manuel Pégourié-Gonnard2389a602021-06-23 12:25:48 +02002974 mbedtls_mpi XmP;
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02002975
Gilles Peskine449bd832023-01-11 14:50:10 +01002976 mbedtls_mpi_init(&XmP);
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02002977
2978 /* Reduce X mod P so that we only need to check values less than P.
2979 * We know X < 2^256 so we can proceed by subtraction. */
Gilles Peskine449bd832023-01-11 14:50:10 +01002980 MBEDTLS_MPI_CHK(mbedtls_mpi_copy(&XmP, X));
2981 while (mbedtls_mpi_cmp_mpi(&XmP, P) >= 0) {
2982 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_mpi(&XmP, &XmP, P));
2983 }
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02002984
Janos Follath865a75e2021-06-24 15:34:59 +01002985 /* Check against the known bad values that are less than P. For Curve448
2986 * these are 0, 1 and -1. For Curve25519 we check the values less than P
2987 * from the following list: https://cr.yp.to/ecdh.html#validate */
Gilles Peskine449bd832023-01-11 14:50:10 +01002988 if (mbedtls_mpi_cmp_int(&XmP, 1) <= 0) { /* takes care of 0 and 1 */
Janos Follath8081ced2021-06-24 14:24:13 +01002989 ret = MBEDTLS_ERR_ECP_INVALID_KEY;
2990 goto cleanup;
2991 }
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02002992
Janos Follath865a75e2021-06-24 15:34:59 +01002993#if defined(MBEDTLS_ECP_DP_CURVE25519_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01002994 if (grp_id == MBEDTLS_ECP_DP_CURVE25519) {
2995 if (mbedtls_mpi_cmp_mpi(&XmP, &ecp_x25519_bad_point_1) == 0) {
Janos Follath865a75e2021-06-24 15:34:59 +01002996 ret = MBEDTLS_ERR_ECP_INVALID_KEY;
2997 goto cleanup;
2998 }
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02002999
Gilles Peskine449bd832023-01-11 14:50:10 +01003000 if (mbedtls_mpi_cmp_mpi(&XmP, &ecp_x25519_bad_point_2) == 0) {
Janos Follath865a75e2021-06-24 15:34:59 +01003001 ret = MBEDTLS_ERR_ECP_INVALID_KEY;
3002 goto cleanup;
3003 }
Janos Follath8081ced2021-06-24 14:24:13 +01003004 }
Janos Follath83e384d2021-06-25 15:29:56 +01003005#else
3006 (void) grp_id;
Janos Follath865a75e2021-06-24 15:34:59 +01003007#endif
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02003008
Manuel Pégourié-Gonnard2389a602021-06-23 12:25:48 +02003009 /* Final check: check if XmP + 1 is P (final because it changes XmP!) */
Gilles Peskine449bd832023-01-11 14:50:10 +01003010 MBEDTLS_MPI_CHK(mbedtls_mpi_add_int(&XmP, &XmP, 1));
3011 if (mbedtls_mpi_cmp_mpi(&XmP, P) == 0) {
Janos Follath8081ced2021-06-24 14:24:13 +01003012 ret = MBEDTLS_ERR_ECP_INVALID_KEY;
3013 goto cleanup;
3014 }
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02003015
3016 ret = 0;
3017
3018cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01003019 mbedtls_mpi_free(&XmP);
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02003020
Gilles Peskine449bd832023-01-11 14:50:10 +01003021 return ret;
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02003022}
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02003023
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003024/*
3025 * Check validity of a public key for Montgomery curves with x-only schemes
3026 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003027static int ecp_check_pubkey_mx(const mbedtls_ecp_group *grp, const mbedtls_ecp_point *pt)
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003028{
Manuel Pégourié-Gonnard07894332015-06-23 00:18:41 +02003029 /* [Curve25519 p. 5] Just check X is the correct number of bytes */
Nicholas Wilson08f3ef12015-11-10 13:10:01 +00003030 /* Allow any public value, if it's too big then we'll just reduce it mod p
3031 * (RFC 7748 sec. 5 para. 3). */
Gilles Peskine449bd832023-01-11 14:50:10 +01003032 if (mbedtls_mpi_size(&pt->X) > (grp->nbits + 7) / 8) {
3033 return MBEDTLS_ERR_ECP_INVALID_KEY;
3034 }
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003035
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02003036 /* Implicit in all standards (as they don't consider negative numbers):
3037 * X must be non-negative. This is normally ensured by the way it's
3038 * encoded for transmission, but let's be extra sure. */
Gilles Peskine449bd832023-01-11 14:50:10 +01003039 if (mbedtls_mpi_cmp_int(&pt->X, 0) < 0) {
3040 return MBEDTLS_ERR_ECP_INVALID_KEY;
3041 }
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02003042
Gilles Peskine449bd832023-01-11 14:50:10 +01003043 return ecp_check_bad_points_mx(&pt->X, &grp->P, grp->id);
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003044}
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003045#endif /* MBEDTLS_ECP_MONTGOMERY_ENABLED */
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003046
3047/*
3048 * Check that a point is valid as a public key
3049 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003050int mbedtls_ecp_check_pubkey(const mbedtls_ecp_group *grp,
3051 const mbedtls_ecp_point *pt)
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003052{
3053 /* Must use affine coordinates */
Gilles Peskine449bd832023-01-11 14:50:10 +01003054 if (mbedtls_mpi_cmp_int(&pt->Z, 1) != 0) {
3055 return MBEDTLS_ERR_ECP_INVALID_KEY;
3056 }
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003057
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003058#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003059 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_MONTGOMERY) {
3060 return ecp_check_pubkey_mx(grp, pt);
3061 }
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003062#endif
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003063#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003064 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
3065 return ecp_check_pubkey_sw(grp, pt);
3066 }
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003067#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01003068 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003069}
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02003070
3071/*
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02003072 * Check that an mbedtls_mpi is valid as a private key
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02003073 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003074int mbedtls_ecp_check_privkey(const mbedtls_ecp_group *grp,
3075 const mbedtls_mpi *d)
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02003076{
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003077#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003078 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_MONTGOMERY) {
Nicholas Wilson08f3ef12015-11-10 13:10:01 +00003079 /* see RFC 7748 sec. 5 para. 5 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003080 if (mbedtls_mpi_get_bit(d, 0) != 0 ||
3081 mbedtls_mpi_get_bit(d, 1) != 0 ||
3082 mbedtls_mpi_bitlen(d) - 1 != grp->nbits) { /* mbedtls_mpi_bitlen is one-based! */
3083 return MBEDTLS_ERR_ECP_INVALID_KEY;
3084 }
Nicholas Wilson08f3ef12015-11-10 13:10:01 +00003085
3086 /* see [Curve25519] page 5 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003087 if (grp->nbits == 254 && mbedtls_mpi_get_bit(d, 2) != 0) {
3088 return MBEDTLS_ERR_ECP_INVALID_KEY;
3089 }
Nicholas Wilson08f3ef12015-11-10 13:10:01 +00003090
Gilles Peskine449bd832023-01-11 14:50:10 +01003091 return 0;
Manuel Pégourié-Gonnard312d2e82013-12-04 11:08:01 +01003092 }
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003093#endif /* MBEDTLS_ECP_MONTGOMERY_ENABLED */
3094#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003095 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
Manuel Pégourié-Gonnard312d2e82013-12-04 11:08:01 +01003096 /* see SEC1 3.2 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003097 if (mbedtls_mpi_cmp_int(d, 1) < 0 ||
3098 mbedtls_mpi_cmp_mpi(d, &grp->N) >= 0) {
3099 return MBEDTLS_ERR_ECP_INVALID_KEY;
3100 } else {
3101 return 0;
3102 }
Manuel Pégourié-Gonnard312d2e82013-12-04 11:08:01 +01003103 }
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003104#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02003105
Gilles Peskine449bd832023-01-11 14:50:10 +01003106 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02003107}
3108
Gilles Peskine72fcc982021-03-23 22:31:31 +01003109#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
3110MBEDTLS_STATIC_TESTABLE
Gilles Peskine449bd832023-01-11 14:50:10 +01003111int mbedtls_ecp_gen_privkey_mx(size_t high_bit,
3112 mbedtls_mpi *d,
3113 int (*f_rng)(void *, unsigned char *, size_t),
3114 void *p_rng)
Gilles Peskine72fcc982021-03-23 22:31:31 +01003115{
3116 int ret = MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Gilles Peskine61f1f5f2021-03-24 12:46:46 +01003117 size_t n_random_bytes = high_bit / 8 + 1;
Gilles Peskine72fcc982021-03-23 22:31:31 +01003118
3119 /* [Curve25519] page 5 */
Gilles Peskine61f1f5f2021-03-24 12:46:46 +01003120 /* Generate a (high_bit+1)-bit random number by generating just enough
3121 * random bytes, then shifting out extra bits from the top (necessary
3122 * when (high_bit+1) is not a multiple of 8). */
Gilles Peskine449bd832023-01-11 14:50:10 +01003123 MBEDTLS_MPI_CHK(mbedtls_mpi_fill_random(d, n_random_bytes,
3124 f_rng, p_rng));
3125 MBEDTLS_MPI_CHK(mbedtls_mpi_shift_r(d, 8 * n_random_bytes - high_bit - 1));
Gilles Peskine72fcc982021-03-23 22:31:31 +01003126
Gilles Peskine449bd832023-01-11 14:50:10 +01003127 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(d, high_bit, 1));
Gilles Peskine72fcc982021-03-23 22:31:31 +01003128
3129 /* Make sure the last two bits are unset for Curve448, three bits for
3130 Curve25519 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003131 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(d, 0, 0));
3132 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(d, 1, 0));
3133 if (high_bit == 254) {
3134 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(d, 2, 0));
Gilles Peskine72fcc982021-03-23 22:31:31 +01003135 }
3136
3137cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01003138 return ret;
Gilles Peskine72fcc982021-03-23 22:31:31 +01003139}
3140#endif /* MBEDTLS_ECP_MONTGOMERY_ENABLED */
3141
Gilles Peskine60d8b982021-03-29 22:28:21 +02003142#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
3143static int mbedtls_ecp_gen_privkey_sw(
3144 const mbedtls_mpi *N, mbedtls_mpi *d,
Gilles Peskine449bd832023-01-11 14:50:10 +01003145 int (*f_rng)(void *, unsigned char *, size_t), void *p_rng)
Gilles Peskine60d8b982021-03-29 22:28:21 +02003146{
Gilles Peskine449bd832023-01-11 14:50:10 +01003147 int ret = mbedtls_mpi_random(d, 1, N, f_rng, p_rng);
3148 switch (ret) {
Gilles Peskine60d8b982021-03-29 22:28:21 +02003149 case MBEDTLS_ERR_MPI_NOT_ACCEPTABLE:
Gilles Peskine449bd832023-01-11 14:50:10 +01003150 return MBEDTLS_ERR_ECP_RANDOM_FAILED;
Gilles Peskine60d8b982021-03-29 22:28:21 +02003151 default:
Gilles Peskine449bd832023-01-11 14:50:10 +01003152 return ret;
Gilles Peskine60d8b982021-03-29 22:28:21 +02003153 }
3154}
3155#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
3156
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02003157/*
Manuel Pégourié-Gonnarda7937f92017-04-20 15:37:46 +02003158 * Generate a private key
Manuel Pégourié-Gonnard45a035a2013-01-26 14:42:45 +01003159 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003160int mbedtls_ecp_gen_privkey(const mbedtls_ecp_group *grp,
3161 mbedtls_mpi *d,
3162 int (*f_rng)(void *, unsigned char *, size_t),
3163 void *p_rng)
Manuel Pégourié-Gonnard45a035a2013-01-26 14:42:45 +01003164{
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003165#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003166 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_MONTGOMERY) {
3167 return mbedtls_ecp_gen_privkey_mx(grp->nbits, d, f_rng, p_rng);
3168 }
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003169#endif /* MBEDTLS_ECP_MONTGOMERY_ENABLED */
Manuel Pégourié-Gonnarda7937f92017-04-20 15:37:46 +02003170
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003171#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003172 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
3173 return mbedtls_ecp_gen_privkey_sw(&grp->N, d, f_rng, p_rng);
3174 }
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003175#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
Manuel Pégourié-Gonnard45a035a2013-01-26 14:42:45 +01003176
Gilles Peskine449bd832023-01-11 14:50:10 +01003177 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Manuel Pégourié-Gonnarda7937f92017-04-20 15:37:46 +02003178}
Manuel Pégourié-Gonnardc9573992014-01-03 12:54:00 +01003179
Valerio Settifd122f42023-04-05 18:15:32 +02003180#if defined(MBEDTLS_ECP_C)
Manuel Pégourié-Gonnarda7937f92017-04-20 15:37:46 +02003181/*
3182 * Generate a keypair with configurable base point
3183 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003184int mbedtls_ecp_gen_keypair_base(mbedtls_ecp_group *grp,
3185 const mbedtls_ecp_point *G,
3186 mbedtls_mpi *d, mbedtls_ecp_point *Q,
3187 int (*f_rng)(void *, unsigned char *, size_t),
3188 void *p_rng)
Manuel Pégourié-Gonnarda7937f92017-04-20 15:37:46 +02003189{
Janos Follath24eed8d2019-11-22 13:21:35 +00003190 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +01003191 MBEDTLS_MPI_CHK(mbedtls_ecp_gen_privkey(grp, d, f_rng, p_rng));
3192 MBEDTLS_MPI_CHK(mbedtls_ecp_mul(grp, Q, d, G, f_rng, p_rng));
Manuel Pégourié-Gonnarda7937f92017-04-20 15:37:46 +02003193
3194cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01003195 return ret;
Manuel Pégourié-Gonnardd9a3f472015-08-11 14:31:03 +02003196}
3197
3198/*
3199 * Generate key pair, wrapper for conventional base point
3200 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003201int mbedtls_ecp_gen_keypair(mbedtls_ecp_group *grp,
3202 mbedtls_mpi *d, mbedtls_ecp_point *Q,
3203 int (*f_rng)(void *, unsigned char *, size_t),
3204 void *p_rng)
Manuel Pégourié-Gonnardd9a3f472015-08-11 14:31:03 +02003205{
Gilles Peskine449bd832023-01-11 14:50:10 +01003206 return mbedtls_ecp_gen_keypair_base(grp, &grp->G, d, Q, f_rng, p_rng);
Manuel Pégourié-Gonnard45a035a2013-01-26 14:42:45 +01003207}
Manuel Pégourié-Gonnardefaa31e2012-11-06 21:34:35 +01003208
Manuel Pégourié-Gonnard104ee1d2013-11-30 14:13:16 +01003209/*
3210 * Generate a keypair, prettier wrapper
3211 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003212int mbedtls_ecp_gen_key(mbedtls_ecp_group_id grp_id, mbedtls_ecp_keypair *key,
3213 int (*f_rng)(void *, unsigned char *, size_t), void *p_rng)
Manuel Pégourié-Gonnard104ee1d2013-11-30 14:13:16 +01003214{
Janos Follath24eed8d2019-11-22 13:21:35 +00003215 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +01003216 if ((ret = mbedtls_ecp_group_load(&key->grp, grp_id)) != 0) {
3217 return ret;
3218 }
Manuel Pégourié-Gonnard104ee1d2013-11-30 14:13:16 +01003219
Gilles Peskine449bd832023-01-11 14:50:10 +01003220 return mbedtls_ecp_gen_keypair(&key->grp, &key->d, &key->Q, f_rng, p_rng);
Manuel Pégourié-Gonnard104ee1d2013-11-30 14:13:16 +01003221}
Valerio Settifd122f42023-04-05 18:15:32 +02003222#endif /* MBEDTLS_ECP_C */
Manuel Pégourié-Gonnard104ee1d2013-11-30 14:13:16 +01003223
Janos Follath77800962019-02-25 16:32:08 +00003224#define ECP_CURVE25519_KEY_SIZE 32
Archana1d2e2bb2021-06-07 06:13:16 +05303225#define ECP_CURVE448_KEY_SIZE 56
Janos Follath171a7ef2019-02-15 16:17:45 +00003226/*
3227 * Read a private key.
3228 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003229int mbedtls_ecp_read_key(mbedtls_ecp_group_id grp_id, mbedtls_ecp_keypair *key,
3230 const unsigned char *buf, size_t buflen)
Janos Follath171a7ef2019-02-15 16:17:45 +00003231{
3232 int ret = 0;
3233
Gilles Peskine449bd832023-01-11 14:50:10 +01003234 if ((ret = mbedtls_ecp_group_load(&key->grp, grp_id)) != 0) {
3235 return ret;
3236 }
Janos Follath171a7ef2019-02-15 16:17:45 +00003237
Janos Follath28eb06d2019-02-26 10:53:34 +00003238 ret = MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
3239
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003240#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003241 if (mbedtls_ecp_get_type(&key->grp) == MBEDTLS_ECP_TYPE_MONTGOMERY) {
Janos Follath28eb06d2019-02-26 10:53:34 +00003242 /*
Archana1d2e2bb2021-06-07 06:13:16 +05303243 * Mask the key as mandated by RFC7748 for Curve25519 and Curve448.
Janos Follath28eb06d2019-02-26 10:53:34 +00003244 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003245 if (grp_id == MBEDTLS_ECP_DP_CURVE25519) {
3246 if (buflen != ECP_CURVE25519_KEY_SIZE) {
3247 return MBEDTLS_ERR_ECP_INVALID_KEY;
3248 }
Janos Follath171a7ef2019-02-15 16:17:45 +00003249
Gilles Peskine449bd832023-01-11 14:50:10 +01003250 MBEDTLS_MPI_CHK(mbedtls_mpi_read_binary_le(&key->d, buf, buflen));
Janos Follath171a7ef2019-02-15 16:17:45 +00003251
Janos Follath28eb06d2019-02-26 10:53:34 +00003252 /* Set the three least significant bits to 0 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003253 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(&key->d, 0, 0));
3254 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(&key->d, 1, 0));
3255 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(&key->d, 2, 0));
Janos Follath171a7ef2019-02-15 16:17:45 +00003256
Janos Follath28eb06d2019-02-26 10:53:34 +00003257 /* Set the most significant bit to 0 */
3258 MBEDTLS_MPI_CHK(
Gilles Peskine449bd832023-01-11 14:50:10 +01003259 mbedtls_mpi_set_bit(&key->d,
3260 ECP_CURVE25519_KEY_SIZE * 8 - 1, 0)
3261 );
Janos Follath171a7ef2019-02-15 16:17:45 +00003262
Janos Follath28eb06d2019-02-26 10:53:34 +00003263 /* Set the second most significant bit to 1 */
3264 MBEDTLS_MPI_CHK(
Gilles Peskine449bd832023-01-11 14:50:10 +01003265 mbedtls_mpi_set_bit(&key->d,
3266 ECP_CURVE25519_KEY_SIZE * 8 - 2, 1)
3267 );
3268 } else if (grp_id == MBEDTLS_ECP_DP_CURVE448) {
3269 if (buflen != ECP_CURVE448_KEY_SIZE) {
3270 return MBEDTLS_ERR_ECP_INVALID_KEY;
3271 }
Archana1d2e2bb2021-06-07 06:13:16 +05303272
Gilles Peskine449bd832023-01-11 14:50:10 +01003273 MBEDTLS_MPI_CHK(mbedtls_mpi_read_binary_le(&key->d, buf, buflen));
Archana1d2e2bb2021-06-07 06:13:16 +05303274
3275 /* Set the two least significant bits to 0 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003276 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(&key->d, 0, 0));
3277 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(&key->d, 1, 0));
Archana1d2e2bb2021-06-07 06:13:16 +05303278
3279 /* Set the most significant bit to 1 */
3280 MBEDTLS_MPI_CHK(
Gilles Peskine449bd832023-01-11 14:50:10 +01003281 mbedtls_mpi_set_bit(&key->d,
3282 ECP_CURVE448_KEY_SIZE * 8 - 1, 1)
3283 );
Archana1d2e2bb2021-06-07 06:13:16 +05303284 }
Janos Follath171a7ef2019-02-15 16:17:45 +00003285 }
Janos Follath171a7ef2019-02-15 16:17:45 +00003286#endif
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003287#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003288 if (mbedtls_ecp_get_type(&key->grp) == MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
3289 MBEDTLS_MPI_CHK(mbedtls_mpi_read_binary(&key->d, buf, buflen));
Janos Follath171a7ef2019-02-15 16:17:45 +00003290 }
Janos Follath171a7ef2019-02-15 16:17:45 +00003291#endif
Valerio Setti41b08182023-07-04 12:14:21 +02003292 MBEDTLS_MPI_CHK(mbedtls_ecp_check_privkey(&key->grp, &key->d));
3293
Janos Follath171a7ef2019-02-15 16:17:45 +00003294cleanup:
3295
Gilles Peskine449bd832023-01-11 14:50:10 +01003296 if (ret != 0) {
3297 mbedtls_mpi_free(&key->d);
3298 }
Janos Follath171a7ef2019-02-15 16:17:45 +00003299
Gilles Peskine449bd832023-01-11 14:50:10 +01003300 return ret;
Janos Follath171a7ef2019-02-15 16:17:45 +00003301}
3302
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003303/*
Steven Cooremande8593f2020-06-09 19:55:26 +02003304 * Write a private key.
3305 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003306int mbedtls_ecp_write_key(mbedtls_ecp_keypair *key,
3307 unsigned char *buf, size_t buflen)
Steven Cooremande8593f2020-06-09 19:55:26 +02003308{
Steven Cooreman0024df62020-07-13 10:59:40 +02003309 int ret = MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooremande8593f2020-06-09 19:55:26 +02003310
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003311#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003312 if (mbedtls_ecp_get_type(&key->grp) == MBEDTLS_ECP_TYPE_MONTGOMERY) {
3313 if (key->grp.id == MBEDTLS_ECP_DP_CURVE25519) {
3314 if (buflen < ECP_CURVE25519_KEY_SIZE) {
3315 return MBEDTLS_ERR_ECP_BUFFER_TOO_SMALL;
3316 }
Steven Cooremande8593f2020-06-09 19:55:26 +02003317
Gilles Peskine449bd832023-01-11 14:50:10 +01003318 } else if (key->grp.id == MBEDTLS_ECP_DP_CURVE448) {
3319 if (buflen < ECP_CURVE448_KEY_SIZE) {
3320 return MBEDTLS_ERR_ECP_BUFFER_TOO_SMALL;
3321 }
Steven Cooremande8593f2020-06-09 19:55:26 +02003322 }
Gilles Peskine449bd832023-01-11 14:50:10 +01003323 MBEDTLS_MPI_CHK(mbedtls_mpi_write_binary_le(&key->d, buf, buflen));
Steven Cooremande8593f2020-06-09 19:55:26 +02003324 }
Steven Cooremande8593f2020-06-09 19:55:26 +02003325#endif
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003326#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003327 if (mbedtls_ecp_get_type(&key->grp) == MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
3328 MBEDTLS_MPI_CHK(mbedtls_mpi_write_binary(&key->d, buf, buflen));
Steven Cooremande8593f2020-06-09 19:55:26 +02003329 }
3330
3331#endif
3332cleanup:
3333
Gilles Peskine449bd832023-01-11 14:50:10 +01003334 return ret;
Steven Cooremande8593f2020-06-09 19:55:26 +02003335}
3336
Valerio Settifd122f42023-04-05 18:15:32 +02003337#if defined(MBEDTLS_ECP_C)
Steven Cooremande8593f2020-06-09 19:55:26 +02003338/*
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003339 * Check a public-private key pair
3340 */
Manuel Pégourié-Gonnardf8c24bf2021-06-15 11:29:26 +02003341int mbedtls_ecp_check_pub_priv(
Gilles Peskine449bd832023-01-11 14:50:10 +01003342 const mbedtls_ecp_keypair *pub, const mbedtls_ecp_keypair *prv,
3343 int (*f_rng)(void *, unsigned char *, size_t), void *p_rng)
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003344{
Janos Follath24eed8d2019-11-22 13:21:35 +00003345 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02003346 mbedtls_ecp_point Q;
3347 mbedtls_ecp_group grp;
Gilles Peskine449bd832023-01-11 14:50:10 +01003348 if (pub->grp.id == MBEDTLS_ECP_DP_NONE ||
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003349 pub->grp.id != prv->grp.id ||
Gilles Peskine449bd832023-01-11 14:50:10 +01003350 mbedtls_mpi_cmp_mpi(&pub->Q.X, &prv->Q.X) ||
3351 mbedtls_mpi_cmp_mpi(&pub->Q.Y, &prv->Q.Y) ||
3352 mbedtls_mpi_cmp_mpi(&pub->Q.Z, &prv->Q.Z)) {
3353 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003354 }
3355
Gilles Peskine449bd832023-01-11 14:50:10 +01003356 mbedtls_ecp_point_init(&Q);
3357 mbedtls_ecp_group_init(&grp);
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003358
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02003359 /* mbedtls_ecp_mul() needs a non-const group... */
Gilles Peskine449bd832023-01-11 14:50:10 +01003360 mbedtls_ecp_group_copy(&grp, &prv->grp);
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003361
3362 /* Also checks d is valid */
Gilles Peskine449bd832023-01-11 14:50:10 +01003363 MBEDTLS_MPI_CHK(mbedtls_ecp_mul(&grp, &Q, &prv->d, &prv->grp.G, f_rng, p_rng));
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003364
Gilles Peskine449bd832023-01-11 14:50:10 +01003365 if (mbedtls_mpi_cmp_mpi(&Q.X, &prv->Q.X) ||
3366 mbedtls_mpi_cmp_mpi(&Q.Y, &prv->Q.Y) ||
3367 mbedtls_mpi_cmp_mpi(&Q.Z, &prv->Q.Z)) {
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02003368 ret = MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003369 goto cleanup;
3370 }
3371
3372cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01003373 mbedtls_ecp_point_free(&Q);
3374 mbedtls_ecp_group_free(&grp);
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003375
Gilles Peskine449bd832023-01-11 14:50:10 +01003376 return ret;
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003377}
Valerio Settifd122f42023-04-05 18:15:32 +02003378#endif /* MBEDTLS_ECP_C */
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003379
Przemek Stekiel711d0f52022-03-18 13:52:26 +01003380/*
3381 * Export generic key-pair parameters.
3382 */
3383int mbedtls_ecp_export(const mbedtls_ecp_keypair *key, mbedtls_ecp_group *grp,
3384 mbedtls_mpi *d, mbedtls_ecp_point *Q)
3385{
3386 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Przemek Stekiel711d0f52022-03-18 13:52:26 +01003387
Gilles Peskine449bd832023-01-11 14:50:10 +01003388 if ((ret = mbedtls_ecp_group_copy(grp, &key->grp)) != 0) {
Przemek Stekiel711d0f52022-03-18 13:52:26 +01003389 return ret;
Gilles Peskine449bd832023-01-11 14:50:10 +01003390 }
Przemek Stekiel711d0f52022-03-18 13:52:26 +01003391
Gilles Peskine449bd832023-01-11 14:50:10 +01003392 if ((ret = mbedtls_mpi_copy(d, &key->d)) != 0) {
Przemek Stekiel711d0f52022-03-18 13:52:26 +01003393 return ret;
Gilles Peskine449bd832023-01-11 14:50:10 +01003394 }
Przemek Stekiel711d0f52022-03-18 13:52:26 +01003395
Gilles Peskine449bd832023-01-11 14:50:10 +01003396 if ((ret = mbedtls_ecp_copy(Q, &key->Q)) != 0) {
Przemek Stekiel711d0f52022-03-18 13:52:26 +01003397 return ret;
Gilles Peskine449bd832023-01-11 14:50:10 +01003398 }
Przemek Stekiel711d0f52022-03-18 13:52:26 +01003399
3400 return 0;
3401}
3402
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02003403#if defined(MBEDTLS_SELF_TEST)
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +01003404
Valerio Settifd122f42023-04-05 18:15:32 +02003405#if defined(MBEDTLS_ECP_C)
Manuel Pégourié-Gonnardaa3ed6f2021-06-15 11:29:26 +02003406/*
3407 * PRNG for test - !!!INSECURE NEVER USE IN PRODUCTION!!!
3408 *
3409 * This is the linear congruential generator from numerical recipes,
3410 * except we only use the low byte as the output. See
3411 * https://en.wikipedia.org/wiki/Linear_congruential_generator#Parameters_in_common_use
3412 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003413static int self_test_rng(void *ctx, unsigned char *out, size_t len)
Manuel Pégourié-Gonnardaa3ed6f2021-06-15 11:29:26 +02003414{
3415 static uint32_t state = 42;
3416
3417 (void) ctx;
3418
Gilles Peskine449bd832023-01-11 14:50:10 +01003419 for (size_t i = 0; i < len; i++) {
Manuel Pégourié-Gonnardaa3ed6f2021-06-15 11:29:26 +02003420 state = state * 1664525u + 1013904223u;
3421 out[i] = (unsigned char) state;
3422 }
3423
Gilles Peskine449bd832023-01-11 14:50:10 +01003424 return 0;
Manuel Pégourié-Gonnardaa3ed6f2021-06-15 11:29:26 +02003425}
3426
Gilles Peskine6d9c8d72020-07-22 01:26:25 +02003427/* Adjust the exponent to be a valid private point for the specified curve.
3428 * This is sometimes necessary because we use a single set of exponents
3429 * for all curves but the validity of values depends on the curve. */
Gilles Peskine449bd832023-01-11 14:50:10 +01003430static int self_test_adjust_exponent(const mbedtls_ecp_group *grp,
3431 mbedtls_mpi *m)
Gilles Peskinea088c812018-09-17 18:31:15 +02003432{
3433 int ret = 0;
Gilles Peskine449bd832023-01-11 14:50:10 +01003434 switch (grp->id) {
3435 /* If Curve25519 is available, then that's what we use for the
3436 * Montgomery test, so we don't need the adjustment code. */
3437#if !defined(MBEDTLS_ECP_DP_CURVE25519_ENABLED)
Gilles Peskinea088c812018-09-17 18:31:15 +02003438#if defined(MBEDTLS_ECP_DP_CURVE448_ENABLED)
3439 case MBEDTLS_ECP_DP_CURVE448:
3440 /* Move highest bit from 254 to N-1. Setting bit N-1 is
3441 * necessary to enforce the highest-bit-set constraint. */
Gilles Peskine449bd832023-01-11 14:50:10 +01003442 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(m, 254, 0));
3443 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(m, grp->nbits, 1));
Gilles Peskinea088c812018-09-17 18:31:15 +02003444 /* Copy second-highest bit from 253 to N-2. This is not
3445 * necessary but improves the test variety a bit. */
3446 MBEDTLS_MPI_CHK(
Gilles Peskine449bd832023-01-11 14:50:10 +01003447 mbedtls_mpi_set_bit(m, grp->nbits - 1,
3448 mbedtls_mpi_get_bit(m, 253)));
Gilles Peskinea088c812018-09-17 18:31:15 +02003449 break;
3450#endif
3451#endif /* ! defined(MBEDTLS_ECP_DP_CURVE25519_ENABLED) */
3452 default:
3453 /* Non-Montgomery curves and Curve25519 need no adjustment. */
3454 (void) grp;
3455 (void) m;
3456 goto cleanup;
3457 }
3458cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01003459 return ret;
Gilles Peskinea088c812018-09-17 18:31:15 +02003460}
3461
Gilles Peskine6d9c8d72020-07-22 01:26:25 +02003462/* Calculate R = m.P for each m in exponents. Check that the number of
3463 * basic operations doesn't depend on the value of m. */
Gilles Peskine449bd832023-01-11 14:50:10 +01003464static int self_test_point(int verbose,
3465 mbedtls_ecp_group *grp,
3466 mbedtls_ecp_point *R,
3467 mbedtls_mpi *m,
3468 const mbedtls_ecp_point *P,
3469 const char *const *exponents,
3470 size_t n_exponents)
Gilles Peskinec95696f2018-09-17 15:59:01 +02003471{
3472 int ret = 0;
Gilles Peskine24666792018-09-17 18:29:49 +02003473 size_t i = 0;
Gilles Peskinec95696f2018-09-17 15:59:01 +02003474 unsigned long add_c_prev, dbl_c_prev, mul_c_prev;
3475 add_count = 0;
3476 dbl_count = 0;
3477 mul_count = 0;
Gilles Peskinea088c812018-09-17 18:31:15 +02003478
Gilles Peskine449bd832023-01-11 14:50:10 +01003479 MBEDTLS_MPI_CHK(mbedtls_mpi_read_string(m, 16, exponents[0]));
3480 MBEDTLS_MPI_CHK(self_test_adjust_exponent(grp, m));
3481 MBEDTLS_MPI_CHK(mbedtls_ecp_mul(grp, R, m, P, self_test_rng, NULL));
Gilles Peskinec95696f2018-09-17 15:59:01 +02003482
Gilles Peskine449bd832023-01-11 14:50:10 +01003483 for (i = 1; i < n_exponents; i++) {
Gilles Peskinec95696f2018-09-17 15:59:01 +02003484 add_c_prev = add_count;
3485 dbl_c_prev = dbl_count;
3486 mul_c_prev = mul_count;
3487 add_count = 0;
3488 dbl_count = 0;
3489 mul_count = 0;
3490
Gilles Peskine449bd832023-01-11 14:50:10 +01003491 MBEDTLS_MPI_CHK(mbedtls_mpi_read_string(m, 16, exponents[i]));
3492 MBEDTLS_MPI_CHK(self_test_adjust_exponent(grp, m));
3493 MBEDTLS_MPI_CHK(mbedtls_ecp_mul(grp, R, m, P, self_test_rng, NULL));
Gilles Peskinec95696f2018-09-17 15:59:01 +02003494
Gilles Peskine449bd832023-01-11 14:50:10 +01003495 if (add_count != add_c_prev ||
Gilles Peskinec95696f2018-09-17 15:59:01 +02003496 dbl_count != dbl_c_prev ||
Gilles Peskine449bd832023-01-11 14:50:10 +01003497 mul_count != mul_c_prev) {
Gilles Peskinec95696f2018-09-17 15:59:01 +02003498 ret = 1;
3499 break;
3500 }
3501 }
3502
3503cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01003504 if (verbose != 0) {
3505 if (ret != 0) {
3506 mbedtls_printf("failed (%u)\n", (unsigned int) i);
3507 } else {
3508 mbedtls_printf("passed\n");
3509 }
Gilles Peskinec95696f2018-09-17 15:59:01 +02003510 }
Gilles Peskine449bd832023-01-11 14:50:10 +01003511 return ret;
Gilles Peskinec95696f2018-09-17 15:59:01 +02003512}
Valerio Settifd122f42023-04-05 18:15:32 +02003513#endif /* MBEDTLS_ECP_C */
Gilles Peskinec95696f2018-09-17 15:59:01 +02003514
Manuel Pégourié-Gonnardb505c272012-11-05 17:27:54 +01003515/*
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +01003516 * Checkup routine
3517 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003518int mbedtls_ecp_self_test(int verbose)
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +01003519{
Valerio Settifd122f42023-04-05 18:15:32 +02003520#if defined(MBEDTLS_ECP_C)
Janos Follath24eed8d2019-11-22 13:21:35 +00003521 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02003522 mbedtls_ecp_group grp;
3523 mbedtls_ecp_point R, P;
3524 mbedtls_mpi m;
Gilles Peskine24666792018-09-17 18:29:49 +02003525
3526#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskined9767a52018-09-14 19:29:47 +02003527 /* Exponents especially adapted for secp192k1, which has the lowest
3528 * order n of all supported curves (secp192r1 is in a slightly larger
3529 * field but the order of its base point is slightly smaller). */
Gilles Peskine24666792018-09-17 18:29:49 +02003530 const char *sw_exponents[] =
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003531 {
Manuel Pégourié-Gonnardb63f9e92012-11-21 13:00:58 +01003532 "000000000000000000000000000000000000000000000001", /* one */
Gilles Peskined9767a52018-09-14 19:29:47 +02003533 "FFFFFFFFFFFFFFFFFFFFFFFE26F2FC170F69466A74DEFD8C", /* n - 1 */
Manuel Pégourié-Gonnardb63f9e92012-11-21 13:00:58 +01003534 "5EA6F389A38B8BC81E767753B15AA5569E1782E30ABE7D25", /* random */
Manuel Pégourié-Gonnardff27b7c2013-11-21 09:28:03 +01003535 "400000000000000000000000000000000000000000000000", /* one and zeros */
3536 "7FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF", /* all ones */
3537 "555555555555555555555555555555555555555555555555", /* 101010... */
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003538 };
Gilles Peskine24666792018-09-17 18:29:49 +02003539#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
3540#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
3541 const char *m_exponents[] =
3542 {
Gilles Peskine6d9c8d72020-07-22 01:26:25 +02003543 /* Valid private values for Curve25519. In a build with Curve448
3544 * but not Curve25519, they will be adjusted in
3545 * self_test_adjust_exponent(). */
Gilles Peskine24666792018-09-17 18:29:49 +02003546 "4000000000000000000000000000000000000000000000000000000000000000",
3547 "5C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C30",
3548 "5715ECCE24583F7A7023C24164390586842E816D7280A49EF6DF4EAE6B280BF8",
3549 "41A2B017516F6D254E1F002BCCBADD54BE30F8CEC737A0E912B4963B6BA74460",
3550 "5555555555555555555555555555555555555555555555555555555555555550",
3551 "7FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF8",
3552 };
3553#endif /* MBEDTLS_ECP_MONTGOMERY_ENABLED */
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003554
Gilles Peskine449bd832023-01-11 14:50:10 +01003555 mbedtls_ecp_group_init(&grp);
3556 mbedtls_ecp_point_init(&R);
3557 mbedtls_ecp_point_init(&P);
3558 mbedtls_mpi_init(&m);
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003559
Gilles Peskine24666792018-09-17 18:29:49 +02003560#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Manuel Pégourié-Gonnardb8012fc2013-10-10 15:40:49 +02003561 /* Use secp192r1 if available, or any available curve */
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02003562#if defined(MBEDTLS_ECP_DP_SECP192R1_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003563 MBEDTLS_MPI_CHK(mbedtls_ecp_group_load(&grp, MBEDTLS_ECP_DP_SECP192R1));
Paul Bakker5dc6b5f2013-06-29 23:26:34 +02003564#else
Gilles Peskine449bd832023-01-11 14:50:10 +01003565 MBEDTLS_MPI_CHK(mbedtls_ecp_group_load(&grp, mbedtls_ecp_curve_list()->grp_id));
Manuel Pégourié-Gonnardb8012fc2013-10-10 15:40:49 +02003566#endif
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003567
Gilles Peskine449bd832023-01-11 14:50:10 +01003568 if (verbose != 0) {
3569 mbedtls_printf(" ECP SW test #1 (constant op_count, base point G): ");
3570 }
Manuel Pégourié-Gonnard161ef962013-09-17 19:13:10 +02003571 /* Do a dummy multiplication first to trigger precomputation */
Gilles Peskine449bd832023-01-11 14:50:10 +01003572 MBEDTLS_MPI_CHK(mbedtls_mpi_lset(&m, 2));
3573 MBEDTLS_MPI_CHK(mbedtls_ecp_mul(&grp, &P, &m, &grp.G, self_test_rng, NULL));
3574 ret = self_test_point(verbose,
3575 &grp, &R, &m, &grp.G,
3576 sw_exponents,
3577 sizeof(sw_exponents) / sizeof(sw_exponents[0]));
3578 if (ret != 0) {
Gilles Peskinec95696f2018-09-17 15:59:01 +02003579 goto cleanup;
Gilles Peskine449bd832023-01-11 14:50:10 +01003580 }
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003581
Gilles Peskine449bd832023-01-11 14:50:10 +01003582 if (verbose != 0) {
3583 mbedtls_printf(" ECP SW test #2 (constant op_count, other point): ");
3584 }
Manuel Pégourié-Gonnard161ef962013-09-17 19:13:10 +02003585 /* We computed P = 2G last time, use it */
Gilles Peskine449bd832023-01-11 14:50:10 +01003586 ret = self_test_point(verbose,
3587 &grp, &R, &m, &P,
3588 sw_exponents,
3589 sizeof(sw_exponents) / sizeof(sw_exponents[0]));
3590 if (ret != 0) {
Gilles Peskine24666792018-09-17 18:29:49 +02003591 goto cleanup;
Gilles Peskine449bd832023-01-11 14:50:10 +01003592 }
Gilles Peskine24666792018-09-17 18:29:49 +02003593
Gilles Peskine449bd832023-01-11 14:50:10 +01003594 mbedtls_ecp_group_free(&grp);
3595 mbedtls_ecp_point_free(&R);
Gilles Peskine24666792018-09-17 18:29:49 +02003596#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
3597
3598#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003599 if (verbose != 0) {
3600 mbedtls_printf(" ECP Montgomery test (constant op_count): ");
3601 }
Gilles Peskine24666792018-09-17 18:29:49 +02003602#if defined(MBEDTLS_ECP_DP_CURVE25519_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003603 MBEDTLS_MPI_CHK(mbedtls_ecp_group_load(&grp, MBEDTLS_ECP_DP_CURVE25519));
Gilles Peskine24666792018-09-17 18:29:49 +02003604#elif defined(MBEDTLS_ECP_DP_CURVE448_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003605 MBEDTLS_MPI_CHK(mbedtls_ecp_group_load(&grp, MBEDTLS_ECP_DP_CURVE448));
Gilles Peskine24666792018-09-17 18:29:49 +02003606#else
3607#error "MBEDTLS_ECP_MONTGOMERY_ENABLED is defined, but no curve is supported for self-test"
3608#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01003609 ret = self_test_point(verbose,
3610 &grp, &R, &m, &grp.G,
3611 m_exponents,
3612 sizeof(m_exponents) / sizeof(m_exponents[0]));
3613 if (ret != 0) {
Gilles Peskine24666792018-09-17 18:29:49 +02003614 goto cleanup;
Gilles Peskine449bd832023-01-11 14:50:10 +01003615 }
Gilles Peskine24666792018-09-17 18:29:49 +02003616#endif /* MBEDTLS_ECP_MONTGOMERY_ENABLED */
Manuel Pégourié-Gonnard161ef962013-09-17 19:13:10 +02003617
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003618cleanup:
3619
Gilles Peskine449bd832023-01-11 14:50:10 +01003620 if (ret < 0 && verbose != 0) {
3621 mbedtls_printf("Unexpected error, return code = %08X\n", (unsigned int) ret);
3622 }
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003623
Gilles Peskine449bd832023-01-11 14:50:10 +01003624 mbedtls_ecp_group_free(&grp);
3625 mbedtls_ecp_point_free(&R);
3626 mbedtls_ecp_point_free(&P);
3627 mbedtls_mpi_free(&m);
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003628
Gilles Peskine449bd832023-01-11 14:50:10 +01003629 if (verbose != 0) {
3630 mbedtls_printf("\n");
3631 }
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003632
Gilles Peskine449bd832023-01-11 14:50:10 +01003633 return ret;
Valerio Settifd122f42023-04-05 18:15:32 +02003634#else /* MBEDTLS_ECP_C */
3635 (void) verbose;
3636 return 0;
3637#endif /* MBEDTLS_ECP_C */
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +01003638}
3639
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02003640#endif /* MBEDTLS_SELF_TEST */
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +01003641
Janos Follathb0697532016-08-18 12:38:46 +01003642#endif /* !MBEDTLS_ECP_ALT */
3643
Valerio Settifd122f42023-04-05 18:15:32 +02003644#endif /* MBEDTLS_ECP_LIGHT */