blob: c823b7889449976c5d50ea04945894b202bd9024 [file] [log] [blame]
gabor-mezei-armd1125342021-07-12 16:31:22 +02001/**
2 * Constant-time functions
3 *
4 * Copyright The Mbed TLS Contributors
5 * SPDX-License-Identifier: Apache-2.0
6 *
7 * Licensed under the Apache License, Version 2.0 (the "License"); you may
8 * not use this file except in compliance with the License.
9 * You may obtain a copy of the License at
10 *
11 * http://www.apache.org/licenses/LICENSE-2.0
12 *
13 * Unless required by applicable law or agreed to in writing, software
14 * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
15 * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16 * See the License for the specific language governing permissions and
17 * limitations under the License.
18 */
19
Gilles Peskine449bd832023-01-11 14:50:10 +010020/*
Gabor Mezei642eeb22021-11-03 16:13:32 +010021 * The following functions are implemented without using comparison operators, as those
Gabor Mezeieab90bc2021-10-18 16:09:41 +020022 * might be translated to branches by some compilers on some platforms.
23 */
24
gabor-mezei-armd1125342021-07-12 16:31:22 +020025#include "common.h"
Gabor Mezei22c9a6f2021-10-20 12:09:35 +020026#include "constant_time_internal.h"
Gabor Mezei765862c2021-10-19 12:22:25 +020027#include "mbedtls/constant_time.h"
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +020028#include "mbedtls/error.h"
gabor-mezei-arm5b3a32d2021-09-29 10:50:31 +020029#include "mbedtls/platform_util.h"
gabor-mezei-armdb9a38c2021-09-27 11:28:54 +020030
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +020031#if defined(MBEDTLS_BIGNUM_C)
32#include "mbedtls/bignum.h"
Gabor Mezei87638a92022-09-15 20:02:36 +020033#include "bignum_core.h"
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +020034#endif
35
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +020036#if defined(MBEDTLS_SSL_TLS_C)
37#include "ssl_misc.h"
38#endif
39
gabor-mezei-arm5b3a32d2021-09-29 10:50:31 +020040#if defined(MBEDTLS_RSA_C)
41#include "mbedtls/rsa.h"
42#endif
43
Gabor Mezei28d61152021-11-15 16:13:01 +010044#if defined(MBEDTLS_BASE64_C)
45#include "constant_time_invasive.h"
46#endif
47
gabor-mezei-armfdb71182021-09-27 16:11:12 +020048#include <string.h>
Andrzej Kurek8a045ce2022-12-23 11:00:06 -050049#if defined(MBEDTLS_USE_PSA_CRYPTO)
50#define PSA_TO_MBEDTLS_ERR(status) PSA_TO_MBEDTLS_ERR_LIST(status, \
51 psa_to_ssl_errors, \
52 psa_generic_status_to_mbedtls)
53#endif
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +020054
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000055/*
Dave Rodgman051225d2022-12-30 21:25:35 +000056 * Define MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS where assembly is present to
57 * perform fast unaligned access to volatile data.
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000058 *
59 * This is needed because mbedtls_get_unaligned_uintXX etc don't support volatile
60 * memory accesses.
61 *
Dave Rodgman051225d2022-12-30 21:25:35 +000062 * Some of these definitions could be moved into alignment.h but for now they are
63 * only used here.
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000064 */
Dave Rodgman051225d2022-12-30 21:25:35 +000065#if defined(MBEDTLS_EFFICIENT_UNALIGNED_ACCESS) && defined(MBEDTLS_HAVE_ASM)
66#if defined(__arm__) || defined(__thumb__) || defined(__thumb2__) || defined(__aarch64__)
67#define MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS
68#endif
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000069#endif
70
Dave Rodgman051225d2022-12-30 21:25:35 +000071#if defined(MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS)
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000072static inline uint32_t mbedtls_get_unaligned_volatile_uint32(volatile const unsigned char *p)
73{
74 /* This is UB, even where it's safe:
75 * return *((volatile uint32_t*)p);
76 * so instead the same thing is expressed in assembly below.
77 */
78 uint32_t r;
79#if defined(__arm__) || defined(__thumb__) || defined(__thumb2__)
Dave Rodgman4610d4b2023-01-30 09:26:48 +000080 asm volatile ("ldr %0, [%1]" : "=r" (r) : "r" (p) :);
Dave Rodgman051225d2022-12-30 21:25:35 +000081#elif defined(__aarch64__)
Dave Rodgman4610d4b2023-01-30 09:26:48 +000082 asm volatile ("ldr %w0, [%1]" : "=r" (r) : "r" (p) :);
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000083#endif
Dave Rodgman051225d2022-12-30 21:25:35 +000084 return r;
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000085}
Dave Rodgman051225d2022-12-30 21:25:35 +000086#endif /* MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS */
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000087
Gilles Peskine449bd832023-01-11 14:50:10 +010088int mbedtls_ct_memcmp(const void *a,
89 const void *b,
90 size_t n)
gabor-mezei-armdb9a38c2021-09-27 11:28:54 +020091{
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000092 size_t i = 0;
Dave Rodgman7658b632023-01-11 17:39:33 +000093 /*
94 * `A` and `B` are cast to volatile to ensure that the compiler
95 * generates code that always fully reads both buffers.
96 * Otherwise it could generate a test to exit early if `diff` has all
97 * bits set early in the loop.
98 */
gabor-mezei-armdb9a38c2021-09-27 11:28:54 +020099 volatile const unsigned char *A = (volatile const unsigned char *) a;
100 volatile const unsigned char *B = (volatile const unsigned char *) b;
Dave Rodgman7658b632023-01-11 17:39:33 +0000101 uint32_t diff = 0;
gabor-mezei-armdb9a38c2021-09-27 11:28:54 +0200102
Dave Rodgman051225d2022-12-30 21:25:35 +0000103#if defined(MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS)
Dave Rodgman36dfc5a2022-12-22 15:04:43 +0000104 for (; (i + 4) <= n; i += 4) {
105 uint32_t x = mbedtls_get_unaligned_volatile_uint32(A + i);
106 uint32_t y = mbedtls_get_unaligned_volatile_uint32(B + i);
107 diff |= x ^ y;
108 }
109#endif
110
111 for (; i < n; i++) {
gabor-mezei-armdb9a38c2021-09-27 11:28:54 +0200112 /* Read volatile data in order before computing diff.
113 * This avoids IAR compiler warning:
114 * 'the order of volatile accesses is undefined ..' */
115 unsigned char x = A[i], y = B[i];
116 diff |= x ^ y;
117 }
118
Gilles Peskine449bd832023-01-11 14:50:10 +0100119 return (int) diff;
gabor-mezei-armdb9a38c2021-09-27 11:28:54 +0200120}
121
Gilles Peskine449bd832023-01-11 14:50:10 +0100122unsigned mbedtls_ct_uint_mask(unsigned value)
gabor-mezei-arm340948e2021-09-27 11:40:03 +0200123{
124 /* MSVC has a warning about unary minus on unsigned, but this is
125 * well-defined and precisely what we want to do here */
126#if defined(_MSC_VER)
127#pragma warning( push )
128#pragma warning( disable : 4146 )
129#endif
Gilles Peskine449bd832023-01-11 14:50:10 +0100130 return -((value | -value) >> (sizeof(value) * 8 - 1));
gabor-mezei-arm340948e2021-09-27 11:40:03 +0200131#if defined(_MSC_VER)
132#pragma warning( pop )
133#endif
134}
gabor-mezei-arm3733bf82021-09-27 11:49:42 +0200135
Przemek Stekiel89ad6232022-09-27 13:36:12 +0200136#if defined(MBEDTLS_SSL_SOME_SUITES_USE_MAC)
Gabor Mezei6a426c92021-10-20 11:17:43 +0200137
Gilles Peskine449bd832023-01-11 14:50:10 +0100138size_t mbedtls_ct_size_mask(size_t value)
gabor-mezei-arm3733bf82021-09-27 11:49:42 +0200139{
140 /* MSVC has a warning about unary minus on unsigned integer types,
141 * but this is well-defined and precisely what we want to do here. */
142#if defined(_MSC_VER)
143#pragma warning( push )
144#pragma warning( disable : 4146 )
145#endif
Gilles Peskine449bd832023-01-11 14:50:10 +0100146 return -((value | -value) >> (sizeof(value) * 8 - 1));
gabor-mezei-arm3733bf82021-09-27 11:49:42 +0200147#if defined(_MSC_VER)
148#pragma warning( pop )
149#endif
150}
gabor-mezei-armc76227d2021-09-27 11:53:54 +0200151
Przemek Stekiel89ad6232022-09-27 13:36:12 +0200152#endif /* MBEDTLS_SSL_SOME_SUITES_USE_MAC */
Gabor Mezei6a426c92021-10-20 11:17:43 +0200153
gabor-mezei-arm9cb55692021-08-11 15:07:02 +0200154#if defined(MBEDTLS_BIGNUM_C)
155
Gilles Peskine449bd832023-01-11 14:50:10 +0100156mbedtls_mpi_uint mbedtls_ct_mpi_uint_mask(mbedtls_mpi_uint value)
gabor-mezei-arm9cb55692021-08-11 15:07:02 +0200157{
158 /* MSVC has a warning about unary minus on unsigned, but this is
159 * well-defined and precisely what we want to do here */
160#if defined(_MSC_VER)
161#pragma warning( push )
162#pragma warning( disable : 4146 )
163#endif
Gilles Peskine449bd832023-01-11 14:50:10 +0100164 return -((value | -value) >> (sizeof(value) * 8 - 1));
gabor-mezei-arm9cb55692021-08-11 15:07:02 +0200165#if defined(_MSC_VER)
166#pragma warning( pop )
167#endif
168}
169
170#endif /* MBEDTLS_BIGNUM_C */
171
Gabor Mezeie2123792021-10-18 17:05:06 +0200172#if defined(MBEDTLS_SSL_SOME_SUITES_USE_TLS_CBC)
173
Gabor Mezei1e642612021-10-18 16:05:50 +0200174/** Constant-flow mask generation for "less than" comparison:
175 * - if \p x < \p y, return all-bits 1, that is (size_t) -1
176 * - otherwise, return all bits 0, that is 0
177 *
178 * This function can be used to write constant-time code by replacing branches
179 * with bit operations using masks.
180 *
181 * \param x The first value to analyze.
182 * \param y The second value to analyze.
183 *
184 * \return All-bits-one if \p x is less than \p y, otherwise zero.
185 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100186static size_t mbedtls_ct_size_mask_lt(size_t x,
187 size_t y)
gabor-mezei-armc76227d2021-09-27 11:53:54 +0200188{
189 /* This has the most significant bit set if and only if x < y */
190 const size_t sub = x - y;
191
192 /* sub1 = (x < y) ? 1 : 0 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100193 const size_t sub1 = sub >> (sizeof(sub) * 8 - 1);
gabor-mezei-armc76227d2021-09-27 11:53:54 +0200194
195 /* mask = (x < y) ? 0xff... : 0x00... */
Gilles Peskine449bd832023-01-11 14:50:10 +0100196 const size_t mask = mbedtls_ct_size_mask(sub1);
gabor-mezei-armc76227d2021-09-27 11:53:54 +0200197
Gilles Peskine449bd832023-01-11 14:50:10 +0100198 return mask;
gabor-mezei-armc76227d2021-09-27 11:53:54 +0200199}
gabor-mezei-arm16fc57b2021-09-27 11:58:31 +0200200
Gilles Peskine449bd832023-01-11 14:50:10 +0100201size_t mbedtls_ct_size_mask_ge(size_t x,
202 size_t y)
gabor-mezei-arm16fc57b2021-09-27 11:58:31 +0200203{
Gilles Peskine449bd832023-01-11 14:50:10 +0100204 return ~mbedtls_ct_size_mask_lt(x, y);
gabor-mezei-arm16fc57b2021-09-27 11:58:31 +0200205}
gabor-mezei-arm8d1d5fd2021-09-27 12:15:19 +0200206
Gabor Mezeie2123792021-10-18 17:05:06 +0200207#endif /* MBEDTLS_SSL_SOME_SUITES_USE_TLS_CBC */
208
Gabor Mezei28d61152021-11-15 16:13:01 +0100209#if defined(MBEDTLS_BASE64_C)
210
211/* Return 0xff if low <= c <= high, 0 otherwise.
212 *
213 * Constant flow with respect to c.
214 */
Gabor Mezeic0d8dda2021-11-26 17:20:36 +0100215MBEDTLS_STATIC_TESTABLE
Gilles Peskine449bd832023-01-11 14:50:10 +0100216unsigned char mbedtls_ct_uchar_mask_of_range(unsigned char low,
217 unsigned char high,
218 unsigned char c)
Gabor Mezei28d61152021-11-15 16:13:01 +0100219{
220 /* low_mask is: 0 if low <= c, 0x...ff if low > c */
Gilles Peskine449bd832023-01-11 14:50:10 +0100221 unsigned low_mask = ((unsigned) c - low) >> 8;
Gabor Mezei28d61152021-11-15 16:13:01 +0100222 /* high_mask is: 0 if c <= high, 0x...ff if c > high */
Gilles Peskine449bd832023-01-11 14:50:10 +0100223 unsigned high_mask = ((unsigned) high - c) >> 8;
224 return ~(low_mask | high_mask) & 0xff;
Gabor Mezei28d61152021-11-15 16:13:01 +0100225}
226
227#endif /* MBEDTLS_BASE64_C */
228
Gilles Peskine449bd832023-01-11 14:50:10 +0100229unsigned mbedtls_ct_size_bool_eq(size_t x,
230 size_t y)
gabor-mezei-arm8d1d5fd2021-09-27 12:15:19 +0200231{
232 /* diff = 0 if x == y, non-zero otherwise */
233 const size_t diff = x ^ y;
234
235 /* MSVC has a warning about unary minus on unsigned integer types,
236 * but this is well-defined and precisely what we want to do here. */
237#if defined(_MSC_VER)
238#pragma warning( push )
239#pragma warning( disable : 4146 )
240#endif
241
242 /* diff_msb's most significant bit is equal to x != y */
Gilles Peskine449bd832023-01-11 14:50:10 +0100243 const size_t diff_msb = (diff | (size_t) -diff);
gabor-mezei-arm8d1d5fd2021-09-27 12:15:19 +0200244
245#if defined(_MSC_VER)
246#pragma warning( pop )
247#endif
248
249 /* diff1 = (x != y) ? 1 : 0 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100250 const unsigned diff1 = diff_msb >> (sizeof(diff_msb) * 8 - 1);
gabor-mezei-arm8d1d5fd2021-09-27 12:15:19 +0200251
Gilles Peskine449bd832023-01-11 14:50:10 +0100252 return 1 ^ diff1;
gabor-mezei-arm8d1d5fd2021-09-27 12:15:19 +0200253}
gabor-mezei-arm5a854422021-09-27 12:25:07 +0200254
Gabor Mezeie2123792021-10-18 17:05:06 +0200255#if defined(MBEDTLS_PKCS1_V15) && defined(MBEDTLS_RSA_C) && !defined(MBEDTLS_RSA_ALT)
256
Gabor Mezeia2d0f902021-10-18 16:35:23 +0200257/** Constant-flow "greater than" comparison:
258 * return x > y
259 *
260 * This is equivalent to \p x > \p y, but is likely to be compiled
261 * to code using bitwise operation rather than a branch.
262 *
263 * \param x The first value to analyze.
264 * \param y The second value to analyze.
265 *
266 * \return 1 if \p x greater than \p y, otherwise 0.
267 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100268static unsigned mbedtls_ct_size_gt(size_t x,
269 size_t y)
gabor-mezei-arm5a854422021-09-27 12:25:07 +0200270{
gabor-mezei-arm87ac5be2021-08-10 20:36:09 +0200271 /* Return the sign bit (1 for negative) of (y - x). */
Gilles Peskine449bd832023-01-11 14:50:10 +0100272 return (y - x) >> (sizeof(size_t) * 8 - 1);
gabor-mezei-arm5a854422021-09-27 12:25:07 +0200273}
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +0200274
Gabor Mezeie2123792021-10-18 17:05:06 +0200275#endif /* MBEDTLS_PKCS1_V15 && MBEDTLS_RSA_C && ! MBEDTLS_RSA_ALT */
276
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +0200277#if defined(MBEDTLS_BIGNUM_C)
278
Gilles Peskine449bd832023-01-11 14:50:10 +0100279unsigned mbedtls_ct_mpi_uint_lt(const mbedtls_mpi_uint x,
280 const mbedtls_mpi_uint y)
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +0200281{
282 mbedtls_mpi_uint ret;
283 mbedtls_mpi_uint cond;
284
285 /*
286 * Check if the most significant bits (MSB) of the operands are different.
287 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100288 cond = (x ^ y);
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +0200289 /*
290 * If the MSB are the same then the difference x-y will be negative (and
291 * have its MSB set to 1 during conversion to unsigned) if and only if x<y.
292 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100293 ret = (x - y) & ~cond;
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +0200294 /*
295 * If the MSB are different, then the operand with the MSB of 1 is the
296 * bigger. (That is if y has MSB of 1, then x<y is true and it is false if
297 * the MSB of y is 0.)
298 */
299 ret |= y & cond;
300
301
Gilles Peskine449bd832023-01-11 14:50:10 +0100302 ret = ret >> (sizeof(mbedtls_mpi_uint) * 8 - 1);
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +0200303
304 return (unsigned) ret;
305}
306
307#endif /* MBEDTLS_BIGNUM_C */
gabor-mezei-armb2dbf2c2021-09-27 12:59:30 +0200308
Gilles Peskine449bd832023-01-11 14:50:10 +0100309unsigned mbedtls_ct_uint_if(unsigned condition,
310 unsigned if1,
311 unsigned if0)
gabor-mezei-armb2dbf2c2021-09-27 12:59:30 +0200312{
Gilles Peskine449bd832023-01-11 14:50:10 +0100313 unsigned mask = mbedtls_ct_uint_mask(condition);
314 return (mask & if1) | (~mask & if0);
gabor-mezei-armb2dbf2c2021-09-27 12:59:30 +0200315}
gabor-mezei-armd3230d52021-09-27 13:03:57 +0200316
Gabor Mezeie2123792021-10-18 17:05:06 +0200317#if defined(MBEDTLS_BIGNUM_C)
gabor-mezei-arm65cefdb2021-09-27 15:47:00 +0200318
Gilles Peskine449bd832023-01-11 14:50:10 +0100319void mbedtls_ct_mpi_uint_cond_assign(size_t n,
320 mbedtls_mpi_uint *dest,
321 const mbedtls_mpi_uint *src,
322 unsigned char condition)
gabor-mezei-armbe8d98b2021-09-27 13:17:15 +0200323{
324 size_t i;
325
326 /* MSVC has a warning about unary minus on unsigned integer types,
327 * but this is well-defined and precisely what we want to do here. */
328#if defined(_MSC_VER)
329#pragma warning( push )
330#pragma warning( disable : 4146 )
331#endif
332
gabor-mezei-arm87ac5be2021-08-10 20:36:09 +0200333 /* all-bits 1 if condition is 1, all-bits 0 if condition is 0 */
334 const mbedtls_mpi_uint mask = -condition;
gabor-mezei-armbe8d98b2021-09-27 13:17:15 +0200335
336#if defined(_MSC_VER)
337#pragma warning( pop )
338#endif
339
Gilles Peskine449bd832023-01-11 14:50:10 +0100340 for (i = 0; i < n; i++) {
341 dest[i] = (src[i] & mask) | (dest[i] & ~mask);
342 }
gabor-mezei-armbe8d98b2021-09-27 13:17:15 +0200343}
344
345#endif /* MBEDTLS_BIGNUM_C */
gabor-mezei-arm394aeaa2021-09-27 13:31:06 +0200346
Gabor Mezei9a4074a2021-11-15 16:18:54 +0100347#if defined(MBEDTLS_BASE64_C)
348
Gilles Peskine449bd832023-01-11 14:50:10 +0100349unsigned char mbedtls_ct_base64_enc_char(unsigned char value)
Gabor Mezei9a4074a2021-11-15 16:18:54 +0100350{
351 unsigned char digit = 0;
Gabor Mezei14d5fac2021-11-24 15:51:39 +0100352 /* For each range of values, if value is in that range, mask digit with
353 * the corresponding value. Since value can only be in a single range,
Gabor Mezei9a4074a2021-11-15 16:18:54 +0100354 * only at most one masking will change digit. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100355 digit |= mbedtls_ct_uchar_mask_of_range(0, 25, value) & ('A' + value);
356 digit |= mbedtls_ct_uchar_mask_of_range(26, 51, value) & ('a' + value - 26);
357 digit |= mbedtls_ct_uchar_mask_of_range(52, 61, value) & ('0' + value - 52);
358 digit |= mbedtls_ct_uchar_mask_of_range(62, 62, value) & '+';
359 digit |= mbedtls_ct_uchar_mask_of_range(63, 63, value) & '/';
360 return digit;
Gabor Mezei9a4074a2021-11-15 16:18:54 +0100361}
362
Gilles Peskine449bd832023-01-11 14:50:10 +0100363signed char mbedtls_ct_base64_dec_value(unsigned char c)
Gabor Mezei358829a2021-11-15 16:22:37 +0100364{
365 unsigned char val = 0;
366 /* For each range of digits, if c is in that range, mask val with
367 * the corresponding value. Since c can only be in a single range,
368 * only at most one masking will change val. Set val to one plus
369 * the desired value so that it stays 0 if c is in none of the ranges. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100370 val |= mbedtls_ct_uchar_mask_of_range('A', 'Z', c) & (c - 'A' + 0 + 1);
371 val |= mbedtls_ct_uchar_mask_of_range('a', 'z', c) & (c - 'a' + 26 + 1);
372 val |= mbedtls_ct_uchar_mask_of_range('0', '9', c) & (c - '0' + 52 + 1);
373 val |= mbedtls_ct_uchar_mask_of_range('+', '+', c) & (c - '+' + 62 + 1);
374 val |= mbedtls_ct_uchar_mask_of_range('/', '/', c) & (c - '/' + 63 + 1);
Gabor Mezei358829a2021-11-15 16:22:37 +0100375 /* At this point, val is 0 if c is an invalid digit and v+1 if c is
376 * a digit with the value v. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100377 return val - 1;
Gabor Mezei358829a2021-11-15 16:22:37 +0100378}
379
Gabor Mezei9a4074a2021-11-15 16:18:54 +0100380#endif /* MBEDTLS_BASE64_C */
381
Gabor Mezeie2123792021-10-18 17:05:06 +0200382#if defined(MBEDTLS_PKCS1_V15) && defined(MBEDTLS_RSA_C) && !defined(MBEDTLS_RSA_ALT)
383
Gabor Mezeia2d0f902021-10-18 16:35:23 +0200384/** Shift some data towards the left inside a buffer.
385 *
Gabor Mezei90437e32021-10-20 11:59:27 +0200386 * `mbedtls_ct_mem_move_to_left(start, total, offset)` is functionally
Gabor Mezeia2d0f902021-10-18 16:35:23 +0200387 * equivalent to
388 * ```
389 * memmove(start, start + offset, total - offset);
390 * memset(start + offset, 0, total - offset);
391 * ```
392 * but it strives to use a memory access pattern (and thus total timing)
393 * that does not depend on \p offset. This timing independence comes at
394 * the expense of performance.
395 *
396 * \param start Pointer to the start of the buffer.
397 * \param total Total size of the buffer.
398 * \param offset Offset from which to copy \p total - \p offset bytes.
399 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100400static void mbedtls_ct_mem_move_to_left(void *start,
401 size_t total,
402 size_t offset)
gabor-mezei-arm394aeaa2021-09-27 13:31:06 +0200403{
404 volatile unsigned char *buf = start;
405 size_t i, n;
Gilles Peskine449bd832023-01-11 14:50:10 +0100406 if (total == 0) {
gabor-mezei-arm394aeaa2021-09-27 13:31:06 +0200407 return;
Gilles Peskine449bd832023-01-11 14:50:10 +0100408 }
409 for (i = 0; i < total; i++) {
410 unsigned no_op = mbedtls_ct_size_gt(total - offset, i);
gabor-mezei-arm394aeaa2021-09-27 13:31:06 +0200411 /* The first `total - offset` passes are a no-op. The last
412 * `offset` passes shift the data one byte to the left and
413 * zero out the last byte. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100414 for (n = 0; n < total - 1; n++) {
gabor-mezei-arm394aeaa2021-09-27 13:31:06 +0200415 unsigned char current = buf[n];
416 unsigned char next = buf[n+1];
Gilles Peskine449bd832023-01-11 14:50:10 +0100417 buf[n] = mbedtls_ct_uint_if(no_op, current, next);
gabor-mezei-arm394aeaa2021-09-27 13:31:06 +0200418 }
Gilles Peskine449bd832023-01-11 14:50:10 +0100419 buf[total-1] = mbedtls_ct_uint_if(no_op, buf[total-1], 0);
gabor-mezei-arm394aeaa2021-09-27 13:31:06 +0200420 }
421}
gabor-mezei-armdee0fd32021-09-27 13:34:25 +0200422
Gabor Mezeie2123792021-10-18 17:05:06 +0200423#endif /* MBEDTLS_PKCS1_V15 && MBEDTLS_RSA_C && ! MBEDTLS_RSA_ALT */
424
Przemek Stekiel89ad6232022-09-27 13:36:12 +0200425#if defined(MBEDTLS_SSL_SOME_SUITES_USE_MAC)
Gabor Mezeie2123792021-10-18 17:05:06 +0200426
Gilles Peskine449bd832023-01-11 14:50:10 +0100427void mbedtls_ct_memcpy_if_eq(unsigned char *dest,
428 const unsigned char *src,
429 size_t len,
430 size_t c1,
431 size_t c2)
gabor-mezei-armdee0fd32021-09-27 13:34:25 +0200432{
433 /* mask = c1 == c2 ? 0xff : 0x00 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100434 const size_t equal = mbedtls_ct_size_bool_eq(c1, c2);
gabor-mezei-armdee0fd32021-09-27 13:34:25 +0200435
gabor-mezei-arm87ac5be2021-08-10 20:36:09 +0200436 /* dest[i] = c1 == c2 ? src[i] : dest[i] */
Dave Rodgman36dfc5a2022-12-22 15:04:43 +0000437 size_t i = 0;
438#if defined(MBEDTLS_EFFICIENT_UNALIGNED_ACCESS)
439 const uint32_t mask32 = (uint32_t) mbedtls_ct_size_mask(equal);
440 const unsigned char mask = (unsigned char) mask32 & 0xff;
441
442 for (; (i + 4) <= len; i += 4) {
443 uint32_t a = mbedtls_get_unaligned_uint32(src + i) & mask32;
444 uint32_t b = mbedtls_get_unaligned_uint32(dest + i) & ~mask32;
445 mbedtls_put_unaligned_uint32(dest + i, a | b);
446 }
447#else
448 const unsigned char mask = (unsigned char) mbedtls_ct_size_mask(equal);
449#endif /* MBEDTLS_EFFICIENT_UNALIGNED_ACCESS */
450 for (; i < len; i++) {
Gilles Peskine449bd832023-01-11 14:50:10 +0100451 dest[i] = (src[i] & mask) | (dest[i] & ~mask);
452 }
gabor-mezei-armdee0fd32021-09-27 13:34:25 +0200453}
gabor-mezei-arm0e7f71e2021-09-27 13:57:45 +0200454
Gilles Peskine449bd832023-01-11 14:50:10 +0100455void mbedtls_ct_memcpy_offset(unsigned char *dest,
456 const unsigned char *src,
457 size_t offset,
458 size_t offset_min,
459 size_t offset_max,
460 size_t len)
gabor-mezei-arm0e7f71e2021-09-27 13:57:45 +0200461{
Gabor Mezei63bbba52021-10-18 16:17:57 +0200462 size_t offsetval;
gabor-mezei-arm0e7f71e2021-09-27 13:57:45 +0200463
Gilles Peskine449bd832023-01-11 14:50:10 +0100464 for (offsetval = offset_min; offsetval <= offset_max; offsetval++) {
465 mbedtls_ct_memcpy_if_eq(dest, src + offsetval, len,
466 offsetval, offset);
gabor-mezei-arm0e7f71e2021-09-27 13:57:45 +0200467 }
468}
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200469
Neil Armstrong2968d302022-02-25 15:09:36 +0100470#if defined(MBEDTLS_USE_PSA_CRYPTO)
Neil Armstrong36cc13b2022-03-17 16:36:52 +0100471
472#if defined(PSA_WANT_ALG_SHA_384)
Gilles Peskine449bd832023-01-11 14:50:10 +0100473#define MAX_HASH_BLOCK_LENGTH PSA_HASH_BLOCK_LENGTH(PSA_ALG_SHA_384)
Neil Armstrong36cc13b2022-03-17 16:36:52 +0100474#elif defined(PSA_WANT_ALG_SHA_256)
Gilles Peskine449bd832023-01-11 14:50:10 +0100475#define MAX_HASH_BLOCK_LENGTH PSA_HASH_BLOCK_LENGTH(PSA_ALG_SHA_256)
Neil Armstrong36cc13b2022-03-17 16:36:52 +0100476#else /* See check_config.h */
Gilles Peskine449bd832023-01-11 14:50:10 +0100477#define MAX_HASH_BLOCK_LENGTH PSA_HASH_BLOCK_LENGTH(PSA_ALG_SHA_1)
Neil Armstrong36cc13b2022-03-17 16:36:52 +0100478#endif
479
Gilles Peskine449bd832023-01-11 14:50:10 +0100480int mbedtls_ct_hmac(mbedtls_svc_key_id_t key,
481 psa_algorithm_t mac_alg,
482 const unsigned char *add_data,
483 size_t add_data_len,
484 const unsigned char *data,
485 size_t data_len_secret,
486 size_t min_data_len,
487 size_t max_data_len,
488 unsigned char *output)
Neil Armstrong2968d302022-02-25 15:09:36 +0100489{
490 /*
Neil Armstrong28d9c632022-03-17 16:33:27 +0100491 * This function breaks the HMAC abstraction and uses psa_hash_clone()
492 * extension in order to get constant-flow behaviour.
Neil Armstrong2968d302022-02-25 15:09:36 +0100493 *
494 * HMAC(msg) is defined as HASH(okey + HASH(ikey + msg)) where + means
495 * concatenation, and okey/ikey are the XOR of the key with some fixed bit
496 * patterns (see RFC 2104, sec. 2).
497 *
498 * We'll first compute ikey/okey, then inner_hash = HASH(ikey + msg) by
499 * hashing up to minlen, then cloning the context, and for each byte up
500 * to maxlen finishing up the hash computation, keeping only the
501 * correct result.
502 *
503 * Then we only need to compute HASH(okey + inner_hash) and we're done.
504 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100505 psa_algorithm_t hash_alg = PSA_ALG_HMAC_GET_HASH(mac_alg);
506 const size_t block_size = PSA_HASH_BLOCK_LENGTH(hash_alg);
Neil Armstrong9ebb9ff2022-03-17 17:04:37 +0100507 unsigned char key_buf[MAX_HASH_BLOCK_LENGTH];
Gilles Peskine449bd832023-01-11 14:50:10 +0100508 const size_t hash_size = PSA_HASH_LENGTH(hash_alg);
Neil Armstrong2968d302022-02-25 15:09:36 +0100509 psa_hash_operation_t operation = PSA_HASH_OPERATION_INIT;
510 size_t hash_length;
511
Neil Armstrong36cc13b2022-03-17 16:36:52 +0100512 unsigned char aux_out[PSA_HASH_MAX_SIZE];
Neil Armstrong2968d302022-02-25 15:09:36 +0100513 psa_hash_operation_t aux_operation = PSA_HASH_OPERATION_INIT;
514 size_t offset;
515 psa_status_t status = PSA_ERROR_CORRUPTION_DETECTED;
516
Neil Armstrong2968d302022-02-25 15:09:36 +0100517 size_t mac_key_length;
518 size_t i;
519
Gilles Peskine449bd832023-01-11 14:50:10 +0100520#define PSA_CHK(func_call) \
Neil Armstrong2968d302022-02-25 15:09:36 +0100521 do { \
522 status = (func_call); \
Gilles Peskine449bd832023-01-11 14:50:10 +0100523 if (status != PSA_SUCCESS) \
524 goto cleanup; \
525 } while (0)
Neil Armstrong2968d302022-02-25 15:09:36 +0100526
Neil Armstrong72c2f762022-03-17 16:39:10 +0100527 /* Export MAC key
528 * We assume key length is always exactly the output size
529 * which is never more than the block size, thus we use block_size
530 * as the key buffer size.
531 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100532 PSA_CHK(psa_export_key(key, key_buf, block_size, &mac_key_length));
Neil Armstrong2968d302022-02-25 15:09:36 +0100533
Neil Armstrong9ebb9ff2022-03-17 17:04:37 +0100534 /* Calculate ikey */
Gilles Peskine449bd832023-01-11 14:50:10 +0100535 for (i = 0; i < mac_key_length; i++) {
536 key_buf[i] = (unsigned char) (key_buf[i] ^ 0x36);
537 }
538 for (; i < block_size; ++i) {
Neil Armstrong9ebb9ff2022-03-17 17:04:37 +0100539 key_buf[i] = 0x36;
Gilles Peskine449bd832023-01-11 14:50:10 +0100540 }
Neil Armstrong2968d302022-02-25 15:09:36 +0100541
Gilles Peskine449bd832023-01-11 14:50:10 +0100542 PSA_CHK(psa_hash_setup(&operation, hash_alg));
Neil Armstrong2968d302022-02-25 15:09:36 +0100543
544 /* Now compute inner_hash = HASH(ikey + msg) */
Gilles Peskine449bd832023-01-11 14:50:10 +0100545 PSA_CHK(psa_hash_update(&operation, key_buf, block_size));
546 PSA_CHK(psa_hash_update(&operation, add_data, add_data_len));
547 PSA_CHK(psa_hash_update(&operation, data, min_data_len));
Neil Armstrong2968d302022-02-25 15:09:36 +0100548
Paul Elliott5260ce22022-05-09 18:15:54 +0100549 /* Fill the hash buffer in advance with something that is
550 * not a valid hash (barring an attack on the hash and
551 * deliberately-crafted input), in case the caller doesn't
552 * check the return status properly. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100553 memset(output, '!', hash_size);
Paul Elliott5260ce22022-05-09 18:15:54 +0100554
Neil Armstrong2968d302022-02-25 15:09:36 +0100555 /* For each possible length, compute the hash up to that point */
Gilles Peskine449bd832023-01-11 14:50:10 +0100556 for (offset = min_data_len; offset <= max_data_len; offset++) {
557 PSA_CHK(psa_hash_clone(&operation, &aux_operation));
558 PSA_CHK(psa_hash_finish(&aux_operation, aux_out,
559 PSA_HASH_MAX_SIZE, &hash_length));
Neil Armstrong2968d302022-02-25 15:09:36 +0100560 /* Keep only the correct inner_hash in the output buffer */
Gilles Peskine449bd832023-01-11 14:50:10 +0100561 mbedtls_ct_memcpy_if_eq(output, aux_out, hash_size,
562 offset, data_len_secret);
Neil Armstrong2968d302022-02-25 15:09:36 +0100563
Gilles Peskine449bd832023-01-11 14:50:10 +0100564 if (offset < max_data_len) {
565 PSA_CHK(psa_hash_update(&operation, data + offset, 1));
566 }
Neil Armstrong2968d302022-02-25 15:09:36 +0100567 }
568
Neil Armstrong28d9c632022-03-17 16:33:27 +0100569 /* Abort current operation to prepare for final operation */
Gilles Peskine449bd832023-01-11 14:50:10 +0100570 PSA_CHK(psa_hash_abort(&operation));
Neil Armstrong2968d302022-02-25 15:09:36 +0100571
Neil Armstrong9ebb9ff2022-03-17 17:04:37 +0100572 /* Calculate okey */
Gilles Peskine449bd832023-01-11 14:50:10 +0100573 for (i = 0; i < mac_key_length; i++) {
574 key_buf[i] = (unsigned char) ((key_buf[i] ^ 0x36) ^ 0x5C);
575 }
576 for (; i < block_size; ++i) {
Neil Armstrong9ebb9ff2022-03-17 17:04:37 +0100577 key_buf[i] = 0x5C;
Gilles Peskine449bd832023-01-11 14:50:10 +0100578 }
Neil Armstrong9ebb9ff2022-03-17 17:04:37 +0100579
Neil Armstrong2968d302022-02-25 15:09:36 +0100580 /* Now compute HASH(okey + inner_hash) */
Gilles Peskine449bd832023-01-11 14:50:10 +0100581 PSA_CHK(psa_hash_setup(&operation, hash_alg));
582 PSA_CHK(psa_hash_update(&operation, key_buf, block_size));
583 PSA_CHK(psa_hash_update(&operation, output, hash_size));
584 PSA_CHK(psa_hash_finish(&operation, output, hash_size, &hash_length));
Neil Armstrong2968d302022-02-25 15:09:36 +0100585
586#undef PSA_CHK
587
588cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100589 mbedtls_platform_zeroize(key_buf, MAX_HASH_BLOCK_LENGTH);
590 mbedtls_platform_zeroize(aux_out, PSA_HASH_MAX_SIZE);
Neil Armstrong36cc13b2022-03-17 16:36:52 +0100591
Gilles Peskine449bd832023-01-11 14:50:10 +0100592 psa_hash_abort(&operation);
593 psa_hash_abort(&aux_operation);
Andrzej Kurek8a045ce2022-12-23 11:00:06 -0500594 return PSA_TO_MBEDTLS_ERR(status);
Neil Armstrong2968d302022-02-25 15:09:36 +0100595}
Neil Armstrong36cc13b2022-03-17 16:36:52 +0100596
597#undef MAX_HASH_BLOCK_LENGTH
598
Neil Armstrong2968d302022-02-25 15:09:36 +0100599#else
Gilles Peskine449bd832023-01-11 14:50:10 +0100600int mbedtls_ct_hmac(mbedtls_md_context_t *ctx,
601 const unsigned char *add_data,
602 size_t add_data_len,
603 const unsigned char *data,
604 size_t data_len_secret,
605 size_t min_data_len,
606 size_t max_data_len,
607 unsigned char *output)
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200608{
609 /*
610 * This function breaks the HMAC abstraction and uses the md_clone()
611 * extension to the MD API in order to get constant-flow behaviour.
612 *
613 * HMAC(msg) is defined as HASH(okey + HASH(ikey + msg)) where + means
614 * concatenation, and okey/ikey are the XOR of the key with some fixed bit
615 * patterns (see RFC 2104, sec. 2), which are stored in ctx->hmac_ctx.
616 *
617 * We'll first compute inner_hash = HASH(ikey + msg) by hashing up to
618 * minlen, then cloning the context, and for each byte up to maxlen
619 * finishing up the hash computation, keeping only the correct result.
620 *
621 * Then we only need to compute HASH(okey + inner_hash) and we're done.
622 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100623 const mbedtls_md_type_t md_alg = mbedtls_md_get_type(ctx->md_info);
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200624 /* TLS 1.2 only supports SHA-384, SHA-256, SHA-1, MD-5,
625 * all of which have the same block size except SHA-384. */
626 const size_t block_size = md_alg == MBEDTLS_MD_SHA384 ? 128 : 64;
627 const unsigned char * const ikey = ctx->hmac_ctx;
628 const unsigned char * const okey = ikey + block_size;
Gilles Peskine449bd832023-01-11 14:50:10 +0100629 const size_t hash_size = mbedtls_md_get_size(ctx->md_info);
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200630
631 unsigned char aux_out[MBEDTLS_MD_MAX_SIZE];
632 mbedtls_md_context_t aux;
633 size_t offset;
634 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
635
Gilles Peskine449bd832023-01-11 14:50:10 +0100636 mbedtls_md_init(&aux);
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200637
Gilles Peskine449bd832023-01-11 14:50:10 +0100638#define MD_CHK(func_call) \
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200639 do { \
640 ret = (func_call); \
Gilles Peskine449bd832023-01-11 14:50:10 +0100641 if (ret != 0) \
642 goto cleanup; \
643 } while (0)
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200644
Gilles Peskine449bd832023-01-11 14:50:10 +0100645 MD_CHK(mbedtls_md_setup(&aux, ctx->md_info, 0));
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200646
647 /* After hmac_start() of hmac_reset(), ikey has already been hashed,
648 * so we can start directly with the message */
Gilles Peskine449bd832023-01-11 14:50:10 +0100649 MD_CHK(mbedtls_md_update(ctx, add_data, add_data_len));
650 MD_CHK(mbedtls_md_update(ctx, data, min_data_len));
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200651
Paul Elliott5260ce22022-05-09 18:15:54 +0100652 /* Fill the hash buffer in advance with something that is
653 * not a valid hash (barring an attack on the hash and
654 * deliberately-crafted input), in case the caller doesn't
655 * check the return status properly. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100656 memset(output, '!', hash_size);
Paul Elliott5260ce22022-05-09 18:15:54 +0100657
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200658 /* For each possible length, compute the hash up to that point */
Gilles Peskine449bd832023-01-11 14:50:10 +0100659 for (offset = min_data_len; offset <= max_data_len; offset++) {
660 MD_CHK(mbedtls_md_clone(&aux, ctx));
661 MD_CHK(mbedtls_md_finish(&aux, aux_out));
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200662 /* Keep only the correct inner_hash in the output buffer */
Gilles Peskine449bd832023-01-11 14:50:10 +0100663 mbedtls_ct_memcpy_if_eq(output, aux_out, hash_size,
664 offset, data_len_secret);
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200665
Gilles Peskine449bd832023-01-11 14:50:10 +0100666 if (offset < max_data_len) {
667 MD_CHK(mbedtls_md_update(ctx, data + offset, 1));
668 }
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200669 }
670
671 /* The context needs to finish() before it starts() again */
Gilles Peskine449bd832023-01-11 14:50:10 +0100672 MD_CHK(mbedtls_md_finish(ctx, aux_out));
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200673
674 /* Now compute HASH(okey + inner_hash) */
Gilles Peskine449bd832023-01-11 14:50:10 +0100675 MD_CHK(mbedtls_md_starts(ctx));
676 MD_CHK(mbedtls_md_update(ctx, okey, block_size));
677 MD_CHK(mbedtls_md_update(ctx, output, hash_size));
678 MD_CHK(mbedtls_md_finish(ctx, output));
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200679
680 /* Done, get ready for next time */
Gilles Peskine449bd832023-01-11 14:50:10 +0100681 MD_CHK(mbedtls_md_hmac_reset(ctx));
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200682
683#undef MD_CHK
684
685cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100686 mbedtls_md_free(&aux);
687 return ret;
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200688}
Neil Armstrong2968d302022-02-25 15:09:36 +0100689#endif /* MBEDTLS_USE_PSA_CRYPTO */
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200690
Przemek Stekiel89ad6232022-09-27 13:36:12 +0200691#endif /* MBEDTLS_SSL_SOME_SUITES_USE_MAC */
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200692
693#if defined(MBEDTLS_BIGNUM_C)
694
Gilles Peskine449bd832023-01-11 14:50:10 +0100695#define MPI_VALIDATE_RET(cond) \
696 MBEDTLS_INTERNAL_VALIDATE_RET(cond, MBEDTLS_ERR_MPI_BAD_INPUT_DATA)
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200697
698/*
699 * Conditionally assign X = Y, without leaking information
700 * about whether the assignment was made or not.
701 * (Leaking information about the respective sizes of X and Y is ok however.)
702 */
Tautvydas Žilys40fc7da2022-01-31 13:34:01 -0800703#if defined(_MSC_VER) && defined(_M_ARM64) && (_MSC_FULL_VER < 193131103)
Tautvydas Žilys60165d72022-01-26 15:33:27 -0800704/*
Tautvydas Žilys40fc7da2022-01-31 13:34:01 -0800705 * MSVC miscompiles this function if it's inlined prior to Visual Studio 2022 version 17.1. See:
Tautvydas Žilys60165d72022-01-26 15:33:27 -0800706 * https://developercommunity.visualstudio.com/t/c-compiler-miscompiles-part-of-mbedtls-library-on/1646989
707 */
708__declspec(noinline)
709#endif
Gilles Peskine449bd832023-01-11 14:50:10 +0100710int mbedtls_mpi_safe_cond_assign(mbedtls_mpi *X,
711 const mbedtls_mpi *Y,
712 unsigned char assign)
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200713{
714 int ret = 0;
Gilles Peskine449bd832023-01-11 14:50:10 +0100715 MPI_VALIDATE_RET(X != NULL);
716 MPI_VALIDATE_RET(Y != NULL);
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200717
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200718 /* all-bits 1 if assign is 1, all-bits 0 if assign is 0 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100719 mbedtls_mpi_uint limb_mask = mbedtls_ct_mpi_uint_mask(assign);
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200720
Gilles Peskine449bd832023-01-11 14:50:10 +0100721 MBEDTLS_MPI_CHK(mbedtls_mpi_grow(X, Y->n));
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200722
Tom Cosgrovee22413c2023-05-03 09:44:01 +0100723 X->s = (int) mbedtls_ct_uint_if(assign, Y->s, X->s);
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200724
Gilles Peskine449bd832023-01-11 14:50:10 +0100725 mbedtls_mpi_core_cond_assign(X->p, Y->p, Y->n, assign);
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200726
Gilles Peskine449bd832023-01-11 14:50:10 +0100727 for (size_t i = Y->n; i < X->n; i++) {
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200728 X->p[i] &= ~limb_mask;
Gilles Peskine449bd832023-01-11 14:50:10 +0100729 }
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200730
731cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100732 return ret;
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200733}
734
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200735/*
736 * Conditionally swap X and Y, without leaking information
737 * about whether the swap was made or not.
Shaun Case8b0ecbc2021-12-20 21:14:10 -0800738 * Here it is not ok to simply swap the pointers, which would lead to
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200739 * different memory access patterns when X and Y are used afterwards.
740 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100741int mbedtls_mpi_safe_cond_swap(mbedtls_mpi *X,
742 mbedtls_mpi *Y,
743 unsigned char swap)
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200744{
Gabor Mezeid7edb1d2022-10-10 14:32:09 +0200745 int ret = 0;
746 int s;
Gilles Peskine449bd832023-01-11 14:50:10 +0100747 MPI_VALIDATE_RET(X != NULL);
748 MPI_VALIDATE_RET(Y != NULL);
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200749
Gilles Peskine449bd832023-01-11 14:50:10 +0100750 if (X == Y) {
751 return 0;
752 }
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200753
Gilles Peskine449bd832023-01-11 14:50:10 +0100754 MBEDTLS_MPI_CHK(mbedtls_mpi_grow(X, Y->n));
755 MBEDTLS_MPI_CHK(mbedtls_mpi_grow(Y, X->n));
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200756
757 s = X->s;
Tom Cosgrovee22413c2023-05-03 09:44:01 +0100758 X->s = (int) mbedtls_ct_uint_if(swap, Y->s, X->s);
759 Y->s = (int) mbedtls_ct_uint_if(swap, s, Y->s);
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200760
Gilles Peskine449bd832023-01-11 14:50:10 +0100761 mbedtls_mpi_core_cond_swap(X->p, Y->p, X->n, swap);
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200762
763cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100764 return ret;
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200765}
766
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200767/*
Janos Follath23bdeca2022-07-22 18:24:06 +0100768 * Compare unsigned values in constant time
769 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100770unsigned mbedtls_mpi_core_lt_ct(const mbedtls_mpi_uint *A,
771 const mbedtls_mpi_uint *B,
772 size_t limbs)
Janos Follath23bdeca2022-07-22 18:24:06 +0100773{
Janos Follath23bdeca2022-07-22 18:24:06 +0100774 unsigned ret, cond, done;
775
Janos Follath63184682022-08-11 17:42:59 +0100776 /* The value of any of these variables is either 0 or 1 for the rest of
777 * their scope. */
Janos Follath23bdeca2022-07-22 18:24:06 +0100778 ret = cond = done = 0;
779
Gilles Peskine449bd832023-01-11 14:50:10 +0100780 for (size_t i = limbs; i > 0; i--) {
Janos Follath23bdeca2022-07-22 18:24:06 +0100781 /*
Janos Follathb7a88ec2022-08-19 12:24:40 +0100782 * If B[i - 1] < A[i - 1] then A < B is false and the result must
Janos Follath23bdeca2022-07-22 18:24:06 +0100783 * remain 0.
784 *
785 * Again even if we can make a decision, we just mark the result and
786 * the fact that we are done and continue looping.
787 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100788 cond = mbedtls_ct_mpi_uint_lt(B[i - 1], A[i - 1]);
Janos Follath23bdeca2022-07-22 18:24:06 +0100789 done |= cond;
790
791 /*
Janos Follathb7a88ec2022-08-19 12:24:40 +0100792 * If A[i - 1] < B[i - 1] then A < B is true.
Janos Follath23bdeca2022-07-22 18:24:06 +0100793 *
794 * Again even if we can make a decision, we just mark the result and
795 * the fact that we are done and continue looping.
796 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100797 cond = mbedtls_ct_mpi_uint_lt(A[i - 1], B[i - 1]);
798 ret |= cond & (1 - done);
Janos Follath23bdeca2022-07-22 18:24:06 +0100799 done |= cond;
800 }
801
802 /*
Janos Follathb7a88ec2022-08-19 12:24:40 +0100803 * If all the limbs were equal, then the numbers are equal, A < B is false
Janos Follath23bdeca2022-07-22 18:24:06 +0100804 * and leaving the result 0 is correct.
805 */
806
Gilles Peskine449bd832023-01-11 14:50:10 +0100807 return ret;
Janos Follath23bdeca2022-07-22 18:24:06 +0100808}
809
810/*
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200811 * Compare signed values in constant time
812 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100813int mbedtls_mpi_lt_mpi_ct(const mbedtls_mpi *X,
814 const mbedtls_mpi *Y,
815 unsigned *ret)
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200816{
817 size_t i;
818 /* The value of any of these variables is either 0 or 1 at all times. */
819 unsigned cond, done, X_is_negative, Y_is_negative;
820
Gilles Peskine449bd832023-01-11 14:50:10 +0100821 MPI_VALIDATE_RET(X != NULL);
822 MPI_VALIDATE_RET(Y != NULL);
823 MPI_VALIDATE_RET(ret != NULL);
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200824
Gilles Peskine449bd832023-01-11 14:50:10 +0100825 if (X->n != Y->n) {
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200826 return MBEDTLS_ERR_MPI_BAD_INPUT_DATA;
Gilles Peskine449bd832023-01-11 14:50:10 +0100827 }
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200828
829 /*
830 * Set sign_N to 1 if N >= 0, 0 if N < 0.
831 * We know that N->s == 1 if N >= 0 and N->s == -1 if N < 0.
832 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100833 X_is_negative = (X->s & 2) >> 1;
834 Y_is_negative = (Y->s & 2) >> 1;
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200835
836 /*
837 * If the signs are different, then the positive operand is the bigger.
838 * That is if X is negative (X_is_negative == 1), then X < Y is true and it
839 * is false if X is positive (X_is_negative == 0).
840 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100841 cond = (X_is_negative ^ Y_is_negative);
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200842 *ret = cond & X_is_negative;
843
844 /*
845 * This is a constant-time function. We might have the result, but we still
846 * need to go through the loop. Record if we have the result already.
847 */
848 done = cond;
849
Gilles Peskine449bd832023-01-11 14:50:10 +0100850 for (i = X->n; i > 0; i--) {
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200851 /*
852 * If Y->p[i - 1] < X->p[i - 1] then X < Y is true if and only if both
853 * X and Y are negative.
854 *
855 * Again even if we can make a decision, we just mark the result and
856 * the fact that we are done and continue looping.
857 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100858 cond = mbedtls_ct_mpi_uint_lt(Y->p[i - 1], X->p[i - 1]);
859 *ret |= cond & (1 - done) & X_is_negative;
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200860 done |= cond;
861
862 /*
863 * If X->p[i - 1] < Y->p[i - 1] then X < Y is true if and only if both
864 * X and Y are positive.
865 *
866 * Again even if we can make a decision, we just mark the result and
867 * the fact that we are done and continue looping.
868 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100869 cond = mbedtls_ct_mpi_uint_lt(X->p[i - 1], Y->p[i - 1]);
870 *ret |= cond & (1 - done) & (1 - X_is_negative);
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200871 done |= cond;
872 }
873
Gilles Peskine449bd832023-01-11 14:50:10 +0100874 return 0;
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200875}
876
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200877#endif /* MBEDTLS_BIGNUM_C */
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200878
879#if defined(MBEDTLS_PKCS1_V15) && defined(MBEDTLS_RSA_C) && !defined(MBEDTLS_RSA_ALT)
880
Gilles Peskine449bd832023-01-11 14:50:10 +0100881int mbedtls_ct_rsaes_pkcs1_v15_unpadding(unsigned char *input,
882 size_t ilen,
883 unsigned char *output,
884 size_t output_max_len,
885 size_t *olen)
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200886{
887 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
888 size_t i, plaintext_max_size;
889
890 /* The following variables take sensitive values: their value must
891 * not leak into the observable behavior of the function other than
892 * the designated outputs (output, olen, return value). Otherwise
893 * this would open the execution of the function to
894 * side-channel-based variants of the Bleichenbacher padding oracle
895 * attack. Potential side channels include overall timing, memory
896 * access patterns (especially visible to an adversary who has access
897 * to a shared memory cache), and branches (especially visible to
898 * an adversary who has access to a shared code cache or to a shared
899 * branch predictor). */
900 size_t pad_count = 0;
901 unsigned bad = 0;
902 unsigned char pad_done = 0;
903 size_t plaintext_size = 0;
904 unsigned output_too_large;
905
Gilles Peskine449bd832023-01-11 14:50:10 +0100906 plaintext_max_size = (output_max_len > ilen - 11) ? ilen - 11
Gabor Mezei7013f622021-10-18 16:12:45 +0200907 : output_max_len;
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200908
909 /* Check and get padding length in constant time and constant
910 * memory trace. The first byte must be 0. */
Gabor Mezei63bbba52021-10-18 16:17:57 +0200911 bad |= input[0];
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200912
913
914 /* Decode EME-PKCS1-v1_5 padding: 0x00 || 0x02 || PS || 0x00
Gabor Mezei63bbba52021-10-18 16:17:57 +0200915 * where PS must be at least 8 nonzero bytes. */
916 bad |= input[1] ^ MBEDTLS_RSA_CRYPT;
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200917
918 /* Read the whole buffer. Set pad_done to nonzero if we find
Gabor Mezei63bbba52021-10-18 16:17:57 +0200919 * the 0x00 byte and remember the padding length in pad_count. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100920 for (i = 2; i < ilen; i++) {
921 pad_done |= ((input[i] | (unsigned char) -input[i]) >> 7) ^ 1;
922 pad_count += ((pad_done | (unsigned char) -pad_done) >> 7) ^ 1;
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200923 }
924
925
926 /* If pad_done is still zero, there's no data, only unfinished padding. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100927 bad |= mbedtls_ct_uint_if(pad_done, 0, 1);
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200928
929 /* There must be at least 8 bytes of padding. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100930 bad |= mbedtls_ct_size_gt(8, pad_count);
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200931
932 /* If the padding is valid, set plaintext_size to the number of
933 * remaining bytes after stripping the padding. If the padding
934 * is invalid, avoid leaking this fact through the size of the
935 * output: use the maximum message size that fits in the output
936 * buffer. Do it without branches to avoid leaking the padding
937 * validity through timing. RSA keys are small enough that all the
938 * size_t values involved fit in unsigned int. */
Gabor Mezei90437e32021-10-20 11:59:27 +0200939 plaintext_size = mbedtls_ct_uint_if(
Gilles Peskine449bd832023-01-11 14:50:10 +0100940 bad, (unsigned) plaintext_max_size,
941 (unsigned) (ilen - pad_count - 3));
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200942
943 /* Set output_too_large to 0 if the plaintext fits in the output
944 * buffer and to 1 otherwise. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100945 output_too_large = mbedtls_ct_size_gt(plaintext_size,
946 plaintext_max_size);
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200947
948 /* Set ret without branches to avoid timing attacks. Return:
949 * - INVALID_PADDING if the padding is bad (bad != 0).
950 * - OUTPUT_TOO_LARGE if the padding is good but the decrypted
951 * plaintext does not fit in the output buffer.
952 * - 0 if the padding is correct. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100953 ret = -(int) mbedtls_ct_uint_if(
954 bad, -MBEDTLS_ERR_RSA_INVALID_PADDING,
955 mbedtls_ct_uint_if(output_too_large,
956 -MBEDTLS_ERR_RSA_OUTPUT_TOO_LARGE,
957 0));
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200958
959 /* If the padding is bad or the plaintext is too large, zero the
960 * data that we're about to copy to the output buffer.
961 * We need to copy the same amount of data
962 * from the same buffer whether the padding is good or not to
963 * avoid leaking the padding validity through overall timing or
964 * through memory or cache access patterns. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100965 bad = mbedtls_ct_uint_mask(bad | output_too_large);
966 for (i = 11; i < ilen; i++) {
Gabor Mezei63bbba52021-10-18 16:17:57 +0200967 input[i] &= ~bad;
Gilles Peskine449bd832023-01-11 14:50:10 +0100968 }
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200969
970 /* If the plaintext is too large, truncate it to the buffer size.
971 * Copy anyway to avoid revealing the length through timing, because
972 * revealing the length is as bad as revealing the padding validity
973 * for a Bleichenbacher attack. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100974 plaintext_size = mbedtls_ct_uint_if(output_too_large,
975 (unsigned) plaintext_max_size,
976 (unsigned) plaintext_size);
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200977
978 /* Move the plaintext to the leftmost position where it can start in
979 * the working buffer, i.e. make it start plaintext_max_size from
980 * the end of the buffer. Do this with a memory access trace that
981 * does not depend on the plaintext size. After this move, the
982 * starting location of the plaintext is no longer sensitive
983 * information. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100984 mbedtls_ct_mem_move_to_left(input + ilen - plaintext_max_size,
985 plaintext_max_size,
986 plaintext_max_size - plaintext_size);
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200987
988 /* Finally copy the decrypted plaintext plus trailing zeros into the output
989 * buffer. If output_max_len is 0, then output may be an invalid pointer
990 * and the result of memcpy() would be undefined; prevent undefined
991 * behavior making sure to depend only on output_max_len (the size of the
992 * user-provided output buffer), which is independent from plaintext
993 * length, validity of padding, success of the decryption, and other
994 * secrets. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100995 if (output_max_len != 0) {
996 memcpy(output, input + ilen - plaintext_max_size, plaintext_max_size);
997 }
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200998
999 /* Report the amount of data we copied to the output buffer. In case
1000 * of errors (bad padding or output too large), the value of *olen
1001 * when this function returns is not specified. Making it equivalent
1002 * to the good case limits the risks of leaking the padding validity. */
1003 *olen = plaintext_size;
1004
Gilles Peskine449bd832023-01-11 14:50:10 +01001005 return ret;
gabor-mezei-armfdb71182021-09-27 16:11:12 +02001006}
1007
1008#endif /* MBEDTLS_PKCS1_V15 && MBEDTLS_RSA_C && ! MBEDTLS_RSA_ALT */