commit fd6a1913813e6243bb98b5593f46b77ce8c5fc61
author Manuel Pégourié-Gonnard <mpg@elzevir.fr> Sat Jan 18 19:05:23 2014 +0100
committer Paul Bakker <p.j.bakker@polarssl.org> Wed Jan 22 12:57:04 2014 +0100
tree 8b45572ea946ef882cba920a94b8c6414a8ec359
parent 073f0fa2fb79557e21a26cc2a0160caa593fdb3b

Fix misplaced initialisation.

If one of the calls to mpi_grow() before setting Apos would fail, then
mpi_free( &Apos ) would be executed without Apos being initialised.

library/bignum.c

diff --git a/library/bignum.c b/library/bignum.c
index eb7a822..680c25a 100644
--- a/library/bignum.c
+++ b/library/bignum.c
@@ -1527,6 +1527,7 @@
      */
     mpi_montg_init( &mm, N );
     mpi_init( &RR ); mpi_init( &T );
+    mpi_init( &Apos );
     memset( W, 0, sizeof( W ) );
 
     i = mpi_msb( E );
@@ -1546,8 +1547,6 @@
      * Compensate for negative A (and correct at the end)
      */
     neg = ( A->s == -1 );
-
-    mpi_init( &Apos );
     if( neg )
     {
         MPI_CHK( mpi_copy( &Apos, A ) );