commit fb2001faf541e55bf370aae091f2274ff5fa82fa
author Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Wed Jul 16 12:20:33 2025 +0200
committer Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Fri Jul 18 09:40:14 2025 +0200
tree c681011122d679267347c7701887b68a84f4c4c9
parent 04ac5d8d35b3dd5753d816f2f4504e0f92d043a3

Make sure the whole temporary array is non-zero

Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>

tests/suites/test_suite_bignum_core.function

diff --git a/tests/suites/test_suite_bignum_core.function b/tests/suites/test_suite_bignum_core.function
index b82ba19..61660c4 100644
--- a/tests/suites/test_suite_bignum_core.function
+++ b/tests/suites/test_suite_bignum_core.function
@@ -1408,8 +1408,7 @@
     TEST_LE_U(A_limbs, N_limbs);
     TEST_ASSERT(mpi_core_cmp(A, A_limbs, N, N_limbs) <= 0);
 
-    const size_t limbs = N_limbs;
-    const size_t bytes = limbs * sizeof(mbedtls_mpi_uint);
+    const size_t N_bytes = N_limbs * sizeof(mbedtls_mpi_uint);
 
     TEST_CF_SECRET(A, A_limbs * sizeof(mbedtls_mpi_uint));
     TEST_CF_SECRET(N, N_limbs * sizeof(mbedtls_mpi_uint));
@@ -1426,10 +1425,10 @@
      * Test GCD only (I == NULL)
      */
     TEST_CALLOC(G, N_limbs);
-    memset(G, 'G', bytes);
+    memset(G, 'G', N_bytes);
 
     TEST_CALLOC(T, 4 * N_limbs);
-    memset(T, 'T', bytes);
+    memset(T, 'T', 4 * N_bytes);
 
     mbedtls_mpi_core_gcd_modinv_odd(G, NULL, A, A_limbs, N, N_limbs, T);
     TEST_EQUAL(mpi_core_cmp(G, N_limbs, exp_G, exp_G_limbs), 0);
@@ -1438,10 +1437,10 @@
 
     /* GCD only, G aliased to N */
     TEST_CALLOC(G, N_limbs);
-    memcpy(G, N, bytes);
+    memcpy(G, N, N_bytes);
 
     TEST_CALLOC(T, 4 * N_limbs);
-    memset(T, 'T', bytes);
+    memset(T, 'T', 4 * N_bytes);
 
     mbedtls_mpi_core_gcd_modinv_odd(G, NULL, A, A_limbs, /* N */ G, N_limbs, T);
     TEST_EQUAL(mpi_core_cmp(G, N_limbs, exp_G, exp_G_limbs), 0);
@@ -1453,7 +1452,7 @@
     memcpy(G, A, A_limbs * sizeof(mbedtls_mpi_uint));
 
     TEST_CALLOC(T, 4 * N_limbs);
-    memset(T, 'T', bytes);
+    memset(T, 'T', 4 * N_bytes);
 
     mbedtls_mpi_core_gcd_modinv_odd(G, NULL, /* A */ G, N_limbs, N, N_limbs, T);
     TEST_EQUAL(mpi_core_cmp(G, N_limbs, exp_G, exp_G_limbs), 0);
@@ -1464,13 +1463,13 @@
      * Test GCD + modinv
      */
     TEST_CALLOC(G, N_limbs);
-    memset(G, 'G', bytes);
+    memset(G, 'G', N_bytes);
 
     TEST_CALLOC(I, N_limbs);
-    memset(I, 'I', bytes);
+    memset(I, 'I', N_bytes);
 
     TEST_CALLOC(T, 5 * N_limbs);
-    memset(T, 'T', bytes);
+    memset(T, 'T', 5 * N_bytes);
 
     mbedtls_mpi_core_gcd_modinv_odd(G, I, A, A_limbs, N, N_limbs, T);
 
@@ -1486,10 +1485,10 @@
     memcpy(G, A, A_limbs * sizeof(mbedtls_mpi_uint));
 
     TEST_CALLOC(I, N_limbs);
-    memset(I, 'I', bytes);
+    memset(I, 'I', N_bytes);
 
     TEST_CALLOC(T, 5 * N_limbs);
-    memset(T, 'T', bytes);
+    memset(T, 'T', 5 * N_bytes);
 
     mbedtls_mpi_core_gcd_modinv_odd(G, I, /* A */ G, N_limbs, N, N_limbs, T);
 
@@ -1502,13 +1501,13 @@
 
     /* GCD + modinv, I aliased to A */
     TEST_CALLOC(G, N_limbs);
-    memset(G, 'G', bytes);
+    memset(G, 'G', N_bytes);
 
     TEST_CALLOC(I, N_limbs);
     memcpy(I, A, A_limbs * sizeof(mbedtls_mpi_uint));
 
     TEST_CALLOC(T, 5 * N_limbs);
-    memset(T, 'T', bytes);
+    memset(T, 'T', 5 * N_bytes);
 
     mbedtls_mpi_core_gcd_modinv_odd(G, I, /* A */ I, N_limbs, N, N_limbs, T);