commit f8362ca847d3308378ac1b0bcc2cd28e74ac815d
author Gilles Peskine <Gilles.Peskine@arm.com> Fri Oct 08 16:28:32 2021 +0200
committer Gilles Peskine <Gilles.Peskine@arm.com> Thu Oct 28 10:07:37 2021 +0200
tree 964dc6159dedf3afa74f852f4fbe5d1fdb07aa30
parent 44fa40cd567cf9a78760d6c37942e58c7d6d5550

Readability improvements

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

include/psa/crypto_values.h

diff --git a/include/psa/crypto_values.h b/include/psa/crypto_values.h
index 4d54068..b407fb0 100644
--- a/include/psa/crypto_values.h
+++ b/include/psa/crypto_values.h
@@ -1373,8 +1373,8 @@
  *                      a supported algorithm identifier or policy.
  */
 #define PSA_ALG_IS_RSA_PSS(alg)                                 \
-    ((((alg) & ~PSA_ALG_HASH_MASK) == PSA_ALG_RSA_PSS_BASE) ||  \
-     (((alg) & ~PSA_ALG_HASH_MASK) == PSA_ALG_RSA_PSS_ANY_SALT_BASE))
+    (PSA_ALG_IS_RSA_PSS_STANDARD_SALT(alg) ||                   \
+     PSA_ALG_IS_RSA_PSS_ANY_SALT(alg))
 
 #define PSA_ALG_ECDSA_BASE                      ((psa_algorithm_t)0x06000600)
 /** ECDSA signature with hashing.

library/psa_crypto_rsa.c

diff --git a/library/psa_crypto_rsa.c b/library/psa_crypto_rsa.c
index de17e5d..3b71913 100644
--- a/library/psa_crypto_rsa.c
+++ b/library/psa_crypto_rsa.c
@@ -456,7 +456,7 @@
         return( MBEDTLS_RSA_SALT_LEN_ANY );
     /* Otherwise: standard salt length, i.e. largest possible salt length
      * up to the hash length. */
-    int klen = (int) (int) mbedtls_rsa_get_len( rsa ); // known to fit
+    int klen = (int) mbedtls_rsa_get_len( rsa ); // known to fit
     int hlen = (int) hash_length; // known to fit
     int room = klen - 2 - hlen;
     if( room < 0 )