commit f4d6b49352e752680d917b6dd6343190600506cb
author Hanno Becker <hanno.becker@arm.com> Tue Jul 02 17:13:14 2019 +0100
committer Hanno Becker <hanno.becker@arm.com> Mon Jul 08 11:23:24 2019 +0100
tree c3879f3424abaaf94215175d55b39fa2f8053cea
parent c5db66af2f15ecbd80de16aaa142b8665f9b477d

Allow use of continue in single-ciphersuite 'loops'

library/ssl_cli.c

diff --git a/library/ssl_cli.c b/library/ssl_cli.c
index 8774003..d45f3d3 100644
--- a/library/ssl_cli.c
+++ b/library/ssl_cli.c
@@ -984,12 +984,7 @@
                                       ssl->conf->min_minor_ver,
                                       ssl->conf->max_minor_ver ) != 0 )
         {
-            /* Logically, we want to continue the ciphersuite iteration
-             * here, but We can't just use `continue` because
-             * MBEDTLS_SSL_BEGIN_FOR_EACH_CIPHERSUITE()
-             * doesn't unfold to a loop in case only a single
-             * ciphersuite is enabled. */
-            goto next_suite;
+            continue;
         }
 
         MBEDTLS_SSL_DEBUG_MSG( 3, ( "client hello, add ciphersuite: %04x",
@@ -1005,11 +1000,6 @@
             mbedtls_ssl_suite_get_id( ciphersuite_info ) >> 8 );
         *p++ = (unsigned char)(
             mbedtls_ssl_suite_get_id( ciphersuite_info )      );
-
-    next_suite:
-        /* Need something here to avoid
-         * 'label at end of compound statement' error. */
-        ((void) 0);
     }
     MBEDTLS_SSL_END_FOR_EACH_CIPHERSUITE
 
@@ -1899,23 +1889,13 @@
                                       ssl->conf->min_minor_ver,
                                       ssl->conf->max_minor_ver ) != 0 )
         {
-            /* Logically, we want to continue the ciphersuite iteration
-             * here, but We can't just use `continue` because
-             * MBEDTLS_SSL_BEGIN_FOR_EACH_CIPHERSUITE()
-             * doesn't unfold to a loop in case only a single
-             * ciphersuite is enabled. */
-            goto next_suite;
+            continue;
         }
 
         if( ciphersuite_info != server_suite_info )
-            goto next_suite;
+            continue;
 
         goto server_picked_valid_suite;
-
-    next_suite:
-        /* Need something here to avoid
-         * 'label at end of compound statement' error. */
-        ((void) 0);
     }
     MBEDTLS_SSL_END_FOR_EACH_CIPHERSUITE
 

library/ssl_srv.c

diff --git a/library/ssl_srv.c b/library/ssl_srv.c
index 4ebd834..e743eff 100644
--- a/library/ssl_srv.c
+++ b/library/ssl_srv.c
@@ -1251,7 +1251,7 @@
                 p[1] != ( ( ciphersuite_id >> 8 ) & 0xFF ) ||
                 p[2] != ( ( ciphersuite_id      ) & 0xFF ) )
             {
-                goto next_suite;
+                continue;
             }
 
             got_common_suite = 1;
@@ -1264,11 +1264,6 @@
                 goto have_ciphersuite_v2;
             }
 
-        next_suite:
-            /* Need something here to avoid
-             * 'label at end of compound statement' error. */
-            ((void) 0);
-
 #if defined(MBEDTLS_SSL_SRV_RESPECT_CLIENT_PREFERENCE)
         }
         MBEDTLS_SSL_END_FOR_EACH_CIPHERSUITE
@@ -2174,7 +2169,7 @@
             if( p[0] != ( ( ciphersuite_id >> 8 ) & 0xFF ) ||
                 p[1] != ( ( ciphersuite_id      ) & 0xFF ) )
             {
-                goto next_suite;
+                continue;
             }
 
             got_common_suite = 1;
@@ -2187,12 +2182,6 @@
 #endif /* MBEDTLS_SSL_CONF_SINGLE_CIPHERSUITE */
                 goto have_ciphersuite;
             }
-
-        next_suite:
-            /* Need something here to avoid
-             * 'label at end of compound statement' error. */
-            ((void) 0);
-
 #if defined(MBEDTLS_SSL_SRV_RESPECT_CLIENT_PREFERENCE)
         }
         MBEDTLS_SSL_END_FOR_EACH_CIPHERSUITE