commit f1ee63562aa6bd42603adc61cda158b9fe109360
author Andres Amaya Garcia <Andres.AmayaGarcia@arm.com> Thu Jul 06 10:06:58 2017 +0100
committer Andres Amaya Garcia <andres.amayagarcia@arm.com> Tue Jan 23 19:37:44 2018 +0000
tree 89112def4b7f21689fb65f899a2489c48a2e5bb7
parent 8ec3bfe1800d7b18e24d9439b641e91c4dd408ed

Style fixes in pem, x509_crl and buf_alloc

library/memory_buffer_alloc.c

diff --git a/library/memory_buffer_alloc.c b/library/memory_buffer_alloc.c
index 0d3342d..1cfc27c 100644
--- a/library/memory_buffer_alloc.c
+++ b/library/memory_buffer_alloc.c
@@ -184,7 +184,7 @@
 {
     memory_header *prv = heap.first, *cur;
 
-    if( heap.first == NULL || verify_header( heap.first ) != 0 )
+    if( prv == NULL || verify_header( prv ) != 0 )
     {
 #if defined(MBEDTLS_MEMORY_DEBUG)
         mbedtls_fprintf( stderr, "FATAL: verification of first header "

library/pem.c

diff --git a/library/pem.c b/library/pem.c
index d726bd6..7b3ae8d 100644
--- a/library/pem.c
+++ b/library/pem.c
@@ -435,7 +435,8 @@
         return( MBEDTLS_ERR_BASE64_BUFFER_TOO_SMALL );
     }
 
-    if( use_len != 0 && ( encode_buf = mbedtls_calloc( 1, use_len ) ) == NULL )
+    if( use_len != 0 &&
+        ( ( encode_buf = mbedtls_calloc( 1, use_len ) ) == NULL ) )
         return( MBEDTLS_ERR_PEM_ALLOC_FAILED );
 
     if( ( ret = mbedtls_base64_encode( encode_buf, use_len, &use_len, der_data,

library/x509_crl.c

diff --git a/library/x509_crl.c b/library/x509_crl.c
index c302bb2..8f98d8c 100644
--- a/library/x509_crl.c
+++ b/library/x509_crl.c
@@ -257,7 +257,7 @@
 {
     int ret;
     size_t len;
-    unsigned char *p = NULL, *end;
+    unsigned char *p = NULL, *end = NULL;
     mbedtls_x509_buf sig_params1, sig_params2, sig_oid2;
     mbedtls_x509_crl *crl = chain;
 
@@ -294,7 +294,7 @@
     /*
      * Copy raw DER-encoded CRL
      */
-    if( buflen != 0 && ( p = mbedtls_calloc( 1, buflen ) ) == NULL )
+    if( buflen != 0 && ( ( p = mbedtls_calloc( 1, buflen ) ) == NULL ) )
         return( MBEDTLS_ERR_X509_ALLOC_FAILED );
 
     memcpy( p, buf, buflen );