commit efebad0d67c63d3b734f898a5624b52be8fbf9e4
author Paul Elliott <paul.elliott@arm.com> Wed Feb 15 16:56:45 2023 +0000
committer Paul Elliott <paul.elliott@arm.com> Wed Feb 15 23:34:29 2023 +0000
tree 6fb249af5d01d34c03471d95a058c265b2523c66
parent 7ef174b285b86c8c8e49d479bf6fe552b7eae3f5

Run extra complete in failure tests regardless.

We do not need to expect to fail, running another complete in either sign or
verify after successful completion should also return BAD_STATE.

Signed-off-by: Paul Elliott <paul.elliott@arm.com>

tests/suites/test_suite_psa_crypto.function

diff --git a/tests/suites/test_suite_psa_crypto.function b/tests/suites/test_suite_psa_crypto.function
index 66f932b..2f5b50d 100644
--- a/tests/suites/test_suite_psa_crypto.function
+++ b/tests/suites/test_suite_psa_crypto.function
@@ -6702,13 +6702,12 @@
 
     TEST_EQUAL(actual_status, expected_complete_status);
 
-    if (expected_complete_status != PSA_SUCCESS) {
-        actual_status = psa_sign_hash_complete(&operation, signature,
-                                               signature_size,
-                                               &signature_length);
+    /* Check that another complete returns BAD_STATE. */
+    actual_status = psa_sign_hash_complete(&operation, signature,
+                                           signature_size,
+                                           &signature_length);
 
-        TEST_EQUAL(actual_status, PSA_ERROR_BAD_STATE);
-    }
+    TEST_EQUAL(actual_status, PSA_ERROR_BAD_STATE);
 
     PSA_ASSERT(psa_sign_hash_abort(&operation));
 
@@ -7160,11 +7159,9 @@
 
     TEST_EQUAL(actual_status, expected_complete_status);
 
-    if (expected_complete_status != PSA_SUCCESS) {
-        actual_status = psa_verify_hash_complete(&operation);
-
-        TEST_EQUAL(actual_status, PSA_ERROR_BAD_STATE);
-    }
+    /* Check that another complete returns BAD_STATE. */
+    actual_status = psa_verify_hash_complete(&operation);
+    TEST_EQUAL(actual_status, PSA_ERROR_BAD_STATE);
 
     TEST_LE_U(min_completes, num_completes);
     TEST_LE_U(num_completes, max_completes);