commit e9eca7fe8dbd29bdaaacd5385c98eecc99c8c1e5
author Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Thu Jun 17 13:25:03 2021 +0200
committer Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Thu Jun 17 16:40:22 2021 +0200
tree dec877bb292cbc0ad53374b835ea7aa61fba4c76
parent 6aba8fc23011d61a9ed73a233d593572748e7019

Homogenize coding patterns

Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>

library/bignum.c

diff --git a/library/bignum.c b/library/bignum.c
index c17c3d6..8a2acdb 100644
--- a/library/bignum.c
+++ b/library/bignum.c
@@ -349,7 +349,7 @@
 #endif
 
     /* make sure assign is 0 or 1 in a time-constant manner */
-    assign = (assign | (unsigned char)-assign) >> 7;
+    assign = (assign | (unsigned char)-assign) >> (sizeof( assign ) * 8 - 1);
     /* all-bits 1 if assign is 1, all-bits 0 if assign is 0 */
     limb_mask = -assign;
 
@@ -396,7 +396,7 @@
 #endif
 
     /* make sure swap is 0 or 1 in a time-constant manner */
-    swap = (swap | (unsigned char)-swap) >> 7;
+    swap = (swap | (unsigned char)-swap) >> (sizeof( swap ) * 8 - 1);
     /* all-bits 1 if swap is 1, all-bits 0 if swap is 0 */
     limb_mask = -swap;
 
@@ -2128,7 +2128,7 @@
 #endif
 
     /* diff_msb's most significant bit is equal to x != y */
-    const size_t diff_msb = ( diff | -diff );
+    const size_t diff_msb = ( diff | (size_t) -diff );
 
 #if defined(_MSC_VER)
 #pragma warning( pop )