commit e655479528b8dff247d3c67e310c8f9067ad12e4
author Gilles Peskine <Gilles.Peskine@arm.com> Tue Dec 20 19:24:27 2022 +0100
committer Gilles Peskine <Gilles.Peskine@arm.com> Tue Dec 20 19:55:51 2022 +0100
tree 2ed30771fa04b48b91a28ebf4c8419a4bf9b4af5
parent eb2e77f6170de7ae8738f0dfdbd261dbf6347006

Generalize representation handling in mbedtls_mpi_mod_read

Call mbedtls_mpi_mod_raw_canonical_to_modulus_rep instead of assuming that
anything that isn't MBEDTLS_MPI_MOD_REP_MONTGOMERY is canonical.

mbedtls_mpi_mod_write should get the same treatment, but I'm holding off
until https://github.com/Mbed-TLS/mbedtls/issues/6679 is done.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

library/bignum_mod.c

diff --git a/library/bignum_mod.c b/library/bignum_mod.c
index 3eef4e7..4ac6277 100644
--- a/library/bignum_mod.c
+++ b/library/bignum_mod.c
@@ -248,8 +248,7 @@
 
     r->limbs = m->limbs;
 
-    if( m->int_rep == MBEDTLS_MPI_MOD_REP_MONTGOMERY )
-       ret = mbedtls_mpi_mod_raw_to_mont_rep( r->p, m );
+    ret = mbedtls_mpi_mod_raw_canonical_to_modulus_rep( r->p, m );
 
 cleanup:
     return ( ret );