commit dd05aab6a06e877cc90872d923eb9f47b3079bda
author gabor-mezei-arm <gabor.mezei@arm.com> Mon May 03 16:30:53 2021 +0200
committer gabor-mezei-arm <gabor.mezei@arm.com> Thu May 06 13:50:32 2021 +0200
tree 006341ae78b7d100ca3ff2c3105d08947ca643d6
parent 2e14879c156e5c05bd681db2424ff5c61bf22af2

Use switch-case for error handling

Signed-off-by: gabor-mezei-arm <gabor.mezei@arm.com>

library/psa_crypto.c

diff --git a/library/psa_crypto.c b/library/psa_crypto.c
index aa1beb5..fc330ea 100644
--- a/library/psa_crypto.c
+++ b/library/psa_crypto.c
@@ -2871,21 +2871,26 @@
 
     *signature_length = 0;
 
-    if( operation == PSA_SIGN_INVALID )
-        return( PSA_ERROR_INVALID_ARGUMENT );
-    else
+    switch( operation )
     {
-        if( ! PSA_ALG_IS_SIGN_MESSAGE( alg ) )
-            return( PSA_ERROR_INVALID_ARGUMENT );
+        case PSA_SIGN_HASH:
+            if( ! PSA_ALG_IS_HASH_AND_SIGN( alg ) )
+                return( PSA_ERROR_INVALID_ARGUMENT );
+            break;
 
-        if( operation == PSA_SIGN_MESSAGE )
-        {
+        case PSA_SIGN_MESSAGE:
+            if( ! PSA_ALG_IS_SIGN_MESSAGE( alg ) )
+                return( PSA_ERROR_INVALID_ARGUMENT );
+
             if ( PSA_ALG_IS_HASH_AND_SIGN( alg ) )
             {
                 if( ! PSA_ALG_IS_HASH( PSA_ALG_SIGN_GET_HASH( alg ) ) )
                     return( PSA_ERROR_INVALID_ARGUMENT );
             }
-        }
+            break;
+
+        default:
+            return( PSA_ERROR_INVALID_ARGUMENT );
     }
 
     /* Immediately reject a zero-length signature buffer. This guarantees
@@ -2961,21 +2966,26 @@
     psa_status_t unlock_status = PSA_ERROR_CORRUPTION_DETECTED;
     psa_key_slot_t *slot;
 
-    if( operation == PSA_VERIFY_INVALID )
-        return( PSA_ERROR_INVALID_ARGUMENT );
-    else
+    switch( operation )
     {
-        if( ! PSA_ALG_IS_SIGN_MESSAGE( alg ) )
-            return( PSA_ERROR_INVALID_ARGUMENT );
+        case PSA_VERIFY_HASH:
+            if( ! PSA_ALG_IS_HASH_AND_SIGN( alg ) )
+                return( PSA_ERROR_INVALID_ARGUMENT );
+            break;
 
-        if( operation == PSA_VERIFY_MESSAGE )
-        {
+        case PSA_VERIFY_MESSAGE:
+            if( ! PSA_ALG_IS_SIGN_MESSAGE( alg ) )
+                return( PSA_ERROR_INVALID_ARGUMENT );
+
             if ( PSA_ALG_IS_HASH_AND_SIGN( alg ) )
             {
                 if( ! PSA_ALG_IS_HASH( PSA_ALG_SIGN_GET_HASH( alg ) ) )
                     return( PSA_ERROR_INVALID_ARGUMENT );
             }
-        }
+            break;
+
+        default:
+            return( PSA_ERROR_INVALID_ARGUMENT );
     }
 
     status = psa_get_and_lock_key_slot_with_policy(