commit d2929b562628b3d15701aa13dcd5ed2aaf3ab675
author Hanno Becker <hanno.becker@arm.com> Wed Sep 04 16:07:52 2019 +0100
committer Hanno Becker <hanno.becker@arm.com> Wed Sep 04 16:19:49 2019 +0100
tree 0b0cb037a49eaeee7a328f2929f79a61089fa93d
parent 96d34d57ec3f9a9d4041439011074a16a84b9d78

Fixup TinyCrypt PK wrap: Check TinyCrypt signature return code

library/pk_wrap.c

diff --git a/library/pk_wrap.c b/library/pk_wrap.c
index e667e30..2bcc947 100644
--- a/library/pk_wrap.c
+++ b/library/pk_wrap.c
@@ -685,6 +685,7 @@
 {
     const mbedtls_uecc_keypair *keypair = (const mbedtls_uecc_keypair *) ctx;
     const struct uECC_Curve_t * uecc_curve = uECC_secp256r1();
+    int ret;
 
     /*
      * RFC-4492 page 20:
@@ -703,7 +704,11 @@
      */
      #define MAX_SECP256R1_ECDSA_SIG_LEN ( 3 + 2 * ( 3 + NUM_ECC_BYTES ) )
 
-    uECC_sign( keypair->private_key, hash, hash_len, sig, uecc_curve );
+    ret = uECC_sign( keypair->private_key, hash, hash_len, sig, uecc_curve );
+    /* TinyCrypt uses 0 to signal errors. */
+    if( ret == 0 )
+        return( MBEDTLS_ERR_PK_HW_ACCEL_FAILED );
+
     *sig_len = 2 * NUM_ECC_BYTES;
 
     /* uECC owns its rng function pointer */