commit d04d292b64865b1316d4c3117a2cc3104404e90c
author Gilles Peskine <Gilles.Peskine@arm.com> Sat Jan 06 03:13:12 2018 +0100
committer Gilles Peskine <Gilles.Peskine@arm.com> Tue Apr 24 09:36:36 2018 +0200
tree e7850b7b8a5b3f7919225e3b2204ddf3b678412c
parent ab50f83a93b07fb0bb82ecdfcf4d8565229e9173

Get rid of useless handshake field out_async_start

The location where the signature goes is now tracked via
ssl->out_msglen, which makes ssl->handshake->out_async_start redundant.

include/mbedtls/ssl_internal.h

diff --git a/include/mbedtls/ssl_internal.h b/include/mbedtls/ssl_internal.h
index e4b767b..c141e8a 100644
--- a/include/mbedtls/ssl_internal.h
+++ b/include/mbedtls/ssl_internal.h
@@ -220,7 +220,6 @@
 #endif /* MBEDTLS_X509_CRT_PARSE_C */
 #if defined(MBEDTLS_SSL_ASYNC_PRIVATE_C)
     void *p_async_operation_ctx;        /*!< asynchronous operation context */
-    unsigned char *out_async_start;     /*!< pointer where the asynchronous operation must write in the output buffer */
 #endif /* MBEDTLS_SSL_ASYNC_PRIVATE_C */
 
 #if defined(MBEDTLS_SSL_PROTO_DTLS)

library/ssl_srv.c

diff --git a/library/ssl_srv.c b/library/ssl_srv.c
index daf87b9..f6db3c7 100644
--- a/library/ssl_srv.c
+++ b/library/ssl_srv.c
@@ -2846,10 +2846,9 @@
 
 #if defined(MBEDTLS_KEY_EXCHANGE__WITH_SERVER_SIGNATURE__ENABLED) && \
     defined(MBEDTLS_SSL_ASYNC_PRIVATE_C)
-    if( ssl->handshake->out_async_start != NULL )
+    if( ssl->handshake->p_async_operation_ctx != NULL )
     {
         MBEDTLS_SSL_DEBUG_MSG( 2, ( "resuming signature operation" ) );
-        p = ssl->handshake->out_async_start;
         goto async_resume;
     }
 #endif /* defined(MBEDTLS_KEY_EXCHANGE__WITH_SERVER_SIGNATURE__ENABLED) &&
@@ -3215,7 +3214,6 @@
                 }
                 /* FALLTHROUGH */
             case MBEDTLS_ERR_SSL_ASYNC_IN_PROGRESS:
-                ssl->handshake->out_async_start = ssl->out_msg + ssl->out_msglen;
                 MBEDTLS_SSL_DEBUG_MSG( 2, ( "<= write server key exchange (pending)" ) );
                 return( MBEDTLS_ERR_SSL_ASYNC_IN_PROGRESS );
             default: