commit c94b6b07dc752de98c10ad15b77a29f5f0099c37
author Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Thu Jun 17 13:25:03 2021 +0200
committer Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Thu Jun 17 16:39:47 2021 +0200
tree 72f93f274f871703b96ce6a8ce52074b35bd2421
parent 7576f55f193a12d2dcfae435e837ad10bebab54a

Homogenize coding patterns

Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>

library/bignum.c

diff --git a/library/bignum.c b/library/bignum.c
index 0c758c5..dd80eb4 100644
--- a/library/bignum.c
+++ b/library/bignum.c
@@ -340,7 +340,7 @@
 #endif
 
     /* make sure assign is 0 or 1 in a time-constant manner */
-    assign = (assign | (unsigned char)-assign) >> 7;
+    assign = (assign | (unsigned char)-assign) >> (sizeof( assign ) * 8 - 1);
     /* all-bits 1 if assign is 1, all-bits 0 if assign is 0 */
     limb_mask = -assign;
 
@@ -387,7 +387,7 @@
 #endif
 
     /* make sure swap is 0 or 1 in a time-constant manner */
-    swap = (swap | (unsigned char)-swap) >> 7;
+    swap = (swap | (unsigned char)-swap) >> (sizeof( swap ) * 8 - 1);
     /* all-bits 1 if swap is 1, all-bits 0 if swap is 0 */
     limb_mask = -swap;
 
@@ -2223,7 +2223,7 @@
 #endif
 
     /* diff_msb's most significant bit is equal to x != y */
-    const size_t diff_msb = ( diff | -diff );
+    const size_t diff_msb = ( diff | (size_t) -diff );
 
 #if defined(_MSC_VER)
 #pragma warning( pop )