commit c941adba31c906e98cfabb445f08057743eb8b8a
author Paul Bakker <p.j.bakker@polarssl.org> Mon Jul 07 14:17:24 2014 +0200
committer Paul Bakker <p.j.bakker@polarssl.org> Mon Jul 07 14:17:24 2014 +0200
tree 892e63774b9e569d8d5c92ab3084f6c14189a405
parent cf78ba2b89dc72d1ca95a8aad9fcdb835f6f12a3

Fixed X.509 hostname comparison (with non-regular characters)

ChangeLog

diff --git a/ChangeLog b/ChangeLog
index 27a6747..92a7e28 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -4,6 +4,9 @@
 Changes
    * Introduced POLARSSL_HAVE_READDIR_R for systems without it
 
+Bugfix
+   * Fixed X.509 hostname comparison (with non-regular characters)
+
 = Version 1.2.10 released 2013-10-07
 Changes
    * Changed RSA blinding to a slower but thread-safe version

library/x509parse.c

diff --git a/library/x509parse.c b/library/x509parse.c
index 42eaf58..26d655f 100644
--- a/library/x509parse.c
+++ b/library/x509parse.c
@@ -3281,11 +3281,15 @@
     {
         diff = n1[i] ^ n2[i];
 
-        if( ( n1[i] >= 'a' || n1[i] <= 'z' ) && ( diff == 0 || diff == 32 ) )
+        if( diff == 0 )
             continue;
 
-        if( ( n1[i] >= 'A' || n1[i] <= 'Z' ) && ( diff == 0 || diff == 32 ) )
+        if( diff == 32 &&
+            ( ( n1[i] >= 'a' && n1[i] <= 'z' ) ||
+              ( n1[i] >= 'A' && n1[i] <= 'Z' ) ) )
+        {
             continue;
+        }
 
         return( 1 );
     }