commit bc1babb38759446b93ec53d82f0ec961cffe1b5a
author Manuel Pégourié-Gonnard <mpg2@elzevir.fr> Fri Oct 02 11:16:47 2015 +0200
committer Manuel Pégourié-Gonnard <mpg2@elzevir.fr> Fri Oct 02 11:20:28 2015 +0200
tree 3b152b28d4848366b0c80b7cad636911ddb4baed
parent 54eec9d1dd1817bf87c8167805379a0a93769ed2

Fix potential overflow in CertificateRequest

library/ssl_srv.c

diff --git a/library/ssl_srv.c b/library/ssl_srv.c
index b48a609..1bda53c 100644
--- a/library/ssl_srv.c
+++ b/library/ssl_srv.c
@@ -2351,6 +2351,7 @@
     size_t dn_size, total_dn_size; /* excluding length bytes */
     size_t ct_len, sa_len; /* including length bytes */
     unsigned char *buf, *p;
+    const unsigned char * const end = ssl->out_msg + MBEDTLS_SSL_MAX_CONTENT_LEN;
     const mbedtls_x509_crt *crt;
     int authmode;
 
@@ -2471,10 +2472,14 @@
     total_dn_size = 0;
     while( crt != NULL && crt->version != 0 )
     {
-        if( p - buf > 4096 )
-            break;
-
         dn_size = crt->subject_raw.len;
+
+        if( end < p || (size_t)( end - p ) < 2 + dn_size )
+        {
+            MBEDTLS_SSL_DEBUG_MSG( 1, ( "skipping CAs: buffer too short" ) );
+            break;
+        }
+
         *p++ = (unsigned char)( dn_size >> 8 );
         *p++ = (unsigned char)( dn_size      );
         memcpy( p, crt->subject_raw.p, dn_size );