commit ae5a35fc30744052954b1980545d51eb79b4878a
author Gilles Peskine <Gilles.Peskine@arm.com> Fri Sep 13 15:18:07 2024 +0200
committer Gilles Peskine <Gilles.Peskine@arm.com> Tue Sep 24 18:59:31 2024 +0200
tree 498f7ebb645ac0cdd9b3542774688077e8a32857
parent edc8f35ed3a021040a079fd4fcdede5e8e5bec1b

Remove obsolete requirements on middlebox compatibility mode: generated

MBEDTLS_SSL_TLS1_3_COMPATIBILITY_MODE is no longer required, except in test
cases that are specifically about it. This commit removes the requirement in
tls13-compat.sh (which does not have test cases that actually depend on the
feature).

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

tests/scripts/generate_tls13_compat_tests.py

diff --git a/tests/scripts/generate_tls13_compat_tests.py b/tests/scripts/generate_tls13_compat_tests.py
index 92ca5d6..6dc0be3 100755
--- a/tests/scripts/generate_tls13_compat_tests.py
+++ b/tests/scripts/generate_tls13_compat_tests.py
@@ -66,7 +66,7 @@
 
     # pylint: disable=too-many-arguments
     def __init__(self, ciphersuite=None, signature_algorithm=None, named_group=None,
-                 cert_sig_alg=None, compat_mode=True):
+                 cert_sig_alg=None):
         self._ciphers = []
         self._sig_algs = []
         self._named_groups = []
@@ -79,7 +79,6 @@
             self.add_signature_algorithms(signature_algorithm)
         if cert_sig_alg:
             self.add_cert_signature_algorithms(cert_sig_alg)
-        self._compat_mode = compat_mode
 
     # add_ciphersuites should not override by sub class
     def add_ciphersuites(self, *ciphersuites):
@@ -157,8 +156,6 @@
             ret += ["-groups {named_groups}".format(named_groups=named_groups)]
 
         ret += ['-msg -tls1_3']
-        if not self._compat_mode:
-            ret += ['-no_middlebox']
 
         return ret
 
@@ -288,9 +285,6 @@
         priority_string = ':+'.join(priority_string_list)
         priority_string += ':%NO_TICKETS'
 
-        if not self._compat_mode:
-            priority_string += [':%DISABLE_TLS13_COMPAT_MODE']
-
         ret += ['--priority={priority_string}'.format(
             priority_string=priority_string)]
         return ret
@@ -370,9 +364,6 @@
         ret = ['requires_config_enabled MBEDTLS_DEBUG_C',
                'requires_config_enabled MBEDTLS_SSL_TLS1_3_KEY_EXCHANGE_MODE_EPHEMERAL_ENABLED']
 
-        if self._compat_mode:
-            ret += ['requires_config_enabled MBEDTLS_SSL_TLS1_3_COMPATIBILITY_MODE']
-
         if 'rsa_pss_rsae_sha256' in self._sig_algs + self._cert_sig_algs:
             ret.append(
                 'requires_config_enabled MBEDTLS_X509_RSASSA_PSS_SUPPORT')