commit ad353f289be33097aa1578d68af192a96e51988b
author Hanno Becker <hanno.becker@arm.com> Tue Aug 20 13:04:30 2019 +0100
committer Hanno Becker <hanno.becker@arm.com> Wed Sep 04 16:17:25 2019 +0100
tree 00c5af28ab3ede5f9b58a460753280fda365925f
parent e8f14483062de9d23e45079d2c93838eb85ba1eb

Fixup: Minor style corrections around use of TinyCrypt

library/pk_wrap.c

diff --git a/library/pk_wrap.c b/library/pk_wrap.c
index ea3d24c..3edd704 100644
--- a/library/pk_wrap.c
+++ b/library/pk_wrap.c
@@ -552,10 +552,13 @@
     ((void) md_alg);
     p = (unsigned char*) sig;
 
-    if( (ret = extract_ecdsa_sig( &p, sig + sig_len, signature, NUM_ECC_BYTES ) ) != 0 )
+    ret = extract_ecdsa_sig( &p, sig + sig_len, signature, NUM_ECC_BYTES );
+    if( ret != 0 )
         return( ret );
 
-    if( (ret = uECC_verify( (uint8_t *) ctx, hash, (unsigned) hash_len, signature, uecc_curve ) ) != 0 )
+    ret = uECC_verify( (uint8_t *) ctx, hash,
+                       (unsigned) hash_len, signature, uecc_curve );
+    if( ret != 0 )
         return( MBEDTLS_ERR_PK_SIG_LEN_MISMATCH );
 
     return( ret );

library/pkparse.c

diff --git a/library/pkparse.c b/library/pkparse.c
index 7573bdc..99464e0 100644
--- a/library/pkparse.c
+++ b/library/pkparse.c
@@ -554,7 +554,7 @@
     if( ilen < 1 )
         return( MBEDTLS_ERR_PK_INVALID_PUBKEY );
 
-    //We are not handling the infinity point right now
+    /* We are not handling the point at infinity. */
 
     if( buf[0] != 0x04 )
         return( MBEDTLS_ERR_PK_FEATURE_UNAVAILABLE );
@@ -917,7 +917,7 @@
     if( ( ret = mbedtls_asn1_get_tag( &p, end, &len, MBEDTLS_ASN1_OCTET_STRING ) ) != 0 )
         return( MBEDTLS_ERR_PK_KEY_INVALID_FORMAT + ret );
 
-    memcpy(keypair->private_key, p, len);
+    memcpy( keypair->private_key, p, len );
 
     p += len;
 
@@ -960,9 +960,11 @@
                 return( MBEDTLS_ERR_PK_KEY_INVALID_FORMAT +
                         MBEDTLS_ERR_ASN1_LENGTH_MISMATCH );
 
-            if( ( ret = uecc_public_key_read_binary( keypair->public_key, 
+            if( ( ret = uecc_public_key_read_binary( keypair->public_key,
                             (const unsigned char *) p, end2 - p ) ) == 0 )
+            {
                 pubkey_done = 1;
+            }
             else
             {
                 /*