commit ac97af223eda0358413dee5349d6912d82d891f8
author Waleed Elmelegy <waleed.elmelegy@arm.com> Thu Oct 12 15:46:06 2023 +0100
committer Waleed Elmelegy <waleed.elmelegy@arm.com> Thu Oct 12 15:46:06 2023 +0100
tree 08fe8bd2f78ad11108ecced1239e56eb846425e3
parent e7ebec6723b61bd54800f649b1391e980edf2fbd

Fix possible NULL dereference issue in X509 cert_req program

Signed-off-by: Waleed Elmelegy <waleed.elmelegy@arm.com>

programs/x509/cert_req.c

diff --git a/programs/x509/cert_req.c b/programs/x509/cert_req.c
index 558d8cc..bc4eb80 100644
--- a/programs/x509/cert_req.c
+++ b/programs/x509/cert_req.c
@@ -261,6 +261,9 @@
 
                 if ((subtype_value = strchr(q, ':')) != NULL) {
                     *subtype_value++ = '\0';
+                } else {
+                    mbedtls_printf("Invalid argument for option SAN: Entry should be separated by a colon\n");
+                    goto usage;
                 }
                 if (strcmp(q, "RFC822") == 0) {
                     cur->node.type = MBEDTLS_X509_SAN_RFC822_NAME;