commit aa377cf11131f6a546c43e58726600de034e031b
author Manuel Pégourié-Gonnard <mpg@elzevir.fr> Fri Jan 24 12:11:56 2020 +0100
committer Simon Butcher <simon.butcher@arm.com> Fri Mar 13 15:37:54 2020 +0000
tree efcd9dec256c08f13d229f401600cc24f9ce6116
parent c0213a91abe4419743cd81bac4bd9a4d5bd03608

Fix incrementing pointer instead of value

This was introduced by a hasty search-and-replace that didn't account for C's
operator precedence when changing those variables to pointer types.

library/ecdsa.c

diff --git a/library/ecdsa.c b/library/ecdsa.c
index 6577785..6cfaa08 100644
--- a/library/ecdsa.c
+++ b/library/ecdsa.c
@@ -297,7 +297,7 @@
     *p_sign_tries = 0;
     do
     {
-        if( *p_sign_tries++ > 10 )
+        if( (*p_sign_tries)++ > 10 )
         {
             ret = MBEDTLS_ERR_ECP_RANDOM_FAILED;
             goto cleanup;
@@ -310,7 +310,7 @@
         *p_key_tries = 0;
         do
         {
-            if( *p_key_tries++ > 10 )
+            if( (*p_key_tries)++ > 10 )
             {
                 ret = MBEDTLS_ERR_ECP_RANDOM_FAILED;
                 goto cleanup;