Correcting documentation issues:
- Changelog entry is Feature instead of API Change
- Correcting whitespaces around braces
- Also adding defensive mechanism to x509_get_subject_key_id
to avoid malfunction in case of trailing garbage
Signed-off-by: toth92g <toth92g@gmail.com>
diff --git a/tests/suites/test_suite_x509parse.function b/tests/suites/test_suite_x509parse.function
index 8408d88..3a56adf 100644
--- a/tests/suites/test_suite_x509parse.function
+++ b/tests/suites/test_suite_x509parse.function
@@ -1414,16 +1414,16 @@
TEST_ASSERT( mbedtls_x509_crt_parse_file( &crt, crt_path ) == retVal );
- if(retVal != 0)
+ if( retVal != 0 )
{
- while(i < subjectKeyIdLength)
+ while( i < subjectKeyIdLength )
{
result |= crt.subject_key_id.p[i] != subjectKeyId[i*2];
result |= crt.subject_key_id.p[i+1] != subjectKeyId[i*2+1];
i++;
}
- TEST_ASSERT(result == 0);
+ TEST_ASSERT( result == 0 );
}
exit:
@@ -1444,10 +1444,10 @@
TEST_ASSERT( mbedtls_x509_crt_parse_file( &crt, crt_path ) == retVal );
- if (retVal != 0)
+ if ( retVal != 0 )
{
/* KeyId test */
- while(i < keyIdLength)
+ while( i < keyIdLength )
{
result |= crt.authority_key_id.keyIdentifier.p[i] != authorityKeyId_keyId[i*2];
result |= crt.authority_key_id.keyIdentifier.p[i+1] != authorityKeyId_keyId[i*2+1];
@@ -1456,11 +1456,11 @@
/* Issuer test */
mbedtls_x509_name* issuerPtr = &crt.authority_key_id.authorityCertIssuer;
- while (issuerPtr != NULL)
+ while ( issuerPtr != NULL )
{
- for (issuerCounter = 0u; issuerCounter < issuerPtr->val.len; issuerCounter++)
+ for ( issuerCounter = 0u; issuerCounter < issuerPtr->val.len; issuerCounter++ )
{
- result |= (authorityKeyId_issuer[bufferCounter++] != issuerPtr->val.p[issuerCounter]);
+ result |= ( authorityKeyId_issuer[bufferCounter++] != issuerPtr->val.p[issuerCounter] );
}
bufferCounter++; /* Skipping the slash */
issuerPtr = issuerPtr->next;
@@ -1468,14 +1468,14 @@
/* Serial test */
i = 0;
- while(i < serialLength)
+ while( i < serialLength )
{
result |= crt.authority_key_id.authorityCertSerialNumber.p[i] != authorityKeyId_serial[i*2];
result |= crt.authority_key_id.authorityCertSerialNumber.p[i+1] != authorityKeyId_serial[i*2+1];
i++;
}
- TEST_ASSERT(result == 0);
+ TEST_ASSERT( result == 0 );
}
exit: