commit 95070a828660f8964bd4bd6b52162481873d685d
author k-stachowiak <krzysiek.stachowiak@gmail.com> Wed Dec 19 14:48:37 2018 +0100
committer k-stachowiak <krzysiek.stachowiak@gmail.com> Wed Dec 19 17:34:58 2018 +0100
tree 8b02cd2e77e837d0631705422b2abef4621b7a26
parent 6df25e793009466a857140127732dce01db9b686

Make some cipher parameter validation unconditional

include/mbedtls/cipher.h

diff --git a/include/mbedtls/cipher.h b/include/mbedtls/cipher.h
index dc76443..5200554 100644
--- a/include/mbedtls/cipher.h
+++ b/include/mbedtls/cipher.h
@@ -428,7 +428,8 @@
     const mbedtls_cipher_context_t *ctx )
 {
     MBEDTLS_INTERNAL_VALIDATE_RET( ctx != NULL, 0 );
-    MBEDTLS_INTERNAL_VALIDATE_RET( ctx->cipher_info != NULL, 0 );
+    if( ctx->cipher_info == NULL )
+        return 0;
 
     return ctx->cipher_info->block_size;
 }
@@ -446,7 +447,8 @@
     const mbedtls_cipher_context_t *ctx )
 {
     MBEDTLS_INTERNAL_VALIDATE_RET( ctx != NULL, MBEDTLS_MODE_NONE );
-    MBEDTLS_INTERNAL_VALIDATE_RET( ctx->cipher_info != NULL, MBEDTLS_MODE_NONE );
+    if( ctx->cipher_info == NULL )
+        return MBEDTLS_MODE_NONE;
 
     return ctx->cipher_info->mode;
 }
@@ -465,7 +467,8 @@
     const mbedtls_cipher_context_t *ctx )
 {
     MBEDTLS_INTERNAL_VALIDATE_RET( ctx != NULL, 0 );
-    MBEDTLS_INTERNAL_VALIDATE_RET( ctx->cipher_info != NULL, 0 );
+    if( ctx->cipher_info == NULL )
+        return 0;
 
     if( ctx->iv_size != 0 )
         return (int) ctx->iv_size;
@@ -486,8 +489,8 @@
 {
     MBEDTLS_INTERNAL_VALIDATE_RET(
         ctx != NULL, MBEDTLS_CIPHER_NONE );
-    MBEDTLS_INTERNAL_VALIDATE_RET(
-        ctx->cipher_info != NULL, MBEDTLS_CIPHER_NONE );
+    if( ctx->cipher_info == NULL )
+        return MBEDTLS_CIPHER_NONE;
 
     return ctx->cipher_info->type;
 }
@@ -505,7 +508,8 @@
     const mbedtls_cipher_context_t *ctx )
 {
     MBEDTLS_INTERNAL_VALIDATE_RET( ctx != NULL, 0 );
-    MBEDTLS_INTERNAL_VALIDATE_RET( ctx->cipher_info != NULL, 0 );
+    if( ctx->cipher_info == NULL )
+        return 0;
 
     return ctx->cipher_info->name;
 }
@@ -524,8 +528,8 @@
 {
     MBEDTLS_INTERNAL_VALIDATE_RET(
         ctx != NULL, MBEDTLS_KEY_LENGTH_NONE );
-    MBEDTLS_INTERNAL_VALIDATE_RET(
-        ctx->cipher_info != NULL, MBEDTLS_KEY_LENGTH_NONE );
+    if( ctx->cipher_info == NULL )
+        return MBEDTLS_KEY_LENGTH_NONE;
 
     return (int) ctx->cipher_info->key_bitlen;
 }
@@ -543,8 +547,8 @@
 {
     MBEDTLS_INTERNAL_VALIDATE_RET(
         ctx != NULL, MBEDTLS_OPERATION_NONE );
-    MBEDTLS_INTERNAL_VALIDATE_RET(
-        ctx->cipher_info != NULL, MBEDTLS_OPERATION_NONE );
+    if( ctx->cipher_info == NULL )
+        return MBEDTLS_OPERATION_NONE;
 
     return ctx->operation;
 }