commit 938a15e58408f636e40e10cb553a6befc006ba92
author Hanno Becker <hanno.becker@arm.com> Tue Dec 18 16:43:45 2018 +0000
committer Hanno Becker <hanno.becker@arm.com> Wed Dec 19 12:51:00 2018 +0000
tree 97c4153a744c93b36e2e16ab024a0821d7a98fde
parent 14b91e8e228fb3cd766842e894215db126ed6291

Leave behaviour on NULL input unspecified in ARIA

We allow a NULL input buffer if the input length is zero,
but we don't test it. As long as that's the case, we shouldn't
promise to support it.

include/mbedtls/aria.h

diff --git a/include/mbedtls/aria.h b/include/mbedtls/aria.h
index 3db4376..1e8956e 100644
--- a/include/mbedtls/aria.h
+++ b/include/mbedtls/aria.h
@@ -200,10 +200,10 @@
  *                 multiple of the block size (16 Bytes).
  * \param iv       Initialization vector (updated after use).
  *                 This must be a readable buffer of size 16 Bytes.
- * \param input    The buffer holding the input data.
- *                 This may be \c NULL if `length == 0`.
- * \param output   The buffer holding the output data.
- *                 This may be \c NULL if `length == 0`.
+ * \param input    The buffer holding the input data. This must
+ *                 be a readable buffer of length \p length Bytes.
+ * \param output   The buffer holding the output data. This must
+ *                 be a writable buffer of length \p length Bytes.
  *
  * \return         \c 0 on success.
  * \return         A negative error code on failure.
@@ -250,10 +250,10 @@
  *                 This must not be larger than 15.
  * \param iv       The initialization vector (updated after use).
  *                 This must be a readable buffer of size 16 Bytes.
- * \param input    The buffer holding the input data.
- *                 This may be \c NULL if `length == 0`.
- * \param output   The buffer holding the output data.
- *                 This may be \c NULL if `length == 0`.
+ * \param input    The buffer holding the input data. This must
+ *                 be a readable buffer of length \p length Bytes.
+ * \param output   The buffer holding the output data. This must
+ *                 be a writable buffer of length \p length Bytes.
  *
  * \return         \c 0 on success.
  * \return         A negative error code on failure.
@@ -337,10 +337,10 @@
  * \param stream_block     The saved stream block for resuming. This must
  *                         point to a read/write buffer of length \c 16 bytes.
  *                         This is overwritten by the function.
- * \param input            The buffer holding the input data.
- *                         This may be \c NULL if `length == 0`.
- * \param output           The buffer holding the output data.
- *                         This may be \c NULL if `length == 0`.
+ * \param input            The buffer holding the input data. This must
+ *                         be a readable buffer of length \p length Bytes.
+ * \param output           The buffer holding the output data. This must
+ *                         be a writable buffer of length \p length Bytes.
  *
  * \return                 \c 0 on success.
  * \return                 A negative error code on failure.