commit 8a1a43b1df095cd3515c84fc3b435fba579ab303
author Ron Eldor <Ron.Eldor@arm.com> Sun Oct 01 17:04:54 2017 +0300
committer Ron Eldor <Ron.Eldor@arm.com> Thu Jun 21 14:00:29 2018 +0300
tree 02b48f4feee0267ce10e228d088869aad974049e
parent e059b56ba2fd0ba2ddbb0f8653afa0f233cc01ad

Resolve PR review comments

Address review comments:
1. add `mbedtls_cipher_init()` after freeing context, in test code
2. style comments
3. set `ctx->iv_size = 0` in case `IV == NULL && iv_len == 0`

library/cipher.c

diff --git a/library/cipher.c b/library/cipher.c
index 3e89d2b..83df04c 100644
--- a/library/cipher.c
+++ b/library/cipher.c
@@ -201,6 +201,9 @@
     else if( NULL == iv && iv_len != 0  )
         return( MBEDTLS_ERR_CIPHER_BAD_INPUT_DATA );
 
+    if( NULL == iv && iv_len == 0 )
+        ctx->iv_size = 0;
+
     /* avoid buffer overflow in ctx->iv */
     if( iv_len > MBEDTLS_MAX_IV_LENGTH )
         return( MBEDTLS_ERR_CIPHER_FEATURE_UNAVAILABLE );
@@ -215,7 +218,7 @@
         if( actual_iv_size > iv_len )
             return( MBEDTLS_ERR_CIPHER_BAD_INPUT_DATA );
     }
-    if ( actual_iv_size )
+    if ( actual_iv_size != 0 )
     {
         memcpy( ctx->iv, iv, actual_iv_size );
         ctx->iv_size = actual_iv_size;

tests/suites/test_suite_cipher.function

diff --git a/tests/suites/test_suite_cipher.function b/tests/suites/test_suite_cipher.function
index 02802b8..343dd78 100644
--- a/tests/suites/test_suite_cipher.function
+++ b/tests/suites/test_suite_cipher.function
@@ -106,7 +106,7 @@
     mbedtls_cipher_init( &ctx );
     memset( input, 0, sizeof( input ) );
     memset( output, 0, sizeof( output ) );
-#if defined (MBEDTLS_CIPHER_MODE_CBC)
+#if defined(MBEDTLS_CIPHER_MODE_CBC)
     memset( iv, 0, sizeof( iv ) );
 
     /* Check and get info structures */
@@ -124,6 +124,7 @@
                  == MBEDTLS_ERR_CIPHER_BAD_INPUT_DATA );
 
     mbedtls_cipher_free( &ctx );
+    mbedtls_cipher_init( &ctx );
 #endif /* MBEDTLS_CIPHER_MODE_CBC */
     cipher_info = mbedtls_cipher_info_from_type( MBEDTLS_CIPHER_AES_128_ECB );
     TEST_ASSERT( NULL != cipher_info );