commit 88c2d227e47e39e977ae64157b2e04954e8bd412
author Brian J Murray <bmurray7jhu@gmail.com> Thu Jun 23 12:57:03 2016 -0700
committer Andres AG <andres.amayagarcia@arm.com> Mon Sep 05 14:05:55 2016 +0100
tree f37dc0d3e714330b7393295d347f55295c84c553
parent 541a960beee50852cd271c7a87f7af080c15e6f3

Fixed unchecked calls to mbedtls_md_setup in rsa.c (#502)

* Fixed unchecked calls to mbedtls_md_setup in rsa.c:

* style fixes

library/rsa.c

diff --git a/library/rsa.c b/library/rsa.c
index 119431d..1d48709 100644
--- a/library/rsa.c
+++ b/library/rsa.c
@@ -553,7 +553,11 @@
     memcpy( p, input, ilen );
 
     mbedtls_md_init( &md_ctx );
-    mbedtls_md_setup( &md_ctx, md_info, 0 );
+    if( ( ret = mbedtls_md_setup( &md_ctx, md_info, 0 ) ) != 0 )
+    {
+        mbedtls_md_free( &md_ctx );
+        return( ret );
+    }
 
     // maskedDB: Apply dbMask to DB
     //
@@ -728,7 +732,12 @@
      * Unmask data and generate lHash
      */
     mbedtls_md_init( &md_ctx );
-    mbedtls_md_setup( &md_ctx, md_info, 0 );
+    if( ( ret = mbedtls_md_setup( &md_ctx, md_info, 0 ) ) != 0 )
+    {
+        mbedtls_md_free( &md_ctx );
+        return( ret );
+    }
+
 
     /* Generate lHash */
     mbedtls_md( md_info, label, label_len, lhash );
@@ -974,7 +983,11 @@
     p += slen;
 
     mbedtls_md_init( &md_ctx );
-    mbedtls_md_setup( &md_ctx, md_info, 0 );
+    if( ( ret = mbedtls_md_setup( &md_ctx, md_info, 0 ) ) != 0 )
+    {
+        mbedtls_md_free( &md_ctx );
+        return( ret );
+    }
 
     // Generate H = Hash( M' )
     //
@@ -1247,7 +1260,11 @@
         return( MBEDTLS_ERR_RSA_BAD_INPUT_DATA );
 
     mbedtls_md_init( &md_ctx );
-    mbedtls_md_setup( &md_ctx, md_info, 0 );
+    if( ( ret = mbedtls_md_setup( &md_ctx, md_info, 0 ) ) != 0 )
+    {
+        mbedtls_md_free( &md_ctx );
+        return( ret );
+    }
 
     mgf_mask( p, siglen - hlen - 1, p + siglen - hlen - 1, hlen, &md_ctx );