commit 88a2264def143fc9d5b8705bb6aec188ec61061f
author Paul Bakker <p.j.bakker@polarssl.org> Wed Sep 11 12:14:16 2013 +0200
committer Paul Bakker <p.j.bakker@polarssl.org> Wed Sep 11 13:31:55 2013 +0200
tree 2366dd87ebfea0fcc48b72e9ac62aeb98dd0dd81
parent f65fbee52b3e76ad983d28c2a800defbeaef6ab0

Fixed potential file descriptor leaks

ChangeLog

diff --git a/ChangeLog b/ChangeLog
index 794bcf6..a420e6c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -6,6 +6,7 @@
 
 Bugfix
    * Fixed potential memory leak when failing to resume a session
+   * Fixed potential file descriptor leaks (found by Remi Gacogne)
    * Minor fixes
 
 Security

library/ctr_drbg.c

diff --git a/library/ctr_drbg.c b/library/ctr_drbg.c
index 8cf0371..2ff0b33 100644
--- a/library/ctr_drbg.c
+++ b/library/ctr_drbg.c
@@ -356,7 +356,10 @@
         return( POLARSSL_ERR_CTR_DRBG_FILE_IO_ERROR );
 
     if( ( ret = ctr_drbg_random( ctx, buf, CTR_DRBG_MAX_INPUT ) ) != 0 )
+    {
+        fclose( f );
         return( ret );
+    }
 
     if( fwrite( buf, 1, CTR_DRBG_MAX_INPUT, f ) != CTR_DRBG_MAX_INPUT )
     {
@@ -382,7 +385,10 @@
     fseek( f, 0, SEEK_SET );
 
     if( n > CTR_DRBG_MAX_INPUT )
+    {
+        fclose( f );
         return( POLARSSL_ERR_CTR_DRBG_INPUT_TOO_BIG );
+    }
 
     if( fread( buf, 1, n, f ) != n )
     {

library/x509parse.c

diff --git a/library/x509parse.c b/library/x509parse.c
index efde3f5..4b4be66 100644
--- a/library/x509parse.c
+++ b/library/x509parse.c
@@ -1967,7 +1967,10 @@
         i = stat( entry_name, &sb );
 
         if( i == -1 )
+        {
+            closedir( dir );
             return( POLARSSL_ERR_X509_FILE_IO_ERROR );
+        }
 
         if( !S_ISREG( sb.st_mode ) )
             continue;