commit 8663c7415a7970798345170f62002265a6bf26e9
author Gaurav Aggarwal <aggarg@amazon.com> Tue Apr 21 14:04:19 2020 -0700
committer Gaurav Aggarwal <aggarg@amazon.com> Tue Apr 21 14:04:19 2020 -0700
tree a654311f8db9580c337ad61eb6d7614fc7d4cdc6
parent 5cac33722878e51b764d571e40a627264f922b43

Remove error_description variable from strerr functions

This was suggested on this PR: https://github.com/ARMmbed/mbedtls/pull/3176

Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>

scripts/data_files/error.fmt

diff --git a/scripts/data_files/error.fmt b/scripts/data_files/error.fmt
index 0e128e8..e908aac 100644
--- a/scripts/data_files/error.fmt
+++ b/scripts/data_files/error.fmt
@@ -45,7 +45,6 @@
 const char * mbedtls_high_level_strerr( int error_code )
 {
     int high_level_error_code;
-    const char *error_description = NULL;
 
     if( error_code < 0 )
         error_code = -error_code;
@@ -63,13 +62,12 @@
             break;
     }
 
-    return error_description;
+    return NULL;
 }
 
 const char * mbedtls_low_level_strerr( int error_code )
 {
     int low_level_error_code;
-    const char *error_description = NULL;
 
     if( error_code < 0 )
         error_code = -error_code;
@@ -87,7 +85,7 @@
             break;
     }
 
-    return error_description;
+    return NULL;
 }
 
 void mbedtls_strerror( int ret, char *buf, size_t buflen )

scripts/generate_errors.pl

diff --git a/scripts/generate_errors.pl b/scripts/generate_errors.pl
index cb59669..5aef37a 100755
--- a/scripts/generate_errors.pl
+++ b/scripts/generate_errors.pl
@@ -161,8 +161,7 @@
     }
 
     ${$code_check} .= "${white_space}case -($error_name):\n".
-                      "${white_space}    error_description = \"$module_name - $description\";\n".
-                      "${white_space}    break;\n"
+                      "${white_space}    return \"$module_name - $description\";\n"
 };
 
 if ($ll_old_define ne "")