commit 862021a1189f50f6690f97b78af7897c7bce5574
author Valerio Setti <valerio.setti@nordicsemi.no> Tue Oct 24 13:52:06 2023 +0200
committer Valerio Setti <valerio.setti@nordicsemi.no> Fri Oct 27 09:13:33 2023 +0200
tree 54ea61af777c10cc2d3af6f19639e0631643f131
parent 5b4039f36dc27c65a442d941cb187bfa6081a730

all.sh: improve comments in common_test_full_no_cipher_with_psa_crypto

Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>

tests/scripts/all.sh

diff --git a/tests/scripts/all.sh b/tests/scripts/all.sh
index b337951..eb12a89 100755
--- a/tests/scripts/all.sh
+++ b/tests/scripts/all.sh
@@ -1532,7 +1532,10 @@
     scripts/config.py unset MBEDTLS_CIPHER_C
 
     if [ "$USE_CRYPTO_CONFIG" -eq 1 ]; then
-        # The built-in implementation of these modes currently depends on CIPHER_C
+        # The built-in implementation of the following algs/key-types depends
+        # on CIPHER_C so we disable them.
+        # This does not hold for KEY_TYPE_CHACHA20 and ALG_CHACHA20_POLY1305
+        # so we keep them enabled.
         scripts/config.py -f $CRYPTO_CONFIG_H unset PSA_WANT_ALG_CCM
         scripts/config.py -f $CRYPTO_CONFIG_H unset PSA_WANT_ALG_CCM_STAR_NO_TAG
         scripts/config.py -f $CRYPTO_CONFIG_H unset PSA_WANT_ALG_GCM
@@ -1562,7 +1565,7 @@
     scripts/config.py unset MBEDTLS_SSL_TLS_C
     scripts/config.py unset MBEDTLS_SSL_TICKET_C
     # Disable cipher modes/keys that make PSA depend on CIPHER_C.
-    # Keep CHACHA20 enabled since it does not depend on CIPHER_C.
+    # Keep CHACHA20 and CHACHAPOLY enabled since they do not depend on CIPHER_C.
     scripts/config.py unset-all MBEDTLS_CIPHER_MODE
     scripts/config.py unset MBEDTLS_AES_C
     scripts/config.py unset MBEDTLS_DES_C