commit 80c8786bfccd360ed4435dc4e96bfce1c391d7fe
author Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Thu Jan 28 17:48:19 2016 +0100
committer Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Fri Jan 29 15:02:41 2016 +0100
tree 41dcf4fd12e97484caf63538a39c90712cb186f6
parent 187ba489afb237c012c972ad8b6cfcd387306ac8

x509: factor common code to a function

library/x509_crt.c

diff --git a/library/x509_crt.c b/library/x509_crt.c
index d045cfe..f1b750c 100644
--- a/library/x509_crt.c
+++ b/library/x509_crt.c
@@ -1796,16 +1796,26 @@
 }
 
 /*
- * Return 0 if name matches wildcard, -1 otherwise
+ * Return 0 if names matche as DNS names (inc. wildcard),
+ * -1 otherwise
  */
-static int x509_check_wildcard( const char *exp_name,
+static int x509_check_dns_name( const char *exp_name,
+                                size_t exp_len,
                                 const mbedtls_x509_buf *name )
 {
     size_t i;
-    size_t idx = 0, exp_len = strlen( exp_name );
+    size_t idx = 0;
 
-    if( name->len < 3 || name->p[0] != '*' || name->p[1] != '.' )
+    /* First check if the names are equal */
+    if( name->len == exp_len &&
+        x509_memcasecmp( exp_name, name->p, exp_len ) == 0 )
+    {
         return( 0 );
+    }
+
+    /* Now try a wildcard match */
+    if( name->len < 3 || name->p[0] != '*' || name->p[1] != '.' )
+        return( -1 );
 
     for( i = 0; i < exp_len; ++i )
     {
@@ -2233,18 +2243,8 @@
 
         while( cur != NULL )
         {
-            if( cur->buf.len == exp_len &&
-                x509_memcasecmp( exp_name, cur->buf.p, exp_len ) == 0 )
-            {
+            if( x509_check_dns_name( exp_name, exp_len, &cur->buf ) == 0 )
                 return( 0 );
-            }
-
-            if( cur->buf.len > 2 &&
-                memcmp( cur->buf.p, "*.", 2 ) == 0 &&
-                x509_check_wildcard( exp_name, &cur->buf ) == 0 )
-            {
-                return( 0 );
-            }
 
             cur = cur->next;
         }
@@ -2257,18 +2257,8 @@
         {
             if( MBEDTLS_OID_CMP( MBEDTLS_OID_AT_CN, &name->oid ) == 0 )
             {
-                if( name->val.len == exp_len &&
-                    x509_memcasecmp( name->val.p, exp_name, exp_len ) == 0 )
-                {
+                if( x509_check_dns_name( exp_name, exp_len, &name->val ) == 0 )
                     return( 0 );
-                }
-
-                if( name->val.len > 2 &&
-                    memcmp( name->val.p, "*.", 2 ) == 0 &&
-                    x509_check_wildcard( exp_name, &name->val ) == 0 )
-                {
-                    return( 0 );
-                }
             }
 
             name = name->next;