commit 7fd620b331970e5db9f6721470c4f4f57de73fa6
author Manuel Pégourié-Gonnard <mpg@elzevir.fr> Sat Jan 18 19:05:23 2014 +0100
committer Paul Bakker <p.j.bakker@polarssl.org> Mon Jul 07 16:01:31 2014 +0200
tree 98f208943d04f1b8170d26bb4472e2a7333ca976
parent b55f5789827e825a05b8df4ba01ee8313321a5db

Fix misplaced initialisation.

If one of the calls to mpi_grow() before setting Apos would fail, then
mpi_free( &Apos ) would be executed without Apos being initialised.

library/bignum.c

diff --git a/library/bignum.c b/library/bignum.c
index 23a3f68..c26842f 100644
--- a/library/bignum.c
+++ b/library/bignum.c
@@ -1410,6 +1410,7 @@
      */
     mpi_montg_init( &mm, N );
     mpi_init( &RR ); mpi_init( &T );
+    mpi_init( &Apos );
     memset( W, 0, sizeof( W ) );
 
     i = mpi_msb( E );
@@ -1429,8 +1430,6 @@
      * Compensate for negative A (and correct at the end)
      */
     neg = ( A->s == -1 );
-
-    mpi_init( &Apos );
     if( neg )
     {
         MPI_CHK( mpi_copy( &Apos, A ) );