commit 788db112a5b85d9cdbf5c30323482a26bd52b3a7
author Manuel Pégourié-Gonnard <mpg@elzevir.fr> Tue Jul 09 11:26:17 2013 +0200
committer Paul Bakker <p.j.bakker@polarssl.org> Wed Jul 17 15:59:39 2013 +0200
tree 48e99c4d42714c75344a84d8f35dbda227c40d02
parent 374e4b87d43c81ca0c869445bd43454376cc6478

Get rid of x509_cert.pkoid

Unused, comment did not match reality, and will soon be superseeded by the
'type' field of the pk_context which will replace rsa_context.

library/x509parse.c

diff --git a/library/x509parse.c b/library/x509parse.c
index c801967..813158d 100644
--- a/library/x509parse.c
+++ b/library/x509parse.c
@@ -545,21 +545,21 @@
  */
 static int x509_get_pubkey( unsigned char **p,
                             const unsigned char *end,
-                            x509_buf *pk_alg_oid,
                             mpi *N, mpi *E )
 {
     int ret;
     size_t len;
+    x509_buf pk_alg_oid;
     unsigned char *end2;
     pk_type_t pk_alg = POLARSSL_PK_NONE;
 
-    if( ( ret = asn1_get_alg_null( p, end, pk_alg_oid ) ) != 0 )
+    if( ( ret = asn1_get_alg_null( p, end, &pk_alg_oid ) ) != 0 )
         return( POLARSSL_ERR_X509_CERT_INVALID_PUBKEY + ret );
 
     /*
      * only RSA public keys handled at this time
      */
-    if( oid_get_pk_alg( pk_alg_oid, &pk_alg ) != 0 )
+    if( oid_get_pk_alg( &pk_alg_oid, &pk_alg ) != 0 )
     {
         return( POLARSSL_ERR_X509_UNKNOWN_PK_ALG );
     }
@@ -1377,7 +1377,7 @@
         return( POLARSSL_ERR_X509_CERT_INVALID_FORMAT + ret );
     }
 
-    if( ( ret = x509_get_pubkey( &p, p + len, &crt->pk_oid,
+    if( ( ret = x509_get_pubkey( &p, p + len,
                                  &crt->rsa.N, &crt->rsa.E ) ) != 0 )
     {
         x509_free( crt );
@@ -2585,7 +2585,6 @@
     int ret;
     size_t len;
     unsigned char *p, *end;
-    x509_buf alg_oid;
 #if defined(POLARSSL_PEM_C)
     pem_context pem;
 
@@ -2641,7 +2640,7 @@
         return( POLARSSL_ERR_X509_CERT_INVALID_FORMAT + ret );
     }
 
-    if( ( ret = x509_get_pubkey( &p, end, &alg_oid, &rsa->N, &rsa->E ) ) != 0 )
+    if( ( ret = x509_get_pubkey( &p, end, &rsa->N, &rsa->E ) ) != 0 )
     {
 #if defined(POLARSSL_PEM_C)
         pem_free( &pem );