commit 74a137817573c1a358a28a3dcc0ee04361e77142
author Manuel Pégourié-Gonnard <mpg@elzevir.fr> Tue Oct 14 22:34:08 2014 +0200
committer Paul Bakker <p.j.bakker@polarssl.org> Tue Oct 21 16:32:56 2014 +0200
tree 46d2856851f2a85d268dad3490c51d04515718d4
parent 8e704f0f74e77dbcd74d0031a094bb5f5bfaa189

Avoid false positive in ssl-opt.sh with memcheck

library/ssl_tls.c

diff --git a/library/ssl_tls.c b/library/ssl_tls.c
index bfaefd4..67aaa98 100644
--- a/library/ssl_tls.c
+++ b/library/ssl_tls.c
@@ -3199,7 +3199,7 @@
             ssl->next_record_offset = 0;
             ssl->in_left = 0;
 
-            SSL_DEBUG_MSG( 1, ( "discarding invalid record" ) );
+            SSL_DEBUG_MSG( 1, ( "discarding invalid record (header)" ) );
             goto read_record_header;
         }
 #endif
@@ -3242,7 +3242,7 @@
                 }
 #endif
 
-                SSL_DEBUG_MSG( 1, ( "discarding invalid record" ) );
+                SSL_DEBUG_MSG( 1, ( "discarding invalid record (mac)" ) );
                 goto read_record_header;
             }
 

tests/ssl-opt.sh

diff --git a/tests/ssl-opt.sh b/tests/ssl-opt.sh
index f0560ef..ac78b1f 100755
--- a/tests/ssl-opt.sh
+++ b/tests/ssl-opt.sh
@@ -266,6 +266,7 @@
 
     if echo "$NAME" | grep "$FILTER" | grep -v "$EXCLUDE" >/dev/null; then :
     else
+        SKIP_NEXT="NO"
         return
     fi
 
@@ -2255,8 +2256,8 @@
             "$P_SRV dtls=1 debug_level=1" \
             "$P_CLI dtls=1 debug_level=1 read_timeout=100" \
             0 \
-            -c "discarding invalid record" \
-            -s "discarding invalid record" \
+            -c "discarding invalid record (mac)" \
+            -s "discarding invalid record (mac)" \
             -s "Extra-header:" \
             -c "HTTP/1.0 200 OK" \
             -S "too many records with bad MAC" \
@@ -2267,8 +2268,8 @@
             "$P_SRV dtls=1 debug_level=1 badmac_limit=1" \
             "$P_CLI dtls=1 debug_level=1 read_timeout=100" \
             1 \
-            -C "discarding invalid record" \
-            -S "discarding invalid record" \
+            -C "discarding invalid record (mac)" \
+            -S "discarding invalid record (mac)" \
             -S "Extra-header:" \
             -C "HTTP/1.0 200 OK" \
             -s "too many records with bad MAC" \
@@ -2279,8 +2280,8 @@
             "$P_SRV dtls=1 debug_level=1 badmac_limit=2" \
             "$P_CLI dtls=1 debug_level=1 read_timeout=100" \
             0 \
-            -c "discarding invalid record" \
-            -s "discarding invalid record" \
+            -c "discarding invalid record (mac)" \
+            -s "discarding invalid record (mac)" \
             -s "Extra-header:" \
             -c "HTTP/1.0 200 OK" \
             -S "too many records with bad MAC" \
@@ -2291,8 +2292,8 @@
             "$P_SRV dtls=1 debug_level=1 badmac_limit=2 exchanges=2" \
             "$P_CLI dtls=1 debug_level=1 read_timeout=100 exchanges=2" \
             1 \
-            -c "discarding invalid record" \
-            -s "discarding invalid record" \
+            -c "discarding invalid record (mac)" \
+            -s "discarding invalid record (mac)" \
             -s "Extra-header:" \
             -c "HTTP/1.0 200 OK" \
             -s "too many records with bad MAC" \