commit 656b2595fba43254cc9366bd370b38100b9d39c3
author Przemek Stekiel <przemyslaw.stekiel@mobica.com> Wed Mar 22 13:15:33 2023 +0100
committer Przemek Stekiel <przemyslaw.stekiel@mobica.com> Thu Mar 23 08:05:52 2023 +0100
tree 426d21e19689de3f200af3e9e7dd189bf428e073
parent 3543806026f86ce58a5eca4e3aa015acc395d28d

psa_pake_input: validate buffer size using PSA_PAKE_INPUT_SIZE

Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>

include/psa/crypto_extra.h

diff --git a/include/psa/crypto_extra.h b/include/psa/crypto_extra.h
index 4920508..0e2d57c 100644
--- a/include/psa/crypto_extra.h
+++ b/include/psa/crypto_extra.h
@@ -1960,7 +1960,7 @@
 /** Returns a suitable initializer for a PAKE operation object of type
  * psa_pake_operation_t.
  */
-#define PSA_PAKE_OPERATION_INIT { 0, PSA_ALG_NONE, PSA_PAKE_OPERATION_STAGE_SETUP, \
+#define PSA_PAKE_OPERATION_INIT { 0, PSA_ALG_NONE, 0, PSA_PAKE_OPERATION_STAGE_SETUP, \
                                   { 0 }, { { 0 } } }
 
 struct psa_pake_cipher_suite_s {
@@ -2106,6 +2106,8 @@
     unsigned int MBEDTLS_PRIVATE(id);
     /* Algorithm of the PAKE operation */
     psa_algorithm_t MBEDTLS_PRIVATE(alg);
+    /* A primitive of type compatible with algorithm */
+    psa_pake_primitive_t MBEDTLS_PRIVATE(primitive);
     /* Stage of the PAKE operation: waiting for the setup, collecting inputs
      * or computing. */
     uint8_t MBEDTLS_PRIVATE(stage);

library/psa_crypto.c

diff --git a/library/psa_crypto.c b/library/psa_crypto.c
index bc19ed0..049edfc 100644
--- a/library/psa_crypto.c
+++ b/library/psa_crypto.c
@@ -7323,6 +7323,8 @@
     memset(&operation->data.inputs, 0, sizeof(operation->data.inputs));
 
     operation->alg = cipher_suite->algorithm;
+    operation->primitive = PSA_PAKE_PRIMITIVE(cipher_suite->type,
+                                              cipher_suite->family, cipher_suite->bits);
     operation->data.inputs.cipher_suite = *cipher_suite;
 
 #if defined(PSA_WANT_ALG_JPAKE)
@@ -7920,7 +7922,9 @@
         goto exit;
     }
 
-    if (input_length == 0 || input_length > PSA_PAKE_INPUT_MAX_SIZE) {
+    if (input_length == 0 || input_length > PSA_PAKE_INPUT_SIZE(operation->alg,
+                                                                operation->primitive,
+                                                                step)) {
         status = PSA_ERROR_INVALID_ARGUMENT;
         goto exit;
     }