commit 64937856e07a7fc611bfd48ce30e8abd0e727406
author Dave Rodgman <dave.rodgman@arm.com> Mon Aug 15 14:12:25 2022 +0100
committer Dave Rodgman <dave.rodgman@arm.com> Tue Aug 30 10:25:45 2022 +0100
tree bdeeb69802eb81da7ce9017b1c6b68bc92ac0ddf
parent 18b02d35d625967d6a3ce8cc034289cc75d6b04a

Correct order of extended key usage attributes

Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>

programs/x509/cert_write.c

diff --git a/programs/x509/cert_write.c b/programs/x509/cert_write.c
index d1c716b..2f51e19 100644
--- a/programs/x509/cert_write.c
+++ b/programs/x509/cert_write.c
@@ -445,13 +445,14 @@
         }
         else if( strcmp( p, "ext_key_usage" ) == 0 )
         {
+            mbedtls_asn1_sequence **tail = &opt.ext_key_usage;
+
             while( q != NULL )
             {
                 if( ( r = strchr( q, ',' ) ) != NULL )
                     *r++ = '\0';
 
                 ext_key_usage = mbedtls_calloc( 1, sizeof(mbedtls_asn1_sequence) );
-                ext_key_usage->next = opt.ext_key_usage;
                 ext_key_usage->buf.tag = MBEDTLS_ASN1_OID;
                 if( strcmp( q, "serverAuth" ) == 0 )
                     SET_OID( ext_key_usage->buf, MBEDTLS_OID_SERVER_AUTH );
@@ -467,7 +468,9 @@
                     SET_OID( ext_key_usage->buf, MBEDTLS_OID_OCSP_SIGNING );
                 else
                     goto usage;
-                opt.ext_key_usage = ext_key_usage;
+
+                *tail = ext_key_usage;
+                tail = &ext_key_usage->next;
 
                 q = r;
             }