commit 59c6f2ef21b7c9fabd1c7e4eb4101530a78b97b1
author Manuel Pégourié-Gonnard <mpg@elzevir.fr> Thu Jan 22 11:06:40 2015 +0000
committer Manuel Pégourié-Gonnard <mpg@elzevir.fr> Thu Jan 22 11:06:40 2015 +0000
tree 86ba1c4a3ff87247087e85f6a1c2314316a66d06
parent 5d9cde25da079f82bd8f1cedbf900504c6b7a067

Avoid nested if's without braces.

Creates a potential for confusing code if we later want to add an else clause.

library/ssl_cli.c

diff --git a/library/ssl_cli.c b/library/ssl_cli.c
index 95699b4..c3729ee 100644
--- a/library/ssl_cli.c
+++ b/library/ssl_cli.c
@@ -605,16 +605,18 @@
      */
 #if defined(POLARSSL_SSL_RENEGOTIATION)
     if( ssl->renegotiation == SSL_INITIAL_HANDSHAKE )
-#endif
-    if( ssl->session_negotiate->ticket != NULL &&
-        ssl->session_negotiate->ticket_len != 0 )
     {
-        ret = ssl->f_rng( ssl->p_rng, ssl->session_negotiate->id, 32 );
+#endif
+        if( ssl->session_negotiate->ticket != NULL &&
+                ssl->session_negotiate->ticket_len != 0 )
+        {
+            ret = ssl->f_rng( ssl->p_rng, ssl->session_negotiate->id, 32 );
 
-        if( ret != 0 )
-            return( ret );
+            if( ret != 0 )
+                return( ret );
 
-        ssl->session_negotiate->length = n = 32;
+            ssl->session_negotiate->length = n = 32;
+        }
     }
 #endif /* POLARSSL_SSL_SESSION_TICKETS */
 

library/ssl_srv.c

diff --git a/library/ssl_srv.c b/library/ssl_srv.c
index 0b947ba..138d1f9 100644
--- a/library/ssl_srv.c
+++ b/library/ssl_srv.c
@@ -1248,10 +1248,12 @@
 #if defined(POLARSSL_SSL_RENEGOTIATION)
     if( ssl->renegotiation == SSL_INITIAL_HANDSHAKE )
 #endif
-    if( ( ret = ssl_fetch_input( ssl, 5 ) ) != 0 )
     {
-        SSL_DEBUG_RET( 1, "ssl_fetch_input", ret );
-        return( ret );
+        if( ( ret = ssl_fetch_input( ssl, 5 ) ) != 0 )
+        {
+            SSL_DEBUG_RET( 1, "ssl_fetch_input", ret );
+            return( ret );
+        }
     }
 
     buf = ssl->in_hdr;
@@ -1301,10 +1303,12 @@
 #if defined(POLARSSL_SSL_RENEGOTIATION)
     if( ssl->renegotiation == SSL_INITIAL_HANDSHAKE )
 #endif
-    if( ( ret = ssl_fetch_input( ssl, 5 + n ) ) != 0 )
     {
-        SSL_DEBUG_RET( 1, "ssl_fetch_input", ret );
-        return( ret );
+        if( ( ret = ssl_fetch_input( ssl, 5 + n ) ) != 0 )
+        {
+            SSL_DEBUG_RET( 1, "ssl_fetch_input", ret );
+            return( ret );
+        }
     }
 
     buf = ssl->in_msg;