commit 541af8575ea00cd95c405937de0e81c2efb4b8bd
author Hanno Becker <hanno.becker@arm.com> Fri May 14 16:49:01 2021 +0100
committer Hanno Becker <hanno.becker@arm.com> Fri May 14 16:49:01 2021 +0100
tree 2bc56d2f38e68884e2bc81a8ce3375c71066eb2f
parent 3268d84313e16297b4f21ab251d5c5436e72d04c

Use -1 instead of 1 as failure return value in internal SSL function

Signed-off-by: Hanno Becker <hanno.becker@arm.com>

library/ssl_tls.c

diff --git a/library/ssl_tls.c b/library/ssl_tls.c
index fd77dc3..1c54b5f 100644
--- a/library/ssl_tls.c
+++ b/library/ssl_tls.c
@@ -6999,14 +6999,14 @@
 {
 #if defined(MBEDTLS_SSL_PROTO_TLS1_2)
     if( ssl->minor_ver != MBEDTLS_SSL_MINOR_VERSION_3 )
-        return( 1 );
+        return( -1 );
 
     switch( md )
     {
 #if defined(MBEDTLS_SSL_PROTO_TLS1) || defined(MBEDTLS_SSL_PROTO_TLS1_1)
 #if defined(MBEDTLS_MD5_C)
         case MBEDTLS_SSL_HASH_MD5:
-            return( 1 );
+            return( -1 );
 #endif
 #if defined(MBEDTLS_SHA1_C)
         case MBEDTLS_SSL_HASH_SHA1:
@@ -7025,7 +7025,7 @@
             break;
 #endif
         default:
-            return( 1 );
+            return( -1 );
     }
 
     return 0;
@@ -7033,7 +7033,7 @@
     (void) ssl;
     (void) md;
 
-    return( 1 );
+    return( -1 );
 #endif /* MBEDTLS_SSL_PROTO_TLS1_2 */
 }