commit 507e1e410aeeee30b38bc4926b0853b0720687e9
author Manuel Pégourié-Gonnard <mpg@elzevir.fr> Thu Feb 13 11:17:34 2014 +0100
committer Paul Bakker <p.j.bakker@polarssl.org> Tue Oct 21 16:30:06 2014 +0200
tree fcc25517332ce1e056b4d3ff237b2ef0e989e4a3
parent 7ee6f0e6e526660fbe0330c6d414ebca1397372e

Prep: allow {in,out}_len != {in,out}_hdr + 3

library/ssl_srv.c

diff --git a/library/ssl_srv.c b/library/ssl_srv.c
index 0d07b36..617db9d 100644
--- a/library/ssl_srv.c
+++ b/library/ssl_srv.c
@@ -1147,13 +1147,13 @@
         return ssl_parse_client_hello_v2( ssl );
 #endif
 
-    SSL_DEBUG_BUF( 4, "record header", buf, 5 );
+    SSL_DEBUG_BUF( 4, "record header", buf, 5 ); // TODO: 13 for DTLS
 
     SSL_DEBUG_MSG( 3, ( "client hello v3, message type: %d",
                    buf[0] ) );
     SSL_DEBUG_MSG( 3, ( "client hello v3, message len.: %d",
-                   ( buf[3] << 8 ) | buf[4] ) );
-    SSL_DEBUG_MSG( 3, ( "client hello v3, protocol ver: [%d:%d]",
+                   ( ssl->in_len[0] << 8 ) | ssl->in_len[1] ) );
+    SSL_DEBUG_MSG( 3, ( "client hello v3, protocol version: [%d:%d]",
                    buf[1], buf[2] ) );
 
     /*
@@ -1182,7 +1182,7 @@
         return( POLARSSL_ERR_SSL_BAD_HS_CLIENT_HELLO );
     }
 
-    n = ( buf[3] << 8 ) | buf[4];
+    n = ( ssl->in_len[0] << 8 ) | ssl->in_len[1];
 
     if( n < 45 || n > SSL_MAX_CONTENT_LEN )
     {

library/ssl_tls.c

diff --git a/library/ssl_tls.c b/library/ssl_tls.c
index 381a0e3..58fb306 100644
--- a/library/ssl_tls.c
+++ b/library/ssl_tls.c
@@ -1607,8 +1607,8 @@
 
         ssl->in_msglen -= ( ssl->transform_in->maclen + padlen );
 
-        ssl->in_hdr[3] = (unsigned char)( ssl->in_msglen >> 8 );
-        ssl->in_hdr[4] = (unsigned char)( ssl->in_msglen      );
+        ssl->in_len[0] = (unsigned char)( ssl->in_msglen >> 8 );
+        ssl->in_len[1] = (unsigned char)( ssl->in_msglen      );
 
         memcpy( tmp, ssl->in_msg + ssl->in_msglen, ssl->transform_in->maclen );
 
@@ -1941,8 +1941,9 @@
         ssl->out_hdr[0] = (unsigned char) ssl->out_msgtype;
         ssl_write_version( ssl->major_ver, ssl->minor_ver,
                            ssl->transport, ssl->out_hdr + 1 );
-        ssl->out_hdr[3] = (unsigned char)( len >> 8 );
-        ssl->out_hdr[4] = (unsigned char)( len      );
+
+        ssl->out_len[0] = (unsigned char)( len >> 8 );
+        ssl->out_len[1] = (unsigned char)( len      );
 
         if( ssl->transform_out != NULL )
         {
@@ -1953,8 +1954,8 @@
             }
 
             len = ssl->out_msglen;
-            ssl->out_hdr[3] = (unsigned char)( len >> 8 );
-            ssl->out_hdr[4] = (unsigned char)( len      );
+            ssl->out_len[0] = (unsigned char)( len >> 8 );
+            ssl->out_len[1] = (unsigned char)( len      );
         }
 
         ssl->out_left = 5 + ssl->out_msglen;
@@ -1962,7 +1963,7 @@
         SSL_DEBUG_MSG( 3, ( "output record: msgtype = %d, "
                             "version = [%d:%d], msglen = %d",
                        ssl->out_hdr[0], ssl->out_hdr[1], ssl->out_hdr[2],
-                     ( ssl->out_hdr[3] << 8 ) | ssl->out_hdr[4] ) );
+                     ( ssl->out_len[0] << 8 ) | ssl->out_len[1] ) );
 
         SSL_DEBUG_BUF( 4, "output record sent to network",
                        ssl->out_hdr, 5 + ssl->out_msglen );
@@ -2034,12 +2035,12 @@
     }
 
     ssl->in_msgtype =  ssl->in_hdr[0];
-    ssl->in_msglen = ( ssl->in_hdr[3] << 8 ) | ssl->in_hdr[4];
+    ssl->in_msglen = ( ssl->in_len[0] << 8 ) | ssl->in_len[1];
 
     SSL_DEBUG_MSG( 3, ( "input record: msgtype = %d, "
                         "version = [%d:%d], msglen = %d",
                      ssl->in_hdr[0], ssl->in_hdr[1], ssl->in_hdr[2],
-                   ( ssl->in_hdr[3] << 8 ) | ssl->in_hdr[4] ) );
+                   ( ssl->in_len[0] << 8 ) | ssl->in_len[1] ) );
 
     ssl_read_version( &major_ver, &minor_ver, ssl->transport, ssl->in_hdr + 1 );
 
@@ -2170,8 +2171,9 @@
             return( ret );
         }
 
-        ssl->in_hdr[3] = (unsigned char)( ssl->in_msglen >> 8 );
-        ssl->in_hdr[4] = (unsigned char)( ssl->in_msglen      );
+        // TODO: what's the purpose of these lines? is in_len used?
+        ssl->in_len[0] = (unsigned char)( ssl->in_msglen >> 8 );
+        ssl->in_len[1] = (unsigned char)( ssl->in_msglen      );
     }
 #endif /* POLARSSL_ZLIB_SUPPORT */