commit 4fe9200f471a5fa47900418eaf41b8f7535dfbc4
author Manuel Pégourié-Gonnard <mpg@elzevir.fr> Fri Sep 13 13:45:58 2013 +0200
committer Manuel Pégourié-Gonnard <mpg@elzevir.fr> Fri Sep 13 13:45:58 2013 +0200
tree b65e8507c5c194f9975cf227c4b0b2c281186e3c
parent deb7949a2282866787fc28c187c256606c6c6d3d

Fix memory leak in GCM by adding gcm_free()

include/polarssl/gcm.h

diff --git a/include/polarssl/gcm.h b/include/polarssl/gcm.h
index 1997c4b..4662f97 100644
--- a/include/polarssl/gcm.h
+++ b/include/polarssl/gcm.h
@@ -198,6 +198,13 @@
                 size_t tag_len );
 
 /**
+ * \brief           Free a GCM context and underlying cipher sub-context
+ *
+ * \param ctx
+ */
+void gcm_free( gcm_context *ctx );
+
+/**
  * \brief          Checkup routine
  *
  * \return         0 if successful, or 1 if the test failed

library/cipher_wrap.c

diff --git a/library/cipher_wrap.c b/library/cipher_wrap.c
index 862328f..c6f52ff 100644
--- a/library/cipher_wrap.c
+++ b/library/cipher_wrap.c
@@ -295,6 +295,7 @@
 
 static void gcm_ctx_free( void *ctx )
 {
+    gcm_free( ctx );
     polarssl_free( ctx );
 }
 

library/gcm.c

diff --git a/library/gcm.c b/library/gcm.c
index 1dfc199..04e9d5b 100644
--- a/library/gcm.c
+++ b/library/gcm.c
@@ -406,6 +406,12 @@
     return( 0 );
 }
 
+void gcm_free( gcm_context *ctx )
+{
+    (void) cipher_free_ctx( &ctx->cipher_ctx );
+    memset( ctx, 0, sizeof( gcm_context ) );
+}
+
 #if defined(POLARSSL_SELF_TEST)
 
 #include <stdio.h>
@@ -672,6 +678,8 @@
                 return( 1 );
             }
 
+            gcm_free( &ctx );
+
             if( verbose != 0 )
                 printf( "passed\n" );
 
@@ -696,6 +704,8 @@
                 return( 1 );
             }
 
+            gcm_free( &ctx );
+
             if( verbose != 0 )
                 printf( "passed\n" );
 
@@ -759,6 +769,8 @@
                 return( 1 );
             }
 
+            gcm_free( &ctx );
+
             if( verbose != 0 )
                 printf( "passed\n" );
 
@@ -822,6 +834,8 @@
                 return( 1 );
             }
 
+            gcm_free( &ctx );
+
             if( verbose != 0 )
                 printf( "passed\n" );
 
@@ -834,6 +848,8 @@
     return( 0 );
 }
 
+
+
 #endif
 
 #endif

tests/suites/test_suite_gcm.function

diff --git a/tests/suites/test_suite_gcm.function b/tests/suites/test_suite_gcm.function
index c9cc177..58de577 100644
--- a/tests/suites/test_suite_gcm.function
+++ b/tests/suites/test_suite_gcm.function
@@ -49,6 +49,8 @@
         TEST_ASSERT( strcmp( (char *) dst_str, hex_dst_string ) == 0 );
         TEST_ASSERT( strcmp( (char *) tag_str, hex_tag_string ) == 0 );
     }
+
+    gcm_free( &ctx );
 }
 /* END_CASE */
 
@@ -101,6 +103,8 @@
             TEST_ASSERT( strcmp( (char *) dst_str, pt_result ) == 0 );
         }
     }
+
+    gcm_free( &ctx );
 }
 /* END_CASE */