commit 4a28563e84946423ea1ae6c67d9de918d68b3708
author David Horstmann <david.horstmann@arm.com> Thu Oct 06 18:30:10 2022 +0100
committer David Horstmann <david.horstmann@arm.com> Fri Oct 07 14:08:42 2022 +0100
tree a2fd7b7e60988bc0fcbf001d0f3fca33f0873c35
parent e0af39a2efd4463dd01cc37baa68b0db6514ea56

Refactor macro-spanning ifs in ssl_client.c

Signed-off-by: David Horstmann <david.horstmann@arm.com>

library/ssl_client.c

diff --git a/library/ssl_client.c b/library/ssl_client.c
index e7453d5..08cb342 100644
--- a/library/ssl_client.c
+++ b/library/ssl_client.c
@@ -376,9 +376,11 @@
     /*
      * Add TLS_EMPTY_RENEGOTIATION_INFO_SCSV
      */
+    int renegotiating = 0;
 #if defined(MBEDTLS_SSL_RENEGOTIATION)
-    if( ssl->renego_status == MBEDTLS_SSL_INITIAL_HANDSHAKE )
+    renegotiating = ( ssl->renego_status != MBEDTLS_SSL_INITIAL_HANDSHAKE );
 #endif
+    if( !renegotiating )
     {
         MBEDTLS_SSL_DEBUG_MSG( 3, ( "adding EMPTY_RENEGOTIATION_INFO_SCSV" ) );
         MBEDTLS_SSL_CHK_BUF_PTR( p, end, 2 );
@@ -790,9 +792,11 @@
      * RFC 5077 section 3.4: "When presenting a ticket, the client MAY
      * generate and include a Session ID in the TLS ClientHello."
      */
+        int renegotiating = 0;
 #if defined(MBEDTLS_SSL_RENEGOTIATION)
-        if( ssl->renego_status == MBEDTLS_SSL_INITIAL_HANDSHAKE )
+        renegotiating = ( ssl->renego_status != MBEDTLS_SSL_INITIAL_HANDSHAKE );
 #endif
+        if( !renegotiating )
         {
             if( ( ssl->session_negotiate->ticket != NULL ) &&
                 ( ssl->session_negotiate->ticket_len != 0 ) )