commit 3050f054f23e1f1b8e23df6d7593aa97848e6159
author Mateusz Starzyk <mateusz.starzyk@mobica.com> Thu Sep 02 12:38:51 2021 +0200
committer Mateusz Starzyk <mateusz.starzyk@mobica.com> Fri Sep 03 12:59:44 2021 +0200
tree 43b46c0fa5661c9dcd2c79d30c47844b60f7a2c2
parent df2507301b12e9247cad8dbb94e5bee144ed8ec0

Subtract 1 from input in CCM's incomplete data tests

Signed-off-by: Mateusz Starzyk <mateusz.starzyk@mobica.com>

tests/suites/test_suite_ccm.function

diff --git a/tests/suites/test_suite_ccm.function b/tests/suites/test_suite_ccm.function
index 128bd86..57f13e3 100644
--- a/tests/suites/test_suite_ccm.function
+++ b/tests/suites/test_suite_ccm.function
@@ -533,8 +533,8 @@
     TEST_EQUAL( mbedtls_ccm_setkey( &ctx, cipher_id, key->x, key->len * 8 ), 0 );
     TEST_EQUAL( 0, mbedtls_ccm_starts( &ctx, mode, iv->x, iv->len ) );
     // use hardcoded values for msg length and tag length. They are not a part of this test
-    // set half of auth data length to provoke an overflow
-    TEST_EQUAL( 0, mbedtls_ccm_set_lengths( &ctx, add->len / 2, 16, 16 ) );
+    // subtract 1 from configured auth data length to provoke an overflow
+    TEST_EQUAL( 0, mbedtls_ccm_set_lengths( &ctx, add->len - 1, 16, 16 ) );
 
     TEST_EQUAL( MBEDTLS_ERR_CCM_BAD_INPUT, mbedtls_ccm_update_ad( &ctx, add->x, add->len) );
 exit:
@@ -556,7 +556,7 @@
     // use hardcoded values for msg length and tag length. They are not a part of this test
     TEST_EQUAL( 0, mbedtls_ccm_set_lengths( &ctx, add->len, 0, 16 ) );
 
-    TEST_EQUAL( 0, mbedtls_ccm_update_ad( &ctx, add->x, add->len/2) );
+    TEST_EQUAL( 0, mbedtls_ccm_update_ad( &ctx, add->x, add->len - 1) );
 
     ASSERT_ALLOC( output, 16 );
     TEST_EQUAL( MBEDTLS_ERR_CCM_BAD_INPUT, mbedtls_ccm_finish( &ctx, output, 16 ) );
@@ -605,8 +605,8 @@
     TEST_EQUAL( mbedtls_ccm_setkey( &ctx, cipher_id, key->x, key->len * 8 ), 0 );
     TEST_EQUAL( 0, mbedtls_ccm_starts( &ctx, mode, iv->x, iv->len ) );
     // use hardcoded value for tag length. It is a not a part of this test
-    // set half of msg length to provoke an overflow
-    TEST_EQUAL( 0, mbedtls_ccm_set_lengths( &ctx, add->len, msg->len / 2, 16 ) );
+    // subtract 1 from configured msg length to provoke an overflow
+    TEST_EQUAL( 0, mbedtls_ccm_set_lengths( &ctx, add->len, msg->len - 1, 16 ) );
 
     TEST_EQUAL( 0, mbedtls_ccm_update_ad( &ctx, add->x, add->len) );
 
@@ -639,7 +639,7 @@
 
     ASSERT_ALLOC( output, msg->len );
     olen = 0xdeadbeef;
-    TEST_EQUAL( 0, mbedtls_ccm_update( &ctx, msg->x, msg->len/2, output, msg->len, &olen ) );
+    TEST_EQUAL( 0, mbedtls_ccm_update( &ctx, msg->x, msg->len - 1, output, msg->len, &olen ) );
     mbedtls_free( output );
     output = NULL;